[INFO] crate scan_fmt 0.1.3 is already in cache [INFO] extracting crate scan_fmt 0.1.3 into work/ex/clippy-test-run/sources/stable/reg/scan_fmt/0.1.3 [INFO] extracting crate scan_fmt 0.1.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/scan_fmt/0.1.3 [INFO] validating manifest of scan_fmt-0.1.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of scan_fmt-0.1.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing scan_fmt-0.1.3 [INFO] finished frobbing scan_fmt-0.1.3 [INFO] frobbed toml for scan_fmt-0.1.3 written to work/ex/clippy-test-run/sources/stable/reg/scan_fmt/0.1.3/Cargo.toml [INFO] started frobbing scan_fmt-0.1.3 [INFO] finished frobbing scan_fmt-0.1.3 [INFO] frobbed toml for scan_fmt-0.1.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/scan_fmt/0.1.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting scan_fmt-0.1.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/scan_fmt/0.1.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0128fac3cb3ff210c2ae43feb457c412a72467f59a46837b169977b85c2529ca [INFO] running `"docker" "start" "-a" "0128fac3cb3ff210c2ae43feb457c412a72467f59a46837b169977b85c2529ca"` [INFO] [stderr] Checking scan_fmt v0.1.3 (/opt/crater/workdir) [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/parse.rs:267:5 [INFO] [stderr] | [INFO] [stderr] 267 | / if vs.cur() == '0' { [INFO] [stderr] 268 | | if !vs.inc() { [INFO] [stderr] 269 | | return; [INFO] [stderr] 270 | | } [INFO] [stderr] 271 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 267 | if vs.cur() == '0' && !vs.inc() { [INFO] [stderr] 268 | return; [INFO] [stderr] 269 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/parse.rs:272:5 [INFO] [stderr] | [INFO] [stderr] 272 | / if vs.cur() == 'x' { [INFO] [stderr] 273 | | if !vs.inc() { [INFO] [stderr] 274 | | return; [INFO] [stderr] 275 | | } [INFO] [stderr] 276 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 272 | if vs.cur() == 'x' && !vs.inc() { [INFO] [stderr] 273 | return; [INFO] [stderr] 274 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parse.rs:355:5 [INFO] [stderr] | [INFO] [stderr] 355 | return ReMatch::NoCapture; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ReMatch::NoCapture` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/parse.rs:423:16 [INFO] [stderr] | [INFO] [stderr] 423 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 424 | | if fmtstr.cur() == '}' { [INFO] [stderr] 425 | | // handle escaped }} by skipping first '}' [INFO] [stderr] 426 | | if !fmtstr.inc() { [INFO] [stderr] ... | [INFO] [stderr] 429 | | } [INFO] [stderr] 430 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 423 | } else if fmtstr.cur() == '}' { [INFO] [stderr] 424 | // handle escaped }} by skipping first '}' [INFO] [stderr] 425 | if !fmtstr.inc() { [INFO] [stderr] 426 | break; [INFO] [stderr] 427 | } [INFO] [stderr] 428 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/parse.rs:413:20 [INFO] [stderr] | [INFO] [stderr] 413 | if !fmt.is_some() { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `fmt.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/parse.rs:267:5 [INFO] [stderr] | [INFO] [stderr] 267 | / if vs.cur() == '0' { [INFO] [stderr] 268 | | if !vs.inc() { [INFO] [stderr] 269 | | return; [INFO] [stderr] 270 | | } [INFO] [stderr] 271 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 267 | if vs.cur() == '0' && !vs.inc() { [INFO] [stderr] 268 | return; [INFO] [stderr] 269 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/parse.rs:272:5 [INFO] [stderr] | [INFO] [stderr] 272 | / if vs.cur() == 'x' { [INFO] [stderr] 273 | | if !vs.inc() { [INFO] [stderr] 274 | | return; [INFO] [stderr] 275 | | } [INFO] [stderr] 276 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 272 | if vs.cur() == 'x' && !vs.inc() { [INFO] [stderr] 273 | return; [INFO] [stderr] 274 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parse.rs:355:5 [INFO] [stderr] | [INFO] [stderr] 355 | return ReMatch::NoCapture; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ReMatch::NoCapture` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/parse.rs:423:16 [INFO] [stderr] | [INFO] [stderr] 423 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 424 | | if fmtstr.cur() == '}' { [INFO] [stderr] 425 | | // handle escaped }} by skipping first '}' [INFO] [stderr] 426 | | if !fmtstr.inc() { [INFO] [stderr] ... | [INFO] [stderr] 429 | | } [INFO] [stderr] 430 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 423 | } else if fmtstr.cur() == '}' { [INFO] [stderr] 424 | // handle escaped }} by skipping first '}' [INFO] [stderr] 425 | if !fmtstr.inc() { [INFO] [stderr] 426 | break; [INFO] [stderr] 427 | } [INFO] [stderr] 428 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/parse.rs:413:20 [INFO] [stderr] | [INFO] [stderr] 413 | if !fmt.is_some() { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `fmt.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.18s [INFO] running `"docker" "inspect" "0128fac3cb3ff210c2ae43feb457c412a72467f59a46837b169977b85c2529ca"` [INFO] running `"docker" "rm" "-f" "0128fac3cb3ff210c2ae43feb457c412a72467f59a46837b169977b85c2529ca"` [INFO] [stdout] 0128fac3cb3ff210c2ae43feb457c412a72467f59a46837b169977b85c2529ca