[INFO] crate scalable_bloom_filter 0.1.1 is already in cache [INFO] extracting crate scalable_bloom_filter 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/scalable_bloom_filter/0.1.1 [INFO] extracting crate scalable_bloom_filter 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/scalable_bloom_filter/0.1.1 [INFO] validating manifest of scalable_bloom_filter-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of scalable_bloom_filter-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing scalable_bloom_filter-0.1.1 [INFO] finished frobbing scalable_bloom_filter-0.1.1 [INFO] frobbed toml for scalable_bloom_filter-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/scalable_bloom_filter/0.1.1/Cargo.toml [INFO] started frobbing scalable_bloom_filter-0.1.1 [INFO] finished frobbing scalable_bloom_filter-0.1.1 [INFO] frobbed toml for scalable_bloom_filter-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/scalable_bloom_filter/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting scalable_bloom_filter-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/scalable_bloom_filter/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fa260e0d1a564d1edf1be25dc93669667544ebbbe41c70f199f2a6042e74cbf9 [INFO] running `"docker" "start" "-a" "fa260e0d1a564d1edf1be25dc93669667544ebbbe41c70f199f2a6042e74cbf9"` [INFO] [stderr] Checking scalable_bloom_filter v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/scalable_bloom_filter.rs:58:20 [INFO] [stderr] | [INFO] [stderr] 58 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 59 | | if filter.contains(element, &self.hasher) { [INFO] [stderr] 60 | | return; [INFO] [stderr] 61 | | } [INFO] [stderr] 62 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 58 | } else if filter.contains(element, &self.hasher) { [INFO] [stderr] 59 | return; [INFO] [stderr] 60 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/scalable_bloom_filter.rs:58:20 [INFO] [stderr] | [INFO] [stderr] 58 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 59 | | if filter.contains(element, &self.hasher) { [INFO] [stderr] 60 | | return; [INFO] [stderr] 61 | | } [INFO] [stderr] 62 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 58 | } else if filter.contains(element, &self.hasher) { [INFO] [stderr] 59 | return; [INFO] [stderr] 60 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/scalable_bloom_filter.rs:118:45 [INFO] [stderr] | [INFO] [stderr] 118 | assert_eq!(filter.allocated_bits(), 262144); [INFO] [stderr] | ^^^^^^ help: consider: `262_144` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/scalable_bloom_filter.rs:133:55 [INFO] [stderr] | [INFO] [stderr] 133 | let mut filter = ScalableBloomFilter::new(32, 0.000001); [INFO] [stderr] | ^^^^^^^^ help: consider: `0.000_001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.34s [INFO] running `"docker" "inspect" "fa260e0d1a564d1edf1be25dc93669667544ebbbe41c70f199f2a6042e74cbf9"` [INFO] running `"docker" "rm" "-f" "fa260e0d1a564d1edf1be25dc93669667544ebbbe41c70f199f2a6042e74cbf9"` [INFO] [stdout] fa260e0d1a564d1edf1be25dc93669667544ebbbe41c70f199f2a6042e74cbf9