[INFO] crate sbrain 0.4.2 is already in cache [INFO] extracting crate sbrain 0.4.2 into work/ex/clippy-test-run/sources/stable/reg/sbrain/0.4.2 [INFO] extracting crate sbrain 0.4.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sbrain/0.4.2 [INFO] validating manifest of sbrain-0.4.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sbrain-0.4.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sbrain-0.4.2 [INFO] finished frobbing sbrain-0.4.2 [INFO] frobbed toml for sbrain-0.4.2 written to work/ex/clippy-test-run/sources/stable/reg/sbrain/0.4.2/Cargo.toml [INFO] started frobbing sbrain-0.4.2 [INFO] finished frobbing sbrain-0.4.2 [INFO] frobbed toml for sbrain-0.4.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sbrain/0.4.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sbrain-0.4.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/sbrain/0.4.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d73fff0119b660ee1db3eb5248dd6c434f620715c7857af8a664c9459da988c3 [INFO] running `"docker" "start" "-a" "d73fff0119b660ee1db3eb5248dd6c434f620715c7857af8a664c9459da988c3"` [INFO] [stderr] Checking sbrain v0.4.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/machine.rs:70:13 [INFO] [stderr] | [INFO] [stderr] 70 | input_t: input_t, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `input_t` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:84:9 [INFO] [stderr] | [INFO] [stderr] 84 | cycles: cycles, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `cycles` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | halted: halted, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `halted` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:115:9 [INFO] [stderr] | [INFO] [stderr] 115 | cycles: cycles, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `cycles` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:116:9 [INFO] [stderr] | [INFO] [stderr] 116 | halted: halted, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `halted` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/machine.rs:70:13 [INFO] [stderr] | [INFO] [stderr] 70 | input_t: input_t, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `input_t` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:84:9 [INFO] [stderr] | [INFO] [stderr] 84 | cycles: cycles, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `cycles` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | halted: halted, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `halted` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:115:9 [INFO] [stderr] | [INFO] [stderr] 115 | cycles: cycles, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `cycles` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:116:9 [INFO] [stderr] | [INFO] [stderr] 116 | halted: halted, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `halted` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/machine.rs:86:9 [INFO] [stderr] | [INFO] [stderr] 86 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/machine.rs:100:9 [INFO] [stderr] | [INFO] [stderr] 100 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/machine.rs:273:9 [INFO] [stderr] | [INFO] [stderr] 273 | return FlowAction::NoAction; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `FlowAction::NoAction` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/machine.rs:278:9 [INFO] [stderr] | [INFO] [stderr] 278 | return self.output_t.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.output_t.clone()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/machine.rs:289:9 [INFO] [stderr] | [INFO] [stderr] 289 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/source.rs:92:5 [INFO] [stderr] | [INFO] [stderr] 92 | return (code, data); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(code, data)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/machine.rs:104:9 [INFO] [stderr] | [INFO] [stderr] 104 | / match &mut self.input_t { [INFO] [stderr] 105 | | &mut Some(ref mut v) => { [INFO] [stderr] 106 | | match v.pop() { [INFO] [stderr] 107 | | Some(n) => n, [INFO] [stderr] ... | [INFO] [stderr] 119 | | } [INFO] [stderr] 120 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 104 | match *(&mut self.input_t) { [INFO] [stderr] 105 | Some(ref mut v) => { [INFO] [stderr] 106 | match v.pop() { [INFO] [stderr] 107 | Some(n) => n, [INFO] [stderr] 108 | None => 0, [INFO] [stderr] 109 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/machine.rs:117:33 [INFO] [stderr] | [INFO] [stderr] 117 | .map(|byte| byte as u32) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(byte)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/machine.rs:202:17 [INFO] [stderr] | [INFO] [stderr] 202 | self.auxi_r = self.auxi_r << 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.auxi_r <<= 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/machine.rs:206:17 [INFO] [stderr] | [INFO] [stderr] 206 | self.auxi_r = self.auxi_r >> 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.auxi_r >>= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/machine.rs:212:17 [INFO] [stderr] | [INFO] [stderr] 212 | / self.data_tape[self.data_p as usize] = self.data_tape[self.data_p as usize] | [INFO] [stderr] 213 | | self.auxi_r; [INFO] [stderr] | |__________________________________________________________________^ help: replace it with: `self.data_tape[self.data_p as usize] |= self.auxi_r` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/machine.rs:217:17 [INFO] [stderr] | [INFO] [stderr] 217 | / self.data_tape[self.data_p as usize] = self.data_tape[self.data_p as usize] & [INFO] [stderr] 218 | | self.auxi_r; [INFO] [stderr] | |__________________________________________________________________^ help: replace it with: `self.data_tape[self.data_p as usize] &= self.auxi_r` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/machine.rs:222:17 [INFO] [stderr] | [INFO] [stderr] 222 | / self.data_tape[self.data_p as usize] = self.data_tape[self.data_p as usize] ^ [INFO] [stderr] 223 | | self.auxi_r; [INFO] [stderr] | |__________________________________________________________________^ help: replace it with: `self.data_tape[self.data_p as usize] ^= self.auxi_r` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/machine.rs:259:21 [INFO] [stderr] | [INFO] [stderr] 259 | / self.data_tape[self.data_p as usize] = self.data_tape[self.data_p as usize] % [INFO] [stderr] 260 | | self.auxi_r; [INFO] [stderr] | |______________________________________________________________________^ help: replace it with: `self.data_tape[self.data_p as usize] %= self.auxi_r` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/machine.rs:302:31 [INFO] [stderr] | [INFO] [stderr] 302 | let instruction = self.exec_tape[self.inst_p as usize].clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.exec_tape[self.inst_p as usize]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/machine.rs:86:9 [INFO] [stderr] | [INFO] [stderr] 86 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/machine.rs:100:9 [INFO] [stderr] | [INFO] [stderr] 100 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/machine.rs:273:9 [INFO] [stderr] | [INFO] [stderr] 273 | return FlowAction::NoAction; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `FlowAction::NoAction` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/machine.rs:278:9 [INFO] [stderr] | [INFO] [stderr] 278 | return self.output_t.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.output_t.clone()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/machine.rs:289:9 [INFO] [stderr] | [INFO] [stderr] 289 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/source.rs:92:5 [INFO] [stderr] | [INFO] [stderr] 92 | return (code, data); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(code, data)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> tests/source.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/machine.rs:104:9 [INFO] [stderr] | [INFO] [stderr] 104 | / match &mut self.input_t { [INFO] [stderr] 105 | | &mut Some(ref mut v) => { [INFO] [stderr] 106 | | match v.pop() { [INFO] [stderr] 107 | | Some(n) => n, [INFO] [stderr] ... | [INFO] [stderr] 119 | | } [INFO] [stderr] 120 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 104 | match *(&mut self.input_t) { [INFO] [stderr] 105 | Some(ref mut v) => { [INFO] [stderr] 106 | match v.pop() { [INFO] [stderr] 107 | Some(n) => n, [INFO] [stderr] 108 | None => 0, [INFO] [stderr] 109 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/machine.rs:117:33 [INFO] [stderr] | [INFO] [stderr] 117 | .map(|byte| byte as u32) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(byte)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/machine.rs:202:17 [INFO] [stderr] | [INFO] [stderr] 202 | self.auxi_r = self.auxi_r << 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.auxi_r <<= 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/machine.rs:206:17 [INFO] [stderr] | [INFO] [stderr] 206 | self.auxi_r = self.auxi_r >> 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.auxi_r >>= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/machine.rs:212:17 [INFO] [stderr] | [INFO] [stderr] 212 | / self.data_tape[self.data_p as usize] = self.data_tape[self.data_p as usize] | [INFO] [stderr] 213 | | self.auxi_r; [INFO] [stderr] | |__________________________________________________________________^ help: replace it with: `self.data_tape[self.data_p as usize] |= self.auxi_r` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/machine.rs:217:17 [INFO] [stderr] | [INFO] [stderr] 217 | / self.data_tape[self.data_p as usize] = self.data_tape[self.data_p as usize] & [INFO] [stderr] 218 | | self.auxi_r; [INFO] [stderr] | |__________________________________________________________________^ help: replace it with: `self.data_tape[self.data_p as usize] &= self.auxi_r` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/machine.rs:222:17 [INFO] [stderr] | [INFO] [stderr] 222 | / self.data_tape[self.data_p as usize] = self.data_tape[self.data_p as usize] ^ [INFO] [stderr] 223 | | self.auxi_r; [INFO] [stderr] | |__________________________________________________________________^ help: replace it with: `self.data_tape[self.data_p as usize] ^= self.auxi_r` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/machine.rs:259:21 [INFO] [stderr] | [INFO] [stderr] 259 | / self.data_tape[self.data_p as usize] = self.data_tape[self.data_p as usize] % [INFO] [stderr] 260 | | self.auxi_r; [INFO] [stderr] | |______________________________________________________________________^ help: replace it with: `self.data_tape[self.data_p as usize] %= self.auxi_r` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/machine.rs:302:31 [INFO] [stderr] | [INFO] [stderr] 302 | let instruction = self.exec_tape[self.inst_p as usize].clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.exec_tape[self.inst_p as usize]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/source.rs:113:29 [INFO] [stderr] | [INFO] [stderr] 113 | vec![4294966271, 4, 1]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_294_966_271` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/source.rs:122:44 [INFO] [stderr] | [INFO] [stderr] 122 | vec![1026, 0, 1026, 4294966269]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_294_966_269` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.43s [INFO] running `"docker" "inspect" "d73fff0119b660ee1db3eb5248dd6c434f620715c7857af8a664c9459da988c3"` [INFO] running `"docker" "rm" "-f" "d73fff0119b660ee1db3eb5248dd6c434f620715c7857af8a664c9459da988c3"` [INFO] [stdout] d73fff0119b660ee1db3eb5248dd6c434f620715c7857af8a664c9459da988c3