[INFO] crate sbd 0.2.0 is already in cache [INFO] extracting crate sbd 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/sbd/0.2.0 [INFO] extracting crate sbd 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sbd/0.2.0 [INFO] validating manifest of sbd-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sbd-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sbd-0.2.0 [INFO] finished frobbing sbd-0.2.0 [INFO] frobbed toml for sbd-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/sbd/0.2.0/Cargo.toml [INFO] started frobbing sbd-0.2.0 [INFO] finished frobbing sbd-0.2.0 [INFO] frobbed toml for sbd-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sbd/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sbd-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/sbd/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 918b56cb299a63a06dbb171b6be5343736b4666f46d63c689f4dc041ead21618 [INFO] running `"docker" "start" "-a" "918b56cb299a63a06dbb171b6be5343736b4666f46d63c689f4dc041ead21618"` [INFO] [stderr] Checking sbd v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/directip.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | addr: addr, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `addr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mo/information_element.rs:50:21 [INFO] [stderr] | [INFO] [stderr] 50 | auto_id: auto_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `auto_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mo/information_element.rs:51:21 [INFO] [stderr] | [INFO] [stderr] 51 | imei: imei, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `imei` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mo/information_element.rs:52:21 [INFO] [stderr] | [INFO] [stderr] 52 | session_status: session_status, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `session_status` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mo/information_element.rs:53:21 [INFO] [stderr] | [INFO] [stderr] 53 | momsn: momsn, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `momsn` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mo/information_element.rs:54:21 [INFO] [stderr] | [INFO] [stderr] 54 | mtmsn: mtmsn, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `mtmsn` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mo/information_element.rs:55:21 [INFO] [stderr] | [INFO] [stderr] 55 | time_of_session: time_of_session, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `time_of_session` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mo/message.rs:117:13 [INFO] [stderr] | [INFO] [stderr] 117 | information_elements: information_elements, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `information_elements` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/directip.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | addr: addr, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `addr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mo/information_element.rs:50:21 [INFO] [stderr] | [INFO] [stderr] 50 | auto_id: auto_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `auto_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mo/information_element.rs:51:21 [INFO] [stderr] | [INFO] [stderr] 51 | imei: imei, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `imei` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mo/information_element.rs:52:21 [INFO] [stderr] | [INFO] [stderr] 52 | session_status: session_status, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `session_status` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mo/information_element.rs:53:21 [INFO] [stderr] | [INFO] [stderr] 53 | momsn: momsn, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `momsn` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mo/information_element.rs:54:21 [INFO] [stderr] | [INFO] [stderr] 54 | mtmsn: mtmsn, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `mtmsn` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mo/information_element.rs:55:21 [INFO] [stderr] | [INFO] [stderr] 55 | time_of_session: time_of_session, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `time_of_session` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mo/message.rs:117:13 [INFO] [stderr] | [INFO] [stderr] 117 | information_elements: information_elements, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `information_elements` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/storage/filesystem.rs:12:23 [INFO] [stderr] | [INFO] [stderr] 12 | const SBD_EXTENSION: &'static str = "sbd"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mo/information_element.rs:161:32 [INFO] [stderr] | [INFO] [stderr] 161 | assert_eq!(1894516585, header.auto_id); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_894_516_585` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/mo/information_element.rs:167:61 [INFO] [stderr] | [INFO] [stderr] 167 | Utc.ymd(2015, 7, 9).and_hms(18, 15, 08), [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_prefixed_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 167 | Utc.ymd(2015, 7, 9).and_hms(18, 15, 8), [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 167 | Utc.ymd(2015, 7, 9).and_hms(18, 15, 0o8), [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mo/message.rs:339:20 [INFO] [stderr] | [INFO] [stderr] 339 | assert_eq!(1894516585, message.auto_id()); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_894_516_585` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/storage/filesystem.rs:12:23 [INFO] [stderr] | [INFO] [stderr] 12 | const SBD_EXTENSION: &'static str = "sbd"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/mo/message.rs:333:35 [INFO] [stderr] | [INFO] [stderr] 333 | assert!(Message::new(vec![header.clone().into(), header.into()]).is_err()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `header` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: avoid using `collect()` when not needed [INFO] [stderr] --> src/storage/filesystem.rs:180:37 [INFO] [stderr] | [INFO] [stderr] 180 | assert_eq!(0, storage.iter().collect::>().len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `.count()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_collect [INFO] [stderr] [INFO] [stderr] warning: avoid using `collect()` when not needed [INFO] [stderr] --> src/storage/filesystem.rs:183:37 [INFO] [stderr] | [INFO] [stderr] 183 | assert_eq!(1, storage.iter().collect::>().len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `.count()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_collect [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/storage/memory.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | let ref stored_message = storage.messages().unwrap()[0]; [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^^---------------------------------- help: try: `let stored_message = &storage.messages().unwrap()[0];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:20:15 [INFO] [stderr] | [INFO] [stderr] 20 | const USAGE: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:20:15 [INFO] [stderr] | [INFO] [stderr] 20 | const USAGE: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.08s [INFO] running `"docker" "inspect" "918b56cb299a63a06dbb171b6be5343736b4666f46d63c689f4dc041ead21618"` [INFO] running `"docker" "rm" "-f" "918b56cb299a63a06dbb171b6be5343736b4666f46d63c689f4dc041ead21618"` [INFO] [stdout] 918b56cb299a63a06dbb171b6be5343736b4666f46d63c689f4dc041ead21618