[INFO] crate sasl 0.4.2 is already in cache [INFO] extracting crate sasl 0.4.2 into work/ex/clippy-test-run/sources/stable/reg/sasl/0.4.2 [INFO] extracting crate sasl 0.4.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sasl/0.4.2 [INFO] validating manifest of sasl-0.4.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sasl-0.4.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sasl-0.4.2 [INFO] finished frobbing sasl-0.4.2 [INFO] frobbed toml for sasl-0.4.2 written to work/ex/clippy-test-run/sources/stable/reg/sasl/0.4.2/Cargo.toml [INFO] started frobbing sasl-0.4.2 [INFO] finished frobbing sasl-0.4.2 [INFO] frobbed toml for sasl-0.4.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sasl/0.4.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sasl-0.4.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/sasl/0.4.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 43c048fdf7f491df88063b0c2ae78c453e4ed70cbd73dbaa0515adc87a291cfe [INFO] running `"docker" "start" "-a" "43c048fdf7f491df88063b0c2ae78c453e4ed70cbd73dbaa0515adc87a291cfe"` [INFO] [stderr] Checking sasl v0.4.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/mechanisms/scram.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | channel_binding: channel_binding, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `channel_binding` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/mechanisms/scram.rs:95:78 [INFO] [stderr] | [INFO] [stderr] 95 | self.state = ScramState::SentInitialMessage { initial_message: bare, gs2_header: gs2_header }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `gs2_header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/mechanisms/scram.rs:138:21 [INFO] [stderr] | [INFO] [stderr] 138 | server_signature: server_signature, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `server_signature` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server/mechanisms/plain.rs:11:17 [INFO] [stderr] | [INFO] [stderr] 11 | Plain { validator: validator, } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `validator` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server/mechanisms/scram.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | channel_binding: channel_binding, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `channel_binding` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server/mechanisms/scram.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | provider: provider, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `provider` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server/mechanisms/scram.rs:114:21 [INFO] [stderr] | [INFO] [stderr] 114 | server_nonce: server_nonce, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `server_nonce` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server/mechanisms/scram.rs:115:21 [INFO] [stderr] | [INFO] [stderr] 115 | identity: identity, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `identity` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server/mechanisms/scram.rs:119:21 [INFO] [stderr] | [INFO] [stderr] 119 | gs2_header: gs2_header, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `gs2_header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/common/mod.rs:86:13 [INFO] [stderr] | [INFO] [stderr] 86 | salt: salt, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `salt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/common/mod.rs:87:13 [INFO] [stderr] | [INFO] [stderr] 87 | iterations: iterations, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `iterations` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/common/mod.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/secret.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | iterations: iterations, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `iterations` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/secret.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | digest: digest, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `digest` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/secret.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | iterations: iterations, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `iterations` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/secret.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | digest: digest, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `digest` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/mechanisms/scram.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | channel_binding: channel_binding, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `channel_binding` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/mechanisms/scram.rs:95:78 [INFO] [stderr] | [INFO] [stderr] 95 | self.state = ScramState::SentInitialMessage { initial_message: bare, gs2_header: gs2_header }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `gs2_header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/mechanisms/scram.rs:138:21 [INFO] [stderr] | [INFO] [stderr] 138 | server_signature: server_signature, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `server_signature` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server/mechanisms/plain.rs:11:17 [INFO] [stderr] | [INFO] [stderr] 11 | Plain { validator: validator, } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `validator` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server/mechanisms/scram.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | channel_binding: channel_binding, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `channel_binding` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server/mechanisms/scram.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | provider: provider, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `provider` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server/mechanisms/scram.rs:114:21 [INFO] [stderr] | [INFO] [stderr] 114 | server_nonce: server_nonce, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `server_nonce` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server/mechanisms/scram.rs:115:21 [INFO] [stderr] | [INFO] [stderr] 115 | identity: identity, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `identity` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server/mechanisms/scram.rs:119:21 [INFO] [stderr] | [INFO] [stderr] 119 | gs2_header: gs2_header, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `gs2_header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/common/mod.rs:86:13 [INFO] [stderr] | [INFO] [stderr] 86 | salt: salt, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `salt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/common/mod.rs:87:13 [INFO] [stderr] | [INFO] [stderr] 87 | iterations: iterations, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `iterations` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/common/mod.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/secret.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | iterations: iterations, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `iterations` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/secret.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | digest: digest, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `digest` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/secret.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | iterations: iterations, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `iterations` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/secret.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | digest: digest, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `digest` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `client::mechanisms::anonymous::Anonymous` [INFO] [stderr] --> src/client/mechanisms/anonymous.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | / pub fn new() -> Anonymous { [INFO] [stderr] 15 | | Anonymous [INFO] [stderr] 16 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 7 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/common/scram.rs:71:25 [INFO] [stderr] | [INFO] [stderr] 71 | Err(format!("incorrect salt")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"incorrect salt".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/common/scram.rs:115:25 [INFO] [stderr] | [INFO] [stderr] 115 | Err(format!("incorrect salt")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"incorrect salt".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/common/mod.rs:131:21 [INFO] [stderr] | [INFO] [stderr] 131 | for (a, b) in a.into_iter().zip(b) { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/common/mod.rs:145:9 [INFO] [stderr] | [INFO] [stderr] 145 | / match (key, val) { [INFO] [stderr] 146 | | (Some(k), Some(v)) => { [INFO] [stderr] 147 | | ret.insert(k.to_owned(), v.to_owned()); [INFO] [stderr] 148 | | }, [INFO] [stderr] 149 | | _ =>(), [INFO] [stderr] 150 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 145 | if let (Some(k), Some(v)) = (key, val) { [INFO] [stderr] 146 | ret.insert(k.to_owned(), v.to_owned()); [INFO] [stderr] 147 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `client::mechanisms::anonymous::Anonymous` [INFO] [stderr] --> src/client/mechanisms/anonymous.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | / pub fn new() -> Anonymous { [INFO] [stderr] 15 | | Anonymous [INFO] [stderr] 16 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 7 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/common/scram.rs:71:25 [INFO] [stderr] | [INFO] [stderr] 71 | Err(format!("incorrect salt")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"incorrect salt".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/common/scram.rs:115:25 [INFO] [stderr] | [INFO] [stderr] 115 | Err(format!("incorrect salt")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"incorrect salt".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/common/mod.rs:131:21 [INFO] [stderr] | [INFO] [stderr] 131 | for (a, b) in a.into_iter().zip(b) { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/common/mod.rs:145:9 [INFO] [stderr] | [INFO] [stderr] 145 | / match (key, val) { [INFO] [stderr] 146 | | (Some(k), Some(v)) => { [INFO] [stderr] 147 | | ret.insert(k.to_owned(), v.to_owned()); [INFO] [stderr] 148 | | }, [INFO] [stderr] 149 | | _ =>(), [INFO] [stderr] 150 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 145 | if let (Some(k), Some(v)) = (key, val) { [INFO] [stderr] 146 | ret.insert(k.to_owned(), v.to_owned()); [INFO] [stderr] 147 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.66s [INFO] running `"docker" "inspect" "43c048fdf7f491df88063b0c2ae78c453e4ed70cbd73dbaa0515adc87a291cfe"` [INFO] running `"docker" "rm" "-f" "43c048fdf7f491df88063b0c2ae78c453e4ed70cbd73dbaa0515adc87a291cfe"` [INFO] [stdout] 43c048fdf7f491df88063b0c2ae78c453e4ed70cbd73dbaa0515adc87a291cfe