[INFO] crate sardine 0.2.0 is already in cache
[INFO] extracting crate sardine 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/sardine/0.2.0
[INFO] extracting crate sardine 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sardine/0.2.0
[INFO] validating manifest of sardine-0.2.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of sardine-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing sardine-0.2.0
[INFO] removed 0 missing examples
[INFO] finished frobbing sardine-0.2.0
[INFO] frobbed toml for sardine-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/sardine/0.2.0/Cargo.toml
[INFO] started frobbing sardine-0.2.0
[INFO] removed 0 missing examples
[INFO] finished frobbing sardine-0.2.0
[INFO] frobbed toml for sardine-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sardine/0.2.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting sardine-0.2.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/sardine/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] dd9c4da5e372fa0b5184669f0b13700b92535b43f2b5757cf0c3ecc70f93273a
[INFO] running `"docker" "start" "-a" "dd9c4da5e372fa0b5184669f0b13700b92535b43f2b5757cf0c3ecc70f93273a"`
[INFO] [stderr] warning: file found to be present in multiple build targets: /opt/crater/workdir/src/lib.rs
[INFO] [stderr]     Checking keystream v1.0.0
[INFO] [stderr]     Checking num-bigint v0.1.44
[INFO] [stderr]     Checking chacha v0.1.0
[INFO] [stderr]     Checking sardine v0.2.0 (/opt/crater/workdir)
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/cipher.rs:10:26
[INFO] [stderr]    |
[INFO] [stderr] 10 | const AES256_FLAG: u32 = 0x00000001;
[INFO] [stderr]    |                          ^^^^^^^^^^ help: consider: `0x0000_0001`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/cipher.rs:11:28
[INFO] [stderr]    |
[INFO] [stderr] 11 | const CHACHA20_FLAG: u32 = 0x00000100;
[INFO] [stderr]    |                            ^^^^^^^^^^ help: consider: `0x0000_0100`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/cipher.rs:12:29
[INFO] [stderr]    |
[INFO] [stderr] 12 | const XCHACHA20_FLAG: u32 = 0x00000200;
[INFO] [stderr]    |                             ^^^^^^^^^^ help: consider: `0x0000_0200`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]  --> src/message_types/mod.rs:9:32
[INFO] [stderr]   |
[INFO] [stderr] 9 | pub const SRD_SIGNATURE: u32 = 0x00445253;
[INFO] [stderr]   |                                ^^^^^^^^^^ help: consider: `0x0044_5253`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]    --> src/srd.rs:242:9
[INFO] [stderr]     |
[INFO] [stderr] 242 | /         if cfg!(not(feature = "aes")) {
[INFO] [stderr] 243 | |             if ciphers.contains(&Cipher::AES256) {
[INFO] [stderr] 244 | |                 return Err(SrdError::Cipher);
[INFO] [stderr] 245 | |             }
[INFO] [stderr] 246 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 242 |         if cfg!(not(feature = "aes")) && ciphers.contains(&Cipher::AES256) {
[INFO] [stderr] 243 |     return Err(SrdError::Cipher);
[INFO] [stderr] 244 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/srd.rs:271:9
[INFO] [stderr]     |
[INFO] [stderr] 271 |         return self.blob.clone();
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.blob.clone()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/ffi.rs:31:17
[INFO] [stderr]    |
[INFO] [stderr] 31 |                 return 0;
[INFO] [stderr]    |                 ^^^^^^^^^ help: remove `return` as shown: `0`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/ffi.rs:33:17
[INFO] [stderr]    |
[INFO] [stderr] 33 |                 return 1;
[INFO] [stderr]    |                 ^^^^^^^^^ help: remove `return` as shown: `1`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/ffi.rs:37:13
[INFO] [stderr]    |
[INFO] [stderr] 37 |             return -1;
[INFO] [stderr]    |             ^^^^^^^^^^ help: remove `return` as shown: `-1`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/ffi.rs:60:5
[INFO] [stderr]    |
[INFO] [stderr] 60 |     return 0;
[INFO] [stderr]    |     ^^^^^^^^^ help: remove `return` as shown: `0`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/ffi.rs:86:5
[INFO] [stderr]    |
[INFO] [stderr] 86 |     return status;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^ help: remove `return` as shown: `status`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/ffi.rs:110:5
[INFO] [stderr]     |
[INFO] [stderr] 110 |     return 0;
[INFO] [stderr]     |     ^^^^^^^^^ help: remove `return` as shown: `0`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/ffi.rs:132:5
[INFO] [stderr]     |
[INFO] [stderr] 132 |     return 0;
[INFO] [stderr]     |     ^^^^^^^^^ help: remove `return` as shown: `0`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/cipher.rs:10:26
[INFO] [stderr]    |
[INFO] [stderr] 10 | const AES256_FLAG: u32 = 0x00000001;
[INFO] [stderr]    |                          ^^^^^^^^^^ help: consider: `0x0000_0001`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/cipher.rs:11:28
[INFO] [stderr]    |
[INFO] [stderr] 11 | const CHACHA20_FLAG: u32 = 0x00000100;
[INFO] [stderr]    |                            ^^^^^^^^^^ help: consider: `0x0000_0100`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/cipher.rs:12:29
[INFO] [stderr]    |
[INFO] [stderr] 12 | const XCHACHA20_FLAG: u32 = 0x00000200;
[INFO] [stderr]    |                             ^^^^^^^^^^ help: consider: `0x0000_0200`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]  --> src/message_types/mod.rs:9:32
[INFO] [stderr]   |
[INFO] [stderr] 9 | pub const SRD_SIGNATURE: u32 = 0x00445253;
[INFO] [stderr]   |                                ^^^^^^^^^^ help: consider: `0x0044_5253`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]    --> src/srd.rs:242:9
[INFO] [stderr]     |
[INFO] [stderr] 242 | /         if cfg!(not(feature = "aes")) {
[INFO] [stderr] 243 | |             if ciphers.contains(&Cipher::AES256) {
[INFO] [stderr] 244 | |                 return Err(SrdError::Cipher);
[INFO] [stderr] 245 | |             }
[INFO] [stderr] 246 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 242 |         if cfg!(not(feature = "aes")) && ciphers.contains(&Cipher::AES256) {
[INFO] [stderr] 243 |     return Err(SrdError::Cipher);
[INFO] [stderr] 244 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/srd.rs:271:9
[INFO] [stderr]     |
[INFO] [stderr] 271 |         return self.blob.clone();
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.blob.clone()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/ffi.rs:31:17
[INFO] [stderr]    |
[INFO] [stderr] 31 |                 return 0;
[INFO] [stderr]    |                 ^^^^^^^^^ help: remove `return` as shown: `0`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/ffi.rs:33:17
[INFO] [stderr]    |
[INFO] [stderr] 33 |                 return 1;
[INFO] [stderr]    |                 ^^^^^^^^^ help: remove `return` as shown: `1`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/ffi.rs:37:13
[INFO] [stderr]    |
[INFO] [stderr] 37 |             return -1;
[INFO] [stderr]    |             ^^^^^^^^^^ help: remove `return` as shown: `-1`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/ffi.rs:60:5
[INFO] [stderr]    |
[INFO] [stderr] 60 |     return 0;
[INFO] [stderr]    |     ^^^^^^^^^ help: remove `return` as shown: `0`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/ffi.rs:86:5
[INFO] [stderr]    |
[INFO] [stderr] 86 |     return status;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^ help: remove `return` as shown: `status`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/ffi.rs:110:5
[INFO] [stderr]     |
[INFO] [stderr] 110 |     return 0;
[INFO] [stderr]     |     ^^^^^^^^^ help: remove `return` as shown: `0`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/ffi.rs:132:5
[INFO] [stderr]     |
[INFO] [stderr] 132 |     return 0;
[INFO] [stderr]     |     ^^^^^^^^^ help: remove `return` as shown: `0`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/cipher.rs:22:25
[INFO] [stderr]    |
[INFO] [stderr] 22 |     pub fn encrypt_data(&self, data: &[u8], key: &[u8], iv: &[u8]) -> Result<Vec<u8>> {
[INFO] [stderr]    |                         ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/cipher.rs:23:9
[INFO] [stderr]    |
[INFO] [stderr] 23 | /         match self {
[INFO] [stderr] 24 | |             &Cipher::AES256 => encrypt_data_aes(data, key, iv),
[INFO] [stderr] 25 | |             &Cipher::ChaCha20 => encrypt_data_chacha(data, key, iv),
[INFO] [stderr] 26 | |             &Cipher::XChaCha20 => encrypt_data_xchacha(data, key, iv),
[INFO] [stderr] 27 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 23 |         match *self {
[INFO] [stderr] 24 |             Cipher::AES256 => encrypt_data_aes(data, key, iv),
[INFO] [stderr] 25 |             Cipher::ChaCha20 => encrypt_data_chacha(data, key, iv),
[INFO] [stderr] 26 |             Cipher::XChaCha20 => encrypt_data_xchacha(data, key, iv),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/cipher.rs:30:25
[INFO] [stderr]    |
[INFO] [stderr] 30 |     pub fn decrypt_data(&self, data: &[u8], key: &[u8], iv: &[u8]) -> Result<Vec<u8>> {
[INFO] [stderr]    |                         ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/cipher.rs:31:9
[INFO] [stderr]    |
[INFO] [stderr] 31 | /         match self {
[INFO] [stderr] 32 | |             &Cipher::AES256 => decrypt_data_aes(data, key, iv),
[INFO] [stderr] 33 | |             &Cipher::ChaCha20 => encrypt_data_chacha(data, key, iv),
[INFO] [stderr] 34 | |             &Cipher::XChaCha20 => encrypt_data_xchacha(data, key, iv),
[INFO] [stderr] 35 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 31 |         match *self {
[INFO] [stderr] 32 |             Cipher::AES256 => decrypt_data_aes(data, key, iv),
[INFO] [stderr] 33 |             Cipher::ChaCha20 => encrypt_data_chacha(data, key, iv),
[INFO] [stderr] 34 |             Cipher::XChaCha20 => encrypt_data_xchacha(data, key, iv),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/cipher.rs:38:17
[INFO] [stderr]    |
[INFO] [stderr] 38 |     pub fn flag(&self) -> u32 {
[INFO] [stderr]    |                 ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/cipher.rs:39:9
[INFO] [stderr]    |
[INFO] [stderr] 39 | /         match self {
[INFO] [stderr] 40 | |             &Cipher::AES256 => AES256_FLAG,
[INFO] [stderr] 41 | |             &Cipher::ChaCha20 => CHACHA20_FLAG,
[INFO] [stderr] 42 | |             &Cipher::XChaCha20 => XCHACHA20_FLAG,
[INFO] [stderr] 43 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 39 |         match *self {
[INFO] [stderr] 40 |             Cipher::AES256 => AES256_FLAG,
[INFO] [stderr] 41 |             Cipher::ChaCha20 => CHACHA20_FLAG,
[INFO] [stderr] 42 |             Cipher::XChaCha20 => XCHACHA20_FLAG,
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this function has too many arguments (8/7)
[INFO] [stderr]    --> src/message_types/srd_accept.rs:109:5
[INFO] [stderr]     |
[INFO] [stderr] 109 | /     pub fn new(
[INFO] [stderr] 110 | |         seq_num: u8,
[INFO] [stderr] 111 | |         cipher: u32,
[INFO] [stderr] 112 | |         key_size: u16,
[INFO] [stderr] ...   |
[INFO] [stderr] 146 | |         Ok(response)
[INFO] [stderr] 147 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::too_many_arguments)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/cipher.rs:22:25
[INFO] [stderr]    |
[INFO] [stderr] 22 |     pub fn encrypt_data(&self, data: &[u8], key: &[u8], iv: &[u8]) -> Result<Vec<u8>> {
[INFO] [stderr]    |                         ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/cipher.rs:23:9
[INFO] [stderr]    |
[INFO] [stderr] 23 | /         match self {
[INFO] [stderr] 24 | |             &Cipher::AES256 => encrypt_data_aes(data, key, iv),
[INFO] [stderr] 25 | |             &Cipher::ChaCha20 => encrypt_data_chacha(data, key, iv),
[INFO] [stderr] 26 | |             &Cipher::XChaCha20 => encrypt_data_xchacha(data, key, iv),
[INFO] [stderr] 27 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 23 |         match *self {
[INFO] [stderr] 24 |             Cipher::AES256 => encrypt_data_aes(data, key, iv),
[INFO] [stderr] 25 |             Cipher::ChaCha20 => encrypt_data_chacha(data, key, iv),
[INFO] [stderr] 26 |             Cipher::XChaCha20 => encrypt_data_xchacha(data, key, iv),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/cipher.rs:30:25
[INFO] [stderr]    |
[INFO] [stderr] 30 |     pub fn decrypt_data(&self, data: &[u8], key: &[u8], iv: &[u8]) -> Result<Vec<u8>> {
[INFO] [stderr]    |                         ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/cipher.rs:31:9
[INFO] [stderr]    |
[INFO] [stderr] 31 | /         match self {
[INFO] [stderr] 32 | |             &Cipher::AES256 => decrypt_data_aes(data, key, iv),
[INFO] [stderr] 33 | |             &Cipher::ChaCha20 => encrypt_data_chacha(data, key, iv),
[INFO] [stderr] 34 | |             &Cipher::XChaCha20 => encrypt_data_xchacha(data, key, iv),
[INFO] [stderr] 35 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 31 |         match *self {
[INFO] [stderr] 32 |             Cipher::AES256 => decrypt_data_aes(data, key, iv),
[INFO] [stderr] 33 |             Cipher::ChaCha20 => encrypt_data_chacha(data, key, iv),
[INFO] [stderr] 34 |             Cipher::XChaCha20 => encrypt_data_xchacha(data, key, iv),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/cipher.rs:38:17
[INFO] [stderr]    |
[INFO] [stderr] 38 |     pub fn flag(&self) -> u32 {
[INFO] [stderr]    |                 ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/cipher.rs:39:9
[INFO] [stderr]    |
[INFO] [stderr] 39 | /         match self {
[INFO] [stderr] 40 | |             &Cipher::AES256 => AES256_FLAG,
[INFO] [stderr] 41 | |             &Cipher::ChaCha20 => CHACHA20_FLAG,
[INFO] [stderr] 42 | |             &Cipher::XChaCha20 => XCHACHA20_FLAG,
[INFO] [stderr] 43 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 39 |         match *self {
[INFO] [stderr] 40 |             Cipher::AES256 => AES256_FLAG,
[INFO] [stderr] 41 |             Cipher::ChaCha20 => CHACHA20_FLAG,
[INFO] [stderr] 42 |             Cipher::XChaCha20 => XCHACHA20_FLAG,
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this function has too many arguments (8/7)
[INFO] [stderr]    --> src/message_types/srd_accept.rs:109:5
[INFO] [stderr]     |
[INFO] [stderr] 109 | /     pub fn new(
[INFO] [stderr] 110 | |         seq_num: u8,
[INFO] [stderr] 111 | |         cipher: u32,
[INFO] [stderr] 112 | |         key_size: u16,
[INFO] [stderr] ...   |
[INFO] [stderr] 146 | |         Ok(response)
[INFO] [stderr] 147 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::too_many_arguments)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stderr] 
[INFO] [stderr] warning: The function/method `write_all` doesn't need a mutable reference
[INFO] [stderr]    --> src/srd.rs:428:57
[INFO] [stderr]     |
[INFO] [stderr] 428 |                 hmac.result().code().to_vec().write_all(&mut cbt_data)?;
[INFO] [stderr]     |                                                         ^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unnecessary_mut_passed)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stderr] 
[INFO] [stderr] warning: The function/method `write_all` doesn't need a mutable reference
[INFO] [stderr]    --> src/srd.rs:505:57
[INFO] [stderr]     |
[INFO] [stderr] 505 |                 hmac.result().code().to_vec().write_all(&mut cbt_data)?;
[INFO] [stderr]     |                                                         ^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stderr] 
[INFO] [stderr] warning: The function/method `write_all` doesn't need a mutable reference
[INFO] [stderr]    --> src/srd.rs:526:57
[INFO] [stderr]     |
[INFO] [stderr] 526 |                 hmac.result().code().to_vec().write_all(&mut cbt_data)?;
[INFO] [stderr]     |                                                         ^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stderr] 
[INFO] [stderr] warning: The function/method `write_all` doesn't need a mutable reference
[INFO] [stderr]    --> src/srd.rs:564:57
[INFO] [stderr]     |
[INFO] [stderr] 564 |                 hmac.result().code().to_vec().write_all(&mut cbt_data)?;
[INFO] [stderr]     |                                                         ^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/srd_errors.rs:34:9
[INFO] [stderr]    |
[INFO] [stderr] 34 | /         match self {
[INFO] [stderr] 35 | |             &SrdError::Io(ref error) => error.fmt(f),
[INFO] [stderr] 36 | |             &SrdError::Ffi(ref _error) => write!(f, "FFI error"),
[INFO] [stderr] 37 | |             &SrdError::BadSequence => write!(f, "Sequence error"),
[INFO] [stderr] ...  |
[INFO] [stderr] 50 | |             &SrdError::InvalidSignature => write!(f, "Signature error"),
[INFO] [stderr] 51 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 34 |         match *self {
[INFO] [stderr] 35 |             SrdError::Io(ref error) => error.fmt(f),
[INFO] [stderr] 36 |             SrdError::Ffi(ref _error) => write!(f, "FFI error"),
[INFO] [stderr] 37 |             SrdError::BadSequence => write!(f, "Sequence error"),
[INFO] [stderr] 38 |             SrdError::Crypto => write!(f, "Cryptographic error"),
[INFO] [stderr] 39 |             SrdError::MissingBlob => write!(f, "Blob error"),
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe`
[INFO] [stderr]   --> src/ffi.rs:17:39
[INFO] [stderr]    |
[INFO] [stderr] 17 |     let _srd = unsafe { Box::from_raw(srd_handle) };
[INFO] [stderr]    |                                       ^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::not_unsafe_ptr_arg_deref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
[INFO] [stderr] 
[INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe`
[INFO] [stderr]   --> src/ffi.rs:22:30
[INFO] [stderr]    |
[INFO] [stderr] 22 |     let srd = unsafe { &mut *srd_handle };
[INFO] [stderr]    |                              ^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
[INFO] [stderr] 
[INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe`
[INFO] [stderr]   --> src/ffi.rs:24:64
[INFO] [stderr]    |
[INFO] [stderr] 24 |     let input_data = unsafe { std::slice::from_raw_parts::<u8>(buffer, buffer_size as usize) };
[INFO] [stderr]    |                                                                ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
[INFO] [stderr] 
[INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe`
[INFO] [stderr]   --> src/ffi.rs:44:30
[INFO] [stderr]    |
[INFO] [stderr] 44 |     let srd = unsafe { &mut *srd_handle };
[INFO] [stderr]    |                              ^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
[INFO] [stderr] 
[INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe`
[INFO] [stderr]   --> src/ffi.rs:54:77
[INFO] [stderr]    |
[INFO] [stderr] 54 |             let buffer_data = unsafe { std::slice::from_raw_parts_mut::<u8>(buffer, buffer_size as usize) };
[INFO] [stderr]    |                                                                             ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/ffi.rs:46:5
[INFO] [stderr]    |
[INFO] [stderr] 46 | /     if let &Some(ref output_data) = srd.get_output_data() {
[INFO] [stderr] 47 | |         let output_size = output_data.len() as i32;
[INFO] [stderr] 48 | | 
[INFO] [stderr] 49 | |         if buffer != std::ptr::null_mut() {
[INFO] [stderr] ...  |
[INFO] [stderr] 57 | |         return output_size;
[INFO] [stderr] 58 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 46 |     if let Some(ref output_data) = *srd.get_output_data() {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^^^   ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: The function/method `write_all` doesn't need a mutable reference
[INFO] [stderr]    --> src/srd.rs:428:57
[INFO] [stderr]     |
[INFO] [stderr] 428 |                 hmac.result().code().to_vec().write_all(&mut cbt_data)?;
[INFO] [stderr]     |                                                         ^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unnecessary_mut_passed)] on by default
[INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method
[INFO] [stderr]   --> src/ffi.rs:49:12
[INFO] [stderr]    |
[INFO] [stderr] 49 |         if buffer != std::ptr::null_mut() {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cmp_null)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null
[INFO] [stderr] 
[INFO] [stderr] 
[INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe`
[INFO] [stderr]   --> src/ffi.rs:72:30
[INFO] [stderr]    |
[INFO] [stderr] 72 |     let srd = unsafe { &mut *srd_handle };
[INFO] [stderr]    |                              ^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
[INFO] [stderr] 
[INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe`
[INFO] [stderr]   --> src/ffi.rs:74:63
[INFO] [stderr]    |
[INFO] [stderr] 74 |     let blob_name = unsafe { std::slice::from_raw_parts::<u8>(blob_name, blob_name_size as usize) };
[INFO] [stderr]    |                                                               ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
[INFO] [stderr] 
[INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe`
[INFO] [stderr]   --> src/ffi.rs:75:63
[INFO] [stderr]    |
[INFO] [stderr] 75 |     let blob_data = unsafe { std::slice::from_raw_parts::<u8>(blob_data, blob_data_size as usize) };
[INFO] [stderr]    |                                                               ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
[INFO] [stderr] 
[INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe`
[INFO] [stderr]   --> src/ffi.rs:91:30
[INFO] [stderr]    |
[INFO] [stderr] 91 |     let srd = unsafe { &mut *srd_handle };
[INFO] [stderr]    |                              ^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
[INFO] [stderr] 
[INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe`
[INFO] [stderr]    --> src/ffi.rs:102:77
[INFO] [stderr]     |
[INFO] [stderr] 102 |             let buffer_data = unsafe { std::slice::from_raw_parts_mut::<u8>(buffer, buffer_size as usize) };
[INFO] [stderr]     |                                                                             ^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
[INFO] [stderr] 
[INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method
[INFO] [stderr]   --> src/ffi.rs:97:12
[INFO] [stderr]    |
[INFO] [stderr] 97 |         if buffer != std::ptr::null_mut() {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null
[INFO] [stderr] 
[INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe`
[INFO] [stderr]    --> src/ffi.rs:115:30
[INFO] [stderr]     |
[INFO] [stderr] 115 |     let srd = unsafe { &mut *srd_handle };
[INFO] [stderr]     |                              ^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
[INFO] [stderr] 
[INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe`
[INFO] [stderr]    --> src/ffi.rs:125:77
[INFO] [stderr]     |
[INFO] [stderr] 125 |             let buffer_data = unsafe { std::slice::from_raw_parts_mut::<u8>(buffer, buffer_size as usize) };
[INFO] [stderr]     |                                                                             ^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
[INFO] [stderr] 
[INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method
[INFO] [stderr]    --> src/ffi.rs:120:12
[INFO] [stderr]     |
[INFO] [stderr] 120 |         if buffer != std::ptr::null_mut() {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null
[INFO] [stderr] 
[INFO] [stderr] warning: The function/method `write_all` doesn't need a mutable reference
[INFO] [stderr]    --> src/srd.rs:505:57
[INFO] [stderr]     |
[INFO] [stderr] 505 |                 hmac.result().code().to_vec().write_all(&mut cbt_data)?;
[INFO] [stderr]     |                                                         ^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe`
[INFO] [stderr]    --> src/ffi.rs:137:30
[INFO] [stderr]     |
[INFO] [stderr] 137 |     let srd = unsafe { &mut *srd_handle };
[INFO] [stderr]     |                              ^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
[INFO] [stderr] 
[INFO] [stderr] 
[INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe`
[INFO] [stderr]    --> src/ffi.rs:138:63
[INFO] [stderr]     |
[INFO] [stderr] 138 |     let cert_data = unsafe { std::slice::from_raw_parts::<u8>(data, data_size as usize) };
[INFO] [stderr]     |                                                               ^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
[INFO] [stderr] 
[INFO] [stderr] warning: The function/method `write_all` doesn't need a mutable reference
[INFO] [stderr]    --> src/srd.rs:526:57
[INFO] [stderr]     |
[INFO] [stderr] 526 |                 hmac.result().code().to_vec().write_all(&mut cbt_data)?;
[INFO] [stderr]     |                                                         ^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stderr] 
[INFO] [stderr] warning: The function/method `write_all` doesn't need a mutable reference
[INFO] [stderr]    --> src/srd.rs:564:57
[INFO] [stderr]     |
[INFO] [stderr] 564 |                 hmac.result().code().to_vec().write_all(&mut cbt_data)?;
[INFO] [stderr]     |                                                         ^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 14 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `sardine`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: useless use of `vec!`
[INFO] [stderr]    --> src/srd_blob/mod.rs:134:46
[INFO] [stderr]     |
[INFO] [stderr] 134 |         let srd_blob = SrdBlob::new("Basic", &vec![0, 1, 2, 3]);
[INFO] [stderr]     |                                              ^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[0, 1, 2, 3]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_vec)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/srd_errors.rs:34:9
[INFO] [stderr]    |
[INFO] [stderr] 34 | /         match self {
[INFO] [stderr] 35 | |             &SrdError::Io(ref error) => error.fmt(f),
[INFO] [stderr] 36 | |             &SrdError::Ffi(ref _error) => write!(f, "FFI error"),
[INFO] [stderr] 37 | |             &SrdError::BadSequence => write!(f, "Sequence error"),
[INFO] [stderr] ...  |
[INFO] [stderr] 50 | |             &SrdError::InvalidSignature => write!(f, "Signature error"),
[INFO] [stderr] 51 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 34 |         match *self {
[INFO] [stderr] 35 |             SrdError::Io(ref error) => error.fmt(f),
[INFO] [stderr] 36 |             SrdError::Ffi(ref _error) => write!(f, "FFI error"),
[INFO] [stderr] 37 |             SrdError::BadSequence => write!(f, "Sequence error"),
[INFO] [stderr] 38 |             SrdError::Crypto => write!(f, "Cryptographic error"),
[INFO] [stderr] 39 |             SrdError::MissingBlob => write!(f, "Blob error"),
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe`
[INFO] [stderr]   --> src/ffi.rs:17:39
[INFO] [stderr]    |
[INFO] [stderr] 17 |     let _srd = unsafe { Box::from_raw(srd_handle) };
[INFO] [stderr]    |                                       ^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::not_unsafe_ptr_arg_deref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
[INFO] [stderr] 
[INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe`
[INFO] [stderr]   --> src/ffi.rs:22:30
[INFO] [stderr]    |
[INFO] [stderr] 22 |     let srd = unsafe { &mut *srd_handle };
[INFO] [stderr]    |                              ^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
[INFO] [stderr] 
[INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe`
[INFO] [stderr]   --> src/ffi.rs:24:64
[INFO] [stderr]    |
[INFO] [stderr] 24 |     let input_data = unsafe { std::slice::from_raw_parts::<u8>(buffer, buffer_size as usize) };
[INFO] [stderr]    |                                                                ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
[INFO] [stderr] 
[INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe`
[INFO] [stderr]   --> src/ffi.rs:44:30
[INFO] [stderr]    |
[INFO] [stderr] 44 |     let srd = unsafe { &mut *srd_handle };
[INFO] [stderr]    |                              ^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
[INFO] [stderr] 
[INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe`
[INFO] [stderr]   --> src/ffi.rs:54:77
[INFO] [stderr]    |
[INFO] [stderr] 54 |             let buffer_data = unsafe { std::slice::from_raw_parts_mut::<u8>(buffer, buffer_size as usize) };
[INFO] [stderr]    |                                                                             ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/ffi.rs:46:5
[INFO] [stderr]    |
[INFO] [stderr] 46 | /     if let &Some(ref output_data) = srd.get_output_data() {
[INFO] [stderr] 47 | |         let output_size = output_data.len() as i32;
[INFO] [stderr] 48 | | 
[INFO] [stderr] 49 | |         if buffer != std::ptr::null_mut() {
[INFO] [stderr] ...  |
[INFO] [stderr] 57 | |         return output_size;
[INFO] [stderr] 58 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 46 |     if let Some(ref output_data) = *srd.get_output_data() {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^^^   ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method
[INFO] [stderr]   --> src/ffi.rs:49:12
[INFO] [stderr]    |
[INFO] [stderr] 49 |         if buffer != std::ptr::null_mut() {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cmp_null)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null
[INFO] [stderr] 
[INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe`
[INFO] [stderr]   --> src/ffi.rs:72:30
[INFO] [stderr]    |
[INFO] [stderr] 72 |     let srd = unsafe { &mut *srd_handle };
[INFO] [stderr]    |                              ^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
[INFO] [stderr] 
[INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe`
[INFO] [stderr]   --> src/ffi.rs:74:63
[INFO] [stderr]    |
[INFO] [stderr] 74 |     let blob_name = unsafe { std::slice::from_raw_parts::<u8>(blob_name, blob_name_size as usize) };
[INFO] [stderr]    |                                                               ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
[INFO] [stderr] 
[INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe`
[INFO] [stderr]   --> src/ffi.rs:75:63
[INFO] [stderr]    |
[INFO] [stderr] 75 |     let blob_data = unsafe { std::slice::from_raw_parts::<u8>(blob_data, blob_data_size as usize) };
[INFO] [stderr]    |                                                               ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
[INFO] [stderr] 
[INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe`
[INFO] [stderr]   --> src/ffi.rs:91:30
[INFO] [stderr]    |
[INFO] [stderr] 91 |     let srd = unsafe { &mut *srd_handle };
[INFO] [stderr]    |                              ^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
[INFO] [stderr] 
[INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe`
[INFO] [stderr]    --> src/ffi.rs:102:77
[INFO] [stderr]     |
[INFO] [stderr] 102 |             let buffer_data = unsafe { std::slice::from_raw_parts_mut::<u8>(buffer, buffer_size as usize) };
[INFO] [stderr]     |                                                                             ^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
[INFO] [stderr] 
[INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method
[INFO] [stderr]   --> src/ffi.rs:97:12
[INFO] [stderr]    |
[INFO] [stderr] 97 |         if buffer != std::ptr::null_mut() {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null
[INFO] [stderr] 
[INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe`
[INFO] [stderr]    --> src/ffi.rs:115:30
[INFO] [stderr]     |
[INFO] [stderr] 115 |     let srd = unsafe { &mut *srd_handle };
[INFO] [stderr]     |                              ^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
[INFO] [stderr] 
[INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe`
[INFO] [stderr]    --> src/ffi.rs:125:77
[INFO] [stderr]     |
[INFO] [stderr] 125 |             let buffer_data = unsafe { std::slice::from_raw_parts_mut::<u8>(buffer, buffer_size as usize) };
[INFO] [stderr]     |                                                                             ^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
[INFO] [stderr] 
[INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method
[INFO] [stderr]    --> src/ffi.rs:120:12
[INFO] [stderr]     |
[INFO] [stderr] 120 |         if buffer != std::ptr::null_mut() {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null
[INFO] [stderr] 
[INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe`
[INFO] [stderr]    --> src/ffi.rs:137:30
[INFO] [stderr]     |
[INFO] [stderr] 137 |     let srd = unsafe { &mut *srd_handle };
[INFO] [stderr]     |                              ^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
[INFO] [stderr] 
[INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe`
[INFO] [stderr]    --> src/ffi.rs:138:63
[INFO] [stderr]     |
[INFO] [stderr] 138 |     let cert_data = unsafe { std::slice::from_raw_parts::<u8>(data, data_size as usize) };
[INFO] [stderr]     |                                                               ^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 14 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `sardine`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "dd9c4da5e372fa0b5184669f0b13700b92535b43f2b5757cf0c3ecc70f93273a"`
[INFO] running `"docker" "rm" "-f" "dd9c4da5e372fa0b5184669f0b13700b92535b43f2b5757cf0c3ecc70f93273a"`
[INFO] [stdout] dd9c4da5e372fa0b5184669f0b13700b92535b43f2b5757cf0c3ecc70f93273a