[INFO] crate sanitize_html 0.3.0 is already in cache
[INFO] extracting crate sanitize_html 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/sanitize_html/0.3.0
[INFO] extracting crate sanitize_html 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sanitize_html/0.3.0
[INFO] validating manifest of sanitize_html-0.3.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of sanitize_html-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing sanitize_html-0.3.0
[INFO] finished frobbing sanitize_html-0.3.0
[INFO] frobbed toml for sanitize_html-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/sanitize_html/0.3.0/Cargo.toml
[INFO] started frobbing sanitize_html-0.3.0
[INFO] finished frobbing sanitize_html-0.3.0
[INFO] frobbed toml for sanitize_html-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sanitize_html/0.3.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting sanitize_html-0.3.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/sanitize_html/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 0ba4922c784faf4531d0fb15a2efed37fdd9c9cf9eb4734d8174e85fb0e77eca
[INFO] running `"docker" "start" "-a" "0ba4922c784faf4531d0fb15a2efed37fdd9c9cf9eb4734d8174e85fb0e77eca"`
[INFO] [stderr] Checking sanitize_html v0.3.0 (/opt/crater/workdir)
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `rules::Rules`
[INFO] [stderr] --> src/rules/mod.rs:68:5
[INFO] [stderr] |
[INFO] [stderr] 68 | / pub fn new() -> Self {
[INFO] [stderr] 69 | | Self {
[INFO] [stderr] 70 | | allow_comments: false,
[INFO] [stderr] 71 | | allowed_elements: HashMap::new(),
[INFO] [stderr] ... |
[INFO] [stderr] 75 | | }
[INFO] [stderr] 76 | | }
[INFO] [stderr] | |_____^
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr] |
[INFO] [stderr] 53 | #[derive(Default)]
[INFO] [stderr] |
[INFO] [stderr]
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr] --> src/sanitize.rs:69:40
[INFO] [stderr] |
[INFO] [stderr] 69 | fn clean_nodes(dom: &mut RcDom, nodes: &Vec, rules: &Rules) -> Vec {
[INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[Handle]`
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr]
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr] --> src/sanitize.rs:79:5
[INFO] [stderr] |
[INFO] [stderr] 79 | / match &node.data {
[INFO] [stderr] 80 | | &NodeData::Document => vec![],
[INFO] [stderr] 81 | | &NodeData::Doctype { .. } => vec![],
[INFO] [stderr] 82 | | &NodeData::ProcessingInstruction { .. } => vec![],
[INFO] [stderr] ... |
[INFO] [stderr] 138 | | },
[INFO] [stderr] 139 | | }
[INFO] [stderr] | |_____^
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr] |
[INFO] [stderr] 79 | match node.data {
[INFO] [stderr] 80 | NodeData::Document => vec![],
[INFO] [stderr] 81 | NodeData::Doctype { .. } => vec![],
[INFO] [stderr] 82 | NodeData::ProcessingInstruction { .. } => vec![],
[INFO] [stderr] 83 |
[INFO] [stderr] 84 | NodeData::Text { .. } => vec![node.clone()],
[INFO] [stderr] ...
[INFO] [stderr]
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `rules::Rules`
[INFO] [stderr] --> src/rules/mod.rs:68:5
[INFO] [stderr] |
[INFO] [stderr] 68 | / pub fn new() -> Self {
[INFO] [stderr] 69 | | Self {
[INFO] [stderr] 70 | | allow_comments: false,
[INFO] [stderr] 71 | | allowed_elements: HashMap::new(),
[INFO] [stderr] ... |
[INFO] [stderr] 75 | | }
[INFO] [stderr] 76 | | }
[INFO] [stderr] | |_____^
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr] |
[INFO] [stderr] 53 | #[derive(Default)]
[INFO] [stderr] |
[INFO] [stderr]
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr] --> src/sanitize.rs:69:40
[INFO] [stderr] |
[INFO] [stderr] 69 | fn clean_nodes(dom: &mut RcDom, nodes: &Vec, rules: &Rules) -> Vec {
[INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[Handle]`
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr]
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr] --> src/sanitize.rs:79:5
[INFO] [stderr] |
[INFO] [stderr] 79 | / match &node.data {
[INFO] [stderr] 80 | | &NodeData::Document => vec![],
[INFO] [stderr] 81 | | &NodeData::Doctype { .. } => vec![],
[INFO] [stderr] 82 | | &NodeData::ProcessingInstruction { .. } => vec![],
[INFO] [stderr] ... |
[INFO] [stderr] 138 | | },
[INFO] [stderr] 139 | | }
[INFO] [stderr] | |_____^
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr] |
[INFO] [stderr] 79 | match node.data {
[INFO] [stderr] 80 | NodeData::Document => vec![],
[INFO] [stderr] 81 | NodeData::Doctype { .. } => vec![],
[INFO] [stderr] 82 | NodeData::ProcessingInstruction { .. } => vec![],
[INFO] [stderr] 83 |
[INFO] [stderr] 84 | NodeData::Text { .. } => vec![node.clone()],
[INFO] [stderr] ...
[INFO] [stderr]
[INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.68s
[INFO] running `"docker" "inspect" "0ba4922c784faf4531d0fb15a2efed37fdd9c9cf9eb4734d8174e85fb0e77eca"`
[INFO] running `"docker" "rm" "-f" "0ba4922c784faf4531d0fb15a2efed37fdd9c9cf9eb4734d8174e85fb0e77eca"`
[INFO] [stdout] 0ba4922c784faf4531d0fb15a2efed37fdd9c9cf9eb4734d8174e85fb0e77eca