[INFO] crate sandbox-ipc 0.4.0 is already in cache [INFO] extracting crate sandbox-ipc 0.4.0 into work/ex/clippy-test-run/sources/stable/reg/sandbox-ipc/0.4.0 [INFO] extracting crate sandbox-ipc 0.4.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sandbox-ipc/0.4.0 [INFO] validating manifest of sandbox-ipc-0.4.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sandbox-ipc-0.4.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sandbox-ipc-0.4.0 [INFO] removed 2 missing tests [INFO] finished frobbing sandbox-ipc-0.4.0 [INFO] frobbed toml for sandbox-ipc-0.4.0 written to work/ex/clippy-test-run/sources/stable/reg/sandbox-ipc/0.4.0/Cargo.toml [INFO] started frobbing sandbox-ipc-0.4.0 [INFO] removed 2 missing tests [INFO] finished frobbing sandbox-ipc-0.4.0 [INFO] frobbed toml for sandbox-ipc-0.4.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sandbox-ipc/0.4.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sandbox-ipc-0.4.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/sandbox-ipc/0.4.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 19ec3edbd5689401a709e4606eda04e6acdd1740b1f7e042f084fa8db89197cf [INFO] running `"docker" "start" "-a" "19ec3edbd5689401a709e4606eda04e6acdd1740b1f7e042f084fa8db89197cf"` [INFO] [stderr] Checking bincode v0.9.2 [INFO] [stderr] Checking uuid v0.5.1 [INFO] [stderr] Checking sandbox-ipc v0.4.0 (/opt/crater/workdir) [INFO] [stderr] warning: defining a method called `clone` on this type; consider implementing the `std::clone::Clone` trait or choosing a less ambiguous name [INFO] [stderr] --> src/channel.rs:362:5 [INFO] [stderr] | [INFO] [stderr] 362 | / pub fn clone(&self) -> io::Result { [INFO] [stderr] 363 | | Ok(ProcessHandle( [INFO] [stderr] 364 | | self.0.clone()? [INFO] [stderr] 365 | | )) [INFO] [stderr] 366 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/io.rs:82:20 [INFO] [stderr] | [INFO] [stderr] 82 | pub fn to_read(self) -> io::Result { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/io.rs:104:21 [INFO] [stderr] | [INFO] [stderr] 104 | pub fn to_bytes(self) -> io::Result { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/sync.rs:71:22 [INFO] [stderr] | [INFO] [stderr] 71 | let poison = memory.borrow().pointer().offset((offset + platform::MUTEX_SHM_SIZE) as isize) as *const AtomicBool; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `memory.borrow().pointer().add((offset + platform::MUTEX_SHM_SIZE))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: item `shm::SharedMemMap` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/shm/mod.rs:64:1 [INFO] [stderr] | [INFO] [stderr] 64 | / impl SharedMemMap { [INFO] [stderr] 65 | | pub unsafe fn pointer(&self) -> *mut u8 { self.0.inner.pointer() } [INFO] [stderr] 66 | | pub fn len(&self) -> usize { self.0.inner.len() } [INFO] [stderr] 67 | | pub fn access(&self) -> Access { self.0.inner.access() } [INFO] [stderr] ... | [INFO] [stderr] 70 | | pub(crate) fn token(&self) -> Uuid { self.0.object.0.token } [INFO] [stderr] 71 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: The function/method `write` doesn't need a mutable reference [INFO] [stderr] --> src/ser.rs:112:55 [INFO] [stderr] | [INFO] [stderr] 112 | let written_bytes = try_nb!(self.io.write(&mut self.tx_buffer[0..msg_len])); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/unix/channel.rs:233:23 [INFO] [stderr] | [INFO] [stderr] 233 | name: OsString::from(name), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `OsString::from()`: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/unix/channel.rs:319:20 [INFO] [stderr] | [INFO] [stderr] 319 | pub fn new(fd: &'a RawFd) -> io::Result { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `RawFd` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/unix/sharedmem.rs:165:36 [INFO] [stderr] | [INFO] [stderr] 165 | user_pointer: unsafe { (mapping_ptr as *mut u8).offset(user_offset_shift as isize) }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(mapping_ptr as *mut u8).add(user_offset_shift)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] error: casting from `*mut u8` to a more-strictly-aligned pointer (`*const std::sync::atomic::AtomicUsize`) [INFO] [stderr] --> src/unix/sync.rs:48:24 [INFO] [stderr] | [INFO] [stderr] 48 | let refcount = memory.pointer().offset(offset as isize) as *const AtomicUsize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::cast_ptr_alignment)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/unix/sync.rs:48:24 [INFO] [stderr] | [INFO] [stderr] 48 | let refcount = memory.pointer().offset(offset as isize) as *const AtomicUsize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `memory.pointer().add(offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] error: casting from `*mut u8` to a more-strictly-aligned pointer (`*const std::sync::atomic::AtomicUsize`) [INFO] [stderr] --> src/unix/sync.rs:81:24 [INFO] [stderr] | [INFO] [stderr] 81 | let refcount = memory.pointer().offset(offset as isize) as *const AtomicUsize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/unix/sync.rs:81:24 [INFO] [stderr] | [INFO] [stderr] 81 | let refcount = memory.pointer().offset(offset as isize) as *const AtomicUsize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `memory.pointer().add(offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/unix/mod.rs:44:26 [INFO] [stderr] | [INFO] [stderr] 44 | .map_err(|err| S::Error::custom(err))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `S::Error::custom` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/unix/mod.rs:72:26 [INFO] [stderr] | [INFO] [stderr] 72 | .map_err(|err| D::Error::custom(err))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `D::Error::custom` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/unix/mod.rs:273:53 [INFO] [stderr] | [INFO] [stderr] 273 | addr.sun_path[..path.len()].copy_from_slice(mem::transmute(path.as_bytes())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(path.as_bytes() as *const [u8] as *const [i8])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/unix/mod.rs:286:5 [INFO] [stderr] | [INFO] [stderr] 286 | / (cmsg as *mut libc::c_uchar).offset(CMSG_ALIGN( [INFO] [stderr] 287 | | mem::size_of::()) as isize) as *mut libc::c_void [INFO] [stderr] | |______________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 286 | (cmsg as *mut libc::c_uchar).add(CMSG_ALIGN( [INFO] [stderr] 287 | mem::size_of::())) as *mut libc::c_void [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: casting from `*mut u8` to a more-strictly-aligned pointer (`*mut platform::libc::cmsghdr`) [INFO] [stderr] --> src/unix/mod.rs:320:34 [INFO] [stderr] | [INFO] [stderr] 320 | let cmsg_hdr = &mut *(buffer.as_mut_ptr() as *mut libc::cmsghdr); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*mut u8` to a more-strictly-aligned pointer (`*mut platform::libc::cmsghdr`) [INFO] [stderr] --> src/unix/mod.rs:346:39 [INFO] [stderr] | [INFO] [stderr] 346 | let cmsg_hdr = unsafe { &mut *(self.buffer.as_mut_ptr() as *mut libc::cmsghdr) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*mut platform::libc::cmsghdr`) [INFO] [stderr] --> src/unix/mod.rs:351:69 [INFO] [stderr] | [INFO] [stderr] 351 | let fds_dest = unsafe { slice::from_raw_parts_mut(CMSG_DATA(self.buffer.as_ptr() as _) as *mut libc::c_int, fds.len()) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*mut u8` to a more-strictly-aligned pointer (`*mut platform::libc::cmsghdr`) [INFO] [stderr] --> src/unix/mod.rs:356:39 [INFO] [stderr] | [INFO] [stderr] 356 | let cmsg_hdr = unsafe { &mut *(self.buffer.as_mut_ptr() as *mut libc::cmsghdr) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const platform::libc::cmsghdr`) [INFO] [stderr] --> src/unix/mod.rs:363:35 [INFO] [stderr] | [INFO] [stderr] 363 | let cmsg_hdr = unsafe { &*(self.buffer.as_ptr() as *const libc::cmsghdr) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*mut platform::libc::cmsghdr`) [INFO] [stderr] --> src/unix/mod.rs:372:50 [INFO] [stderr] | [INFO] [stderr] 372 | unsafe { slice::from_raw_parts(CMSG_DATA(self.buffer.as_ptr() as _) as *mut libc::c_int, self.current_fd_count()) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: aborting due to 8 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `sandbox-ipc`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: use of deprecated item 'tokio_all::runtime::Runtime::reactor': there is now a reactor per worker thread [INFO] [stderr] --> src/io.rs:170:81 [INFO] [stderr] | [INFO] [stderr] 170 | let (a, b) = MessageChannel::::pair(runtime.reactor(), 8192).unwrap(); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_all::runtime::Runtime::reactor': there is now a reactor per worker thread [INFO] [stderr] --> src/shm/mod.rs:122:51 [INFO] [stderr] | [INFO] [stderr] 122 | let (a, b) = MessageChannel::pair(runtime.reactor(), 8192).unwrap(); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: defining a method called `clone` on this type; consider implementing the `std::clone::Clone` trait or choosing a less ambiguous name [INFO] [stderr] --> src/channel.rs:362:5 [INFO] [stderr] | [INFO] [stderr] 362 | / pub fn clone(&self) -> io::Result { [INFO] [stderr] 363 | | Ok(ProcessHandle( [INFO] [stderr] 364 | | self.0.clone()? [INFO] [stderr] 365 | | )) [INFO] [stderr] 366 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/io.rs:82:20 [INFO] [stderr] | [INFO] [stderr] 82 | pub fn to_read(self) -> io::Result { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/io.rs:104:21 [INFO] [stderr] | [INFO] [stderr] 104 | pub fn to_bytes(self) -> io::Result { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/sync.rs:71:22 [INFO] [stderr] | [INFO] [stderr] 71 | let poison = memory.borrow().pointer().offset((offset + platform::MUTEX_SHM_SIZE) as isize) as *const AtomicBool; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `memory.borrow().pointer().add((offset + platform::MUTEX_SHM_SIZE))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/shm/queue.rs:69:26 [INFO] [stderr] | [INFO] [stderr] 69 | let items_base = memory.borrow().pointer().offset(offset as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `memory.borrow().pointer().add(offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] error: casting from `*mut u8` to a more-strictly-aligned pointer (`*mut shm::queue::SharedMemQueueCtrl`) [INFO] [stderr] --> src/shm/queue.rs:70:23 [INFO] [stderr] | [INFO] [stderr] 70 | let control = items_base.offset((item_count * item_offset) as isize) as *mut SharedMemQueueCtrl; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::cast_ptr_alignment)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/shm/queue.rs:70:23 [INFO] [stderr] | [INFO] [stderr] 70 | let control = items_base.offset((item_count * item_offset) as isize) as *mut SharedMemQueueCtrl; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `items_base.add((item_count * item_offset))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/shm/queue.rs:109:26 [INFO] [stderr] | [INFO] [stderr] 109 | items_base = memory.borrow().pointer().offset(local_offset as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `memory.borrow().pointer().add(local_offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] error: casting from `*mut u8` to a more-strictly-aligned pointer (`*const shm::queue::SharedMemQueueCtrl`) [INFO] [stderr] --> src/shm/queue.rs:110:23 [INFO] [stderr] | [INFO] [stderr] 110 | control = items_base.offset((handle.item_count * item_offset) as isize) as *const SharedMemQueueCtrl; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/shm/queue.rs:110:23 [INFO] [stderr] | [INFO] [stderr] 110 | control = items_base.offset((handle.item_count * item_offset) as isize) as *const SharedMemQueueCtrl; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `items_base.add((handle.item_count * item_offset))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/shm/queue.rs:176:17 [INFO] [stderr] | [INFO] [stderr] 176 | self.items_base.offset(((send_index % self.item_count) * self.item_offset) as isize), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.items_base.add(((send_index % self.item_count) * self.item_offset))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/shm/queue.rs:224:17 [INFO] [stderr] | [INFO] [stderr] 224 | self.items_base.offset(((recv_index % self.item_count) * self.item_offset) as isize), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.items_base.add(((recv_index % self.item_count) * self.item_offset))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] error: mutable borrow from immutable input(s) [INFO] [stderr] --> src/shm/queue.rs:306:38 [INFO] [stderr] | [INFO] [stderr] 306 | pub unsafe fn as_bytes(&self) -> &mut [u8] { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::mut_from_ref)] on by default [INFO] [stderr] note: immutable borrow here [INFO] [stderr] --> src/shm/queue.rs:306:28 [INFO] [stderr] | [INFO] [stderr] 306 | pub unsafe fn as_bytes(&self) -> &mut [u8] { [INFO] [stderr] | ^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_from_ref [INFO] [stderr] [INFO] [stderr] warning: item `shm::SharedMemMap` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/shm/mod.rs:64:1 [INFO] [stderr] | [INFO] [stderr] 64 | / impl SharedMemMap { [INFO] [stderr] 65 | | pub unsafe fn pointer(&self) -> *mut u8 { self.0.inner.pointer() } [INFO] [stderr] 66 | | pub fn len(&self) -> usize { self.0.inner.len() } [INFO] [stderr] 67 | | pub fn access(&self) -> Access { self.0.inner.access() } [INFO] [stderr] ... | [INFO] [stderr] 70 | | pub(crate) fn token(&self) -> Uuid { self.0.object.0.token } [INFO] [stderr] 71 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: The function/method `write` doesn't need a mutable reference [INFO] [stderr] --> src/ser.rs:112:55 [INFO] [stderr] | [INFO] [stderr] 112 | let written_bytes = try_nb!(self.io.write(&mut self.tx_buffer[0..msg_len])); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/unix/channel.rs:233:23 [INFO] [stderr] | [INFO] [stderr] 233 | name: OsString::from(name), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `OsString::from()`: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/unix/channel.rs:319:20 [INFO] [stderr] | [INFO] [stderr] 319 | pub fn new(fd: &'a RawFd) -> io::Result { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `RawFd` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/unix/sharedmem.rs:165:36 [INFO] [stderr] | [INFO] [stderr] 165 | user_pointer: unsafe { (mapping_ptr as *mut u8).offset(user_offset_shift as isize) }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(mapping_ptr as *mut u8).add(user_offset_shift)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] error: casting from `*mut u8` to a more-strictly-aligned pointer (`*const std::sync::atomic::AtomicUsize`) [INFO] [stderr] --> src/unix/sync.rs:48:24 [INFO] [stderr] | [INFO] [stderr] 48 | let refcount = memory.pointer().offset(offset as isize) as *const AtomicUsize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/unix/sync.rs:48:24 [INFO] [stderr] | [INFO] [stderr] 48 | let refcount = memory.pointer().offset(offset as isize) as *const AtomicUsize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `memory.pointer().add(offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] error: casting from `*mut u8` to a more-strictly-aligned pointer (`*const std::sync::atomic::AtomicUsize`) [INFO] [stderr] --> src/unix/sync.rs:81:24 [INFO] [stderr] | [INFO] [stderr] 81 | let refcount = memory.pointer().offset(offset as isize) as *const AtomicUsize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/unix/sync.rs:81:24 [INFO] [stderr] | [INFO] [stderr] 81 | let refcount = memory.pointer().offset(offset as isize) as *const AtomicUsize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `memory.pointer().add(offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/unix/mod.rs:44:26 [INFO] [stderr] | [INFO] [stderr] 44 | .map_err(|err| S::Error::custom(err))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `S::Error::custom` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/unix/mod.rs:72:26 [INFO] [stderr] | [INFO] [stderr] 72 | .map_err(|err| D::Error::custom(err))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `D::Error::custom` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/unix/mod.rs:273:53 [INFO] [stderr] | [INFO] [stderr] 273 | addr.sun_path[..path.len()].copy_from_slice(mem::transmute(path.as_bytes())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(path.as_bytes() as *const [u8] as *const [i8])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/unix/mod.rs:286:5 [INFO] [stderr] | [INFO] [stderr] 286 | / (cmsg as *mut libc::c_uchar).offset(CMSG_ALIGN( [INFO] [stderr] 287 | | mem::size_of::()) as isize) as *mut libc::c_void [INFO] [stderr] | |______________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 286 | (cmsg as *mut libc::c_uchar).add(CMSG_ALIGN( [INFO] [stderr] 287 | mem::size_of::())) as *mut libc::c_void [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: casting from `*mut u8` to a more-strictly-aligned pointer (`*mut platform::libc::cmsghdr`) [INFO] [stderr] --> src/unix/mod.rs:320:34 [INFO] [stderr] | [INFO] [stderr] 320 | let cmsg_hdr = &mut *(buffer.as_mut_ptr() as *mut libc::cmsghdr); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*mut u8` to a more-strictly-aligned pointer (`*mut platform::libc::cmsghdr`) [INFO] [stderr] --> src/unix/mod.rs:346:39 [INFO] [stderr] | [INFO] [stderr] 346 | let cmsg_hdr = unsafe { &mut *(self.buffer.as_mut_ptr() as *mut libc::cmsghdr) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*mut platform::libc::cmsghdr`) [INFO] [stderr] --> src/unix/mod.rs:351:69 [INFO] [stderr] | [INFO] [stderr] 351 | let fds_dest = unsafe { slice::from_raw_parts_mut(CMSG_DATA(self.buffer.as_ptr() as _) as *mut libc::c_int, fds.len()) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*mut u8` to a more-strictly-aligned pointer (`*mut platform::libc::cmsghdr`) [INFO] [stderr] --> src/unix/mod.rs:356:39 [INFO] [stderr] | [INFO] [stderr] 356 | let cmsg_hdr = unsafe { &mut *(self.buffer.as_mut_ptr() as *mut libc::cmsghdr) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const platform::libc::cmsghdr`) [INFO] [stderr] --> src/unix/mod.rs:363:35 [INFO] [stderr] | [INFO] [stderr] 363 | let cmsg_hdr = unsafe { &*(self.buffer.as_ptr() as *const libc::cmsghdr) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*mut platform::libc::cmsghdr`) [INFO] [stderr] --> src/unix/mod.rs:372:50 [INFO] [stderr] | [INFO] [stderr] 372 | unsafe { slice::from_raw_parts(CMSG_DATA(self.buffer.as_ptr() as _) as *mut libc::c_int, self.current_fd_count()) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: aborting due to 11 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `sandbox-ipc`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "19ec3edbd5689401a709e4606eda04e6acdd1740b1f7e042f084fa8db89197cf"` [INFO] running `"docker" "rm" "-f" "19ec3edbd5689401a709e4606eda04e6acdd1740b1f7e042f084fa8db89197cf"` [INFO] [stdout] 19ec3edbd5689401a709e4606eda04e6acdd1740b1f7e042f084fa8db89197cf