[INFO] crate samplerate 0.1.5 is already in cache [INFO] extracting crate samplerate 0.1.5 into work/ex/clippy-test-run/sources/stable/reg/samplerate/0.1.5 [INFO] extracting crate samplerate 0.1.5 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/samplerate/0.1.5 [INFO] validating manifest of samplerate-0.1.5 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of samplerate-0.1.5 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing samplerate-0.1.5 [INFO] finished frobbing samplerate-0.1.5 [INFO] frobbed toml for samplerate-0.1.5 written to work/ex/clippy-test-run/sources/stable/reg/samplerate/0.1.5/Cargo.toml [INFO] started frobbing samplerate-0.1.5 [INFO] finished frobbing samplerate-0.1.5 [INFO] frobbed toml for samplerate-0.1.5 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/samplerate/0.1.5/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting samplerate-0.1.5 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/samplerate/0.1.5:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 735fdb5ae81be680248038b4d36226ce9b77c7dada7fe3480ceaec05c4229a7f [INFO] running `"docker" "start" "-a" "735fdb5ae81be680248038b4d36226ce9b77c7dada7fe3480ceaec05c4229a7f"` [INFO] [stderr] Compiling libsamplerate-sys v0.1.3 [INFO] [stderr] Checking samplerate v0.1.5 (/opt/crater/workdir) [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/converter_type.rs:30:17 [INFO] [stderr] | [INFO] [stderr] 30 | pub fn name(&self) -> &'static str { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/converter_type.rs:37:24 [INFO] [stderr] | [INFO] [stderr] 37 | pub fn description(&self) -> &'static str { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/error.rs:66:24 [INFO] [stderr] | [INFO] [stderr] 66 | pub fn description(&self) -> &'static str { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/error.rs:92:17 [INFO] [stderr] | [INFO] [stderr] 92 | pub fn code(&self) -> ErrorCode { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/error.rs:96:24 [INFO] [stderr] | [INFO] [stderr] 96 | pub fn description(&self) -> &'static str { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/samplerate.rs:35:21 [INFO] [stderr] | [INFO] [stderr] 35 | let ratio = to_rate as f64 / from_rate as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(to_rate)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/samplerate.rs:35:38 [INFO] [stderr] | [INFO] [stderr] 35 | let ratio = to_rate as f64 / from_rate as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(from_rate)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/samplerate.rs:64:22 [INFO] [stderr] | [INFO] [stderr] 64 | pub fn from_rate(&self) -> u32 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/samplerate.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | self.to_rate as f64 / self.from_rate as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.to_rate)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/samplerate.rs:85:31 [INFO] [stderr] | [INFO] [stderr] 85 | self.to_rate as f64 / self.from_rate as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.from_rate)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:31:17 [INFO] [stderr] | [INFO] [stderr] 31 | let ratio = to_rate as f64 / from_rate as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(to_rate)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:31:34 [INFO] [stderr] | [INFO] [stderr] 31 | let ratio = to_rate as f64 / from_rate as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(from_rate)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/converter_type.rs:30:17 [INFO] [stderr] | [INFO] [stderr] 30 | pub fn name(&self) -> &'static str { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/converter_type.rs:37:24 [INFO] [stderr] | [INFO] [stderr] 37 | pub fn description(&self) -> &'static str { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/error.rs:66:24 [INFO] [stderr] | [INFO] [stderr] 66 | pub fn description(&self) -> &'static str { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/error.rs:92:17 [INFO] [stderr] | [INFO] [stderr] 92 | pub fn code(&self) -> ErrorCode { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/error.rs:96:24 [INFO] [stderr] | [INFO] [stderr] 96 | pub fn description(&self) -> &'static str { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 26 [INFO] [stderr] --> src/error.rs:118:5 [INFO] [stderr] | [INFO] [stderr] 118 | / fn create_converter_type_from_int() { [INFO] [stderr] 119 | | assert_eq!(ErrorCode::from_int(0), ErrorCode::NoError); [INFO] [stderr] 120 | | assert_eq!(ErrorCode::from_int(1), ErrorCode::MallocFailed); [INFO] [stderr] 121 | | assert_eq!(ErrorCode::from_int(2), ErrorCode::BadState); [INFO] [stderr] ... | [INFO] [stderr] 143 | | assert_eq!(ErrorCode::from_int(24), ErrorCode::Unknown); [INFO] [stderr] 144 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 26 [INFO] [stderr] --> src/error.rs:147:5 [INFO] [stderr] | [INFO] [stderr] 147 | / fn description() { [INFO] [stderr] 148 | | assert_eq!(ErrorCode::NoError.description(), "No error."); [INFO] [stderr] 149 | | assert_eq!(ErrorCode::MallocFailed.description(), "Malloc failed."); [INFO] [stderr] 150 | | assert_eq!(ErrorCode::BadState.description(), "SRC_STATE pointer is NULL."); [INFO] [stderr] ... | [INFO] [stderr] 172 | | assert_eq!(ErrorCode::Unknown.description(), "Unkown error."); [INFO] [stderr] 173 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/samplerate.rs:35:21 [INFO] [stderr] | [INFO] [stderr] 35 | let ratio = to_rate as f64 / from_rate as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(to_rate)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/samplerate.rs:35:38 [INFO] [stderr] | [INFO] [stderr] 35 | let ratio = to_rate as f64 / from_rate as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(from_rate)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/samplerate.rs:64:22 [INFO] [stderr] | [INFO] [stderr] 64 | pub fn from_rate(&self) -> u32 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/samplerate.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | self.to_rate as f64 / self.from_rate as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.to_rate)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/samplerate.rs:85:31 [INFO] [stderr] | [INFO] [stderr] 85 | self.to_rate as f64 / self.from_rate as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.from_rate)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:31:17 [INFO] [stderr] | [INFO] [stderr] 31 | let ratio = to_rate as f64 / from_rate as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(to_rate)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:31:34 [INFO] [stderr] | [INFO] [stderr] 31 | let ratio = to_rate as f64 / from_rate as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(from_rate)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 18.19s [INFO] running `"docker" "inspect" "735fdb5ae81be680248038b4d36226ce9b77c7dada7fe3480ceaec05c4229a7f"` [INFO] running `"docker" "rm" "-f" "735fdb5ae81be680248038b4d36226ce9b77c7dada7fe3480ceaec05c4229a7f"` [INFO] [stdout] 735fdb5ae81be680248038b4d36226ce9b77c7dada7fe3480ceaec05c4229a7f