[INFO] crate salt-compressor 0.4.0 is already in cache [INFO] extracting crate salt-compressor 0.4.0 into work/ex/clippy-test-run/sources/stable/reg/salt-compressor/0.4.0 [INFO] extracting crate salt-compressor 0.4.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/salt-compressor/0.4.0 [INFO] validating manifest of salt-compressor-0.4.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of salt-compressor-0.4.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing salt-compressor-0.4.0 [INFO] finished frobbing salt-compressor-0.4.0 [INFO] frobbed toml for salt-compressor-0.4.0 written to work/ex/clippy-test-run/sources/stable/reg/salt-compressor/0.4.0/Cargo.toml [INFO] started frobbing salt-compressor-0.4.0 [INFO] finished frobbing salt-compressor-0.4.0 [INFO] frobbed toml for salt-compressor-0.4.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/salt-compressor/0.4.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting salt-compressor-0.4.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/salt-compressor/0.4.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fd8b6bc9f1259b4bb56e2421c003b37d891c54b3f54242f84977bc79eef98f19 [INFO] running `"docker" "start" "-a" "fd8b6bc9f1259b4bb56e2421c003b37d891c54b3f54242f84977bc79eef98f19"` [INFO] [stderr] warning: only one of `license` or `license-file` is necessary [INFO] [stderr] Checking loggerv v0.3.0 [INFO] [stderr] Checking salt-compressor v0.4.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:268:34 [INFO] [stderr] | [INFO] [stderr] 268 | result: result, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `result` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:269:34 [INFO] [stderr] | [INFO] [stderr] 269 | retcode: retcode, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `retcode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:278:34 [INFO] [stderr] | [INFO] [stderr] 278 | retcode: retcode, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `retcode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:294:34 [INFO] [stderr] | [INFO] [stderr] 294 | retcode: retcode, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `retcode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:339:38 [INFO] [stderr] | [INFO] [stderr] 339 | output: output, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `output` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:340:38 [INFO] [stderr] | [INFO] [stderr] 340 | result: result, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:350:26 [INFO] [stderr] | [INFO] [stderr] 350 | host: host, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `host` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:407:31 [INFO] [stderr] | [INFO] [stderr] 407 | host: host, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `host` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:596:9 [INFO] [stderr] | [INFO] [stderr] 596 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:598:9 [INFO] [stderr] | [INFO] [stderr] 598 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:668:5 [INFO] [stderr] | [INFO] [stderr] 668 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:268:34 [INFO] [stderr] | [INFO] [stderr] 268 | result: result, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `result` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:269:34 [INFO] [stderr] | [INFO] [stderr] 269 | retcode: retcode, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `retcode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:278:34 [INFO] [stderr] | [INFO] [stderr] 278 | retcode: retcode, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `retcode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:294:34 [INFO] [stderr] | [INFO] [stderr] 294 | retcode: retcode, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `retcode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:339:38 [INFO] [stderr] | [INFO] [stderr] 339 | output: output, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `output` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:340:38 [INFO] [stderr] | [INFO] [stderr] 340 | result: result, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:350:26 [INFO] [stderr] | [INFO] [stderr] 350 | host: host, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `host` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:407:31 [INFO] [stderr] | [INFO] [stderr] 407 | host: host, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `host` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:596:9 [INFO] [stderr] | [INFO] [stderr] 596 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:598:9 [INFO] [stderr] | [INFO] [stderr] 598 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:668:5 [INFO] [stderr] | [INFO] [stderr] 668 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/main.rs:561:12 [INFO] [stderr] | [INFO] [stderr] 561 | if filter.unchanged && !result.output.is_some() && result.retcode.is_success() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `filter.unchanged && result.output.is_none() && result.retcode.is_success()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 27 [INFO] [stderr] --> src/main.rs:531:1 [INFO] [stderr] | [INFO] [stderr] 531 | / fn print_compressed(compressed: DataMap>, filter: &Filter) { [INFO] [stderr] 532 | | let mut succeeded_hosts = DataSet::default(); [INFO] [stderr] 533 | | let mut failed_hosts = DataSet::default(); [INFO] [stderr] 534 | | [INFO] [stderr] ... | [INFO] [stderr] 690 | | failed_hosts.len()); [INFO] [stderr] 691 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/main.rs:561:12 [INFO] [stderr] | [INFO] [stderr] 561 | if filter.unchanged && !result.output.is_some() && result.retcode.is_success() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `filter.unchanged && result.output.is_none() && result.retcode.is_success()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 27 [INFO] [stderr] --> src/main.rs:531:1 [INFO] [stderr] | [INFO] [stderr] 531 | / fn print_compressed(compressed: DataMap>, filter: &Filter) { [INFO] [stderr] 532 | | let mut succeeded_hosts = DataSet::default(); [INFO] [stderr] 533 | | let mut failed_hosts = DataSet::default(); [INFO] [stderr] 534 | | [INFO] [stderr] ... | [INFO] [stderr] 690 | | failed_hosts.len()); [INFO] [stderr] 691 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.68s [INFO] running `"docker" "inspect" "fd8b6bc9f1259b4bb56e2421c003b37d891c54b3f54242f84977bc79eef98f19"` [INFO] running `"docker" "rm" "-f" "fd8b6bc9f1259b4bb56e2421c003b37d891c54b3f54242f84977bc79eef98f19"` [INFO] [stdout] fd8b6bc9f1259b4bb56e2421c003b37d891c54b3f54242f84977bc79eef98f19