[INFO] crate salsa 0.8.0 is already in cache [INFO] extracting crate salsa 0.8.0 into work/ex/clippy-test-run/sources/stable/reg/salsa/0.8.0 [INFO] extracting crate salsa 0.8.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/salsa/0.8.0 [INFO] validating manifest of salsa-0.8.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of salsa-0.8.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing salsa-0.8.0 [INFO] finished frobbing salsa-0.8.0 [INFO] frobbed toml for salsa-0.8.0 written to work/ex/clippy-test-run/sources/stable/reg/salsa/0.8.0/Cargo.toml [INFO] started frobbing salsa-0.8.0 [INFO] finished frobbing salsa-0.8.0 [INFO] frobbed toml for salsa-0.8.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/salsa/0.8.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting salsa-0.8.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/salsa/0.8.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f037cb78706ce838ccffbad458d29cbe69275d59c69a431fc723576387343e4c [INFO] running `"docker" "start" "-a" "f037cb78706ce838ccffbad458d29cbe69275d59c69a431fc723576387343e4c"` [INFO] [stderr] Checking rustc-hash v1.0.1 [INFO] [stderr] Compiling derive-new v0.5.6 [INFO] [stderr] Checking salsa v0.8.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/derived.rs:521:13 [INFO] [stderr] | [INFO] [stderr] 521 | return Err(CycleDetected); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(CycleDetected)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/derived.rs:521:13 [INFO] [stderr] | [INFO] [stderr] 521 | return Err(CycleDetected); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(CycleDetected)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/derived.rs:137:18 [INFO] [stderr] | [INFO] [stderr] 137 | waiting: Mutex>; 2]>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/derived.rs:137:18 [INFO] [stderr] | [INFO] [stderr] 137 | waiting: Mutex>; 2]>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/derived.rs:518:18 [INFO] [stderr] | [INFO] [stderr] 518 | waiting: &Mutex>; 2]>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: outlives requirements can be inferred [INFO] [stderr] --> src/derived.rs:594:17 [INFO] [stderr] | [INFO] [stderr] 594 | DB: Database + 'db, [INFO] [stderr] | ^^^^^^ help: remove this bound [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:1:9 [INFO] [stderr] | [INFO] [stderr] 1 | #![warn(rust_2018_idioms)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] = note: #[warn(explicit_outlives_requirements)] implied by #[warn(rust_2018_idioms)] [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/derived.rs:518:18 [INFO] [stderr] | [INFO] [stderr] 518 | waiting: &Mutex>; 2]>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: outlives requirements can be inferred [INFO] [stderr] --> src/derived.rs:594:17 [INFO] [stderr] | [INFO] [stderr] 594 | DB: Database + 'db, [INFO] [stderr] | ^^^^^^ help: remove this bound [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:1:9 [INFO] [stderr] | [INFO] [stderr] 1 | #![warn(rust_2018_idioms)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] = note: #[warn(explicit_outlives_requirements)] implied by #[warn(rust_2018_idioms)] [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/derived.rs:980:37 [INFO] [stderr] | [INFO] [stderr] 980 | let changed_input = inputs [INFO] [stderr] | _____________________________________^ [INFO] [stderr] 981 | | .iter() [INFO] [stderr] 982 | | .filter(|input| input.maybe_changed_since(db, verified_at)) [INFO] [stderr] 983 | | .next(); [INFO] [stderr] | |___________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::filter_next)] on by default [INFO] [stderr] = note: replace `filter(|input| input.maybe_changed_since(db, verified_at)).next()` with `find(|input| input.maybe_changed_since(db, verified_at))` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/derived.rs:980:37 [INFO] [stderr] | [INFO] [stderr] 980 | let changed_input = inputs [INFO] [stderr] | _____________________________________^ [INFO] [stderr] 981 | | .iter() [INFO] [stderr] 982 | | .filter(|input| input.maybe_changed_since(db, verified_at)) [INFO] [stderr] 983 | | .next(); [INFO] [stderr] | |___________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::filter_next)] on by default [INFO] [stderr] = note: replace `filter(|input| input.maybe_changed_since(db, verified_at)).next()` with `find(|input| input.maybe_changed_since(db, verified_at))` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/runtime.rs:317:27 [INFO] [stderr] | [INFO] [stderr] 317 | let start_index = (0..query_stack.len()) [INFO] [stderr] | ___________________________^ [INFO] [stderr] 318 | | .rev() [INFO] [stderr] 319 | | .filter(|&i| query_stack[i].descriptor == descriptor) [INFO] [stderr] 320 | | .next() [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = note: replace `filter(|&i| query_stack[i].descriptor == descriptor).next()` with `find(|&i| query_stack[i].descriptor == descriptor)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/runtime.rs:323:27 [INFO] [stderr] | [INFO] [stderr] 323 | let mut message = format!("Internal error, cycle detected:\n"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Internal error, cycle detected:\n".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/runtime.rs:583:14 [INFO] [stderr] | [INFO] [stderr] 583 | .or_insert(SmallVec::default()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(SmallVec::default)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `default` [INFO] [stderr] --> src/runtime.rs:589:19 [INFO] [stderr] | [INFO] [stderr] 589 | let vec = self [INFO] [stderr] | ___________________^ [INFO] [stderr] 590 | | .labels [INFO] [stderr] 591 | | .remove(descriptor) [INFO] [stderr] 592 | | .unwrap_or(SmallVec::default()); [INFO] [stderr] | |___________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 589 | let vec = self [INFO] [stderr] 590 | .labels [INFO] [stderr] 591 | .remove(descriptor).unwrap_or_default(); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: struct update has no effect, all the fields in the struct have already been specified [INFO] [stderr] --> src/lib.rs:218:15 [INFO] [stderr] | [INFO] [stderr] 218 | ..self [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_update)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update [INFO] [stderr] [INFO] [stderr] warning: outlives requirements can be inferred [INFO] [stderr] --> src/lib.rs:353:17 [INFO] [stderr] | [INFO] [stderr] 353 | DB: Database + 'me, [INFO] [stderr] | ^^^^^^ help: remove this bound [INFO] [stderr] [INFO] [stderr] warning: outlives requirements can be inferred [INFO] [stderr] --> src/lib.rs:401:17 [INFO] [stderr] | [INFO] [stderr] 401 | DB: Database + 'me, [INFO] [stderr] | ^^^^^^ help: remove this bound [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/runtime.rs:317:27 [INFO] [stderr] | [INFO] [stderr] 317 | let start_index = (0..query_stack.len()) [INFO] [stderr] | ___________________________^ [INFO] [stderr] 318 | | .rev() [INFO] [stderr] 319 | | .filter(|&i| query_stack[i].descriptor == descriptor) [INFO] [stderr] 320 | | .next() [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = note: replace `filter(|&i| query_stack[i].descriptor == descriptor).next()` with `find(|&i| query_stack[i].descriptor == descriptor)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/runtime.rs:323:27 [INFO] [stderr] | [INFO] [stderr] 323 | let mut message = format!("Internal error, cycle detected:\n"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Internal error, cycle detected:\n".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/runtime.rs:583:14 [INFO] [stderr] | [INFO] [stderr] 583 | .or_insert(SmallVec::default()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(SmallVec::default)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `default` [INFO] [stderr] --> src/runtime.rs:589:19 [INFO] [stderr] | [INFO] [stderr] 589 | let vec = self [INFO] [stderr] | ___________________^ [INFO] [stderr] 590 | | .labels [INFO] [stderr] 591 | | .remove(descriptor) [INFO] [stderr] 592 | | .unwrap_or(SmallVec::default()); [INFO] [stderr] | |___________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 589 | let vec = self [INFO] [stderr] 590 | .labels [INFO] [stderr] 591 | .remove(descriptor).unwrap_or_default(); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: struct update has no effect, all the fields in the struct have already been specified [INFO] [stderr] --> src/lib.rs:218:15 [INFO] [stderr] | [INFO] [stderr] 218 | ..self [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_update)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update [INFO] [stderr] [INFO] [stderr] warning: outlives requirements can be inferred [INFO] [stderr] --> src/lib.rs:353:17 [INFO] [stderr] | [INFO] [stderr] 353 | DB: Database + 'me, [INFO] [stderr] | ^^^^^^ help: remove this bound [INFO] [stderr] [INFO] [stderr] warning: outlives requirements can be inferred [INFO] [stderr] --> src/lib.rs:401:17 [INFO] [stderr] | [INFO] [stderr] 401 | DB: Database + 'me, [INFO] [stderr] | ^^^^^^ help: remove this bound [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> tests/set_unchecked.rs:54:33 [INFO] [stderr] | [INFO] [stderr] 54 | db.query_mut(Input).set((), format!("Hello, world")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Hello, world".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> tests/set_unchecked.rs:56:33 [INFO] [stderr] | [INFO] [stderr] 56 | db.query_mut(Input).set((), format!("Hello, world!")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Hello, world!".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> tests/set_unchecked.rs:71:28 [INFO] [stderr] | [INFO] [stderr] 71 | .set_unchecked((), format!("Hello, world")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Hello, world".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> tests/set_unchecked.rs:78:33 [INFO] [stderr] | [INFO] [stderr] 78 | db.query_mut(Input).set((), format!("Hello, world")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Hello, world".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> tests/set_unchecked.rs:84:28 [INFO] [stderr] | [INFO] [stderr] 84 | .set_unchecked((), format!("Hello, world!")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Hello, world!".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> tests/cycles.rs:43:35 [INFO] [stderr] | [INFO] [stderr] 43 | fn memoized_a(db: &impl Database) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> tests/cycles.rs:47:35 [INFO] [stderr] | [INFO] [stderr] 47 | fn memoized_b(db: &impl Database) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> tests/cycles.rs:51:35 [INFO] [stderr] | [INFO] [stderr] 51 | fn volatile_a(db: &impl Database) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> tests/cycles.rs:55:35 [INFO] [stderr] | [INFO] [stderr] 55 | fn volatile_b(db: &impl Database) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> tests/panic_safely.rs:17:48 [INFO] [stderr] | [INFO] [stderr] 17 | fn panic_safely(db: &impl PanicSafelyDatabase) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> examples/hello_world/main.rs:101:27 [INFO] [stderr] | [INFO] [stderr] 101 | .set((), Arc::new(format!("Hello, world"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Hello, world".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> tests/parallel/cancellation.rs:12:34 [INFO] [stderr] | [INFO] [stderr] 12 | db.query_mut(Input).set('b', 010); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_prefixed_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 12 | db.query_mut(Input).set('b', 10); [INFO] [stderr] | ^^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 12 | db.query_mut(Input).set('b', 0o10); [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> tests/parallel/cancellation.rs:13:34 [INFO] [stderr] | [INFO] [stderr] 13 | db.query_mut(Input).set('c', 001); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 13 | db.query_mut(Input).set('c', 1); [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 13 | db.query_mut(Input).set('c', 0o1); [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> tests/parallel/cancellation.rs:53:34 [INFO] [stderr] | [INFO] [stderr] 53 | db.query_mut(Input).set('b', 010); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 53 | db.query_mut(Input).set('b', 10); [INFO] [stderr] | ^^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 53 | db.query_mut(Input).set('b', 0o10); [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> tests/parallel/cancellation.rs:54:34 [INFO] [stderr] | [INFO] [stderr] 54 | db.query_mut(Input).set('c', 001); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 54 | db.query_mut(Input).set('c', 1); [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 54 | db.query_mut(Input).set('c', 0o1); [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> tests/parallel/independent.rs:11:34 [INFO] [stderr] | [INFO] [stderr] 11 | db.query_mut(Input).set('b', 010); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 11 | db.query_mut(Input).set('b', 10); [INFO] [stderr] | ^^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 11 | db.query_mut(Input).set('b', 0o10); [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> tests/parallel/independent.rs:12:34 [INFO] [stderr] | [INFO] [stderr] 12 | db.query_mut(Input).set('c', 001); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 12 | db.query_mut(Input).set('c', 1); [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 12 | db.query_mut(Input).set('c', 0o1); [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> tests/parallel/independent.rs:14:34 [INFO] [stderr] | [INFO] [stderr] 14 | db.query_mut(Input).set('e', 020); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 14 | db.query_mut(Input).set('e', 20); [INFO] [stderr] | ^^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 14 | db.query_mut(Input).set('e', 0o20); [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> tests/parallel/independent.rs:15:34 [INFO] [stderr] | [INFO] [stderr] 15 | db.query_mut(Input).set('f', 002); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 15 | db.query_mut(Input).set('f', 2); [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 15 | db.query_mut(Input).set('f', 0o2); [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> tests/parallel/race.rs:11:34 [INFO] [stderr] | [INFO] [stderr] 11 | db.query_mut(Input).set('b', 010); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 11 | db.query_mut(Input).set('b', 10); [INFO] [stderr] | ^^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 11 | db.query_mut(Input).set('b', 0o10); [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> tests/parallel/race.rs:12:34 [INFO] [stderr] | [INFO] [stderr] 12 | db.query_mut(Input).set('c', 001); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 12 | db.query_mut(Input).set('c', 1); [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 12 | db.query_mut(Input).set('c', 0o1); [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> tests/parallel/race.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | v [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> tests/parallel/race.rs:17:21 [INFO] [stderr] | [INFO] [stderr] 17 | let v = db.sum("abc"); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> tests/parallel/stress.rs:122:9 [INFO] [stderr] | [INFO] [stderr] 122 | return WriteOp::SetA(key, value); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `WriteOp::SetA(key, value)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> tests/parallel/stress.rs:147:9 [INFO] [stderr] | [INFO] [stderr] 147 | / if check_cancellation { [INFO] [stderr] 148 | | if db.salsa_runtime().is_current_revision_canceled() { [INFO] [stderr] 149 | | return; [INFO] [stderr] 150 | | } [INFO] [stderr] 151 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 147 | if check_cancellation && db.salsa_runtime().is_current_revision_canceled() { [INFO] [stderr] 148 | return; [INFO] [stderr] 149 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> tests/parallel/true_parallel.rs:14:34 [INFO] [stderr] | [INFO] [stderr] 14 | db.query_mut(Input).set('b', 010); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 14 | db.query_mut(Input).set('b', 10); [INFO] [stderr] | ^^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 14 | db.query_mut(Input).set('b', 0o10); [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> tests/parallel/true_parallel.rs:15:34 [INFO] [stderr] | [INFO] [stderr] 15 | db.query_mut(Input).set('c', 001); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 15 | db.query_mut(Input).set('c', 1); [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 15 | db.query_mut(Input).set('c', 0o1); [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> tests/parallel/true_parallel.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | v [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> tests/parallel/true_parallel.rs:21:21 [INFO] [stderr] | [INFO] [stderr] 21 | let v = db.knobs().sum_signal_on_entry.with_value(1, || { [INFO] [stderr] | _____________________^ [INFO] [stderr] 22 | | db.knobs() [INFO] [stderr] 23 | | .sum_wait_for_on_exit [INFO] [stderr] 24 | | .with_value(2, || db.sum("a")) [INFO] [stderr] 25 | | }); [INFO] [stderr] | |______________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> tests/parallel/true_parallel.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | v [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> tests/parallel/true_parallel.rs:35:21 [INFO] [stderr] | [INFO] [stderr] 35 | let v = db.knobs().sum_wait_for_on_entry.with_value(1, || { [INFO] [stderr] | _____________________^ [INFO] [stderr] 36 | | db.knobs().sum_signal_on_exit.with_value(2, || db.sum("b")) [INFO] [stderr] 37 | | }); [INFO] [stderr] | |______________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> tests/parallel/true_parallel.rs:43:41 [INFO] [stderr] | [INFO] [stderr] 43 | assert_eq!(thread2.join().unwrap(), 010); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 43 | assert_eq!(thread2.join().unwrap(), 10); [INFO] [stderr] | ^^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 43 | assert_eq!(thread2.join().unwrap(), 0o10); [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> tests/parallel/true_parallel.rs:54:34 [INFO] [stderr] | [INFO] [stderr] 54 | db.query_mut(Input).set('b', 010); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 54 | db.query_mut(Input).set('b', 10); [INFO] [stderr] | ^^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 54 | db.query_mut(Input).set('b', 0o10); [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> tests/parallel/true_parallel.rs:55:34 [INFO] [stderr] | [INFO] [stderr] 55 | db.query_mut(Input).set('c', 001); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 55 | db.query_mut(Input).set('c', 1); [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 55 | db.query_mut(Input).set('c', 0o1); [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> tests/parallel/true_parallel.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | v [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> tests/parallel/true_parallel.rs:61:21 [INFO] [stderr] | [INFO] [stderr] 61 | let v = db.knobs().sum_signal_on_entry.with_value(1, || { [INFO] [stderr] | _____________________^ [INFO] [stderr] 62 | | db.knobs() [INFO] [stderr] 63 | | .sum_wait_for_on_entry [INFO] [stderr] 64 | | .with_value(2, || db.sum("abc")) [INFO] [stderr] 65 | | }); [INFO] [stderr] | |______________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> tests/parallel/setup.rs:133:9 [INFO] [stderr] | [INFO] [stderr] 133 | / match event.kind { [INFO] [stderr] 134 | | salsa::EventKind::WillBlockOn { .. } => { [INFO] [stderr] 135 | | self.signal(self.knobs().signal_on_will_block.get()); [INFO] [stderr] 136 | | } [INFO] [stderr] 137 | | [INFO] [stderr] 138 | | _ => {} [INFO] [stderr] 139 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 133 | if let salsa::EventKind::WillBlockOn { .. } = event.kind { [INFO] [stderr] 134 | self.signal(self.knobs().signal_on_will_block.get()); [INFO] [stderr] 135 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> tests/macros.rs:11:68 [INFO] [stderr] | [INFO] [stderr] 11 | pub(crate) fn another_name(_: &impl crate::MyDatabase, (): ()) -> () {} [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 20.51s [INFO] running `"docker" "inspect" "f037cb78706ce838ccffbad458d29cbe69275d59c69a431fc723576387343e4c"` [INFO] running `"docker" "rm" "-f" "f037cb78706ce838ccffbad458d29cbe69275d59c69a431fc723576387343e4c"` [INFO] [stdout] f037cb78706ce838ccffbad458d29cbe69275d59c69a431fc723576387343e4c