[INFO] crate sabi 0.1.0 is already in cache [INFO] extracting crate sabi 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/sabi/0.1.0 [INFO] extracting crate sabi 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sabi/0.1.0 [INFO] validating manifest of sabi-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sabi-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sabi-0.1.0 [INFO] finished frobbing sabi-0.1.0 [INFO] frobbed toml for sabi-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/sabi/0.1.0/Cargo.toml [INFO] started frobbing sabi-0.1.0 [INFO] finished frobbing sabi-0.1.0 [INFO] frobbed toml for sabi-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sabi/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sabi-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/sabi/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e8509c4cc4e1e6b96d95ef3446274b9ab2169b95fa41b1ec8547513ba3e92c01 [INFO] running `"docker" "start" "-a" "e8509c4cc4e1e6b96d95ef3446274b9ab2169b95fa41b1ec8547513ba3e92c01"` [INFO] [stderr] Checking combine v3.6.6 [INFO] [stderr] Checking sabi v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `writeln!(f, "")` [INFO] [stderr] --> src/vm.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | writeln!(f, ""); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `writeln!(f)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::writeln_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vm.rs:123:13 [INFO] [stderr] | [INFO] [stderr] 123 | output: output, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `output` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(f, "")` [INFO] [stderr] --> src/vm.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | writeln!(f, ""); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `writeln!(f)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::writeln_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vm.rs:123:13 [INFO] [stderr] | [INFO] [stderr] 123 | output: output, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `output` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Stream`, `many1`, `many`, `one_of` [INFO] [stderr] --> src/parser/bytecode.rs:3:18 [INFO] [stderr] | [INFO] [stderr] 3 | choice, eof, many, many1, one_of, optional, r#try, token, ParseError, Parser, [INFO] [stderr] | ^^^^ ^^^^^ ^^^^^^ [INFO] [stderr] 4 | RangeStream, Stream, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/vm.rs:343:13 [INFO] [stderr] | [INFO] [stderr] 343 | / if self.debug { [INFO] [stderr] 344 | | if self.code.get(self.code_ptr).and_then(|x| Opcode::from_u8(x.clone())) != Some(Opcode::Nop) { [INFO] [stderr] 345 | | println!("{:?}", self); [INFO] [stderr] 346 | | let mut input = String::new(); [INFO] [stderr] 347 | | io::stdin().read_line(&mut input); [INFO] [stderr] 348 | | } [INFO] [stderr] 349 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 343 | if self.debug && self.code.get(self.code_ptr).and_then(|x| Opcode::from_u8(x.clone())) != Some(Opcode::Nop) { [INFO] [stderr] 344 | println!("{:?}", self); [INFO] [stderr] 345 | let mut input = String::new(); [INFO] [stderr] 346 | io::stdin().read_line(&mut input); [INFO] [stderr] 347 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused import: `self` [INFO] [stderr] --> src/main.rs:9:15 [INFO] [stderr] | [INFO] [stderr] 9 | use std::io::{self, Read}; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Stream`, `many1`, `many`, `one_of` [INFO] [stderr] --> src/parser/bytecode.rs:3:18 [INFO] [stderr] | [INFO] [stderr] 3 | choice, eof, many, many1, one_of, optional, r#try, token, ParseError, Parser, [INFO] [stderr] | ^^^^ ^^^^^ ^^^^^^ [INFO] [stderr] 4 | RangeStream, Stream, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/vm.rs:343:13 [INFO] [stderr] | [INFO] [stderr] 343 | / if self.debug { [INFO] [stderr] 344 | | if self.code.get(self.code_ptr).and_then(|x| Opcode::from_u8(x.clone())) != Some(Opcode::Nop) { [INFO] [stderr] 345 | | println!("{:?}", self); [INFO] [stderr] 346 | | let mut input = String::new(); [INFO] [stderr] 347 | | io::stdin().read_line(&mut input); [INFO] [stderr] 348 | | } [INFO] [stderr] 349 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 343 | if self.debug && self.code.get(self.code_ptr).and_then(|x| Opcode::from_u8(x.clone())) != Some(Opcode::Nop) { [INFO] [stderr] 344 | println!("{:?}", self); [INFO] [stderr] 345 | let mut input = String::new(); [INFO] [stderr] 346 | io::stdin().read_line(&mut input); [INFO] [stderr] 347 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused import: `self` [INFO] [stderr] --> src/main.rs:9:15 [INFO] [stderr] | [INFO] [stderr] 9 | use std::io::{self, Read}; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `peek` [INFO] [stderr] --> src/vm.rs:248:5 [INFO] [stderr] | [INFO] [stderr] 248 | pub fn peek(&self) -> isize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser/bytecode.rs:38:36 [INFO] [stderr] | [INFO] [stderr] 38 | let skip_space = || take_while(|c| is_space(c)); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove closure as shown: `is_space` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser/bytecode.rs:39:31 [INFO] [stderr] | [INFO] [stderr] 39 | let word = || take_while1(|c| is_char(c)).skip(skip_space()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove closure as shown: `is_char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser/bytecode.rs:41:21 [INFO] [stderr] | [INFO] [stderr] 41 | take_while1(|c| is_num(c)) [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove closure as shown: `is_num` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser/bytecode.rs:47:39 [INFO] [stderr] | [INFO] [stderr] 47 | let argument = choice((word().map(|t| Arg::Text(t)), int().map(|i| Arg::Int(i)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove closure as shown: `Arg::Text` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser/bytecode.rs:47:68 [INFO] [stderr] | [INFO] [stderr] 47 | let argument = choice((word().map(|t| Arg::Text(t)), int().map(|i| Arg::Int(i)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove closure as shown: `Arg::Int` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/parser.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | / if (x >= 'a' && x <= 'z') || (x >= 'A' && x <= 'Z') { [INFO] [stderr] 10 | | true [INFO] [stderr] 11 | | } else { [INFO] [stderr] 12 | | false [INFO] [stderr] 13 | | } [INFO] [stderr] | |_____^ help: you can reduce it to: `(x >= 'a' && x <= 'z') || (x >= 'A' && x <= 'Z')` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/parser.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | / if x >= '0' && x <= '9' { [INFO] [stderr] 18 | | true [INFO] [stderr] 19 | | } else { [INFO] [stderr] 20 | | false [INFO] [stderr] 21 | | } [INFO] [stderr] | |_____^ help: you can reduce it to: `x >= '0' && x <= '9'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/vm.rs:82:9 [INFO] [stderr] | [INFO] [stderr] 82 | writeln!(f, "code:"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/vm.rs:93:13 [INFO] [stderr] | [INFO] [stderr] 93 | write!(f, "{:04x}: {:?}", i, op); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const i64`) [INFO] [stderr] --> src/vm.rs:96:42 [INFO] [stderr] | [INFO] [stderr] 96 | let num: i64 = unsafe { *(*slice as *const i64) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::cast_ptr_alignment)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/vm.rs:98:17 [INFO] [stderr] | [INFO] [stderr] 98 | write!(f, " {:?}", num); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/vm.rs:102:17 [INFO] [stderr] | [INFO] [stderr] 102 | write!(f, " <"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/vm.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | writeln!(f, ""); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/vm.rs:107:9 [INFO] [stderr] | [INFO] [stderr] 107 | writeln!(f, "code_ptr: {:04x}", self.code_ptr); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/vm.rs:233:18 [INFO] [stderr] | [INFO] [stderr] 233 | let op = self.code[self.code_ptr].clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.code[self.code_ptr]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const i64`) [INFO] [stderr] --> src/vm.rs:242:34 [INFO] [stderr] | [INFO] [stderr] 242 | let num: i64 = unsafe { *(*slice as *const i64) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/parser/bytecode.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | fn new(label: Option<&'a str>, instr: &'a str, arg: Option>) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/vm.rs:292:17 [INFO] [stderr] | [INFO] [stderr] 292 | writeln!(self.output, "{}", val); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `peek` [INFO] [stderr] --> src/vm.rs:248:5 [INFO] [stderr] | [INFO] [stderr] 248 | pub fn peek(&self) -> isize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser/bytecode.rs:38:36 [INFO] [stderr] | [INFO] [stderr] 38 | let skip_space = || take_while(|c| is_space(c)); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove closure as shown: `is_space` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser/bytecode.rs:39:31 [INFO] [stderr] | [INFO] [stderr] 39 | let word = || take_while1(|c| is_char(c)).skip(skip_space()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove closure as shown: `is_char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser/bytecode.rs:41:21 [INFO] [stderr] | [INFO] [stderr] 41 | take_while1(|c| is_num(c)) [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove closure as shown: `is_num` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser/bytecode.rs:47:39 [INFO] [stderr] | [INFO] [stderr] 47 | let argument = choice((word().map(|t| Arg::Text(t)), int().map(|i| Arg::Int(i)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove closure as shown: `Arg::Text` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser/bytecode.rs:47:68 [INFO] [stderr] | [INFO] [stderr] 47 | let argument = choice((word().map(|t| Arg::Text(t)), int().map(|i| Arg::Int(i)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove closure as shown: `Arg::Int` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/vm.rs:344:78 [INFO] [stderr] | [INFO] [stderr] 344 | if self.code.get(self.code_ptr).and_then(|x| Opcode::from_u8(x.clone())) != Some(Opcode::Nop) { [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/vm.rs:347:21 [INFO] [stderr] | [INFO] [stderr] 347 | io::stdin().read_line(&mut input); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/parser.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | / if (x >= 'a' && x <= 'z') || (x >= 'A' && x <= 'Z') { [INFO] [stderr] 10 | | true [INFO] [stderr] 11 | | } else { [INFO] [stderr] 12 | | false [INFO] [stderr] 13 | | } [INFO] [stderr] | |_____^ help: you can reduce it to: `(x >= 'a' && x <= 'z') || (x >= 'A' && x <= 'Z')` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/parser.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | / if x >= '0' && x <= '9' { [INFO] [stderr] 18 | | true [INFO] [stderr] 19 | | } else { [INFO] [stderr] 20 | | false [INFO] [stderr] 21 | | } [INFO] [stderr] | |_____^ help: you can reduce it to: `x >= '0' && x <= '9'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/vm.rs:82:9 [INFO] [stderr] | [INFO] [stderr] 82 | writeln!(f, "code:"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/vm.rs:93:13 [INFO] [stderr] | [INFO] [stderr] 93 | write!(f, "{:04x}: {:?}", i, op); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const i64`) [INFO] [stderr] --> src/vm.rs:96:42 [INFO] [stderr] | [INFO] [stderr] 96 | let num: i64 = unsafe { *(*slice as *const i64) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::cast_ptr_alignment)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/vm.rs:98:17 [INFO] [stderr] | [INFO] [stderr] 98 | write!(f, " {:?}", num); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/vm.rs:102:17 [INFO] [stderr] | [INFO] [stderr] 102 | write!(f, " <"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/vm.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | writeln!(f, ""); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/vm.rs:107:9 [INFO] [stderr] | [INFO] [stderr] 107 | writeln!(f, "code_ptr: {:04x}", self.code_ptr); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/vm.rs:233:18 [INFO] [stderr] | [INFO] [stderr] 233 | let op = self.code[self.code_ptr].clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.code[self.code_ptr]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const i64`) [INFO] [stderr] --> src/vm.rs:242:34 [INFO] [stderr] | [INFO] [stderr] 242 | let num: i64 = unsafe { *(*slice as *const i64) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: Could not compile `sabi`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/vm.rs:292:17 [INFO] [stderr] | [INFO] [stderr] 292 | writeln!(self.output, "{}", val); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/vm.rs:344:78 [INFO] [stderr] | [INFO] [stderr] 344 | if self.code.get(self.code_ptr).and_then(|x| Opcode::from_u8(x.clone())) != Some(Opcode::Nop) { [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/vm.rs:347:21 [INFO] [stderr] | [INFO] [stderr] 347 | io::stdin().read_line(&mut input); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `sabi`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "e8509c4cc4e1e6b96d95ef3446274b9ab2169b95fa41b1ec8547513ba3e92c01"` [INFO] running `"docker" "rm" "-f" "e8509c4cc4e1e6b96d95ef3446274b9ab2169b95fa41b1ec8547513ba3e92c01"` [INFO] [stdout] e8509c4cc4e1e6b96d95ef3446274b9ab2169b95fa41b1ec8547513ba3e92c01