[INFO] crate s3-concat 1.0.0 is already in cache [INFO] extracting crate s3-concat 1.0.0 into work/ex/clippy-test-run/sources/stable/reg/s3-concat/1.0.0 [INFO] extracting crate s3-concat 1.0.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/s3-concat/1.0.0 [INFO] validating manifest of s3-concat-1.0.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of s3-concat-1.0.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing s3-concat-1.0.0 [INFO] finished frobbing s3-concat-1.0.0 [INFO] frobbed toml for s3-concat-1.0.0 written to work/ex/clippy-test-run/sources/stable/reg/s3-concat/1.0.0/Cargo.toml [INFO] started frobbing s3-concat-1.0.0 [INFO] finished frobbing s3-concat-1.0.0 [INFO] frobbed toml for s3-concat-1.0.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/s3-concat/1.0.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting s3-concat-1.0.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/s3-concat/1.0.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f8f4ac4cf5d7810dfaeb1ffd2c558609e727994e271d3dc24ec094947399d2af [INFO] running `"docker" "start" "-a" "f8f4ac4cf5d7810dfaeb1ffd2c558609e727994e271d3dc24ec094947399d2af"` [INFO] [stderr] Compiling rusoto_core v0.35.0 [INFO] [stderr] Checking quick-xml v0.12.4 [INFO] [stderr] Checking rusoto_credential v0.14.0 [INFO] [stderr] Checking rusoto_s3 v0.35.0 [INFO] [stderr] Checking s3-concat v1.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:259:38 [INFO] [stderr] | [INFO] [stderr] 259 | if entry.size.unwrap() < 5000000 { [INFO] [stderr] | ^^^^^^^ help: consider: `5_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/main.rs:166:16 [INFO] [stderr] | [INFO] [stderr] 166 | if let Err(_) = s3.complete_multipart_upload(complete).sync() { [INFO] [stderr] | _________- ^^^^^^ [INFO] [stderr] 167 | | // remove the upload sources [INFO] [stderr] 168 | | sources.remove(&key); [INFO] [stderr] 169 | | [INFO] [stderr] ... | [INFO] [stderr] 176 | | ); [INFO] [stderr] 177 | | } [INFO] [stderr] | |_________- help: try this: `if s3.complete_multipart_upload(complete).sync().is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/main.rs:200:20 [INFO] [stderr] | [INFO] [stderr] 200 | if let Err(_) = s3.delete_object(delete).sync() { [INFO] [stderr] | _____________- ^^^^^^ [INFO] [stderr] 201 | | error!("Unable to remove {}", key); [INFO] [stderr] 202 | | } [INFO] [stderr] | |_____________- help: try this: `if s3.delete_object(delete).sync().is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/main.rs:214:1 [INFO] [stderr] | [INFO] [stderr] 214 | / fn construct_uploads<'a>( [INFO] [stderr] 215 | | dry: bool, [INFO] [stderr] 216 | | s3: &S3Client, [INFO] [stderr] 217 | | bucket: Cow<'a, str>, [INFO] [stderr] ... | [INFO] [stderr] 334 | | Ok(()) [INFO] [stderr] 335 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/main.rs:326:16 [INFO] [stderr] | [INFO] [stderr] 326 | if let None = response.next_continuation_token { [INFO] [stderr] | _________- ^^^^ [INFO] [stderr] 327 | | break; [INFO] [stderr] 328 | | } [INFO] [stderr] | |_________- help: try this: `if response.next_continuation_token.is_none()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/main.rs:354:12 [INFO] [stderr] | [INFO] [stderr] 354 | if let Err(_) = s3.abort_multipart_upload(abort).sync() { [INFO] [stderr] | _____- ^^^^^^ [INFO] [stderr] 355 | | error!("Unable to abort: {}", upload_id); [INFO] [stderr] 356 | | } [INFO] [stderr] | |_____- help: try this: `if s3.abort_multipart_upload(abort).sync().is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:259:38 [INFO] [stderr] | [INFO] [stderr] 259 | if entry.size.unwrap() < 5000000 { [INFO] [stderr] | ^^^^^^^ help: consider: `5_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/main.rs:166:16 [INFO] [stderr] | [INFO] [stderr] 166 | if let Err(_) = s3.complete_multipart_upload(complete).sync() { [INFO] [stderr] | _________- ^^^^^^ [INFO] [stderr] 167 | | // remove the upload sources [INFO] [stderr] 168 | | sources.remove(&key); [INFO] [stderr] 169 | | [INFO] [stderr] ... | [INFO] [stderr] 176 | | ); [INFO] [stderr] 177 | | } [INFO] [stderr] | |_________- help: try this: `if s3.complete_multipart_upload(complete).sync().is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/main.rs:200:20 [INFO] [stderr] | [INFO] [stderr] 200 | if let Err(_) = s3.delete_object(delete).sync() { [INFO] [stderr] | _____________- ^^^^^^ [INFO] [stderr] 201 | | error!("Unable to remove {}", key); [INFO] [stderr] 202 | | } [INFO] [stderr] | |_____________- help: try this: `if s3.delete_object(delete).sync().is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/main.rs:214:1 [INFO] [stderr] | [INFO] [stderr] 214 | / fn construct_uploads<'a>( [INFO] [stderr] 215 | | dry: bool, [INFO] [stderr] 216 | | s3: &S3Client, [INFO] [stderr] 217 | | bucket: Cow<'a, str>, [INFO] [stderr] ... | [INFO] [stderr] 334 | | Ok(()) [INFO] [stderr] 335 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/main.rs:326:16 [INFO] [stderr] | [INFO] [stderr] 326 | if let None = response.next_continuation_token { [INFO] [stderr] | _________- ^^^^ [INFO] [stderr] 327 | | break; [INFO] [stderr] 328 | | } [INFO] [stderr] | |_________- help: try this: `if response.next_continuation_token.is_none()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/main.rs:354:12 [INFO] [stderr] | [INFO] [stderr] 354 | if let Err(_) = s3.abort_multipart_upload(abort).sync() { [INFO] [stderr] | _____- ^^^^^^ [INFO] [stderr] 355 | | error!("Unable to abort: {}", upload_id); [INFO] [stderr] 356 | | } [INFO] [stderr] | |_____- help: try this: `if s3.abort_multipart_upload(abort).sync().is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 47.69s [INFO] running `"docker" "inspect" "f8f4ac4cf5d7810dfaeb1ffd2c558609e727994e271d3dc24ec094947399d2af"` [INFO] running `"docker" "rm" "-f" "f8f4ac4cf5d7810dfaeb1ffd2c558609e727994e271d3dc24ec094947399d2af"` [INFO] [stdout] f8f4ac4cf5d7810dfaeb1ffd2c558609e727994e271d3dc24ec094947399d2af