[INFO] crate rwlock2 0.2.5 is already in cache
[INFO] extracting crate rwlock2 0.2.5 into work/ex/clippy-test-run/sources/stable/reg/rwlock2/0.2.5
[INFO] extracting crate rwlock2 0.2.5 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rwlock2/0.2.5
[INFO] validating manifest of rwlock2-0.2.5 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of rwlock2-0.2.5 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing rwlock2-0.2.5
[INFO] finished frobbing rwlock2-0.2.5
[INFO] frobbed toml for rwlock2-0.2.5 written to work/ex/clippy-test-run/sources/stable/reg/rwlock2/0.2.5/Cargo.toml
[INFO] started frobbing rwlock2-0.2.5
[INFO] finished frobbing rwlock2-0.2.5
[INFO] frobbed toml for rwlock2-0.2.5 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rwlock2/0.2.5/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting rwlock2-0.2.5 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rwlock2/0.2.5:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] bc34d748679c2ee238ab2bffb98cf2a7b89f7145ddaa91867c55608fe8b65f9b
[INFO] running `"docker" "start" "-a" "bc34d748679c2ee238ab2bffb98cf2a7b89f7145ddaa91867c55608fe8b65f9b"`
[INFO] [stderr]     Checking rwlock2 v0.2.5 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/poison.rs:113:23
[INFO] [stderr]     |
[INFO] [stderr] 113 |         PoisonError { guard: guard }
[INFO] [stderr]     |                       ^^^^^^^^^^^^ help: replace it with: `guard`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] error: redundant field names in struct initialization
[INFO] [stderr]    --> src/poison.rs:113:23
[INFO] [stderr]     |
[INFO] [stderr] 113 |         PoisonError { guard: guard }
[INFO] [stderr]     |                       ^^^^^^^^^^^^ help: replace it with: `guard`
[INFO] [stderr]     |
[INFO] [stderr] note: lint level defined here
[INFO] [stderr]    --> src/lib.rs:1:24
[INFO] [stderr]     |
[INFO] [stderr] 1   | #![cfg_attr(test, deny(warnings))]
[INFO] [stderr]     |                        ^^^^^^^^
[INFO] [stderr]     = note: #[deny(clippy::redundant_field_names)] implied by #[deny(warnings)]
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: transmute from a reference to a reference
[INFO] [stderr]    --> src/rwlock.rs:410:30
[INFO] [stderr]     |
[INFO] [stderr] 410 |             __data: unsafe { mem::transmute::<&mut U, &UnsafeCell<U>>(new_data) },
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(new_data as *mut U as *const std::cell::UnsafeCell<U>)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr
[INFO] [stderr] 
[INFO] [stderr] warning: transmute from a reference to a reference
[INFO] [stderr]    --> src/rwlock.rs:436:38
[INFO] [stderr]     |
[INFO] [stderr] 436 |                     __data: unsafe { mem::transmute::<&mut U, &UnsafeCell<U>>(new_data) },
[INFO] [stderr]     |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(new_data as *mut U as *const std::cell::UnsafeCell<U>)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/condvar.rs:24:22
[INFO] [stderr]    |
[INFO] [stderr] 24 |     pub fn timed_out(&self) -> bool {
[INFO] [stderr]    |                      ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `condvar::Condvar`
[INFO] [stderr]   --> src/condvar.rs:91:5
[INFO] [stderr]    |
[INFO] [stderr] 91 | /     pub fn new() -> Condvar {
[INFO] [stderr] 92 | |         Condvar {
[INFO] [stderr] 93 | |             inner: Box::new(StaticCondvar {
[INFO] [stderr] 94 | |                 inner: sys::Condvar::new(),
[INFO] [stderr] ...  |
[INFO] [stderr] 97 | |         }
[INFO] [stderr] 98 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 88 | impl Default for condvar::Condvar {
[INFO] [stderr] 89 |     fn default() -> Self {
[INFO] [stderr] 90 |         Self::new()
[INFO] [stderr] 91 |     }
[INFO] [stderr] 92 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] error: unneeded unit return type
[INFO] [stderr]    --> src/rwlock.rs:616:38
[INFO] [stderr]     |
[INFO] [stderr] 616 |         let _ = thread::spawn(move|| -> () {
[INFO] [stderr]     |                                      ^^^^^ help: remove the `-> ()`
[INFO] [stderr]     |
[INFO] [stderr] note: lint level defined here
[INFO] [stderr]    --> src/lib.rs:1:24
[INFO] [stderr]     |
[INFO] [stderr] 1   | #![cfg_attr(test, deny(warnings))]
[INFO] [stderr]     |                        ^^^^^^^^
[INFO] [stderr]     = note: #[deny(clippy::unused_unit)] implied by #[deny(warnings)]
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] error: unneeded unit return type
[INFO] [stderr]    --> src/mutex.rs:564:40
[INFO] [stderr]     |
[INFO] [stderr] 564 |         let _t = thread::spawn(move || -> () {
[INFO] [stderr]     |                                        ^^^^^ help: remove the `-> ()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] error: unneeded unit return type
[INFO] [stderr]    --> src/mutex.rs:620:38
[INFO] [stderr]     |
[INFO] [stderr] 620 |         let _ = thread::spawn(move|| -> () {
[INFO] [stderr]     |                                      ^^^^^ help: remove the `-> ()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 4 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `rwlock2`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "bc34d748679c2ee238ab2bffb98cf2a7b89f7145ddaa91867c55608fe8b65f9b"`
[INFO] running `"docker" "rm" "-f" "bc34d748679c2ee238ab2bffb98cf2a7b89f7145ddaa91867c55608fe8b65f9b"`
[INFO] [stdout] bc34d748679c2ee238ab2bffb98cf2a7b89f7145ddaa91867c55608fe8b65f9b