[INFO] crate rvue 0.1.0 is already in cache [INFO] extracting crate rvue 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/rvue/0.1.0 [INFO] extracting crate rvue 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rvue/0.1.0 [INFO] validating manifest of rvue-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rvue-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rvue-0.1.0 [INFO] finished frobbing rvue-0.1.0 [INFO] frobbed toml for rvue-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/rvue/0.1.0/Cargo.toml [INFO] started frobbing rvue-0.1.0 [INFO] finished frobbing rvue-0.1.0 [INFO] frobbed toml for rvue-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rvue/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rvue-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rvue/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 28c6cb6a5797934a81ad29341f900e83e190ce790d957f293e06a491ee4e4366 [INFO] running `"docker" "start" "-a" "28c6cb6a5797934a81ad29341f900e83e190ce790d957f293e06a491ee4e4366"` [INFO] [stderr] Checking reqwest v0.4.0 [INFO] [stderr] Checking rvue v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api.rs:114:13 [INFO] [stderr] | [INFO] [stderr] 114 | xml: xml, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `xml` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api.rs:180:13 [INFO] [stderr] | [INFO] [stderr] 180 | action: action, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `action` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/diff.rs:94:17 [INFO] [stderr] | [INFO] [stderr] 94 | changes: changes, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `changes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/diff.rs:180:17 [INFO] [stderr] | [INFO] [stderr] 180 | changes: changes, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `changes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:88:41 [INFO] [stderr] | [INFO] [stderr] 88 | courses: courses, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `courses` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:89:41 [INFO] [stderr] | [INFO] [stderr] 89 | reporting_period: reporting_period, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `reporting_period` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:90:41 [INFO] [stderr] | [INFO] [stderr] 90 | reporting_periods: reporting_periods, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `reporting_periods` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:282:29 [INFO] [stderr] | [INFO] [stderr] 282 | marks: marks, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `marks` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:283:29 [INFO] [stderr] | [INFO] [stderr] 283 | period: period, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `period` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:284:29 [INFO] [stderr] | [INFO] [stderr] 284 | room: room, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `room` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:285:29 [INFO] [stderr] | [INFO] [stderr] 285 | staff: staff, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `staff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:286:29 [INFO] [stderr] | [INFO] [stderr] 286 | staff_email: staff_email, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `staff_email` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:287:29 [INFO] [stderr] | [INFO] [stderr] 287 | title: title, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `title` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:379:29 [INFO] [stderr] | [INFO] [stderr] 379 | assignments: assignments, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `assignments` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:380:29 [INFO] [stderr] | [INFO] [stderr] 380 | mark_name: mark_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `mark_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:381:29 [INFO] [stderr] | [INFO] [stderr] 381 | calculated_score_raw: calculated_score_raw, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `calculated_score_raw` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:382:29 [INFO] [stderr] | [INFO] [stderr] 382 | calculated_score_string: calculated_score_string, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `calculated_score_string` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:383:29 [INFO] [stderr] | [INFO] [stderr] 383 | grade_calculation_summary: grade_calculation_summary, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `grade_calculation_summary` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:384:29 [INFO] [stderr] | [INFO] [stderr] 384 | standard_views: standard_views, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `standard_views` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:462:29 [INFO] [stderr] | [INFO] [stderr] 462 | cal_value: cal_value, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cal_value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:463:29 [INFO] [stderr] | [INFO] [stderr] 463 | description: description, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `description` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:464:29 [INFO] [stderr] | [INFO] [stderr] 464 | mark: mark, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `mark` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:465:29 [INFO] [stderr] | [INFO] [stderr] 465 | proficiency: proficiency, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `proficiency` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:466:29 [INFO] [stderr] | [INFO] [stderr] 466 | proficiency_max_value: proficiency_max_value, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `proficiency_max_value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:467:29 [INFO] [stderr] | [INFO] [stderr] 467 | standard_assignment_views: standard_assignment_views, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `standard_assignment_views` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:468:29 [INFO] [stderr] | [INFO] [stderr] 468 | subject: subject, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `subject` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:469:29 [INFO] [stderr] | [INFO] [stderr] 469 | subject_id: subject_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `subject_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:512:29 [INFO] [stderr] | [INFO] [stderr] 512 | _type: _type, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:513:29 [INFO] [stderr] | [INFO] [stderr] 513 | assignment: assignment, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `assignment` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:514:29 [INFO] [stderr] | [INFO] [stderr] 514 | cal_value: cal_value, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cal_value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:515:29 [INFO] [stderr] | [INFO] [stderr] 515 | due_date: due_date, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `due_date` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:516:29 [INFO] [stderr] | [INFO] [stderr] 516 | gradebook_id: gradebook_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `gradebook_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:517:29 [INFO] [stderr] | [INFO] [stderr] 517 | mark: mark, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `mark` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:518:29 [INFO] [stderr] | [INFO] [stderr] 518 | proficiency: proficiency, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `proficiency` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:519:29 [INFO] [stderr] | [INFO] [stderr] 519 | proficiency_max_value: proficiency_max_value, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `proficiency_max_value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:558:29 [INFO] [stderr] | [INFO] [stderr] 558 | _type: _type, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:559:29 [INFO] [stderr] | [INFO] [stderr] 559 | calculated_mark: calculated_mark, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `calculated_mark` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:560:29 [INFO] [stderr] | [INFO] [stderr] 560 | points: points, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `points` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:561:29 [INFO] [stderr] | [INFO] [stderr] 561 | points_possible: points_possible, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `points_possible` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:562:29 [INFO] [stderr] | [INFO] [stderr] 562 | weight: weight, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `weight` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:563:29 [INFO] [stderr] | [INFO] [stderr] 563 | weighted_pct: weighted_pct, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `weighted_pct` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:684:29 [INFO] [stderr] | [INFO] [stderr] 684 | _type: _type, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:685:29 [INFO] [stderr] | [INFO] [stderr] 685 | gradebook_id: gradebook_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `gradebook_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:686:29 [INFO] [stderr] | [INFO] [stderr] 686 | measure: measure, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `measure` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:687:29 [INFO] [stderr] | [INFO] [stderr] 687 | date: date, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `date` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:688:29 [INFO] [stderr] | [INFO] [stderr] 688 | due_date: due_date, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `due_date` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:689:29 [INFO] [stderr] | [INFO] [stderr] 689 | score: score, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `score` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:690:29 [INFO] [stderr] | [INFO] [stderr] 690 | score_type: score_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `score_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:691:29 [INFO] [stderr] | [INFO] [stderr] 691 | points: points, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `points` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:692:29 [INFO] [stderr] | [INFO] [stderr] 692 | notes: notes, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `notes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:693:29 [INFO] [stderr] | [INFO] [stderr] 693 | teacher_id: teacher_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `teacher_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:694:29 [INFO] [stderr] | [INFO] [stderr] 694 | student_id: student_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `student_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:695:29 [INFO] [stderr] | [INFO] [stderr] 695 | has_drop_box: has_drop_box, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `has_drop_box` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:696:29 [INFO] [stderr] | [INFO] [stderr] 696 | drop_start_date: drop_start_date, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `drop_start_date` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:697:29 [INFO] [stderr] | [INFO] [stderr] 697 | drop_end_date: drop_end_date, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `drop_end_date` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:698:29 [INFO] [stderr] | [INFO] [stderr] 698 | standards: standards, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `standards` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:859:29 [INFO] [stderr] | [INFO] [stderr] 859 | subject: subject, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `subject` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:860:29 [INFO] [stderr] | [INFO] [stderr] 860 | mark: mark, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `mark` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:861:29 [INFO] [stderr] | [INFO] [stderr] 861 | description: description, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `description` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:862:29 [INFO] [stderr] | [INFO] [stderr] 862 | proficiency: proficiency, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `proficiency` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:863:29 [INFO] [stderr] | [INFO] [stderr] 863 | proficiency_max_value: proficiency_max_value, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `proficiency_max_value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:864:29 [INFO] [stderr] | [INFO] [stderr] 864 | standard_screen_assignments: standard_screen_assignments, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `standard_screen_assignments` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:902:29 [INFO] [stderr] | [INFO] [stderr] 902 | _type: _type, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:903:29 [INFO] [stderr] | [INFO] [stderr] 903 | assignment: assignment, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `assignment` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:904:29 [INFO] [stderr] | [INFO] [stderr] 904 | due_date: due_date, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `due_date` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:905:29 [INFO] [stderr] | [INFO] [stderr] 905 | mark: mark, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `mark` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:906:29 [INFO] [stderr] | [INFO] [stderr] 906 | proficiency: proficiency, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `proficiency` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:907:29 [INFO] [stderr] | [INFO] [stderr] 907 | proficiency_max_value: proficiency_max_value, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `proficiency_max_value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api.rs:114:13 [INFO] [stderr] | [INFO] [stderr] 114 | xml: xml, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `xml` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api.rs:180:13 [INFO] [stderr] | [INFO] [stderr] 180 | action: action, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `action` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/diff.rs:94:17 [INFO] [stderr] | [INFO] [stderr] 94 | changes: changes, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `changes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/diff.rs:180:17 [INFO] [stderr] | [INFO] [stderr] 180 | changes: changes, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `changes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:88:41 [INFO] [stderr] | [INFO] [stderr] 88 | courses: courses, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `courses` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:89:41 [INFO] [stderr] | [INFO] [stderr] 89 | reporting_period: reporting_period, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `reporting_period` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:90:41 [INFO] [stderr] | [INFO] [stderr] 90 | reporting_periods: reporting_periods, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `reporting_periods` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:282:29 [INFO] [stderr] | [INFO] [stderr] 282 | marks: marks, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `marks` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:283:29 [INFO] [stderr] | [INFO] [stderr] 283 | period: period, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `period` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:284:29 [INFO] [stderr] | [INFO] [stderr] 284 | room: room, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `room` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:285:29 [INFO] [stderr] | [INFO] [stderr] 285 | staff: staff, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `staff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:286:29 [INFO] [stderr] | [INFO] [stderr] 286 | staff_email: staff_email, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `staff_email` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:287:29 [INFO] [stderr] | [INFO] [stderr] 287 | title: title, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `title` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:379:29 [INFO] [stderr] | [INFO] [stderr] 379 | assignments: assignments, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `assignments` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:380:29 [INFO] [stderr] | [INFO] [stderr] 380 | mark_name: mark_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `mark_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:381:29 [INFO] [stderr] | [INFO] [stderr] 381 | calculated_score_raw: calculated_score_raw, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `calculated_score_raw` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:382:29 [INFO] [stderr] | [INFO] [stderr] 382 | calculated_score_string: calculated_score_string, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `calculated_score_string` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:383:29 [INFO] [stderr] | [INFO] [stderr] 383 | grade_calculation_summary: grade_calculation_summary, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `grade_calculation_summary` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:384:29 [INFO] [stderr] | [INFO] [stderr] 384 | standard_views: standard_views, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `standard_views` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:462:29 [INFO] [stderr] | [INFO] [stderr] 462 | cal_value: cal_value, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cal_value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:463:29 [INFO] [stderr] | [INFO] [stderr] 463 | description: description, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `description` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:464:29 [INFO] [stderr] | [INFO] [stderr] 464 | mark: mark, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `mark` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:465:29 [INFO] [stderr] | [INFO] [stderr] 465 | proficiency: proficiency, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `proficiency` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:466:29 [INFO] [stderr] | [INFO] [stderr] 466 | proficiency_max_value: proficiency_max_value, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `proficiency_max_value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:467:29 [INFO] [stderr] | [INFO] [stderr] 467 | standard_assignment_views: standard_assignment_views, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `standard_assignment_views` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:468:29 [INFO] [stderr] | [INFO] [stderr] 468 | subject: subject, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `subject` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:469:29 [INFO] [stderr] | [INFO] [stderr] 469 | subject_id: subject_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `subject_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:512:29 [INFO] [stderr] | [INFO] [stderr] 512 | _type: _type, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:513:29 [INFO] [stderr] | [INFO] [stderr] 513 | assignment: assignment, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `assignment` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:514:29 [INFO] [stderr] | [INFO] [stderr] 514 | cal_value: cal_value, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cal_value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:515:29 [INFO] [stderr] | [INFO] [stderr] 515 | due_date: due_date, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `due_date` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:516:29 [INFO] [stderr] | [INFO] [stderr] 516 | gradebook_id: gradebook_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `gradebook_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:517:29 [INFO] [stderr] | [INFO] [stderr] 517 | mark: mark, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `mark` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:518:29 [INFO] [stderr] | [INFO] [stderr] 518 | proficiency: proficiency, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `proficiency` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:519:29 [INFO] [stderr] | [INFO] [stderr] 519 | proficiency_max_value: proficiency_max_value, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `proficiency_max_value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:558:29 [INFO] [stderr] | [INFO] [stderr] 558 | _type: _type, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:559:29 [INFO] [stderr] | [INFO] [stderr] 559 | calculated_mark: calculated_mark, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `calculated_mark` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:560:29 [INFO] [stderr] | [INFO] [stderr] 560 | points: points, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `points` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:561:29 [INFO] [stderr] | [INFO] [stderr] 561 | points_possible: points_possible, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `points_possible` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:562:29 [INFO] [stderr] | [INFO] [stderr] 562 | weight: weight, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `weight` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:563:29 [INFO] [stderr] | [INFO] [stderr] 563 | weighted_pct: weighted_pct, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `weighted_pct` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:684:29 [INFO] [stderr] | [INFO] [stderr] 684 | _type: _type, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:685:29 [INFO] [stderr] | [INFO] [stderr] 685 | gradebook_id: gradebook_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `gradebook_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:686:29 [INFO] [stderr] | [INFO] [stderr] 686 | measure: measure, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `measure` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:687:29 [INFO] [stderr] | [INFO] [stderr] 687 | date: date, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `date` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:688:29 [INFO] [stderr] | [INFO] [stderr] 688 | due_date: due_date, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `due_date` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:689:29 [INFO] [stderr] | [INFO] [stderr] 689 | score: score, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `score` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:690:29 [INFO] [stderr] | [INFO] [stderr] 690 | score_type: score_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `score_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:691:29 [INFO] [stderr] | [INFO] [stderr] 691 | points: points, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `points` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:692:29 [INFO] [stderr] | [INFO] [stderr] 692 | notes: notes, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `notes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:693:29 [INFO] [stderr] | [INFO] [stderr] 693 | teacher_id: teacher_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `teacher_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:694:29 [INFO] [stderr] | [INFO] [stderr] 694 | student_id: student_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `student_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:695:29 [INFO] [stderr] | [INFO] [stderr] 695 | has_drop_box: has_drop_box, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `has_drop_box` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:696:29 [INFO] [stderr] | [INFO] [stderr] 696 | drop_start_date: drop_start_date, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `drop_start_date` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:697:29 [INFO] [stderr] | [INFO] [stderr] 697 | drop_end_date: drop_end_date, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `drop_end_date` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:698:29 [INFO] [stderr] | [INFO] [stderr] 698 | standards: standards, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `standards` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:859:29 [INFO] [stderr] | [INFO] [stderr] 859 | subject: subject, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `subject` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:860:29 [INFO] [stderr] | [INFO] [stderr] 860 | mark: mark, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `mark` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:861:29 [INFO] [stderr] | [INFO] [stderr] 861 | description: description, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `description` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:862:29 [INFO] [stderr] | [INFO] [stderr] 862 | proficiency: proficiency, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `proficiency` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:863:29 [INFO] [stderr] | [INFO] [stderr] 863 | proficiency_max_value: proficiency_max_value, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `proficiency_max_value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:864:29 [INFO] [stderr] | [INFO] [stderr] 864 | standard_screen_assignments: standard_screen_assignments, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `standard_screen_assignments` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:902:29 [INFO] [stderr] | [INFO] [stderr] 902 | _type: _type, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:903:29 [INFO] [stderr] | [INFO] [stderr] 903 | assignment: assignment, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `assignment` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:904:29 [INFO] [stderr] | [INFO] [stderr] 904 | due_date: due_date, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `due_date` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:905:29 [INFO] [stderr] | [INFO] [stderr] 905 | mark: mark, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `mark` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:906:29 [INFO] [stderr] | [INFO] [stderr] 906 | proficiency: proficiency, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `proficiency` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gradebook.rs:907:29 [INFO] [stderr] | [INFO] [stderr] 907 | proficiency_max_value: proficiency_max_value, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `proficiency_max_value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/api.rs:12:23 [INFO] [stderr] | [INFO] [stderr] 12 | const SVUE_ENDPOINT: &'static str = "https://student-portland.cascadetech.org/portland/Service/PXPCommunication.asmx"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/api.rs:13:21 [INFO] [stderr] | [INFO] [stderr] 13 | const SOAP_ACTION: &'static [u8; 56] = b"http://edupoint.com/webservices/ProcessWebServiceRequest"; [INFO] [stderr] | -^^^^^^^--------- help: consider removing `'static`: `&[u8; 56]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/api.rs:156:16 [INFO] [stderr] | [INFO] [stderr] 156 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 157 | | if error { [INFO] [stderr] 158 | | let err = DecodedSVUEError::decode(xml) [INFO] [stderr] 159 | | .map_err(|e| SVUERequestError::SVUEErrorParsingFailed(e))?; [INFO] [stderr] ... | [INFO] [stderr] 164 | | } [INFO] [stderr] 165 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 156 | } else if error { [INFO] [stderr] 157 | let err = DecodedSVUEError::decode(xml) [INFO] [stderr] 158 | .map_err(|e| SVUERequestError::SVUEErrorParsingFailed(e))?; [INFO] [stderr] 159 | [INFO] [stderr] 160 | Err(SVUERequestError::SVUEError(err)) [INFO] [stderr] 161 | } else { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/api.rs:12:23 [INFO] [stderr] | [INFO] [stderr] 12 | const SVUE_ENDPOINT: &'static str = "https://student-portland.cascadetech.org/portland/Service/PXPCommunication.asmx"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/api.rs:13:21 [INFO] [stderr] | [INFO] [stderr] 13 | const SOAP_ACTION: &'static [u8; 56] = b"http://edupoint.com/webservices/ProcessWebServiceRequest"; [INFO] [stderr] | -^^^^^^^--------- help: consider removing `'static`: `&[u8; 56]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/api.rs:156:16 [INFO] [stderr] | [INFO] [stderr] 156 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 157 | | if error { [INFO] [stderr] 158 | | let err = DecodedSVUEError::decode(xml) [INFO] [stderr] 159 | | .map_err(|e| SVUERequestError::SVUEErrorParsingFailed(e))?; [INFO] [stderr] ... | [INFO] [stderr] 164 | | } [INFO] [stderr] 165 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 156 | } else if error { [INFO] [stderr] 157 | let err = DecodedSVUEError::decode(xml) [INFO] [stderr] 158 | .map_err(|e| SVUERequestError::SVUEErrorParsingFailed(e))?; [INFO] [stderr] 159 | [INFO] [stderr] 160 | Err(SVUERequestError::SVUEError(err)) [INFO] [stderr] 161 | } else { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/decoder.rs:35:41 [INFO] [stderr] | [INFO] [stderr] 35 | pub fn attributes_vec_to_map<'a>(attrs: &'a Vec) -> HashMap<&'a str, String> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[OwnedAttribute]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/api.rs:54:33 [INFO] [stderr] | [INFO] [stderr] 54 | / match name.local_name.as_str() { [INFO] [stderr] 55 | | "RT_ERROR" => { [INFO] [stderr] 56 | | let attrs = attributes_vec_to_map(&attributes); [INFO] [stderr] 57 | | error = Some(get_attr_owned!(attrs, "ERROR_MESSAGE")); [INFO] [stderr] 58 | | } [INFO] [stderr] 59 | | _ => {} [INFO] [stderr] 60 | | } [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 54 | if let "RT_ERROR" = name.local_name.as_str() { [INFO] [stderr] 55 | let attrs = attributes_vec_to_map(&attributes); [INFO] [stderr] 56 | error = Some(get_attr_owned!(attrs, "ERROR_MESSAGE")); [INFO] [stderr] 57 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/api.rs:63:33 [INFO] [stderr] | [INFO] [stderr] 63 | / match name.local_name.as_str() { [INFO] [stderr] 64 | | "RT_ERROR" => { break; } [INFO] [stderr] 65 | | _ => {} [INFO] [stderr] 66 | | } [INFO] [stderr] | |_________________________________^ help: try this: `if let "RT_ERROR" = name.local_name.as_str() { break; }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/api.rs:132:5 [INFO] [stderr] | [INFO] [stderr] 132 | / fn get_expected_xml<'a>(xml: String, expect: &'a str) -> Result { [INFO] [stderr] 133 | | let mut found = false; [INFO] [stderr] 134 | | let mut error = false; [INFO] [stderr] 135 | | [INFO] [stderr] ... | [INFO] [stderr] 165 | | } [INFO] [stderr] 166 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/api.rs:159:30 [INFO] [stderr] | [INFO] [stderr] 159 | .map_err(|e| SVUERequestError::SVUEErrorParsingFailed(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `SVUERequestError::SVUEErrorParsingFailed` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/api.rs:200:22 [INFO] [stderr] | [INFO] [stderr] 200 | .map_err(|e| SVUERequestError::ReqwestError(e)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `SVUERequestError::ReqwestError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/api.rs:204:30 [INFO] [stderr] | [INFO] [stderr] 204 | .map_err(|e| SVUERequestError::ResponseReadError(e))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `SVUERequestError::ResponseReadError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/api.rs:264:13 [INFO] [stderr] | [INFO] [stderr] 264 | / match self.action { [INFO] [stderr] 265 | | SVUEAPIAction::RetrieveGrades(idx) => { [INFO] [stderr] 266 | | if idx.is_some() { [INFO] [stderr] 267 | | let idx = idx.unwrap().to_string(); [INFO] [stderr] ... | [INFO] [stderr] 271 | | _ => {} [INFO] [stderr] 272 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 264 | if let SVUEAPIAction::RetrieveGrades(idx) = self.action { [INFO] [stderr] 265 | if idx.is_some() { [INFO] [stderr] 266 | let idx = idx.unwrap().to_string(); [INFO] [stderr] 267 | write_element! { w; "ReportPeriod" => &idx }; [INFO] [stderr] 268 | } [INFO] [stderr] 269 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/gradebook.rs:52:22 [INFO] [stderr] | [INFO] [stderr] 52 | .map_err(|e| SVUERequestError::DecodingError(e)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `SVUERequestError::DecodingError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/gradebook.rs:85:29 [INFO] [stderr] | [INFO] [stderr] 85 | / match name.local_name.as_str() { [INFO] [stderr] 86 | | "Gradebook" => { [INFO] [stderr] 87 | | return Ok(Gradebook { [INFO] [stderr] 88 | | courses: courses, [INFO] [stderr] ... | [INFO] [stderr] 93 | | _ => {} [INFO] [stderr] 94 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 85 | if let "Gradebook" = name.local_name.as_str() { [INFO] [stderr] 86 | return Ok(Gradebook { [INFO] [stderr] 87 | courses: courses, [INFO] [stderr] 88 | reporting_period: reporting_period, [INFO] [stderr] 89 | reporting_periods: reporting_periods, [INFO] [stderr] 90 | }); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/gradebook.rs:258:45 [INFO] [stderr] | [INFO] [stderr] 258 | / match name.local_name.as_str() { [INFO] [stderr] 259 | | "Course" => { [INFO] [stderr] 260 | | break; [INFO] [stderr] 261 | | } [INFO] [stderr] 262 | | _ => {} [INFO] [stderr] 263 | | } [INFO] [stderr] | |_____________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 258 | if let "Course" = name.local_name.as_str() { [INFO] [stderr] 259 | break; [INFO] [stderr] 260 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/gradebook.rs:358:45 [INFO] [stderr] | [INFO] [stderr] 358 | / match name.local_name.as_str() { [INFO] [stderr] 359 | | "Mark" => { [INFO] [stderr] 360 | | break; [INFO] [stderr] 361 | | } [INFO] [stderr] 362 | | _ => {} [INFO] [stderr] 363 | | } [INFO] [stderr] | |_____________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 358 | if let "Mark" = name.local_name.as_str() { [INFO] [stderr] 359 | break; [INFO] [stderr] 360 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/gradebook.rs:442:45 [INFO] [stderr] | [INFO] [stderr] 442 | / match name.local_name.as_str() { [INFO] [stderr] 443 | | "StandardAssignmentViews" => { [INFO] [stderr] 444 | | break; [INFO] [stderr] 445 | | } [INFO] [stderr] 446 | | _ => {} [INFO] [stderr] 447 | | } [INFO] [stderr] | |_____________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 442 | if let "StandardAssignmentViews" = name.local_name.as_str() { [INFO] [stderr] 443 | break; [INFO] [stderr] 444 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/gradebook.rs:590:18 [INFO] [stderr] | [INFO] [stderr] 590 | .unwrap_or(AssignmentGradeCalcWeight::Unparseable(weight.to_string())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| AssignmentGradeCalcWeight::Unparseable(weight.to_string()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/gradebook.rs:589:22 [INFO] [stderr] | [INFO] [stderr] 589 | .map(|i| AssignmentGradeCalcWeight::Percentage(i)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `AssignmentGradeCalcWeight::Percentage` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/gradebook.rs:667:45 [INFO] [stderr] | [INFO] [stderr] 667 | / match name.local_name.as_str() { [INFO] [stderr] 668 | | "Standards" => { [INFO] [stderr] 669 | | break; [INFO] [stderr] 670 | | } [INFO] [stderr] 671 | | _ => {} [INFO] [stderr] 672 | | } [INFO] [stderr] | |_____________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 667 | if let "Standards" = name.local_name.as_str() { [INFO] [stderr] 668 | break; [INFO] [stderr] 669 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/gradebook.rs:842:45 [INFO] [stderr] | [INFO] [stderr] 842 | / match name.local_name.as_str() { [INFO] [stderr] 843 | | "StandardScreenAssignments" => { [INFO] [stderr] 844 | | break; [INFO] [stderr] 845 | | } [INFO] [stderr] 846 | | _ => {} [INFO] [stderr] 847 | | } [INFO] [stderr] | |_____________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 842 | if let "StandardScreenAssignments" = name.local_name.as_str() { [INFO] [stderr] 843 | break; [INFO] [stderr] 844 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/decoder.rs:35:41 [INFO] [stderr] | [INFO] [stderr] 35 | pub fn attributes_vec_to_map<'a>(attrs: &'a Vec) -> HashMap<&'a str, String> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[OwnedAttribute]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/api.rs:54:33 [INFO] [stderr] | [INFO] [stderr] 54 | / match name.local_name.as_str() { [INFO] [stderr] 55 | | "RT_ERROR" => { [INFO] [stderr] 56 | | let attrs = attributes_vec_to_map(&attributes); [INFO] [stderr] 57 | | error = Some(get_attr_owned!(attrs, "ERROR_MESSAGE")); [INFO] [stderr] 58 | | } [INFO] [stderr] 59 | | _ => {} [INFO] [stderr] 60 | | } [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 54 | if let "RT_ERROR" = name.local_name.as_str() { [INFO] [stderr] 55 | let attrs = attributes_vec_to_map(&attributes); [INFO] [stderr] 56 | error = Some(get_attr_owned!(attrs, "ERROR_MESSAGE")); [INFO] [stderr] 57 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/api.rs:63:33 [INFO] [stderr] | [INFO] [stderr] 63 | / match name.local_name.as_str() { [INFO] [stderr] 64 | | "RT_ERROR" => { break; } [INFO] [stderr] 65 | | _ => {} [INFO] [stderr] 66 | | } [INFO] [stderr] | |_________________________________^ help: try this: `if let "RT_ERROR" = name.local_name.as_str() { break; }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/api.rs:132:5 [INFO] [stderr] | [INFO] [stderr] 132 | / fn get_expected_xml<'a>(xml: String, expect: &'a str) -> Result { [INFO] [stderr] 133 | | let mut found = false; [INFO] [stderr] 134 | | let mut error = false; [INFO] [stderr] 135 | | [INFO] [stderr] ... | [INFO] [stderr] 165 | | } [INFO] [stderr] 166 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/api.rs:159:30 [INFO] [stderr] | [INFO] [stderr] 159 | .map_err(|e| SVUERequestError::SVUEErrorParsingFailed(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `SVUERequestError::SVUEErrorParsingFailed` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/api.rs:200:22 [INFO] [stderr] | [INFO] [stderr] 200 | .map_err(|e| SVUERequestError::ReqwestError(e)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `SVUERequestError::ReqwestError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/api.rs:204:30 [INFO] [stderr] | [INFO] [stderr] 204 | .map_err(|e| SVUERequestError::ResponseReadError(e))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `SVUERequestError::ResponseReadError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/api.rs:264:13 [INFO] [stderr] | [INFO] [stderr] 264 | / match self.action { [INFO] [stderr] 265 | | SVUEAPIAction::RetrieveGrades(idx) => { [INFO] [stderr] 266 | | if idx.is_some() { [INFO] [stderr] 267 | | let idx = idx.unwrap().to_string(); [INFO] [stderr] ... | [INFO] [stderr] 271 | | _ => {} [INFO] [stderr] 272 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 264 | if let SVUEAPIAction::RetrieveGrades(idx) = self.action { [INFO] [stderr] 265 | if idx.is_some() { [INFO] [stderr] 266 | let idx = idx.unwrap().to_string(); [INFO] [stderr] 267 | write_element! { w; "ReportPeriod" => &idx }; [INFO] [stderr] 268 | } [INFO] [stderr] 269 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/gradebook.rs:52:22 [INFO] [stderr] | [INFO] [stderr] 52 | .map_err(|e| SVUERequestError::DecodingError(e)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `SVUERequestError::DecodingError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/gradebook.rs:85:29 [INFO] [stderr] | [INFO] [stderr] 85 | / match name.local_name.as_str() { [INFO] [stderr] 86 | | "Gradebook" => { [INFO] [stderr] 87 | | return Ok(Gradebook { [INFO] [stderr] 88 | | courses: courses, [INFO] [stderr] ... | [INFO] [stderr] 93 | | _ => {} [INFO] [stderr] 94 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 85 | if let "Gradebook" = name.local_name.as_str() { [INFO] [stderr] 86 | return Ok(Gradebook { [INFO] [stderr] 87 | courses: courses, [INFO] [stderr] 88 | reporting_period: reporting_period, [INFO] [stderr] 89 | reporting_periods: reporting_periods, [INFO] [stderr] 90 | }); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/gradebook.rs:258:45 [INFO] [stderr] | [INFO] [stderr] 258 | / match name.local_name.as_str() { [INFO] [stderr] 259 | | "Course" => { [INFO] [stderr] 260 | | break; [INFO] [stderr] 261 | | } [INFO] [stderr] 262 | | _ => {} [INFO] [stderr] 263 | | } [INFO] [stderr] | |_____________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 258 | if let "Course" = name.local_name.as_str() { [INFO] [stderr] 259 | break; [INFO] [stderr] 260 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/gradebook.rs:358:45 [INFO] [stderr] | [INFO] [stderr] 358 | / match name.local_name.as_str() { [INFO] [stderr] 359 | | "Mark" => { [INFO] [stderr] 360 | | break; [INFO] [stderr] 361 | | } [INFO] [stderr] 362 | | _ => {} [INFO] [stderr] 363 | | } [INFO] [stderr] | |_____________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 358 | if let "Mark" = name.local_name.as_str() { [INFO] [stderr] 359 | break; [INFO] [stderr] 360 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/gradebook.rs:442:45 [INFO] [stderr] | [INFO] [stderr] 442 | / match name.local_name.as_str() { [INFO] [stderr] 443 | | "StandardAssignmentViews" => { [INFO] [stderr] 444 | | break; [INFO] [stderr] 445 | | } [INFO] [stderr] 446 | | _ => {} [INFO] [stderr] 447 | | } [INFO] [stderr] | |_____________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 442 | if let "StandardAssignmentViews" = name.local_name.as_str() { [INFO] [stderr] 443 | break; [INFO] [stderr] 444 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/gradebook.rs:590:18 [INFO] [stderr] | [INFO] [stderr] 590 | .unwrap_or(AssignmentGradeCalcWeight::Unparseable(weight.to_string())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| AssignmentGradeCalcWeight::Unparseable(weight.to_string()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/gradebook.rs:589:22 [INFO] [stderr] | [INFO] [stderr] 589 | .map(|i| AssignmentGradeCalcWeight::Percentage(i)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `AssignmentGradeCalcWeight::Percentage` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/gradebook.rs:667:45 [INFO] [stderr] | [INFO] [stderr] 667 | / match name.local_name.as_str() { [INFO] [stderr] 668 | | "Standards" => { [INFO] [stderr] 669 | | break; [INFO] [stderr] 670 | | } [INFO] [stderr] 671 | | _ => {} [INFO] [stderr] 672 | | } [INFO] [stderr] | |_____________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 667 | if let "Standards" = name.local_name.as_str() { [INFO] [stderr] 668 | break; [INFO] [stderr] 669 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/gradebook.rs:842:45 [INFO] [stderr] | [INFO] [stderr] 842 | / match name.local_name.as_str() { [INFO] [stderr] 843 | | "StandardScreenAssignments" => { [INFO] [stderr] 844 | | break; [INFO] [stderr] 845 | | } [INFO] [stderr] 846 | | _ => {} [INFO] [stderr] 847 | | } [INFO] [stderr] | |_____________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 842 | if let "StandardScreenAssignments" = name.local_name.as_str() { [INFO] [stderr] 843 | break; [INFO] [stderr] 844 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 7.90s [INFO] running `"docker" "inspect" "28c6cb6a5797934a81ad29341f900e83e190ce790d957f293e06a491ee4e4366"` [INFO] running `"docker" "rm" "-f" "28c6cb6a5797934a81ad29341f900e83e190ce790d957f293e06a491ee4e4366"` [INFO] [stdout] 28c6cb6a5797934a81ad29341f900e83e190ce790d957f293e06a491ee4e4366