[INFO] crate rustyq 0.6.0 is already in cache [INFO] extracting crate rustyq 0.6.0 into work/ex/clippy-test-run/sources/stable/reg/rustyq/0.6.0 [INFO] extracting crate rustyq 0.6.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rustyq/0.6.0 [INFO] validating manifest of rustyq-0.6.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rustyq-0.6.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rustyq-0.6.0 [INFO] finished frobbing rustyq-0.6.0 [INFO] frobbed toml for rustyq-0.6.0 written to work/ex/clippy-test-run/sources/stable/reg/rustyq/0.6.0/Cargo.toml [INFO] started frobbing rustyq-0.6.0 [INFO] finished frobbing rustyq-0.6.0 [INFO] frobbed toml for rustyq-0.6.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rustyq/0.6.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rustyq-0.6.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rustyq/0.6.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7867c2eff5709cc6c58fdb0e0f483379f9766a1338c64591f8495296cabc2482 [INFO] running `"docker" "start" "-a" "7867c2eff5709cc6c58fdb0e0f483379f9766a1338c64591f8495296cabc2482"` [INFO] [stderr] Checking zmtp v0.6.0 [INFO] [stderr] Checking rustyq v0.6.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rep.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | peers: peers, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `peers` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rep.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | peers: peers, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `peers` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::u32` [INFO] [stderr] --> src/rep.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | use std::u32; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::u32` [INFO] [stderr] --> src/rep.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | use std::u32; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:20:21 [INFO] [stderr] | [INFO] [stderr] 20 | const ADDRESS: &'static str = "localhost:50000"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:22:28 [INFO] [stderr] | [INFO] [stderr] 22 | const BASIC_REQUEST: &'static str = "My Little Request"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:23:28 [INFO] [stderr] | [INFO] [stderr] 23 | const BASIC_RESPONSE: &'static str = "Server is not amused"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/req.rs:79:9 [INFO] [stderr] | [INFO] [stderr] 79 | / loop { [INFO] [stderr] 80 | | if self.peers.is_empty() { [INFO] [stderr] 81 | | let address = self.address; [INFO] [stderr] 82 | | self.connect(address).unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 103 | | } [INFO] [stderr] 104 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/rep.rs:65:9 [INFO] [stderr] | [INFO] [stderr] 65 | / loop { [INFO] [stderr] 66 | | let policy = [INFO] [stderr] 67 | | if self.peers.is_empty() { BlockPolicy::Block } [INFO] [stderr] 68 | | else { BlockPolicy::DontBlock }; [INFO] [stderr] ... | [INFO] [stderr] 88 | | } [INFO] [stderr] 89 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/rep.rs:69:13 [INFO] [stderr] | [INFO] [stderr] 69 | self.accept(&policy).map(|p| self.add_peer(p)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(p) = self.accept(&policy) { self.add_peer(p) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/rep.rs:112:9 [INFO] [stderr] | [INFO] [stderr] 112 | self.accept(&BlockPolicy::DontBlock).map(|p| self.add_peer(p)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(p) = self.accept(&BlockPolicy::DontBlock) { self.add_peer(p) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/rep.rs:113:9 [INFO] [stderr] | [INFO] [stderr] 113 | / loop { [INFO] [stderr] 114 | | if self.peers.len() == 0 { [INFO] [stderr] 115 | | self.accept(&BlockPolicy::Block).map(|p| self.add_peer(p)); [INFO] [stderr] 116 | | } [INFO] [stderr] ... | [INFO] [stderr] 132 | | }; [INFO] [stderr] 133 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/rep.rs:114:16 [INFO] [stderr] | [INFO] [stderr] 114 | if self.peers.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.peers.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/rep.rs:115:17 [INFO] [stderr] | [INFO] [stderr] 115 | self.accept(&BlockPolicy::Block).map(|p| self.add_peer(p)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(p) = self.accept(&BlockPolicy::Block) { self.add_peer(p) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rustyq`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/req.rs:79:9 [INFO] [stderr] | [INFO] [stderr] 79 | / loop { [INFO] [stderr] 80 | | if self.peers.is_empty() { [INFO] [stderr] 81 | | let address = self.address; [INFO] [stderr] 82 | | self.connect(address).unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 103 | | } [INFO] [stderr] 104 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/rep.rs:65:9 [INFO] [stderr] | [INFO] [stderr] 65 | / loop { [INFO] [stderr] 66 | | let policy = [INFO] [stderr] 67 | | if self.peers.is_empty() { BlockPolicy::Block } [INFO] [stderr] 68 | | else { BlockPolicy::DontBlock }; [INFO] [stderr] ... | [INFO] [stderr] 88 | | } [INFO] [stderr] 89 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/rep.rs:69:13 [INFO] [stderr] | [INFO] [stderr] 69 | self.accept(&policy).map(|p| self.add_peer(p)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(p) = self.accept(&policy) { self.add_peer(p) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/rep.rs:112:9 [INFO] [stderr] | [INFO] [stderr] 112 | self.accept(&BlockPolicy::DontBlock).map(|p| self.add_peer(p)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(p) = self.accept(&BlockPolicy::DontBlock) { self.add_peer(p) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/rep.rs:113:9 [INFO] [stderr] | [INFO] [stderr] 113 | / loop { [INFO] [stderr] 114 | | if self.peers.len() == 0 { [INFO] [stderr] 115 | | self.accept(&BlockPolicy::Block).map(|p| self.add_peer(p)); [INFO] [stderr] 116 | | } [INFO] [stderr] ... | [INFO] [stderr] 132 | | }; [INFO] [stderr] 133 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/rep.rs:114:16 [INFO] [stderr] | [INFO] [stderr] 114 | if self.peers.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.peers.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/rep.rs:115:17 [INFO] [stderr] | [INFO] [stderr] 115 | self.accept(&BlockPolicy::Block).map(|p| self.add_peer(p)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(p) = self.accept(&BlockPolicy::Block) { self.add_peer(p) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rustyq`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "7867c2eff5709cc6c58fdb0e0f483379f9766a1338c64591f8495296cabc2482"` [INFO] running `"docker" "rm" "-f" "7867c2eff5709cc6c58fdb0e0f483379f9766a1338c64591f8495296cabc2482"` [INFO] [stdout] 7867c2eff5709cc6c58fdb0e0f483379f9766a1338c64591f8495296cabc2482