[INFO] crate rustyline 3.0.0 is already in cache [INFO] extracting crate rustyline 3.0.0 into work/ex/clippy-test-run/sources/stable/reg/rustyline/3.0.0 [INFO] extracting crate rustyline 3.0.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rustyline/3.0.0 [INFO] validating manifest of rustyline-3.0.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rustyline-3.0.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rustyline-3.0.0 [INFO] finished frobbing rustyline-3.0.0 [INFO] frobbed toml for rustyline-3.0.0 written to work/ex/clippy-test-run/sources/stable/reg/rustyline/3.0.0/Cargo.toml [INFO] started frobbing rustyline-3.0.0 [INFO] finished frobbing rustyline-3.0.0 [INFO] frobbed toml for rustyline-3.0.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rustyline/3.0.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rustyline-3.0.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rustyline/3.0.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 88426002b66f04bf4597a78585b1d4e892d49da61b6ea2f99b9e650fefb065c9 [INFO] running `"docker" "start" "-a" "88426002b66f04bf4597a78585b1d4e892d49da61b6ea2f99b9e650fefb065c9"` [INFO] [stderr] Checking dirs v1.0.4 [INFO] [stderr] Checking rustyline v3.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `libc` [INFO] [stderr] --> src/lib.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | use libc; [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `libc` [INFO] [stderr] --> src/lib.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | use libc; [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:377:20 [INFO] [stderr] | [INFO] [stderr] 377 | original_mode: &tty::Mode, [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `tty::Mode` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let original_mode =` [INFO] [stderr] --> src/lib.rs:650:5 [INFO] [stderr] | [INFO] [stderr] 650 | let original_mode = editor.term.enable_raw_mode()?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.78s [INFO] running `"docker" "inspect" "88426002b66f04bf4597a78585b1d4e892d49da61b6ea2f99b9e650fefb065c9"` [INFO] running `"docker" "rm" "-f" "88426002b66f04bf4597a78585b1d4e892d49da61b6ea2f99b9e650fefb065c9"` [INFO] [stdout] 88426002b66f04bf4597a78585b1d4e892d49da61b6ea2f99b9e650fefb065c9