[INFO] crate rusty_tarantool 0.1.1 is already in cache [INFO] extracting crate rusty_tarantool 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/rusty_tarantool/0.1.1 [INFO] extracting crate rusty_tarantool 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rusty_tarantool/0.1.1 [INFO] validating manifest of rusty_tarantool-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rusty_tarantool-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rusty_tarantool-0.1.1 [INFO] finished frobbing rusty_tarantool-0.1.1 [INFO] frobbed toml for rusty_tarantool-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/rusty_tarantool/0.1.1/Cargo.toml [INFO] started frobbing rusty_tarantool-0.1.1 [INFO] finished frobbing rusty_tarantool-0.1.1 [INFO] frobbed toml for rusty_tarantool-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rusty_tarantool/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rusty_tarantool-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rusty_tarantool/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 937c535e4e0e870ee5c0092f3c38b776e8d5b9797dc15f535ba4b794b745a483 [INFO] running `"docker" "start" "-a" "937c535e4e0e870ee5c0092f3c38b776e8d5b9797dc15f535ba4b794b745a483"` [INFO] [stderr] Checking base64 v0.2.1 [INFO] [stderr] Checking rmp-serialize v0.8.0 [INFO] [stderr] Checking rmpv v0.4.0 [INFO] [stderr] Checking hyper v0.12.23 [INFO] [stderr] Checking rusty_tarantool v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/tarantool/codec.rs:48:16 [INFO] [stderr] | [INFO] [stderr] 48 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 49 | | if buf.len() < 5 { [INFO] [stderr] 50 | | Ok(None) [INFO] [stderr] 51 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 59 | | } [INFO] [stderr] 60 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 48 | } else if buf.len() < 5 { [INFO] [stderr] 49 | Ok(None) [INFO] [stderr] 50 | } else { [INFO] [stderr] 51 | let size: usize = decode_serde(&buf[0..5])?; [INFO] [stderr] 52 | [INFO] [stderr] 53 | if buf.len() - 5 < size { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio::net::ConnectFuture': use `tokio::net::tcp::ConnectFuture` instead [INFO] [stderr] --> src/tarantool/dispatch.rs:14:18 [INFO] [stderr] | [INFO] [stderr] 14 | use tokio::net::{ConnectFuture, TcpStream}; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio::net::ConnectFuture': use `tokio::net::tcp::ConnectFuture` instead [INFO] [stderr] --> src/tarantool/dispatch.rs:75:15 [INFO] [stderr] | [INFO] [stderr] 75 | OnConnect(ConnectFuture), [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `tarantool::codec::TarantoolCodec` [INFO] [stderr] --> src/tarantool/codec.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | / pub fn new() -> TarantoolCodec { [INFO] [stderr] 29 | | TarantoolCodec { [INFO] [stderr] 30 | | is_greetings_received: false, [INFO] [stderr] 31 | | salt: None, [INFO] [stderr] 32 | | } [INFO] [stderr] 33 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 22 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/tarantool/tools.rs:69:27 [INFO] [stderr] | [INFO] [stderr] 69 | pub fn get_map_value(map: &Vec<(Value, Value)>, key: u64) -> io::Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(Value, Value)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/tarantool/tools.rs:72:9 [INFO] [stderr] | [INFO] [stderr] 72 | / match row { [INFO] [stderr] 73 | | &(Value::Integer(row_key), Value::Integer(val)) if row_key.as_u64()==Some(key) && val.is_u64() => val.as_u64(), [INFO] [stderr] 74 | | _ => None [INFO] [stderr] 75 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 72 | match *row { [INFO] [stderr] 73 | (Value::Integer(row_key), Value::Integer(val)) if row_key.as_u64()==Some(key) && val.is_u64() => val.as_u64(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/tarantool/dispatch.rs:132:56 [INFO] [stderr] | [INFO] [stderr] 132 | fn send_error_to_all(&mut self, error_description: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/tarantool/dispatch.rs:138:16 [INFO] [stderr] | [INFO] [stderr] 138 | if let Some(_) = self.timeout_time_ms { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 139 | | self.timeout_id_to_key.clear(); [INFO] [stderr] 140 | | self.timeout_queue.clear(); [INFO] [stderr] 141 | | } [INFO] [stderr] | |_________- help: try this: `if self.timeout_time_ms.is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/tarantool/dispatch.rs:143:9 [INFO] [stderr] | [INFO] [stderr] 143 | / loop { [INFO] [stderr] 144 | | match self.command_receiver.poll() { [INFO] [stderr] 145 | | Ok(Async::Ready(Some((_, callback_sender)))) => { [INFO] [stderr] 146 | | let _res = callback_sender.send(Err(io::Error::new(io::ErrorKind::Other, error_description.clone()))); [INFO] [stderr] ... | [INFO] [stderr] 149 | | }; [INFO] [stderr] 150 | | } [INFO] [stderr] | |_________^ help: try: `while let Ok(Async::Ready(Some((_, callback_sender)))) = self.command_receiver.poll() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/tarantool/dispatch.rs:185:28 [INFO] [stderr] | [INFO] [stderr] 185 | if let Some(_) = self.timeout_time_ms { [INFO] [stderr] | _____________________- ^^^^^^^ [INFO] [stderr] 186 | | if let Some(delay_key) = self.timeout_id_to_key.remove(&request_id) { [INFO] [stderr] 187 | | self.timeout_queue.remove(&delay_key); [INFO] [stderr] 188 | | } [INFO] [stderr] 189 | | } [INFO] [stderr] | |_____________________- help: try this: `if self.timeout_time_ms.is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/tarantool/dispatch.rs:206:16 [INFO] [stderr] | [INFO] [stderr] 206 | if let Some(_) = self.timeout_time_ms { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 207 | | loop { [INFO] [stderr] 208 | | match self.timeout_queue.poll() { [INFO] [stderr] 209 | | Ok(Async::Ready(Some(request_id_ref))) => { [INFO] [stderr] ... | [INFO] [stderr] 222 | | } [INFO] [stderr] 223 | | } [INFO] [stderr] | |_________- help: try this: `if self.timeout_time_ms.is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/tarantool/dispatch.rs:227:9 [INFO] [stderr] | [INFO] [stderr] 227 | self.command_counter = self.command_counter + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.command_counter += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/tarantool/dispatch.rs:245:31 [INFO] [stderr] | [INFO] [stderr] 245 | let timeout_time_ms = config.timeout_time_ms.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `config.timeout_time_ms` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/tarantool/dispatch.rs:325:21 [INFO] [stderr] | [INFO] [stderr] 325 | / match self.engine.process_commands(sink) { [INFO] [stderr] 326 | | Ok(Async::Ready(())) => { [INFO] [stderr] 327 | | // stop client !!! exit from event loop ! [INFO] [stderr] 328 | | return Ok(Async::Ready(())); [INFO] [stderr] 329 | | } [INFO] [stderr] 330 | | _ => {} [INFO] [stderr] 331 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 325 | if let Ok(Async::Ready(())) = self.engine.process_commands(sink) { [INFO] [stderr] 326 | // stop client !!! exit from event loop ! [INFO] [stderr] 327 | return Ok(Async::Ready(())); [INFO] [stderr] 328 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> examples/simple-bench.rs:28:17 [INFO] [stderr] | [INFO] [stderr] 28 | let count = 1000000; [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/tarantool/codec.rs:48:16 [INFO] [stderr] | [INFO] [stderr] 48 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 49 | | if buf.len() < 5 { [INFO] [stderr] 50 | | Ok(None) [INFO] [stderr] 51 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 59 | | } [INFO] [stderr] 60 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 48 | } else if buf.len() < 5 { [INFO] [stderr] 49 | Ok(None) [INFO] [stderr] 50 | } else { [INFO] [stderr] 51 | let size: usize = decode_serde(&buf[0..5])?; [INFO] [stderr] 52 | [INFO] [stderr] 53 | if buf.len() - 5 < size { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio::net::ConnectFuture': use `tokio::net::tcp::ConnectFuture` instead [INFO] [stderr] --> src/tarantool/dispatch.rs:14:18 [INFO] [stderr] | [INFO] [stderr] 14 | use tokio::net::{ConnectFuture, TcpStream}; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio::net::ConnectFuture': use `tokio::net::tcp::ConnectFuture` instead [INFO] [stderr] --> src/tarantool/dispatch.rs:75:15 [INFO] [stderr] | [INFO] [stderr] 75 | OnConnect(ConnectFuture), [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `tarantool::codec::TarantoolCodec` [INFO] [stderr] --> src/tarantool/codec.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | / pub fn new() -> TarantoolCodec { [INFO] [stderr] 29 | | TarantoolCodec { [INFO] [stderr] 30 | | is_greetings_received: false, [INFO] [stderr] 31 | | salt: None, [INFO] [stderr] 32 | | } [INFO] [stderr] 33 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 22 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/tarantool/tools.rs:69:27 [INFO] [stderr] | [INFO] [stderr] 69 | pub fn get_map_value(map: &Vec<(Value, Value)>, key: u64) -> io::Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(Value, Value)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/tarantool/tools.rs:72:9 [INFO] [stderr] | [INFO] [stderr] 72 | / match row { [INFO] [stderr] 73 | | &(Value::Integer(row_key), Value::Integer(val)) if row_key.as_u64()==Some(key) && val.is_u64() => val.as_u64(), [INFO] [stderr] 74 | | _ => None [INFO] [stderr] 75 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 72 | match *row { [INFO] [stderr] 73 | (Value::Integer(row_key), Value::Integer(val)) if row_key.as_u64()==Some(key) && val.is_u64() => val.as_u64(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/tarantool/dispatch.rs:132:56 [INFO] [stderr] | [INFO] [stderr] 132 | fn send_error_to_all(&mut self, error_description: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/tarantool/dispatch.rs:138:16 [INFO] [stderr] | [INFO] [stderr] 138 | if let Some(_) = self.timeout_time_ms { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 139 | | self.timeout_id_to_key.clear(); [INFO] [stderr] 140 | | self.timeout_queue.clear(); [INFO] [stderr] 141 | | } [INFO] [stderr] | |_________- help: try this: `if self.timeout_time_ms.is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/tarantool/dispatch.rs:143:9 [INFO] [stderr] | [INFO] [stderr] 143 | / loop { [INFO] [stderr] 144 | | match self.command_receiver.poll() { [INFO] [stderr] 145 | | Ok(Async::Ready(Some((_, callback_sender)))) => { [INFO] [stderr] 146 | | let _res = callback_sender.send(Err(io::Error::new(io::ErrorKind::Other, error_description.clone()))); [INFO] [stderr] ... | [INFO] [stderr] 149 | | }; [INFO] [stderr] 150 | | } [INFO] [stderr] | |_________^ help: try: `while let Ok(Async::Ready(Some((_, callback_sender)))) = self.command_receiver.poll() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/tarantool/dispatch.rs:185:28 [INFO] [stderr] | [INFO] [stderr] 185 | if let Some(_) = self.timeout_time_ms { [INFO] [stderr] | _____________________- ^^^^^^^ [INFO] [stderr] 186 | | if let Some(delay_key) = self.timeout_id_to_key.remove(&request_id) { [INFO] [stderr] 187 | | self.timeout_queue.remove(&delay_key); [INFO] [stderr] 188 | | } [INFO] [stderr] 189 | | } [INFO] [stderr] | |_____________________- help: try this: `if self.timeout_time_ms.is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/tarantool/dispatch.rs:206:16 [INFO] [stderr] | [INFO] [stderr] 206 | if let Some(_) = self.timeout_time_ms { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 207 | | loop { [INFO] [stderr] 208 | | match self.timeout_queue.poll() { [INFO] [stderr] 209 | | Ok(Async::Ready(Some(request_id_ref))) => { [INFO] [stderr] ... | [INFO] [stderr] 222 | | } [INFO] [stderr] 223 | | } [INFO] [stderr] | |_________- help: try this: `if self.timeout_time_ms.is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/tarantool/dispatch.rs:227:9 [INFO] [stderr] | [INFO] [stderr] 227 | self.command_counter = self.command_counter + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.command_counter += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/tarantool/dispatch.rs:245:31 [INFO] [stderr] | [INFO] [stderr] 245 | let timeout_time_ms = config.timeout_time_ms.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `config.timeout_time_ms` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/tarantool/dispatch.rs:325:21 [INFO] [stderr] | [INFO] [stderr] 325 | / match self.engine.process_commands(sink) { [INFO] [stderr] 326 | | Ok(Async::Ready(())) => { [INFO] [stderr] 327 | | // stop client !!! exit from event loop ! [INFO] [stderr] 328 | | return Ok(Async::Ready(())); [INFO] [stderr] 329 | | } [INFO] [stderr] 330 | | _ => {} [INFO] [stderr] 331 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 325 | if let Ok(Async::Ready(())) = self.engine.process_commands(sink) { [INFO] [stderr] 326 | // stop client !!! exit from event loop ! [INFO] [stderr] 327 | return Ok(Async::Ready(())); [INFO] [stderr] 328 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 27.51s [INFO] running `"docker" "inspect" "937c535e4e0e870ee5c0092f3c38b776e8d5b9797dc15f535ba4b794b745a483"` [INFO] running `"docker" "rm" "-f" "937c535e4e0e870ee5c0092f3c38b776e8d5b9797dc15f535ba4b794b745a483"` [INFO] [stdout] 937c535e4e0e870ee5c0092f3c38b776e8d5b9797dc15f535ba4b794b745a483