[INFO] crate rusty_dashed 0.2.1 is already in cache [INFO] extracting crate rusty_dashed 0.2.1 into work/ex/clippy-test-run/sources/stable/reg/rusty_dashed/0.2.1 [INFO] extracting crate rusty_dashed 0.2.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rusty_dashed/0.2.1 [INFO] validating manifest of rusty_dashed-0.2.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rusty_dashed-0.2.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rusty_dashed-0.2.1 [INFO] finished frobbing rusty_dashed-0.2.1 [INFO] frobbed toml for rusty_dashed-0.2.1 written to work/ex/clippy-test-run/sources/stable/reg/rusty_dashed/0.2.1/Cargo.toml [INFO] started frobbing rusty_dashed-0.2.1 [INFO] finished frobbing rusty_dashed-0.2.1 [INFO] frobbed toml for rusty_dashed-0.2.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rusty_dashed/0.2.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rusty_dashed-0.2.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rusty_dashed/0.2.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 000b0d5f8eccb5e92e9c01d039b53407fe6e37735087190b79aa2ac39d787d82 [INFO] running `"docker" "start" "-a" "000b0d5f8eccb5e92e9c01d039b53407fe6e37735087190b79aa2ac39d787d82"` [INFO] [stderr] Compiling walkdir v0.1.8 [INFO] [stderr] Checking miow v0.1.5 [INFO] [stderr] Compiling flate2 v0.2.20 [INFO] [stderr] Checking iron v0.4.0 [INFO] [stderr] Checking mio v0.5.1 [INFO] [stderr] Checking includedir v0.2.2 [INFO] [stderr] Compiling includedir_codegen v0.2.2 [INFO] [stderr] Checking mount v0.2.1 [INFO] [stderr] Checking ws v0.5.3 [INFO] [stderr] Compiling rusty_dashed v0.2.1 (/opt/crater/workdir) [INFO] [stderr] Checking staticfile v0.3.1 [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server.rs:28:28 [INFO] [stderr] | [INFO] [stderr] 28 | let join = Server{ dashboard: dashboard }.start(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dashboard` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server.rs:28:28 [INFO] [stderr] | [INFO] [stderr] 28 | let join = Server{ dashboard: dashboard }.start(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dashboard` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/rusty_dashed-5b74325af28d191e/out/public.rs:4:10 [INFO] [stderr] | [INFO] [stderr] 4 | key: 3347381344252206323, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `3_347_381_344_252_206_323` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/server.rs:95:9 [INFO] [stderr] | [INFO] [stderr] 95 | server [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/server.rs:87:22 [INFO] [stderr] | [INFO] [stderr] 87 | let server = spawn(move || { [INFO] [stderr] | ______________________^ [INFO] [stderr] 88 | | let mut mount = Mount::new(); [INFO] [stderr] 89 | | mount [INFO] [stderr] 90 | | .mount("/", Server::get_static_file) [INFO] [stderr] ... | [INFO] [stderr] 93 | | Iron::new(mount).http("0.0.0.0:3000").unwrap(); [INFO] [stderr] 94 | | }); [INFO] [stderr] | |__________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `dashboard::Dashboard` [INFO] [stderr] --> src/dashboard.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | / pub fn new() -> Dashboard { [INFO] [stderr] 9 | | Dashboard { graph_types: vec![], graphs: vec![] } [INFO] [stderr] 10 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 2 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/rusty_dashed-5b74325af28d191e/out/public.rs:4:10 [INFO] [stderr] | [INFO] [stderr] 4 | key: 3347381344252206323, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `3_347_381_344_252_206_323` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/server.rs:95:9 [INFO] [stderr] | [INFO] [stderr] 95 | server [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/server.rs:87:22 [INFO] [stderr] | [INFO] [stderr] 87 | let server = spawn(move || { [INFO] [stderr] | ______________________^ [INFO] [stderr] 88 | | let mut mount = Mount::new(); [INFO] [stderr] 89 | | mount [INFO] [stderr] 90 | | .mount("/", Server::get_static_file) [INFO] [stderr] ... | [INFO] [stderr] 93 | | Iron::new(mount).http("0.0.0.0:3000").unwrap(); [INFO] [stderr] 94 | | }); [INFO] [stderr] | |__________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> examples/dashboard.rs:35:67 [INFO] [stderr] | [INFO] [stderr] 35 | self.nodes.push(Node { id: Net::get_node_name(self.next), group: group }); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `group` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> examples/dashboard.rs:40:104 [INFO] [stderr] | [INFO] [stderr] 40 | self.links.push(Link { source: Net::get_node_name(source), target: Net::get_node_name(target), value: value }); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `dashboard::Dashboard` [INFO] [stderr] --> src/dashboard.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | / pub fn new() -> Dashboard { [INFO] [stderr] 9 | | Dashboard { graph_types: vec![], graphs: vec![] } [INFO] [stderr] 10 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 2 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused import: `rustc_serialize::json` [INFO] [stderr] --> examples/dashboard.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | use rustc_serialize::json; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 24.21s [INFO] running `"docker" "inspect" "000b0d5f8eccb5e92e9c01d039b53407fe6e37735087190b79aa2ac39d787d82"` [INFO] running `"docker" "rm" "-f" "000b0d5f8eccb5e92e9c01d039b53407fe6e37735087190b79aa2ac39d787d82"` [INFO] [stdout] 000b0d5f8eccb5e92e9c01d039b53407fe6e37735087190b79aa2ac39d787d82