[INFO] crate rusty-x 0.1.6 is already in cache [INFO] extracting crate rusty-x 0.1.6 into work/ex/clippy-test-run/sources/stable/reg/rusty-x/0.1.6 [INFO] extracting crate rusty-x 0.1.6 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rusty-x/0.1.6 [INFO] validating manifest of rusty-x-0.1.6 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rusty-x-0.1.6 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rusty-x-0.1.6 [INFO] finished frobbing rusty-x-0.1.6 [INFO] frobbed toml for rusty-x-0.1.6 written to work/ex/clippy-test-run/sources/stable/reg/rusty-x/0.1.6/Cargo.toml [INFO] started frobbing rusty-x-0.1.6 [INFO] finished frobbing rusty-x-0.1.6 [INFO] frobbed toml for rusty-x-0.1.6 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rusty-x/0.1.6/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rusty-x-0.1.6 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rusty-x/0.1.6:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0c611c18830f10fe5beac30c3a9f183e74f8827e33e7eeab5b96548e8359d44e [INFO] running `"docker" "start" "-a" "0c611c18830f10fe5beac30c3a9f183e74f8827e33e7eeab5b96548e8359d44e"` [INFO] [stderr] Compiling onig_sys v69.1.0 [INFO] [stderr] Checking plist v0.3.0 [INFO] [stderr] Checking docopt v1.0.2 [INFO] [stderr] Checking markdown v0.2.0 [INFO] [stderr] Checking skim v0.4.0 [INFO] [stderr] Checking onig v4.3.1 [INFO] [stderr] Checking syntect v3.0.2 [INFO] [stderr] Checking rusty-x v0.1.6 (/opt/crater/workdir) [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/x.rs:213:5 [INFO] [stderr] | [INFO] [stderr] 213 | result [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/x.rs:131:18 [INFO] [stderr] | [INFO] [stderr] 131 | let result = match code { [INFO] [stderr] | __________________^ [INFO] [stderr] 132 | | OpCode::AddSnippet(new_file, location) => { [INFO] [stderr] 133 | | // Create the full path [INFO] [stderr] 134 | | let full_path = path::Path::new(&location.local).join(new_file); [INFO] [stderr] ... | [INFO] [stderr] 211 | | } [INFO] [stderr] 212 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/project.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | / return SnippetLocation { [INFO] [stderr] 23 | | local: String::from(home.to_owned() + "/.snippets"), [INFO] [stderr] 24 | | ext: "md".to_string(), [INFO] [stderr] 25 | | git: None, [INFO] [stderr] 26 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 22 | SnippetLocation { [INFO] [stderr] 23 | local: String::from(home.to_owned() + "/.snippets"), [INFO] [stderr] 24 | ext: "md".to_string(), [INFO] [stderr] 25 | git: None, [INFO] [stderr] 26 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/git.rs:44:17 [INFO] [stderr] | [INFO] [stderr] 44 | return Ok(true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(true)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/git.rs:46:17 [INFO] [stderr] | [INFO] [stderr] 46 | return Ok(false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(false)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/x.rs:213:5 [INFO] [stderr] | [INFO] [stderr] 213 | result [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/x.rs:131:18 [INFO] [stderr] | [INFO] [stderr] 131 | let result = match code { [INFO] [stderr] | __________________^ [INFO] [stderr] 132 | | OpCode::AddSnippet(new_file, location) => { [INFO] [stderr] 133 | | // Create the full path [INFO] [stderr] 134 | | let full_path = path::Path::new(&location.local).join(new_file); [INFO] [stderr] ... | [INFO] [stderr] 211 | | } [INFO] [stderr] 212 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/project.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | / return SnippetLocation { [INFO] [stderr] 23 | | local: String::from(home.to_owned() + "/.snippets"), [INFO] [stderr] 24 | | ext: "md".to_string(), [INFO] [stderr] 25 | | git: None, [INFO] [stderr] 26 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 22 | SnippetLocation { [INFO] [stderr] 23 | local: String::from(home.to_owned() + "/.snippets"), [INFO] [stderr] 24 | ext: "md".to_string(), [INFO] [stderr] 25 | git: None, [INFO] [stderr] 26 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/git.rs:44:17 [INFO] [stderr] | [INFO] [stderr] 44 | return Ok(true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(true)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/git.rs:46:17 [INFO] [stderr] | [INFO] [stderr] 46 | return Ok(false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(false)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/x.rs:63:18 [INFO] [stderr] | [INFO] [stderr] 63 | dir_entries: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[fs::DirEntry]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/x.rs:64:15 [INFO] [stderr] | [INFO] [stderr] 64 | keywords: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/x.rs:77:12 [INFO] [stderr] | [INFO] [stderr] 77 | if keyword_slice.len() == 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `keyword_slice.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/x.rs:79:20 [INFO] [stderr] | [INFO] [stderr] 79 | .iter() [INFO] [stderr] | ____________________^ [INFO] [stderr] 80 | | .fold(false, |res, tag| (res || keyword_slice.contains(&tag))) [INFO] [stderr] | |__________________________________________________________________________^ help: try: `.any(|tag| keyword_slice.contains(&tag))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/x.rs:117:24 [INFO] [stderr] | [INFO] [stderr] 117 | final_editor = editor.into(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider removing `.into()`: `editor` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/x.rs:143:17 [INFO] [stderr] | [INFO] [stderr] 143 | file.write(keyword.as_bytes())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/x.rs:144:17 [INFO] [stderr] | [INFO] [stderr] 144 | file.write(b",")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/project.rs:21:26 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn default(home: &String) -> SnippetLocation { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/project.rs:23:20 [INFO] [stderr] | [INFO] [stderr] 23 | local: String::from(home.to_owned() + "/.snippets"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `home.to_owned() + "/.snippets"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/snippet.rs:15:36 [INFO] [stderr] | [INFO] [stderr] 15 | pub fn new(name: String, tags: &Vec) -> Snippet { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rusty-x`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/x.rs:63:18 [INFO] [stderr] | [INFO] [stderr] 63 | dir_entries: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[fs::DirEntry]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/x.rs:64:15 [INFO] [stderr] | [INFO] [stderr] 64 | keywords: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/x.rs:77:12 [INFO] [stderr] | [INFO] [stderr] 77 | if keyword_slice.len() == 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `keyword_slice.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/x.rs:79:20 [INFO] [stderr] | [INFO] [stderr] 79 | .iter() [INFO] [stderr] | ____________________^ [INFO] [stderr] 80 | | .fold(false, |res, tag| (res || keyword_slice.contains(&tag))) [INFO] [stderr] | |__________________________________________________________________________^ help: try: `.any(|tag| keyword_slice.contains(&tag))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/x.rs:117:24 [INFO] [stderr] | [INFO] [stderr] 117 | final_editor = editor.into(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider removing `.into()`: `editor` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/x.rs:143:17 [INFO] [stderr] | [INFO] [stderr] 143 | file.write(keyword.as_bytes())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/x.rs:144:17 [INFO] [stderr] | [INFO] [stderr] 144 | file.write(b",")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/project.rs:21:26 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn default(home: &String) -> SnippetLocation { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/project.rs:23:20 [INFO] [stderr] | [INFO] [stderr] 23 | local: String::from(home.to_owned() + "/.snippets"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `home.to_owned() + "/.snippets"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/snippet.rs:15:36 [INFO] [stderr] | [INFO] [stderr] 15 | pub fn new(name: String, tags: &Vec) -> Snippet { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rusty-x`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "0c611c18830f10fe5beac30c3a9f183e74f8827e33e7eeab5b96548e8359d44e"` [INFO] running `"docker" "rm" "-f" "0c611c18830f10fe5beac30c3a9f183e74f8827e33e7eeab5b96548e8359d44e"` [INFO] [stdout] 0c611c18830f10fe5beac30c3a9f183e74f8827e33e7eeab5b96548e8359d44e