[INFO] crate rusty-variation 0.1.0 is already in cache [INFO] extracting crate rusty-variation 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/rusty-variation/0.1.0 [INFO] extracting crate rusty-variation 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rusty-variation/0.1.0 [INFO] validating manifest of rusty-variation-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rusty-variation-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rusty-variation-0.1.0 [INFO] finished frobbing rusty-variation-0.1.0 [INFO] frobbed toml for rusty-variation-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/rusty-variation/0.1.0/Cargo.toml [INFO] started frobbing rusty-variation-0.1.0 [INFO] finished frobbing rusty-variation-0.1.0 [INFO] frobbed toml for rusty-variation-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rusty-variation/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rusty-variation-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rusty-variation/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 15acfd032e5c1e76d7d6df24b6384240f3eab2a337a348e58a3e55f187de4ff2 [INFO] running `"docker" "start" "-a" "15acfd032e5c1e76d7d6df24b6384240f3eab2a337a348e58a3e55f187de4ff2"` [INFO] [stderr] Checking rusty-variation v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | return (End, End); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(End, End)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | return (Send { channel: sender }, Recv { channel: receiver }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(Send { channel: sender }, Recv { channel: receiver })` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:57:9 [INFO] [stderr] | [INFO] [stderr] 57 | return (here, there); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(here, there)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | return (End, End); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(End, End)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | return (Send { channel: sender }, Recv { channel: receiver }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(Send { channel: sender }, Recv { channel: receiver })` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:57:9 [INFO] [stderr] | [INFO] [stderr] 57 | return (here, there); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(here, there)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/lib.rs:107:21 [INFO] [stderr] | [INFO] [stderr] 107 | let r = (move || -> Result<_, Box> { [INFO] [stderr] | _____________________^ [INFO] [stderr] 108 | | $forked_process [INFO] [stderr] 109 | | })(); [INFO] [stderr] | |________________^ [INFO] [stderr] ... [INFO] [stderr] 353 | let (other_thread, s) = fork_with_thread_id!( [INFO] [stderr] | _________________________________- [INFO] [stderr] 354 | | move |s: NiceCalcServer| {cancel(s)}); [INFO] [stderr] | |______________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] help: Try doing something like: [INFO] [stderr] | [INFO] [stderr] 107 | let r = { [INFO] [stderr] 108 | $forked_process [INFO] [stderr] 109 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/lib.rs:107:21 [INFO] [stderr] | [INFO] [stderr] 107 | let r = (move || -> Result<_, Box> { [INFO] [stderr] | _____________________^ [INFO] [stderr] 108 | | $forked_process [INFO] [stderr] 109 | | })(); [INFO] [stderr] | |________________^ [INFO] [stderr] ... [INFO] [stderr] 374 | let (other_thread2, u) = fork_with_thread_id!( [INFO] [stderr] | __________________________________- [INFO] [stderr] 375 | | move |u: Recv, End>| {cancel(u)}); [INFO] [stderr] | |_________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] help: Try doing something like: [INFO] [stderr] | [INFO] [stderr] 107 | let r = { [INFO] [stderr] 108 | $forked_process [INFO] [stderr] 109 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/lib.rs:107:21 [INFO] [stderr] | [INFO] [stderr] 107 | let r = (move || -> Result<_, Box> { [INFO] [stderr] | _____________________^ [INFO] [stderr] 108 | | $forked_process [INFO] [stderr] 109 | | })(); [INFO] [stderr] | |________________^ [INFO] [stderr] ... [INFO] [stderr] 496 | let s = fork!(move |s: Send<(), End>| { [INFO] [stderr] | _________________- [INFO] [stderr] 497 | | mem::forget(s); [INFO] [stderr] 498 | | Ok(()) [INFO] [stderr] 499 | | }); [INFO] [stderr] | |__________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] help: Try doing something like: [INFO] [stderr] | [INFO] [stderr] 107 | let r = { [INFO] [stderr] 108 | $forked_process [INFO] [stderr] 109 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/lib.rs:198:46 [INFO] [stderr] | [INFO] [stderr] 198 | assert!(|| -> Result<(), Box> { [INFO] [stderr] | ______________________________________________^ [INFO] [stderr] 199 | | [INFO] [stderr] 200 | | let s = fork!(move |s: Send<(), End>| { [INFO] [stderr] 201 | | let s = send((), s)?; [INFO] [stderr] ... | [INFO] [stderr] 206 | | [INFO] [stderr] 207 | | }().is_ok()); [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::block_in_if_condition_stmt)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/lib.rs:238:46 [INFO] [stderr] | [INFO] [stderr] 238 | assert!(|| -> Result<(), Box> { [INFO] [stderr] | ______________________________________________^ [INFO] [stderr] 239 | | [INFO] [stderr] 240 | | let mut rng = thread_rng(); [INFO] [stderr] 241 | | [INFO] [stderr] ... | [INFO] [stderr] 265 | | [INFO] [stderr] 266 | | }().is_ok()); [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/lib.rs:296:46 [INFO] [stderr] | [INFO] [stderr] 296 | assert!(|| -> Result<(), Box> { [INFO] [stderr] | ______________________________________________^ [INFO] [stderr] 297 | | [INFO] [stderr] 298 | | // Pick some random numbers. [INFO] [stderr] 299 | | let mut rng = thread_rng(); [INFO] [stderr] ... | [INFO] [stderr] 326 | | [INFO] [stderr] 327 | | }().is_ok()); [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/lib.rs:335:46 [INFO] [stderr] | [INFO] [stderr] 335 | assert!(|| -> Result<(), Box> { [INFO] [stderr] | ______________________________________________^ [INFO] [stderr] 336 | | [INFO] [stderr] 337 | | cancel(s)?; [INFO] [stderr] 338 | | Ok(()) [INFO] [stderr] 339 | | [INFO] [stderr] 340 | | }().is_ok()); [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/lib.rs:356:46 [INFO] [stderr] | [INFO] [stderr] 356 | assert!(|| -> Result<(), Box> { [INFO] [stderr] | ______________________________________________^ [INFO] [stderr] 357 | | [INFO] [stderr] 358 | | let s = select!(CalcOp::Add, s)?; [INFO] [stderr] 359 | | let s = send(x, s)?; [INFO] [stderr] ... | [INFO] [stderr] 365 | | [INFO] [stderr] 366 | | }().is_err()); [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/lib.rs:377:46 [INFO] [stderr] | [INFO] [stderr] 377 | assert!(|| -> Result<(), Box> { [INFO] [stderr] | ______________________________________________^ [INFO] [stderr] 378 | | [INFO] [stderr] 379 | | let u = send(s, u)?; [INFO] [stderr] 380 | | close(u)?; [INFO] [stderr] 381 | | Ok(()) [INFO] [stderr] 382 | | [INFO] [stderr] 383 | | }().is_ok()); [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/lib.rs:393:47 [INFO] [stderr] | [INFO] [stderr] 393 | assert!(|| -> Result> { [INFO] [stderr] | _______________________________________________^ [INFO] [stderr] 394 | | [INFO] [stderr] 395 | | // Create a closure which uses the session. [INFO] [stderr] 396 | | let f = move |x: i32| -> Result> { [INFO] [stderr] ... | [INFO] [stderr] 407 | | [INFO] [stderr] 408 | | }().is_err()); [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/lib.rs:464:46 [INFO] [stderr] | [INFO] [stderr] 464 | assert!(|| -> Result<(), Box> { [INFO] [stderr] | ______________________________________________^ [INFO] [stderr] 465 | | [INFO] [stderr] 466 | | let sum2 = nice_sum_client_accum(s, xs)?; [INFO] [stderr] 467 | | assert_eq!(sum1, sum2); [INFO] [stderr] 468 | | Ok(()) [INFO] [stderr] 469 | | [INFO] [stderr] 470 | | }().is_ok()); [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.52s [INFO] running `"docker" "inspect" "15acfd032e5c1e76d7d6df24b6384240f3eab2a337a348e58a3e55f187de4ff2"` [INFO] running `"docker" "rm" "-f" "15acfd032e5c1e76d7d6df24b6384240f3eab2a337a348e58a3e55f187de4ff2"` [INFO] [stdout] 15acfd032e5c1e76d7d6df24b6384240f3eab2a337a348e58a3e55f187de4ff2