[INFO] crate rusty-tags 3.2.0 is already in cache [INFO] extracting crate rusty-tags 3.2.0 into work/ex/clippy-test-run/sources/stable/reg/rusty-tags/3.2.0 [INFO] extracting crate rusty-tags 3.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rusty-tags/3.2.0 [INFO] validating manifest of rusty-tags-3.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rusty-tags-3.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rusty-tags-3.2.0 [INFO] finished frobbing rusty-tags-3.2.0 [INFO] frobbed toml for rusty-tags-3.2.0 written to work/ex/clippy-test-run/sources/stable/reg/rusty-tags/3.2.0/Cargo.toml [INFO] started frobbing rusty-tags-3.2.0 [INFO] finished frobbing rusty-tags-3.2.0 [INFO] frobbed toml for rusty-tags-3.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rusty-tags/3.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rusty-tags-3.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rusty-tags/3.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 03cd414437d0223e51d6be94ce4f8007f10facbb620f88ec06381c5f8fda15ea [INFO] running `"docker" "start" "-a" "03cd414437d0223e51d6be94ce4f8007f10facbb620f88ec06381c5f8fda15ea"` [INFO] [stderr] Checking rusty-tags v3.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/tags.rs:111:17 [INFO] [stderr] | [INFO] [stderr] 111 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types.rs:276:13 [INFO] [stderr] | [INFO] [stderr] 276 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types.rs:280:13 [INFO] [stderr] | [INFO] [stderr] 280 | hash: hash, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `hash` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types.rs:281:13 [INFO] [stderr] | [INFO] [stderr] 281 | is_root: is_root, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `is_root` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types.rs:282:13 [INFO] [stderr] | [INFO] [stderr] 282 | tags_file: tags_file, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `tags_file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types.rs:283:13 [INFO] [stderr] | [INFO] [stderr] 283 | cached_tags_file: cached_tags_file [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cached_tags_file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types.rs:459:13 [INFO] [stderr] | [INFO] [stderr] 459 | kind: kind, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types.rs:460:13 [INFO] [stderr] | [INFO] [stderr] 460 | exe: exe, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `exe` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types.rs:461:13 [INFO] [stderr] | [INFO] [stderr] 461 | vi_tags: vi_tags, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `vi_tags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types.rs:462:13 [INFO] [stderr] | [INFO] [stderr] 462 | emacs_tags: emacs_tags, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `emacs_tags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types.rs:463:13 [INFO] [stderr] | [INFO] [stderr] 463 | ctags_options: ctags_options [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `ctags_options` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:105:12 [INFO] [stderr] | [INFO] [stderr] 105 | start_dir: start_dir, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `start_dir` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:106:12 [INFO] [stderr] | [INFO] [stderr] 106 | omit_deps: omit_deps, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `omit_deps` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:107:12 [INFO] [stderr] | [INFO] [stderr] 107 | force_recreate: force_recreate, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `force_recreate` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:108:12 [INFO] [stderr] | [INFO] [stderr] 108 | verbose: verbose, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `verbose` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:109:12 [INFO] [stderr] | [INFO] [stderr] 109 | quiet: quiet, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `quiet` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:110:12 [INFO] [stderr] | [INFO] [stderr] 110 | num_threads: num_threads [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num_threads` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/tags.rs:111:17 [INFO] [stderr] | [INFO] [stderr] 111 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types.rs:276:13 [INFO] [stderr] | [INFO] [stderr] 276 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types.rs:280:13 [INFO] [stderr] | [INFO] [stderr] 280 | hash: hash, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `hash` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types.rs:281:13 [INFO] [stderr] | [INFO] [stderr] 281 | is_root: is_root, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `is_root` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types.rs:282:13 [INFO] [stderr] | [INFO] [stderr] 282 | tags_file: tags_file, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `tags_file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types.rs:283:13 [INFO] [stderr] | [INFO] [stderr] 283 | cached_tags_file: cached_tags_file [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cached_tags_file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types.rs:459:13 [INFO] [stderr] | [INFO] [stderr] 459 | kind: kind, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types.rs:460:13 [INFO] [stderr] | [INFO] [stderr] 460 | exe: exe, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `exe` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types.rs:461:13 [INFO] [stderr] | [INFO] [stderr] 461 | vi_tags: vi_tags, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `vi_tags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types.rs:462:13 [INFO] [stderr] | [INFO] [stderr] 462 | emacs_tags: emacs_tags, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `emacs_tags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types.rs:463:13 [INFO] [stderr] | [INFO] [stderr] 463 | ctags_options: ctags_options [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `ctags_options` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:105:12 [INFO] [stderr] | [INFO] [stderr] 105 | start_dir: start_dir, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `start_dir` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:106:12 [INFO] [stderr] | [INFO] [stderr] 106 | omit_deps: omit_deps, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `omit_deps` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:107:12 [INFO] [stderr] | [INFO] [stderr] 107 | force_recreate: force_recreate, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `force_recreate` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:108:12 [INFO] [stderr] | [INFO] [stderr] 108 | verbose: verbose, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `verbose` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:109:12 [INFO] [stderr] | [INFO] [stderr] 109 | quiet: quiet, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `quiet` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:110:12 [INFO] [stderr] | [INFO] [stderr] 110 | num_threads: num_threads [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num_threads` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/dirs.rs:43:25 [INFO] [stderr] | [INFO] [stderr] 43 | if let Some(path) = env::home_dir() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/dirs.rs:43:25 [INFO] [stderr] | [INFO] [stderr] 43 | if let Some(path) = env::home_dir() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/rt_result.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | / match self { [INFO] [stderr] 22 | | &RtErr::Message(ref msg) => writeln!(f, "{}", msg), [INFO] [stderr] 23 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 21 | match *self { [INFO] [stderr] 22 | RtErr::Message(ref msg) => writeln!(f, "{}", msg), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/dependencies.rs:28:14 [INFO] [stderr] | [INFO] [stderr] 28 | .ok_or(format!("Expected 'workspace_members' of type string but found: {}", to_string_pretty(member)))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("Expected 'workspace_members' of type string but found: {}", to_string_pretty(member)))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/dependencies.rs:111:26 [INFO] [stderr] | [INFO] [stderr] 111 | .ok_or(format!("Couldn't find string in dependency:\n{}", to_string_pretty(dep)))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("Couldn't find string in dependency:\n{}", to_string_pretty(dep)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/dependencies.rs:143:10 [INFO] [stderr] | [INFO] [stderr] 143 | .ok_or(format!("Couldn't find package for {}", source_version).into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("Couldn't find package for {}", source_version).into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/dependencies.rs:153:14 [INFO] [stderr] | [INFO] [stderr] 153 | .ok_or(format!("Couldn't get directory of path '{:?}'", manifest_path.display()))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("Couldn't get directory of path '{:?}'", manifest_path.display()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/dependencies.rs:161:18 [INFO] [stderr] | [INFO] [stderr] 161 | .ok_or(format!("Expected 'kind' of type string but found: {}", to_string_pretty(kind)))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("Expected 'kind' of type string but found: {}", to_string_pretty(kind)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/dependencies.rs:171:22 [INFO] [stderr] | [INFO] [stderr] 171 | .ok_or(format!("Couldn't get directory of path '{:?}' in target:\n{}\nof package:\n{}", [INFO] [stderr] | ______________________^ [INFO] [stderr] 172 | | src_path.display(), to_string_pretty(target), to_string_pretty(package)))?; [INFO] [stderr] | |____________________________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 171 | .ok_or_else(|| format!("Couldn't get directory of path '{:?}' in target:\n{}\nof package:\n{}", [INFO] [stderr] 172 | src_path.display(), to_string_pretty(target), to_string_pretty(package)))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/dependencies.rs:192:5 [INFO] [stderr] | [INFO] [stderr] 192 | serde_json::to_string_pretty(value).unwrap_or(String::new()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `serde_json::to_string_pretty(value).unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/dependencies.rs:198:11 [INFO] [stderr] | [INFO] [stderr] 198 | .ok_or(format!("Couldn't find array entry '{}' in:\n{}", entry, to_string_pretty(value)).into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("Couldn't find array entry '{}' in:\n{}", entry, to_string_pretty(value)).into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/dependencies.rs:204:11 [INFO] [stderr] | [INFO] [stderr] 204 | .ok_or(format!("Couldn't find string entry '{}' in:\n{}", entry, to_string_pretty(value)).into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("Couldn't find string entry '{}' in:\n{}", entry, to_string_pretty(value)).into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/dependencies.rs:210:11 [INFO] [stderr] | [INFO] [stderr] 210 | .ok_or(format!("Couldn't find object entry '{}' in:\n{}", entry, to_string_pretty(value)).into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("Couldn't find object entry '{}' in:\n{}", entry, to_string_pretty(value)).into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/dependencies.rs:216:12 [INFO] [stderr] | [INFO] [stderr] 216 | .ok_or(format!("Couldn't find array entry '{}' in:\n{:?}", entry, object).into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("Couldn't find array entry '{}' in:\n{:?}", entry, object).into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/tags.rs:223:5 [INFO] [stderr] | [INFO] [stderr] 223 | let _ = rename(from_tags, to_tags)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/tags.rs:366:16 [INFO] [stderr] | [INFO] [stderr] 366 | if mods.len() >= 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!mods.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/config.rs:162:16 [INFO] [stderr] | [INFO] [stderr] 162 | let exes = if let &Some(ref exe) = ctags_exe { [INFO] [stderr] | ________________^ [INFO] [stderr] 163 | | vec![exe.as_str()] [INFO] [stderr] 164 | | } else { [INFO] [stderr] 165 | | vec!["ctags", "exuberant-ctags", "exctags", "universal-ctags", "uctags"] [INFO] [stderr] 166 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 162 | let exes = if let Some(ref exe) = *ctags_exe { [INFO] [stderr] | ^^^^^^^^^^^^^ ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/main.rs:123:8 [INFO] [stderr] | [INFO] [stderr] 123 | if ! src_path_str.is_ok() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `src_path_str.is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/rt_result.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | / match self { [INFO] [stderr] 22 | | &RtErr::Message(ref msg) => writeln!(f, "{}", msg), [INFO] [stderr] 23 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 21 | match *self { [INFO] [stderr] 22 | RtErr::Message(ref msg) => writeln!(f, "{}", msg), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/dependencies.rs:28:14 [INFO] [stderr] | [INFO] [stderr] 28 | .ok_or(format!("Expected 'workspace_members' of type string but found: {}", to_string_pretty(member)))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("Expected 'workspace_members' of type string but found: {}", to_string_pretty(member)))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/dependencies.rs:111:26 [INFO] [stderr] | [INFO] [stderr] 111 | .ok_or(format!("Couldn't find string in dependency:\n{}", to_string_pretty(dep)))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("Couldn't find string in dependency:\n{}", to_string_pretty(dep)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/dependencies.rs:143:10 [INFO] [stderr] | [INFO] [stderr] 143 | .ok_or(format!("Couldn't find package for {}", source_version).into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("Couldn't find package for {}", source_version).into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/dependencies.rs:153:14 [INFO] [stderr] | [INFO] [stderr] 153 | .ok_or(format!("Couldn't get directory of path '{:?}'", manifest_path.display()))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("Couldn't get directory of path '{:?}'", manifest_path.display()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/dependencies.rs:161:18 [INFO] [stderr] | [INFO] [stderr] 161 | .ok_or(format!("Expected 'kind' of type string but found: {}", to_string_pretty(kind)))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("Expected 'kind' of type string but found: {}", to_string_pretty(kind)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/dependencies.rs:171:22 [INFO] [stderr] | [INFO] [stderr] 171 | .ok_or(format!("Couldn't get directory of path '{:?}' in target:\n{}\nof package:\n{}", [INFO] [stderr] | ______________________^ [INFO] [stderr] 172 | | src_path.display(), to_string_pretty(target), to_string_pretty(package)))?; [INFO] [stderr] | |____________________________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 171 | .ok_or_else(|| format!("Couldn't get directory of path '{:?}' in target:\n{}\nof package:\n{}", [INFO] [stderr] 172 | src_path.display(), to_string_pretty(target), to_string_pretty(package)))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/dependencies.rs:192:5 [INFO] [stderr] | [INFO] [stderr] 192 | serde_json::to_string_pretty(value).unwrap_or(String::new()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `serde_json::to_string_pretty(value).unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/dependencies.rs:198:11 [INFO] [stderr] | [INFO] [stderr] 198 | .ok_or(format!("Couldn't find array entry '{}' in:\n{}", entry, to_string_pretty(value)).into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("Couldn't find array entry '{}' in:\n{}", entry, to_string_pretty(value)).into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/dependencies.rs:204:11 [INFO] [stderr] | [INFO] [stderr] 204 | .ok_or(format!("Couldn't find string entry '{}' in:\n{}", entry, to_string_pretty(value)).into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("Couldn't find string entry '{}' in:\n{}", entry, to_string_pretty(value)).into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/dependencies.rs:210:11 [INFO] [stderr] | [INFO] [stderr] 210 | .ok_or(format!("Couldn't find object entry '{}' in:\n{}", entry, to_string_pretty(value)).into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("Couldn't find object entry '{}' in:\n{}", entry, to_string_pretty(value)).into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/dependencies.rs:216:12 [INFO] [stderr] | [INFO] [stderr] 216 | .ok_or(format!("Couldn't find array entry '{}' in:\n{:?}", entry, object).into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("Couldn't find array entry '{}' in:\n{:?}", entry, object).into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/tags.rs:223:5 [INFO] [stderr] | [INFO] [stderr] 223 | let _ = rename(from_tags, to_tags)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/tags.rs:366:16 [INFO] [stderr] | [INFO] [stderr] 366 | if mods.len() >= 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!mods.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/config.rs:162:16 [INFO] [stderr] | [INFO] [stderr] 162 | let exes = if let &Some(ref exe) = ctags_exe { [INFO] [stderr] | ________________^ [INFO] [stderr] 163 | | vec![exe.as_str()] [INFO] [stderr] 164 | | } else { [INFO] [stderr] 165 | | vec!["ctags", "exuberant-ctags", "exctags", "universal-ctags", "uctags"] [INFO] [stderr] 166 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 162 | let exes = if let Some(ref exe) = *ctags_exe { [INFO] [stderr] | ^^^^^^^^^^^^^ ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/main.rs:123:8 [INFO] [stderr] | [INFO] [stderr] 123 | if ! src_path_str.is_ok() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `src_path_str.is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.59s [INFO] running `"docker" "inspect" "03cd414437d0223e51d6be94ce4f8007f10facbb620f88ec06381c5f8fda15ea"` [INFO] running `"docker" "rm" "-f" "03cd414437d0223e51d6be94ce4f8007f10facbb620f88ec06381c5f8fda15ea"` [INFO] [stdout] 03cd414437d0223e51d6be94ce4f8007f10facbb620f88ec06381c5f8fda15ea