[INFO] crate rusty-santa-cli 0.1.0 is already in cache [INFO] extracting crate rusty-santa-cli 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/rusty-santa-cli/0.1.0 [INFO] extracting crate rusty-santa-cli 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rusty-santa-cli/0.1.0 [INFO] validating manifest of rusty-santa-cli-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rusty-santa-cli-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rusty-santa-cli-0.1.0 [INFO] finished frobbing rusty-santa-cli-0.1.0 [INFO] frobbed toml for rusty-santa-cli-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/rusty-santa-cli/0.1.0/Cargo.toml [INFO] started frobbing rusty-santa-cli-0.1.0 [INFO] finished frobbing rusty-santa-cli-0.1.0 [INFO] frobbed toml for rusty-santa-cli-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rusty-santa-cli/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rusty-santa-cli-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rusty-santa-cli/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 95ae8361f20c74d868a275065a9b74f997f6788d35d2f36ae1b69cb7b3153063 [INFO] running `"docker" "start" "-a" "95ae8361f20c74d868a275065a9b74f997f6788d35d2f36ae1b69cb7b3153063"` [INFO] [stderr] Checking rusty-santa v0.1.0 [INFO] [stderr] Checking rusty-santa-cli v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:11:17 [INFO] [stderr] | [INFO] [stderr] 11 | const VERSION: &'static str = env!("CARGO_PKG_VERSION"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/main.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | / loop { [INFO] [stderr] 50 | | match get_name(1, &mut group) { [INFO] [stderr] 51 | | Some(name1) => match get_name(2, &mut group) { [INFO] [stderr] 52 | | Some(name2) => { [INFO] [stderr] ... | [INFO] [stderr] 60 | | } [INFO] [stderr] 61 | | } [INFO] [stderr] | |_____^ help: try: `while let Some(name1) = get_name(1, &mut group) { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/main.rs:66:5 [INFO] [stderr] | [INFO] [stderr] 66 | / loop { [INFO] [stderr] 67 | | match get_name(1, &mut group) { [INFO] [stderr] 68 | | Some(name1) => match get_name(2, &mut group) { [INFO] [stderr] 69 | | Some(name2) => { [INFO] [stderr] ... | [INFO] [stderr] 77 | | } [INFO] [stderr] 78 | | } [INFO] [stderr] | |_____^ help: try: `while let Some(name1) = get_name(1, &mut group) { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:11:17 [INFO] [stderr] | [INFO] [stderr] 11 | const VERSION: &'static str = env!("CARGO_PKG_VERSION"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/main.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | / loop { [INFO] [stderr] 50 | | match get_name(1, &mut group) { [INFO] [stderr] 51 | | Some(name1) => match get_name(2, &mut group) { [INFO] [stderr] 52 | | Some(name2) => { [INFO] [stderr] ... | [INFO] [stderr] 60 | | } [INFO] [stderr] 61 | | } [INFO] [stderr] | |_____^ help: try: `while let Some(name1) = get_name(1, &mut group) { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/main.rs:66:5 [INFO] [stderr] | [INFO] [stderr] 66 | / loop { [INFO] [stderr] 67 | | match get_name(1, &mut group) { [INFO] [stderr] 68 | | Some(name1) => match get_name(2, &mut group) { [INFO] [stderr] 69 | | Some(name2) => { [INFO] [stderr] ... | [INFO] [stderr] 77 | | } [INFO] [stderr] 78 | | } [INFO] [stderr] | |_____^ help: try: `while let Some(name1) = get_name(1, &mut group) { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.42s [INFO] running `"docker" "inspect" "95ae8361f20c74d868a275065a9b74f997f6788d35d2f36ae1b69cb7b3153063"` [INFO] running `"docker" "rm" "-f" "95ae8361f20c74d868a275065a9b74f997f6788d35d2f36ae1b69cb7b3153063"` [INFO] [stdout] 95ae8361f20c74d868a275065a9b74f997f6788d35d2f36ae1b69cb7b3153063