[INFO] crate rusty-release 0.6.1 is already in cache [INFO] extracting crate rusty-release 0.6.1 into work/ex/clippy-test-run/sources/stable/reg/rusty-release/0.6.1 [INFO] extracting crate rusty-release 0.6.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rusty-release/0.6.1 [INFO] validating manifest of rusty-release-0.6.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rusty-release-0.6.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rusty-release-0.6.1 [INFO] finished frobbing rusty-release-0.6.1 [INFO] frobbed toml for rusty-release-0.6.1 written to work/ex/clippy-test-run/sources/stable/reg/rusty-release/0.6.1/Cargo.toml [INFO] started frobbing rusty-release-0.6.1 [INFO] finished frobbing rusty-release-0.6.1 [INFO] frobbed toml for rusty-release-0.6.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rusty-release/0.6.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rusty-release-0.6.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rusty-release/0.6.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] aa88341a8c02fecfc27016ce826897625422f66194b55f793845542e4da1b530 [INFO] running `"docker" "start" "-a" "aa88341a8c02fecfc27016ce826897625422f66194b55f793845542e4da1b530"` [INFO] [stderr] Checking rusty-release v0.6.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cargo_proj.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | version: version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cargo_proj.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | cargo_toml: cargo_toml, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cargo_toml` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cargo_proj.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | changelog: changelog [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `changelog` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cargo_proj.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | version: version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cargo_proj.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | cargo_toml: cargo_toml, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cargo_toml` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cargo_proj.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | changelog: changelog [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `changelog` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/cargo_proj.rs:111:13 [INFO] [stderr] | [INFO] [stderr] 111 | files [INFO] [stderr] | ^^^^^ [INFO] [stderr] ... [INFO] [stderr] 122 | for file in read_files!(&dir) { [INFO] [stderr] | ----------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/cargo_proj.rs:104:25 [INFO] [stderr] | [INFO] [stderr] 104 | let files = dir_entries.filter_map(|f| { [INFO] [stderr] | _________________________^ [INFO] [stderr] 105 | | match f { [INFO] [stderr] 106 | | Ok(f) => { let p = f.path(); if p.is_file() { Some(p) } else { None } }, [INFO] [stderr] 107 | | _ => None [INFO] [stderr] 108 | | } [INFO] [stderr] 109 | | }); [INFO] [stderr] | |______________^ [INFO] [stderr] ... [INFO] [stderr] 122 | for file in read_files!(&dir) { [INFO] [stderr] | ----------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/cargo_proj.rs:111:13 [INFO] [stderr] | [INFO] [stderr] 111 | files [INFO] [stderr] | ^^^^^ [INFO] [stderr] ... [INFO] [stderr] 136 | for file in read_files!(dir) { [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/cargo_proj.rs:104:25 [INFO] [stderr] | [INFO] [stderr] 104 | let files = dir_entries.filter_map(|f| { [INFO] [stderr] | _________________________^ [INFO] [stderr] 105 | | match f { [INFO] [stderr] 106 | | Ok(f) => { let p = f.path(); if p.is_file() { Some(p) } else { None } }, [INFO] [stderr] 107 | | _ => None [INFO] [stderr] 108 | | } [INFO] [stderr] 109 | | }); [INFO] [stderr] | |______________^ [INFO] [stderr] ... [INFO] [stderr] 136 | for file in read_files!(dir) { [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/config.rs:204:29 [INFO] [stderr] | [INFO] [stderr] 204 | if let Some(path) = env::home_dir().map(|d| d.join(config_file_name())) { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/cargo_proj.rs:111:13 [INFO] [stderr] | [INFO] [stderr] 111 | files [INFO] [stderr] | ^^^^^ [INFO] [stderr] ... [INFO] [stderr] 122 | for file in read_files!(&dir) { [INFO] [stderr] | ----------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/cargo_proj.rs:104:25 [INFO] [stderr] | [INFO] [stderr] 104 | let files = dir_entries.filter_map(|f| { [INFO] [stderr] | _________________________^ [INFO] [stderr] 105 | | match f { [INFO] [stderr] 106 | | Ok(f) => { let p = f.path(); if p.is_file() { Some(p) } else { None } }, [INFO] [stderr] 107 | | _ => None [INFO] [stderr] 108 | | } [INFO] [stderr] 109 | | }); [INFO] [stderr] | |______________^ [INFO] [stderr] ... [INFO] [stderr] 122 | for file in read_files!(&dir) { [INFO] [stderr] | ----------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/cargo_proj.rs:111:13 [INFO] [stderr] | [INFO] [stderr] 111 | files [INFO] [stderr] | ^^^^^ [INFO] [stderr] ... [INFO] [stderr] 136 | for file in read_files!(dir) { [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/cargo_proj.rs:104:25 [INFO] [stderr] | [INFO] [stderr] 104 | let files = dir_entries.filter_map(|f| { [INFO] [stderr] | _________________________^ [INFO] [stderr] 105 | | match f { [INFO] [stderr] 106 | | Ok(f) => { let p = f.path(); if p.is_file() { Some(p) } else { None } }, [INFO] [stderr] 107 | | _ => None [INFO] [stderr] 108 | | } [INFO] [stderr] 109 | | }); [INFO] [stderr] | |______________^ [INFO] [stderr] ... [INFO] [stderr] 136 | for file in read_files!(dir) { [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/config.rs:204:29 [INFO] [stderr] | [INFO] [stderr] 204 | if let Some(path) = env::home_dir().map(|d| d.join(config_file_name())) { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/config.rs:224:58 [INFO] [stderr] | [INFO] [stderr] 224 | commit_message: self.commit_message.as_ref().or(other.commit_message.as_ref()).cloned(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| other.commit_message.as_ref())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/config.rs:225:46 [INFO] [stderr] | [INFO] [stderr] 225 | tag_name: self.tag_name.as_ref().or(other.tag_name.as_ref()).cloned(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| other.tag_name.as_ref())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/config.rs:226:42 [INFO] [stderr] | [INFO] [stderr] 226 | editor: self.editor.as_ref().or(other.editor.as_ref()).cloned() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| other.editor.as_ref())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/cargo_proj.rs:35:14 [INFO] [stderr] | [INFO] [stderr] 35 | .ok_or(format!("Couldn't get 'package' table from: {:?}", toml))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("Couldn't get 'package' table from: {:?}", toml))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/cargo_proj.rs:39:14 [INFO] [stderr] | [INFO] [stderr] 39 | .ok_or(format!("Couldn't get 'name' string from: {:?}", package))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("Couldn't get 'name' string from: {:?}", package))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/cargo_proj.rs:44:18 [INFO] [stderr] | [INFO] [stderr] 44 | .ok_or(format!("Couldn't get 'version' string from: {:?}", package))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("Couldn't get 'version' string from: {:?}", package))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/cargo_proj.rs:86:14 [INFO] [stderr] | [INFO] [stderr] 86 | .ok_or(format!("Couldn't get directory of path: {:?}", self.cargo_toml).into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("Couldn't get directory of path: {:?}", self.cargo_toml).into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/config.rs:224:58 [INFO] [stderr] | [INFO] [stderr] 224 | commit_message: self.commit_message.as_ref().or(other.commit_message.as_ref()).cloned(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| other.commit_message.as_ref())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/config.rs:225:46 [INFO] [stderr] | [INFO] [stderr] 225 | tag_name: self.tag_name.as_ref().or(other.tag_name.as_ref()).cloned(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| other.tag_name.as_ref())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/config.rs:226:42 [INFO] [stderr] | [INFO] [stderr] 226 | editor: self.editor.as_ref().or(other.editor.as_ref()).cloned() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| other.editor.as_ref())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/cargo_proj.rs:35:14 [INFO] [stderr] | [INFO] [stderr] 35 | .ok_or(format!("Couldn't get 'package' table from: {:?}", toml))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("Couldn't get 'package' table from: {:?}", toml))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/cargo_proj.rs:39:14 [INFO] [stderr] | [INFO] [stderr] 39 | .ok_or(format!("Couldn't get 'name' string from: {:?}", package))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("Couldn't get 'name' string from: {:?}", package))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/cargo_proj.rs:44:18 [INFO] [stderr] | [INFO] [stderr] 44 | .ok_or(format!("Couldn't get 'version' string from: {:?}", package))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("Couldn't get 'version' string from: {:?}", package))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/cargo_proj.rs:86:14 [INFO] [stderr] | [INFO] [stderr] 86 | .ok_or(format!("Couldn't get directory of path: {:?}", self.cargo_toml).into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("Couldn't get directory of path: {:?}", self.cargo_toml).into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.84s [INFO] running `"docker" "inspect" "aa88341a8c02fecfc27016ce826897625422f66194b55f793845542e4da1b530"` [INFO] running `"docker" "rm" "-f" "aa88341a8c02fecfc27016ce826897625422f66194b55f793845542e4da1b530"` [INFO] [stdout] aa88341a8c02fecfc27016ce826897625422f66194b55f793845542e4da1b530