[INFO] crate rusty-leveldb 0.2.4 is already in cache [INFO] extracting crate rusty-leveldb 0.2.4 into work/ex/clippy-test-run/sources/stable/reg/rusty-leveldb/0.2.4 [INFO] extracting crate rusty-leveldb 0.2.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rusty-leveldb/0.2.4 [INFO] validating manifest of rusty-leveldb-0.2.4 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rusty-leveldb-0.2.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rusty-leveldb-0.2.4 [INFO] finished frobbing rusty-leveldb-0.2.4 [INFO] frobbed toml for rusty-leveldb-0.2.4 written to work/ex/clippy-test-run/sources/stable/reg/rusty-leveldb/0.2.4/Cargo.toml [INFO] started frobbing rusty-leveldb-0.2.4 [INFO] finished frobbing rusty-leveldb-0.2.4 [INFO] frobbed toml for rusty-leveldb-0.2.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rusty-leveldb/0.2.4/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rusty-leveldb-0.2.4 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rusty-leveldb/0.2.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9f9330f8b569e86160b03ed1c4c814ffa5ec8bb6b4694f882eb286bd9856dc9d [INFO] running `"docker" "start" "-a" "9f9330f8b569e86160b03ed1c4c814ffa5ec8bb6b4694f882eb286bd9856dc9d"` [INFO] [stderr] Checking integer-encoding v1.0.5 [INFO] [stderr] Checking time-test v0.2.1 [INFO] [stderr] Checking rusty-leveldb v0.2.4 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/block.rs:70:13 [INFO] [stderr] | [INFO] [stderr] 70 | opt: opt, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `opt` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/block_builder.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | restarts: restarts, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `restarts` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockhandle.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | offset: offset, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockhandle.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | code: code, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `code` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error.rs:68:13 [INFO] [stderr] | [INFO] [stderr] 68 | err: err, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/filter.rs:83:13 [INFO] [stderr] | [INFO] [stderr] 83 | bits_per_key: bits_per_key, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bits_per_key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/filter.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | k: k, [INFO] [stderr] | ^^^^ help: replace it with: `k` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/key_types.rs:68:13 [INFO] [stderr] | [INFO] [stderr] 68 | key: key, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/block.rs:70:13 [INFO] [stderr] | [INFO] [stderr] 70 | opt: opt, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `opt` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/block_builder.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | restarts: restarts, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `restarts` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockhandle.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | offset: offset, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockhandle.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | code: code, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `code` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error.rs:68:13 [INFO] [stderr] | [INFO] [stderr] 68 | err: err, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/filter.rs:83:13 [INFO] [stderr] | [INFO] [stderr] 83 | bits_per_key: bits_per_key, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bits_per_key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/filter.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | k: k, [INFO] [stderr] | ^^^^ help: replace it with: `k` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/key_types.rs:68:13 [INFO] [stderr] | [INFO] [stderr] 68 | key: key, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/log.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | digest: digest, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `digest` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/log.rs:132:13 [INFO] [stderr] | [INFO] [stderr] 132 | src: src, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `src` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/merging_iter.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | iters: iters, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `iters` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/merging_iter.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | cmp: cmp, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `cmp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/skipmap.rs:61:17 [INFO] [stderr] | [INFO] [stderr] 61 | cmp: cmp, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `cmp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/skipmap.rs:240:13 [INFO] [stderr] | [INFO] [stderr] 240 | key: key, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/snapshot.rs:72:17 [INFO] [stderr] | [INFO] [stderr] 72 | seq: seq, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `seq` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/table_builder.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | index: index, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/table_builder.rs:120:13 [INFO] [stderr] | [INFO] [stderr] 120 | dst: dst, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `dst` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/table_reader.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | file: file, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/table_reader.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | cache_id: cache_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `cache_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/table_reader.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | opt: opt, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `opt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/table_reader.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | footer: footer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `footer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/table_reader.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | indexblock: indexblock, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `indexblock` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/version.rs:391:9 [INFO] [stderr] | [INFO] [stderr] 391 | files: files, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `files` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/version.rs:392:9 [INFO] [stderr] | [INFO] [stderr] 392 | cache: cache, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `cache` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/version.rs:593:13 [INFO] [stderr] | [INFO] [stderr] 593 | num: num, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `num` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/version_edit.rs:121:13 [INFO] [stderr] | [INFO] [stderr] 121 | level: level, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `level` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/log.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | digest: digest, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `digest` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/version_edit.rs:241:33 [INFO] [stderr] | [INFO] [stderr] 241 | key: key, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/log.rs:132:13 [INFO] [stderr] | [INFO] [stderr] 132 | src: src, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `src` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/version_edit.rs:269:45 [INFO] [stderr] | [INFO] [stderr] 269 | num: num, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `num` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/version_edit.rs:270:45 [INFO] [stderr] | [INFO] [stderr] 270 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/version_edit.rs:271:45 [INFO] [stderr] | [INFO] [stderr] 271 | smallest: smallest, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `smallest` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/version_edit.rs:272:45 [INFO] [stderr] | [INFO] [stderr] 272 | largest: largest, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `largest` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/version_set.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | level: level, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `level` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/version_set.rs:193:13 [INFO] [stderr] | [INFO] [stderr] 193 | opt: opt, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `opt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] [INFO] [stderr] --> src/merging_iter.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | iters: iters, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `iters` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/merging_iter.rs:33:13 [INFO] [stderr] --> src/version_set.rs:194:13 [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] 33 | cmp: cmp, [INFO] [stderr] 194 | cache: cache, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `cache` [INFO] [stderr] | ^^^^^^^^ help: replace it with: `cmp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/skipmap.rs:61:17 [INFO] [stderr] | [INFO] [stderr] 61 | cmp: cmp, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `cmp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/skipmap.rs:240:13 [INFO] [stderr] | [INFO] [stderr] 240 | key: key, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/snapshot.rs:72:17 [INFO] [stderr] | [INFO] [stderr] 72 | seq: seq, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `seq` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/table_builder.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | index: index, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/table_builder.rs:120:13 [INFO] [stderr] | [INFO] [stderr] 120 | dst: dst, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `dst` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/db_impl.rs:81:13 [INFO] [stderr] | [INFO] [stderr] 81 | opt: opt, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `opt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/table_reader.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | file: file, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/table_reader.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | cache_id: cache_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `cache_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/table_reader.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | opt: opt, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `opt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/table_reader.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | footer: footer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `footer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/table_reader.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | indexblock: indexblock, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `indexblock` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/db_impl.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | cache: cache, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `cache` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/version.rs:391:9 [INFO] [stderr] | [INFO] [stderr] 391 | files: files, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `files` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/version.rs:392:9 [INFO] [stderr] | [INFO] [stderr] 392 | cache: cache, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `cache` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/version.rs:593:13 [INFO] [stderr] | [INFO] [stderr] 593 | num: num, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `num` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/version_edit.rs:121:13 [INFO] [stderr] | [INFO] [stderr] 121 | level: level, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `level` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/version_edit.rs:241:33 [INFO] [stderr] | [INFO] [stderr] 241 | key: key, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/version_edit.rs:269:45 [INFO] [stderr] | [INFO] [stderr] 269 | num: num, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `num` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/version_edit.rs:270:45 [INFO] [stderr] | [INFO] [stderr] 270 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/version_edit.rs:271:45 [INFO] [stderr] | [INFO] [stderr] 271 | smallest: smallest, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `smallest` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/version_edit.rs:272:45 [INFO] [stderr] | [INFO] [stderr] 272 | largest: largest, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `largest` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/db_iter.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | cmp: cmp, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `cmp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/version_set.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | level: level, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `level` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/db_iter.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | vset: vset, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `vset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/db_iter.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | iter: iter, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `iter` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/version_set.rs:193:13 [INFO] [stderr] | [INFO] [stderr] 193 | opt: opt, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `opt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/version_set.rs:194:13 [INFO] [stderr] | [INFO] [stderr] 194 | cache: cache, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `cache` [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/db_iter.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | ss: ss, [INFO] [stderr] | ^^^^^^ help: replace it with: `ss` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/db_impl.rs:81:13 [INFO] [stderr] | [INFO] [stderr] 81 | opt: opt, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `opt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/db_impl.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | cache: cache, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `cache` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/db_iter.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | cmp: cmp, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `cmp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/db_iter.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | vset: vset, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `vset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/db_iter.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | iter: iter, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/db_iter.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | ss: ss, [INFO] [stderr] | ^^^^^^ help: replace it with: `ss` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cache.rs:186:9 [INFO] [stderr] | [INFO] [stderr] 186 | return self.id; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cache.rs:191:9 [INFO] [stderr] | [INFO] [stderr] 191 | return self.list.count(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.list.count()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cache.rs:196:9 [INFO] [stderr] | [INFO] [stderr] 196 | return self.cap; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.cap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cmp.rs:88:9 [INFO] [stderr] | [INFO] [stderr] 88 | return sep; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `sep` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cmp.rs:102:9 [INFO] [stderr] | [INFO] [stderr] 102 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cmp.rs:134:9 [INFO] [stderr] | [INFO] [stderr] 134 | return LookupKey::new(&sep, seqa).internal_key().to_vec(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `LookupKey::new(&sep, seqa).internal_key().to_vec()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cmp.rs:140:9 [INFO] [stderr] | [INFO] [stderr] 140 | return LookupKey::new(&succ, seq).internal_key().to_vec(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `LookupKey::new(&succ, seq).internal_key().to_vec()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/disk_env.rs:159:13 [INFO] [stderr] | [INFO] [stderr] 159 | / return err( [INFO] [stderr] 160 | | StatusCode::LockError, [INFO] [stderr] 161 | | &format!("unlocking a file that is not locked: {}", l.id), [INFO] [stderr] 162 | | ); [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 159 | err( [INFO] [stderr] 160 | StatusCode::LockError, [INFO] [stderr] 161 | &format!("unlocking a file that is not locked: {}", l.id), [INFO] [stderr] 162 | ) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/env_common.rs:10:47 [INFO] [stderr] | [INFO] [stderr] 10 | Ok(dur) => return dur.as_secs() * 1000000 + (dur.subsec_nanos() / 1000) as u64, [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/error.rs:66:9 [INFO] [stderr] | [INFO] [stderr] 66 | / return Status { [INFO] [stderr] 67 | | code: code, [INFO] [stderr] 68 | | err: err, [INFO] [stderr] 69 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 66 | Status { [INFO] [stderr] 67 | code: code, [INFO] [stderr] 68 | err: err, [INFO] [stderr] 69 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/filter.rs:56:25 [INFO] [stderr] | [INFO] [stderr] 56 | const BLOOM_SEED: u32 = 0xbc9f1d34; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xbc9f_1d34` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/filter.rs:89:22 [INFO] [stderr] | [INFO] [stderr] 89 | let m: u32 = 0xc6a4a793; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xc6a4_a793` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/key_types.rs:148:9 [INFO] [stderr] | [INFO] [stderr] 148 | return (keylen - 8, keyoff, tag, vallen, valoff); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(keylen - 8, keyoff, tag, vallen, valoff)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/key_types.rs:150:9 [INFO] [stderr] | [INFO] [stderr] 150 | return (keylen - 8, keyoff, 0, 0, 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(keylen - 8, keyoff, 0, 0, 0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/key_types.rs:183:5 [INFO] [stderr] | [INFO] [stderr] 183 | return (typ, seq, &ikey[0..ikey.len() - 8]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(typ, seq, &ikey[0..ikey.len() - 8])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/log.rs:208:25 [INFO] [stderr] | [INFO] [stderr] 208 | const MASK_DELTA: u32 = 0xa282ead8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xa282_ead8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/memtable.rs:130:13 [INFO] [stderr] | [INFO] [stderr] 130 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/merging_iter.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | mi [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/merging_iter.rs:29:18 [INFO] [stderr] | [INFO] [stderr] 29 | let mi = MergingIter { [INFO] [stderr] | __________________^ [INFO] [stderr] 30 | | iters: iters, [INFO] [stderr] 31 | | current: None, [INFO] [stderr] 32 | | direction: Direction::Forward, [INFO] [stderr] 33 | | cmp: cmp, [INFO] [stderr] 34 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/merging_iter.rs:71:33 [INFO] [stderr] | [INFO] [stderr] 71 | / if self.iters[i].current(&mut keybuf, &mut valbuf) { [INFO] [stderr] 72 | | if self.cmp.cmp(&keybuf, &key) == Ordering::Equal { [INFO] [stderr] 73 | | self.iters[i].advance(); [INFO] [stderr] 74 | | } [INFO] [stderr] 75 | | } [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 71 | if self.iters[i].current(&mut keybuf, &mut valbuf) && self.cmp.cmp(&keybuf, &key) == Ordering::Equal { [INFO] [stderr] 72 | self.iters[i].advance(); [INFO] [stderr] 73 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/skipmap.rs:143:17 [INFO] [stderr] | [INFO] [stderr] 143 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/skipmap.rs:145:17 [INFO] [stderr] | [INFO] [stderr] 145 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/skipmap.rs:147:17 [INFO] [stderr] | [INFO] [stderr] 147 | return Some(&(*current)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(&(*current))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/skipmap.rs:182:17 [INFO] [stderr] | [INFO] [stderr] 182 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/skipmap.rs:184:17 [INFO] [stderr] | [INFO] [stderr] 184 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/skipmap.rs:186:17 [INFO] [stderr] | [INFO] [stderr] 186 | return Some(&(*current)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(&(*current))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/table_builder.rs:23:38 [INFO] [stderr] | [INFO] [stderr] 23 | pub const MAGIC_FOOTER_NUMBER: u64 = 0xdb4775248b80fb57; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xdb47_7524_8b80_fb57` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/table_reader.rs:155:9 [INFO] [stderr] | [INFO] [stderr] 155 | return self.footer.meta_index.offset(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.footer.meta_index.offset()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/table_reader.rs:166:9 [INFO] [stderr] | [INFO] [stderr] 166 | iter [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/table_reader.rs:160:20 [INFO] [stderr] | [INFO] [stderr] 160 | let iter = TableIterator { [INFO] [stderr] | ____________________^ [INFO] [stderr] 161 | | current_block: None, [INFO] [stderr] 162 | | current_block_off: 0, [INFO] [stderr] 163 | | index_block: self.indexblock.iter(), [INFO] [stderr] 164 | | table: self.clone(), [INFO] [stderr] 165 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/test_util.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | / return TestLdbIter { [INFO] [stderr] 16 | | v: c, [INFO] [stderr] 17 | | ix: 0, [INFO] [stderr] 18 | | init: false, [INFO] [stderr] 19 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 15 | TestLdbIter { [INFO] [stderr] 16 | v: c, [INFO] [stderr] 17 | ix: 0, [INFO] [stderr] 18 | init: false, [INFO] [stderr] 19 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/version.rs:191:9 [INFO] [stderr] | [INFO] [stderr] 191 | return level; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `level` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/version.rs:204:13 [INFO] [stderr] | [INFO] [stderr] 204 | / if !level.is_empty() { [INFO] [stderr] 205 | | if first_file.is_none() && first_file_level.is_none() { [INFO] [stderr] 206 | | first_file = Some(level[0].clone()); [INFO] [stderr] 207 | | first_file_level = Some(i); [INFO] [stderr] 208 | | } [INFO] [stderr] 209 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 204 | if !level.is_empty() && first_file.is_none() && first_file_level.is_none() { [INFO] [stderr] 205 | first_file = Some(level[0].clone()); [INFO] [stderr] 206 | first_file_level = Some(i); [INFO] [stderr] 207 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/version_set.rs:272:24 [INFO] [stderr] | [INFO] [stderr] 272 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 273 | | if let Ok(tbl) = self.cache.borrow_mut().get_table(f.borrow().num) { [INFO] [stderr] 274 | | offset += tbl.approx_offset_of(key); [INFO] [stderr] 275 | | } [INFO] [stderr] 276 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 272 | } else if let Ok(tbl) = self.cache.borrow_mut().get_table(f.borrow().num) { [INFO] [stderr] 273 | offset += tbl.approx_offset_of(key); [INFO] [stderr] 274 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/write_batch.rs:137:13 [INFO] [stderr] | [INFO] [stderr] 137 | return Some((k, Some(v))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some((k, Some(v)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/write_batch.rs:139:13 [INFO] [stderr] | [INFO] [stderr] 139 | return Some((k, None)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some((k, None))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/db_iter.rs:14:34 [INFO] [stderr] | [INFO] [stderr] 14 | const READ_BYTES_PERIOD: isize = 1048576; [INFO] [stderr] | ^^^^^^^ help: consider: `1_048_576` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cache.rs:186:9 [INFO] [stderr] | [INFO] [stderr] 186 | return self.id; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cache.rs:191:9 [INFO] [stderr] | [INFO] [stderr] 191 | return self.list.count(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.list.count()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cache.rs:196:9 [INFO] [stderr] | [INFO] [stderr] 196 | return self.cap; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.cap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cmp.rs:88:9 [INFO] [stderr] | [INFO] [stderr] 88 | return sep; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `sep` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cmp.rs:102:9 [INFO] [stderr] | [INFO] [stderr] 102 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cmp.rs:134:9 [INFO] [stderr] | [INFO] [stderr] 134 | return LookupKey::new(&sep, seqa).internal_key().to_vec(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `LookupKey::new(&sep, seqa).internal_key().to_vec()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cmp.rs:140:9 [INFO] [stderr] | [INFO] [stderr] 140 | return LookupKey::new(&succ, seq).internal_key().to_vec(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `LookupKey::new(&succ, seq).internal_key().to_vec()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/disk_env.rs:159:13 [INFO] [stderr] | [INFO] [stderr] 159 | / return err( [INFO] [stderr] 160 | | StatusCode::LockError, [INFO] [stderr] 161 | | &format!("unlocking a file that is not locked: {}", l.id), [INFO] [stderr] 162 | | ); [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 159 | err( [INFO] [stderr] 160 | StatusCode::LockError, [INFO] [stderr] 161 | &format!("unlocking a file that is not locked: {}", l.id), [INFO] [stderr] 162 | ) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/env_common.rs:10:47 [INFO] [stderr] | [INFO] [stderr] 10 | Ok(dur) => return dur.as_secs() * 1000000 + (dur.subsec_nanos() / 1000) as u64, [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/error.rs:66:9 [INFO] [stderr] | [INFO] [stderr] 66 | / return Status { [INFO] [stderr] 67 | | code: code, [INFO] [stderr] 68 | | err: err, [INFO] [stderr] 69 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 66 | Status { [INFO] [stderr] 67 | code: code, [INFO] [stderr] 68 | err: err, [INFO] [stderr] 69 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/filter.rs:56:25 [INFO] [stderr] | [INFO] [stderr] 56 | const BLOOM_SEED: u32 = 0xbc9f1d34; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xbc9f_1d34` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/filter.rs:89:22 [INFO] [stderr] | [INFO] [stderr] 89 | let m: u32 = 0xc6a4a793; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xc6a4_a793` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/filter.rs:283:9 [INFO] [stderr] | [INFO] [stderr] 283 | filter [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/filter.rs:281:22 [INFO] [stderr] | [INFO] [stderr] 281 | let filter = fpol.create_filter(&intdata, &intoffs); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/filter.rs:312:40 [INFO] [stderr] | [INFO] [stderr] 312 | assert_eq!(fp.bloom_hash(&d1), 0xef1345c4); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xef13_45c4` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/filter.rs:313:40 [INFO] [stderr] | [INFO] [stderr] 313 | assert_eq!(fp.bloom_hash(&d2), 0x5b663814); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x5b66_3814` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/filter.rs:314:40 [INFO] [stderr] | [INFO] [stderr] 314 | assert_eq!(fp.bloom_hash(&d3), 0x323c078f); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x323c_078f` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/filter.rs:315:40 [INFO] [stderr] | [INFO] [stderr] 315 | assert_eq!(fp.bloom_hash(&d4), 0xed21633a); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xed21_633a` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/key_types.rs:148:9 [INFO] [stderr] | [INFO] [stderr] 148 | return (keylen - 8, keyoff, tag, vallen, valoff); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(keylen - 8, keyoff, tag, vallen, valoff)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/key_types.rs:150:9 [INFO] [stderr] | [INFO] [stderr] 150 | return (keylen - 8, keyoff, 0, 0, 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(keylen - 8, keyoff, 0, 0, 0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/key_types.rs:183:5 [INFO] [stderr] | [INFO] [stderr] 183 | return (typ, seq, &ikey[0..ikey.len() - 8]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(typ, seq, &ikey[0..ikey.len() - 8])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/log.rs:208:25 [INFO] [stderr] | [INFO] [stderr] 208 | const MASK_DELTA: u32 = 0xa282ead8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xa282_ead8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/log.rs:233:20 [INFO] [stderr] | [INFO] [stderr] 233 | assert_eq!(0x8a9136aa, crc32::checksum_castagnoli(&[0 as u8; 32])); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x8a91_36aa` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/log.rs:234:20 [INFO] [stderr] | [INFO] [stderr] 234 | assert_eq!(0x62a8ab43, crc32::checksum_castagnoli(&[0xff as u8; 32])); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x62a8_ab43` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/memtable.rs:130:13 [INFO] [stderr] | [INFO] [stderr] 130 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/merging_iter.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | mi [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/merging_iter.rs:29:18 [INFO] [stderr] | [INFO] [stderr] 29 | let mi = MergingIter { [INFO] [stderr] | __________________^ [INFO] [stderr] 30 | | iters: iters, [INFO] [stderr] 31 | | current: None, [INFO] [stderr] 32 | | direction: Direction::Forward, [INFO] [stderr] 33 | | cmp: cmp, [INFO] [stderr] 34 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/merging_iter.rs:71:33 [INFO] [stderr] | [INFO] [stderr] 71 | / if self.iters[i].current(&mut keybuf, &mut valbuf) { [INFO] [stderr] 72 | | if self.cmp.cmp(&keybuf, &key) == Ordering::Equal { [INFO] [stderr] 73 | | self.iters[i].advance(); [INFO] [stderr] 74 | | } [INFO] [stderr] 75 | | } [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 71 | if self.iters[i].current(&mut keybuf, &mut valbuf) && self.cmp.cmp(&keybuf, &key) == Ordering::Equal { [INFO] [stderr] 72 | self.iters[i].advance(); [INFO] [stderr] 73 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/skipmap.rs:143:17 [INFO] [stderr] | [INFO] [stderr] 143 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/skipmap.rs:145:17 [INFO] [stderr] | [INFO] [stderr] 145 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/skipmap.rs:147:17 [INFO] [stderr] | [INFO] [stderr] 147 | return Some(&(*current)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(&(*current))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/skipmap.rs:182:17 [INFO] [stderr] | [INFO] [stderr] 182 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/skipmap.rs:184:17 [INFO] [stderr] | [INFO] [stderr] 184 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/skipmap.rs:186:17 [INFO] [stderr] | [INFO] [stderr] 186 | return Some(&(*current)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(&(*current))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/table_builder.rs:23:38 [INFO] [stderr] | [INFO] [stderr] 23 | pub const MAGIC_FOOTER_NUMBER: u64 = 0xdb4775248b80fb57; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xdb47_7524_8b80_fb57` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/table_cache.rs:103:36 [INFO] [stderr] | [INFO] [stderr] 103 | table_file_name("abc", 1234567) [INFO] [stderr] | ^^^^^^^ help: consider: `1_234_567` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/table_cache.rs:115:54 [INFO] [stderr] | [INFO] [stderr] 115 | assert_eq!(make_key(1, 2, 3), filenum_to_key(0x030201)); [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0003_0201` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/table_reader.rs:155:9 [INFO] [stderr] | [INFO] [stderr] 155 | return self.footer.meta_index.offset(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.footer.meta_index.offset()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/table_reader.rs:166:9 [INFO] [stderr] | [INFO] [stderr] 166 | iter [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/table_reader.rs:160:20 [INFO] [stderr] | [INFO] [stderr] 160 | let iter = TableIterator { [INFO] [stderr] | ____________________^ [INFO] [stderr] 161 | | current_block: None, [INFO] [stderr] 162 | | current_block_off: 0, [INFO] [stderr] 163 | | index_block: self.indexblock.iter(), [INFO] [stderr] 164 | | table: self.clone(), [INFO] [stderr] 165 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/test_util.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | / return TestLdbIter { [INFO] [stderr] 16 | | v: c, [INFO] [stderr] 17 | | ix: 0, [INFO] [stderr] 18 | | init: false, [INFO] [stderr] 19 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 15 | TestLdbIter { [INFO] [stderr] 16 | v: c, [INFO] [stderr] 17 | ix: 0, [INFO] [stderr] 18 | init: false, [INFO] [stderr] 19 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/version.rs:191:9 [INFO] [stderr] | [INFO] [stderr] 191 | return level; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `level` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/version.rs:204:13 [INFO] [stderr] | [INFO] [stderr] 204 | / if !level.is_empty() { [INFO] [stderr] 205 | | if first_file.is_none() && first_file_level.is_none() { [INFO] [stderr] 206 | | first_file = Some(level[0].clone()); [INFO] [stderr] 207 | | first_file_level = Some(i); [INFO] [stderr] 208 | | } [INFO] [stderr] 209 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 204 | if !level.is_empty() && first_file.is_none() && first_file_level.is_none() { [INFO] [stderr] 205 | first_file = Some(level[0].clone()); [INFO] [stderr] 206 | first_file_level = Some(i); [INFO] [stderr] 207 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/version.rs:592:19 [INFO] [stderr] | [INFO] [stderr] 592 | size: 163840, [INFO] [stderr] | ^^^^^^ help: consider: `163_840` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/version_set.rs:272:24 [INFO] [stderr] | [INFO] [stderr] 272 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 273 | | if let Ok(tbl) = self.cache.borrow_mut().get_table(f.borrow().num) { [INFO] [stderr] 274 | | offset += tbl.approx_offset_of(key); [INFO] [stderr] 275 | | } [INFO] [stderr] 276 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 272 | } else if let Ok(tbl) = self.cache.borrow_mut().get_table(f.borrow().num) { [INFO] [stderr] 273 | offset += tbl.approx_offset_of(key); [INFO] [stderr] 274 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/write_batch.rs:137:13 [INFO] [stderr] | [INFO] [stderr] 137 | return Some((k, Some(v))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some((k, Some(v)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/write_batch.rs:139:13 [INFO] [stderr] | [INFO] [stderr] 139 | return Some((k, None)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some((k, None))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/db_iter.rs:14:34 [INFO] [stderr] | [INFO] [stderr] 14 | const READ_BYTES_PERIOD: isize = 1048576; [INFO] [stderr] | ^^^^^^^ help: consider: `1_048_576` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/block_builder.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | / pub fn last_key<'a>(&'a self) -> &'a [u8] { [INFO] [stderr] 40 | | &self.last_key [INFO] [stderr] 41 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/cmp.rs:55:44 [INFO] [stderr] | [INFO] [stderr] 55 | let mut sep = Vec::from(&a[0..diff_at + 1]); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `0..=diff_at` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `disk_env::PosixDiskEnv` [INFO] [stderr] --> src/disk_env.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | / pub fn new() -> PosixDiskEnv { [INFO] [stderr] 29 | | PosixDiskEnv { [INFO] [stderr] 30 | | locks: Arc::new(Mutex::new(HashMap::new())), [INFO] [stderr] 31 | | } [INFO] [stderr] 32 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 23 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/disk_env.rs:85:20 [INFO] [stderr] | [INFO] [stderr] 85 | if !r.is_ok() { [INFO] [stderr] | ^^^^^^^^^^ help: try: `r.is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/disk_env.rs:101:12 [INFO] [stderr] | [INFO] [stderr] 101 | Ok(fs::remove_file(p).map_err(|e| map_err_with_name("delete", p, e))?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 101 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/disk_env.rs:104:12 [INFO] [stderr] | [INFO] [stderr] 104 | Ok(fs::create_dir(p).map_err(|e| map_err_with_name("mkdir", p, e))?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 104 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/disk_env.rs:107:12 [INFO] [stderr] | [INFO] [stderr] 107 | Ok(fs::remove_dir_all(p).map_err(|e| map_err_with_name("rmdir", p, e))?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 107 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/disk_env.rs:110:12 [INFO] [stderr] | [INFO] [stderr] 110 | Ok(fs::rename(old, new).map_err(|e| map_err_with_name("rename", old, e))?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 110 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/disk_env.rs:137:21 [INFO] [stderr] | [INFO] [stderr] 137 | mem::transmute::<&libc::flock, *const libc::flock>(&&flock_arg), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&&flock_arg as *const &libc::flock as *const libc::flock` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_transmute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/disk_env.rs:176:21 [INFO] [stderr] | [INFO] [stderr] 176 | mem::transmute::<&libc::flock, *const libc::flock>(&&flock_arg), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&&flock_arg as *const &libc::flock as *const libc::flock` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/env.rs:58:36 [INFO] [stderr] | [INFO] [stderr] 58 | pub fn log(&mut self, message: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/env_common.rs:10:57 [INFO] [stderr] | [INFO] [stderr] 10 | Ok(dur) => return dur.as_secs() * 1000000 + (dur.subsec_nanos() / 1000) as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(dur.subsec_nanos() / 1000)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: Calling `subsec_micros()` is more concise than this calculation [INFO] [stderr] --> src/env_common.rs:10:57 [INFO] [stderr] | [INFO] [stderr] 10 | Ok(dur) => return dur.as_secs() * 1000000 + (dur.subsec_nanos() / 1000) as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `dur.subsec_micros()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::duration_subsec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duration_subsec [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/filter.rs:95:55 [INFO] [stderr] | [INFO] [stderr] 95 | let mut h: u32 = BLOOM_SEED ^ (limit as u64 * m as u64) as u32; [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(m)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/filter.rs:101:18 [INFO] [stderr] | [INFO] [stderr] 101 | h = (h as u64 + w as u64) as u32; [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/filter.rs:101:29 [INFO] [stderr] | [INFO] [stderr] 101 | h = (h as u64 + w as u64) as u32; [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(w)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/filter.rs:102:18 [INFO] [stderr] | [INFO] [stderr] 102 | h = (h as u64 * m as u64) as u32; [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/filter.rs:102:29 [INFO] [stderr] | [INFO] [stderr] 102 | h = (h as u64 * m as u64) as u32; [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(m)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the variable `i` is used as a loop counter. Consider using `for (i, item) in data[ix..].iter().enumerate()` or similar iterators [INFO] [stderr] --> src/filter.rs:112:22 [INFO] [stderr] | [INFO] [stderr] 112 | for b in data[ix..].iter() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/filter.rs:113:39 [INFO] [stderr] | [INFO] [stderr] 113 | h = h.overflowing_add((*b as u32) << (8 * i)).0; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(*b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/filter.rs:117:18 [INFO] [stderr] | [INFO] [stderr] 117 | h = (h as u64 * m as u64) as u32; [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/filter.rs:117:29 [INFO] [stderr] | [INFO] [stderr] 117 | h = (h as u64 * m as u64) as u32; [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(m)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/filter.rs:152:22 [INFO] [stderr] | [INFO] [stderr] 152 | h = (h as u64 + delta as u64) as u32; [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/filter.rs:152:33 [INFO] [stderr] | [INFO] [stderr] 152 | h = (h as u64 + delta as u64) as u32; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(delta)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/filter.rs:159:12 [INFO] [stderr] | [INFO] [stderr] 159 | if filter.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `filter.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/filter.rs:178:18 [INFO] [stderr] | [INFO] [stderr] 178 | h = (h as u64 + delta as u64) as u32; [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/filter.rs:178:29 [INFO] [stderr] | [INFO] [stderr] 178 | h = (h as u64 + delta as u64) as u32; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(delta)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/filter_block.rs:126:21 [INFO] [stderr] | [INFO] [stderr] 126 | let fbase = data[data.len() - 1] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(data[data.len() - 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/key_types.rs:47:5 [INFO] [stderr] | [INFO] [stderr] 47 | / pub fn new<'a>(k: UserKey<'a>, s: SequenceNumber) -> LookupKey { [INFO] [stderr] 48 | | LookupKey::new_full(k, s, ValueType::TypeValue) [INFO] [stderr] 49 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/key_types.rs:51:5 [INFO] [stderr] | [INFO] [stderr] 51 | / pub fn new_full<'a>(k: UserKey<'a>, s: SequenceNumber, t: ValueType) -> LookupKey { [INFO] [stderr] 52 | | let mut key = Vec::new(); [INFO] [stderr] 53 | | let internal_keylen = k.len() + U64_SPACE; [INFO] [stderr] 54 | | key.resize(k.len() + internal_keylen.required_space() + U64_SPACE, 0); [INFO] [stderr] ... | [INFO] [stderr] 70 | | } [INFO] [stderr] 71 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/key_types.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | writer.write(k).expect("write to slice failed"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/key_types.rs:74:5 [INFO] [stderr] | [INFO] [stderr] 74 | / pub fn memtable_key<'a>(&'a self) -> MemtableKey<'a> { [INFO] [stderr] 75 | | self.key.as_slice() [INFO] [stderr] 76 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/key_types.rs:79:5 [INFO] [stderr] | [INFO] [stderr] 79 | / pub fn user_key<'a>(&'a self) -> UserKey<'a> { [INFO] [stderr] 80 | | &self.key[self.key_offset..self.key.len() - 8] [INFO] [stderr] 81 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/key_types.rs:84:5 [INFO] [stderr] | [INFO] [stderr] 84 | / pub fn internal_key<'a>(&'a self) -> InternalKey<'a> { [INFO] [stderr] 85 | | &self.key[self.key_offset..] [INFO] [stderr] 86 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/key_types.rs:123:9 [INFO] [stderr] | [INFO] [stderr] 123 | writer.write(key).expect("write to slice failed"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/key_types.rs:128:9 [INFO] [stderr] | [INFO] [stderr] 128 | writer.write(value).expect("write to slice failed"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/key_types.rs:137:1 [INFO] [stderr] | [INFO] [stderr] 137 | / pub fn parse_memtable_key<'a>(mkey: MemtableKey<'a>) -> (usize, usize, u64, usize, usize) { [INFO] [stderr] 138 | | let (keylen, mut i): (usize, usize) = VarInt::decode_var(&mkey); [INFO] [stderr] 139 | | let keyoff = i; [INFO] [stderr] 140 | | i += keylen - 8; [INFO] [stderr] ... | [INFO] [stderr] 151 | | } [INFO] [stderr] 152 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/key_types.rs:177:1 [INFO] [stderr] | [INFO] [stderr] 177 | / pub fn parse_internal_key<'a>(ikey: InternalKey<'a>) -> (ValueType, SequenceNumber, UserKey<'a>) { [INFO] [stderr] 178 | | if ikey.is_empty() { [INFO] [stderr] 179 | | return (ValueType::TypeDeletion, 0, &ikey[0..0]); [INFO] [stderr] 180 | | } [INFO] [stderr] ... | [INFO] [stderr] 183 | | return (typ, seq, &ikey[0..ikey.len() - 8]); [INFO] [stderr] 184 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/log.rs:56:33 [INFO] [stderr] | [INFO] [stderr] 56 | while result.is_ok() && record.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!record.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/log.rs:63:17 [INFO] [stderr] | [INFO] [stderr] 63 | try!(self.dst.write(&vec![0, 0, 0, 0, 0, 0][0..space_left])); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/log.rs:153:17 [INFO] [stderr] | [INFO] [stderr] 153 | / try!( [INFO] [stderr] 154 | | self.src [INFO] [stderr] 155 | | .read(&mut self.head_scratch[0..self.blocksize - self.blk_off]) [INFO] [stderr] 156 | | ); [INFO] [stderr] | |__________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/log.rs:192:55 [INFO] [stderr] | [INFO] [stderr] 192 | } else if typ == RecordType::Middle as u8 { [INFO] [stderr] | _______________________________________________________^ [INFO] [stderr] 193 | | continue; [INFO] [stderr] 194 | | } else if typ == RecordType::Last as u8 { [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/log.rs:190:54 [INFO] [stderr] | [INFO] [stderr] 190 | } else if typ == RecordType::First as u8 { [INFO] [stderr] | ______________________________________________________^ [INFO] [stderr] 191 | | continue; [INFO] [stderr] 192 | | } else if typ == RecordType::Middle as u8 { [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/mem_env.rs:175:30 [INFO] [stderr] | [INFO] [stderr] 175 | if !prefix.ends_with("/") { [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `mem_env::MemEnv` [INFO] [stderr] --> src/mem_env.rs:278:5 [INFO] [stderr] | [INFO] [stderr] 278 | / pub fn new() -> MemEnv { [INFO] [stderr] 279 | | MemEnv(MemFS::new()) [INFO] [stderr] 280 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 277 | impl Default for mem_env::MemEnv { [INFO] [stderr] 278 | fn default() -> Self { [INFO] [stderr] 279 | Self::new() [INFO] [stderr] 280 | } [INFO] [stderr] 281 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/merging_iter.rs:112:9 [INFO] [stderr] | [INFO] [stderr] 112 | / let ord; [INFO] [stderr] 113 | | [INFO] [stderr] 114 | | if direction == SL::Smallest { [INFO] [stderr] 115 | | ord = Ordering::Less; [INFO] [stderr] 116 | | } else { [INFO] [stderr] 117 | | ord = Ordering::Greater; [INFO] [stderr] 118 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let ord = if direction == SL::Smallest { Ordering::Less } else { Ordering::Greater };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/merging_iter.rs:107:12 [INFO] [stderr] | [INFO] [stderr] 107 | if self.iters.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.iters.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/skipmap.rs:144:76 [INFO] [stderr] | [INFO] [stderr] 144 | } else if self.cmp.cmp(&(*current).key, key) == Ordering::Less { [INFO] [stderr] | ____________________________________________________________________________^ [INFO] [stderr] 145 | | return None; [INFO] [stderr] 146 | | } else { [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/skipmap.rs:142:67 [INFO] [stderr] | [INFO] [stderr] 142 | if current.is_null() || current == self.head.as_ref() { [INFO] [stderr] | ___________________________________________________________________^ [INFO] [stderr] 143 | | return None; [INFO] [stderr] 144 | | } else if self.cmp.cmp(&(*current).key, key) == Ordering::Less { [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/skipmap.rs:164:21 [INFO] [stderr] | [INFO] [stderr] 164 | / match ord { [INFO] [stderr] 165 | | Ordering::Less => { [INFO] [stderr] 166 | | current = next; [INFO] [stderr] 167 | | continue; [INFO] [stderr] 168 | | } [INFO] [stderr] 169 | | _ => (), [INFO] [stderr] 170 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 164 | if let Ordering::Less = ord { [INFO] [stderr] 165 | current = next; [INFO] [stderr] 166 | continue; [INFO] [stderr] 167 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/skipmap.rs:183:76 [INFO] [stderr] | [INFO] [stderr] 183 | } else if self.cmp.cmp(&(*current).key, key) != Ordering::Less { [INFO] [stderr] | ____________________________________________________________________________^ [INFO] [stderr] 184 | | return None; [INFO] [stderr] 185 | | } else { [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/skipmap.rs:180:67 [INFO] [stderr] | [INFO] [stderr] 180 | if current.is_null() || current == self.head.as_ref() { [INFO] [stderr] | ___________________________________________________________________^ [INFO] [stderr] 181 | | // If we're past the end for some reason or at the head [INFO] [stderr] 182 | | return None; [INFO] [stderr] 183 | | } else if self.cmp.cmp(&(*current).key, key) != Ordering::Less { [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `prevs`. [INFO] [stderr] --> src/skipmap.rs:202:18 [INFO] [stderr] | [INFO] [stderr] 202 | for i in 0..prevs.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 202 | for in &mut prevs { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `prevs` [INFO] [stderr] --> src/skipmap.rs:245:18 [INFO] [stderr] | [INFO] [stderr] 245 | for i in 0..new_height { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 245 | for (i, ) in prevs.iter().enumerate().take(new_height) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/skipmap.rs:277:37 [INFO] [stderr] | [INFO] [stderr] 277 | if let Some(next) = (*current).skips[0].clone() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `(*current).skips[0]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/table_block.rs:70:58 [INFO] [stderr] | [INFO] [stderr] 70 | if let Some(ctype) = options::int_to_compressiontype(compress[0] as u32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(compress[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `to`. [INFO] [stderr] --> src/table_builder.rs:66:18 [INFO] [stderr] | [INFO] [stderr] 66 | for i in s1 + s2..FOOTER_LENGTH { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 66 | for in to.iter_mut().take(FOOTER_LENGTH).skip(s1 + s2) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/table_builder.rs:69:18 [INFO] [stderr] | [INFO] [stderr] 69 | for i in FOOTER_LENGTH..FULL_FOOTER_LENGTH { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try replacing the loop by: `to[FOOTER_LENGTH..FULL_FOOTER_LENGTH].clone_from_slice(&MAGIC_FOOTER_ENCODED[0..(FULL_FOOTER_LENGTH - FOOTER_LENGTH)])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/table_builder.rs:214:9 [INFO] [stderr] | [INFO] [stderr] 214 | self.dst.write(&data)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/table_builder.rs:215:9 [INFO] [stderr] | [INFO] [stderr] 215 | self.dst.write(&[ctype as u8; TABLE_BLOCK_COMPRESS_LEN])?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 26 [INFO] [stderr] --> src/test_util.rs:92:1 [INFO] [stderr] | [INFO] [stderr] 92 | / pub fn test_iterator_properties(mut it: It) { [INFO] [stderr] 93 | | assert!(!it.valid()); [INFO] [stderr] 94 | | assert!(it.advance()); [INFO] [stderr] 95 | | assert!(it.valid()); [INFO] [stderr] ... | [INFO] [stderr] 130 | | assert!(!it.valid()); [INFO] [stderr] 131 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the loop variable `level` is used to index `levels` [INFO] [stderr] --> src/version.rs:70:22 [INFO] [stderr] | [INFO] [stderr] 70 | for level in 0..levels.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 70 | for (level, ) in levels.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `level` is used to index `levels` [INFO] [stderr] --> src/version.rs:127:22 [INFO] [stderr] | [INFO] [stderr] 127 | for level in 1..NUM_LEVELS { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 127 | for (level, ) in levels.iter_mut().enumerate().take(NUM_LEVELS).skip(1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the variable `i` is used as a loop counter. Consider using `for (i, item) in &levels.enumerate()` or similar iterators [INFO] [stderr] --> src/version.rs:203:22 [INFO] [stderr] | [INFO] [stderr] 203 | for level in &levels { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/version.rs:258:33 [INFO] [stderr] | [INFO] [stderr] 258 | pub fn overlap_in_level<'a, 'b>( [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/version.rs:313:14 [INFO] [stderr] | [INFO] [stderr] 313 | ) -> (Option<(Vec, Vec)>, Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/version.rs:326:17 [INFO] [stderr] | [INFO] [stderr] 326 | / { [INFO] [stderr] 327 | | continue; [INFO] [stderr] 328 | | } else { [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/version.rs:322:99 [INFO] [stderr] | [INFO] [stderr] 322 | if !ubegin.is_empty() && myself.user_cmp.cmp(flargest, &ubegin) == Ordering::Less { [INFO] [stderr] | ___________________________________________________________________________________________________^ [INFO] [stderr] 323 | | continue; [INFO] [stderr] 324 | | } else if !uend.is_empty() [INFO] [stderr] | |_________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `version_edit::VersionEdit` [INFO] [stderr] --> src/version_edit.rs:74:5 [INFO] [stderr] | [INFO] [stderr] 74 | / pub fn new() -> VersionEdit { [INFO] [stderr] 75 | | VersionEdit { [INFO] [stderr] 76 | | comparator: None, [INFO] [stderr] 77 | | log_number: None, [INFO] [stderr] ... | [INFO] [stderr] 84 | | } [INFO] [stderr] 85 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 61 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/version_edit.rs:135:13 [INFO] [stderr] | [INFO] [stderr] 135 | buf.write(cmp.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/version_edit.rs:162:13 [INFO] [stderr] | [INFO] [stderr] 162 | buf.write(cptr.key.as_ref()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/version_edit.rs:178:13 [INFO] [stderr] | [INFO] [stderr] 178 | buf.write(nf.1.smallest.as_ref()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/version_edit.rs:180:13 [INFO] [stderr] | [INFO] [stderr] 180 | buf.write(nf.1.largest.as_ref()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/version_set.rs:103:34 [INFO] [stderr] | [INFO] [stderr] 103 | pub fn is_base_level_for<'a>(&mut self, k: UserKey<'a>) -> bool { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/version_set.rs:532:13 [INFO] [stderr] | [INFO] [stderr] 532 | / let score: f64; [INFO] [stderr] 533 | | if l == 0 { [INFO] [stderr] 534 | | score = v.files[l].len() as f64 / 4.0; [INFO] [stderr] 535 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 540 | | score = total_size(v.files[l].iter()) as f64 / max_bytes; [INFO] [stderr] 541 | | } [INFO] [stderr] | |_____________^ help: it is more idiomatic to write: `let score = if l == 0 { v.files[l].len() as f64 / 4.0 } else { ..; total_size(v.files[l].iter()) as f64 / max_bytes };` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/version_set.rs:860:31 [INFO] [stderr] | [INFO] [stderr] 860 | pub fn read_current_file(env: &Box, dbname: &Path) -> Result { [INFO] [stderr] | ^^^^^^^^^ help: try: `&Env` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/version_set.rs:874:10 [INFO] [stderr] | [INFO] [stderr] 874 | env: &Box, [INFO] [stderr] | ^^^^^^^^^ help: try: `&Env` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/version_set.rs:883:9 [INFO] [stderr] | [INFO] [stderr] 883 | f.write(manifest_base.as_os_str().as_bytes())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/version_set.rs:884:9 [INFO] [stderr] | [INFO] [stderr] 884 | f.write("\n".as_bytes())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/version_set.rs:890:20 [INFO] [stderr] | [INFO] [stderr] 890 | return Err(Status::from(e)); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider removing `Status::from()`: `e` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `write_batch::WriteBatch` [INFO] [stderr] --> src/write_batch.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | / pub fn new() -> WriteBatch { [INFO] [stderr] 23 | | let mut v = Vec::with_capacity(128); [INFO] [stderr] 24 | | v.resize(HEADER_SIZE, 0); [INFO] [stderr] 25 | | [INFO] [stderr] 26 | | WriteBatch { entries: v } [INFO] [stderr] 27 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 17 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/write_batch.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | self.entries.write(&[ValueType::TypeValue as u8]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/write_batch.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | self.entries.write(k).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/write_batch.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | self.entries.write(v).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/write_batch.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | / self.entries [INFO] [stderr] 52 | | .write(&[ValueType::TypeDeletion as u8]) [INFO] [stderr] 53 | | .unwrap(); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/write_batch.rs:55:9 [INFO] [stderr] | [INFO] [stderr] 55 | self.entries.write(k).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/write_batch.rs:87:5 [INFO] [stderr] | [INFO] [stderr] 87 | / pub fn iter<'a>(&'a self) -> WriteBatchIter<'a> { [INFO] [stderr] 88 | | WriteBatchIter { [INFO] [stderr] 89 | | batch: self, [INFO] [stderr] 90 | | ix: HEADER_SIZE, [INFO] [stderr] 91 | | } [INFO] [stderr] 92 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/write_batch.rs:98:65 [INFO] [stderr] | [INFO] [stderr] 98 | None => mt.add(seq, ValueType::TypeDeletion, k, "".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b""` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/db_impl.rs:257:47 [INFO] [stderr] | [INFO] [stderr] 257 | let last_seq = batch.sequence() + batch.count() as u64 - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(batch.count())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/db_impl.rs:387:23 [INFO] [stderr] | [INFO] [stderr] 387 | let entries = batch.count() as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(batch.count())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/db_impl.rs:551:39 [INFO] [stderr] | [INFO] [stderr] 551 | } else if self.mem.len() == 0 { [INFO] [stderr] | _______________________________________^ [INFO] [stderr] 552 | | Ok(()) [INFO] [stderr] 553 | | } else { [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/db_impl.rs:549:79 [INFO] [stderr] | [INFO] [stderr] 549 | if !force && self.mem.approx_mem_usage() < self.opt.write_buffer_size { [INFO] [stderr] | _______________________________________________________________________________^ [INFO] [stderr] 550 | | Ok(()) [INFO] [stderr] 551 | | } else if self.mem.len() == 0 { [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/db_impl.rs:615:18 [INFO] [stderr] | [INFO] [stderr] 615 | for l in 0..max_level + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: use: `0..=max_level` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/db_impl.rs:960:48 [INFO] [stderr] | [INFO] [stderr] 960 | fn cleanup>(&mut self, env: &Box, name: P) { [INFO] [stderr] | ^^^^^^^^^ help: try: `&Env` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/db_iter.rs:62:27 [INFO] [stderr] | [INFO] [stderr] 62 | fn record_read_sample<'a>(&mut self, len: usize) { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] error: aborting due to 23 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rusty-leveldb`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/block.rs:313:14 [INFO] [stderr] | [INFO] [stderr] 313 | ("key1".as_bytes(), "value1".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"key1"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/block.rs:313:33 [INFO] [stderr] | [INFO] [stderr] 313 | ("key1".as_bytes(), "value1".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"value1"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/block.rs:315:17 [INFO] [stderr] | [INFO] [stderr] 315 | "loooooooooooooooooooooooooooooooooongerkey1".as_bytes(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"loooooooooooooooooooooooooooooooooongerkey1"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/block.rs:316:17 [INFO] [stderr] | [INFO] [stderr] 316 | "shrtvl1".as_bytes(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"shrtvl1"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/block.rs:318:14 [INFO] [stderr] | [INFO] [stderr] 318 | ("medium length key 1".as_bytes(), "some value 2".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"medium length key 1"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/block.rs:318:48 [INFO] [stderr] | [INFO] [stderr] 318 | ("medium length key 1".as_bytes(), "some value 2".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"some value 2"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/block.rs:319:14 [INFO] [stderr] | [INFO] [stderr] 319 | ("prefix_key1".as_bytes(), "value".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"prefix_key1"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/block.rs:319:40 [INFO] [stderr] | [INFO] [stderr] 319 | ("prefix_key1".as_bytes(), "value".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"value"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/block.rs:320:14 [INFO] [stderr] | [INFO] [stderr] 320 | ("prefix_key2".as_bytes(), "value".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"prefix_key2"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/block.rs:320:40 [INFO] [stderr] | [INFO] [stderr] 320 | ("prefix_key2".as_bytes(), "value".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"value"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/block.rs:321:14 [INFO] [stderr] | [INFO] [stderr] 321 | ("prefix_key3".as_bytes(), "value".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"prefix_key3"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/block.rs:321:40 [INFO] [stderr] | [INFO] [stderr] 321 | ("prefix_key3".as_bytes(), "value".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"value"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/block.rs:397:19 [INFO] [stderr] | [INFO] [stderr] 397 | Some(("key1".as_bytes().to_vec(), "value1".as_bytes().to_vec())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"key1"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/block.rs:397:47 [INFO] [stderr] | [INFO] [stderr] 397 | Some(("key1".as_bytes().to_vec(), "value1".as_bytes().to_vec())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"value1"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/block.rs:406:19 [INFO] [stderr] | [INFO] [stderr] 406 | Some(("key1".as_bytes().to_vec(), "value1".as_bytes().to_vec())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"key1"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/block.rs:406:47 [INFO] [stderr] | [INFO] [stderr] 406 | Some(("key1".as_bytes().to_vec(), "value1".as_bytes().to_vec())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"value1"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/block.rs:420:17 [INFO] [stderr] | [INFO] [stderr] 420 | "prefix_key2".as_bytes().to_vec(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"prefix_key2"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/block.rs:421:17 [INFO] [stderr] | [INFO] [stderr] 421 | "value".as_bytes().to_vec() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"value"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/block.rs:442:21 [INFO] [stderr] | [INFO] [stderr] 442 | block.seek(&"prefix_key2".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"prefix_key2"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/block.rs:447:17 [INFO] [stderr] | [INFO] [stderr] 447 | "prefix_key2".as_bytes().to_vec(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"prefix_key2"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/block.rs:448:17 [INFO] [stderr] | [INFO] [stderr] 448 | "value".as_bytes().to_vec() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"value"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/block.rs:452:21 [INFO] [stderr] | [INFO] [stderr] 452 | block.seek(&"prefix_key0".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"prefix_key0"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/block.rs:457:17 [INFO] [stderr] | [INFO] [stderr] 457 | "prefix_key1".as_bytes().to_vec(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"prefix_key1"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/block.rs:458:17 [INFO] [stderr] | [INFO] [stderr] 458 | "value".as_bytes().to_vec() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"value"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/block.rs:462:21 [INFO] [stderr] | [INFO] [stderr] 462 | block.seek(&"key1".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"key1"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/block.rs:466:19 [INFO] [stderr] | [INFO] [stderr] 466 | Some(("key1".as_bytes().to_vec(), "value1".as_bytes().to_vec())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"key1"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/block.rs:466:47 [INFO] [stderr] | [INFO] [stderr] 466 | Some(("key1".as_bytes().to_vec(), "value1".as_bytes().to_vec())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"value1"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/block.rs:469:21 [INFO] [stderr] | [INFO] [stderr] 469 | block.seek(&"prefix_key3".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"prefix_key3"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/block.rs:474:17 [INFO] [stderr] | [INFO] [stderr] 474 | "prefix_key3".as_bytes().to_vec(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"prefix_key3"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/block.rs:475:17 [INFO] [stderr] | [INFO] [stderr] 475 | "value".as_bytes().to_vec() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"value"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/block.rs:479:21 [INFO] [stderr] | [INFO] [stderr] 479 | block.seek(&"prefix_key8".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"prefix_key8"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/block.rs:489:39 [INFO] [stderr] | [INFO] [stderr] 489 | for block_restart_interval in vec![2, 6, 10] { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: you can use a slice directly: `&[2, 6, 10]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/block.rs:508:21 [INFO] [stderr] | [INFO] [stderr] 508 | "prefix_key3".as_bytes().to_vec(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"prefix_key3"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/block.rs:509:21 [INFO] [stderr] | [INFO] [stderr] 509 | "value".as_bytes().to_vec() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"value"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/block_builder.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | / pub fn last_key<'a>(&'a self) -> &'a [u8] { [INFO] [stderr] 40 | | &self.last_key [INFO] [stderr] 41 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/block_builder.rs:129:14 [INFO] [stderr] | [INFO] [stderr] 129 | ("key1".as_bytes(), "value1".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"key1"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/block_builder.rs:129:33 [INFO] [stderr] | [INFO] [stderr] 129 | ("key1".as_bytes(), "value1".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"value1"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/block_builder.rs:131:17 [INFO] [stderr] | [INFO] [stderr] 131 | "loooooooooooooooooooooooooooooooooongerkey1".as_bytes(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"loooooooooooooooooooooooooooooooooongerkey1"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/block_builder.rs:132:17 [INFO] [stderr] | [INFO] [stderr] 132 | "shrtvl1".as_bytes(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"shrtvl1"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/block_builder.rs:134:14 [INFO] [stderr] | [INFO] [stderr] 134 | ("medium length key 1".as_bytes(), "some value 2".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"medium length key 1"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/block_builder.rs:134:48 [INFO] [stderr] | [INFO] [stderr] 134 | ("medium length key 1".as_bytes(), "some value 2".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"some value 2"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/block_builder.rs:135:14 [INFO] [stderr] | [INFO] [stderr] 135 | ("prefix_key1".as_bytes(), "value".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"prefix_key1"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/block_builder.rs:135:40 [INFO] [stderr] | [INFO] [stderr] 135 | ("prefix_key1".as_bytes(), "value".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"value"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/block_builder.rs:136:14 [INFO] [stderr] | [INFO] [stderr] 136 | ("prefix_key2".as_bytes(), "value".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"prefix_key2"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/block_builder.rs:136:40 [INFO] [stderr] | [INFO] [stderr] 136 | ("prefix_key2".as_bytes(), "value".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"value"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/block_builder.rs:137:14 [INFO] [stderr] | [INFO] [stderr] 137 | ("prefix_key3".as_bytes(), "value".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"prefix_key3"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/block_builder.rs:137:40 [INFO] [stderr] | [INFO] [stderr] 137 | ("prefix_key3".as_bytes(), "value".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"value"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/cache.rs:354:20 [INFO] [stderr] | [INFO] [stderr] 354 | assert_eq!(lru._testing_head_ref().map(|r| (*r)).unwrap(), 244); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `lru._testing_head_ref().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/cache.rs:358:20 [INFO] [stderr] | [INFO] [stderr] 358 | assert_eq!(lru._testing_head_ref().map(|r| (*r)).unwrap(), 56); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `lru._testing_head_ref().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/cache.rs:362:20 [INFO] [stderr] | [INFO] [stderr] 362 | assert_eq!(lru._testing_head_ref().map(|r| (*r)).unwrap(), 244); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `lru._testing_head_ref().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/cache.rs:366:20 [INFO] [stderr] | [INFO] [stderr] 366 | assert_eq!(lru._testing_head_ref().map(|r| (*r)).unwrap(), 22); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `lru._testing_head_ref().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `handles` [INFO] [stderr] --> src/cache.rs:389:18 [INFO] [stderr] | [INFO] [stderr] 389 | for i in 0..9 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 389 | for (i, ) in handles.iter().enumerate().take(9) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/cache.rs:391:24 [INFO] [stderr] | [INFO] [stderr] 391 | assert_eq!(lru._testing_head_ref().map(|x| *x), Some(i)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `lru._testing_head_ref().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/cache.rs:402:20 [INFO] [stderr] | [INFO] [stderr] 402 | assert_eq!(lru._testing_head_ref().map(|x| *x), Some(3)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `lru._testing_head_ref().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/cmp.rs:55:44 [INFO] [stderr] | [INFO] [stderr] 55 | let mut sep = Vec::from(&a[0..diff_at + 1]); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `0..=diff_at` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/cmp.rs:187:49 [INFO] [stderr] | [INFO] [stderr] 187 | assert_eq!(DefaultCmp.find_shortest_sep("abcd".as_bytes(), "abcf".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abcd"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/cmp.rs:187:68 [INFO] [stderr] | [INFO] [stderr] 187 | assert_eq!(DefaultCmp.find_shortest_sep("abcd".as_bytes(), "abcf".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abcf"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/cmp.rs:188:20 [INFO] [stderr] | [INFO] [stderr] 188 | "abce".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abce"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/cmp.rs:189:49 [INFO] [stderr] | [INFO] [stderr] 189 | assert_eq!(DefaultCmp.find_shortest_sep("abc".as_bytes(), "acd".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abc"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/cmp.rs:189:67 [INFO] [stderr] | [INFO] [stderr] 189 | assert_eq!(DefaultCmp.find_shortest_sep("abc".as_bytes(), "acd".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"acd"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/cmp.rs:190:20 [INFO] [stderr] | [INFO] [stderr] 190 | "abd".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abd"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/cmp.rs:191:49 [INFO] [stderr] | [INFO] [stderr] 191 | assert_eq!(DefaultCmp.find_shortest_sep("abcdefghi".as_bytes(), "abcffghi".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abcdefghi"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/cmp.rs:191:73 [INFO] [stderr] | [INFO] [stderr] 191 | assert_eq!(DefaultCmp.find_shortest_sep("abcdefghi".as_bytes(), "abcffghi".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abcffghi"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/cmp.rs:192:20 [INFO] [stderr] | [INFO] [stderr] 192 | "abce".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abce"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/cmp.rs:193:49 [INFO] [stderr] | [INFO] [stderr] 193 | assert_eq!(DefaultCmp.find_shortest_sep("a".as_bytes(), "a".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"a"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/cmp.rs:193:65 [INFO] [stderr] | [INFO] [stderr] 193 | assert_eq!(DefaultCmp.find_shortest_sep("a".as_bytes(), "a".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"a"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/cmp.rs:194:20 [INFO] [stderr] | [INFO] [stderr] 194 | "a".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"a"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/cmp.rs:195:49 [INFO] [stderr] | [INFO] [stderr] 195 | assert_eq!(DefaultCmp.find_shortest_sep("a".as_bytes(), "b".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"a"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/cmp.rs:195:65 [INFO] [stderr] | [INFO] [stderr] 195 | assert_eq!(DefaultCmp.find_shortest_sep("a".as_bytes(), "b".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"b"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/cmp.rs:197:49 [INFO] [stderr] | [INFO] [stderr] 197 | assert_eq!(DefaultCmp.find_shortest_sep("abc".as_bytes(), "zzz".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abc"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/cmp.rs:197:67 [INFO] [stderr] | [INFO] [stderr] 197 | assert_eq!(DefaultCmp.find_shortest_sep("abc".as_bytes(), "zzz".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"zzz"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/cmp.rs:198:20 [INFO] [stderr] | [INFO] [stderr] 198 | "b".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"b"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/cmp.rs:199:49 [INFO] [stderr] | [INFO] [stderr] 199 | assert_eq!(DefaultCmp.find_shortest_sep("yyy".as_bytes(), "z".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"yyy"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/cmp.rs:199:67 [INFO] [stderr] | [INFO] [stderr] 199 | assert_eq!(DefaultCmp.find_shortest_sep("yyy".as_bytes(), "z".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"z"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/cmp.rs:200:20 [INFO] [stderr] | [INFO] [stderr] 200 | "yyz".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"yyz"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/cmp.rs:201:49 [INFO] [stderr] | [INFO] [stderr] 201 | assert_eq!(DefaultCmp.find_shortest_sep("".as_bytes(), "".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b""` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/cmp.rs:201:64 [INFO] [stderr] | [INFO] [stderr] 201 | assert_eq!(DefaultCmp.find_shortest_sep("".as_bytes(), "".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b""` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/cmp.rs:202:20 [INFO] [stderr] | [INFO] [stderr] 202 | "".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b""` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/cmp.rs:207:47 [INFO] [stderr] | [INFO] [stderr] 207 | assert_eq!(DefaultCmp.find_short_succ("abcd".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abcd"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/cmp.rs:208:20 [INFO] [stderr] | [INFO] [stderr] 208 | "b".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"b"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/cmp.rs:209:47 [INFO] [stderr] | [INFO] [stderr] 209 | assert_eq!(DefaultCmp.find_short_succ("zzzz".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"zzzz"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/cmp.rs:210:20 [INFO] [stderr] | [INFO] [stderr] 210 | "{".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"{"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/cmp.rs:219:57 [INFO] [stderr] | [INFO] [stderr] 219 | assert_eq!(cmp.find_shortest_sep(LookupKey::new("abcd".as_bytes(), 1).internal_key(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abcd"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/cmp.rs:220:57 [INFO] [stderr] | [INFO] [stderr] 220 | LookupKey::new("abcf".as_bytes(), 2).internal_key()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abcf"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/cmp.rs:221:35 [INFO] [stderr] | [INFO] [stderr] 221 | LookupKey::new("abce".as_bytes(), 1).internal_key()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abce"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/cmp.rs:222:57 [INFO] [stderr] | [INFO] [stderr] 222 | assert_eq!(cmp.find_shortest_sep(LookupKey::new("abcd".as_bytes(), 1).internal_key(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abcd"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/cmp.rs:223:57 [INFO] [stderr] | [INFO] [stderr] 223 | LookupKey::new("abce".as_bytes(), 2).internal_key()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abce"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/cmp.rs:225:57 [INFO] [stderr] | [INFO] [stderr] 225 | assert_eq!(cmp.find_shortest_sep(LookupKey::new("abc".as_bytes(), 1).internal_key(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abc"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/cmp.rs:226:57 [INFO] [stderr] | [INFO] [stderr] 226 | LookupKey::new("zzz".as_bytes(), 2).internal_key()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"zzz"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/cmp.rs:227:35 [INFO] [stderr] | [INFO] [stderr] 227 | LookupKey::new("b".as_bytes(), types::MAX_SEQUENCE_NUMBER).internal_key()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"b"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/cmp.rs:228:57 [INFO] [stderr] | [INFO] [stderr] 228 | assert_eq!(cmp.find_shortest_sep(LookupKey::new("abc".as_bytes(), 1).internal_key(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abc"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/cmp.rs:229:57 [INFO] [stderr] | [INFO] [stderr] 229 | LookupKey::new("acd".as_bytes(), 2).internal_key()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"acd"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/cmp.rs:230:35 [INFO] [stderr] | [INFO] [stderr] 230 | LookupKey::new("abd".as_bytes(), 1).internal_key()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abd"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/cmp.rs:231:57 [INFO] [stderr] | [INFO] [stderr] 231 | assert_eq!(cmp.find_shortest_sep(LookupKey::new("abc".as_bytes(), 1).internal_key(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abc"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/cmp.rs:232:57 [INFO] [stderr] | [INFO] [stderr] 232 | LookupKey::new("abe".as_bytes(), 2).internal_key()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abe"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/cmp.rs:233:35 [INFO] [stderr] | [INFO] [stderr] 233 | LookupKey::new("abd".as_bytes(), 1).internal_key()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abd"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/cmp.rs:234:57 [INFO] [stderr] | [INFO] [stderr] 234 | assert_eq!(cmp.find_shortest_sep(LookupKey::new("".as_bytes(), 1).internal_key(), [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b""` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/cmp.rs:235:57 [INFO] [stderr] | [INFO] [stderr] 235 | LookupKey::new("".as_bytes(), 2).internal_key()), [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b""` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/cmp.rs:236:35 [INFO] [stderr] | [INFO] [stderr] 236 | LookupKey::new("".as_bytes(), 1).internal_key()); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b""` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/cmp.rs:237:57 [INFO] [stderr] | [INFO] [stderr] 237 | assert_eq!(cmp.find_shortest_sep(LookupKey::new("abc".as_bytes(), 2).internal_key(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abc"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/cmp.rs:238:57 [INFO] [stderr] | [INFO] [stderr] 238 | LookupKey::new("abc".as_bytes(), 2).internal_key()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abc"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/cmp.rs:239:35 [INFO] [stderr] | [INFO] [stderr] 239 | LookupKey::new("abc".as_bytes(), 2).internal_key()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abc"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/cmp.rs:246:32 [INFO] [stderr] | [INFO] [stderr] 246 | let a = LookupKey::new("abc".as_bytes(), 2).internal_key().to_vec(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abc"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/cmp.rs:247:32 [INFO] [stderr] | [INFO] [stderr] 247 | let b = LookupKey::new("abc".as_bytes(), 1).internal_key().to_vec(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abc"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/cmp.rs:248:32 [INFO] [stderr] | [INFO] [stderr] 248 | let c = LookupKey::new("abd".as_bytes(), 3).internal_key().to_vec(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abd"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/cmp.rs:249:17 [INFO] [stderr] | [INFO] [stderr] 249 | let d = "xyy".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"xyy"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/cmp.rs:250:17 [INFO] [stderr] | [INFO] [stderr] 250 | let e = "xyz".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"xyz"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `disk_env::PosixDiskEnv` [INFO] [stderr] --> src/disk_env.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | / pub fn new() -> PosixDiskEnv { [INFO] [stderr] 29 | | PosixDiskEnv { [INFO] [stderr] 30 | | locks: Arc::new(Mutex::new(HashMap::new())), [INFO] [stderr] 31 | | } [INFO] [stderr] 32 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 23 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/disk_env.rs:85:20 [INFO] [stderr] | [INFO] [stderr] 85 | if !r.is_ok() { [INFO] [stderr] | ^^^^^^^^^^ help: try: `r.is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/disk_env.rs:101:12 [INFO] [stderr] | [INFO] [stderr] 101 | Ok(fs::remove_file(p).map_err(|e| map_err_with_name("delete", p, e))?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 101 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/disk_env.rs:104:12 [INFO] [stderr] | [INFO] [stderr] 104 | Ok(fs::create_dir(p).map_err(|e| map_err_with_name("mkdir", p, e))?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 104 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/disk_env.rs:107:12 [INFO] [stderr] | [INFO] [stderr] 107 | Ok(fs::remove_dir_all(p).map_err(|e| map_err_with_name("rmdir", p, e))?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 107 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/disk_env.rs:110:12 [INFO] [stderr] | [INFO] [stderr] 110 | Ok(fs::rename(old, new).map_err(|e| map_err_with_name("rename", old, e))?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 110 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/disk_env.rs:137:21 [INFO] [stderr] | [INFO] [stderr] 137 | mem::transmute::<&libc::flock, *const libc::flock>(&&flock_arg), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&&flock_arg as *const &libc::flock as *const libc::flock` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_transmute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/disk_env.rs:176:21 [INFO] [stderr] | [INFO] [stderr] 176 | mem::transmute::<&libc::flock, *const libc::flock>(&&flock_arg), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&&flock_arg as *const &libc::flock as *const libc::flock` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/disk_env.rs:228:29 [INFO] [stderr] | [INFO] [stderr] 228 | let _ = f.write("123xyz".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"123xyz"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/disk_env.rs:254:29 [INFO] [stderr] | [INFO] [stderr] 254 | let _ = f.write("123xyz".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"123xyz"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/env.rs:58:36 [INFO] [stderr] | [INFO] [stderr] 58 | pub fn log(&mut self, message: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/env_common.rs:10:57 [INFO] [stderr] | [INFO] [stderr] 10 | Ok(dur) => return dur.as_secs() * 1000000 + (dur.subsec_nanos() / 1000) as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(dur.subsec_nanos() / 1000)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: Calling `subsec_micros()` is more concise than this calculation [INFO] [stderr] --> src/env_common.rs:10:57 [INFO] [stderr] | [INFO] [stderr] 10 | Ok(dur) => return dur.as_secs() * 1000000 + (dur.subsec_nanos() / 1000) as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `dur.subsec_micros()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::duration_subsec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duration_subsec [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/filter.rs:95:55 [INFO] [stderr] | [INFO] [stderr] 95 | let mut h: u32 = BLOOM_SEED ^ (limit as u64 * m as u64) as u32; [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(m)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/filter.rs:101:18 [INFO] [stderr] | [INFO] [stderr] 101 | h = (h as u64 + w as u64) as u32; [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/filter.rs:101:29 [INFO] [stderr] | [INFO] [stderr] 101 | h = (h as u64 + w as u64) as u32; [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(w)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/filter.rs:102:18 [INFO] [stderr] | [INFO] [stderr] 102 | h = (h as u64 * m as u64) as u32; [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/filter.rs:102:29 [INFO] [stderr] | [INFO] [stderr] 102 | h = (h as u64 * m as u64) as u32; [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(m)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the variable `i` is used as a loop counter. Consider using `for (i, item) in data[ix..].iter().enumerate()` or similar iterators [INFO] [stderr] --> src/filter.rs:112:22 [INFO] [stderr] | [INFO] [stderr] 112 | for b in data[ix..].iter() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/filter.rs:113:39 [INFO] [stderr] | [INFO] [stderr] 113 | h = h.overflowing_add((*b as u32) << (8 * i)).0; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(*b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/filter.rs:117:18 [INFO] [stderr] | [INFO] [stderr] 117 | h = (h as u64 * m as u64) as u32; [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/filter.rs:117:29 [INFO] [stderr] | [INFO] [stderr] 117 | h = (h as u64 * m as u64) as u32; [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(m)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/filter.rs:152:22 [INFO] [stderr] | [INFO] [stderr] 152 | h = (h as u64 + delta as u64) as u32; [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/filter.rs:152:33 [INFO] [stderr] | [INFO] [stderr] 152 | h = (h as u64 + delta as u64) as u32; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(delta)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/filter.rs:159:12 [INFO] [stderr] | [INFO] [stderr] 159 | if filter.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `filter.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/filter.rs:178:18 [INFO] [stderr] | [INFO] [stderr] 178 | h = (h as u64 + delta as u64) as u32; [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/filter.rs:178:29 [INFO] [stderr] | [INFO] [stderr] 178 | h = (h as u64 + delta as u64) as u32; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(delta)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/filter.rs:246:13 [INFO] [stderr] | [INFO] [stderr] 246 | "abc123def456".as_bytes(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abc123def456"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/filter.rs:247:13 [INFO] [stderr] | [INFO] [stderr] 247 | "xxx111xxx222".as_bytes(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"xxx111xxx222"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/filter.rs:248:13 [INFO] [stderr] | [INFO] [stderr] 248 | "ab00cd00ab".as_bytes(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"ab00cd00ab"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/filter.rs:249:13 [INFO] [stderr] | [INFO] [stderr] 249 | "908070605040302010".as_bytes(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"908070605040302010"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/filter_block.rs:126:21 [INFO] [stderr] | [INFO] [stderr] 126 | let fbase = data[data.len() - 1] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(data[data.len() - 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/filter_block.rs:181:13 [INFO] [stderr] | [INFO] [stderr] 181 | "abcd".as_bytes(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abcd"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/filter_block.rs:182:13 [INFO] [stderr] | [INFO] [stderr] 182 | "efgh".as_bytes(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"efgh"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/filter_block.rs:183:13 [INFO] [stderr] | [INFO] [stderr] 183 | "ijkl".as_bytes(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"ijkl"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/filter_block.rs:184:13 [INFO] [stderr] | [INFO] [stderr] 184 | "mnopqrstuvwxyz".as_bytes(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"mnopqrstuvwxyz"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/filter_block.rs:235:13 [INFO] [stderr] | [INFO] [stderr] 235 | "xsb".as_bytes(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"xsb"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/filter_block.rs:236:13 [INFO] [stderr] | [INFO] [stderr] 236 | "9sad".as_bytes(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"9sad"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/filter_block.rs:237:13 [INFO] [stderr] | [INFO] [stderr] 237 | "assssaaaass".as_bytes(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"assssaaaass"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/key_types.rs:47:5 [INFO] [stderr] | [INFO] [stderr] 47 | / pub fn new<'a>(k: UserKey<'a>, s: SequenceNumber) -> LookupKey { [INFO] [stderr] 48 | | LookupKey::new_full(k, s, ValueType::TypeValue) [INFO] [stderr] 49 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/key_types.rs:51:5 [INFO] [stderr] | [INFO] [stderr] 51 | / pub fn new_full<'a>(k: UserKey<'a>, s: SequenceNumber, t: ValueType) -> LookupKey { [INFO] [stderr] 52 | | let mut key = Vec::new(); [INFO] [stderr] 53 | | let internal_keylen = k.len() + U64_SPACE; [INFO] [stderr] 54 | | key.resize(k.len() + internal_keylen.required_space() + U64_SPACE, 0); [INFO] [stderr] ... | [INFO] [stderr] 70 | | } [INFO] [stderr] 71 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/key_types.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | writer.write(k).expect("write to slice failed"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/key_types.rs:74:5 [INFO] [stderr] | [INFO] [stderr] 74 | / pub fn memtable_key<'a>(&'a self) -> MemtableKey<'a> { [INFO] [stderr] 75 | | self.key.as_slice() [INFO] [stderr] 76 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/key_types.rs:79:5 [INFO] [stderr] | [INFO] [stderr] 79 | / pub fn user_key<'a>(&'a self) -> UserKey<'a> { [INFO] [stderr] 80 | | &self.key[self.key_offset..self.key.len() - 8] [INFO] [stderr] 81 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/key_types.rs:84:5 [INFO] [stderr] | [INFO] [stderr] 84 | / pub fn internal_key<'a>(&'a self) -> InternalKey<'a> { [INFO] [stderr] 85 | | &self.key[self.key_offset..] [INFO] [stderr] 86 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/key_types.rs:123:9 [INFO] [stderr] | [INFO] [stderr] 123 | writer.write(key).expect("write to slice failed"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/key_types.rs:128:9 [INFO] [stderr] | [INFO] [stderr] 128 | writer.write(value).expect("write to slice failed"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/key_types.rs:137:1 [INFO] [stderr] | [INFO] [stderr] 137 | / pub fn parse_memtable_key<'a>(mkey: MemtableKey<'a>) -> (usize, usize, u64, usize, usize) { [INFO] [stderr] 138 | | let (keylen, mut i): (usize, usize) = VarInt::decode_var(&mkey); [INFO] [stderr] 139 | | let keyoff = i; [INFO] [stderr] 140 | | i += keylen - 8; [INFO] [stderr] ... | [INFO] [stderr] 151 | | } [INFO] [stderr] 152 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/key_types.rs:177:1 [INFO] [stderr] | [INFO] [stderr] 177 | / pub fn parse_internal_key<'a>(ikey: InternalKey<'a>) -> (ValueType, SequenceNumber, UserKey<'a>) { [INFO] [stderr] 178 | | if ikey.is_empty() { [INFO] [stderr] 179 | | return (ValueType::TypeDeletion, 0, &ikey[0..0]); [INFO] [stderr] 180 | | } [INFO] [stderr] ... | [INFO] [stderr] 183 | | return (typ, seq, &ikey[0..ikey.len() - 8]); [INFO] [stderr] 184 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/key_types.rs:216:34 [INFO] [stderr] | [INFO] [stderr] 216 | let lk1 = LookupKey::new("abcde".as_bytes(), 123); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abcde"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/key_types.rs:217:34 [INFO] [stderr] | [INFO] [stderr] 217 | let lk2 = LookupKey::new("xyabxy".as_bytes(), 97); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"xyabxy"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/key_types.rs:223:36 [INFO] [stderr] | [INFO] [stderr] 223 | assert_eq!(lk1.user_key(), "abcde".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abcde"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/key_types.rs:235:17 [INFO] [stderr] | [INFO] [stderr] 235 | "abc".as_bytes(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abc"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/key_types.rs:236:17 [INFO] [stderr] | [INFO] [stderr] 236 | "123".as_bytes(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"123"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/key_types.rs:243:32 [INFO] [stderr] | [INFO] [stderr] 243 | build_memtable_key("".as_bytes(), "123".as_bytes(), ValueType::TypeValue, 231), [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b""` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/key_types.rs:243:47 [INFO] [stderr] | [INFO] [stderr] 243 | build_memtable_key("".as_bytes(), "123".as_bytes(), ValueType::TypeValue, 231), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"123"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/key_types.rs:248:17 [INFO] [stderr] | [INFO] [stderr] 248 | "abc".as_bytes(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abc"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/key_types.rs:249:17 [INFO] [stderr] | [INFO] [stderr] 249 | "123".as_bytes(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"123"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/key_types.rs:257:17 [INFO] [stderr] | [INFO] [stderr] 257 | "abc".as_bytes(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abc"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/key_types.rs:258:17 [INFO] [stderr] | [INFO] [stderr] 258 | "".as_bytes(), [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b""` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/log.rs:56:33 [INFO] [stderr] | [INFO] [stderr] 56 | while result.is_ok() && record.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!record.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/log.rs:63:17 [INFO] [stderr] | [INFO] [stderr] 63 | try!(self.dst.write(&vec![0, 0, 0, 0, 0, 0][0..space_left])); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/log.rs:153:17 [INFO] [stderr] | [INFO] [stderr] 153 | / try!( [INFO] [stderr] 154 | | self.src [INFO] [stderr] 155 | | .read(&mut self.head_scratch[0..self.blocksize - self.blk_off]) [INFO] [stderr] 156 | | ); [INFO] [stderr] | |__________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/log.rs:192:55 [INFO] [stderr] | [INFO] [stderr] 192 | } else if typ == RecordType::Middle as u8 { [INFO] [stderr] | _______________________________________________________^ [INFO] [stderr] 193 | | continue; [INFO] [stderr] 194 | | } else if typ == RecordType::Last as u8 { [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/log.rs:190:54 [INFO] [stderr] | [INFO] [stderr] 190 | } else if typ == RecordType::First as u8 { [INFO] [stderr] | ______________________________________________________^ [INFO] [stderr] 191 | | continue; [INFO] [stderr] 192 | | } else if typ == RecordType::Middle as u8 { [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/log.rs:226:46 [INFO] [stderr] | [INFO] [stderr] 226 | let crc = crc32::checksum_castagnoli("abcde".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abcde"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/log.rs:319:16 [INFO] [stderr] | [INFO] [stderr] 319 | if !r.is_ok() { [INFO] [stderr] | ^^^^^^^^^^ help: try: `r.is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/log.rs:290:13 [INFO] [stderr] | [INFO] [stderr] 290 | "abcdefghi".as_bytes().to_vec(), // fits one block of 17 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abcdefghi"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/log.rs:291:13 [INFO] [stderr] | [INFO] [stderr] 291 | "123456789012".as_bytes().to_vec(), // spans two blocks of 17 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"123456789012"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/log.rs:292:13 [INFO] [stderr] | [INFO] [stderr] 292 | "0101010101010101010101".as_bytes().to_vec(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"0101010101010101010101"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/mem_env.rs:175:30 [INFO] [stderr] | [INFO] [stderr] 175 | if !prefix.ends_with("/") { [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `mem_env::MemEnv` [INFO] [stderr] --> src/mem_env.rs:278:5 [INFO] [stderr] | [INFO] [stderr] 278 | / pub fn new() -> MemEnv { [INFO] [stderr] 279 | | MemEnv(MemFS::new()) [INFO] [stderr] 280 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 277 | impl Default for mem_env::MemEnv { [INFO] [stderr] 278 | fn default() -> Self { [INFO] [stderr] 279 | Self::new() [INFO] [stderr] 280 | } [INFO] [stderr] 281 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/mem_env.rs:540:13 [INFO] [stderr] | [INFO] [stderr] 540 | f.write("abcdef".as_bytes()).expect("write failed"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/mem_env.rs:540:21 [INFO] [stderr] | [INFO] [stderr] 540 | f.write("abcdef".as_bytes()).expect("write failed"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abcdef"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/memtable.rs:200:13 [INFO] [stderr] | [INFO] [stderr] 200 | "abc".as_bytes(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abc"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/memtable.rs:201:13 [INFO] [stderr] | [INFO] [stderr] 201 | "123".as_bytes(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"123"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/memtable.rs:219:49 [INFO] [stderr] | [INFO] [stderr] 219 | if let Some(v) = mt.get(&LookupKey::new("abc".as_bytes(), 110)).0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abc"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/memtable.rs:224:49 [INFO] [stderr] | [INFO] [stderr] 224 | if let Some(v) = mt.get(&LookupKey::new("abf".as_bytes(), 110)).0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abf"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/memtable.rs:230:49 [INFO] [stderr] | [INFO] [stderr] 230 | if let Some(v) = mt.get(&LookupKey::new("abc".as_bytes(), 116)).0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abc"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/memtable.rs:231:27 [INFO] [stderr] | [INFO] [stderr] 231 | assert_eq!(v, "122".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"122"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/memtable.rs:237:60 [INFO] [stderr] | [INFO] [stderr] 237 | if let (Some(v), deleted) = mt.get(&LookupKey::new("abc".as_bytes(), 120)) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abc"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/memtable.rs:238:27 [INFO] [stderr] | [INFO] [stderr] 238 | assert_eq!(v, "123".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"123"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/memtable.rs:244:57 [INFO] [stderr] | [INFO] [stderr] 244 | if let (None, deleted) = mt.get(&LookupKey::new("abe".as_bytes(), 122)) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abe"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/memtable.rs:250:49 [INFO] [stderr] | [INFO] [stderr] 250 | if let Some(v) = mt.get(&LookupKey::new("abf".as_bytes(), 129)).0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abf"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/memtable.rs:251:27 [INFO] [stderr] | [INFO] [stderr] 251 | assert_eq!(v, "126".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"126"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/memtable.rs:280:34 [INFO] [stderr] | [INFO] [stderr] 280 | iter.seek(LookupKey::new("abc".as_bytes(), 400).internal_key()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abc"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/memtable.rs:284:14 [INFO] [stderr] | [INFO] [stderr] 284 | ("abc".as_bytes(), "123".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abc"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/memtable.rs:284:32 [INFO] [stderr] | [INFO] [stderr] 284 | ("abc".as_bytes(), "123".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"123"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/memtable.rs:288:34 [INFO] [stderr] | [INFO] [stderr] 288 | iter.seek(LookupKey::new("xxx".as_bytes(), 400).internal_key()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"xxx"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/memtable.rs:291:34 [INFO] [stderr] | [INFO] [stderr] 291 | iter.seek(LookupKey::new("abd".as_bytes(), 400).internal_key()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abd"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/memtable.rs:295:14 [INFO] [stderr] | [INFO] [stderr] 295 | ("abd".as_bytes(), "124".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abd"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/memtable.rs:295:32 [INFO] [stderr] | [INFO] [stderr] 295 | ("abd".as_bytes(), "124".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"124"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/memtable.rs:306:13 [INFO] [stderr] | [INFO] [stderr] 306 | "123".as_bytes(), /* i.e., the abc entry with [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"123"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/memtable.rs:308:13 [INFO] [stderr] | [INFO] [stderr] 308 | "122".as_bytes(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"122"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/memtable.rs:309:13 [INFO] [stderr] | [INFO] [stderr] 309 | "124".as_bytes(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"124"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/memtable.rs:311:13 [INFO] [stderr] | [INFO] [stderr] 311 | "125".as_bytes(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"125"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/memtable.rs:312:13 [INFO] [stderr] | [INFO] [stderr] 312 | "126".as_bytes(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"126"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: the variable `i` is used as a loop counter. Consider using `for (i, item) in LdbIteratorIter::wrap(&mut iter).enumerate()` or similar iterators [INFO] [stderr] --> src/memtable.rs:316:23 [INFO] [stderr] | [INFO] [stderr] 316 | for (k, v) in LdbIteratorIter::wrap(&mut iter) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/merging_iter.rs:112:9 [INFO] [stderr] | [INFO] [stderr] 112 | / let ord; [INFO] [stderr] 113 | | [INFO] [stderr] 114 | | if direction == SL::Smallest { [INFO] [stderr] 115 | | ord = Ordering::Less; [INFO] [stderr] 116 | | } else { [INFO] [stderr] 117 | | ord = Ordering::Greater; [INFO] [stderr] 118 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let ord = if direction == SL::Smallest { Ordering::Less } else { Ordering::Greater };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/merging_iter.rs:107:12 [INFO] [stderr] | [INFO] [stderr] 107 | if self.iters.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.iters.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/merging_iter.rs:214:9 [INFO] [stderr] | [INFO] [stderr] 214 | / loop { [INFO] [stderr] 215 | | if let Some((k, v)) = miter.next() { [INFO] [stderr] 216 | | if let Some((k2, v2)) = iter2.next() { [INFO] [stderr] 217 | | assert_eq!(k, k2); [INFO] [stderr] ... | [INFO] [stderr] 224 | | } [INFO] [stderr] 225 | | } [INFO] [stderr] | |_________^ help: try: `while let Some((k, v)) = miter.next() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/merging_iter.rs:239:9 [INFO] [stderr] | [INFO] [stderr] 239 | / loop { [INFO] [stderr] 240 | | if let Some((k, v)) = miter.next() { [INFO] [stderr] 241 | | if let Some((k2, v2)) = miter.next() { [INFO] [stderr] 242 | | assert_eq!(k, k2); [INFO] [stderr] ... | [INFO] [stderr] 249 | | } [INFO] [stderr] 250 | | } [INFO] [stderr] | |_________^ help: try: `while let Some((k, v)) = miter.next() { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/merging_iter.rs:261:19 [INFO] [stderr] | [INFO] [stderr] 261 | let val = "def".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"def"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/merging_iter.rs:273:19 [INFO] [stderr] | [INFO] [stderr] 273 | let val = "def".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"def"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/merging_iter.rs:319:19 [INFO] [stderr] | [INFO] [stderr] 319 | let val = "def".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"def"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: the variable `i` is used as a loop counter. Consider using `for (i, item) in LdbIteratorIter::wrap(&mut iter).enumerate()` or similar iterators [INFO] [stderr] --> src/merging_iter.rs:331:23 [INFO] [stderr] | [INFO] [stderr] 331 | for (k, _) in LdbIteratorIter::wrap(&mut iter) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/merging_iter.rs:339:19 [INFO] [stderr] | [INFO] [stderr] 339 | let val = "def".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"def"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/merging_iter.rs:354:19 [INFO] [stderr] | [INFO] [stderr] 354 | iter.seek("abc".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abc"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/merging_iter.rs:359:19 [INFO] [stderr] | [INFO] [stderr] 359 | iter.seek("ab0".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"ab0"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/merging_iter.rs:364:19 [INFO] [stderr] | [INFO] [stderr] 364 | iter.seek("abx".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abx"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/skipmap.rs:144:76 [INFO] [stderr] | [INFO] [stderr] 144 | } else if self.cmp.cmp(&(*current).key, key) == Ordering::Less { [INFO] [stderr] | ____________________________________________________________________________^ [INFO] [stderr] 145 | | return None; [INFO] [stderr] 146 | | } else { [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/skipmap.rs:142:67 [INFO] [stderr] | [INFO] [stderr] 142 | if current.is_null() || current == self.head.as_ref() { [INFO] [stderr] | ___________________________________________________________________^ [INFO] [stderr] 143 | | return None; [INFO] [stderr] 144 | | } else if self.cmp.cmp(&(*current).key, key) == Ordering::Less { [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/skipmap.rs:164:21 [INFO] [stderr] | [INFO] [stderr] 164 | / match ord { [INFO] [stderr] 165 | | Ordering::Less => { [INFO] [stderr] 166 | | current = next; [INFO] [stderr] 167 | | continue; [INFO] [stderr] 168 | | } [INFO] [stderr] 169 | | _ => (), [INFO] [stderr] 170 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 164 | if let Ordering::Less = ord { [INFO] [stderr] 165 | current = next; [INFO] [stderr] 166 | continue; [INFO] [stderr] 167 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/skipmap.rs:183:76 [INFO] [stderr] | [INFO] [stderr] 183 | } else if self.cmp.cmp(&(*current).key, key) != Ordering::Less { [INFO] [stderr] | ____________________________________________________________________________^ [INFO] [stderr] 184 | | return None; [INFO] [stderr] 185 | | } else { [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/skipmap.rs:180:67 [INFO] [stderr] | [INFO] [stderr] 180 | if current.is_null() || current == self.head.as_ref() { [INFO] [stderr] | ___________________________________________________________________^ [INFO] [stderr] 181 | | // If we're past the end for some reason or at the head [INFO] [stderr] 182 | | return None; [INFO] [stderr] 183 | | } else if self.cmp.cmp(&(*current).key, key) != Ordering::Less { [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `prevs`. [INFO] [stderr] --> src/skipmap.rs:202:18 [INFO] [stderr] | [INFO] [stderr] 202 | for i in 0..prevs.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 202 | for in &mut prevs { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `prevs` [INFO] [stderr] --> src/skipmap.rs:245:18 [INFO] [stderr] | [INFO] [stderr] 245 | for i in 0..new_height { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 245 | for (i, ) in prevs.iter().enumerate().take(new_height) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/skipmap.rs:277:37 [INFO] [stderr] | [INFO] [stderr] 277 | if let Some(next) = (*current).skips[0].clone() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `(*current).skips[0]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/skipmap.rs:371:47 [INFO] [stderr] | [INFO] [stderr] 371 | skm.insert(k.as_bytes().to_vec(), "def".as_bytes().to_vec()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"def"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/skipmap.rs:388:20 [INFO] [stderr] | [INFO] [stderr] 388 | skm.insert("abc".as_bytes().to_vec(), "def".as_bytes().to_vec()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abc"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/skipmap.rs:388:47 [INFO] [stderr] | [INFO] [stderr] 388 | skm.insert("abc".as_bytes().to_vec(), "def".as_bytes().to_vec()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"def"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/skipmap.rs:389:20 [INFO] [stderr] | [INFO] [stderr] 389 | skm.insert("abf".as_bytes().to_vec(), "def".as_bytes().to_vec()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abf"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/skipmap.rs:389:47 [INFO] [stderr] | [INFO] [stderr] 389 | skm.insert("abf".as_bytes().to_vec(), "def".as_bytes().to_vec()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"def"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/skipmap.rs:395:31 [INFO] [stderr] | [INFO] [stderr] 395 | assert!(skm.contains(&"aby".as_bytes().to_vec())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"aby"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/skipmap.rs:396:31 [INFO] [stderr] | [INFO] [stderr] 396 | assert!(skm.contains(&"abc".as_bytes().to_vec())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abc"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/skipmap.rs:397:31 [INFO] [stderr] | [INFO] [stderr] 397 | assert!(skm.contains(&"abz".as_bytes().to_vec())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abz"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/skipmap.rs:398:32 [INFO] [stderr] | [INFO] [stderr] 398 | assert!(!skm.contains(&"ab{".as_bytes().to_vec())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"ab{"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/skipmap.rs:399:32 [INFO] [stderr] | [INFO] [stderr] 399 | assert!(!skm.contains(&"123".as_bytes().to_vec())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"123"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/skipmap.rs:400:32 [INFO] [stderr] | [INFO] [stderr] 400 | assert!(!skm.contains(&"aaa".as_bytes().to_vec())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"aaa"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/skipmap.rs:401:32 [INFO] [stderr] | [INFO] [stderr] 401 | assert!(!skm.contains(&"456".as_bytes().to_vec())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"456"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/skipmap.rs:410:40 [INFO] [stderr] | [INFO] [stderr] 410 | .get_greater_or_equal(&"abf".as_bytes().to_vec()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abf"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/skipmap.rs:413:13 [INFO] [stderr] | [INFO] [stderr] 413 | "abf".as_bytes().to_vec() [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abf"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/skipmap.rs:418:40 [INFO] [stderr] | [INFO] [stderr] 418 | .get_greater_or_equal(&"ab{".as_bytes().to_vec()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"ab{"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/skipmap.rs:424:40 [INFO] [stderr] | [INFO] [stderr] 424 | .get_greater_or_equal(&"aaa".as_bytes().to_vec()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"aaa"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/skipmap.rs:427:13 [INFO] [stderr] | [INFO] [stderr] 427 | "aba".as_bytes().to_vec() [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"aba"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/skipmap.rs:432:40 [INFO] [stderr] | [INFO] [stderr] 432 | .get_greater_or_equal(&"ab".as_bytes()) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"ab"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/skipmap.rs:436:13 [INFO] [stderr] | [INFO] [stderr] 436 | "aba".as_bytes() [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"aba"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/skipmap.rs:441:40 [INFO] [stderr] | [INFO] [stderr] 441 | .get_greater_or_equal(&"abc".as_bytes()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abc"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/skipmap.rs:445:13 [INFO] [stderr] | [INFO] [stderr] 445 | "abc".as_bytes() [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abc"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/skipmap.rs:450:36 [INFO] [stderr] | [INFO] [stderr] 450 | .get_next_smaller(&"ab0".as_bytes()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"ab0"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/skipmap.rs:456:36 [INFO] [stderr] | [INFO] [stderr] 456 | .get_next_smaller(&"abd".as_bytes()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abd"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/skipmap.rs:460:13 [INFO] [stderr] | [INFO] [stderr] 460 | "abc".as_bytes() [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abc"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/skipmap.rs:465:36 [INFO] [stderr] | [INFO] [stderr] 465 | .get_next_smaller(&"ab{".as_bytes()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"ab{"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/skipmap.rs:469:13 [INFO] [stderr] | [INFO] [stderr] 469 | "abz".as_bytes() [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abz"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/skipmap.rs:480:17 [INFO] [stderr] | [INFO] [stderr] 480 | it.seek("abc".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abc"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/skipmap.rs:534:55 [INFO] [stderr] | [INFO] [stderr] 534 | assert_eq!(current_key_val(&iter).unwrap().0, "aba".as_bytes().to_vec()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"aba"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/skipmap.rs:535:20 [INFO] [stderr] | [INFO] [stderr] 535 | iter.seek(&"abz".as_bytes().to_vec()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abz"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/skipmap.rs:538:14 [INFO] [stderr] | [INFO] [stderr] 538 | ("abz".as_bytes().to_vec(), "def".as_bytes().to_vec()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abz"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/skipmap.rs:538:41 [INFO] [stderr] | [INFO] [stderr] 538 | ("abz".as_bytes().to_vec(), "def".as_bytes().to_vec()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"def"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/skipmap.rs:541:20 [INFO] [stderr] | [INFO] [stderr] 541 | iter.seek(&"aba".as_bytes().to_vec()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"aba"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/skipmap.rs:544:14 [INFO] [stderr] | [INFO] [stderr] 544 | ("aba".as_bytes().to_vec(), "def".as_bytes().to_vec()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"aba"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/skipmap.rs:544:41 [INFO] [stderr] | [INFO] [stderr] 544 | ("aba".as_bytes().to_vec(), "def".as_bytes().to_vec()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"def"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/skipmap.rs:547:20 [INFO] [stderr] | [INFO] [stderr] 547 | iter.seek(&"".as_bytes().to_vec()); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b""` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/skipmap.rs:563:47 [INFO] [stderr] | [INFO] [stderr] 563 | skm.insert(k.as_bytes().to_vec(), "def".as_bytes().to_vec()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"def"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/skipmap.rs:577:20 [INFO] [stderr] | [INFO] [stderr] 577 | iter.seek(&"abc".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abc"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/skipmap.rs:581:14 [INFO] [stderr] | [INFO] [stderr] 581 | ("abb".as_bytes().to_vec(), "def".as_bytes().to_vec()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abb"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/skipmap.rs:581:41 [INFO] [stderr] | [INFO] [stderr] 581 | ("abb".as_bytes().to_vec(), "def".as_bytes().to_vec()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"def"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/skipmap.rs:593:20 [INFO] [stderr] | [INFO] [stderr] 593 | skm.insert("abccc".as_bytes().to_vec(), "defff".as_bytes().to_vec()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abccc"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/skipmap.rs:593:49 [INFO] [stderr] | [INFO] [stderr] 593 | skm.insert("abccc".as_bytes().to_vec(), "defff".as_bytes().to_vec()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"defff"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/skipmap.rs:596:21 [INFO] [stderr] | [INFO] [stderr] 596 | if k == "abccc".as_bytes() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abccc"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/table_block.rs:70:58 [INFO] [stderr] | [INFO] [stderr] 70 | if let Some(ctype) = options::int_to_compressiontype(compress[0] as u32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(compress[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `to`. [INFO] [stderr] --> src/table_builder.rs:66:18 [INFO] [stderr] | [INFO] [stderr] 66 | for i in s1 + s2..FOOTER_LENGTH { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 66 | for in to.iter_mut().take(FOOTER_LENGTH).skip(s1 + s2) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/table_builder.rs:69:18 [INFO] [stderr] | [INFO] [stderr] 69 | for i in FOOTER_LENGTH..FULL_FOOTER_LENGTH { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try replacing the loop by: `to[FOOTER_LENGTH..FULL_FOOTER_LENGTH].clone_from_slice(&MAGIC_FOOTER_ENCODED[0..(FULL_FOOTER_LENGTH - FOOTER_LENGTH)])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/table_builder.rs:214:9 [INFO] [stderr] | [INFO] [stderr] 214 | self.dst.write(&data)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/table_builder.rs:215:9 [INFO] [stderr] | [INFO] [stderr] 215 | self.dst.write(&[ctype as u8; TABLE_BLOCK_COMPRESS_LEN])?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: the variable `i` is used as a loop counter. Consider using `for (i, item) in LdbIteratorIter::wrap(&mut iter).enumerate()` or similar iterators [INFO] [stderr] --> src/table_reader.rs:459:23 [INFO] [stderr] | [INFO] [stderr] 459 | for (k, _) in LdbIteratorIter::wrap(&mut iter) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/table_reader.rs:465:48 [INFO] [stderr] | [INFO] [stderr] 465 | assert_eq!(137, table.approx_offset_of("{aa".as_bytes())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"{aa"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/table_reader.rs:549:9 [INFO] [stderr] | [INFO] [stderr] 549 | / loop { [INFO] [stderr] 550 | | if let Some((k, _)) = iter.next() { [INFO] [stderr] 551 | | assert!(filter_reader.key_may_match(iter.current_block_off, &k)); [INFO] [stderr] 552 | | assert!(!filter_reader.key_may_match(iter.current_block_off, b"somerandomkey")); [INFO] [stderr] ... | [INFO] [stderr] 555 | | } [INFO] [stderr] 556 | | } [INFO] [stderr] | |_________^ help: try: `while let Some((k, _)) = iter.next() { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/table_reader.rs:654:19 [INFO] [stderr] | [INFO] [stderr] 654 | iter.seek("{{{".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"{{{"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/table_reader.rs:684:27 [INFO] [stderr] | [INFO] [stderr] 684 | assert!(table.get("zz{".as_bytes()).unwrap().is_none()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"zz{"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/table_reader.rs:717:9 [INFO] [stderr] | [INFO] [stderr] 717 | / loop { [INFO] [stderr] 718 | | if let Some((k, _)) = iter.next() { [INFO] [stderr] 719 | | let lk = LookupKey::new(&k, 123); [INFO] [stderr] 720 | | let userkey = lk.user_key(); [INFO] [stderr] ... | [INFO] [stderr] 726 | | } [INFO] [stderr] 727 | | } [INFO] [stderr] | |_________^ help: try: `while let Some((k, _)) = iter.next() { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 26 [INFO] [stderr] --> src/test_util.rs:92:1 [INFO] [stderr] | [INFO] [stderr] 92 | / pub fn test_iterator_properties(mut it: It) { [INFO] [stderr] 93 | | assert!(!it.valid()); [INFO] [stderr] 94 | | assert!(it.advance()); [INFO] [stderr] 95 | | assert!(it.valid()); [INFO] [stderr] ... | [INFO] [stderr] 130 | | assert!(!it.valid()); [INFO] [stderr] 131 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/test_util.rs:140:14 [INFO] [stderr] | [INFO] [stderr] 140 | ("abc".as_bytes(), "def".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abc"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/test_util.rs:140:32 [INFO] [stderr] | [INFO] [stderr] 140 | ("abc".as_bytes(), "def".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"def"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/test_util.rs:141:14 [INFO] [stderr] | [INFO] [stderr] 141 | ("abd".as_bytes(), "deg".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abd"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/test_util.rs:141:32 [INFO] [stderr] | [INFO] [stderr] 141 | ("abd".as_bytes(), "deg".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"deg"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/test_util.rs:146:29 [INFO] [stderr] | [INFO] [stderr] 146 | Some((Vec::from("abc".as_bytes()), Vec::from("def".as_bytes()))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abc"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/test_util.rs:146:58 [INFO] [stderr] | [INFO] [stderr] 146 | Some((Vec::from("abc".as_bytes()), Vec::from("def".as_bytes()))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"def"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/test_util.rs:157:18 [INFO] [stderr] | [INFO] [stderr] 157 | ("abc".as_bytes(), "def".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abc"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/test_util.rs:157:36 [INFO] [stderr] | [INFO] [stderr] 157 | ("abc".as_bytes(), "def".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"def"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/test_util.rs:158:18 [INFO] [stderr] | [INFO] [stderr] 158 | ("abd".as_bytes(), "deg".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abd"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/test_util.rs:158:36 [INFO] [stderr] | [INFO] [stderr] 158 | ("abd".as_bytes(), "deg".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"deg"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/test_util.rs:159:18 [INFO] [stderr] | [INFO] [stderr] 159 | ("abe".as_bytes(), "deg".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abe"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/test_util.rs:159:36 [INFO] [stderr] | [INFO] [stderr] 159 | ("abe".as_bytes(), "deg".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"deg"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/test_util.rs:160:18 [INFO] [stderr] | [INFO] [stderr] 160 | ("abf".as_bytes(), "deg".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abf"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/test_util.rs:160:36 [INFO] [stderr] | [INFO] [stderr] 160 | ("abf".as_bytes(), "deg".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"deg"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: the loop variable `level` is used to index `levels` [INFO] [stderr] --> src/version.rs:70:22 [INFO] [stderr] | [INFO] [stderr] 70 | for level in 0..levels.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 70 | for (level, ) in levels.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `level` is used to index `levels` [INFO] [stderr] --> src/version.rs:127:22 [INFO] [stderr] | [INFO] [stderr] 127 | for level in 1..NUM_LEVELS { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 127 | for (level, ) in levels.iter_mut().enumerate().take(NUM_LEVELS).skip(1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the variable `i` is used as a loop counter. Consider using `for (i, item) in &levels.enumerate()` or similar iterators [INFO] [stderr] --> src/version.rs:203:22 [INFO] [stderr] | [INFO] [stderr] 203 | for level in &levels { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/version.rs:258:33 [INFO] [stderr] | [INFO] [stderr] 258 | pub fn overlap_in_level<'a, 'b>( [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/version.rs:313:14 [INFO] [stderr] | [INFO] [stderr] 313 | ) -> (Option<(Vec, Vec)>, Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/version.rs:326:17 [INFO] [stderr] | [INFO] [stderr] 326 | / { [INFO] [stderr] 327 | | continue; [INFO] [stderr] 328 | | } else { [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/version.rs:322:99 [INFO] [stderr] | [INFO] [stderr] 322 | if !ubegin.is_empty() && myself.user_cmp.cmp(flargest, &ubegin) == Ordering::Less { [INFO] [stderr] | ___________________________________________________________________________________________________^ [INFO] [stderr] 323 | | continue; [INFO] [stderr] 324 | | } else if !uend.is_empty() [INFO] [stderr] | |_________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/version.rs:602:13 [INFO] [stderr] | [INFO] [stderr] 602 | me: &Box, [INFO] [stderr] | ^^^^^^^^^ help: try: `&Env` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:646:14 [INFO] [stderr] | [INFO] [stderr] 646 | ("aac".as_bytes(), "val1".as_bytes(), ValueType::TypeDeletion), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"aac"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:646:32 [INFO] [stderr] | [INFO] [stderr] 646 | ("aac".as_bytes(), "val1".as_bytes(), ValueType::TypeDeletion), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"val1"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:647:14 [INFO] [stderr] | [INFO] [stderr] 647 | ("aax".as_bytes(), "val2".as_bytes(), ValueType::TypeValue), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"aax"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:647:32 [INFO] [stderr] | [INFO] [stderr] 647 | ("aax".as_bytes(), "val2".as_bytes(), ValueType::TypeValue), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"val2"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:648:14 [INFO] [stderr] | [INFO] [stderr] 648 | ("aba".as_bytes(), "val3".as_bytes(), ValueType::TypeValue), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"aba"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:648:32 [INFO] [stderr] | [INFO] [stderr] 648 | ("aba".as_bytes(), "val3".as_bytes(), ValueType::TypeValue), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"val3"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:649:14 [INFO] [stderr] | [INFO] [stderr] 649 | ("bab".as_bytes(), "val4".as_bytes(), ValueType::TypeValue), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"bab"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:649:32 [INFO] [stderr] | [INFO] [stderr] 649 | ("bab".as_bytes(), "val4".as_bytes(), ValueType::TypeValue), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"val4"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:650:14 [INFO] [stderr] | [INFO] [stderr] 650 | ("bba".as_bytes(), "val5".as_bytes(), ValueType::TypeValue), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"bba"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:650:32 [INFO] [stderr] | [INFO] [stderr] 650 | ("bba".as_bytes(), "val5".as_bytes(), ValueType::TypeValue), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"val5"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:654:14 [INFO] [stderr] | [INFO] [stderr] 654 | ("aaa".as_bytes(), "val1".as_bytes(), ValueType::TypeValue), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"aaa"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:654:32 [INFO] [stderr] | [INFO] [stderr] 654 | ("aaa".as_bytes(), "val1".as_bytes(), ValueType::TypeValue), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"val1"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:655:14 [INFO] [stderr] | [INFO] [stderr] 655 | ("aab".as_bytes(), "val2".as_bytes(), ValueType::TypeValue), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"aab"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:655:32 [INFO] [stderr] | [INFO] [stderr] 655 | ("aab".as_bytes(), "val2".as_bytes(), ValueType::TypeValue), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"val2"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:656:14 [INFO] [stderr] | [INFO] [stderr] 656 | ("aac".as_bytes(), "val3".as_bytes(), ValueType::TypeValue), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"aac"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:656:32 [INFO] [stderr] | [INFO] [stderr] 656 | ("aac".as_bytes(), "val3".as_bytes(), ValueType::TypeValue), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"val3"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:657:14 [INFO] [stderr] | [INFO] [stderr] 657 | ("aba".as_bytes(), "val4".as_bytes(), ValueType::TypeValue), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"aba"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:657:32 [INFO] [stderr] | [INFO] [stderr] 657 | ("aba".as_bytes(), "val4".as_bytes(), ValueType::TypeValue), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"val4"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:662:14 [INFO] [stderr] | [INFO] [stderr] 662 | ("aaa".as_bytes(), "val0".as_bytes(), ValueType::TypeValue), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"aaa"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:662:32 [INFO] [stderr] | [INFO] [stderr] 662 | ("aaa".as_bytes(), "val0".as_bytes(), ValueType::TypeValue), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"val0"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:663:14 [INFO] [stderr] | [INFO] [stderr] 663 | ("cab".as_bytes(), "val2".as_bytes(), ValueType::TypeValue), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"cab"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:663:32 [INFO] [stderr] | [INFO] [stderr] 663 | ("cab".as_bytes(), "val2".as_bytes(), ValueType::TypeValue), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"val2"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:664:14 [INFO] [stderr] | [INFO] [stderr] 664 | ("cba".as_bytes(), "val3".as_bytes(), ValueType::TypeValue), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"cba"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:664:32 [INFO] [stderr] | [INFO] [stderr] 664 | ("cba".as_bytes(), "val3".as_bytes(), ValueType::TypeValue), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"val3"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:668:14 [INFO] [stderr] | [INFO] [stderr] 668 | ("daa".as_bytes(), "val1".as_bytes(), ValueType::TypeValue), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"daa"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:668:32 [INFO] [stderr] | [INFO] [stderr] 668 | ("daa".as_bytes(), "val1".as_bytes(), ValueType::TypeValue), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"val1"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:669:14 [INFO] [stderr] | [INFO] [stderr] 669 | ("dab".as_bytes(), "val2".as_bytes(), ValueType::TypeValue), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"dab"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:669:32 [INFO] [stderr] | [INFO] [stderr] 669 | ("dab".as_bytes(), "val2".as_bytes(), ValueType::TypeValue), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"val2"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:670:14 [INFO] [stderr] | [INFO] [stderr] 670 | ("dba".as_bytes(), "val3".as_bytes(), ValueType::TypeValue), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"dba"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:670:32 [INFO] [stderr] | [INFO] [stderr] 670 | ("dba".as_bytes(), "val3".as_bytes(), ValueType::TypeValue), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"val3"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:674:14 [INFO] [stderr] | [INFO] [stderr] 674 | ("eaa".as_bytes(), "val1".as_bytes(), ValueType::TypeValue), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"eaa"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:674:32 [INFO] [stderr] | [INFO] [stderr] 674 | ("eaa".as_bytes(), "val1".as_bytes(), ValueType::TypeValue), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"val1"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:675:14 [INFO] [stderr] | [INFO] [stderr] 675 | ("eab".as_bytes(), "val2".as_bytes(), ValueType::TypeValue), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"eab"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:675:32 [INFO] [stderr] | [INFO] [stderr] 675 | ("eab".as_bytes(), "val2".as_bytes(), ValueType::TypeValue), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"val2"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:676:14 [INFO] [stderr] | [INFO] [stderr] 676 | ("fab".as_bytes(), "val3".as_bytes(), ValueType::TypeValue), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"fab"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:676:32 [INFO] [stderr] | [INFO] [stderr] 676 | ("fab".as_bytes(), "val3".as_bytes(), ValueType::TypeValue), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"val3"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:681:14 [INFO] [stderr] | [INFO] [stderr] 681 | ("cab".as_bytes(), "val1".as_bytes(), ValueType::TypeValue), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"cab"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:681:32 [INFO] [stderr] | [INFO] [stderr] 681 | ("cab".as_bytes(), "val1".as_bytes(), ValueType::TypeValue), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"val1"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:682:14 [INFO] [stderr] | [INFO] [stderr] 682 | ("fab".as_bytes(), "val2".as_bytes(), ValueType::TypeValue), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"fab"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:682:32 [INFO] [stderr] | [INFO] [stderr] 682 | ("fab".as_bytes(), "val2".as_bytes(), ValueType::TypeValue), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"val2"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:683:14 [INFO] [stderr] | [INFO] [stderr] 683 | ("fba".as_bytes(), "val3".as_bytes(), ValueType::TypeValue), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"fba"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:683:32 [INFO] [stderr] | [INFO] [stderr] 683 | ("fba".as_bytes(), "val3".as_bytes(), ValueType::TypeValue), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"val3"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:687:14 [INFO] [stderr] | [INFO] [stderr] 687 | ("gaa".as_bytes(), "val1".as_bytes(), ValueType::TypeValue), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"gaa"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:687:32 [INFO] [stderr] | [INFO] [stderr] 687 | ("gaa".as_bytes(), "val1".as_bytes(), ValueType::TypeValue), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"val1"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:688:14 [INFO] [stderr] | [INFO] [stderr] 688 | ("gab".as_bytes(), "val2".as_bytes(), ValueType::TypeValue), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"gab"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:688:32 [INFO] [stderr] | [INFO] [stderr] 688 | ("gab".as_bytes(), "val2".as_bytes(), ValueType::TypeValue), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"val2"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:689:14 [INFO] [stderr] | [INFO] [stderr] 689 | ("gba".as_bytes(), "val3".as_bytes(), ValueType::TypeValue), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"gba"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:689:32 [INFO] [stderr] | [INFO] [stderr] 689 | ("gba".as_bytes(), "val3".as_bytes(), ValueType::TypeValue), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"val3"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:690:14 [INFO] [stderr] | [INFO] [stderr] 690 | ("gca".as_bytes(), "val4".as_bytes(), ValueType::TypeDeletion), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"gca"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:690:32 [INFO] [stderr] | [INFO] [stderr] 690 | ("gca".as_bytes(), "val4".as_bytes(), ValueType::TypeDeletion), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"val4"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:691:14 [INFO] [stderr] | [INFO] [stderr] 691 | ("gda".as_bytes(), "val5".as_bytes(), ValueType::TypeValue), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"gda"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:691:32 [INFO] [stderr] | [INFO] [stderr] 691 | ("gda".as_bytes(), "val5".as_bytes(), ValueType::TypeValue), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"val5"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:696:14 [INFO] [stderr] | [INFO] [stderr] 696 | ("haa".as_bytes(), "val1".as_bytes(), ValueType::TypeValue), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"haa"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:696:32 [INFO] [stderr] | [INFO] [stderr] 696 | ("haa".as_bytes(), "val1".as_bytes(), ValueType::TypeValue), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"val1"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:697:14 [INFO] [stderr] | [INFO] [stderr] 697 | ("hba".as_bytes(), "val2".as_bytes(), ValueType::TypeValue), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"hba"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:697:32 [INFO] [stderr] | [INFO] [stderr] 697 | ("hba".as_bytes(), "val2".as_bytes(), ValueType::TypeValue), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"val2"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:701:14 [INFO] [stderr] | [INFO] [stderr] 701 | ("iaa".as_bytes(), "val1".as_bytes(), ValueType::TypeValue), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"iaa"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:701:32 [INFO] [stderr] | [INFO] [stderr] 701 | ("iaa".as_bytes(), "val1".as_bytes(), ValueType::TypeValue), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"val1"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:702:14 [INFO] [stderr] | [INFO] [stderr] 702 | ("iba".as_bytes(), "val2".as_bytes(), ValueType::TypeValue), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"iba"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:702:32 [INFO] [stderr] | [INFO] [stderr] 702 | ("iba".as_bytes(), "val2".as_bytes(), ValueType::TypeValue), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"val2"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: the loop variable `l` is used to index `expected_entries` [INFO] [stderr] --> src/version.rs:732:18 [INFO] [stderr] | [INFO] [stderr] 732 | for l in 1..4 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 732 | for (l, ) in expected_entries.iter().enumerate().take(4).skip(1) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:763:35 [INFO] [stderr] | [INFO] [stderr] 763 | let init = LookupKey::new("000".as_bytes(), MAX_SEQUENCE_NUMBER); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"000"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/version.rs:783:20 [INFO] [stderr] | [INFO] [stderr] 783 | let cases: &[(&[u8], u64, Result>>)] = &[ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:784:14 [INFO] [stderr] | [INFO] [stderr] 784 | ("aaa".as_bytes(), 1, Ok(None)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"aaa"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:785:14 [INFO] [stderr] | [INFO] [stderr] 785 | ("aaa".as_bytes(), 100, Ok(Some("val1".as_bytes().to_vec()))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"aaa"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:785:45 [INFO] [stderr] | [INFO] [stderr] 785 | ("aaa".as_bytes(), 100, Ok(Some("val1".as_bytes().to_vec()))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"val1"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:786:14 [INFO] [stderr] | [INFO] [stderr] 786 | ("aaa".as_bytes(), 21, Ok(Some("val0".as_bytes().to_vec()))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"aaa"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:786:44 [INFO] [stderr] | [INFO] [stderr] 786 | ("aaa".as_bytes(), 21, Ok(Some("val0".as_bytes().to_vec()))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"val0"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:787:14 [INFO] [stderr] | [INFO] [stderr] 787 | ("aab".as_bytes(), 0, Ok(None)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"aab"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:788:14 [INFO] [stderr] | [INFO] [stderr] 788 | ("aab".as_bytes(), 100, Ok(Some("val2".as_bytes().to_vec()))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"aab"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:788:45 [INFO] [stderr] | [INFO] [stderr] 788 | ("aab".as_bytes(), 100, Ok(Some("val2".as_bytes().to_vec()))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"val2"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:789:14 [INFO] [stderr] | [INFO] [stderr] 789 | ("aac".as_bytes(), 100, Ok(None)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"aac"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:790:14 [INFO] [stderr] | [INFO] [stderr] 790 | ("aac".as_bytes(), 25, Ok(Some("val3".as_bytes().to_vec()))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"aac"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:790:44 [INFO] [stderr] | [INFO] [stderr] 790 | ("aac".as_bytes(), 25, Ok(Some("val3".as_bytes().to_vec()))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"val3"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:791:14 [INFO] [stderr] | [INFO] [stderr] 791 | ("aba".as_bytes(), 100, Ok(Some("val3".as_bytes().to_vec()))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"aba"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:791:45 [INFO] [stderr] | [INFO] [stderr] 791 | ("aba".as_bytes(), 100, Ok(Some("val3".as_bytes().to_vec()))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"val3"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:792:14 [INFO] [stderr] | [INFO] [stderr] 792 | ("aba".as_bytes(), 25, Ok(Some("val4".as_bytes().to_vec()))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"aba"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:792:44 [INFO] [stderr] | [INFO] [stderr] 792 | ("aba".as_bytes(), 25, Ok(Some("val4".as_bytes().to_vec()))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"val4"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:793:14 [INFO] [stderr] | [INFO] [stderr] 793 | ("daa".as_bytes(), 100, Ok(Some("val1".as_bytes().to_vec()))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"daa"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:793:45 [INFO] [stderr] | [INFO] [stderr] 793 | ("daa".as_bytes(), 100, Ok(Some("val1".as_bytes().to_vec()))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"val1"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:794:14 [INFO] [stderr] | [INFO] [stderr] 794 | ("dab".as_bytes(), 1, Ok(None)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"dab"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:795:14 [INFO] [stderr] | [INFO] [stderr] 795 | ("dac".as_bytes(), 100, Ok(None)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"dac"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:796:14 [INFO] [stderr] | [INFO] [stderr] 796 | ("gba".as_bytes(), 100, Ok(Some("val3".as_bytes().to_vec()))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"gba"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:796:45 [INFO] [stderr] | [INFO] [stderr] 796 | ("gba".as_bytes(), 100, Ok(Some("val3".as_bytes().to_vec()))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"val3"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:798:14 [INFO] [stderr] | [INFO] [stderr] 798 | ("gca".as_bytes(), 100, Ok(None)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"gca"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:799:14 [INFO] [stderr] | [INFO] [stderr] 799 | ("gbb".as_bytes(), 100, Ok(None)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"gbb"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/version.rs:802:13 [INFO] [stderr] | [INFO] [stderr] 802 | for ref c in cases { [INFO] [stderr] | ^^^^^ ----- help: try: `let c = &cases;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `ol`. [INFO] [stderr] --> src/version.rs:827:18 [INFO] [stderr] | [INFO] [stderr] 827 | for i in 0..NUM_LEVELS { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 827 | for in ol.iter().take(NUM_LEVELS) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:837:18 [INFO] [stderr] | [INFO] [stderr] 837 | (0, ("000".as_bytes(), "003".as_bytes()), false), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"000"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:837:36 [INFO] [stderr] | [INFO] [stderr] 837 | (0, ("000".as_bytes(), "003".as_bytes()), false), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"003"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:838:18 [INFO] [stderr] | [INFO] [stderr] 838 | (0, ("aa0".as_bytes(), "abx".as_bytes()), true), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"aa0"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:838:36 [INFO] [stderr] | [INFO] [stderr] 838 | (0, ("aa0".as_bytes(), "abx".as_bytes()), true), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abx"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:839:18 [INFO] [stderr] | [INFO] [stderr] 839 | (1, ("012".as_bytes(), "013".as_bytes()), false), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"012"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:839:36 [INFO] [stderr] | [INFO] [stderr] 839 | (1, ("012".as_bytes(), "013".as_bytes()), false), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"013"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:840:18 [INFO] [stderr] | [INFO] [stderr] 840 | (1, ("abc".as_bytes(), "def".as_bytes()), true), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abc"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:840:36 [INFO] [stderr] | [INFO] [stderr] 840 | (1, ("abc".as_bytes(), "def".as_bytes()), true), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"def"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:841:18 [INFO] [stderr] | [INFO] [stderr] 841 | (2, ("xxx".as_bytes(), "xyz".as_bytes()), false), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"xxx"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:841:36 [INFO] [stderr] | [INFO] [stderr] 841 | (2, ("xxx".as_bytes(), "xyz".as_bytes()), false), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"xyz"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:842:18 [INFO] [stderr] | [INFO] [stderr] 842 | (2, ("gac".as_bytes(), "gaz".as_bytes()), true), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"gac"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:842:36 [INFO] [stderr] | [INFO] [stderr] 842 | (2, ("gac".as_bytes(), "gaz".as_bytes()), true), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"gaz"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:857:14 [INFO] [stderr] | [INFO] [stderr] 857 | ("000".as_bytes(), "abc".as_bytes(), 0), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"000"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:857:32 [INFO] [stderr] | [INFO] [stderr] 857 | ("000".as_bytes(), "abc".as_bytes(), 0), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abc"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:858:14 [INFO] [stderr] | [INFO] [stderr] 858 | ("gab".as_bytes(), "hhh".as_bytes(), 1), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"gab"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:858:32 [INFO] [stderr] | [INFO] [stderr] 858 | ("gab".as_bytes(), "hhh".as_bytes(), 1), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"hhh"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:859:14 [INFO] [stderr] | [INFO] [stderr] 859 | ("000".as_bytes(), "111".as_bytes(), 2), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"000"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:859:32 [INFO] [stderr] | [INFO] [stderr] 859 | ("000".as_bytes(), "111".as_bytes(), 2), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"111"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:873:39 [INFO] [stderr] | [INFO] [stderr] 873 | let from = LookupKey::new("aab".as_bytes(), MAX_SEQUENCE_NUMBER); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"aab"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:874:37 [INFO] [stderr] | [INFO] [stderr] 874 | let to = LookupKey::new("aae".as_bytes(), 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"aae"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:881:39 [INFO] [stderr] | [INFO] [stderr] 881 | let from = LookupKey::new("cab".as_bytes(), MAX_SEQUENCE_NUMBER); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"cab"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:882:37 [INFO] [stderr] | [INFO] [stderr] 882 | let to = LookupKey::new("cbx".as_bytes(), 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"cbx"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:889:39 [INFO] [stderr] | [INFO] [stderr] 889 | let from = LookupKey::new("cab".as_bytes(), MAX_SEQUENCE_NUMBER); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"cab"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:890:37 [INFO] [stderr] | [INFO] [stderr] 890 | let to = LookupKey::new("ebx".as_bytes(), 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"ebx"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:899:39 [INFO] [stderr] | [INFO] [stderr] 899 | let from = LookupKey::new("hhh".as_bytes(), MAX_SEQUENCE_NUMBER); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"hhh"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:900:37 [INFO] [stderr] | [INFO] [stderr] 900 | let to = LookupKey::new("ijk".as_bytes(), 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"ijk"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:911:32 [INFO] [stderr] | [INFO] [stderr] 911 | let k = LookupKey::new("aab".as_bytes(), MAX_SEQUENCE_NUMBER); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"aab"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version.rs:912:42 [INFO] [stderr] | [INFO] [stderr] 912 | let only_in_one = LookupKey::new("cax".as_bytes(), MAX_SEQUENCE_NUMBER); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"cax"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `version_edit::VersionEdit` [INFO] [stderr] --> src/version_edit.rs:74:5 [INFO] [stderr] | [INFO] [stderr] 74 | / pub fn new() -> VersionEdit { [INFO] [stderr] 75 | | VersionEdit { [INFO] [stderr] 76 | | comparator: None, [INFO] [stderr] 77 | | log_number: None, [INFO] [stderr] ... | [INFO] [stderr] 84 | | } [INFO] [stderr] 85 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 61 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/version_edit.rs:135:13 [INFO] [stderr] | [INFO] [stderr] 135 | buf.write(cmp.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/version_edit.rs:162:13 [INFO] [stderr] | [INFO] [stderr] 162 | buf.write(cptr.key.as_ref()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/version_edit.rs:178:13 [INFO] [stderr] | [INFO] [stderr] 178 | buf.write(nf.1.smallest.as_ref()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/version_edit.rs:180:13 [INFO] [stderr] | [INFO] [stderr] 180 | buf.write(nf.1.largest.as_ref()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/version_set.rs:103:34 [INFO] [stderr] | [INFO] [stderr] 103 | pub fn is_base_level_for<'a>(&mut self, k: UserKey<'a>) -> bool { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/version_set.rs:532:13 [INFO] [stderr] | [INFO] [stderr] 532 | / let score: f64; [INFO] [stderr] 533 | | if l == 0 { [INFO] [stderr] 534 | | score = v.files[l].len() as f64 / 4.0; [INFO] [stderr] 535 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 540 | | score = total_size(v.files[l].iter()) as f64 / max_bytes; [INFO] [stderr] 541 | | } [INFO] [stderr] | |_____________^ help: it is more idiomatic to write: `let score = if l == 0 { v.files[l].len() as f64 / 4.0 } else { ..; total_size(v.files[l].iter()) as f64 / max_bytes };` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/version_set.rs:860:31 [INFO] [stderr] | [INFO] [stderr] 860 | pub fn read_current_file(env: &Box, dbname: &Path) -> Result { [INFO] [stderr] | ^^^^^^^^^ help: try: `&Env` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/version_set.rs:874:10 [INFO] [stderr] | [INFO] [stderr] 874 | env: &Box, [INFO] [stderr] | ^^^^^^^^^ help: try: `&Env` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/version_set.rs:883:9 [INFO] [stderr] | [INFO] [stderr] 883 | f.write(manifest_base.as_os_str().as_bytes())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/version_set.rs:884:9 [INFO] [stderr] | [INFO] [stderr] 884 | f.write("\n".as_bytes())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/version_set.rs:890:20 [INFO] [stderr] | [INFO] [stderr] 890 | return Err(Status::from(e)); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider removing `Status::from()`: `e` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version_set.rs:982:23 [INFO] [stderr] | [INFO] [stderr] 982 | f1.smallest = "f".as_bytes().to_vec(); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"f"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version_set.rs:983:22 [INFO] [stderr] | [INFO] [stderr] 983 | f1.largest = "g".as_bytes().to_vec(); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"g"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version_set.rs:987:23 [INFO] [stderr] | [INFO] [stderr] 987 | f2.smallest = "e".as_bytes().to_vec(); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"e"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version_set.rs:988:22 [INFO] [stderr] | [INFO] [stderr] 988 | f2.largest = "f".as_bytes().to_vec(); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"f"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version_set.rs:992:23 [INFO] [stderr] | [INFO] [stderr] 992 | f3.smallest = "a".as_bytes().to_vec(); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"a"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version_set.rs:993:22 [INFO] [stderr] | [INFO] [stderr] 993 | f3.largest = "b".as_bytes().to_vec(); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"b"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version_set.rs:997:23 [INFO] [stderr] | [INFO] [stderr] 997 | f4.smallest = "q".as_bytes().to_vec(); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"q"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version_set.rs:998:22 [INFO] [stderr] | [INFO] [stderr] 998 | f4.largest = "z".as_bytes().to_vec(); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"z"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version_set.rs:1022:14 [INFO] [stderr] | [INFO] [stderr] 1022 | ("a".as_bytes().to_vec(), "z".as_bytes().to_vec()), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"a"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version_set.rs:1022:39 [INFO] [stderr] | [INFO] [stderr] 1022 | ("a".as_bytes().to_vec(), "z".as_bytes().to_vec()), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"z"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version_set.rs:1035:39 [INFO] [stderr] | [INFO] [stderr] 1035 | fmd.smallest = LookupKey::new("klm".as_bytes(), 777) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"klm"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version_set.rs:1038:38 [INFO] [stderr] | [INFO] [stderr] 1038 | fmd.largest = LookupKey::new("kop".as_bytes(), 700) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"kop"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version_set.rs:1047:50 [INFO] [stderr] | [INFO] [stderr] 1047 | ve.set_compact_pointer(2, LookupKey::new("xxx".as_bytes(), 123).internal_key()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"xxx"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version_set.rs:1117:43 [INFO] [stderr] | [INFO] [stderr] 1117 | fmd.smallest = LookupKey::new("abc".as_bytes(), 777) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abc"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version_set.rs:1120:42 [INFO] [stderr] | [INFO] [stderr] 1120 | fmd.largest = LookupKey::new("def".as_bytes(), 700) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"def"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version_set.rs:1228:58 [INFO] [stderr] | [INFO] [stderr] 1228 | vs.approximate_offset(&v, LookupKey::new("aaa".as_bytes(), 9000).internal_key()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"aaa"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version_set.rs:1232:58 [INFO] [stderr] | [INFO] [stderr] 1232 | vs.approximate_offset(&v, LookupKey::new("bab".as_bytes(), 9000).internal_key()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"bab"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version_set.rs:1236:58 [INFO] [stderr] | [INFO] [stderr] 1236 | vs.approximate_offset(&v, LookupKey::new("fab".as_bytes(), 9000).internal_key()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"fab"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version_set.rs:1244:39 [INFO] [stderr] | [INFO] [stderr] 1244 | let from = LookupKey::new("000".as_bytes(), 1000); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"000"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version_set.rs:1245:37 [INFO] [stderr] | [INFO] [stderr] 1245 | let to = LookupKey::new("ab".as_bytes(), 1010); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"ab"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version_set.rs:1253:39 [INFO] [stderr] | [INFO] [stderr] 1253 | let from = LookupKey::new("000".as_bytes(), 1000); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"000"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version_set.rs:1254:37 [INFO] [stderr] | [INFO] [stderr] 1254 | let to = LookupKey::new("zzz".as_bytes(), 1010); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"zzz"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version_set.rs:1267:39 [INFO] [stderr] | [INFO] [stderr] 1267 | let from = LookupKey::new("dab".as_bytes(), 1000); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"dab"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version_set.rs:1268:37 [INFO] [stderr] | [INFO] [stderr] 1268 | let to = LookupKey::new("eab".as_bytes(), 1010); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"eab"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version_set.rs:1281:39 [INFO] [stderr] | [INFO] [stderr] 1281 | let from = LookupKey::new("fab".as_bytes(), 1000); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"fab"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version_set.rs:1282:37 [INFO] [stderr] | [INFO] [stderr] 1282 | let to = LookupKey::new("fba".as_bytes(), 1010); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"fba"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version_set.rs:1290:39 [INFO] [stderr] | [INFO] [stderr] 1290 | let from = LookupKey::new("000".as_bytes(), 1000); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"000"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version_set.rs:1291:37 [INFO] [stderr] | [INFO] [stderr] 1291 | let to = LookupKey::new("zzz".as_bytes(), 1010); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"zzz"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version_set.rs:1292:38 [INFO] [stderr] | [INFO] [stderr] 1292 | let mid = LookupKey::new("abc".as_bytes(), 1010); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abc"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version_set.rs:1300:39 [INFO] [stderr] | [INFO] [stderr] 1300 | let from = LookupKey::new("000".as_bytes(), 1000); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"000"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version_set.rs:1301:37 [INFO] [stderr] | [INFO] [stderr] 1301 | let to = LookupKey::new("zzz".as_bytes(), 1010); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"zzz"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version_set.rs:1304:41 [INFO] [stderr] | [INFO] [stderr] 1304 | assert!(c.is_base_level_for("aaa".as_bytes())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"aaa"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version_set.rs:1305:42 [INFO] [stderr] | [INFO] [stderr] 1305 | assert!(!c.is_base_level_for("hac".as_bytes())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"hac"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version_set.rs:1308:39 [INFO] [stderr] | [INFO] [stderr] 1308 | let from = LookupKey::new("000".as_bytes(), 1000); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"000"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/version_set.rs:1309:37 [INFO] [stderr] | [INFO] [stderr] 1309 | let to = LookupKey::new("zzz".as_bytes(), 1010); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"zzz"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `write_batch::WriteBatch` [INFO] [stderr] --> src/write_batch.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | / pub fn new() -> WriteBatch { [INFO] [stderr] 23 | | let mut v = Vec::with_capacity(128); [INFO] [stderr] 24 | | v.resize(HEADER_SIZE, 0); [INFO] [stderr] 25 | | [INFO] [stderr] 26 | | WriteBatch { entries: v } [INFO] [stderr] 27 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 17 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/write_batch.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | self.entries.write(&[ValueType::TypeValue as u8]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/write_batch.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | self.entries.write(k).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/write_batch.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | self.entries.write(v).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/write_batch.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | / self.entries [INFO] [stderr] 52 | | .write(&[ValueType::TypeDeletion as u8]) [INFO] [stderr] 53 | | .unwrap(); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/write_batch.rs:55:9 [INFO] [stderr] | [INFO] [stderr] 55 | self.entries.write(k).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/write_batch.rs:87:5 [INFO] [stderr] | [INFO] [stderr] 87 | / pub fn iter<'a>(&'a self) -> WriteBatchIter<'a> { [INFO] [stderr] 88 | | WriteBatchIter { [INFO] [stderr] 89 | | batch: self, [INFO] [stderr] 90 | | ix: HEADER_SIZE, [INFO] [stderr] 91 | | } [INFO] [stderr] 92 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/write_batch.rs:98:65 [INFO] [stderr] | [INFO] [stderr] 98 | None => mt.add(seq, ValueType::TypeDeletion, k, "".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b""` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/write_batch.rs:153:14 [INFO] [stderr] | [INFO] [stderr] 153 | ("abc".as_bytes(), "def".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abc"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/write_batch.rs:153:32 [INFO] [stderr] | [INFO] [stderr] 153 | ("abc".as_bytes(), "def".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"def"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/write_batch.rs:154:14 [INFO] [stderr] | [INFO] [stderr] 154 | ("123".as_bytes(), "456".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"123"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/write_batch.rs:154:32 [INFO] [stderr] | [INFO] [stderr] 154 | ("123".as_bytes(), "456".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"456"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/write_batch.rs:155:14 [INFO] [stderr] | [INFO] [stderr] 155 | ("xxx".as_bytes(), "yyy".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"xxx"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/write_batch.rs:155:32 [INFO] [stderr] | [INFO] [stderr] 155 | ("xxx".as_bytes(), "yyy".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"yyy"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/write_batch.rs:156:14 [INFO] [stderr] | [INFO] [stderr] 156 | ("zzz".as_bytes(), "".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"zzz"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/write_batch.rs:156:32 [INFO] [stderr] | [INFO] [stderr] 156 | ("zzz".as_bytes(), "".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b""` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/write_batch.rs:157:14 [INFO] [stderr] | [INFO] [stderr] 157 | ("010".as_bytes(), "".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"010"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/write_batch.rs:157:32 [INFO] [stderr] | [INFO] [stderr] 157 | ("010".as_bytes(), "".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b""` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/db_impl.rs:257:47 [INFO] [stderr] | [INFO] [stderr] 257 | let last_seq = batch.sequence() + batch.count() as u64 - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(batch.count())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/db_impl.rs:387:23 [INFO] [stderr] | [INFO] [stderr] 387 | let entries = batch.count() as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(batch.count())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/db_impl.rs:551:39 [INFO] [stderr] | [INFO] [stderr] 551 | } else if self.mem.len() == 0 { [INFO] [stderr] | _______________________________________^ [INFO] [stderr] 552 | | Ok(()) [INFO] [stderr] 553 | | } else { [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/db_impl.rs:549:79 [INFO] [stderr] | [INFO] [stderr] 549 | if !force && self.mem.approx_mem_usage() < self.opt.write_buffer_size { [INFO] [stderr] | _______________________________________________________________________________^ [INFO] [stderr] 550 | | Ok(()) [INFO] [stderr] 551 | | } else if self.mem.len() == 0 { [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/db_impl.rs:615:18 [INFO] [stderr] | [INFO] [stderr] 615 | for l in 0..max_level + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: use: `0..=max_level` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/db_impl.rs:960:48 [INFO] [stderr] | [INFO] [stderr] 960 | fn cleanup>(&mut self, env: &Box, name: P) { [INFO] [stderr] | ^^^^^^^^^ help: try: `&Env` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/db_impl.rs:1162:17 [INFO] [stderr] | [INFO] [stderr] 1162 | "looooongval".as_bytes(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"looooongval"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/db_impl.rs:1209:20 [INFO] [stderr] | [INFO] [stderr] 1209 | db.put("abc".as_bytes(), "def".as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abc"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/db_impl.rs:1209:38 [INFO] [stderr] | [INFO] [stderr] 1209 | db.put("abc".as_bytes(), "def".as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"def"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/db_impl.rs:1210:20 [INFO] [stderr] | [INFO] [stderr] 1210 | db.put("abd".as_bytes(), "def".as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abd"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/db_impl.rs:1210:38 [INFO] [stderr] | [INFO] [stderr] 1210 | db.put("abd".as_bytes(), "def".as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"def"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/db_impl.rs:1240:17 [INFO] [stderr] | [INFO] [stderr] 1240 | "def".as_bytes(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"def"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/db_impl.rs:1243:41 [INFO] [stderr] | [INFO] [stderr] 1243 | .get(LookupKey::new("abc".as_bytes(), 1).internal_key()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abc"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/db_impl.rs:1249:20 [INFO] [stderr] | [INFO] [stderr] 1249 | db.put("abe".as_bytes(), "def".as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abe"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/db_impl.rs:1249:38 [INFO] [stderr] | [INFO] [stderr] 1249 | db.put("abe".as_bytes(), "def".as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"def"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/db_impl.rs:1276:17 [INFO] [stderr] | [INFO] [stderr] 1276 | "def".as_bytes(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"def"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/db_impl.rs:1278:42 [INFO] [stderr] | [INFO] [stderr] 1278 | .get(&LookupKey::new("abe".as_bytes(), 3)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abe"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/db_impl.rs:1381:28 [INFO] [stderr] | [INFO] [stderr] 1381 | LookupKey::new("aabc".as_bytes(), 6).internal_key(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"aabc"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/db_impl.rs:1385:28 [INFO] [stderr] | [INFO] [stderr] 1385 | LookupKey::new("test123".as_bytes(), 7).internal_key(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"test123"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/db_impl.rs:1443:16 [INFO] [stderr] | [INFO] [stderr] 1443 | db.put("xyy".as_bytes(), "123".as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"xyy"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/db_impl.rs:1443:34 [INFO] [stderr] | [INFO] [stderr] 1443 | db.put("xyy".as_bytes(), "123".as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"123"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/db_impl.rs:1446:16 [INFO] [stderr] | [INFO] [stderr] 1446 | db.put("xyz".as_bytes(), "123".as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"xyz"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/db_impl.rs:1446:34 [INFO] [stderr] | [INFO] [stderr] 1446 | db.put("xyz".as_bytes(), "123".as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"123"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/db_impl.rs:1448:36 [INFO] [stderr] | [INFO] [stderr] 1448 | assert!(db.get_at(&old_ss, "xyy".as_bytes()).unwrap().is_some()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"xyy"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/db_impl.rs:1449:36 [INFO] [stderr] | [INFO] [stderr] 1449 | assert!(db.get_at(&old_ss, "xyz".as_bytes()).unwrap().is_none()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"xyz"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/db_impl.rs:1453:13 [INFO] [stderr] | [INFO] [stderr] 1453 | "123".as_bytes(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"123"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/db_impl.rs:1454:20 [INFO] [stderr] | [INFO] [stderr] 1454 | db.get("xyz".as_bytes()).unwrap().as_slice() [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"xyz"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/db_impl.rs:1456:37 [INFO] [stderr] | [INFO] [stderr] 1456 | assert!(db.get_internal(31, "xyy".as_bytes()).unwrap().is_some()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"xyy"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/db_impl.rs:1457:37 [INFO] [stderr] | [INFO] [stderr] 1457 | assert!(db.get_internal(32, "xyy".as_bytes()).unwrap().is_some()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"xyy"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/db_impl.rs:1459:37 [INFO] [stderr] | [INFO] [stderr] 1459 | assert!(db.get_internal(31, "xyz".as_bytes()).unwrap().is_none()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"xyz"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/db_impl.rs:1460:37 [INFO] [stderr] | [INFO] [stderr] 1460 | assert!(db.get_internal(32, "xyz".as_bytes()).unwrap().is_some()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"xyz"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/db_impl.rs:1464:13 [INFO] [stderr] | [INFO] [stderr] 1464 | "val2".as_bytes(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"val2"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/db_impl.rs:1465:20 [INFO] [stderr] | [INFO] [stderr] 1465 | db.get("eab".as_bytes()).unwrap().as_slice() [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"eab"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/db_impl.rs:1467:36 [INFO] [stderr] | [INFO] [stderr] 1467 | assert!(db.get_internal(3, "eab".as_bytes()).unwrap().is_none()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"eab"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/db_impl.rs:1468:37 [INFO] [stderr] | [INFO] [stderr] 1468 | assert!(db.get_internal(32, "eab".as_bytes()).unwrap().is_some()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"eab"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/db_impl.rs:1473:17 [INFO] [stderr] | [INFO] [stderr] 1473 | "val2".as_bytes(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"val2"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/db_impl.rs:1474:32 [INFO] [stderr] | [INFO] [stderr] 1474 | db.get_at(&ss, "eab".as_bytes()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"eab"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/db_impl.rs:1483:13 [INFO] [stderr] | [INFO] [stderr] 1483 | "val2".as_bytes(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"val2"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/db_impl.rs:1484:20 [INFO] [stderr] | [INFO] [stderr] 1484 | db.get("cab".as_bytes()).unwrap().as_slice() [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"cab"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/db_impl.rs:1525:16 [INFO] [stderr] | [INFO] [stderr] 1525 | db.put("abc".as_bytes(), "xyz".as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abc"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/db_impl.rs:1525:34 [INFO] [stderr] | [INFO] [stderr] 1525 | db.put("abc".as_bytes(), "xyz".as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"xyz"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/db_impl.rs:1526:16 [INFO] [stderr] | [INFO] [stderr] 1526 | db.put("ab3".as_bytes(), "xyz".as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"ab3"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/db_impl.rs:1526:34 [INFO] [stderr] | [INFO] [stderr] 1526 | db.put("ab3".as_bytes(), "xyz".as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"xyz"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/db_impl.rs:1527:16 [INFO] [stderr] | [INFO] [stderr] 1527 | db.put("ab0".as_bytes(), "xyz".as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"ab0"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/db_impl.rs:1527:34 [INFO] [stderr] | [INFO] [stderr] 1527 | db.put("ab0".as_bytes(), "xyz".as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"xyz"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/db_impl.rs:1528:16 [INFO] [stderr] | [INFO] [stderr] 1528 | db.put("abz".as_bytes(), "xyz".as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abz"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/db_impl.rs:1528:34 [INFO] [stderr] | [INFO] [stderr] 1528 | db.put("abz".as_bytes(), "xyz".as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"xyz"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/db_impl.rs:1625:21 [INFO] [stderr] | [INFO] [stderr] 1625 | let stuff = "abcdefghijkl".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abcdefghijkl"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/db_iter.rs:62:27 [INFO] [stderr] | [INFO] [stderr] 62 | fn record_read_sample<'a>(&mut self, len: usize) { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] error: aborting due to 24 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rusty-leveldb`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "9f9330f8b569e86160b03ed1c4c814ffa5ec8bb6b4694f882eb286bd9856dc9d"` [INFO] running `"docker" "rm" "-f" "9f9330f8b569e86160b03ed1c4c814ffa5ec8bb6b4694f882eb286bd9856dc9d"` [INFO] [stdout] 9f9330f8b569e86160b03ed1c4c814ffa5ec8bb6b4694f882eb286bd9856dc9d