[INFO] crate rusty-hash 1.1.0 is already in cache
[INFO] extracting crate rusty-hash 1.1.0 into work/ex/clippy-test-run/sources/stable/reg/rusty-hash/1.1.0
[INFO] extracting crate rusty-hash 1.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rusty-hash/1.1.0
[INFO] validating manifest of rusty-hash-1.1.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of rusty-hash-1.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing rusty-hash-1.1.0
[INFO] finished frobbing rusty-hash-1.1.0
[INFO] frobbed toml for rusty-hash-1.1.0 written to work/ex/clippy-test-run/sources/stable/reg/rusty-hash/1.1.0/Cargo.toml
[INFO] started frobbing rusty-hash-1.1.0
[INFO] finished frobbing rusty-hash-1.1.0
[INFO] frobbed toml for rusty-hash-1.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rusty-hash/1.1.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting rusty-hash-1.1.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rusty-hash/1.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 09928828f59004623121eed8e8131dbe7d3d6dda2deb4413ee46a75b369d2a42
[INFO] running `"docker" "start" "-a" "09928828f59004623121eed8e8131dbe7d3d6dda2deb4413ee46a75b369d2a42"`
[INFO] [stderr] Checking rusty-hash v1.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary
[INFO] [stderr] --> src/checksum.rs:66:5
[INFO] [stderr] |
[INFO] [stderr] 66 | / fn ne(&self, right: &Checksum) -> bool {
[INFO] [stderr] 67 | | self.name != right.name
[INFO] [stderr] 68 | | }
[INFO] [stderr] | |_____^
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::partialeq_ne_impl)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl
[INFO] [stderr]
[INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary
[INFO] [stderr] --> src/checksum.rs:66:5
[INFO] [stderr] |
[INFO] [stderr] 66 | / fn ne(&self, right: &Checksum) -> bool {
[INFO] [stderr] 67 | | self.name != right.name
[INFO] [stderr] 68 | | }
[INFO] [stderr] | |_____^
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::partialeq_ne_impl)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl
[INFO] [stderr]
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr] --> src/main.rs:196:5
[INFO] [stderr] |
[INFO] [stderr] 196 | println!("");
[INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr]
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr] --> src/main.rs:208:5
[INFO] [stderr] |
[INFO] [stderr] 208 | println!("");
[INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr]
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr] --> src/main.rs:196:5
[INFO] [stderr] |
[INFO] [stderr] 196 | println!("");
[INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr]
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr] --> src/main.rs:208:5
[INFO] [stderr] |
[INFO] [stderr] 208 | println!("");
[INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr]
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr] --> src/main.rs:18:15
[INFO] [stderr] |
[INFO] [stderr] 18 | const USAGE: &'static str = "Usage: rusty_hash [-c | -o | -p] [algorithms] ...
[INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr]
[INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary
[INFO] [stderr] --> src/checksum.rs:66:5
[INFO] [stderr] |
[INFO] [stderr] 66 | / fn ne(&self, right: &Checksum) -> bool {
[INFO] [stderr] 67 | | self.name != right.name
[INFO] [stderr] 68 | | }
[INFO] [stderr] | |_____^
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::partialeq_ne_impl)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl
[INFO] [stderr]
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr] --> src/main.rs:59:28
[INFO] [stderr] |
[INFO] [stderr] 59 | if arg.starts_with("-") {
[INFO] [stderr] | ^^^ help: try using a char instead: `'-'`
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr]
[INFO] [stderr] warning: the `arg @ _` pattern can be written as just `arg`
[INFO] [stderr] --> src/main.rs:67:25
[INFO] [stderr] |
[INFO] [stderr] 67 | arg @ _ => {
[INFO] [stderr] | ^^^^^^^
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern
[INFO] [stderr]
[INFO] [stderr] warning: the `arg @ _` pattern can be written as just `arg`
[INFO] [stderr] --> src/main.rs:101:17
[INFO] [stderr] |
[INFO] [stderr] 101 | arg @ _ => {
[INFO] [stderr] | ^^^^^^^
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern
[INFO] [stderr]
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr] --> src/main.rs:115:8
[INFO] [stderr] |
[INFO] [stderr] 115 | if checksums.len() == 0 {
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `checksums.is_empty()`
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr]
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr] --> src/main.rs:129:23
[INFO] [stderr] |
[INFO] [stderr] 129 | fn normal_mode(paths: &Vec, checksums: &mut Vec, flag: FlagType) {
[INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr]
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr] --> src/main.rs:18:15
[INFO] [stderr] |
[INFO] [stderr] 18 | const USAGE: &'static str = "Usage: rusty_hash [-c | -o | -p] [algorithms] ...
[INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr]
[INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary
[INFO] [stderr] --> src/checksum.rs:66:5
[INFO] [stderr] |
[INFO] [stderr] 66 | / fn ne(&self, right: &Checksum) -> bool {
[INFO] [stderr] 67 | | self.name != right.name
[INFO] [stderr] 68 | | }
[INFO] [stderr] | |_____^
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::partialeq_ne_impl)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl
[INFO] [stderr]
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr] --> src/main.rs:59:28
[INFO] [stderr] |
[INFO] [stderr] 59 | if arg.starts_with("-") {
[INFO] [stderr] | ^^^ help: try using a char instead: `'-'`
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr]
[INFO] [stderr] warning: the `arg @ _` pattern can be written as just `arg`
[INFO] [stderr] --> src/main.rs:67:25
[INFO] [stderr] |
[INFO] [stderr] 67 | arg @ _ => {
[INFO] [stderr] | ^^^^^^^
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern
[INFO] [stderr]
[INFO] [stderr] warning: the `arg @ _` pattern can be written as just `arg`
[INFO] [stderr] --> src/main.rs:101:17
[INFO] [stderr] |
[INFO] [stderr] 101 | arg @ _ => {
[INFO] [stderr] | ^^^^^^^
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern
[INFO] [stderr]
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr] --> src/main.rs:115:8
[INFO] [stderr] |
[INFO] [stderr] 115 | if checksums.len() == 0 {
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `checksums.is_empty()`
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr]
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr] --> src/main.rs:129:23
[INFO] [stderr] |
[INFO] [stderr] 129 | fn normal_mode(paths: &Vec, checksums: &mut Vec, flag: FlagType) {
[INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr]
[INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.73s
[INFO] running `"docker" "inspect" "09928828f59004623121eed8e8131dbe7d3d6dda2deb4413ee46a75b369d2a42"`
[INFO] running `"docker" "rm" "-f" "09928828f59004623121eed8e8131dbe7d3d6dda2deb4413ee46a75b369d2a42"`
[INFO] [stdout] 09928828f59004623121eed8e8131dbe7d3d6dda2deb4413ee46a75b369d2a42