[INFO] crate rusty-data 0.0.3 is already in cache [INFO] extracting crate rusty-data 0.0.3 into work/ex/clippy-test-run/sources/stable/reg/rusty-data/0.0.3 [INFO] extracting crate rusty-data 0.0.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rusty-data/0.0.3 [INFO] validating manifest of rusty-data-0.0.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rusty-data-0.0.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rusty-data-0.0.3 [INFO] finished frobbing rusty-data-0.0.3 [INFO] frobbed toml for rusty-data-0.0.3 written to work/ex/clippy-test-run/sources/stable/reg/rusty-data/0.0.3/Cargo.toml [INFO] started frobbing rusty-data-0.0.3 [INFO] finished frobbing rusty-data-0.0.3 [INFO] frobbed toml for rusty-data-0.0.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rusty-data/0.0.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rusty-data-0.0.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rusty-data/0.0.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 55c10946d5f05617398cdc249e769f3758bfd0875ca1234fc9f4b3ccac21c131 [INFO] running `"docker" "start" "-a" "55c10946d5f05617398cdc249e769f3758bfd0875ca1234fc9f4b3ccac21c131"` [INFO] [stderr] Checking rusty-data v0.0.3 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/loader.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | has_header: has_header, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `has_header` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/loader.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | delimiter: delimiter, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `delimiter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/loader.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | file: file, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/loader.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | options: options, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `options` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/loader.rs:156:13 [INFO] [stderr] | [INFO] [stderr] 156 | line: line, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/loader.rs:157:13 [INFO] [stderr] | [INFO] [stderr] 157 | quote_char: quote_char, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `quote_char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/loader.rs:158:13 [INFO] [stderr] | [INFO] [stderr] 158 | delimiter: delimiter, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `delimiter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/loader.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | has_header: has_header, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `has_header` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/loader.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | delimiter: delimiter, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `delimiter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/loader.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | file: file, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/loader.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | options: options, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `options` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/loader.rs:156:13 [INFO] [stderr] | [INFO] [stderr] 156 | line: line, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/loader.rs:157:13 [INFO] [stderr] | [INFO] [stderr] 157 | quote_char: quote_char, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `quote_char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/loader.rs:158:13 [INFO] [stderr] | [INFO] [stderr] 158 | delimiter: delimiter, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `delimiter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/loader.rs:100:16 [INFO] [stderr] | [INFO] [stderr] 100 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 101 | | if let Some(line) = lines.next() { [INFO] [stderr] 102 | | let line = try!(line); [INFO] [stderr] 103 | | let values = LineSplitIter::new(line.to_string(), [INFO] [stderr] ... | [INFO] [stderr] 113 | | } [INFO] [stderr] 114 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 100 | } else if let Some(line) = lines.next() { [INFO] [stderr] 101 | let line = try!(line); [INFO] [stderr] 102 | let values = LineSplitIter::new(line.to_string(), [INFO] [stderr] 103 | self.options.quote_marker, [INFO] [stderr] 104 | self.options.delimiter); [INFO] [stderr] 105 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/loader.rs:100:16 [INFO] [stderr] | [INFO] [stderr] 100 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 101 | | if let Some(line) = lines.next() { [INFO] [stderr] 102 | | let line = try!(line); [INFO] [stderr] 103 | | let values = LineSplitIter::new(line.to_string(), [INFO] [stderr] ... | [INFO] [stderr] 113 | | } [INFO] [stderr] 114 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 100 | } else if let Some(line) = lines.next() { [INFO] [stderr] 101 | let line = try!(line); [INFO] [stderr] 102 | let values = LineSplitIter::new(line.to_string(), [INFO] [stderr] 103 | self.options.quote_marker, [INFO] [stderr] 104 | self.options.delimiter); [INFO] [stderr] 105 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/loader.rs:167:12 [INFO] [stderr] | [INFO] [stderr] 167 | if self.line.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.line.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/loader.rs:180:43 [INFO] [stderr] | [INFO] [stderr] 180 | } else if c == self.delimiter && !in_quotes { [INFO] [stderr] | ___________________________________________^ [INFO] [stderr] 181 | | true [INFO] [stderr] 182 | | } else { [INFO] [stderr] 183 | | false [INFO] [stderr] 184 | | } [INFO] [stderr] | |____________________________________^ help: you can reduce it to: `c == self.delimiter && !in_quotes` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/datatable.rs:35:12 [INFO] [stderr] | [INFO] [stderr] 35 | if self.data_cols.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.data_cols.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `column_iters`. [INFO] [stderr] --> src/datatable.rs:71:26 [INFO] [stderr] | [INFO] [stderr] 71 | for i in 0..cols { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 71 | for in column_iters.iter_mut().take(cols) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: item `datatable::DataColumn` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/datatable.rs:114:1 [INFO] [stderr] | [INFO] [stderr] 114 | / impl DataColumn { [INFO] [stderr] 115 | | /// Constructs an empty data column. [INFO] [stderr] 116 | | pub fn empty() -> DataColumn { [INFO] [stderr] 117 | | DataColumn { [INFO] [stderr] ... | [INFO] [stderr] 293 | | } [INFO] [stderr] 294 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `outer_vec` [INFO] [stderr] --> src/datatable.rs:207:34 [INFO] [stderr] | [INFO] [stderr] 207 | for i in 0..categories.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 207 | for (i, ) in outer_vec.iter_mut().enumerate().take(categories.len()) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/datatable.rs:289:13 [INFO] [stderr] | [INFO] [stderr] 289 | -> std::iter::Map, fn(String) -> Result::Err>> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/datatable.rs:299:9 [INFO] [stderr] | [INFO] [stderr] 299 | -> std::iter::Map::Item) -> Result::Err>> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/error.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | / match self { [INFO] [stderr] 18 | | &DataError::DataCastError => write!(f, "DataCastError"), [INFO] [stderr] 19 | | &DataError::InvalidStateError => write!(f, "InvalidStateError"), [INFO] [stderr] 20 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 17 | match *self { [INFO] [stderr] 18 | DataError::DataCastError => write!(f, "DataCastError"), [INFO] [stderr] 19 | DataError::InvalidStateError => write!(f, "InvalidStateError"), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/error.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | / match self { [INFO] [stderr] 27 | | &DataError::DataCastError => "Failed to cast data.", [INFO] [stderr] 28 | | &DataError::InvalidStateError => "Operation was not valid for state of object.", [INFO] [stderr] 29 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 26 | match *self { [INFO] [stderr] 27 | DataError::DataCastError => "Failed to cast data.", [INFO] [stderr] 28 | DataError::InvalidStateError => "Operation was not valid for state of object.", [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/loader.rs:167:12 [INFO] [stderr] | [INFO] [stderr] 167 | if self.line.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.line.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/loader.rs:180:43 [INFO] [stderr] | [INFO] [stderr] 180 | } else if c == self.delimiter && !in_quotes { [INFO] [stderr] | ___________________________________________^ [INFO] [stderr] 181 | | true [INFO] [stderr] 182 | | } else { [INFO] [stderr] 183 | | false [INFO] [stderr] 184 | | } [INFO] [stderr] | |____________________________________^ help: you can reduce it to: `c == self.delimiter && !in_quotes` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/datatable.rs:35:12 [INFO] [stderr] | [INFO] [stderr] 35 | if self.data_cols.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.data_cols.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `column_iters`. [INFO] [stderr] --> src/datatable.rs:71:26 [INFO] [stderr] | [INFO] [stderr] 71 | for i in 0..cols { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 71 | for in column_iters.iter_mut().take(cols) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: item `datatable::DataColumn` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/datatable.rs:114:1 [INFO] [stderr] | [INFO] [stderr] 114 | / impl DataColumn { [INFO] [stderr] 115 | | /// Constructs an empty data column. [INFO] [stderr] 116 | | pub fn empty() -> DataColumn { [INFO] [stderr] 117 | | DataColumn { [INFO] [stderr] ... | [INFO] [stderr] 293 | | } [INFO] [stderr] 294 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `outer_vec` [INFO] [stderr] --> src/datatable.rs:207:34 [INFO] [stderr] | [INFO] [stderr] 207 | for i in 0..categories.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 207 | for (i, ) in outer_vec.iter_mut().enumerate().take(categories.len()) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/datatable.rs:289:13 [INFO] [stderr] | [INFO] [stderr] 289 | -> std::iter::Map, fn(String) -> Result::Err>> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/datatable.rs:299:9 [INFO] [stderr] | [INFO] [stderr] 299 | -> std::iter::Map::Item) -> Result::Err>> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/error.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | / match self { [INFO] [stderr] 18 | | &DataError::DataCastError => write!(f, "DataCastError"), [INFO] [stderr] 19 | | &DataError::InvalidStateError => write!(f, "InvalidStateError"), [INFO] [stderr] 20 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 17 | match *self { [INFO] [stderr] 18 | DataError::DataCastError => write!(f, "DataCastError"), [INFO] [stderr] 19 | DataError::InvalidStateError => write!(f, "InvalidStateError"), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/error.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | / match self { [INFO] [stderr] 27 | | &DataError::DataCastError => "Failed to cast data.", [INFO] [stderr] 28 | | &DataError::InvalidStateError => "Operation was not valid for state of object.", [INFO] [stderr] 29 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 26 | match *self { [INFO] [stderr] 27 | DataError::DataCastError => "Failed to cast data.", [INFO] [stderr] 28 | DataError::InvalidStateError => "Operation was not valid for state of object.", [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.07s [INFO] running `"docker" "inspect" "55c10946d5f05617398cdc249e769f3758bfd0875ca1234fc9f4b3ccac21c131"` [INFO] running `"docker" "rm" "-f" "55c10946d5f05617398cdc249e769f3758bfd0875ca1234fc9f4b3ccac21c131"` [INFO] [stdout] 55c10946d5f05617398cdc249e769f3758bfd0875ca1234fc9f4b3ccac21c131