[INFO] crate rusty-blockparser 0.6.1 is already in cache [INFO] extracting crate rusty-blockparser 0.6.1 into work/ex/clippy-test-run/sources/stable/reg/rusty-blockparser/0.6.1 [INFO] extracting crate rusty-blockparser 0.6.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rusty-blockparser/0.6.1 [INFO] validating manifest of rusty-blockparser-0.6.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rusty-blockparser-0.6.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rusty-blockparser-0.6.1 [INFO] finished frobbing rusty-blockparser-0.6.1 [INFO] frobbed toml for rusty-blockparser-0.6.1 written to work/ex/clippy-test-run/sources/stable/reg/rusty-blockparser/0.6.1/Cargo.toml [INFO] started frobbing rusty-blockparser-0.6.1 [INFO] finished frobbing rusty-blockparser-0.6.1 [INFO] frobbed toml for rusty-blockparser-0.6.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rusty-blockparser/0.6.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rusty-blockparser-0.6.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rusty-blockparser/0.6.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d99c8f50d7db9f5cd7cf79b470a54b7b14d8bc061c9bc688a9b6cecdec38b3e7 [INFO] running `"docker" "start" "-a" "d99c8f50d7db9f5cd7cf79b470a54b7b14d8bc061c9bc688a9b6cecdec38b3e7"` [INFO] [stderr] warning: profile `doc` is deprecated and has no effect [INFO] [stderr] Compiling num-traits v0.2.6 [INFO] [stderr] Compiling num-integer v0.1.39 [INFO] [stderr] Compiling num-bigint v0.2.2 [INFO] [stderr] Compiling libc v0.2.48 [INFO] [stderr] Compiling num-complex v0.2.1 [INFO] [stderr] Compiling num-iter v0.1.37 [INFO] [stderr] Compiling num-rational v0.2.1 [INFO] [stderr] Compiling gcc v0.3.55 [INFO] [stderr] Checking unicode-width v0.1.5 [INFO] [stderr] Checking cfg-if v0.1.6 [INFO] [stderr] Checking strsim v0.6.0 [INFO] [stderr] Checking ansi_term v0.9.0 [INFO] [stderr] Checking vec_map v0.8.1 [INFO] [stderr] Checking rustc-serialize v0.3.24 [INFO] [stderr] Checking seek_bufread v1.2.2 [INFO] [stderr] Checking byteorder v1.1.0 [INFO] [stderr] Checking log v0.4.6 [INFO] [stderr] Checking log v0.3.9 [INFO] [stderr] Compiling rust-crypto v0.2.36 [INFO] [stderr] Checking term_size v0.3.1 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking time v0.1.42 [INFO] [stderr] Checking atty v0.2.11 [INFO] [stderr] Checking textwrap v0.8.0 [INFO] [stderr] Checking clap v2.26.2 [INFO] [stderr] Checking rand v0.3.23 [INFO] [stderr] Checking num v0.2.0 [INFO] [stderr] Checking rust-base58 v0.0.4 [INFO] [stderr] Checking rusty-blockparser v0.6.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/errors.rs:45:18 [INFO] [stderr] | [INFO] [stderr] 45 | OpError{ kind: kind, message: String::new() } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockchain/proto/block.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | blk_index: blk_index, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `blk_index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockchain/proto/block.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | blk_offset: blk_offset, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `blk_offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockchain/proto/block.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | blocksize: blocksize, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `blocksize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockchain/proto/block.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | tx_count: tx_count, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `tx_count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockchain/proto/header.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | version: version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockchain/proto/header.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | prev_hash: prev_hash, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `prev_hash` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockchain/proto/header.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | merkle_root: merkle_root, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `merkle_root` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockchain/proto/header.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | timestamp: timestamp, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `timestamp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockchain/proto/header.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | bits: bits, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `bits` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockchain/proto/header.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | nonce: nonce [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `nonce` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockchain/proto/tx.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | tx_version: tx_version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `tx_version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockchain/proto/tx.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | in_count: in_count, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `in_count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockchain/proto/tx.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | out_count: out_count, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `out_count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockchain/proto/tx.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | tx_locktime: tx_locktime, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `tx_locktime` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockchain/proto/tx.rs:154:13 [INFO] [stderr] | [INFO] [stderr] 154 | out: out [INFO] [stderr] | ^^^^^^^^ help: replace it with: `out` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockchain/proto/varuint.rs:21:40 [INFO] [stderr] | [INFO] [stderr] 21 | VarUint { value: value as u64, buf: buf } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `buf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockchain/proto/script.rs:180:27 [INFO] [stderr] | [INFO] [stderr] 180 | ScriptEvaluator { bytes: bytes, n_bytes: bytes.len(), ip: 0 } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `bytes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockchain/proto/script.rs:213:20 [INFO] [stderr] | [INFO] [stderr] 213 | Ok(Stack { elements: elements, pattern: pattern }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `elements` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockchain/proto/script.rs:213:40 [INFO] [stderr] | [INFO] [stderr] 213 | Ok(Stack { elements: elements, pattern: pattern }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `pattern` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockchain/proto/mod.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | value: value [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockchain/proto/mod.rs:37:18 [INFO] [stderr] | [INFO] [stderr] 37 | Hashed { hash: hash, value: value } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `hash` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockchain/proto/mod.rs:37:30 [INFO] [stderr] | [INFO] [stderr] 37 | Hashed { hash: hash, value: value } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockchain/parser/worker.rs:46:21 [INFO] [stderr] | [INFO] [stderr] 46 | tx_channel: tx_channel, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `tx_channel` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockchain/parser/worker.rs:47:21 [INFO] [stderr] | [INFO] [stderr] 47 | remaining_files: remaining_files, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `remaining_files` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockchain/parser/worker.rs:48:21 [INFO] [stderr] | [INFO] [stderr] 48 | coin_type: coin_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `coin_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockchain/parser/worker.rs:50:21 [INFO] [stderr] | [INFO] [stderr] 50 | reader: reader, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockchain/parser/worker.rs:51:21 [INFO] [stderr] | [INFO] [stderr] 51 | mode: mode, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `mode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockchain/parser/chain.rs:163:38 [INFO] [stderr] | [INFO] [stderr] 163 | let builder = ChainBuilder { header_map: header_map }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `header_map` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockchain/parser/mod.rs:81:13 [INFO] [stderr] | [INFO] [stderr] 81 | options: options, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `options` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockchain/parser/mod.rs:82:13 [INFO] [stderr] | [INFO] [stderr] 82 | chain_storage: chain_storage, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `chain_storage` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockchain/utils/blkfile.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockchain/utils/blkfile.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | index: index, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockchain/utils/blkfile.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockchain/utils/reader.rs:109:17 [INFO] [stderr] | [INFO] [stderr] 109 | outpoint: outpoint, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `outpoint` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockchain/utils/reader.rs:110:17 [INFO] [stderr] | [INFO] [stderr] 110 | script_len: script_len, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `script_len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockchain/utils/reader.rs:111:17 [INFO] [stderr] | [INFO] [stderr] 111 | script_sig: script_sig, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `script_sig` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockchain/utils/reader.rs:112:17 [INFO] [stderr] | [INFO] [stderr] 112 | seq_no: seq_no, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `seq_no` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockchain/utils/reader.rs:127:17 [INFO] [stderr] | [INFO] [stderr] 127 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockchain/utils/reader.rs:128:17 [INFO] [stderr] | [INFO] [stderr] 128 | script_len: script_len, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `script_len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockchain/utils/reader.rs:129:17 [INFO] [stderr] | [INFO] [stderr] 129 | script_pubkey: script_pubkey, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `script_pubkey` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/common.rs:16:41 [INFO] [stderr] | [INFO] [stderr] 16 | Box::new(SimpleLogger { log_filter: log_filter }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `log_filter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(&mut buffer, "")` [INFO] [stderr] --> src/callbacks/stats.rs:130:9 [INFO] [stderr] | [INFO] [stderr] 130 | writeln!(&mut buffer, "").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(&mut buffer)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::writeln_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(&mut buffer, "")` [INFO] [stderr] --> src/callbacks/stats.rs:150:13 [INFO] [stderr] | [INFO] [stderr] 150 | writeln!(&mut buffer, "").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(&mut buffer)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/callbacks/unspentcsvdump.rs:118:4 [INFO] [stderr] | [INFO] [stderr] 118 | block_height: block_height, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `block_height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:267:9 [INFO] [stderr] | [INFO] [stderr] 267 | coin_type: coin_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `coin_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:268:9 [INFO] [stderr] | [INFO] [stderr] 268 | callback: callback, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `callback` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:269:9 [INFO] [stderr] | [INFO] [stderr] 269 | verify_merkle_root: verify_merkle_root, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `verify_merkle_root` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:270:9 [INFO] [stderr] | [INFO] [stderr] 270 | thread_count: thread_count, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `thread_count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:271:9 [INFO] [stderr] | [INFO] [stderr] 271 | resume: resume, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `resume` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:272:9 [INFO] [stderr] | [INFO] [stderr] 272 | reindex: reindex, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `reindex` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:275:9 [INFO] [stderr] | [INFO] [stderr] 275 | worker_backlog: worker_backlog, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `worker_backlog` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:276:9 [INFO] [stderr] | [INFO] [stderr] 276 | log_level_filter: log_level_filter [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `log_level_filter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/errors.rs:45:18 [INFO] [stderr] | [INFO] [stderr] 45 | OpError{ kind: kind, message: String::new() } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockchain/proto/block.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | blk_index: blk_index, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `blk_index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockchain/proto/block.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | blk_offset: blk_offset, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `blk_offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockchain/proto/block.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | blocksize: blocksize, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `blocksize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockchain/proto/block.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | tx_count: tx_count, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `tx_count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockchain/proto/header.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | version: version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockchain/proto/header.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | prev_hash: prev_hash, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `prev_hash` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockchain/proto/header.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | merkle_root: merkle_root, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `merkle_root` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockchain/proto/header.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | timestamp: timestamp, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `timestamp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockchain/proto/header.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | bits: bits, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `bits` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockchain/proto/header.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | nonce: nonce [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `nonce` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockchain/proto/tx.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | tx_version: tx_version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `tx_version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockchain/proto/tx.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | in_count: in_count, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `in_count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockchain/proto/tx.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | out_count: out_count, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `out_count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockchain/proto/tx.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | tx_locktime: tx_locktime, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `tx_locktime` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockchain/proto/tx.rs:154:13 [INFO] [stderr] | [INFO] [stderr] 154 | out: out [INFO] [stderr] | ^^^^^^^^ help: replace it with: `out` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockchain/proto/varuint.rs:21:40 [INFO] [stderr] | [INFO] [stderr] 21 | VarUint { value: value as u64, buf: buf } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `buf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockchain/proto/script.rs:180:27 [INFO] [stderr] | [INFO] [stderr] 180 | ScriptEvaluator { bytes: bytes, n_bytes: bytes.len(), ip: 0 } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `bytes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockchain/proto/script.rs:213:20 [INFO] [stderr] | [INFO] [stderr] 213 | Ok(Stack { elements: elements, pattern: pattern }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `elements` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockchain/proto/script.rs:213:40 [INFO] [stderr] | [INFO] [stderr] 213 | Ok(Stack { elements: elements, pattern: pattern }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `pattern` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockchain/proto/mod.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | value: value [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockchain/proto/mod.rs:37:18 [INFO] [stderr] | [INFO] [stderr] 37 | Hashed { hash: hash, value: value } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `hash` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockchain/proto/mod.rs:37:30 [INFO] [stderr] | [INFO] [stderr] 37 | Hashed { hash: hash, value: value } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockchain/parser/worker.rs:46:21 [INFO] [stderr] | [INFO] [stderr] 46 | tx_channel: tx_channel, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `tx_channel` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockchain/parser/worker.rs:47:21 [INFO] [stderr] | [INFO] [stderr] 47 | remaining_files: remaining_files, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `remaining_files` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockchain/parser/worker.rs:48:21 [INFO] [stderr] | [INFO] [stderr] 48 | coin_type: coin_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `coin_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockchain/parser/worker.rs:50:21 [INFO] [stderr] | [INFO] [stderr] 50 | reader: reader, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockchain/parser/worker.rs:51:21 [INFO] [stderr] | [INFO] [stderr] 51 | mode: mode, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `mode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockchain/parser/chain.rs:163:38 [INFO] [stderr] | [INFO] [stderr] 163 | let builder = ChainBuilder { header_map: header_map }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `header_map` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockchain/parser/mod.rs:81:13 [INFO] [stderr] | [INFO] [stderr] 81 | options: options, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `options` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockchain/parser/mod.rs:82:13 [INFO] [stderr] | [INFO] [stderr] 82 | chain_storage: chain_storage, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `chain_storage` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockchain/utils/blkfile.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockchain/utils/blkfile.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | index: index, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockchain/utils/blkfile.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockchain/utils/reader.rs:109:17 [INFO] [stderr] | [INFO] [stderr] 109 | outpoint: outpoint, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `outpoint` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockchain/utils/reader.rs:110:17 [INFO] [stderr] | [INFO] [stderr] 110 | script_len: script_len, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `script_len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockchain/utils/reader.rs:111:17 [INFO] [stderr] | [INFO] [stderr] 111 | script_sig: script_sig, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `script_sig` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockchain/utils/reader.rs:112:17 [INFO] [stderr] | [INFO] [stderr] 112 | seq_no: seq_no, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `seq_no` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockchain/utils/reader.rs:127:17 [INFO] [stderr] | [INFO] [stderr] 127 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockchain/utils/reader.rs:128:17 [INFO] [stderr] | [INFO] [stderr] 128 | script_len: script_len, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `script_len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockchain/utils/reader.rs:129:17 [INFO] [stderr] | [INFO] [stderr] 129 | script_pubkey: script_pubkey, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `script_pubkey` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/common.rs:16:41 [INFO] [stderr] | [INFO] [stderr] 16 | Box::new(SimpleLogger { log_filter: log_filter }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `log_filter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(&mut buffer, "")` [INFO] [stderr] --> src/callbacks/stats.rs:130:9 [INFO] [stderr] | [INFO] [stderr] 130 | writeln!(&mut buffer, "").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(&mut buffer)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::writeln_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(&mut buffer, "")` [INFO] [stderr] --> src/callbacks/stats.rs:150:13 [INFO] [stderr] | [INFO] [stderr] 150 | writeln!(&mut buffer, "").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(&mut buffer)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/callbacks/unspentcsvdump.rs:118:4 [INFO] [stderr] | [INFO] [stderr] 118 | block_height: block_height, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `block_height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:267:9 [INFO] [stderr] | [INFO] [stderr] 267 | coin_type: coin_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `coin_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:268:9 [INFO] [stderr] | [INFO] [stderr] 268 | callback: callback, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `callback` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:269:9 [INFO] [stderr] | [INFO] [stderr] 269 | verify_merkle_root: verify_merkle_root, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `verify_merkle_root` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:270:9 [INFO] [stderr] | [INFO] [stderr] 270 | thread_count: thread_count, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `thread_count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:271:9 [INFO] [stderr] | [INFO] [stderr] 271 | resume: resume, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `resume` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:272:9 [INFO] [stderr] | [INFO] [stderr] 272 | reindex: reindex, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `reindex` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:275:9 [INFO] [stderr] | [INFO] [stderr] 275 | worker_backlog: worker_backlog, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `worker_backlog` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:276:9 [INFO] [stderr] | [INFO] [stderr] 276 | log_level_filter: log_level_filter [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `log_level_filter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blockchain/proto/block.rs:50:9 [INFO] [stderr] | [INFO] [stderr] 50 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blockchain/proto/block.rs:69:5 [INFO] [stderr] | [INFO] [stderr] 69 | return reward; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `reward` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/blockchain/proto/block.rs:67:32 [INFO] [stderr] | [INFO] [stderr] 67 | let mut reward: u64 = 50 * 100000000; [INFO] [stderr] | ^^^^^^^^^ help: consider: `100_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/blockchain/proto/block.rs:68:31 [INFO] [stderr] | [INFO] [stderr] 68 | reward >>= block_height / 210000; [INFO] [stderr] | ^^^^^^ help: consider: `210_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/blockchain/proto/block.rs:78:45 [INFO] [stderr] | [INFO] [stderr] 78 | assert_eq!(get_base_reward(0), 5000000000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `5_000_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/blockchain/proto/block.rs:79:36 [INFO] [stderr] | [INFO] [stderr] 79 | assert_eq!(get_base_reward(209999), 5000000000); [INFO] [stderr] | ^^^^^^ help: consider: `209_999` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/blockchain/proto/block.rs:79:45 [INFO] [stderr] | [INFO] [stderr] 79 | assert_eq!(get_base_reward(209999), 5000000000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `5_000_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/blockchain/proto/block.rs:80:36 [INFO] [stderr] | [INFO] [stderr] 80 | assert_eq!(get_base_reward(210000), 2500000000); [INFO] [stderr] | ^^^^^^ help: consider: `210_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/blockchain/proto/block.rs:80:45 [INFO] [stderr] | [INFO] [stderr] 80 | assert_eq!(get_base_reward(210000), 2500000000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_500_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/blockchain/proto/block.rs:81:36 [INFO] [stderr] | [INFO] [stderr] 81 | assert_eq!(get_base_reward(419999), 2500000000); [INFO] [stderr] | ^^^^^^ help: consider: `419_999` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/blockchain/proto/block.rs:81:45 [INFO] [stderr] | [INFO] [stderr] 81 | assert_eq!(get_base_reward(419999), 2500000000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_500_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/blockchain/proto/block.rs:82:36 [INFO] [stderr] | [INFO] [stderr] 82 | assert_eq!(get_base_reward(420000), 1250000000); [INFO] [stderr] | ^^^^^^ help: consider: `420_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/blockchain/proto/block.rs:82:45 [INFO] [stderr] | [INFO] [stderr] 82 | assert_eq!(get_base_reward(420000), 1250000000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_250_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/blockchain/proto/block.rs:83:36 [INFO] [stderr] | [INFO] [stderr] 83 | assert_eq!(get_base_reward(629999), 1250000000); [INFO] [stderr] | ^^^^^^ help: consider: `629_999` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/blockchain/proto/block.rs:83:45 [INFO] [stderr] | [INFO] [stderr] 83 | assert_eq!(get_base_reward(629999), 1250000000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_250_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/blockchain/proto/block.rs:84:36 [INFO] [stderr] | [INFO] [stderr] 84 | assert_eq!(get_base_reward(630000), 0625000000); [INFO] [stderr] | ^^^^^^ help: consider: `630_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/blockchain/proto/block.rs:84:45 [INFO] [stderr] | [INFO] [stderr] 84 | assert_eq!(get_base_reward(630000), 0625000000); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_prefixed_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 84 | assert_eq!(get_base_reward(630000), 625000000); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 84 | assert_eq!(get_base_reward(630000), 0o625000000); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/blockchain/proto/block.rs:84:45 [INFO] [stderr] | [INFO] [stderr] 84 | assert_eq!(get_base_reward(630000), 0625000000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0_625_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blockchain/proto/header.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | return bytes; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `bytes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blockchain/proto/tx.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/blockchain/proto/tx.rs:43:80 [INFO] [stderr] | [INFO] [stderr] 43 | return input.outpoint.txid == [0u8; 32] && input.outpoint.index == 0xFFFFFFFF; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blockchain/proto/tx.rs:79:9 [INFO] [stderr] | [INFO] [stderr] 79 | return bytes; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `bytes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blockchain/proto/tx.rs:95:9 [INFO] [stderr] | [INFO] [stderr] 95 | return bytes; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `bytes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blockchain/proto/tx.rs:126:9 [INFO] [stderr] | [INFO] [stderr] 126 | return bytes; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `bytes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blockchain/proto/tx.rs:174:9 [INFO] [stderr] | [INFO] [stderr] 174 | return bytes; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `bytes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/blockchain/proto/varuint.rs:116:22 [INFO] [stderr] | [INFO] [stderr] 116 | let v: u32 = 3333333333; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `3_333_333_333` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/blockchain/proto/varuint.rs:119:20 [INFO] [stderr] | [INFO] [stderr] 119 | assert_eq!(3333333333, test.value); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `3_333_333_333` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/blockchain/proto/varuint.rs:127:22 [INFO] [stderr] | [INFO] [stderr] 127 | let v: u64 = 9000000000000000000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `9_000_000_000_000_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/blockchain/proto/varuint.rs:130:20 [INFO] [stderr] | [INFO] [stderr] 130 | assert_eq!(9000000000000000000, test.value); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `9_000_000_000_000_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blockchain/proto/script.rs:310:9 [INFO] [stderr] | [INFO] [stderr] 310 | return ScriptPattern::NotRecognised; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ScriptPattern::NotRecognised` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blockchain/proto/script.rs:340:9 [INFO] [stderr] | [INFO] [stderr] 340 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blockchain/parser/worker.rs:59:17 [INFO] [stderr] | [INFO] [stderr] 59 | return Err(OpError::new(OpErrorKind::None)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(OpError::new(OpErrorKind::None))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blockchain/parser/worker.rs:63:17 [INFO] [stderr] | [INFO] [stderr] 63 | return Err(OpError::new(OpErrorKind::RuntimeError)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(OpError::new(OpErrorKind::RuntimeError))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/blockchain/parser/worker.rs:43:40 [INFO] [stderr] | [INFO] [stderr] 43 | file.size as f64 / 1000000.0); [INFO] [stderr] | ^^^^^^^^^ help: consider: `1_000_000.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blockchain/parser/worker.rs:148:9 [INFO] [stderr] | [INFO] [stderr] 148 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blockchain/parser/worker.rs:168:9 [INFO] [stderr] | [INFO] [stderr] 168 | return Ok(true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(true)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/blockchain/parser/worker.rs:166:51 [INFO] [stderr] | [INFO] [stderr] 166 | self.blk_file.size as f64 / 1000000.0); [INFO] [stderr] | ^^^^^^^^^ help: consider: `1_000_000.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/blockchain/parser/chain.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | / if i < len - 1 { [INFO] [stderr] 39 | | if headers[i].hash != headers[i + 1].value.prev_hash { [INFO] [stderr] 40 | | return Err(OpError::new(OpErrorKind::ValidateError) [INFO] [stderr] 41 | | .join_msg("Longest-chain consistency check failed!")); [INFO] [stderr] 42 | | } [INFO] [stderr] 43 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 38 | if i < len - 1 && headers[i].hash != headers[i + 1].value.prev_hash { [INFO] [stderr] 39 | return Err(OpError::new(OpErrorKind::ValidateError) [INFO] [stderr] 40 | .join_msg("Longest-chain consistency check failed!")); [INFO] [stderr] 41 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blockchain/parser/chain.rs:174:9 [INFO] [stderr] | [INFO] [stderr] 174 | return Ok(chain); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(chain)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blockchain/parser/chain.rs:194:9 [INFO] [stderr] | [INFO] [stderr] 194 | return leafs; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `leafs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/blockchain/parser/chain.rs:274:13 [INFO] [stderr] | [INFO] [stderr] 274 | 0x00000001, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/blockchain/parser/chain.rs:280:13 [INFO] [stderr] | [INFO] [stderr] 280 | 1231006505, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_231_006_505` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/blockchain/parser/chain.rs:281:13 [INFO] [stderr] | [INFO] [stderr] 281 | 0x1d00ffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1d00_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/blockchain/parser/chain.rs:282:13 [INFO] [stderr] | [INFO] [stderr] 282 | 2083236893); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_083_236_893` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/blockchain/parser/chain.rs:317:13 [INFO] [stderr] | [INFO] [stderr] 317 | 0x00000001, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/blockchain/parser/chain.rs:323:13 [INFO] [stderr] | [INFO] [stderr] 323 | 1231006505, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_231_006_505` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/blockchain/parser/chain.rs:324:13 [INFO] [stderr] | [INFO] [stderr] 324 | 0x1d00ffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1d00_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/blockchain/parser/chain.rs:325:13 [INFO] [stderr] | [INFO] [stderr] 325 | 2083236893); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_083_236_893` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/blockchain/parser/chain.rs:338:13 [INFO] [stderr] | [INFO] [stderr] 338 | 0x00000001, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/blockchain/parser/chain.rs:344:13 [INFO] [stderr] | [INFO] [stderr] 344 | 1231006505, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_231_006_505` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/blockchain/parser/chain.rs:345:13 [INFO] [stderr] | [INFO] [stderr] 345 | 0x1d00ffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1d00_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/blockchain/parser/chain.rs:346:13 [INFO] [stderr] | [INFO] [stderr] 346 | 2083236893); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_083_236_893` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/blockchain/parser/chain.rs:353:13 [INFO] [stderr] | [INFO] [stderr] 353 | 0x00000001, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/blockchain/parser/chain.rs:359:13 [INFO] [stderr] | [INFO] [stderr] 359 | 1231006505, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_231_006_505` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/blockchain/parser/chain.rs:360:13 [INFO] [stderr] | [INFO] [stderr] 360 | 0x1d00ffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1d00_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/blockchain/parser/chain.rs:361:13 [INFO] [stderr] | [INFO] [stderr] 361 | 2083236893); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_083_236_893` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/blockchain/parser/types.rs:32:36 [INFO] [stderr] | [INFO] [stderr] 32 | fn magic(&self) -> u32 { 0xd9b4bef9 } [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xd9b4_bef9` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/blockchain/parser/types.rs:41:36 [INFO] [stderr] | [INFO] [stderr] 41 | fn magic(&self) -> u32 { 0x0709110b } [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0709_110b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/blockchain/parser/types.rs:49:36 [INFO] [stderr] | [INFO] [stderr] 49 | fn magic(&self) -> u32 { 0xfeb4bef9 } [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xfeb4_bef9` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/blockchain/parser/types.rs:57:36 [INFO] [stderr] | [INFO] [stderr] 57 | fn magic(&self) -> u32 { 0xdbb6c0fb } [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xdbb6_c0fb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/blockchain/parser/types.rs:65:36 [INFO] [stderr] | [INFO] [stderr] 65 | fn magic(&self) -> u32 { 0xc0c0c0c0 } [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xc0c0_c0c0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/blockchain/parser/types.rs:73:36 [INFO] [stderr] | [INFO] [stderr] 73 | fn magic(&self) -> u32 { 0xee7645af } [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xee76_45af` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/blockchain/parser/types.rs:81:36 [INFO] [stderr] | [INFO] [stderr] 81 | fn magic(&self) -> u32 { 0x03b5d503 } [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x03b5_d503` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blockchain/parser/types.rs:138:17 [INFO] [stderr] | [INFO] [stderr] 138 | return Err(e); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(e)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/blockchain/utils/blkfile.rs:31:37 [INFO] [stderr] | [INFO] [stderr] 31 | Ok(BufReader::with_capacity(100000000, f)) [INFO] [stderr] | ^^^^^^^^^ help: consider: `100_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/blockchain/utils/blkfile.rs:110:20 [INFO] [stderr] | [INFO] [stderr] 110 | assert_eq!(13412451, BlkFile::parse_blk_index("blk13412451.dat", blk_prefix, blk_ext).unwrap()); [INFO] [stderr] | ^^^^^^^^ help: consider: `13_412_451` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/blockchain/utils/reader.rs:232:20 [INFO] [stderr] | [INFO] [stderr] 232 | assert_eq!(0xd9b4bef9, magic); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xd9b4_bef9` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/blockchain/utils/reader.rs:236:20 [INFO] [stderr] | [INFO] [stderr] 236 | assert_eq!(0x00000001, block.header.value.version); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/blockchain/utils/reader.rs:246:20 [INFO] [stderr] | [INFO] [stderr] 246 | assert_eq!(1231006505, block.header.value.timestamp); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_231_006_505` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/blockchain/utils/reader.rs:247:20 [INFO] [stderr] | [INFO] [stderr] 247 | assert_eq!(0x1d00ffff, block.header.value.bits); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1d00_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/blockchain/utils/reader.rs:248:20 [INFO] [stderr] | [INFO] [stderr] 248 | assert_eq!(2083236893, block.header.value.nonce); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_083_236_893` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/blockchain/utils/reader.rs:252:20 [INFO] [stderr] | [INFO] [stderr] 252 | assert_eq!(0x00000001, block.txs[0].value.tx_version); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/blockchain/utils/reader.rs:258:20 [INFO] [stderr] | [INFO] [stderr] 258 | assert_eq!(0xffffffff, block.txs[0].value.inputs[0].outpoint.index); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/blockchain/utils/reader.rs:262:20 [INFO] [stderr] | [INFO] [stderr] 262 | assert_eq!(0xffffffff, block.txs[0].value.inputs[0].seq_no); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/blockchain/utils/reader.rs:266:33 [INFO] [stderr] | [INFO] [stderr] 266 | assert_eq!(u64::from_be(0x00f2052a01000000), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x00f2_052a_0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/blockchain/utils/reader.rs:273:20 [INFO] [stderr] | [INFO] [stderr] 273 | assert_eq!(0x00000000, block.txs[0].value.tx_locktime); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blockchain/utils/mod.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | return out; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `out` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blockchain/utils/mod.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | return out; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `out` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blockchain/utils/mod.rs:61:5 [INFO] [stderr] | [INFO] [stderr] 61 | return merkle_root(&mut hash_pairs); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `merkle_root(&mut hash_pairs)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blockchain/utils/mod.rs:103:5 [INFO] [stderr] | [INFO] [stderr] 103 | return hex; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `hex` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blockchain/utils/mod.rs:126:5 [INFO] [stderr] | [INFO] [stderr] 126 | return arr; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `arr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/callbacks/csvdump.rs:70:22 [INFO] [stderr] | [INFO] [stderr] 70 | Ok(s) => return Ok(s), [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `Ok(s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/callbacks/csvdump.rs:71:23 [INFO] [stderr] | [INFO] [stderr] 71 | Err(e) => return Err( [INFO] [stderr] | _______________________^ [INFO] [stderr] 72 | | tag_err!(e, "Couldn't initialize csvdump with folder: `{}`", dump_folder [INFO] [stderr] 73 | | .as_path() [INFO] [stderr] 74 | | .display())) [INFO] [stderr] | |____________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 71 | Err(e) => Err( [INFO] [stderr] 72 | tag_err!(e, "Couldn't initialize csvdump with folder: `{}`", dump_folder [INFO] [stderr] 73 | .as_path() [INFO] [stderr] 74 | .display())) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/callbacks/csvdump.rs:59:23 [INFO] [stderr] | [INFO] [stderr] 59 | let cap = 4000000; [INFO] [stderr] | ^^^^^^^ help: consider: `4_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/callbacks/unspentcsvdump.rs:75:22 [INFO] [stderr] | [INFO] [stderr] 75 | Ok(s) => return Ok(s), [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `Ok(s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/callbacks/unspentcsvdump.rs:76:23 [INFO] [stderr] | [INFO] [stderr] 76 | Err(e) => return Err( [INFO] [stderr] | _______________________^ [INFO] [stderr] 77 | | tag_err!(e, "Couldn't initialize csvdump with folder: `{}`", dump_folder [INFO] [stderr] 78 | | .as_path() [INFO] [stderr] 79 | | .display())) [INFO] [stderr] | |____________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 76 | Err(e) => Err( [INFO] [stderr] 77 | tag_err!(e, "Couldn't initialize csvdump with folder: `{}`", dump_folder [INFO] [stderr] 78 | .as_path() [INFO] [stderr] 79 | .display())) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/callbacks/unspentcsvdump.rs:66:23 [INFO] [stderr] | [INFO] [stderr] 66 | let cap = 4000000; [INFO] [stderr] | ^^^^^^^ help: consider: `4_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/callbacks/unspentcsvdump.rs:70:48 [INFO] [stderr] | [INFO] [stderr] 70 | transactions_unspent: HashMap::with_capacity(10000000), // Init hashmap for tracking the unspent transactions (with 10'000'000 mln preallocated entries) [INFO] [stderr] | ^^^^^^^^ help: consider: `10_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:163:40 [INFO] [stderr] | [INFO] [stderr] 163 | ErrorKind::NotFound => return Ok(chain::ChainStorage::default()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(chain::ChainStorage::default())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:164:22 [INFO] [stderr] | [INFO] [stderr] 164 | _ => return Err(OpError::from(err)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(OpError::from(err))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:167:21 [INFO] [stderr] | [INFO] [stderr] 167 | kind @ _ => return Err(OpError::new(kind)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(OpError::new(kind))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/blockchain/utils/mod.rs:131:19 [INFO] [stderr] | [INFO] [stderr] 131 | PathBuf::from(env::home_dir().expect("Unable to get home path from env!")) [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blockchain/proto/block.rs:50:9 [INFO] [stderr] | [INFO] [stderr] 50 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blockchain/proto/block.rs:69:5 [INFO] [stderr] | [INFO] [stderr] 69 | return reward; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `reward` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/blockchain/proto/block.rs:67:32 [INFO] [stderr] | [INFO] [stderr] 67 | let mut reward: u64 = 50 * 100000000; [INFO] [stderr] | ^^^^^^^^^ help: consider: `100_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/blockchain/proto/block.rs:68:31 [INFO] [stderr] | [INFO] [stderr] 68 | reward >>= block_height / 210000; [INFO] [stderr] | ^^^^^^ help: consider: `210_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blockchain/proto/header.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | return bytes; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `bytes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blockchain/proto/tx.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/blockchain/proto/tx.rs:43:80 [INFO] [stderr] | [INFO] [stderr] 43 | return input.outpoint.txid == [0u8; 32] && input.outpoint.index == 0xFFFFFFFF; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blockchain/proto/tx.rs:79:9 [INFO] [stderr] | [INFO] [stderr] 79 | return bytes; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `bytes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blockchain/proto/tx.rs:95:9 [INFO] [stderr] | [INFO] [stderr] 95 | return bytes; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `bytes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blockchain/proto/tx.rs:126:9 [INFO] [stderr] | [INFO] [stderr] 126 | return bytes; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `bytes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blockchain/proto/tx.rs:174:9 [INFO] [stderr] | [INFO] [stderr] 174 | return bytes; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `bytes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blockchain/proto/script.rs:310:9 [INFO] [stderr] | [INFO] [stderr] 310 | return ScriptPattern::NotRecognised; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ScriptPattern::NotRecognised` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blockchain/proto/script.rs:340:9 [INFO] [stderr] | [INFO] [stderr] 340 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blockchain/parser/worker.rs:59:17 [INFO] [stderr] | [INFO] [stderr] 59 | return Err(OpError::new(OpErrorKind::None)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(OpError::new(OpErrorKind::None))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blockchain/parser/worker.rs:63:17 [INFO] [stderr] | [INFO] [stderr] 63 | return Err(OpError::new(OpErrorKind::RuntimeError)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(OpError::new(OpErrorKind::RuntimeError))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/blockchain/parser/worker.rs:43:40 [INFO] [stderr] | [INFO] [stderr] 43 | file.size as f64 / 1000000.0); [INFO] [stderr] | ^^^^^^^^^ help: consider: `1_000_000.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blockchain/parser/worker.rs:148:9 [INFO] [stderr] | [INFO] [stderr] 148 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blockchain/parser/worker.rs:168:9 [INFO] [stderr] | [INFO] [stderr] 168 | return Ok(true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(true)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/blockchain/parser/worker.rs:166:51 [INFO] [stderr] | [INFO] [stderr] 166 | self.blk_file.size as f64 / 1000000.0); [INFO] [stderr] | ^^^^^^^^^ help: consider: `1_000_000.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/blockchain/parser/chain.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | / if i < len - 1 { [INFO] [stderr] 39 | | if headers[i].hash != headers[i + 1].value.prev_hash { [INFO] [stderr] 40 | | return Err(OpError::new(OpErrorKind::ValidateError) [INFO] [stderr] 41 | | .join_msg("Longest-chain consistency check failed!")); [INFO] [stderr] 42 | | } [INFO] [stderr] 43 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 38 | if i < len - 1 && headers[i].hash != headers[i + 1].value.prev_hash { [INFO] [stderr] 39 | return Err(OpError::new(OpErrorKind::ValidateError) [INFO] [stderr] 40 | .join_msg("Longest-chain consistency check failed!")); [INFO] [stderr] 41 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blockchain/parser/chain.rs:174:9 [INFO] [stderr] | [INFO] [stderr] 174 | return Ok(chain); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(chain)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blockchain/parser/chain.rs:194:9 [INFO] [stderr] | [INFO] [stderr] 194 | return leafs; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `leafs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/blockchain/parser/types.rs:32:36 [INFO] [stderr] | [INFO] [stderr] 32 | fn magic(&self) -> u32 { 0xd9b4bef9 } [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xd9b4_bef9` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/blockchain/parser/types.rs:41:36 [INFO] [stderr] | [INFO] [stderr] 41 | fn magic(&self) -> u32 { 0x0709110b } [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0709_110b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/blockchain/parser/types.rs:49:36 [INFO] [stderr] | [INFO] [stderr] 49 | fn magic(&self) -> u32 { 0xfeb4bef9 } [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xfeb4_bef9` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/blockchain/parser/types.rs:57:36 [INFO] [stderr] | [INFO] [stderr] 57 | fn magic(&self) -> u32 { 0xdbb6c0fb } [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xdbb6_c0fb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/blockchain/parser/types.rs:65:36 [INFO] [stderr] | [INFO] [stderr] 65 | fn magic(&self) -> u32 { 0xc0c0c0c0 } [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xc0c0_c0c0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/blockchain/parser/types.rs:73:36 [INFO] [stderr] | [INFO] [stderr] 73 | fn magic(&self) -> u32 { 0xee7645af } [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xee76_45af` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/blockchain/parser/types.rs:81:36 [INFO] [stderr] | [INFO] [stderr] 81 | fn magic(&self) -> u32 { 0x03b5d503 } [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x03b5_d503` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blockchain/parser/types.rs:138:17 [INFO] [stderr] | [INFO] [stderr] 138 | return Err(e); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(e)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/blockchain/utils/blkfile.rs:31:37 [INFO] [stderr] | [INFO] [stderr] 31 | Ok(BufReader::with_capacity(100000000, f)) [INFO] [stderr] | ^^^^^^^^^ help: consider: `100_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blockchain/utils/mod.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | return out; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `out` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blockchain/utils/mod.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | return out; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `out` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blockchain/utils/mod.rs:61:5 [INFO] [stderr] | [INFO] [stderr] 61 | return merkle_root(&mut hash_pairs); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `merkle_root(&mut hash_pairs)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blockchain/utils/mod.rs:103:5 [INFO] [stderr] | [INFO] [stderr] 103 | return hex; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `hex` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blockchain/utils/mod.rs:126:5 [INFO] [stderr] | [INFO] [stderr] 126 | return arr; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `arr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/callbacks/csvdump.rs:70:22 [INFO] [stderr] | [INFO] [stderr] 70 | Ok(s) => return Ok(s), [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `Ok(s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/callbacks/csvdump.rs:71:23 [INFO] [stderr] | [INFO] [stderr] 71 | Err(e) => return Err( [INFO] [stderr] | _______________________^ [INFO] [stderr] 72 | | tag_err!(e, "Couldn't initialize csvdump with folder: `{}`", dump_folder [INFO] [stderr] 73 | | .as_path() [INFO] [stderr] 74 | | .display())) [INFO] [stderr] | |____________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 71 | Err(e) => Err( [INFO] [stderr] 72 | tag_err!(e, "Couldn't initialize csvdump with folder: `{}`", dump_folder [INFO] [stderr] 73 | .as_path() [INFO] [stderr] 74 | .display())) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/callbacks/csvdump.rs:59:23 [INFO] [stderr] | [INFO] [stderr] 59 | let cap = 4000000; [INFO] [stderr] | ^^^^^^^ help: consider: `4_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/callbacks/unspentcsvdump.rs:75:22 [INFO] [stderr] | [INFO] [stderr] 75 | Ok(s) => return Ok(s), [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `Ok(s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/callbacks/unspentcsvdump.rs:76:23 [INFO] [stderr] | [INFO] [stderr] 76 | Err(e) => return Err( [INFO] [stderr] | _______________________^ [INFO] [stderr] 77 | | tag_err!(e, "Couldn't initialize csvdump with folder: `{}`", dump_folder [INFO] [stderr] 78 | | .as_path() [INFO] [stderr] 79 | | .display())) [INFO] [stderr] | |____________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 76 | Err(e) => Err( [INFO] [stderr] 77 | tag_err!(e, "Couldn't initialize csvdump with folder: `{}`", dump_folder [INFO] [stderr] 78 | .as_path() [INFO] [stderr] 79 | .display())) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/callbacks/unspentcsvdump.rs:66:23 [INFO] [stderr] | [INFO] [stderr] 66 | let cap = 4000000; [INFO] [stderr] | ^^^^^^^ help: consider: `4_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/callbacks/unspentcsvdump.rs:70:48 [INFO] [stderr] | [INFO] [stderr] 70 | transactions_unspent: HashMap::with_capacity(10000000), // Init hashmap for tracking the unspent transactions (with 10'000'000 mln preallocated entries) [INFO] [stderr] | ^^^^^^^^ help: consider: `10_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:163:40 [INFO] [stderr] | [INFO] [stderr] 163 | ErrorKind::NotFound => return Ok(chain::ChainStorage::default()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(chain::ChainStorage::default())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:164:22 [INFO] [stderr] | [INFO] [stderr] 164 | _ => return Err(OpError::from(err)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(OpError::from(err))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:167:21 [INFO] [stderr] | [INFO] [stderr] 167 | kind @ _ => return Err(OpError::new(kind)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(OpError::new(kind))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/blockchain/utils/mod.rs:131:19 [INFO] [stderr] | [INFO] [stderr] 131 | PathBuf::from(env::home_dir().expect("Unable to get home path from env!")) [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/blockchain/proto/block.rs:32:38 [INFO] [stderr] | [INFO] [stderr] 32 | txs: txs.into_iter().map(|tx| Hashed::double_sha256(tx)).collect(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Hashed::double_sha256` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/blockchain/proto/varuint.rs:39:22 [INFO] [stderr] | [INFO] [stderr] 39 | VarUint::new(value as u64, vec![value]) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(value)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/blockchain/proto/varuint.rs:48:22 [INFO] [stderr] | [INFO] [stderr] 48 | VarUint::new(value as u64, buf) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/blockchain/proto/varuint.rs:57:22 [INFO] [stderr] | [INFO] [stderr] 57 | VarUint::new(value as u64, buf) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/blockchain/proto/script.rs:135:5 [INFO] [stderr] | [INFO] [stderr] 135 | / fn ne(&self, other: &Self) -> bool { [INFO] [stderr] 136 | | !self.eq(other) [INFO] [stderr] 137 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::partialeq_ne_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/blockchain/proto/script.rs:142:9 [INFO] [stderr] | [INFO] [stderr] 142 | / match self { [INFO] [stderr] 143 | | &StackElement::Op(ref op) => write!(f, "{:?}", &op), [INFO] [stderr] 144 | | &StackElement::Data(ref d) => write!(f, "{}", &utils::arr_to_hex(&d)) [INFO] [stderr] 145 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 142 | match *self { [INFO] [stderr] 143 | StackElement::Op(ref op) => write!(f, "{:?}", &op), [INFO] [stderr] 144 | StackElement::Data(ref d) => write!(f, "{}", &utils::arr_to_hex(&d)) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `data` [INFO] [stderr] --> src/blockchain/proto/script.rs:320:22 [INFO] [stderr] | [INFO] [stderr] 320 | for i in 0..size { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 320 | for (i, ) in data.iter().enumerate().take(size) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the `p @ _` pattern can be written as just `p` [INFO] [stderr] --> src/blockchain/proto/script.rs:399:13 [INFO] [stderr] | [INFO] [stderr] 399 | ref p @ _ => { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/blockchain/proto/script.rs:432:20 [INFO] [stderr] | [INFO] [stderr] 432 | let mut addr = Vec::from(vh160); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider removing `Vec::from()`: `vh160` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/blockchain/proto/opcodes.rs:556:21 [INFO] [stderr] | [INFO] [stderr] 556 | pub fn classify(&self) -> Class { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/blockchain/parser/worker.rs:82:26 [INFO] [stderr] | [INFO] [stderr] 82 | .expect(&format!("Unable to contact main thread!")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Unable to contact main thread!"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/blockchain/parser/worker.rs:82:34 [INFO] [stderr] | [INFO] [stderr] 82 | .expect(&format!("Unable to contact main thread!")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Unable to contact main thread!".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/blockchain/parser/worker.rs:99:9 [INFO] [stderr] | [INFO] [stderr] 99 | / match try!(self.maybe_next()) { [INFO] [stderr] 100 | | false => Ok(None), [INFO] [stderr] 101 | | true => { [INFO] [stderr] 102 | | // Get metadata for next block [INFO] [stderr] ... | [INFO] [stderr] 121 | | } [INFO] [stderr] 122 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 99 | if match $ expr { [INFO] [stderr] 100 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 101 | :: Err ( err ) => { [INFO] [stderr] 102 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 103 | $ crate :: convert :: From :: from ( err ) ) } } { [INFO] [stderr] 104 | // Get metadata for next block [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/blockchain/parser/worker.rs:146:23 [INFO] [stderr] | [INFO] [stderr] 146 | let n_bytes = blocksize as u64 - (self.reader.position() - block_offset); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u64::from(blocksize)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: item `blockchain::parser::chain::ChainStorage` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/blockchain/parser/chain.rs:29:1 [INFO] [stderr] | [INFO] [stderr] 29 | / impl ChainStorage { [INFO] [stderr] 30 | | [INFO] [stderr] 31 | | /// Extends an existing ChainStorage with new hashes. [INFO] [stderr] 32 | | pub fn extend(&mut self, headers: Vec>, [INFO] [stderr] ... | [INFO] [stderr] 136 | | } [INFO] [stderr] 137 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/blockchain/parser/chain.rs:51:20 [INFO] [stderr] | [INFO] [stderr] 51 | if &coin_type.genesis_hash != &first_hash { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 51 | if coin_type.genesis_hash != first_hash { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/blockchain/parser/chain.rs:63:35 [INFO] [stderr] | [INFO] [stderr] 63 | let latest_hash = transform!(self.hashes.last()).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 63 | let latest_hash = *{ [INFO] [stderr] 64 | try!($e.ok_or(OpError::new(OpErrorKind::None).join_msg(&line_mark!()))) [INFO] [stderr] 65 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/blockchain/parser/chain.rs:67:20 [INFO] [stderr] | [INFO] [stderr] 67 | if new_hashes.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!new_hashes.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's values [INFO] [stderr] --> src/blockchain/parser/chain.rs:188:28 [INFO] [stderr] | [INFO] [stderr] 188 | for (_, header) in &ph_map { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::for_kv_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 188 | for header in ph_map.values() { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/blockchain/parser/chain.rs:372:13 [INFO] [stderr] | [INFO] [stderr] 372 | Err(_) => panic!() [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/blockchain/parser/chain.rs:382:13 [INFO] [stderr] | [INFO] [stderr] 382 | Err(_) => panic!() [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/blockchain/parser/types.rs:119:29 [INFO] [stderr] | [INFO] [stderr] 119 | default_folder: PathBuf::from(coin.default_folder()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `PathBuf::from()`: `coin.default_folder()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: the `n @ _` pattern can be written as just `n` [INFO] [stderr] --> src/blockchain/parser/types.rs:135:13 [INFO] [stderr] | [INFO] [stderr] 135 | n @ _ => { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/blockchain/parser/mod.rs:240:9 [INFO] [stderr] | [INFO] [stderr] 240 | / match self.mode { [INFO] [stderr] 241 | | ParseMode::FullData => { [INFO] [stderr] 242 | | (*self.options.callback).on_complete(self.chain_storage.get_cur_height()); [INFO] [stderr] 243 | | } [INFO] [stderr] 244 | | _ => () [INFO] [stderr] 245 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 240 | if let ParseMode::FullData = self.mode { [INFO] [stderr] 241 | (*self.options.callback).on_complete(self.chain_storage.get_cur_height()); [INFO] [stderr] 242 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/blockchain/utils/blkfile.rs:51:21 [INFO] [stderr] | [INFO] [stderr] 51 | / let mut metadata: Metadata = de.metadata().unwrap(); [INFO] [stderr] 52 | | if sl { [INFO] [stderr] 53 | | path = fs::read_link(path.clone()).unwrap(); [INFO] [stderr] 54 | | metadata = fs::metadata(path.clone()).unwrap(); [INFO] [stderr] 55 | | } [INFO] [stderr] | |_____________________^ help: it is more idiomatic to write: `let metadata = if sl { ..; fs::metadata(path.clone()).unwrap() } else { de.metadata().unwrap() };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/blockchain/utils/reader.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | / let in_count: VarUint; [INFO] [stderr] 55 | | if marker == 0x00 { [INFO] [stderr] 56 | | // SegWit hack [INFO] [stderr] 57 | | /*let flag = */try!(self.read_u8()); [INFO] [stderr] ... | [INFO] [stderr] 66 | | }; [INFO] [stderr] 67 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] help: it is more idiomatic to write [INFO] [stderr] | [INFO] [stderr] 54 | let in_count = if marker == 0x00 { ..; match $ expr { [INFO] [stderr] 55 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 56 | :: Err ( err ) => { [INFO] [stderr] 57 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 58 | $ crate :: convert :: From :: from ( err ) ) } } } else { match marker { [INFO] [stderr] 59 | 0x01...0xfc => VarUint::from(marker), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: The function/method `merkle_root` doesn't need a mutable reference [INFO] [stderr] --> src/blockchain/utils/mod.rs:61:24 [INFO] [stderr] | [INFO] [stderr] 61 | return merkle_root(&mut hash_pairs); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/blockchain/utils/mod.rs:131:5 [INFO] [stderr] | [INFO] [stderr] 131 | PathBuf::from(env::home_dir().expect("Unable to get home path from env!")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `PathBuf::from()`: `env::home_dir().expect("Unable to get home path from env!")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/blockchain/utils/mod.rs:141:27 [INFO] [stderr] | [INFO] [stderr] 141 | let sum = slice.iter() [INFO] [stderr] | ___________________________^ [INFO] [stderr] 142 | | .fold(0, |sum, &s| sum + s); [INFO] [stderr] | |__________________________________^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/blockchain/utils/mod.rs:143:5 [INFO] [stderr] | [INFO] [stderr] 143 | sum as f64 / slice.len() as f64 [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(sum)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the `p @ _` pattern can be written as just `p` [INFO] [stderr] --> src/callbacks/stats.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | p @ _ => p [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/callbacks/stats.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | / if !self.n_tx_types.contains_key(&pattern) { [INFO] [stderr] 52 | | self.n_tx_types.insert(pattern.clone(), 1); [INFO] [stderr] 53 | | self.tx_first_occs.insert(pattern, (block_height, txid, index)); [INFO] [stderr] 54 | | } else { [INFO] [stderr] 55 | | let counter = self.n_tx_types.entry(pattern).or_insert(1); [INFO] [stderr] 56 | | *counter += 1; [INFO] [stderr] 57 | | } [INFO] [stderr] | |_________^ help: consider using: `self.n_tx_types.entry(pattern)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: the variable `i` is used as a loop counter. Consider using `for (i, item) in tx.value.outputs.enumerate()` or similar iterators [INFO] [stderr] --> src/callbacks/stats.rs:96:22 [INFO] [stderr] | [INFO] [stderr] 96 | for o in tx.value.outputs { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/callbacks/stats.rs:156:23 [INFO] [stderr] | [INFO] [stderr] 156 | let pos = self.tx_first_occs.get(pattern).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.tx_first_occs[pattern]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/callbacks/csvdump.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | let ref dump_folder = PathBuf::from(matches.value_of("dump-folder").unwrap()); // Save to unwrap [INFO] [stderr] | ----^^^^^^^^^^^^^^^----------------------------------------------------------- help: try: `let dump_folder = &PathBuf::from(matches.value_of("dump-folder").unwrap());` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/callbacks/csvdump.rs:112:18 [INFO] [stderr] | [INFO] [stderr] 112 | for f in vec!["blocks", "transactions", "tx_in", "tx_out"] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&["blocks", "transactions", "tx_in", "tx_out"]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/blockchain/proto/block.rs:32:38 [INFO] [stderr] | [INFO] [stderr] 32 | txs: txs.into_iter().map(|tx| Hashed::double_sha256(tx)).collect(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Hashed::double_sha256` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/callbacks/unspentcsvdump.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | let ref dump_folder = PathBuf::from(matches.value_of("dump-folder").unwrap()); // Save to unwrap [INFO] [stderr] | ----^^^^^^^^^^^^^^^----------------------------------------------------------- help: try: `let dump_folder = &PathBuf::from(matches.value_of("dump-folder").unwrap());` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/callbacks/unspentcsvdump.rs:160:18 [INFO] [stderr] | [INFO] [stderr] 160 | for f in vec!["unspent"] { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: you can use a slice directly: `&["unspent"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/blockchain/proto/varuint.rs:39:22 [INFO] [stderr] | [INFO] [stderr] 39 | VarUint::new(value as u64, vec![value]) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(value)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/blockchain/proto/varuint.rs:48:22 [INFO] [stderr] | [INFO] [stderr] 48 | VarUint::new(value as u64, buf) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/blockchain/proto/varuint.rs:57:22 [INFO] [stderr] | [INFO] [stderr] 57 | VarUint::new(value as u64, buf) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:94:26 [INFO] [stderr] | [INFO] [stderr] 94 | let parse_mode = match chain_file.len() == 0 || resume { [INFO] [stderr] | __________________________^ [INFO] [stderr] 95 | | true => ParseMode::Indexing, [INFO] [stderr] 96 | | false => ParseMode::FullData [INFO] [stderr] 97 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if chain_file.len() == 0 || resume { ParseMode::Indexing } else { ParseMode::FullData }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/main.rs:155:47 [INFO] [stderr] | [INFO] [stderr] 155 | let err = match chain::ChainStorage::load(path.clone()) { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 155 | let err = match chain::ChainStorage::load(&(*path).clone()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 155 | let err = match chain::ChainStorage::load(&std::path::Path::clone(path)) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the `kind @ _` pattern can be written as just `kind` [INFO] [stderr] --> src/main.rs:167:9 [INFO] [stderr] | [INFO] [stderr] 167 | kind @ _ => return Err(OpError::new(kind)) [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:242:5 [INFO] [stderr] | [INFO] [stderr] 242 | / let mut blockchain_path = utils::get_absolute_blockchain_dir(&coin_type); [INFO] [stderr] 243 | | if matches.value_of("blockchain-dir").is_some() { [INFO] [stderr] 244 | | blockchain_path = PathBuf::from(matches.value_of("blockchain-dir").unwrap()); [INFO] [stderr] 245 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let blockchain_path = if matches.value_of("blockchain-dir").is_some() { PathBuf::from(matches.value_of("blockchain-dir").unwrap()) } else { utils::get_absolute_blockchain_dir(&coin_type) };` [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:241:57 [INFO] [stderr] | [INFO] [stderr] 241 | let coin_type = value_t!(matches, "coin", CoinType).unwrap_or(CoinType::from(Bitcoin)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| CoinType::from(Bitcoin))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/blockchain/proto/script.rs:135:5 [INFO] [stderr] | [INFO] [stderr] 135 | / fn ne(&self, other: &Self) -> bool { [INFO] [stderr] 136 | | !self.eq(other) [INFO] [stderr] 137 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::partialeq_ne_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/blockchain/proto/script.rs:142:9 [INFO] [stderr] | [INFO] [stderr] 142 | / match self { [INFO] [stderr] 143 | | &StackElement::Op(ref op) => write!(f, "{:?}", &op), [INFO] [stderr] 144 | | &StackElement::Data(ref d) => write!(f, "{}", &utils::arr_to_hex(&d)) [INFO] [stderr] 145 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 142 | match *self { [INFO] [stderr] 143 | StackElement::Op(ref op) => write!(f, "{:?}", &op), [INFO] [stderr] 144 | StackElement::Data(ref d) => write!(f, "{}", &utils::arr_to_hex(&d)) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `data` [INFO] [stderr] --> src/blockchain/proto/script.rs:320:22 [INFO] [stderr] | [INFO] [stderr] 320 | for i in 0..size { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 320 | for (i, ) in data.iter().enumerate().take(size) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the `p @ _` pattern can be written as just `p` [INFO] [stderr] --> src/blockchain/proto/script.rs:399:13 [INFO] [stderr] | [INFO] [stderr] 399 | ref p @ _ => { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/blockchain/proto/script.rs:432:20 [INFO] [stderr] | [INFO] [stderr] 432 | let mut addr = Vec::from(vh160); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider removing `Vec::from()`: `vh160` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rusty-blockparser`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/blockchain/proto/opcodes.rs:556:21 [INFO] [stderr] | [INFO] [stderr] 556 | pub fn classify(&self) -> Class { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/blockchain/parser/worker.rs:82:26 [INFO] [stderr] | [INFO] [stderr] 82 | .expect(&format!("Unable to contact main thread!")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Unable to contact main thread!"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/blockchain/parser/worker.rs:82:34 [INFO] [stderr] | [INFO] [stderr] 82 | .expect(&format!("Unable to contact main thread!")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Unable to contact main thread!".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/blockchain/parser/worker.rs:99:9 [INFO] [stderr] | [INFO] [stderr] 99 | / match try!(self.maybe_next()) { [INFO] [stderr] 100 | | false => Ok(None), [INFO] [stderr] 101 | | true => { [INFO] [stderr] 102 | | // Get metadata for next block [INFO] [stderr] ... | [INFO] [stderr] 121 | | } [INFO] [stderr] 122 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 99 | if match $ expr { [INFO] [stderr] 100 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 101 | :: Err ( err ) => { [INFO] [stderr] 102 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 103 | $ crate :: convert :: From :: from ( err ) ) } } { [INFO] [stderr] 104 | // Get metadata for next block [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/blockchain/parser/worker.rs:146:23 [INFO] [stderr] | [INFO] [stderr] 146 | let n_bytes = blocksize as u64 - (self.reader.position() - block_offset); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u64::from(blocksize)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: item `blockchain::parser::chain::ChainStorage` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/blockchain/parser/chain.rs:29:1 [INFO] [stderr] | [INFO] [stderr] 29 | / impl ChainStorage { [INFO] [stderr] 30 | | [INFO] [stderr] 31 | | /// Extends an existing ChainStorage with new hashes. [INFO] [stderr] 32 | | pub fn extend(&mut self, headers: Vec>, [INFO] [stderr] ... | [INFO] [stderr] 136 | | } [INFO] [stderr] 137 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/blockchain/parser/chain.rs:51:20 [INFO] [stderr] | [INFO] [stderr] 51 | if &coin_type.genesis_hash != &first_hash { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 51 | if coin_type.genesis_hash != first_hash { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/blockchain/parser/chain.rs:63:35 [INFO] [stderr] | [INFO] [stderr] 63 | let latest_hash = transform!(self.hashes.last()).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 63 | let latest_hash = *{ [INFO] [stderr] 64 | try!($e.ok_or(OpError::new(OpErrorKind::None).join_msg(&line_mark!()))) [INFO] [stderr] 65 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/blockchain/parser/chain.rs:67:20 [INFO] [stderr] | [INFO] [stderr] 67 | if new_hashes.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!new_hashes.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's values [INFO] [stderr] --> src/blockchain/parser/chain.rs:188:28 [INFO] [stderr] | [INFO] [stderr] 188 | for (_, header) in &ph_map { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::for_kv_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 188 | for header in ph_map.values() { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/blockchain/parser/types.rs:119:29 [INFO] [stderr] | [INFO] [stderr] 119 | default_folder: PathBuf::from(coin.default_folder()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `PathBuf::from()`: `coin.default_folder()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: the `n @ _` pattern can be written as just `n` [INFO] [stderr] --> src/blockchain/parser/types.rs:135:13 [INFO] [stderr] | [INFO] [stderr] 135 | n @ _ => { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/blockchain/parser/mod.rs:240:9 [INFO] [stderr] | [INFO] [stderr] 240 | / match self.mode { [INFO] [stderr] 241 | | ParseMode::FullData => { [INFO] [stderr] 242 | | (*self.options.callback).on_complete(self.chain_storage.get_cur_height()); [INFO] [stderr] 243 | | } [INFO] [stderr] 244 | | _ => () [INFO] [stderr] 245 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 240 | if let ParseMode::FullData = self.mode { [INFO] [stderr] 241 | (*self.options.callback).on_complete(self.chain_storage.get_cur_height()); [INFO] [stderr] 242 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/blockchain/utils/blkfile.rs:51:21 [INFO] [stderr] | [INFO] [stderr] 51 | / let mut metadata: Metadata = de.metadata().unwrap(); [INFO] [stderr] 52 | | if sl { [INFO] [stderr] 53 | | path = fs::read_link(path.clone()).unwrap(); [INFO] [stderr] 54 | | metadata = fs::metadata(path.clone()).unwrap(); [INFO] [stderr] 55 | | } [INFO] [stderr] | |_____________________^ help: it is more idiomatic to write: `let metadata = if sl { ..; fs::metadata(path.clone()).unwrap() } else { de.metadata().unwrap() };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/blockchain/utils/reader.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | / let in_count: VarUint; [INFO] [stderr] 55 | | if marker == 0x00 { [INFO] [stderr] 56 | | // SegWit hack [INFO] [stderr] 57 | | /*let flag = */try!(self.read_u8()); [INFO] [stderr] ... | [INFO] [stderr] 66 | | }; [INFO] [stderr] 67 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] help: it is more idiomatic to write [INFO] [stderr] | [INFO] [stderr] 54 | let in_count = if marker == 0x00 { ..; match $ expr { [INFO] [stderr] 55 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 56 | :: Err ( err ) => { [INFO] [stderr] 57 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 58 | $ crate :: convert :: From :: from ( err ) ) } } } else { match marker { [INFO] [stderr] 59 | 0x01...0xfc => VarUint::from(marker), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: The function/method `merkle_root` doesn't need a mutable reference [INFO] [stderr] --> src/blockchain/utils/mod.rs:61:24 [INFO] [stderr] | [INFO] [stderr] 61 | return merkle_root(&mut hash_pairs); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/blockchain/utils/mod.rs:131:5 [INFO] [stderr] | [INFO] [stderr] 131 | PathBuf::from(env::home_dir().expect("Unable to get home path from env!")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `PathBuf::from()`: `env::home_dir().expect("Unable to get home path from env!")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/blockchain/utils/mod.rs:141:27 [INFO] [stderr] | [INFO] [stderr] 141 | let sum = slice.iter() [INFO] [stderr] | ___________________________^ [INFO] [stderr] 142 | | .fold(0, |sum, &s| sum + s); [INFO] [stderr] | |__________________________________^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/blockchain/utils/mod.rs:143:5 [INFO] [stderr] | [INFO] [stderr] 143 | sum as f64 / slice.len() as f64 [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(sum)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the `p @ _` pattern can be written as just `p` [INFO] [stderr] --> src/callbacks/stats.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | p @ _ => p [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/callbacks/stats.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | / if !self.n_tx_types.contains_key(&pattern) { [INFO] [stderr] 52 | | self.n_tx_types.insert(pattern.clone(), 1); [INFO] [stderr] 53 | | self.tx_first_occs.insert(pattern, (block_height, txid, index)); [INFO] [stderr] 54 | | } else { [INFO] [stderr] 55 | | let counter = self.n_tx_types.entry(pattern).or_insert(1); [INFO] [stderr] 56 | | *counter += 1; [INFO] [stderr] 57 | | } [INFO] [stderr] | |_________^ help: consider using: `self.n_tx_types.entry(pattern)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: the variable `i` is used as a loop counter. Consider using `for (i, item) in tx.value.outputs.enumerate()` or similar iterators [INFO] [stderr] --> src/callbacks/stats.rs:96:22 [INFO] [stderr] | [INFO] [stderr] 96 | for o in tx.value.outputs { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/callbacks/stats.rs:156:23 [INFO] [stderr] | [INFO] [stderr] 156 | let pos = self.tx_first_occs.get(pattern).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.tx_first_occs[pattern]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/callbacks/csvdump.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | let ref dump_folder = PathBuf::from(matches.value_of("dump-folder").unwrap()); // Save to unwrap [INFO] [stderr] | ----^^^^^^^^^^^^^^^----------------------------------------------------------- help: try: `let dump_folder = &PathBuf::from(matches.value_of("dump-folder").unwrap());` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/callbacks/csvdump.rs:112:18 [INFO] [stderr] | [INFO] [stderr] 112 | for f in vec!["blocks", "transactions", "tx_in", "tx_out"] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&["blocks", "transactions", "tx_in", "tx_out"]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/callbacks/unspentcsvdump.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | let ref dump_folder = PathBuf::from(matches.value_of("dump-folder").unwrap()); // Save to unwrap [INFO] [stderr] | ----^^^^^^^^^^^^^^^----------------------------------------------------------- help: try: `let dump_folder = &PathBuf::from(matches.value_of("dump-folder").unwrap());` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/callbacks/unspentcsvdump.rs:160:18 [INFO] [stderr] | [INFO] [stderr] 160 | for f in vec!["unspent"] { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: you can use a slice directly: `&["unspent"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:94:26 [INFO] [stderr] | [INFO] [stderr] 94 | let parse_mode = match chain_file.len() == 0 || resume { [INFO] [stderr] | __________________________^ [INFO] [stderr] 95 | | true => ParseMode::Indexing, [INFO] [stderr] 96 | | false => ParseMode::FullData [INFO] [stderr] 97 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if chain_file.len() == 0 || resume { ParseMode::Indexing } else { ParseMode::FullData }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/main.rs:155:47 [INFO] [stderr] | [INFO] [stderr] 155 | let err = match chain::ChainStorage::load(path.clone()) { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 155 | let err = match chain::ChainStorage::load(&(*path).clone()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 155 | let err = match chain::ChainStorage::load(&std::path::Path::clone(path)) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the `kind @ _` pattern can be written as just `kind` [INFO] [stderr] --> src/main.rs:167:9 [INFO] [stderr] | [INFO] [stderr] 167 | kind @ _ => return Err(OpError::new(kind)) [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:242:5 [INFO] [stderr] | [INFO] [stderr] 242 | / let mut blockchain_path = utils::get_absolute_blockchain_dir(&coin_type); [INFO] [stderr] 243 | | if matches.value_of("blockchain-dir").is_some() { [INFO] [stderr] 244 | | blockchain_path = PathBuf::from(matches.value_of("blockchain-dir").unwrap()); [INFO] [stderr] 245 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let blockchain_path = if matches.value_of("blockchain-dir").is_some() { PathBuf::from(matches.value_of("blockchain-dir").unwrap()) } else { utils::get_absolute_blockchain_dir(&coin_type) };` [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:241:57 [INFO] [stderr] | [INFO] [stderr] 241 | let coin_type = value_t!(matches, "coin", CoinType).unwrap_or(CoinType::from(Bitcoin)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| CoinType::from(Bitcoin))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rusty-blockparser`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "d99c8f50d7db9f5cd7cf79b470a54b7b14d8bc061c9bc688a9b6cecdec38b3e7"` [INFO] running `"docker" "rm" "-f" "d99c8f50d7db9f5cd7cf79b470a54b7b14d8bc061c9bc688a9b6cecdec38b3e7"` [INFO] [stdout] d99c8f50d7db9f5cd7cf79b470a54b7b14d8bc061c9bc688a9b6cecdec38b3e7