[INFO] crate rusturn 0.0.2 is already in cache [INFO] extracting crate rusturn 0.0.2 into work/ex/clippy-test-run/sources/stable/reg/rusturn/0.0.2 [INFO] extracting crate rusturn 0.0.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rusturn/0.0.2 [INFO] validating manifest of rusturn-0.0.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rusturn-0.0.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rusturn-0.0.2 [INFO] finished frobbing rusturn-0.0.2 [INFO] frobbed toml for rusturn-0.0.2 written to work/ex/clippy-test-run/sources/stable/reg/rusturn/0.0.2/Cargo.toml [INFO] started frobbing rusturn-0.0.2 [INFO] finished frobbing rusturn-0.0.2 [INFO] frobbed toml for rusturn-0.0.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rusturn/0.0.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded fibers_global v0.1.1 [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rusturn-0.0.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rusturn/0.0.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f09c5bcb580b09c726128f439a191134caa91a7405a096fd86b2c19d1c1a624d [INFO] running `"docker" "start" "-a" "f09c5bcb580b09c726128f439a191134caa91a7405a096fd86b2c19d1c1a624d"` [INFO] [stderr] Checking splay_tree v0.2.10 [INFO] [stderr] Checking nbchan v0.1.3 [INFO] [stderr] Checking factory v0.1.1 [INFO] [stderr] Checking md5 v0.4.0 [INFO] [stderr] Compiling trackable_derive v0.1.2 [INFO] [stderr] Checking fibers v0.1.12 [INFO] [stderr] Checking trackable v0.2.21 [INFO] [stderr] Checking fibers_timeout_queue v0.1.0 [INFO] [stderr] Checking fibers_global v0.1.1 [INFO] [stderr] Checking bytecodec v0.4.11 [INFO] [stderr] Checking fibers_transport v0.1.2 [INFO] [stderr] Checking stun_codec v0.1.10 [INFO] [stderr] Checking rustun v0.3.5 [INFO] [stderr] Checking rusturn v0.0.2 (/opt/crater/workdir) [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/client/core.rs:143:21 [INFO] [stderr] | [INFO] [stderr] 143 | / match attr { [INFO] [stderr] 144 | | Attribute::MessageIntegrity(a) => { [INFO] [stderr] 145 | | track!(self.auth_params.validate(&a))?; [INFO] [stderr] 146 | | } [INFO] [stderr] 147 | | _ => {} [INFO] [stderr] 148 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 143 | if let Attribute::MessageIntegrity(a) = attr { [INFO] [stderr] 144 | track!(self.auth_params.validate(&a))?; [INFO] [stderr] 145 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/client/core.rs:182:21 [INFO] [stderr] | [INFO] [stderr] 182 | / match attr { [INFO] [stderr] 183 | | Attribute::MessageIntegrity(a) => { [INFO] [stderr] 184 | | track!(self.auth_params.validate(&a))?; [INFO] [stderr] 185 | | } [INFO] [stderr] 186 | | _ => {} [INFO] [stderr] 187 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 182 | if let Attribute::MessageIntegrity(a) = attr { [INFO] [stderr] 183 | track!(self.auth_params.validate(&a))?; [INFO] [stderr] 184 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/client/core.rs:402:13 [INFO] [stderr] | [INFO] [stderr] 402 | / while let Async::Ready(data) = track!(self.channel_data_transporter.poll_recv())? { [INFO] [stderr] 403 | | if let Some((_, data)) = data { [INFO] [stderr] 404 | | let (peer, data) = track!(self.handle_channel_data(data))?; [INFO] [stderr] 405 | | return Ok(Async::Ready(Some((peer, data)))); [INFO] [stderr] ... | [INFO] [stderr] 408 | | } [INFO] [stderr] 409 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/server/core.rs:126:9 [INFO] [stderr] | [INFO] [stderr] 126 | track!(self.stun_channel.reply(client, Ok(response))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/server/core.rs:150:30 [INFO] [stderr] | [INFO] [stderr] 150 | let channel_number = track_assert_some!( [INFO] [stderr] | ______________________________^ [INFO] [stderr] 151 | | request.get_attribute::(), [INFO] [stderr] 152 | | ErrorKind::InvalidInput [INFO] [stderr] 153 | | ).clone(); [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 150 | let channel_number = *(if let Some ( v ) = $ expr { v } else { [INFO] [stderr] 151 | track_panic ! ( [INFO] [stderr] 152 | $ error_kind , "assertion failed: `{}.is_some()`" , stringify ! ( $ expr ) ) }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/server/core.rs:167:9 [INFO] [stderr] | [INFO] [stderr] 167 | track!(self.stun_channel.reply(client, Ok(response))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/server/core.rs:385:34 [INFO] [stderr] | [INFO] [stderr] 385 | .map(|x| x.0.clone()) [INFO] [stderr] | ^^^^^^^^^^^ help: try dereferencing it: `*x.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/turn_message.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | Stun(stun::MessageDecoder), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 16 | Stun(Box>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/turn_message.rs:76:5 [INFO] [stderr] | [INFO] [stderr] 76 | Stun(stun::MessageEncoder), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 76 | Stun(Box>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/lib.rs:117:9 [INFO] [stderr] | [INFO] [stderr] 117 | let _ = self.0.exit(result); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rusturn`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/client/core.rs:143:21 [INFO] [stderr] | [INFO] [stderr] 143 | / match attr { [INFO] [stderr] 144 | | Attribute::MessageIntegrity(a) => { [INFO] [stderr] 145 | | track!(self.auth_params.validate(&a))?; [INFO] [stderr] 146 | | } [INFO] [stderr] 147 | | _ => {} [INFO] [stderr] 148 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 143 | if let Attribute::MessageIntegrity(a) = attr { [INFO] [stderr] 144 | track!(self.auth_params.validate(&a))?; [INFO] [stderr] 145 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/client/core.rs:182:21 [INFO] [stderr] | [INFO] [stderr] 182 | / match attr { [INFO] [stderr] 183 | | Attribute::MessageIntegrity(a) => { [INFO] [stderr] 184 | | track!(self.auth_params.validate(&a))?; [INFO] [stderr] 185 | | } [INFO] [stderr] 186 | | _ => {} [INFO] [stderr] 187 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 182 | if let Attribute::MessageIntegrity(a) = attr { [INFO] [stderr] 183 | track!(self.auth_params.validate(&a))?; [INFO] [stderr] 184 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/client/core.rs:402:13 [INFO] [stderr] | [INFO] [stderr] 402 | / while let Async::Ready(data) = track!(self.channel_data_transporter.poll_recv())? { [INFO] [stderr] 403 | | if let Some((_, data)) = data { [INFO] [stderr] 404 | | let (peer, data) = track!(self.handle_channel_data(data))?; [INFO] [stderr] 405 | | return Ok(Async::Ready(Some((peer, data)))); [INFO] [stderr] ... | [INFO] [stderr] 408 | | } [INFO] [stderr] 409 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/server/core.rs:126:9 [INFO] [stderr] | [INFO] [stderr] 126 | track!(self.stun_channel.reply(client, Ok(response))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/server/core.rs:150:30 [INFO] [stderr] | [INFO] [stderr] 150 | let channel_number = track_assert_some!( [INFO] [stderr] | ______________________________^ [INFO] [stderr] 151 | | request.get_attribute::(), [INFO] [stderr] 152 | | ErrorKind::InvalidInput [INFO] [stderr] 153 | | ).clone(); [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 150 | let channel_number = *(if let Some ( v ) = $ expr { v } else { [INFO] [stderr] 151 | track_panic ! ( [INFO] [stderr] 152 | $ error_kind , "assertion failed: `{}.is_some()`" , stringify ! ( $ expr ) ) }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/server/core.rs:167:9 [INFO] [stderr] | [INFO] [stderr] 167 | track!(self.stun_channel.reply(client, Ok(response))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/server/core.rs:385:34 [INFO] [stderr] | [INFO] [stderr] 385 | .map(|x| x.0.clone()) [INFO] [stderr] | ^^^^^^^^^^^ help: try dereferencing it: `*x.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/turn_message.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | Stun(stun::MessageDecoder), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 16 | Stun(Box>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/turn_message.rs:76:5 [INFO] [stderr] | [INFO] [stderr] 76 | Stun(stun::MessageEncoder), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 76 | Stun(Box>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/lib.rs:117:9 [INFO] [stderr] | [INFO] [stderr] 117 | let _ = self.0.exit(result); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rusturn`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "f09c5bcb580b09c726128f439a191134caa91a7405a096fd86b2c19d1c1a624d"` [INFO] running `"docker" "rm" "-f" "f09c5bcb580b09c726128f439a191134caa91a7405a096fd86b2c19d1c1a624d"` [INFO] [stdout] f09c5bcb580b09c726128f439a191134caa91a7405a096fd86b2c19d1c1a624d