[INFO] crate rustsym 0.3.2 is already in cache [INFO] extracting crate rustsym 0.3.2 into work/ex/clippy-test-run/sources/stable/reg/rustsym/0.3.2 [INFO] extracting crate rustsym 0.3.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rustsym/0.3.2 [INFO] validating manifest of rustsym-0.3.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rustsym-0.3.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rustsym-0.3.2 [INFO] finished frobbing rustsym-0.3.2 [INFO] frobbed toml for rustsym-0.3.2 written to work/ex/clippy-test-run/sources/stable/reg/rustsym/0.3.2/Cargo.toml [INFO] started frobbing rustsym-0.3.2 [INFO] finished frobbing rustsym-0.3.2 [INFO] frobbed toml for rustsym-0.3.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rustsym/0.3.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rustsym-0.3.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rustsym/0.3.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8191f36d3908e227063b611f7078303eee012cd86db2fa9db05b7756d86cb8f3 [INFO] running `"docker" "start" "-a" "8191f36d3908e227063b611f7078303eee012cd86db2fa9db05b7756d86cb8f3"` [INFO] [stderr] Checking syncbox v0.2.4 [INFO] [stderr] Checking syntex_syntax v0.59.1 [INFO] [stderr] Checking rustsym v0.3.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/visitor.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | kind: kind, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/visitor.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | line: line, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:194:9 [INFO] [stderr] | [INFO] [stderr] 194 | search_children: search_children, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `search_children` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/visitor.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | kind: kind, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/visitor.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | line: line, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:194:9 [INFO] [stderr] | [INFO] [stderr] 194 | search_children: search_children, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `search_children` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/visitor.rs:69:17 [INFO] [stderr] | [INFO] [stderr] 69 | / if !self.search_children { [INFO] [stderr] 70 | | if self.codemap.span_to_filename(item.span) != self.codemap.span_to_filename(mod_.inner) { [INFO] [stderr] 71 | | // Don't visit submodules that are not inline. [INFO] [stderr] 72 | | return; [INFO] [stderr] 73 | | } [INFO] [stderr] 74 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 69 | if !self.search_children && self.codemap.span_to_filename(item.span) != self.codemap.span_to_filename(mod_.inner) { [INFO] [stderr] 70 | // Don't visit submodules that are not inline. [INFO] [stderr] 71 | return; [INFO] [stderr] 72 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/visitor.rs:34:26 [INFO] [stderr] | [INFO] [stderr] 34 | fn get_ident_name(ident: &ast::Ident) -> String { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `ast::Ident` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/main.rs:108:9 [INFO] [stderr] | [INFO] [stderr] 108 | Err(_) => { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/visitor.rs:69:17 [INFO] [stderr] | [INFO] [stderr] 69 | / if !self.search_children { [INFO] [stderr] 70 | | if self.codemap.span_to_filename(item.span) != self.codemap.span_to_filename(mod_.inner) { [INFO] [stderr] 71 | | // Don't visit submodules that are not inline. [INFO] [stderr] 72 | | return; [INFO] [stderr] 73 | | } [INFO] [stderr] 74 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 69 | if !self.search_children && self.codemap.span_to_filename(item.span) != self.codemap.span_to_filename(mod_.inner) { [INFO] [stderr] 70 | // Don't visit submodules that are not inline. [INFO] [stderr] 71 | return; [INFO] [stderr] 72 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/visitor.rs:34:26 [INFO] [stderr] | [INFO] [stderr] 34 | fn get_ident_name(ident: &ast::Ident) -> String { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `ast::Ident` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/main.rs:108:9 [INFO] [stderr] | [INFO] [stderr] 108 | Err(_) => { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:440:13 [INFO] [stderr] | [INFO] [stderr] 440 | let ref symbol = matches[0]; [INFO] [stderr] | ----^^^^^^^^^^-------------- help: try: `let symbol = &matches[0];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:446:13 [INFO] [stderr] | [INFO] [stderr] 446 | let ref symbol = matches[1]; [INFO] [stderr] | ----^^^^^^^^^^-------------- help: try: `let symbol = &matches[1];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:452:13 [INFO] [stderr] | [INFO] [stderr] 452 | let ref symbol = matches[2]; [INFO] [stderr] | ----^^^^^^^^^^-------------- help: try: `let symbol = &matches[2];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:471:13 [INFO] [stderr] | [INFO] [stderr] 471 | let ref symbol = matches[0]; [INFO] [stderr] | ----^^^^^^^^^^-------------- help: try: `let symbol = &matches[0];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:477:13 [INFO] [stderr] | [INFO] [stderr] 477 | let ref symbol = matches[1]; [INFO] [stderr] | ----^^^^^^^^^^-------------- help: try: `let symbol = &matches[1];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:483:13 [INFO] [stderr] | [INFO] [stderr] 483 | let ref symbol = matches[2]; [INFO] [stderr] | ----^^^^^^^^^^-------------- help: try: `let symbol = &matches[2];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:503:13 [INFO] [stderr] | [INFO] [stderr] 503 | let ref symbol = matches[0]; [INFO] [stderr] | ----^^^^^^^^^^-------------- help: try: `let symbol = &matches[0];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:509:13 [INFO] [stderr] | [INFO] [stderr] 509 | let ref symbol = matches[1]; [INFO] [stderr] | ----^^^^^^^^^^-------------- help: try: `let symbol = &matches[1];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:515:13 [INFO] [stderr] | [INFO] [stderr] 515 | let ref symbol = matches[2]; [INFO] [stderr] | ----^^^^^^^^^^-------------- help: try: `let symbol = &matches[2];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:521:13 [INFO] [stderr] | [INFO] [stderr] 521 | let ref symbol = matches[3]; [INFO] [stderr] | ----^^^^^^^^^^-------------- help: try: `let symbol = &matches[3];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:539:13 [INFO] [stderr] | [INFO] [stderr] 539 | let ref symbol = matches[0]; [INFO] [stderr] | ----^^^^^^^^^^-------------- help: try: `let symbol = &matches[0];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:545:13 [INFO] [stderr] | [INFO] [stderr] 545 | let ref symbol = matches[1]; [INFO] [stderr] | ----^^^^^^^^^^-------------- help: try: `let symbol = &matches[1];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 28.32s [INFO] running `"docker" "inspect" "8191f36d3908e227063b611f7078303eee012cd86db2fa9db05b7756d86cb8f3"` [INFO] running `"docker" "rm" "-f" "8191f36d3908e227063b611f7078303eee012cd86db2fa9db05b7756d86cb8f3"` [INFO] [stdout] 8191f36d3908e227063b611f7078303eee012cd86db2fa9db05b7756d86cb8f3