[INFO] crate rustsourcebundler 0.6.0 is already in cache [INFO] extracting crate rustsourcebundler 0.6.0 into work/ex/clippy-test-run/sources/stable/reg/rustsourcebundler/0.6.0 [INFO] extracting crate rustsourcebundler 0.6.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rustsourcebundler/0.6.0 [INFO] validating manifest of rustsourcebundler-0.6.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rustsourcebundler-0.6.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rustsourcebundler-0.6.0 [INFO] finished frobbing rustsourcebundler-0.6.0 [INFO] frobbed toml for rustsourcebundler-0.6.0 written to work/ex/clippy-test-run/sources/stable/reg/rustsourcebundler/0.6.0/Cargo.toml [INFO] started frobbing rustsourcebundler-0.6.0 [INFO] finished frobbing rustsourcebundler-0.6.0 [INFO] frobbed toml for rustsourcebundler-0.6.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rustsourcebundler/0.6.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rustsourcebundler-0.6.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rustsourcebundler/0.6.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b4eb6a1792d37f0e8483349d6a4df7a5e396f61af4c21315432234bb31940a4f [INFO] running `"docker" "start" "-a" "b4eb6a1792d37f0e8483349d6a4df7a5e396f61af4c21315432234bb31940a4f"` [INFO] [stderr] Checking rustsourcebundler v0.6.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | binrs_filename: binrs_filename, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `binrs_filename` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | bundle_filename: bundle_filename, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bundle_filename` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | binrs_filename: binrs_filename, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `binrs_filename` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | bundle_filename: bundle_filename, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bundle_filename` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:18:24 [INFO] [stderr] | [INFO] [stderr] 18 | const LIBRS_FILENAME: &'static str = "src/lib.rs"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:18:24 [INFO] [stderr] | [INFO] [stderr] 18 | const LIBRS_FILENAME: &'static str = "src/lib.rs"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:47:57 [INFO] [stderr] | [INFO] [stderr] 47 | let mut o = File::create(&self.bundle_filename).expect(&format!( [INFO] [stderr] | _________________________________________________________^ [INFO] [stderr] 48 | | "error creating {}", [INFO] [stderr] 49 | | &self.bundle_filename.display() [INFO] [stderr] 50 | | )); [INFO] [stderr] | |__________^ help: try this: `unwrap_or_else(|_| panic!("error creating {}", &self.bundle_filename.display()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:51:28 [INFO] [stderr] | [INFO] [stderr] 51 | self.binrs(&mut o).expect(&format!( [INFO] [stderr] | ____________________________^ [INFO] [stderr] 52 | | "error creating bundle {} for {}", [INFO] [stderr] 53 | | self.bundle_filename.display(), [INFO] [stderr] 54 | | self.binrs_filename.display() [INFO] [stderr] 55 | | )); [INFO] [stderr] | |__________^ help: try this: `unwrap_or_else(|_| panic!("error creating bundle {} for {}", self.bundle_filename.display()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/lib.rs:124:22 [INFO] [stderr] | [INFO] [stderr] 124 | let mod_fd = mod_filenames0.iter().map(|fn0| { [INFO] [stderr] | ______________________^ [INFO] [stderr] 125 | | let mod_filename = Path::new(&fn0); [INFO] [stderr] 126 | | File::open(mod_filename) [INFO] [stderr] 127 | | }).filter(|fd| fd.is_ok()).next(); [INFO] [stderr] | |_________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::filter_next)] on by default [INFO] [stderr] = note: replace `filter(|fd| fd.is_ok()).next()` with `find(|fd| fd.is_ok())` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:47:57 [INFO] [stderr] | [INFO] [stderr] 47 | let mut o = File::create(&self.bundle_filename).expect(&format!( [INFO] [stderr] | _________________________________________________________^ [INFO] [stderr] 48 | | "error creating {}", [INFO] [stderr] 49 | | &self.bundle_filename.display() [INFO] [stderr] 50 | | )); [INFO] [stderr] | |__________^ help: try this: `unwrap_or_else(|_| panic!("error creating {}", &self.bundle_filename.display()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:51:28 [INFO] [stderr] | [INFO] [stderr] 51 | self.binrs(&mut o).expect(&format!( [INFO] [stderr] | ____________________________^ [INFO] [stderr] 52 | | "error creating bundle {} for {}", [INFO] [stderr] 53 | | self.bundle_filename.display(), [INFO] [stderr] 54 | | self.binrs_filename.display() [INFO] [stderr] 55 | | )); [INFO] [stderr] | |__________^ help: try this: `unwrap_or_else(|_| panic!("error creating bundle {} for {}", self.bundle_filename.display()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/lib.rs:124:22 [INFO] [stderr] | [INFO] [stderr] 124 | let mod_fd = mod_filenames0.iter().map(|fn0| { [INFO] [stderr] | ______________________^ [INFO] [stderr] 125 | | let mod_filename = Path::new(&fn0); [INFO] [stderr] 126 | | File::open(mod_filename) [INFO] [stderr] 127 | | }).filter(|fd| fd.is_ok()).next(); [INFO] [stderr] | |_________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::filter_next)] on by default [INFO] [stderr] = note: replace `filter(|fd| fd.is_ok()).next()` with `find(|fd| fd.is_ok())` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.27s [INFO] running `"docker" "inspect" "b4eb6a1792d37f0e8483349d6a4df7a5e396f61af4c21315432234bb31940a4f"` [INFO] running `"docker" "rm" "-f" "b4eb6a1792d37f0e8483349d6a4df7a5e396f61af4c21315432234bb31940a4f"` [INFO] [stdout] b4eb6a1792d37f0e8483349d6a4df7a5e396f61af4c21315432234bb31940a4f