[INFO] crate rustpiet 0.1.1 is already in cache [INFO] extracting crate rustpiet 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/rustpiet/0.1.1 [INFO] extracting crate rustpiet 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rustpiet/0.1.1 [INFO] validating manifest of rustpiet-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rustpiet-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rustpiet-0.1.1 [INFO] finished frobbing rustpiet-0.1.1 [INFO] frobbed toml for rustpiet-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/rustpiet/0.1.1/Cargo.toml [INFO] started frobbing rustpiet-0.1.1 [INFO] finished frobbing rustpiet-0.1.1 [INFO] frobbed toml for rustpiet-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rustpiet/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rustpiet-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rustpiet/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 529643f16431ddd6e66f0da9a91299ebcd53f9e67469eefb52bd01fcb550accd [INFO] running `"docker" "start" "-a" "529643f16431ddd6e66f0da9a91299ebcd53f9e67469eefb52bd01fcb550accd"` [INFO] [stderr] Checking png v0.8.0 [INFO] [stderr] Checking image v0.14.0 [INFO] [stderr] Checking rustpiet v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interpreter.rs:65:13 [INFO] [stderr] | [INFO] [stderr] 65 | image: image, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `image` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interpreter.rs:65:13 [INFO] [stderr] | [INFO] [stderr] 65 | image: image, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `image` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded `()` [INFO] [stderr] --> src/ops.rs:122:24 [INFO] [stderr] | [INFO] [stderr] 122 | None => return (), [INFO] [stderr] | ^^ help: remove the `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/interpreter.rs:122:46 [INFO] [stderr] | [INFO] [stderr] 122 | fn process_action(&mut self, next_color: &Rgba) { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `Rgba` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/colors.rs:3:26 [INFO] [stderr] | [INFO] [stderr] 3 | pub fn color_code(color: &Rgba) -> Option { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `Rgba` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/ops.rs:101:18 [INFO] [stderr] | [INFO] [stderr] 101 | for _ in 1..n.abs() + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `1..=n.abs()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/ops.rs:113:18 [INFO] [stderr] | [INFO] [stderr] 113 | for _ in 1..n.abs() + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `1..=n.abs()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/ops.rs:132:18 [INFO] [stderr] | [INFO] [stderr] 132 | for _ in 1..rolls.abs() + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: use: `1..=rolls.abs()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: unneeded `()` [INFO] [stderr] --> src/ops.rs:122:24 [INFO] [stderr] | [INFO] [stderr] 122 | None => return (), [INFO] [stderr] | ^^ help: remove the `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/interpreter.rs:122:46 [INFO] [stderr] | [INFO] [stderr] 122 | fn process_action(&mut self, next_color: &Rgba) { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `Rgba` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/colors.rs:3:26 [INFO] [stderr] | [INFO] [stderr] 3 | pub fn color_code(color: &Rgba) -> Option { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `Rgba` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/ops.rs:101:18 [INFO] [stderr] | [INFO] [stderr] 101 | for _ in 1..n.abs() + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `1..=n.abs()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/ops.rs:113:18 [INFO] [stderr] | [INFO] [stderr] 113 | for _ in 1..n.abs() + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `1..=n.abs()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/ops.rs:132:18 [INFO] [stderr] | [INFO] [stderr] 132 | for _ in 1..rolls.abs() + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: use: `1..=rolls.abs()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 12.26s [INFO] running `"docker" "inspect" "529643f16431ddd6e66f0da9a91299ebcd53f9e67469eefb52bd01fcb550accd"` [INFO] running `"docker" "rm" "-f" "529643f16431ddd6e66f0da9a91299ebcd53f9e67469eefb52bd01fcb550accd"` [INFO] [stdout] 529643f16431ddd6e66f0da9a91299ebcd53f9e67469eefb52bd01fcb550accd