[INFO] crate rustop 1.0.2 is already in cache
[INFO] extracting crate rustop 1.0.2 into work/ex/clippy-test-run/sources/stable/reg/rustop/1.0.2
[INFO] extracting crate rustop 1.0.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rustop/1.0.2
[INFO] validating manifest of rustop-1.0.2 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of rustop-1.0.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing rustop-1.0.2
[INFO] finished frobbing rustop-1.0.2
[INFO] frobbed toml for rustop-1.0.2 written to work/ex/clippy-test-run/sources/stable/reg/rustop/1.0.2/Cargo.toml
[INFO] started frobbing rustop-1.0.2
[INFO] finished frobbing rustop-1.0.2
[INFO] frobbed toml for rustop-1.0.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rustop/1.0.2/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting rustop-1.0.2 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rustop/1.0.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] ea13819c3df71b1dd26bf75f57f5500ea2337522d441f20ad8583b96b19b5a6f
[INFO] running `"docker" "start" "-a" "ea13819c3df71b1dd26bf75f57f5500ea2337522d441f20ad8583b96b19b5a6f"`
[INFO] [stderr]     Checking rustop v1.0.2 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/rustop.rs:830:13
[INFO] [stderr]     |
[INFO] [stderr] 830 |             default: default,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^ help: replace it with: `default`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/rustop.rs:854:13
[INFO] [stderr]     |
[INFO] [stderr] 854 |             default: default,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^ help: replace it with: `default`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/rustop.rs:830:13
[INFO] [stderr]     |
[INFO] [stderr] 830 |             default: default,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^ help: replace it with: `default`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/rustop.rs:854:13
[INFO] [stderr]     |
[INFO] [stderr] 854 |             default: default,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^ help: replace it with: `default`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/rustop.rs:613:22
[INFO] [stderr]     |
[INFO] [stderr] 613 |         name.or_else(|| T::default_name()).map(|n| n.to_string())
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `T::default_name`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/rustop.rs:650:22
[INFO] [stderr]     |
[INFO] [stderr] 650 |         name.or_else(|| T::default_name())
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `T::default_name`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/rustop.rs:686:22
[INFO] [stderr]     |
[INFO] [stderr] 686 |         name.or_else(|| T::default_name())
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `T::default_name`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `while let` loop
[INFO] [stderr]     --> src/rustop.rs:1080:13
[INFO] [stderr]      |
[INFO] [stderr] 1080 | /             loop {
[INFO] [stderr] 1081 | |                 if let Some(arg) = args.peek() {
[INFO] [stderr] 1082 | |                     if self.stopons.contains(arg) || (arg.len() >= 2 && &arg[0..1] == "-") {
[INFO] [stderr] 1083 | |                         break;
[INFO] [stderr] ...    |
[INFO] [stderr] 1091 | |                 args.next();
[INFO] [stderr] 1092 | |             }
[INFO] [stderr]      | |_____________^ help: try: `while let Some(arg) = args.peek() { .. }`
[INFO] [stderr]      |
[INFO] [stderr]      = note: #[warn(clippy::while_let_loop)] on by default
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
[INFO] [stderr] 
[INFO] [stderr] warning: this boolean expression can be simplified
[INFO] [stderr]     --> src/rustop.rs:1131:16
[INFO] [stderr]      |
[INFO] [stderr] 1131 |             if opt.seen && !(opt.var.is_multi() && !opt.multi) {
[INFO] [stderr]      |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(!opt.var.is_multi() || opt.multi) && opt.seen`
[INFO] [stderr]      |
[INFO] [stderr]      = note: #[warn(clippy::nonminimal_bool)] on by default
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 26
[INFO] [stderr]     --> src/rustop.rs:1215:5
[INFO] [stderr]      |
[INFO] [stderr] 1215 | /     pub fn write_usage(&self, output: &mut std::io::Write) -> Result<(), std::io::Error> {
[INFO] [stderr] 1216 | |         if let Some(u) = self.usage {
[INFO] [stderr] 1217 | |             if u.is_empty() {
[INFO] [stderr] 1218 | |                 // nothing to show
[INFO] [stderr] ...    |
[INFO] [stderr] 1340 | |         Ok(())
[INFO] [stderr] 1341 | |     }
[INFO] [stderr]      | |_____^
[INFO] [stderr]      |
[INFO] [stderr]      = note: #[warn(clippy::cyclomatic_complexity)] on by default
[INFO] [stderr]      = help: you could split it up into multiple smaller functions
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/rustop.rs:613:22
[INFO] [stderr]     |
[INFO] [stderr] 613 |         name.or_else(|| T::default_name()).map(|n| n.to_string())
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `T::default_name`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/rustop.rs:650:22
[INFO] [stderr]     |
[INFO] [stderr] 650 |         name.or_else(|| T::default_name())
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `T::default_name`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/rustop.rs:686:22
[INFO] [stderr]     |
[INFO] [stderr] 686 |         name.or_else(|| T::default_name())
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `T::default_name`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `while let` loop
[INFO] [stderr]     --> src/rustop.rs:1080:13
[INFO] [stderr]      |
[INFO] [stderr] 1080 | /             loop {
[INFO] [stderr] 1081 | |                 if let Some(arg) = args.peek() {
[INFO] [stderr] 1082 | |                     if self.stopons.contains(arg) || (arg.len() >= 2 && &arg[0..1] == "-") {
[INFO] [stderr] 1083 | |                         break;
[INFO] [stderr] ...    |
[INFO] [stderr] 1091 | |                 args.next();
[INFO] [stderr] 1092 | |             }
[INFO] [stderr]      | |_____________^ help: try: `while let Some(arg) = args.peek() { .. }`
[INFO] [stderr]      |
[INFO] [stderr]      = note: #[warn(clippy::while_let_loop)] on by default
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
[INFO] [stderr] 
[INFO] [stderr] warning: this boolean expression can be simplified
[INFO] [stderr]     --> src/rustop.rs:1131:16
[INFO] [stderr]      |
[INFO] [stderr] 1131 |             if opt.seen && !(opt.var.is_multi() && !opt.multi) {
[INFO] [stderr]      |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(!opt.var.is_multi() || opt.multi) && opt.seen`
[INFO] [stderr]      |
[INFO] [stderr]      = note: #[warn(clippy::nonminimal_bool)] on by default
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 26
[INFO] [stderr]     --> src/rustop.rs:1215:5
[INFO] [stderr]      |
[INFO] [stderr] 1215 | /     pub fn write_usage(&self, output: &mut std::io::Write) -> Result<(), std::io::Error> {
[INFO] [stderr] 1216 | |         if let Some(u) = self.usage {
[INFO] [stderr] 1217 | |             if u.is_empty() {
[INFO] [stderr] 1218 | |                 // nothing to show
[INFO] [stderr] ...    |
[INFO] [stderr] 1340 | |         Ok(())
[INFO] [stderr] 1341 | |     }
[INFO] [stderr]      | |_____^
[INFO] [stderr]      |
[INFO] [stderr]      = note: #[warn(clippy::cyclomatic_complexity)] on by default
[INFO] [stderr]      = help: you could split it up into multiple smaller functions
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against false can be replaced by a negation
[INFO] [stderr]     --> src/rustop.rs:2045:13
[INFO] [stderr]      |
[INFO] [stderr] 2045 |     assert!(args.doit == false);
[INFO] [stderr]      |             ^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!args.doit`
[INFO] [stderr]      |
[INFO] [stderr]      = note: #[warn(clippy::bool_comparison)] on by default
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against true are unnecessary
[INFO] [stderr]     --> src/rustop.rs:2046:13
[INFO] [stderr]      |
[INFO] [stderr] 2046 |     assert!(args.doit2 == true);
[INFO] [stderr]      |             ^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `args.doit2`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 2.54s
[INFO] running `"docker" "inspect" "ea13819c3df71b1dd26bf75f57f5500ea2337522d441f20ad8583b96b19b5a6f"`
[INFO] running `"docker" "rm" "-f" "ea13819c3df71b1dd26bf75f57f5500ea2337522d441f20ad8583b96b19b5a6f"`
[INFO] [stdout] ea13819c3df71b1dd26bf75f57f5500ea2337522d441f20ad8583b96b19b5a6f