[INFO] crate rustlex_fsa 0.4.0 is already in cache [INFO] extracting crate rustlex_fsa 0.4.0 into work/ex/clippy-test-run/sources/stable/reg/rustlex_fsa/0.4.0 [INFO] extracting crate rustlex_fsa 0.4.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rustlex_fsa/0.4.0 [INFO] validating manifest of rustlex_fsa-0.4.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rustlex_fsa-0.4.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rustlex_fsa-0.4.0 [INFO] finished frobbing rustlex_fsa-0.4.0 [INFO] frobbed toml for rustlex_fsa-0.4.0 written to work/ex/clippy-test-run/sources/stable/reg/rustlex_fsa/0.4.0/Cargo.toml [INFO] started frobbing rustlex_fsa-0.4.0 [INFO] finished frobbing rustlex_fsa-0.4.0 [INFO] frobbed toml for rustlex_fsa-0.4.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rustlex_fsa/0.4.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rustlex_fsa-0.4.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rustlex_fsa/0.4.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 55d86bddb8ba926f07fb7e4d8d3a1d6e7d7b453bbc3fae2ad1b9d93083325773 [INFO] running `"docker" "start" "-a" "55d86bddb8ba926f07fb7e4d8d3a1d6e7d7b453bbc3fae2ad1b9d93083325773"` [INFO] [stderr] Checking rustlex_fsa v0.4.0 (/opt/crater/workdir) [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `dfa::Automaton` [INFO] [stderr] --> dfa.rs:83:5 [INFO] [stderr] | [INFO] [stderr] 83 | / pub fn new() -> Automaton { [INFO] [stderr] 84 | | let mut ret = Automaton { [INFO] [stderr] 85 | | states: vec!(), [INFO] [stderr] 86 | | initials: vec!() [INFO] [stderr] ... | [INFO] [stderr] 91 | | ret [INFO] [stderr] 92 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 24 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the variable `ch` is used as a loop counter. Consider using `for (ch, item) in st.trans.iter().enumerate()` or similar iterators [INFO] [stderr] --> dfa.rs:232:22 [INFO] [stderr] | [INFO] [stderr] 232 | for t in st.trans.iter() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: the variable `i` is used as a loop counter. Consider using `for (i, item) in self.states.iter().enumerate()` or similar iterators [INFO] [stderr] --> dfa.rs:265:19 [INFO] [stderr] | [INFO] [stderr] 265 | for st in self.states.iter() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: the variable `i` is used as a loop counter. Consider using `for (i, item) in self.states.iter().enumerate()` or similar iterators [INFO] [stderr] --> dfa.rs:277:19 [INFO] [stderr] | [INFO] [stderr] 277 | for st in self.states.iter() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> nfa.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | fn etransition<'a>(&'a self) -> &'a Etrans; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `dfa::Automaton` [INFO] [stderr] --> dfa.rs:83:5 [INFO] [stderr] | [INFO] [stderr] 83 | / pub fn new() -> Automaton { [INFO] [stderr] 84 | | let mut ret = Automaton { [INFO] [stderr] 85 | | states: vec!(), [INFO] [stderr] 86 | | initials: vec!() [INFO] [stderr] ... | [INFO] [stderr] 91 | | ret [INFO] [stderr] 92 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 24 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the variable `ch` is used as a loop counter. Consider using `for (ch, item) in st.trans.iter().enumerate()` or similar iterators [INFO] [stderr] --> dfa.rs:232:22 [INFO] [stderr] | [INFO] [stderr] 232 | for t in st.trans.iter() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: the variable `i` is used as a loop counter. Consider using `for (i, item) in self.states.iter().enumerate()` or similar iterators [INFO] [stderr] --> dfa.rs:265:19 [INFO] [stderr] | [INFO] [stderr] 265 | for st in self.states.iter() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: the variable `i` is used as a loop counter. Consider using `for (i, item) in self.states.iter().enumerate()` or similar iterators [INFO] [stderr] --> dfa.rs:277:19 [INFO] [stderr] | [INFO] [stderr] 277 | for st in self.states.iter() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> nfa.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | fn etransition<'a>(&'a self) -> &'a Etrans; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.17s [INFO] running `"docker" "inspect" "55d86bddb8ba926f07fb7e4d8d3a1d6e7d7b453bbc3fae2ad1b9d93083325773"` [INFO] running `"docker" "rm" "-f" "55d86bddb8ba926f07fb7e4d8d3a1d6e7d7b453bbc3fae2ad1b9d93083325773"` [INFO] [stdout] 55d86bddb8ba926f07fb7e4d8d3a1d6e7d7b453bbc3fae2ad1b9d93083325773