[INFO] crate rustler_codegen 0.18.0 is already in cache [INFO] extracting crate rustler_codegen 0.18.0 into work/ex/clippy-test-run/sources/stable/reg/rustler_codegen/0.18.0 [INFO] extracting crate rustler_codegen 0.18.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rustler_codegen/0.18.0 [INFO] validating manifest of rustler_codegen-0.18.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rustler_codegen-0.18.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rustler_codegen-0.18.0 [INFO] finished frobbing rustler_codegen-0.18.0 [INFO] frobbed toml for rustler_codegen-0.18.0 written to work/ex/clippy-test-run/sources/stable/reg/rustler_codegen/0.18.0/Cargo.toml [INFO] started frobbing rustler_codegen-0.18.0 [INFO] finished frobbing rustler_codegen-0.18.0 [INFO] frobbed toml for rustler_codegen-0.18.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rustler_codegen/0.18.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rustler_codegen-0.18.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rustler_codegen/0.18.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1e665fa1609454cfcb4e17671c4645dadebc3a5be57a78fe90f4fd23747de369 [INFO] running `"docker" "start" "-a" "1e665fa1609454cfcb4e17671c4645dadebc3a5be57a78fe90f4fd23747de369"` [INFO] [stderr] Checking syn v0.11.11 [INFO] [stderr] Checking rustler_codegen v0.18.0 (/opt/crater/workdir) [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/tuple.rs:25:49 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn gen_decoder(struct_name: &Ident, fields: &Vec, is_tuple: bool, has_lifetime: bool) -> Tokens { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Field]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/tuple.rs:65:49 [INFO] [stderr] | [INFO] [stderr] 65 | pub fn gen_encoder(struct_name: &Ident, fields: &Vec, is_tuple: bool, has_lifetime: bool) -> Tokens { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Field]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/record.rs:6:13 [INFO] [stderr] | [INFO] [stderr] 6 | let ref attr_value = ast.attrs.iter() [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 6 | let attr_value = &ast.attrs.iter() [INFO] [stderr] 7 | .find(|attr| attr.name() == "tag") [INFO] [stderr] 8 | .expect("NifRecord requires a 'tag' attribute").value; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/record.rs:42:49 [INFO] [stderr] | [INFO] [stderr] 42 | pub fn gen_decoder(struct_name: &Ident, fields: &Vec, atom_defs: &Tokens, has_lifetime: bool) -> Tokens { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Field]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/record.rs:86:49 [INFO] [stderr] | [INFO] [stderr] 86 | pub fn gen_encoder(struct_name: &Ident, fields: &Vec, atom_defs: &Tokens, has_lifetime: bool) -> Tokens { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Field]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/map.rs:41:49 [INFO] [stderr] | [INFO] [stderr] 41 | pub fn gen_decoder(struct_name: &Ident, fields: &Vec, atom_defs: &Tokens, has_lifetime: bool) -> Tokens { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Field]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/map.rs:71:49 [INFO] [stderr] | [INFO] [stderr] 71 | pub fn gen_encoder(struct_name: &Ident, fields: &Vec, atom_defs: &Tokens, has_lifetime: bool) -> Tokens { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Field]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/ex_struct.rs:6:13 [INFO] [stderr] | [INFO] [stderr] 6 | let ref attr_value = ast.attrs.iter() [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 6 | let attr_value = &ast.attrs.iter() [INFO] [stderr] 7 | .find(|attr| attr.name() == "module") [INFO] [stderr] 8 | .expect("NifStruct requires a 'module' attribute") [INFO] [stderr] 9 | .value; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/tuple.rs:25:49 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn gen_decoder(struct_name: &Ident, fields: &Vec, is_tuple: bool, has_lifetime: bool) -> Tokens { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Field]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/tuple.rs:65:49 [INFO] [stderr] | [INFO] [stderr] 65 | pub fn gen_encoder(struct_name: &Ident, fields: &Vec, is_tuple: bool, has_lifetime: bool) -> Tokens { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Field]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/record.rs:6:13 [INFO] [stderr] | [INFO] [stderr] 6 | let ref attr_value = ast.attrs.iter() [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 6 | let attr_value = &ast.attrs.iter() [INFO] [stderr] 7 | .find(|attr| attr.name() == "tag") [INFO] [stderr] 8 | .expect("NifRecord requires a 'tag' attribute").value; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/record.rs:42:49 [INFO] [stderr] | [INFO] [stderr] 42 | pub fn gen_decoder(struct_name: &Ident, fields: &Vec, atom_defs: &Tokens, has_lifetime: bool) -> Tokens { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Field]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/record.rs:86:49 [INFO] [stderr] | [INFO] [stderr] 86 | pub fn gen_encoder(struct_name: &Ident, fields: &Vec, atom_defs: &Tokens, has_lifetime: bool) -> Tokens { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Field]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/map.rs:41:49 [INFO] [stderr] | [INFO] [stderr] 41 | pub fn gen_decoder(struct_name: &Ident, fields: &Vec, atom_defs: &Tokens, has_lifetime: bool) -> Tokens { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Field]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/map.rs:71:49 [INFO] [stderr] | [INFO] [stderr] 71 | pub fn gen_encoder(struct_name: &Ident, fields: &Vec, atom_defs: &Tokens, has_lifetime: bool) -> Tokens { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Field]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/ex_struct.rs:6:13 [INFO] [stderr] | [INFO] [stderr] 6 | let ref attr_value = ast.attrs.iter() [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 6 | let attr_value = &ast.attrs.iter() [INFO] [stderr] 7 | .find(|attr| attr.name() == "module") [INFO] [stderr] 8 | .expect("NifStruct requires a 'module' attribute") [INFO] [stderr] 9 | .value; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.06s [INFO] running `"docker" "inspect" "1e665fa1609454cfcb4e17671c4645dadebc3a5be57a78fe90f4fd23747de369"` [INFO] running `"docker" "rm" "-f" "1e665fa1609454cfcb4e17671c4645dadebc3a5be57a78fe90f4fd23747de369"` [INFO] [stdout] 1e665fa1609454cfcb4e17671c4645dadebc3a5be57a78fe90f4fd23747de369