[INFO] crate rustkit_bindgen 0.0.1 is already in cache [INFO] extracting crate rustkit_bindgen 0.0.1 into work/ex/clippy-test-run/sources/stable/reg/rustkit_bindgen/0.0.1 [INFO] extracting crate rustkit_bindgen 0.0.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rustkit_bindgen/0.0.1 [INFO] validating manifest of rustkit_bindgen-0.0.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rustkit_bindgen-0.0.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rustkit_bindgen-0.0.1 [INFO] finished frobbing rustkit_bindgen-0.0.1 [INFO] frobbed toml for rustkit_bindgen-0.0.1 written to work/ex/clippy-test-run/sources/stable/reg/rustkit_bindgen/0.0.1/Cargo.toml [INFO] started frobbing rustkit_bindgen-0.0.1 [INFO] finished frobbing rustkit_bindgen-0.0.1 [INFO] frobbed toml for rustkit_bindgen-0.0.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rustkit_bindgen/0.0.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rustkit_bindgen-0.0.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rustkit_bindgen/0.0.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3f3c97244bdf69b4d6d43f745759fcfc2a211a9b70d470b465561c51e1cd5ed3 [INFO] running `"docker" "start" "-a" "3f3c97244bdf69b4d6d43f745759fcfc2a211a9b70d470b465561c51e1cd5ed3"` [INFO] [stderr] Compiling rustkit-clang-sys v0.24.0 [INFO] [stderr] Checking syn v0.14.9 [INFO] [stderr] Checking rustkit_bindgen v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/walker.rs:1466:13 [INFO] [stderr] | [INFO] [stderr] 1466 | idx: idx, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `idx` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/walker.rs:1491:13 [INFO] [stderr] | [INFO] [stderr] 1491 | tu: tu, [INFO] [stderr] | ^^^^^^ help: replace it with: `tu` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:478:13 [INFO] [stderr] | [INFO] [stderr] 478 | setter: setter, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `setter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:572:21 [INFO] [stderr] | [INFO] [stderr] 572 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:600:13 [INFO] [stderr] | [INFO] [stderr] 600 | rustname: rustname, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `rustname` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:602:13 [INFO] [stderr] | [INFO] [stderr] 602 | args: args, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `args` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:605:13 [INFO] [stderr] | [INFO] [stderr] 605 | inter_ptr: inter_ptr, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `inter_ptr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:606:13 [INFO] [stderr] | [INFO] [stderr] 606 | consumes_self: consumes_self, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `consumes_self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:815:13 [INFO] [stderr] | [INFO] [stderr] 815 | superclass: superclass, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `superclass` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:816:13 [INFO] [stderr] | [INFO] [stderr] 816 | protocols: protocols, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `protocols` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:817:13 [INFO] [stderr] | [INFO] [stderr] 817 | cprops: cprops, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `cprops` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:818:13 [INFO] [stderr] | [INFO] [stderr] 818 | iprops: iprops, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `iprops` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:819:13 [INFO] [stderr] | [INFO] [stderr] 819 | cmethods: cmethods, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `cmethods` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:820:13 [INFO] [stderr] | [INFO] [stderr] 820 | imethods: imethods, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `imethods` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:892:13 [INFO] [stderr] | [INFO] [stderr] 892 | ty: ty, [INFO] [stderr] | ^^^^^^ help: replace it with: `ty` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:894:13 [INFO] [stderr] | [INFO] [stderr] 894 | flagenum: flagenum, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `flagenum` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:895:13 [INFO] [stderr] | [INFO] [stderr] 895 | variants: variants, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `variants` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:945:13 [INFO] [stderr] | [INFO] [stderr] 945 | fields: fields, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `fields` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:1006:13 [INFO] [stderr] | [INFO] [stderr] 1006 | args: args, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `args` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/walker.rs:1466:13 [INFO] [stderr] | [INFO] [stderr] 1466 | idx: idx, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `idx` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/walker.rs:1491:13 [INFO] [stderr] | [INFO] [stderr] 1491 | tu: tu, [INFO] [stderr] | ^^^^^^ help: replace it with: `tu` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:478:13 [INFO] [stderr] | [INFO] [stderr] 478 | setter: setter, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `setter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:572:21 [INFO] [stderr] | [INFO] [stderr] 572 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:600:13 [INFO] [stderr] | [INFO] [stderr] 600 | rustname: rustname, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `rustname` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:602:13 [INFO] [stderr] | [INFO] [stderr] 602 | args: args, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `args` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:605:13 [INFO] [stderr] | [INFO] [stderr] 605 | inter_ptr: inter_ptr, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `inter_ptr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:606:13 [INFO] [stderr] | [INFO] [stderr] 606 | consumes_self: consumes_self, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `consumes_self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:815:13 [INFO] [stderr] | [INFO] [stderr] 815 | superclass: superclass, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `superclass` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:816:13 [INFO] [stderr] | [INFO] [stderr] 816 | protocols: protocols, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `protocols` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:817:13 [INFO] [stderr] | [INFO] [stderr] 817 | cprops: cprops, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `cprops` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:818:13 [INFO] [stderr] | [INFO] [stderr] 818 | iprops: iprops, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `iprops` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:819:13 [INFO] [stderr] | [INFO] [stderr] 819 | cmethods: cmethods, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `cmethods` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:820:13 [INFO] [stderr] | [INFO] [stderr] 820 | imethods: imethods, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `imethods` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:892:13 [INFO] [stderr] | [INFO] [stderr] 892 | ty: ty, [INFO] [stderr] | ^^^^^^ help: replace it with: `ty` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:894:13 [INFO] [stderr] | [INFO] [stderr] 894 | flagenum: flagenum, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `flagenum` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:895:13 [INFO] [stderr] | [INFO] [stderr] 895 | variants: variants, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `variants` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:945:13 [INFO] [stderr] | [INFO] [stderr] 945 | fields: fields, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `fields` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:1006:13 [INFO] [stderr] | [INFO] [stderr] 1006 | args: args, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `args` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/walker.rs:1247:9 [INFO] [stderr] | [INFO] [stderr] 1247 | res [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/walker.rs:1239:19 [INFO] [stderr] | [INFO] [stderr] 1239 | let res = AvailabilityAttr { [INFO] [stderr] | ___________________^ [INFO] [stderr] 1240 | | platform: into_str(a.Platform), [INFO] [stderr] 1241 | | introduced: a.Introduced, [INFO] [stderr] 1242 | | deprecated: a.Deprecated, [INFO] [stderr] ... | [INFO] [stderr] 1245 | | message: into_str(a.Message), [INFO] [stderr] 1246 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/walker.rs:1490:9 [INFO] [stderr] | [INFO] [stderr] 1490 | / return Some(TranslationUnit { [INFO] [stderr] 1491 | | tu: tu, [INFO] [stderr] 1492 | | p: PhantomData, [INFO] [stderr] 1493 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 1490 | Some(TranslationUnit { [INFO] [stderr] 1491 | tu: tu, [INFO] [stderr] 1492 | p: PhantomData, [INFO] [stderr] 1493 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Variant name ends with the enum's name [INFO] [stderr] --> src/lib.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | InstanceType(bool), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::enum_variant_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:810:13 [INFO] [stderr] | [INFO] [stderr] 810 | return walker::ChildVisit::Continue; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `walker::ChildVisit::Continue` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/walker.rs:1247:9 [INFO] [stderr] | [INFO] [stderr] 1247 | res [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/walker.rs:1239:19 [INFO] [stderr] | [INFO] [stderr] 1239 | let res = AvailabilityAttr { [INFO] [stderr] | ___________________^ [INFO] [stderr] 1240 | | platform: into_str(a.Platform), [INFO] [stderr] 1241 | | introduced: a.Introduced, [INFO] [stderr] 1242 | | deprecated: a.Deprecated, [INFO] [stderr] ... | [INFO] [stderr] 1245 | | message: into_str(a.Message), [INFO] [stderr] 1246 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/walker.rs:1490:9 [INFO] [stderr] | [INFO] [stderr] 1490 | / return Some(TranslationUnit { [INFO] [stderr] 1491 | | tu: tu, [INFO] [stderr] 1492 | | p: PhantomData, [INFO] [stderr] 1493 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 1490 | Some(TranslationUnit { [INFO] [stderr] 1491 | tu: tu, [INFO] [stderr] 1492 | p: PhantomData, [INFO] [stderr] 1493 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Variant name ends with the enum's name [INFO] [stderr] --> src/lib.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | InstanceType(bool), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::enum_variant_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:810:13 [INFO] [stderr] | [INFO] [stderr] 810 | return walker::ChildVisit::Continue; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `walker::ChildVisit::Continue` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: method is never used: `is_copy` [INFO] [stderr] --> src/lib.rs:379:5 [INFO] [stderr] | [INFO] [stderr] 379 | pub fn is_copy(&self) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut std::ffi::c_void`) to a reference type (`&mut V`) [INFO] [stderr] --> src/walker.rs:1425:33 [INFO] [stderr] | [INFO] [stderr] 1425 | let func: &mut V = unsafe { mem::transmute(data) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(data as *mut V)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:77:35 [INFO] [stderr] | [INFO] [stderr] 77 | Type::Record(name.unwrap_or(decl.name()), decl.kind() == CursorKind::UnionDecl) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| decl.name())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:79:47 [INFO] [stderr] | [INFO] [stderr] 79 | TypeKind::Enum => Type::Enum(name.unwrap_or(t.decl().name())), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| t.decl().name())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's values [INFO] [stderr] --> src/lib.rs:1068:31 [INFO] [stderr] | [INFO] [stderr] 1068 | for (_, p) in &c.iprops { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::for_kv_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 1068 | for p in c.iprops.values() { [INFO] [stderr] | ^ ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's values [INFO] [stderr] --> src/lib.rs:1076:31 [INFO] [stderr] | [INFO] [stderr] 1076 | for (_, m) in &c.cmethods { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 1076 | for m in c.cmethods.values() { [INFO] [stderr] | ^ ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's values [INFO] [stderr] --> src/lib.rs:1079:31 [INFO] [stderr] | [INFO] [stderr] 1079 | for (_, m) in &c.imethods { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 1079 | for m in c.imethods.values() { [INFO] [stderr] | ^ ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `is_copy` [INFO] [stderr] --> src/lib.rs:379:5 [INFO] [stderr] | [INFO] [stderr] 379 | pub fn is_copy(&self) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 36 [INFO] [stderr] --> src/lib.rs:1154:14 [INFO] [stderr] | [INFO] [stderr] 1154 | tu.visit(|c| { [INFO] [stderr] | ______________^ [INFO] [stderr] 1155 | | if let walker::Availability::NotAvailable(_) = c.availability() { [INFO] [stderr] 1156 | | return walker::ChildVisit::Continue; [INFO] [stderr] 1157 | | } [INFO] [stderr] ... | [INFO] [stderr] 1355 | | walker::ChildVisit::Continue [INFO] [stderr] 1356 | | }); [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/lib.rs:1361:16 [INFO] [stderr] | [INFO] [stderr] 1361 | let mods = std::fs::read_dir(&subframeworks_path).map(|rd| rd.map(|e| e.unwrap().path().file_stem().unwrap().to_str().unwrap().to_owned()).collect::>()).unwrap_or(Vec::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `std::fs::read_dir(&subframeworks_path).map(|rd| rd.map(|e| e.unwrap().path().file_stem().unwrap().to_str().unwrap().to_owned()).collect::>()).unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 50 [INFO] [stderr] --> src/lib.rs:1388:1 [INFO] [stderr] | [INFO] [stderr] 1388 | / fn gen_file( [INFO] [stderr] 1389 | | decls: &HashMap, [INFO] [stderr] 1390 | | declnames: &[String], [INFO] [stderr] 1391 | | base_path: &Path, [INFO] [stderr] ... | [INFO] [stderr] 1764 | | std::process::Command::new("rustfmt").arg(out_path).status().unwrap(); [INFO] [stderr] 1765 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut std::ffi::c_void`) to a reference type (`&mut V`) [INFO] [stderr] --> src/walker.rs:1425:33 [INFO] [stderr] | [INFO] [stderr] 1425 | let func: &mut V = unsafe { mem::transmute(data) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(data as *mut V)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/lib.rs:1388:1 [INFO] [stderr] | [INFO] [stderr] 1388 | / fn gen_file( [INFO] [stderr] 1389 | | decls: &HashMap, [INFO] [stderr] 1390 | | declnames: &[String], [INFO] [stderr] 1391 | | base_path: &Path, [INFO] [stderr] ... | [INFO] [stderr] 1764 | | std::process::Command::new("rustfmt").arg(out_path).status().unwrap(); [INFO] [stderr] 1765 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:77:35 [INFO] [stderr] | [INFO] [stderr] 77 | Type::Record(name.unwrap_or(decl.name()), decl.kind() == CursorKind::UnionDecl) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| decl.name())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:79:47 [INFO] [stderr] | [INFO] [stderr] 79 | TypeKind::Enum => Type::Enum(name.unwrap_or(t.decl().name())), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| t.decl().name())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's values [INFO] [stderr] --> src/lib.rs:1634:31 [INFO] [stderr] | [INFO] [stderr] 1634 | for (_, p) in &c.iprops { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 1634 | for p in c.iprops.values() { [INFO] [stderr] | ^ ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's values [INFO] [stderr] --> src/lib.rs:1068:31 [INFO] [stderr] | [INFO] [stderr] 1068 | for (_, p) in &c.iprops { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::for_kv_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 1068 | for p in c.iprops.values() { [INFO] [stderr] | ^ ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's values [INFO] [stderr] --> src/lib.rs:1076:31 [INFO] [stderr] | [INFO] [stderr] 1076 | for (_, m) in &c.cmethods { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 1076 | for m in c.cmethods.values() { [INFO] [stderr] | ^ ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's values [INFO] [stderr] --> src/lib.rs:1079:31 [INFO] [stderr] | [INFO] [stderr] 1079 | for (_, m) in &c.imethods { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 1079 | for m in c.imethods.values() { [INFO] [stderr] | ^ ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 36 [INFO] [stderr] --> src/lib.rs:1154:14 [INFO] [stderr] | [INFO] [stderr] 1154 | tu.visit(|c| { [INFO] [stderr] | ______________^ [INFO] [stderr] 1155 | | if let walker::Availability::NotAvailable(_) = c.availability() { [INFO] [stderr] 1156 | | return walker::ChildVisit::Continue; [INFO] [stderr] 1157 | | } [INFO] [stderr] ... | [INFO] [stderr] 1355 | | walker::ChildVisit::Continue [INFO] [stderr] 1356 | | }); [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/lib.rs:1361:16 [INFO] [stderr] | [INFO] [stderr] 1361 | let mods = std::fs::read_dir(&subframeworks_path).map(|rd| rd.map(|e| e.unwrap().path().file_stem().unwrap().to_str().unwrap().to_owned()).collect::>()).unwrap_or(Vec::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `std::fs::read_dir(&subframeworks_path).map(|rd| rd.map(|e| e.unwrap().path().file_stem().unwrap().to_str().unwrap().to_owned()).collect::>()).unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 50 [INFO] [stderr] --> src/lib.rs:1388:1 [INFO] [stderr] | [INFO] [stderr] 1388 | / fn gen_file( [INFO] [stderr] 1389 | | decls: &HashMap, [INFO] [stderr] 1390 | | declnames: &[String], [INFO] [stderr] 1391 | | base_path: &Path, [INFO] [stderr] ... | [INFO] [stderr] 1764 | | std::process::Command::new("rustfmt").arg(out_path).status().unwrap(); [INFO] [stderr] 1765 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/lib.rs:1388:1 [INFO] [stderr] | [INFO] [stderr] 1388 | / fn gen_file( [INFO] [stderr] 1389 | | decls: &HashMap, [INFO] [stderr] 1390 | | declnames: &[String], [INFO] [stderr] 1391 | | base_path: &Path, [INFO] [stderr] ... | [INFO] [stderr] 1764 | | std::process::Command::new("rustfmt").arg(out_path).status().unwrap(); [INFO] [stderr] 1765 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's values [INFO] [stderr] --> src/lib.rs:1634:31 [INFO] [stderr] | [INFO] [stderr] 1634 | for (_, p) in &c.iprops { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 1634 | for p in c.iprops.values() { [INFO] [stderr] | ^ ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 12.46s [INFO] running `"docker" "inspect" "3f3c97244bdf69b4d6d43f745759fcfc2a211a9b70d470b465561c51e1cd5ed3"` [INFO] running `"docker" "rm" "-f" "3f3c97244bdf69b4d6d43f745759fcfc2a211a9b70d470b465561c51e1cd5ed3"` [INFO] [stdout] 3f3c97244bdf69b4d6d43f745759fcfc2a211a9b70d470b465561c51e1cd5ed3