[INFO] crate rustkell 0.2.2 is already in cache [INFO] extracting crate rustkell 0.2.2 into work/ex/clippy-test-run/sources/stable/reg/rustkell/0.2.2 [INFO] extracting crate rustkell 0.2.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rustkell/0.2.2 [INFO] validating manifest of rustkell-0.2.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rustkell-0.2.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rustkell-0.2.2 [INFO] finished frobbing rustkell-0.2.2 [INFO] frobbed toml for rustkell-0.2.2 written to work/ex/clippy-test-run/sources/stable/reg/rustkell/0.2.2/Cargo.toml [INFO] started frobbing rustkell-0.2.2 [INFO] finished frobbing rustkell-0.2.2 [INFO] frobbed toml for rustkell-0.2.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rustkell/0.2.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rustkell-0.2.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rustkell/0.2.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 44ec33090a46d5b66a140aa71275a314a6f5caebec377b56198b74e90a67d63a [INFO] running `"docker" "start" "-a" "44ec33090a46d5b66a140aa71275a314a6f5caebec377b56198b74e90a67d63a"` [INFO] [stderr] Checking rustkell v0.2.2 (/opt/crater/workdir) [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/datalist/tails.rs:52:25 [INFO] [stderr] | [INFO] [stderr] 52 | self.last = res.len() == 0; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `res.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/datalist/tails.rs:90:25 [INFO] [stderr] | [INFO] [stderr] 90 | self.last = res.len() == 0; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `res.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/datalist/tails.rs:52:25 [INFO] [stderr] | [INFO] [stderr] 52 | self.last = res.len() == 0; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `res.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/datalist/tails.rs:90:25 [INFO] [stderr] | [INFO] [stderr] 90 | self.last = res.len() == 0; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `res.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/datalist/mod.rs:69:18 [INFO] [stderr] | [INFO] [stderr] 69 | for (a,b) in (&v[..]).tails().into_iter().zip(b) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(&v[..]).tails()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/datalist/mod.rs:85:18 [INFO] [stderr] | [INFO] [stderr] 85 | for (a,b) in v.iter().tails().into_iter().zip(b) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `v.iter().tails()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/datalist/mod.rs:86:17 [INFO] [stderr] | [INFO] [stderr] 86 | let a = a.into_iter().map(|x| *x).collect::>(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `a.into_iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/datalist/mod.rs:86:17 [INFO] [stderr] | [INFO] [stderr] 86 | let a = a.into_iter().map(|x| *x).collect::>(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `a` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/datalist/mod.rs:102:18 [INFO] [stderr] | [INFO] [stderr] 102 | for (a,b) in v.tails().into_iter().zip(b) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `v.tails()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/datalist/mod.rs:113:18 [INFO] [stderr] | [INFO] [stderr] 113 | for (a,b) in (&v[..]).tails().into_iter().zip(b) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(&v[..]).tails()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/datalist/mod.rs:124:18 [INFO] [stderr] | [INFO] [stderr] 124 | for (a,b) in v.tails().into_iter().zip(b) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `v.tails()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/datalist/mod.rs:135:18 [INFO] [stderr] | [INFO] [stderr] 135 | for (a,b) in v.iter().tails().into_iter().zip(b) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `v.iter().tails()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/datalist/mod.rs:136:17 [INFO] [stderr] | [INFO] [stderr] 136 | let a = a.into_iter().map(|x| *x).collect::>(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `a.into_iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/datalist/mod.rs:136:17 [INFO] [stderr] | [INFO] [stderr] 136 | let a = a.into_iter().map(|x| *x).collect::>(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `a` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.11s [INFO] running `"docker" "inspect" "44ec33090a46d5b66a140aa71275a314a6f5caebec377b56198b74e90a67d63a"` [INFO] running `"docker" "rm" "-f" "44ec33090a46d5b66a140aa71275a314a6f5caebec377b56198b74e90a67d63a"` [INFO] [stdout] 44ec33090a46d5b66a140aa71275a314a6f5caebec377b56198b74e90a67d63a