[INFO] crate rustix-bl 0.5.0 is already in cache [INFO] extracting crate rustix-bl 0.5.0 into work/ex/clippy-test-run/sources/stable/reg/rustix-bl/0.5.0 [INFO] extracting crate rustix-bl 0.5.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rustix-bl/0.5.0 [INFO] validating manifest of rustix-bl-0.5.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rustix-bl-0.5.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rustix-bl-0.5.0 [INFO] finished frobbing rustix-bl-0.5.0 [INFO] frobbed toml for rustix-bl-0.5.0 written to work/ex/clippy-test-run/sources/stable/reg/rustix-bl/0.5.0/Cargo.toml [INFO] started frobbing rustix-bl-0.5.0 [INFO] finished frobbing rustix-bl-0.5.0 [INFO] frobbed toml for rustix-bl-0.5.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rustix-bl/0.5.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rustix-bl-0.5.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rustix-bl/0.5.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 77e096e0b3d33b1de006c0a992085b441d7f7be6b15383d8f548e6f2c08810a5 [INFO] running `"docker" "start" "-a" "77e096e0b3d33b1de006c0a992085b441d7f7be6b15383d8f548e6f2c08810a5"` [INFO] [stderr] Checking custom_derive v0.1.7 [INFO] [stderr] Compiling lmdb-sys v0.8.0 [INFO] [stderr] Checking typescriptify v0.1.5 [INFO] [stderr] Checking bincode v0.8.0 [INFO] [stderr] Checking suffix-rs v0.1.0 [INFO] [stderr] Checking lmdb v0.8.0 [INFO] [stderr] Checking rustix-bl v0.5.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_backend.rs:87:17 [INFO] [stderr] | [INFO] [stderr] 87 | timestamp_from: timestamp_from, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `timestamp_from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_backend.rs:88:17 [INFO] [stderr] | [INFO] [stderr] 88 | timestamp_to: timestamp_to, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `timestamp_to` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_backend.rs:87:17 [INFO] [stderr] | [INFO] [stderr] 87 | timestamp_from: timestamp_from, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `timestamp_from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] --> src/rustix_backend.rs:89:17 [INFO] [stderr] | [INFO] [stderr] 89 | user_ids: user_ids, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `user_ids` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_backend.rs:90:17 [INFO] [stderr] | [INFO] [stderr] 90 | comment: comment, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `comment` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_backend.rs:104:17 [INFO] [stderr] | [INFO] [stderr] 104 | itemname: itemname, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `itemname` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_backend.rs:105:17 [INFO] [stderr] | [INFO] [stderr] 105 | price_cents: price_cents, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `price_cents` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_backend.rs:106:17 [INFO] [stderr] | [INFO] [stderr] 106 | category: category, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `category` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_backend.rs:114:56 [INFO] [stderr] | [INFO] [stderr] 114 | &rustix_event_shop::BLEvents::CreateUser { username: username }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `username` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_backend.rs:121:56 [INFO] [stderr] | [INFO] [stderr] 121 | &rustix_event_shop::BLEvents::DeleteUser { user_id: user_id }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `user_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_backend.rs:128:56 [INFO] [stderr] | [INFO] [stderr] 128 | &rustix_event_shop::BLEvents::DeleteItem { item_id: item_id }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `item_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_backend.rs:136:17 [INFO] [stderr] | [INFO] [stderr] 136 | user_id: user_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `user_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_backend.rs:137:17 [INFO] [stderr] | [INFO] [stderr] 137 | item_id: item_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `item_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_backend.rs:152:17 [INFO] [stderr] | [INFO] [stderr] 152 | unique_id: unique_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `unique_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_backend.rs:160:17 [INFO] [stderr] | [INFO] [stderr] 160 | user_id: user_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `user_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_backend.rs:161:17 [INFO] [stderr] | [INFO] [stderr] 161 | special_name: special_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `special_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] [INFO] [stderr] --> src/rustix_backend.rs:171:13 [INFO] [stderr] | [INFO] [stderr] 171 | ffa_id: ffa_id, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `ffa_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_backend.rs:172:17 [INFO] [stderr] | [INFO] [stderr] 172 | item_id: item_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `item_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_backend.rs:182:17 [INFO] [stderr] | [INFO] [stderr] 182 | allowed_categories: allowed_categories, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `allowed_categories` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_backend.rs:183:17 [INFO] [stderr] | [INFO] [stderr] 183 | allowed_drinks: allowed_drinks, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `allowed_drinks` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_backend.rs:184:17 [INFO] [stderr] | [INFO] [stderr] 184 | allowed_number_total: allowed_number_total, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `allowed_number_total` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_backend.rs:185:17 [INFO] [stderr] | [INFO] [stderr] 185 | text_message: text_message, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `text_message` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_backend.rs:186:17 [INFO] [stderr] | [INFO] [stderr] 186 | created_timestamp: created_timestamp, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `created_timestamp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_backend.rs:187:17 [INFO] [stderr] | [INFO] [stderr] 187 | donor: donor, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `donor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_backend.rs:197:17 [INFO] [stderr] | [INFO] [stderr] 197 | cents_worth_total: cents_worth_total, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cents_worth_total` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_backend.rs:198:17 [INFO] [stderr] | [INFO] [stderr] 198 | text_message: text_message, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `text_message` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_backend.rs:199:17 [INFO] [stderr] | [INFO] [stderr] 199 | created_timestamp: created_timestamp, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `created_timestamp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_backend.rs:200:17 [INFO] [stderr] | [INFO] [stderr] 200 | donor: donor, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `donor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_backend.rs:201:17 [INFO] [stderr] | [INFO] [stderr] 201 | recipient: recipient, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `recipient` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_backend.rs:211:17 [INFO] [stderr] | [INFO] [stderr] 211 | allowed_categories: allowed_categories, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `allowed_categories` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_backend.rs:212:17 [INFO] [stderr] | [INFO] [stderr] 212 | allowed_drinks: allowed_drinks, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `allowed_drinks` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_backend.rs:213:17 [INFO] [stderr] | [INFO] [stderr] 213 | allowed_number_total: allowed_number_total, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `allowed_number_total` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_backend.rs:214:17 [INFO] [stderr] | [INFO] [stderr] 214 | text_message: text_message, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `text_message` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_backend.rs:215:17 [INFO] [stderr] | [INFO] [stderr] 215 | created_timestamp: created_timestamp, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `created_timestamp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_backend.rs:216:17 [INFO] [stderr] | [INFO] [stderr] 216 | donor: donor, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `donor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_backend.rs:217:17 [INFO] [stderr] | [INFO] [stderr] 217 | recipient: recipient, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `recipient` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_backend.rs:225:17 [INFO] [stderr] | [INFO] [stderr] 225 | user_id: user_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `user_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_backend.rs:226:17 [INFO] [stderr] | [INFO] [stderr] 226 | specials: specials, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `specials` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_backend.rs:227:17 [INFO] [stderr] | [INFO] [stderr] 227 | item_ids: item_ids, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `item_ids` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_backend.rs:236:17 [INFO] [stderr] | [INFO] [stderr] 236 | item_id: item_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `item_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_backend.rs:237:17 [INFO] [stderr] | [INFO] [stderr] 237 | itemname: itemname, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `itemname` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_backend.rs:238:17 [INFO] [stderr] | [INFO] [stderr] 238 | price_cents: price_cents, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `price_cents` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_backend.rs:239:17 [INFO] [stderr] | [INFO] [stderr] 239 | category: category, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `category` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_backend.rs:248:17 [INFO] [stderr] | [INFO] [stderr] 248 | user_id: user_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `user_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_backend.rs:249:17 [INFO] [stderr] | [INFO] [stderr] 249 | username: username, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `username` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_backend.rs:250:17 [INFO] [stderr] | [INFO] [stderr] 250 | is_billed: is_billed, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_billed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_backend.rs:251:17 [INFO] [stderr] | [INFO] [stderr] 251 | is_highlighted: is_highlighted, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_highlighted` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_backend.rs:252:17 [INFO] [stderr] | [INFO] [stderr] 252 | external_user_id: external_user_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `external_user_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_backend.rs:253:17 [INFO] [stderr] | [INFO] [stderr] 253 | is_sepa: is_sepa, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `is_sepa` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/persistencer.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | config: config, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `config` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/persistencer.rs:117:13 [INFO] [stderr] | [INFO] [stderr] 117 | lmdb: lmdb, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `lmdb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_event_shop.rs:487:21 [INFO] [stderr] | [INFO] [stderr] 487 | item_id: item_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `item_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_event_shop.rs:616:21 [INFO] [stderr] | [INFO] [stderr] 616 | item_id: item_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `item_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_event_shop.rs:766:17 [INFO] [stderr] | [INFO] [stderr] 766 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_event_shop.rs:794:21 [INFO] [stderr] | [INFO] [stderr] 794 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_event_shop.rs:817:21 [INFO] [stderr] | [INFO] [stderr] 817 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_backend.rs:88:17 [INFO] [stderr] | [INFO] [stderr] 88 | timestamp_to: timestamp_to, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `timestamp_to` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_backend.rs:89:17 [INFO] [stderr] | [INFO] [stderr] 89 | user_ids: user_ids, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `user_ids` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_backend.rs:90:17 [INFO] [stderr] | [INFO] [stderr] 90 | comment: comment, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `comment` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_backend.rs:104:17 [INFO] [stderr] | [INFO] [stderr] 104 | itemname: itemname, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `itemname` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_backend.rs:105:17 [INFO] [stderr] | [INFO] [stderr] 105 | price_cents: price_cents, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `price_cents` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_backend.rs:106:17 [INFO] [stderr] | [INFO] [stderr] 106 | category: category, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `category` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_backend.rs:114:56 [INFO] [stderr] | [INFO] [stderr] 114 | &rustix_event_shop::BLEvents::CreateUser { username: username }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `username` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_backend.rs:121:56 [INFO] [stderr] | [INFO] [stderr] 121 | &rustix_event_shop::BLEvents::DeleteUser { user_id: user_id }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `user_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_backend.rs:128:56 [INFO] [stderr] | [INFO] [stderr] 128 | &rustix_event_shop::BLEvents::DeleteItem { item_id: item_id }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `item_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_backend.rs:136:17 [INFO] [stderr] | [INFO] [stderr] 136 | user_id: user_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `user_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_backend.rs:137:17 [INFO] [stderr] | [INFO] [stderr] 137 | item_id: item_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `item_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_backend.rs:152:17 [INFO] [stderr] | [INFO] [stderr] 152 | unique_id: unique_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `unique_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_backend.rs:160:17 [INFO] [stderr] | [INFO] [stderr] 160 | user_id: user_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `user_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_backend.rs:161:17 [INFO] [stderr] | [INFO] [stderr] 161 | special_name: special_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `special_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_backend.rs:171:13 [INFO] [stderr] | [INFO] [stderr] 171 | ffa_id: ffa_id, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `ffa_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_backend.rs:172:17 [INFO] [stderr] | [INFO] [stderr] 172 | item_id: item_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `item_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_backend.rs:182:17 [INFO] [stderr] | [INFO] [stderr] 182 | allowed_categories: allowed_categories, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `allowed_categories` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_backend.rs:183:17 [INFO] [stderr] | [INFO] [stderr] 183 | allowed_drinks: allowed_drinks, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `allowed_drinks` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_backend.rs:184:17 [INFO] [stderr] | [INFO] [stderr] 184 | allowed_number_total: allowed_number_total, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `allowed_number_total` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_backend.rs:185:17 [INFO] [stderr] | [INFO] [stderr] 185 | text_message: text_message, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `text_message` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_backend.rs:186:17 [INFO] [stderr] | [INFO] [stderr] 186 | created_timestamp: created_timestamp, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `created_timestamp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_backend.rs:187:17 [INFO] [stderr] | [INFO] [stderr] 187 | donor: donor, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `donor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_backend.rs:197:17 [INFO] [stderr] | [INFO] [stderr] 197 | cents_worth_total: cents_worth_total, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cents_worth_total` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_backend.rs:198:17 [INFO] [stderr] | [INFO] [stderr] 198 | text_message: text_message, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `text_message` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_backend.rs:199:17 [INFO] [stderr] | [INFO] [stderr] 199 | created_timestamp: created_timestamp, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `created_timestamp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_backend.rs:200:17 [INFO] [stderr] | [INFO] [stderr] 200 | donor: donor, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `donor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_backend.rs:201:17 [INFO] [stderr] | [INFO] [stderr] 201 | recipient: recipient, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `recipient` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_backend.rs:211:17 [INFO] [stderr] | [INFO] [stderr] 211 | allowed_categories: allowed_categories, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `allowed_categories` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_backend.rs:212:17 [INFO] [stderr] | [INFO] [stderr] 212 | allowed_drinks: allowed_drinks, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `allowed_drinks` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_backend.rs:213:17 [INFO] [stderr] | [INFO] [stderr] 213 | allowed_number_total: allowed_number_total, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `allowed_number_total` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_backend.rs:214:17 [INFO] [stderr] | [INFO] [stderr] 214 | text_message: text_message, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `text_message` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_backend.rs:215:17 [INFO] [stderr] | [INFO] [stderr] 215 | created_timestamp: created_timestamp, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `created_timestamp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_backend.rs:216:17 [INFO] [stderr] | [INFO] [stderr] 216 | donor: donor, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `donor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_backend.rs:217:17 [INFO] [stderr] | [INFO] [stderr] 217 | recipient: recipient, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `recipient` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_backend.rs:225:17 [INFO] [stderr] | [INFO] [stderr] 225 | user_id: user_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `user_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_backend.rs:226:17 [INFO] [stderr] | [INFO] [stderr] 226 | specials: specials, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `specials` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_backend.rs:227:17 [INFO] [stderr] | [INFO] [stderr] 227 | item_ids: item_ids, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `item_ids` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_backend.rs:236:17 [INFO] [stderr] | [INFO] [stderr] 236 | item_id: item_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `item_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_backend.rs:237:17 [INFO] [stderr] | [INFO] [stderr] 237 | itemname: itemname, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `itemname` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_backend.rs:238:17 [INFO] [stderr] | [INFO] [stderr] 238 | price_cents: price_cents, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `price_cents` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_backend.rs:239:17 [INFO] [stderr] | [INFO] [stderr] 239 | category: category, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `category` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_backend.rs:248:17 [INFO] [stderr] | [INFO] [stderr] 248 | user_id: user_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `user_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_backend.rs:249:17 [INFO] [stderr] | [INFO] [stderr] 249 | username: username, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `username` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_backend.rs:250:17 [INFO] [stderr] | [INFO] [stderr] 250 | is_billed: is_billed, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_billed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_backend.rs:251:17 [INFO] [stderr] | [INFO] [stderr] 251 | is_highlighted: is_highlighted, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_highlighted` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_backend.rs:252:17 [INFO] [stderr] | [INFO] [stderr] 252 | external_user_id: external_user_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `external_user_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_backend.rs:253:17 [INFO] [stderr] | [INFO] [stderr] 253 | is_sepa: is_sepa, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `is_sepa` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/persistencer.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | config: config, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `config` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/persistencer.rs:117:13 [INFO] [stderr] | [INFO] [stderr] 117 | lmdb: lmdb, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `lmdb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_event_shop.rs:487:21 [INFO] [stderr] | [INFO] [stderr] 487 | item_id: item_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `item_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_event_shop.rs:616:21 [INFO] [stderr] | [INFO] [stderr] 616 | item_id: item_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `item_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_event_shop.rs:766:17 [INFO] [stderr] | [INFO] [stderr] 766 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_event_shop.rs:794:21 [INFO] [stderr] | [INFO] [stderr] 794 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustix_event_shop.rs:817:21 [INFO] [stderr] | [INFO] [stderr] 817 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/left_threaded_avl_tree.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | / return ScoredIdTreeMock { [INFO] [stderr] 26 | | ids: Vec::new(), [INFO] [stderr] 27 | | scores: Vec::new(), [INFO] [stderr] 28 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 25 | ScoredIdTreeMock { [INFO] [stderr] 26 | ids: Vec::new(), [INFO] [stderr] 27 | scores: Vec::new(), [INFO] [stderr] 28 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/left_threaded_avl_tree.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/left_threaded_avl_tree.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | return x; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/left_threaded_avl_tree.rs:47:19 [INFO] [stderr] | [INFO] [stderr] 47 | let hm = &*(&mut hashmap); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try this: `hashmap` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deref_addrof)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/left_threaded_avl_tree.rs:57:9 [INFO] [stderr] | [INFO] [stderr] 57 | return ScoredIdTreeMock::default(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ScoredIdTreeMock::default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/left_threaded_avl_tree.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/left_threaded_avl_tree.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/left_threaded_avl_tree.rs:72:9 [INFO] [stderr] | [INFO] [stderr] 72 | / return o.map(|i| { [INFO] [stderr] 73 | | self.scores[i] = self.scores[i] + 1; [INFO] [stderr] 74 | | self.scores[i] [INFO] [stderr] 75 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 72 | o.map(|i| { [INFO] [stderr] 73 | self.scores[i] = self.scores[i] + 1; [INFO] [stderr] 74 | self.scores[i] [INFO] [stderr] 75 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/left_threaded_avl_tree.rs:83:17 [INFO] [stderr] | [INFO] [stderr] 83 | return Some(self.scores.remove(i)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(self.scores.remove(i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/left_threaded_avl_tree.rs:86:17 [INFO] [stderr] | [INFO] [stderr] 86 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/left_threaded_avl_tree.rs:93:9 [INFO] [stderr] | [INFO] [stderr] 93 | return self.score_sorted_copy()[0..(n)].to_vec(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.score_sorted_copy()[0..(n)].to_vec()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/datastore.rs:108:33 [INFO] [stderr] | [INFO] [stderr] 108 | fn rebuild_user_tree(&self) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/datastore.rs:112:33 [INFO] [stderr] | [INFO] [stderr] 112 | fn rebuild_item_tree(&self) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:121:9 [INFO] [stderr] | [INFO] [stderr] 121 | return self.get_purchase(purchase_id).map(|p| *(p.get_timestamp())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.get_purchase(purchase_id).map(|p| *(p.get_timestamp()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:125:9 [INFO] [stderr] | [INFO] [stderr] 125 | return self.top_user_scores.extract_top(n as usize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.top_user_scores.extract_top(n as usize)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:134:9 [INFO] [stderr] | [INFO] [stderr] 134 | return v; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `v` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:138:9 [INFO] [stderr] | [INFO] [stderr] 138 | return self.items_suffix_tree.search(searchterm).iter().map(|sr : &SearchResult|sr.id).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.items_suffix_tree.search(searchterm).iter().map(|sr : &SearchResult|sr.id).collect()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:149:9 [INFO] [stderr] | [INFO] [stderr] 149 | return v; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `v` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:157:9 [INFO] [stderr] | [INFO] [stderr] 157 | return &self.purchases[from..to]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&self.purchases[from..to]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:165:9 [INFO] [stderr] | [INFO] [stderr] 165 | return v; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `v` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:169:31 [INFO] [stderr] | [INFO] [stderr] 169 | Some(ref tree) => return tree.extract_top(n as usize), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `tree.extract_top(n as usize)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:180:9 [INFO] [stderr] | [INFO] [stderr] 180 | return v; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `v` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:186:9 [INFO] [stderr] | [INFO] [stderr] 186 | return idx.map(move |id| self.purchases.get_mut(id).unwrap()).ok(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `idx.map(move |id| self.purchases.get_mut(id).unwrap()).ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:190:9 [INFO] [stderr] | [INFO] [stderr] 190 | return self.bills.iter_mut().find(|b| b.timestamp_from == timestamp_from && b.timestamp_to == timestamp_to); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.bills.iter_mut().find(|b| b.timestamp_from == timestamp_from && b.timestamp_to == timestamp_to)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:194:9 [INFO] [stderr] | [INFO] [stderr] 194 | return self.bills.iter().position(|b| b.timestamp_from == timestamp_from && b.timestamp_to == timestamp_to); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.bills.iter().position(|b| b.timestamp_from == timestamp_from && b.timestamp_to == timestamp_to)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:201:13 [INFO] [stderr] | [INFO] [stderr] 201 | return Vec::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Vec::new()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:204:13 [INFO] [stderr] | [INFO] [stderr] 204 | / return self.purchases[from..to].iter().filter(|p| { [INFO] [stderr] 205 | | p.has_user_id() && matches_usergroup(&Some(*p.get_user_id()), &bill.users) && (match **p { [INFO] [stderr] 206 | | Purchase::SpecialPurchase { [INFO] [stderr] 207 | | .. [INFO] [stderr] ... | [INFO] [stderr] 210 | | }) [INFO] [stderr] 211 | | }).map(|p|p.get_unique_id()).collect(); [INFO] [stderr] | |___________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 204 | self.purchases[from..to].iter().filter(|p| { [INFO] [stderr] 205 | p.has_user_id() && matches_usergroup(&Some(*p.get_user_id()), &bill.users) && (match **p { [INFO] [stderr] 206 | Purchase::SpecialPurchase { [INFO] [stderr] 207 | .. [INFO] [stderr] 208 | } => true, [INFO] [stderr] 209 | _ => false, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:218:13 [INFO] [stderr] | [INFO] [stderr] 218 | return Vec::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Vec::new()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:230:17 [INFO] [stderr] | [INFO] [stderr] 230 | return xs; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `xs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:237:13 [INFO] [stderr] | [INFO] [stderr] 237 | return Vec::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Vec::new()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:267:13 [INFO] [stderr] | [INFO] [stderr] 267 | return users_undefined_indices; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `users_undefined_indices` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/datastore.rs:248:17 [INFO] [stderr] | [INFO] [stderr] 248 | / if matches_usergroup(&Some(uid), &bill.users) { [INFO] [stderr] 249 | | if !touched_users_set.contains(&uid) { [INFO] [stderr] 250 | | //user matches criteria & isn't in list => add user to list [INFO] [stderr] 251 | | touched_users_set.insert(uid); [INFO] [stderr] ... | [INFO] [stderr] 263 | | } [INFO] [stderr] 264 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 248 | if matches_usergroup(&Some(uid), &bill.users) && !touched_users_set.contains(&uid) { [INFO] [stderr] 249 | //user matches criteria & isn't in list => add user to list [INFO] [stderr] 250 | touched_users_set.insert(uid); [INFO] [stderr] 251 | let usr = self.users.get(&uid).unwrap(); [INFO] [stderr] 252 | [INFO] [stderr] 253 | if !usr.is_billed { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:279:13 [INFO] [stderr] | [INFO] [stderr] 279 | return xs; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `xs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:282:9 [INFO] [stderr] | [INFO] [stderr] 282 | return self.bills.iter().find(|b| b.timestamp_from == timestamp_from && b.timestamp_to == timestamp_to); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.bills.iter().find(|b| b.timestamp_from == timestamp_from && b.timestamp_to == timestamp_to)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:297:9 [INFO] [stderr] | [INFO] [stderr] 297 | return v; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `v` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:315:9 [INFO] [stderr] | [INFO] [stderr] 315 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:343:9 [INFO] [stderr] | [INFO] [stderr] 343 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/datastore.rs:333:37 [INFO] [stderr] | [INFO] [stderr] 333 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:349:13 [INFO] [stderr] | [INFO] [stderr] 349 | return self.open_ffa.get(found); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.open_ffa.get(found)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:354:17 [INFO] [stderr] | [INFO] [stderr] 354 | return self.used_up_freebies.get(found); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.used_up_freebies.get(found)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:356:17 [INFO] [stderr] | [INFO] [stderr] 356 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:364:13 [INFO] [stderr] | [INFO] [stderr] 364 | return self.used_up_freebies.get(found_closed.unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.used_up_freebies.get(found_closed.unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:369:21 [INFO] [stderr] | [INFO] [stderr] 369 | return self.open_freebies.get(&recipient_id).unwrap().get(found_open.unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.open_freebies.get(&recipient_id).unwrap().get(found_open.unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:371:21 [INFO] [stderr] | [INFO] [stderr] 371 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:374:17 [INFO] [stderr] | [INFO] [stderr] 374 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/datastore.rs:365:16 [INFO] [stderr] | [INFO] [stderr] 365 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 366 | | if self.open_freebies.contains_key(&recipient_id) { [INFO] [stderr] 367 | | let found_open = self.open_freebies.get(&recipient_id).unwrap().binary_search_by(|f| f.get_id().cmp(&freeby_id)); [INFO] [stderr] 368 | | if found_open.is_ok() { [INFO] [stderr] ... | [INFO] [stderr] 375 | | } [INFO] [stderr] 376 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 365 | } else if self.open_freebies.contains_key(&recipient_id) { [INFO] [stderr] 366 | let found_open = self.open_freebies.get(&recipient_id).unwrap().binary_search_by(|f| f.get_id().cmp(&freeby_id)); [INFO] [stderr] 367 | if found_open.is_ok() { [INFO] [stderr] 368 | return self.open_freebies.get(&recipient_id).unwrap().get(found_open.unwrap()); [INFO] [stderr] 369 | } else { [INFO] [stderr] 370 | return None; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:384:9 [INFO] [stderr] | [INFO] [stderr] 384 | / return match *usergroup { [INFO] [stderr] 385 | | UserGroup::SingleUser { [INFO] [stderr] 386 | | ref user_id [INFO] [stderr] 387 | | } => *user_id == checked_user_id, [INFO] [stderr] ... | [INFO] [stderr] 391 | | } => user_ids.iter().any(|id| *id == checked_user_id), [INFO] [stderr] 392 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 384 | match *usergroup { [INFO] [stderr] 385 | UserGroup::SingleUser { [INFO] [stderr] 386 | ref user_id [INFO] [stderr] 387 | } => *user_id == checked_user_id, [INFO] [stderr] 388 | UserGroup::AllUsers => true, [INFO] [stderr] 389 | UserGroup::MultipleUsers { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:394:9 [INFO] [stderr] | [INFO] [stderr] 394 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:400:5 [INFO] [stderr] | [INFO] [stderr] 400 | return user_id.map(|id| usergroup.contains(&id)).unwrap_or(true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `user_id.map(|id| usergroup.contains(&id)).unwrap_or(true)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:422:5 [INFO] [stderr] | [INFO] [stderr] 422 | return (first,last); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(first,last)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:441:9 [INFO] [stderr] | [INFO] [stderr] 441 | return self.users.contains_key(&id); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.users.contains_key(&id)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:446:9 [INFO] [stderr] | [INFO] [stderr] 446 | return self.items.contains_key(&id); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.items.contains_key(&id)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:458:9 [INFO] [stderr] | [INFO] [stderr] 458 | / return self.purchases.iter_mut().find(|p|{ [INFO] [stderr] 459 | | p.has_unique_id(id) [INFO] [stderr] 460 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 458 | self.purchases.iter_mut().find(|p|{ [INFO] [stderr] 459 | p.has_unique_id(id) [INFO] [stderr] 460 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:468:9 [INFO] [stderr] | [INFO] [stderr] 468 | return s; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `s` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:472:9 [INFO] [stderr] | [INFO] [stderr] 472 | return self.user_id; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.user_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:480:9 [INFO] [stderr] | [INFO] [stderr] 480 | return s; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `s` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:484:9 [INFO] [stderr] | [INFO] [stderr] 484 | return self.item_id; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.item_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:493:9 [INFO] [stderr] | [INFO] [stderr] 493 | / return Datastore { [INFO] [stderr] 494 | | users: HashMap::new(), [INFO] [stderr] 495 | | users_suffix_tree: MockKDTree::build(&empty_user_vec, true), [INFO] [stderr] 496 | | items: HashMap::new(), [INFO] [stderr] ... | [INFO] [stderr] 515 | | version: 0, [INFO] [stderr] 516 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 493 | Datastore { [INFO] [stderr] 494 | users: HashMap::new(), [INFO] [stderr] 495 | users_suffix_tree: MockKDTree::build(&empty_user_vec, true), [INFO] [stderr] 496 | items: HashMap::new(), [INFO] [stderr] 497 | items_suffix_tree: MockKDTree::build(&empty_item_vec, true), [INFO] [stderr] 498 | purchases: Vec::new(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:531:9 [INFO] [stderr] | [INFO] [stderr] 531 | return UserGroup::AllUsers; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `UserGroup::AllUsers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:550:9 [INFO] [stderr] | [INFO] [stderr] 550 | / return User { [INFO] [stderr] 551 | | username: self.username.to_string(), [INFO] [stderr] 552 | | external_user_id: self.external_user_id.clone(), [INFO] [stderr] 553 | | user_id: self.user_id, [INFO] [stderr] ... | [INFO] [stderr] 557 | | deleted: self.deleted, [INFO] [stderr] 558 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 550 | User { [INFO] [stderr] 551 | username: self.username.to_string(), [INFO] [stderr] 552 | external_user_id: self.external_user_id.clone(), [INFO] [stderr] 553 | user_id: self.user_id, [INFO] [stderr] 554 | is_billed: self.is_billed, [INFO] [stderr] 555 | is_sepa: self.is_sepa, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:585:35 [INFO] [stderr] | [INFO] [stderr] 585 | BillState::Created => return true, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:586:18 [INFO] [stderr] | [INFO] [stderr] 586 | _ => return false, [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:590:9 [INFO] [stderr] | [INFO] [stderr] 590 | return !self.is_created() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `!self.is_created()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:596:9 [INFO] [stderr] | [INFO] [stderr] 596 | return BillState::Created; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `BillState::Created` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:670:9 [INFO] [stderr] | [INFO] [stderr] 670 | return day as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `day as usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:766:9 [INFO] [stderr] | [INFO] [stderr] 766 | / return match *self { [INFO] [stderr] 767 | | Freeby::Classic { [INFO] [stderr] 768 | | ref id, [INFO] [stderr] 769 | | ref allowed_categories, [INFO] [stderr] ... | [INFO] [stderr] 802 | | }, [INFO] [stderr] 803 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 766 | match *self { [INFO] [stderr] 767 | Freeby::Classic { [INFO] [stderr] 768 | ref id, [INFO] [stderr] 769 | ref allowed_categories, [INFO] [stderr] 770 | ref allowed_drinks, [INFO] [stderr] 771 | ref allowed_number_total, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:806:9 [INFO] [stderr] | [INFO] [stderr] 806 | / return match *self { [INFO] [stderr] 807 | | Freeby::Classic { [INFO] [stderr] 808 | | ref id, [INFO] [stderr] 809 | | ref allowed_categories, [INFO] [stderr] ... | [INFO] [stderr] 842 | | }, [INFO] [stderr] 843 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 806 | match *self { [INFO] [stderr] 807 | Freeby::Classic { [INFO] [stderr] 808 | ref id, [INFO] [stderr] 809 | ref allowed_categories, [INFO] [stderr] 810 | ref allowed_drinks, [INFO] [stderr] 811 | ref allowed_number_total, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:847:9 [INFO] [stderr] | [INFO] [stderr] 847 | / return match *self { [INFO] [stderr] 848 | | Freeby::Classic { [INFO] [stderr] 849 | | ref id, [INFO] [stderr] 850 | | ref allowed_categories, [INFO] [stderr] ... | [INFO] [stderr] 883 | | }, [INFO] [stderr] 884 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 847 | match *self { [INFO] [stderr] 848 | Freeby::Classic { [INFO] [stderr] 849 | ref id, [INFO] [stderr] 850 | ref allowed_categories, [INFO] [stderr] 851 | ref allowed_drinks, [INFO] [stderr] 852 | ref allowed_number_total, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:888:9 [INFO] [stderr] | [INFO] [stderr] 888 | / return match *self { [INFO] [stderr] 889 | | Freeby::Classic { [INFO] [stderr] 890 | | ref id, [INFO] [stderr] 891 | | ref allowed_categories, [INFO] [stderr] ... | [INFO] [stderr] 924 | | }, [INFO] [stderr] 925 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 888 | match *self { [INFO] [stderr] 889 | Freeby::Classic { [INFO] [stderr] 890 | ref id, [INFO] [stderr] 891 | ref allowed_categories, [INFO] [stderr] 892 | ref allowed_drinks, [INFO] [stderr] 893 | ref allowed_number_total, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:929:9 [INFO] [stderr] | [INFO] [stderr] 929 | / return match *self { [INFO] [stderr] 930 | | Freeby::Classic { [INFO] [stderr] 931 | | ref id, [INFO] [stderr] 932 | | ref allowed_categories, [INFO] [stderr] ... | [INFO] [stderr] 965 | | }, [INFO] [stderr] 966 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 929 | match *self { [INFO] [stderr] 930 | Freeby::Classic { [INFO] [stderr] 931 | ref id, [INFO] [stderr] 932 | ref allowed_categories, [INFO] [stderr] 933 | ref allowed_drinks, [INFO] [stderr] 934 | ref allowed_number_total, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:970:9 [INFO] [stderr] | [INFO] [stderr] 970 | / return match *self { [INFO] [stderr] 971 | | Freeby::Classic { [INFO] [stderr] 972 | | ref id, [INFO] [stderr] 973 | | ref allowed_categories, [INFO] [stderr] ... | [INFO] [stderr] 1007 | | }, [INFO] [stderr] 1008 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 970 | match *self { [INFO] [stderr] 971 | Freeby::Classic { [INFO] [stderr] 972 | ref id, [INFO] [stderr] 973 | ref allowed_categories, [INFO] [stderr] 974 | ref allowed_drinks, [INFO] [stderr] 975 | ref allowed_number_total, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:1011:9 [INFO] [stderr] | [INFO] [stderr] 1011 | / return match *self { [INFO] [stderr] 1012 | | Freeby::Classic { [INFO] [stderr] 1013 | | ref id, [INFO] [stderr] 1014 | | ref allowed_categories, [INFO] [stderr] ... | [INFO] [stderr] 1049 | | }, [INFO] [stderr] 1050 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 1011 | match *self { [INFO] [stderr] 1012 | Freeby::Classic { [INFO] [stderr] 1013 | ref id, [INFO] [stderr] 1014 | ref allowed_categories, [INFO] [stderr] 1015 | ref allowed_drinks, [INFO] [stderr] 1016 | ref allowed_number_total, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/datastore.rs:1010:29 [INFO] [stderr] | [INFO] [stderr] 1010 | fn decrement(&mut self) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:1053:9 [INFO] [stderr] | [INFO] [stderr] 1053 | / return match *self { [INFO] [stderr] 1054 | | Freeby::Transfer{ [INFO] [stderr] 1055 | | ref id, [INFO] [stderr] 1056 | | ref cents_worth_total, [INFO] [stderr] ... | [INFO] [stderr] 1065 | | _ => panic!("Cannot get cents left for non-budget-freeby"), [INFO] [stderr] 1066 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 1053 | match *self { [INFO] [stderr] 1054 | Freeby::Transfer{ [INFO] [stderr] 1055 | ref id, [INFO] [stderr] 1056 | ref cents_worth_total, [INFO] [stderr] 1057 | ref cents_worth_used, [INFO] [stderr] 1058 | ref text_message, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:1097:9 [INFO] [stderr] | [INFO] [stderr] 1097 | return FreebyAble::left(self) != 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `FreebyAble::left(self) != 0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:1116:9 [INFO] [stderr] | [INFO] [stderr] 1116 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:1158:17 [INFO] [stderr] | [INFO] [stderr] 1158 | return *unique_id; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `*unique_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:1166:17 [INFO] [stderr] | [INFO] [stderr] 1166 | return *unique_id; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `*unique_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:1175:17 [INFO] [stderr] | [INFO] [stderr] 1175 | return *unique_id; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `*unique_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:1188:18 [INFO] [stderr] | [INFO] [stderr] 1188 | } => return *specialcost, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `*specialcost` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:1202:17 [INFO] [stderr] | [INFO] [stderr] 1202 | return *unique_id == other; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `*unique_id == other` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:1210:17 [INFO] [stderr] | [INFO] [stderr] 1210 | return *unique_id == other; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `*unique_id == other` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:1219:17 [INFO] [stderr] | [INFO] [stderr] 1219 | return *unique_id == other; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `*unique_id == other` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:1233:17 [INFO] [stderr] | [INFO] [stderr] 1233 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:1241:17 [INFO] [stderr] | [INFO] [stderr] 1241 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:1250:17 [INFO] [stderr] | [INFO] [stderr] 1250 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:1263:17 [INFO] [stderr] | [INFO] [stderr] 1263 | return consumer_id; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `consumer_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:1271:17 [INFO] [stderr] | [INFO] [stderr] 1271 | return consumer_id; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `consumer_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:1280:17 [INFO] [stderr] | [INFO] [stderr] 1280 | return donor; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `donor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:1302:17 [INFO] [stderr] | [INFO] [stderr] 1302 | return item_id; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `item_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:1311:17 [INFO] [stderr] | [INFO] [stderr] 1311 | return item_id; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `item_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:1325:17 [INFO] [stderr] | [INFO] [stderr] 1325 | return timestamp_epoch_millis; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `timestamp_epoch_millis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:1333:17 [INFO] [stderr] | [INFO] [stderr] 1333 | return timestamp_epoch_millis; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `timestamp_epoch_millis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:1342:17 [INFO] [stderr] | [INFO] [stderr] 1342 | return timestamp_epoch_millis; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `timestamp_epoch_millis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustix_backend.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | / return self.persistencer.test_store_apply( [INFO] [stderr] 86 | | &rustix_event_shop::BLEvents::CreateBill { [INFO] [stderr] 87 | | timestamp_from: timestamp_from, [INFO] [stderr] 88 | | timestamp_to: timestamp_to, [INFO] [stderr] ... | [INFO] [stderr] 92 | | &mut self.datastore, [INFO] [stderr] 93 | | ); [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 85 | self.persistencer.test_store_apply( [INFO] [stderr] 86 | &rustix_event_shop::BLEvents::CreateBill { [INFO] [stderr] 87 | timestamp_from: timestamp_from, [INFO] [stderr] 88 | timestamp_to: timestamp_to, [INFO] [stderr] 89 | user_ids: user_ids, [INFO] [stderr] 90 | comment: comment, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustix_backend.rs:102:9 [INFO] [stderr] | [INFO] [stderr] 102 | / return self.persistencer.test_store_apply( [INFO] [stderr] 103 | | &rustix_event_shop::BLEvents::CreateItem { [INFO] [stderr] 104 | | itemname: itemname, [INFO] [stderr] 105 | | price_cents: price_cents, [INFO] [stderr] ... | [INFO] [stderr] 108 | | &mut self.datastore, [INFO] [stderr] 109 | | ); [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 102 | self.persistencer.test_store_apply( [INFO] [stderr] 103 | &rustix_event_shop::BLEvents::CreateItem { [INFO] [stderr] 104 | itemname: itemname, [INFO] [stderr] 105 | price_cents: price_cents, [INFO] [stderr] 106 | category: category, [INFO] [stderr] 107 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustix_backend.rs:113:9 [INFO] [stderr] | [INFO] [stderr] 113 | / return self.persistencer.test_store_apply( [INFO] [stderr] 114 | | &rustix_event_shop::BLEvents::CreateUser { username: username }, [INFO] [stderr] 115 | | &mut self.datastore, [INFO] [stderr] 116 | | ); [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 113 | self.persistencer.test_store_apply( [INFO] [stderr] 114 | &rustix_event_shop::BLEvents::CreateUser { username: username }, [INFO] [stderr] 115 | &mut self.datastore, [INFO] [stderr] 116 | ) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustix_backend.rs:120:9 [INFO] [stderr] | [INFO] [stderr] 120 | / return self.persistencer.test_store_apply( [INFO] [stderr] 121 | | &rustix_event_shop::BLEvents::DeleteUser { user_id: user_id }, [INFO] [stderr] 122 | | &mut self.datastore, [INFO] [stderr] 123 | | ); [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 120 | self.persistencer.test_store_apply( [INFO] [stderr] 121 | &rustix_event_shop::BLEvents::DeleteUser { user_id: user_id }, [INFO] [stderr] 122 | &mut self.datastore, [INFO] [stderr] 123 | ) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustix_backend.rs:127:9 [INFO] [stderr] | [INFO] [stderr] 127 | / return self.persistencer.test_store_apply( [INFO] [stderr] 128 | | &rustix_event_shop::BLEvents::DeleteItem { item_id: item_id }, [INFO] [stderr] 129 | | &mut self.datastore, [INFO] [stderr] 130 | | ); [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 127 | self.persistencer.test_store_apply( [INFO] [stderr] 128 | &rustix_event_shop::BLEvents::DeleteItem { item_id: item_id }, [INFO] [stderr] 129 | &mut self.datastore, [INFO] [stderr] 130 | ) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustix_backend.rs:134:9 [INFO] [stderr] | [INFO] [stderr] 134 | / return self.persistencer.test_store_apply( [INFO] [stderr] 135 | | &rustix_event_shop::BLEvents::MakeSimplePurchase { [INFO] [stderr] 136 | | user_id: user_id, [INFO] [stderr] 137 | | item_id: item_id, [INFO] [stderr] ... | [INFO] [stderr] 140 | | &mut self.datastore, [INFO] [stderr] 141 | | ); [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 134 | self.persistencer.test_store_apply( [INFO] [stderr] 135 | &rustix_event_shop::BLEvents::MakeSimplePurchase { [INFO] [stderr] 136 | user_id: user_id, [INFO] [stderr] 137 | item_id: item_id, [INFO] [stderr] 138 | timestamp: millis_timestamp, [INFO] [stderr] 139 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustix_backend.rs:147:9 [INFO] [stderr] | [INFO] [stderr] 147 | return self.persistencer.reload_from_filepath(&mut self.datastore); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.persistencer.reload_from_filepath(&mut self.datastore)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustix_backend.rs:150:9 [INFO] [stderr] | [INFO] [stderr] 150 | / return self.persistencer.test_store_apply( [INFO] [stderr] 151 | | &rustix_event_shop::BLEvents::UndoPurchase { [INFO] [stderr] 152 | | unique_id: unique_id, [INFO] [stderr] 153 | | }, [INFO] [stderr] 154 | | &mut self.datastore, [INFO] [stderr] 155 | | ); [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 150 | self.persistencer.test_store_apply( [INFO] [stderr] 151 | &rustix_event_shop::BLEvents::UndoPurchase { [INFO] [stderr] 152 | unique_id: unique_id, [INFO] [stderr] 153 | }, [INFO] [stderr] 154 | &mut self.datastore, [INFO] [stderr] 155 | ) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustix_backend.rs:158:9 [INFO] [stderr] | [INFO] [stderr] 158 | / return self.persistencer.test_store_apply( [INFO] [stderr] 159 | | &rustix_event_shop::BLEvents::MakeSpecialPurchase { [INFO] [stderr] 160 | | user_id: user_id, [INFO] [stderr] 161 | | special_name: special_name, [INFO] [stderr] ... | [INFO] [stderr] 164 | | &mut self.datastore, [INFO] [stderr] 165 | | ); [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 158 | self.persistencer.test_store_apply( [INFO] [stderr] 159 | &rustix_event_shop::BLEvents::MakeSpecialPurchase { [INFO] [stderr] 160 | user_id: user_id, [INFO] [stderr] 161 | special_name: special_name, [INFO] [stderr] 162 | timestamp: millis_timestamp, [INFO] [stderr] 163 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustix_backend.rs:169:9 [INFO] [stderr] | [INFO] [stderr] 169 | / return self.persistencer.test_store_apply( [INFO] [stderr] 170 | | &rustix_event_shop::BLEvents::MakeFreeForAllPurchase { [INFO] [stderr] 171 | | ffa_id: ffa_id, [INFO] [stderr] 172 | | item_id: item_id, [INFO] [stderr] ... | [INFO] [stderr] 175 | | &mut self.datastore, [INFO] [stderr] 176 | | ); [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 169 | self.persistencer.test_store_apply( [INFO] [stderr] 170 | &rustix_event_shop::BLEvents::MakeFreeForAllPurchase { [INFO] [stderr] 171 | ffa_id: ffa_id, [INFO] [stderr] 172 | item_id: item_id, [INFO] [stderr] 173 | timestamp: millis_timestamp, [INFO] [stderr] 174 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustix_backend.rs:180:9 [INFO] [stderr] | [INFO] [stderr] 180 | / return self.persistencer.test_store_apply( [INFO] [stderr] 181 | | &rustix_event_shop::BLEvents::CreateFreeForAll { [INFO] [stderr] 182 | | allowed_categories: allowed_categories, [INFO] [stderr] 183 | | allowed_drinks: allowed_drinks, [INFO] [stderr] ... | [INFO] [stderr] 189 | | &mut self.datastore, [INFO] [stderr] 190 | | ); [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 180 | self.persistencer.test_store_apply( [INFO] [stderr] 181 | &rustix_event_shop::BLEvents::CreateFreeForAll { [INFO] [stderr] 182 | allowed_categories: allowed_categories, [INFO] [stderr] 183 | allowed_drinks: allowed_drinks, [INFO] [stderr] 184 | allowed_number_total: allowed_number_total, [INFO] [stderr] 185 | text_message: text_message, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustix_backend.rs:195:9 [INFO] [stderr] | [INFO] [stderr] 195 | / return self.persistencer.test_store_apply( [INFO] [stderr] 196 | | &rustix_event_shop::BLEvents::CreateFreeBudget { [INFO] [stderr] 197 | | cents_worth_total: cents_worth_total, [INFO] [stderr] 198 | | text_message: text_message, [INFO] [stderr] ... | [INFO] [stderr] 203 | | &mut self.datastore, [INFO] [stderr] 204 | | ); [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 195 | self.persistencer.test_store_apply( [INFO] [stderr] 196 | &rustix_event_shop::BLEvents::CreateFreeBudget { [INFO] [stderr] 197 | cents_worth_total: cents_worth_total, [INFO] [stderr] 198 | text_message: text_message, [INFO] [stderr] 199 | created_timestamp: created_timestamp, [INFO] [stderr] 200 | donor: donor, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustix_backend.rs:209:9 [INFO] [stderr] | [INFO] [stderr] 209 | / return self.persistencer.test_store_apply( [INFO] [stderr] 210 | | &rustix_event_shop::BLEvents::CreateFreeCount { [INFO] [stderr] 211 | | allowed_categories: allowed_categories, [INFO] [stderr] 212 | | allowed_drinks: allowed_drinks, [INFO] [stderr] ... | [INFO] [stderr] 219 | | &mut self.datastore, [INFO] [stderr] 220 | | ); [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 209 | self.persistencer.test_store_apply( [INFO] [stderr] 210 | &rustix_event_shop::BLEvents::CreateFreeCount { [INFO] [stderr] 211 | allowed_categories: allowed_categories, [INFO] [stderr] 212 | allowed_drinks: allowed_drinks, [INFO] [stderr] 213 | allowed_number_total: allowed_number_total, [INFO] [stderr] 214 | text_message: text_message, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustix_backend.rs:223:9 [INFO] [stderr] | [INFO] [stderr] 223 | / return self.persistencer.test_store_apply( [INFO] [stderr] 224 | | &rustix_event_shop::BLEvents::MakeShoppingCartPurchase { [INFO] [stderr] 225 | | user_id: user_id, [INFO] [stderr] 226 | | specials: specials, [INFO] [stderr] ... | [INFO] [stderr] 230 | | &mut self.datastore, [INFO] [stderr] 231 | | ); [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 223 | self.persistencer.test_store_apply( [INFO] [stderr] 224 | &rustix_event_shop::BLEvents::MakeShoppingCartPurchase { [INFO] [stderr] 225 | user_id: user_id, [INFO] [stderr] 226 | specials: specials, [INFO] [stderr] 227 | item_ids: item_ids, [INFO] [stderr] 228 | timestamp: millis_timestamp, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustix_backend.rs:234:9 [INFO] [stderr] | [INFO] [stderr] 234 | / return self.persistencer.test_store_apply( [INFO] [stderr] 235 | | &rustix_event_shop::BLEvents::UpdateItem { [INFO] [stderr] 236 | | item_id: item_id, [INFO] [stderr] 237 | | itemname: itemname, [INFO] [stderr] ... | [INFO] [stderr] 241 | | &mut self.datastore, [INFO] [stderr] 242 | | ); [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 234 | self.persistencer.test_store_apply( [INFO] [stderr] 235 | &rustix_event_shop::BLEvents::UpdateItem { [INFO] [stderr] 236 | item_id: item_id, [INFO] [stderr] 237 | itemname: itemname, [INFO] [stderr] 238 | price_cents: price_cents, [INFO] [stderr] 239 | category: category, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustix_backend.rs:246:9 [INFO] [stderr] | [INFO] [stderr] 246 | / return self.persistencer.test_store_apply( [INFO] [stderr] 247 | | &rustix_event_shop::BLEvents::UpdateUser { [INFO] [stderr] 248 | | user_id: user_id, [INFO] [stderr] 249 | | username: username, [INFO] [stderr] ... | [INFO] [stderr] 255 | | &mut self.datastore, [INFO] [stderr] 256 | | ); [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 246 | self.persistencer.test_store_apply( [INFO] [stderr] 247 | &rustix_event_shop::BLEvents::UpdateUser { [INFO] [stderr] 248 | user_id: user_id, [INFO] [stderr] 249 | username: username, [INFO] [stderr] 250 | is_billed: is_billed, [INFO] [stderr] 251 | is_highlighted: is_highlighted, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustix_backend.rs:259:9 [INFO] [stderr] | [INFO] [stderr] 259 | return self.persistencer.test_store_apply(event, &mut self.datastore); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.persistencer.test_store_apply(event, &mut self.datastore)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustix_backend.rs:289:33 [INFO] [stderr] | [INFO] [stderr] 289 | return Some(self.datastore.version); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(self.datastore.version)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustix_backend.rs:293:33 [INFO] [stderr] | [INFO] [stderr] 293 | return None [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustix_backend.rs:299:25 [INFO] [stderr] | [INFO] [stderr] 299 | return None [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustix_backend.rs:306:17 [INFO] [stderr] | [INFO] [stderr] 306 | return None [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustix_backend.rs:341:9 [INFO] [stderr] | [INFO] [stderr] 341 | return Some(version); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(version)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/persistencer.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | return RustixError::Init(e); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `RustixError::Init(e)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/persistencer.rs:59:9 [INFO] [stderr] | [INFO] [stderr] 59 | return RustixError::SerialJson(e); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `RustixError::SerialJson(e)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/persistencer.rs:65:9 [INFO] [stderr] | [INFO] [stderr] 65 | return RustixError::SerialUTF8(e); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `RustixError::SerialUTF8(e)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/persistencer.rs:71:9 [INFO] [stderr] | [INFO] [stderr] 71 | return RustixError::DB(e); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `RustixError::DB(e)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/persistencer.rs:120:9 [INFO] [stderr] | [INFO] [stderr] 120 | return Ok(fp); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(fp)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/persistencer.rs:134:5 [INFO] [stderr] | [INFO] [stderr] 134 | return [b1, b2, b3, b4]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `[b1, b2, b3, b4]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/persistencer.rs:150:9 [INFO] [stderr] | [INFO] [stderr] 150 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/persistencer.rs:164:21 [INFO] [stderr] | [INFO] [stderr] 164 | return false [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/persistencer.rs:169:21 [INFO] [stderr] | [INFO] [stderr] 169 | return event.apply(datastore, &self.config); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `event.apply(datastore, &self.config)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/persistencer.rs:173:13 [INFO] [stderr] | [INFO] [stderr] 173 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/persistencer.rs:216:9 [INFO] [stderr] | [INFO] [stderr] 216 | return Ok(datastore.version); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(datastore.version)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/persistencer.rs:224:5 [INFO] [stderr] | [INFO] [stderr] 224 | return wtr; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `wtr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/persistencer.rs:229:5 [INFO] [stderr] | [INFO] [stderr] 229 | return rdr.read_u64::().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `rdr.read_u64::().unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustix_event_shop.rs:136:5 [INFO] [stderr] | [INFO] [stderr] 136 | return r; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `r` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustix_event_shop.rs:141:9 [INFO] [stderr] | [INFO] [stderr] 141 | / return match self { [INFO] [stderr] 142 | | &BLEvents::CreateItem { [INFO] [stderr] 143 | | ref itemname, [INFO] [stderr] 144 | | price_cents, [INFO] [stderr] ... | [INFO] [stderr] 231 | | &BLEvents::SetPriceForSpecial { unique_id, price } => store.get_purchase(unique_id).is_some(), [INFO] [stderr] 232 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 141 | match self { [INFO] [stderr] 142 | &BLEvents::CreateItem { [INFO] [stderr] 143 | ref itemname, [INFO] [stderr] 144 | price_cents, [INFO] [stderr] 145 | ref category, [INFO] [stderr] 146 | } => true, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustix_event_shop.rs:236:9 [INFO] [stderr] | [INFO] [stderr] 236 | / return match self { [INFO] [stderr] 237 | | &BLEvents::CreateItem { [INFO] [stderr] 238 | | ref itemname, [INFO] [stderr] 239 | | ref price_cents, [INFO] [stderr] ... | [INFO] [stderr] 1196 | | }, [INFO] [stderr] 1197 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 236 | match self { [INFO] [stderr] 237 | &BLEvents::CreateItem { [INFO] [stderr] 238 | ref itemname, [INFO] [stderr] 239 | ref price_cents, [INFO] [stderr] 240 | ref category, [INFO] [stderr] 241 | } => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | / return StaticConfig { [INFO] [stderr] 15 | | users_per_page: 40, [INFO] [stderr] 16 | | users_in_top_users: 40, [INFO] [stderr] 17 | | top_drinks_per_user: 4, [INFO] [stderr] 18 | | use_persistence: true, [INFO] [stderr] 19 | | persistence_file_path: filepath.to_string(), [INFO] [stderr] 20 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 14 | StaticConfig { [INFO] [stderr] 15 | users_per_page: 40, [INFO] [stderr] 16 | users_in_top_users: 40, [INFO] [stderr] 17 | top_drinks_per_user: 4, [INFO] [stderr] 18 | use_persistence: true, [INFO] [stderr] 19 | persistence_file_path: filepath.to_string(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | / return StaticConfig { [INFO] [stderr] 27 | | users_per_page: 20, [INFO] [stderr] 28 | | users_in_top_users: 20, [INFO] [stderr] 29 | | top_drinks_per_user: 4, [INFO] [stderr] 30 | | use_persistence: false, [INFO] [stderr] 31 | | persistence_file_path: String::new(), [INFO] [stderr] 32 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 26 | StaticConfig { [INFO] [stderr] 27 | users_per_page: 20, [INFO] [stderr] 28 | users_in_top_users: 20, [INFO] [stderr] 29 | top_drinks_per_user: 4, [INFO] [stderr] 30 | use_persistence: false, [INFO] [stderr] 31 | persistence_file_path: String::new(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:50:5 [INFO] [stderr] | [INFO] [stderr] 50 | return build_transient_backend_with(20, 20); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `build_transient_backend_with(20, 20)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:62:5 [INFO] [stderr] | [INFO] [stderr] 62 | / return rustix_backend::RustixBackend { [INFO] [stderr] 63 | | datastore: datastore::Datastore::default(), [INFO] [stderr] 64 | | persistencer: persistencer::FilePersister::new(config).unwrap(), [INFO] [stderr] 65 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 62 | rustix_backend::RustixBackend { [INFO] [stderr] 63 | datastore: datastore::Datastore::default(), [INFO] [stderr] 64 | persistencer: persistencer::FilePersister::new(config).unwrap(), [INFO] [stderr] 65 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:71:5 [INFO] [stderr] | [INFO] [stderr] 71 | / return rustix_backend::RustixBackend { [INFO] [stderr] 72 | | datastore: datastore::Datastore::default(), [INFO] [stderr] 73 | | persistencer: persistencer::FilePersister::new(config).unwrap(), [INFO] [stderr] 74 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 71 | rustix_backend::RustixBackend { [INFO] [stderr] 72 | datastore: datastore::Datastore::default(), [INFO] [stderr] 73 | persistencer: persistencer::FilePersister::new(config).unwrap(), [INFO] [stderr] 74 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/left_threaded_avl_tree.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | / return ScoredIdTreeMock { [INFO] [stderr] 26 | | ids: Vec::new(), [INFO] [stderr] 27 | | scores: Vec::new(), [INFO] [stderr] 28 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 25 | ScoredIdTreeMock { [INFO] [stderr] 26 | ids: Vec::new(), [INFO] [stderr] 27 | scores: Vec::new(), [INFO] [stderr] 28 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/left_threaded_avl_tree.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/left_threaded_avl_tree.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | return x; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/left_threaded_avl_tree.rs:47:19 [INFO] [stderr] | [INFO] [stderr] 47 | let hm = &*(&mut hashmap); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try this: `hashmap` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deref_addrof)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/left_threaded_avl_tree.rs:57:9 [INFO] [stderr] | [INFO] [stderr] 57 | return ScoredIdTreeMock::default(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ScoredIdTreeMock::default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/left_threaded_avl_tree.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/left_threaded_avl_tree.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/left_threaded_avl_tree.rs:72:9 [INFO] [stderr] | [INFO] [stderr] 72 | / return o.map(|i| { [INFO] [stderr] 73 | | self.scores[i] = self.scores[i] + 1; [INFO] [stderr] 74 | | self.scores[i] [INFO] [stderr] 75 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 72 | o.map(|i| { [INFO] [stderr] 73 | self.scores[i] = self.scores[i] + 1; [INFO] [stderr] 74 | self.scores[i] [INFO] [stderr] 75 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/left_threaded_avl_tree.rs:83:17 [INFO] [stderr] | [INFO] [stderr] 83 | return Some(self.scores.remove(i)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(self.scores.remove(i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/left_threaded_avl_tree.rs:86:17 [INFO] [stderr] | [INFO] [stderr] 86 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/left_threaded_avl_tree.rs:93:9 [INFO] [stderr] | [INFO] [stderr] 93 | return self.score_sorted_copy()[0..(n)].to_vec(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.score_sorted_copy()[0..(n)].to_vec()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/datastore.rs:108:33 [INFO] [stderr] | [INFO] [stderr] 108 | fn rebuild_user_tree(&self) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/datastore.rs:112:33 [INFO] [stderr] | [INFO] [stderr] 112 | fn rebuild_item_tree(&self) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:121:9 [INFO] [stderr] | [INFO] [stderr] 121 | return self.get_purchase(purchase_id).map(|p| *(p.get_timestamp())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.get_purchase(purchase_id).map(|p| *(p.get_timestamp()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:125:9 [INFO] [stderr] | [INFO] [stderr] 125 | return self.top_user_scores.extract_top(n as usize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.top_user_scores.extract_top(n as usize)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:134:9 [INFO] [stderr] | [INFO] [stderr] 134 | return v; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `v` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:138:9 [INFO] [stderr] | [INFO] [stderr] 138 | return self.items_suffix_tree.search(searchterm).iter().map(|sr : &SearchResult|sr.id).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.items_suffix_tree.search(searchterm).iter().map(|sr : &SearchResult|sr.id).collect()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:149:9 [INFO] [stderr] | [INFO] [stderr] 149 | return v; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `v` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:157:9 [INFO] [stderr] | [INFO] [stderr] 157 | return &self.purchases[from..to]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&self.purchases[from..to]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:165:9 [INFO] [stderr] | [INFO] [stderr] 165 | return v; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `v` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:169:31 [INFO] [stderr] | [INFO] [stderr] 169 | Some(ref tree) => return tree.extract_top(n as usize), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `tree.extract_top(n as usize)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:180:9 [INFO] [stderr] | [INFO] [stderr] 180 | return v; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `v` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:186:9 [INFO] [stderr] | [INFO] [stderr] 186 | return idx.map(move |id| self.purchases.get_mut(id).unwrap()).ok(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `idx.map(move |id| self.purchases.get_mut(id).unwrap()).ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:190:9 [INFO] [stderr] | [INFO] [stderr] 190 | return self.bills.iter_mut().find(|b| b.timestamp_from == timestamp_from && b.timestamp_to == timestamp_to); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.bills.iter_mut().find(|b| b.timestamp_from == timestamp_from && b.timestamp_to == timestamp_to)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:194:9 [INFO] [stderr] | [INFO] [stderr] 194 | return self.bills.iter().position(|b| b.timestamp_from == timestamp_from && b.timestamp_to == timestamp_to); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.bills.iter().position(|b| b.timestamp_from == timestamp_from && b.timestamp_to == timestamp_to)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:201:13 [INFO] [stderr] | [INFO] [stderr] 201 | return Vec::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Vec::new()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:204:13 [INFO] [stderr] | [INFO] [stderr] 204 | / return self.purchases[from..to].iter().filter(|p| { [INFO] [stderr] 205 | | p.has_user_id() && matches_usergroup(&Some(*p.get_user_id()), &bill.users) && (match **p { [INFO] [stderr] 206 | | Purchase::SpecialPurchase { [INFO] [stderr] 207 | | .. [INFO] [stderr] ... | [INFO] [stderr] 210 | | }) [INFO] [stderr] 211 | | }).map(|p|p.get_unique_id()).collect(); [INFO] [stderr] | |___________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 204 | self.purchases[from..to].iter().filter(|p| { [INFO] [stderr] 205 | p.has_user_id() && matches_usergroup(&Some(*p.get_user_id()), &bill.users) && (match **p { [INFO] [stderr] 206 | Purchase::SpecialPurchase { [INFO] [stderr] 207 | .. [INFO] [stderr] 208 | } => true, [INFO] [stderr] 209 | _ => false, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:218:13 [INFO] [stderr] | [INFO] [stderr] 218 | return Vec::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Vec::new()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:230:17 [INFO] [stderr] | [INFO] [stderr] 230 | return xs; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `xs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:237:13 [INFO] [stderr] | [INFO] [stderr] 237 | return Vec::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Vec::new()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:267:13 [INFO] [stderr] | [INFO] [stderr] 267 | return users_undefined_indices; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `users_undefined_indices` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/datastore.rs:248:17 [INFO] [stderr] | [INFO] [stderr] 248 | / if matches_usergroup(&Some(uid), &bill.users) { [INFO] [stderr] 249 | | if !touched_users_set.contains(&uid) { [INFO] [stderr] 250 | | //user matches criteria & isn't in list => add user to list [INFO] [stderr] 251 | | touched_users_set.insert(uid); [INFO] [stderr] ... | [INFO] [stderr] 263 | | } [INFO] [stderr] 264 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 248 | if matches_usergroup(&Some(uid), &bill.users) && !touched_users_set.contains(&uid) { [INFO] [stderr] 249 | //user matches criteria & isn't in list => add user to list [INFO] [stderr] 250 | touched_users_set.insert(uid); [INFO] [stderr] 251 | let usr = self.users.get(&uid).unwrap(); [INFO] [stderr] 252 | [INFO] [stderr] 253 | if !usr.is_billed { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:279:13 [INFO] [stderr] | [INFO] [stderr] 279 | return xs; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `xs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:282:9 [INFO] [stderr] | [INFO] [stderr] 282 | return self.bills.iter().find(|b| b.timestamp_from == timestamp_from && b.timestamp_to == timestamp_to); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.bills.iter().find(|b| b.timestamp_from == timestamp_from && b.timestamp_to == timestamp_to)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:297:9 [INFO] [stderr] | [INFO] [stderr] 297 | return v; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `v` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:315:9 [INFO] [stderr] | [INFO] [stderr] 315 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:343:9 [INFO] [stderr] | [INFO] [stderr] 343 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/datastore.rs:333:37 [INFO] [stderr] | [INFO] [stderr] 333 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:349:13 [INFO] [stderr] | [INFO] [stderr] 349 | return self.open_ffa.get(found); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.open_ffa.get(found)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:354:17 [INFO] [stderr] | [INFO] [stderr] 354 | return self.used_up_freebies.get(found); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.used_up_freebies.get(found)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:356:17 [INFO] [stderr] | [INFO] [stderr] 356 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:364:13 [INFO] [stderr] | [INFO] [stderr] 364 | return self.used_up_freebies.get(found_closed.unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.used_up_freebies.get(found_closed.unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:369:21 [INFO] [stderr] | [INFO] [stderr] 369 | return self.open_freebies.get(&recipient_id).unwrap().get(found_open.unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.open_freebies.get(&recipient_id).unwrap().get(found_open.unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:371:21 [INFO] [stderr] | [INFO] [stderr] 371 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:374:17 [INFO] [stderr] | [INFO] [stderr] 374 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/datastore.rs:365:16 [INFO] [stderr] | [INFO] [stderr] 365 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 366 | | if self.open_freebies.contains_key(&recipient_id) { [INFO] [stderr] 367 | | let found_open = self.open_freebies.get(&recipient_id).unwrap().binary_search_by(|f| f.get_id().cmp(&freeby_id)); [INFO] [stderr] 368 | | if found_open.is_ok() { [INFO] [stderr] ... | [INFO] [stderr] 375 | | } [INFO] [stderr] 376 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 365 | } else if self.open_freebies.contains_key(&recipient_id) { [INFO] [stderr] 366 | let found_open = self.open_freebies.get(&recipient_id).unwrap().binary_search_by(|f| f.get_id().cmp(&freeby_id)); [INFO] [stderr] 367 | if found_open.is_ok() { [INFO] [stderr] 368 | return self.open_freebies.get(&recipient_id).unwrap().get(found_open.unwrap()); [INFO] [stderr] 369 | } else { [INFO] [stderr] 370 | return None; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:384:9 [INFO] [stderr] | [INFO] [stderr] 384 | / return match *usergroup { [INFO] [stderr] 385 | | UserGroup::SingleUser { [INFO] [stderr] 386 | | ref user_id [INFO] [stderr] 387 | | } => *user_id == checked_user_id, [INFO] [stderr] ... | [INFO] [stderr] 391 | | } => user_ids.iter().any(|id| *id == checked_user_id), [INFO] [stderr] 392 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 384 | match *usergroup { [INFO] [stderr] 385 | UserGroup::SingleUser { [INFO] [stderr] 386 | ref user_id [INFO] [stderr] 387 | } => *user_id == checked_user_id, [INFO] [stderr] 388 | UserGroup::AllUsers => true, [INFO] [stderr] 389 | UserGroup::MultipleUsers { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:394:9 [INFO] [stderr] | [INFO] [stderr] 394 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:400:5 [INFO] [stderr] | [INFO] [stderr] 400 | return user_id.map(|id| usergroup.contains(&id)).unwrap_or(true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `user_id.map(|id| usergroup.contains(&id)).unwrap_or(true)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:422:5 [INFO] [stderr] | [INFO] [stderr] 422 | return (first,last); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(first,last)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:441:9 [INFO] [stderr] | [INFO] [stderr] 441 | return self.users.contains_key(&id); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.users.contains_key(&id)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:446:9 [INFO] [stderr] | [INFO] [stderr] 446 | return self.items.contains_key(&id); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.items.contains_key(&id)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:458:9 [INFO] [stderr] | [INFO] [stderr] 458 | / return self.purchases.iter_mut().find(|p|{ [INFO] [stderr] 459 | | p.has_unique_id(id) [INFO] [stderr] 460 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 458 | self.purchases.iter_mut().find(|p|{ [INFO] [stderr] 459 | p.has_unique_id(id) [INFO] [stderr] 460 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:468:9 [INFO] [stderr] | [INFO] [stderr] 468 | return s; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `s` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:472:9 [INFO] [stderr] | [INFO] [stderr] 472 | return self.user_id; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.user_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:480:9 [INFO] [stderr] | [INFO] [stderr] 480 | return s; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `s` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:484:9 [INFO] [stderr] | [INFO] [stderr] 484 | return self.item_id; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.item_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:493:9 [INFO] [stderr] | [INFO] [stderr] 493 | / return Datastore { [INFO] [stderr] 494 | | users: HashMap::new(), [INFO] [stderr] 495 | | users_suffix_tree: MockKDTree::build(&empty_user_vec, true), [INFO] [stderr] 496 | | items: HashMap::new(), [INFO] [stderr] ... | [INFO] [stderr] 515 | | version: 0, [INFO] [stderr] 516 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 493 | Datastore { [INFO] [stderr] 494 | users: HashMap::new(), [INFO] [stderr] 495 | users_suffix_tree: MockKDTree::build(&empty_user_vec, true), [INFO] [stderr] 496 | items: HashMap::new(), [INFO] [stderr] 497 | items_suffix_tree: MockKDTree::build(&empty_item_vec, true), [INFO] [stderr] 498 | purchases: Vec::new(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:531:9 [INFO] [stderr] | [INFO] [stderr] 531 | return UserGroup::AllUsers; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `UserGroup::AllUsers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:550:9 [INFO] [stderr] | [INFO] [stderr] 550 | / return User { [INFO] [stderr] 551 | | username: self.username.to_string(), [INFO] [stderr] 552 | | external_user_id: self.external_user_id.clone(), [INFO] [stderr] 553 | | user_id: self.user_id, [INFO] [stderr] ... | [INFO] [stderr] 557 | | deleted: self.deleted, [INFO] [stderr] 558 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 550 | User { [INFO] [stderr] 551 | username: self.username.to_string(), [INFO] [stderr] 552 | external_user_id: self.external_user_id.clone(), [INFO] [stderr] 553 | user_id: self.user_id, [INFO] [stderr] 554 | is_billed: self.is_billed, [INFO] [stderr] 555 | is_sepa: self.is_sepa, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:585:35 [INFO] [stderr] | [INFO] [stderr] 585 | BillState::Created => return true, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:586:18 [INFO] [stderr] | [INFO] [stderr] 586 | _ => return false, [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:590:9 [INFO] [stderr] | [INFO] [stderr] 590 | return !self.is_created() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `!self.is_created()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:596:9 [INFO] [stderr] | [INFO] [stderr] 596 | return BillState::Created; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `BillState::Created` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:670:9 [INFO] [stderr] | [INFO] [stderr] 670 | return day as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `day as usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:766:9 [INFO] [stderr] | [INFO] [stderr] 766 | / return match *self { [INFO] [stderr] 767 | | Freeby::Classic { [INFO] [stderr] 768 | | ref id, [INFO] [stderr] 769 | | ref allowed_categories, [INFO] [stderr] ... | [INFO] [stderr] 802 | | }, [INFO] [stderr] 803 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 766 | match *self { [INFO] [stderr] 767 | Freeby::Classic { [INFO] [stderr] 768 | ref id, [INFO] [stderr] 769 | ref allowed_categories, [INFO] [stderr] 770 | ref allowed_drinks, [INFO] [stderr] 771 | ref allowed_number_total, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:806:9 [INFO] [stderr] | [INFO] [stderr] 806 | / return match *self { [INFO] [stderr] 807 | | Freeby::Classic { [INFO] [stderr] 808 | | ref id, [INFO] [stderr] 809 | | ref allowed_categories, [INFO] [stderr] ... | [INFO] [stderr] 842 | | }, [INFO] [stderr] 843 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 806 | match *self { [INFO] [stderr] 807 | Freeby::Classic { [INFO] [stderr] 808 | ref id, [INFO] [stderr] 809 | ref allowed_categories, [INFO] [stderr] 810 | ref allowed_drinks, [INFO] [stderr] 811 | ref allowed_number_total, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:847:9 [INFO] [stderr] | [INFO] [stderr] 847 | / return match *self { [INFO] [stderr] 848 | | Freeby::Classic { [INFO] [stderr] 849 | | ref id, [INFO] [stderr] 850 | | ref allowed_categories, [INFO] [stderr] ... | [INFO] [stderr] 883 | | }, [INFO] [stderr] 884 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 847 | match *self { [INFO] [stderr] 848 | Freeby::Classic { [INFO] [stderr] 849 | ref id, [INFO] [stderr] 850 | ref allowed_categories, [INFO] [stderr] 851 | ref allowed_drinks, [INFO] [stderr] 852 | ref allowed_number_total, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:888:9 [INFO] [stderr] | [INFO] [stderr] 888 | / return match *self { [INFO] [stderr] 889 | | Freeby::Classic { [INFO] [stderr] 890 | | ref id, [INFO] [stderr] 891 | | ref allowed_categories, [INFO] [stderr] ... | [INFO] [stderr] 924 | | }, [INFO] [stderr] 925 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 888 | match *self { [INFO] [stderr] 889 | Freeby::Classic { [INFO] [stderr] 890 | ref id, [INFO] [stderr] 891 | ref allowed_categories, [INFO] [stderr] 892 | ref allowed_drinks, [INFO] [stderr] 893 | ref allowed_number_total, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:929:9 [INFO] [stderr] | [INFO] [stderr] 929 | / return match *self { [INFO] [stderr] 930 | | Freeby::Classic { [INFO] [stderr] 931 | | ref id, [INFO] [stderr] 932 | | ref allowed_categories, [INFO] [stderr] ... | [INFO] [stderr] 965 | | }, [INFO] [stderr] 966 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 929 | match *self { [INFO] [stderr] 930 | Freeby::Classic { [INFO] [stderr] 931 | ref id, [INFO] [stderr] 932 | ref allowed_categories, [INFO] [stderr] 933 | ref allowed_drinks, [INFO] [stderr] 934 | ref allowed_number_total, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:970:9 [INFO] [stderr] | [INFO] [stderr] 970 | / return match *self { [INFO] [stderr] 971 | | Freeby::Classic { [INFO] [stderr] 972 | | ref id, [INFO] [stderr] 973 | | ref allowed_categories, [INFO] [stderr] ... | [INFO] [stderr] 1007 | | }, [INFO] [stderr] 1008 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 970 | match *self { [INFO] [stderr] 971 | Freeby::Classic { [INFO] [stderr] 972 | ref id, [INFO] [stderr] 973 | ref allowed_categories, [INFO] [stderr] 974 | ref allowed_drinks, [INFO] [stderr] 975 | ref allowed_number_total, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:1011:9 [INFO] [stderr] | [INFO] [stderr] 1011 | / return match *self { [INFO] [stderr] 1012 | | Freeby::Classic { [INFO] [stderr] 1013 | | ref id, [INFO] [stderr] 1014 | | ref allowed_categories, [INFO] [stderr] ... | [INFO] [stderr] 1049 | | }, [INFO] [stderr] 1050 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 1011 | match *self { [INFO] [stderr] 1012 | Freeby::Classic { [INFO] [stderr] 1013 | ref id, [INFO] [stderr] 1014 | ref allowed_categories, [INFO] [stderr] 1015 | ref allowed_drinks, [INFO] [stderr] 1016 | ref allowed_number_total, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/datastore.rs:1010:29 [INFO] [stderr] | [INFO] [stderr] 1010 | fn decrement(&mut self) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:1053:9 [INFO] [stderr] | [INFO] [stderr] 1053 | / return match *self { [INFO] [stderr] 1054 | | Freeby::Transfer{ [INFO] [stderr] 1055 | | ref id, [INFO] [stderr] 1056 | | ref cents_worth_total, [INFO] [stderr] ... | [INFO] [stderr] 1065 | | _ => panic!("Cannot get cents left for non-budget-freeby"), [INFO] [stderr] 1066 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 1053 | match *self { [INFO] [stderr] 1054 | Freeby::Transfer{ [INFO] [stderr] 1055 | ref id, [INFO] [stderr] 1056 | ref cents_worth_total, [INFO] [stderr] 1057 | ref cents_worth_used, [INFO] [stderr] 1058 | ref text_message, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:1097:9 [INFO] [stderr] | [INFO] [stderr] 1097 | return FreebyAble::left(self) != 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `FreebyAble::left(self) != 0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:1116:9 [INFO] [stderr] | [INFO] [stderr] 1116 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:1158:17 [INFO] [stderr] | [INFO] [stderr] 1158 | return *unique_id; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `*unique_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:1166:17 [INFO] [stderr] | [INFO] [stderr] 1166 | return *unique_id; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `*unique_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:1175:17 [INFO] [stderr] | [INFO] [stderr] 1175 | return *unique_id; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `*unique_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:1188:18 [INFO] [stderr] | [INFO] [stderr] 1188 | } => return *specialcost, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `*specialcost` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:1202:17 [INFO] [stderr] | [INFO] [stderr] 1202 | return *unique_id == other; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `*unique_id == other` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:1210:17 [INFO] [stderr] | [INFO] [stderr] 1210 | return *unique_id == other; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `*unique_id == other` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:1219:17 [INFO] [stderr] | [INFO] [stderr] 1219 | return *unique_id == other; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `*unique_id == other` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:1233:17 [INFO] [stderr] | [INFO] [stderr] 1233 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:1241:17 [INFO] [stderr] | [INFO] [stderr] 1241 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:1250:17 [INFO] [stderr] | [INFO] [stderr] 1250 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:1263:17 [INFO] [stderr] | [INFO] [stderr] 1263 | return consumer_id; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `consumer_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:1271:17 [INFO] [stderr] | [INFO] [stderr] 1271 | return consumer_id; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `consumer_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:1280:17 [INFO] [stderr] | [INFO] [stderr] 1280 | return donor; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `donor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:1302:17 [INFO] [stderr] | [INFO] [stderr] 1302 | return item_id; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `item_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:1311:17 [INFO] [stderr] | [INFO] [stderr] 1311 | return item_id; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `item_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:1325:17 [INFO] [stderr] | [INFO] [stderr] 1325 | return timestamp_epoch_millis; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `timestamp_epoch_millis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:1333:17 [INFO] [stderr] | [INFO] [stderr] 1333 | return timestamp_epoch_millis; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `timestamp_epoch_millis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/datastore.rs:1342:17 [INFO] [stderr] | [INFO] [stderr] 1342 | return timestamp_epoch_millis; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `timestamp_epoch_millis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustix_backend.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | / return self.persistencer.test_store_apply( [INFO] [stderr] 86 | | &rustix_event_shop::BLEvents::CreateBill { [INFO] [stderr] 87 | | timestamp_from: timestamp_from, [INFO] [stderr] 88 | | timestamp_to: timestamp_to, [INFO] [stderr] ... | [INFO] [stderr] 92 | | &mut self.datastore, [INFO] [stderr] 93 | | ); [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 85 | self.persistencer.test_store_apply( [INFO] [stderr] 86 | &rustix_event_shop::BLEvents::CreateBill { [INFO] [stderr] 87 | timestamp_from: timestamp_from, [INFO] [stderr] 88 | timestamp_to: timestamp_to, [INFO] [stderr] 89 | user_ids: user_ids, [INFO] [stderr] 90 | comment: comment, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustix_backend.rs:102:9 [INFO] [stderr] | [INFO] [stderr] 102 | / return self.persistencer.test_store_apply( [INFO] [stderr] 103 | | &rustix_event_shop::BLEvents::CreateItem { [INFO] [stderr] 104 | | itemname: itemname, [INFO] [stderr] 105 | | price_cents: price_cents, [INFO] [stderr] ... | [INFO] [stderr] 108 | | &mut self.datastore, [INFO] [stderr] 109 | | ); [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 102 | self.persistencer.test_store_apply( [INFO] [stderr] 103 | &rustix_event_shop::BLEvents::CreateItem { [INFO] [stderr] 104 | itemname: itemname, [INFO] [stderr] 105 | price_cents: price_cents, [INFO] [stderr] 106 | category: category, [INFO] [stderr] 107 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustix_backend.rs:113:9 [INFO] [stderr] | [INFO] [stderr] 113 | / return self.persistencer.test_store_apply( [INFO] [stderr] 114 | | &rustix_event_shop::BLEvents::CreateUser { username: username }, [INFO] [stderr] 115 | | &mut self.datastore, [INFO] [stderr] 116 | | ); [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 113 | self.persistencer.test_store_apply( [INFO] [stderr] 114 | &rustix_event_shop::BLEvents::CreateUser { username: username }, [INFO] [stderr] 115 | &mut self.datastore, [INFO] [stderr] 116 | ) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustix_backend.rs:120:9 [INFO] [stderr] | [INFO] [stderr] 120 | / return self.persistencer.test_store_apply( [INFO] [stderr] 121 | | &rustix_event_shop::BLEvents::DeleteUser { user_id: user_id }, [INFO] [stderr] 122 | | &mut self.datastore, [INFO] [stderr] 123 | | ); [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 120 | self.persistencer.test_store_apply( [INFO] [stderr] 121 | &rustix_event_shop::BLEvents::DeleteUser { user_id: user_id }, [INFO] [stderr] 122 | &mut self.datastore, [INFO] [stderr] 123 | ) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustix_backend.rs:127:9 [INFO] [stderr] | [INFO] [stderr] 127 | / return self.persistencer.test_store_apply( [INFO] [stderr] 128 | | &rustix_event_shop::BLEvents::DeleteItem { item_id: item_id }, [INFO] [stderr] 129 | | &mut self.datastore, [INFO] [stderr] 130 | | ); [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 127 | self.persistencer.test_store_apply( [INFO] [stderr] 128 | &rustix_event_shop::BLEvents::DeleteItem { item_id: item_id }, [INFO] [stderr] 129 | &mut self.datastore, [INFO] [stderr] 130 | ) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustix_backend.rs:134:9 [INFO] [stderr] | [INFO] [stderr] 134 | / return self.persistencer.test_store_apply( [INFO] [stderr] 135 | | &rustix_event_shop::BLEvents::MakeSimplePurchase { [INFO] [stderr] 136 | | user_id: user_id, [INFO] [stderr] 137 | | item_id: item_id, [INFO] [stderr] ... | [INFO] [stderr] 140 | | &mut self.datastore, [INFO] [stderr] 141 | | ); [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 134 | self.persistencer.test_store_apply( [INFO] [stderr] 135 | &rustix_event_shop::BLEvents::MakeSimplePurchase { [INFO] [stderr] 136 | user_id: user_id, [INFO] [stderr] 137 | item_id: item_id, [INFO] [stderr] 138 | timestamp: millis_timestamp, [INFO] [stderr] 139 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustix_backend.rs:147:9 [INFO] [stderr] | [INFO] [stderr] 147 | return self.persistencer.reload_from_filepath(&mut self.datastore); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.persistencer.reload_from_filepath(&mut self.datastore)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustix_backend.rs:150:9 [INFO] [stderr] | [INFO] [stderr] 150 | / return self.persistencer.test_store_apply( [INFO] [stderr] 151 | | &rustix_event_shop::BLEvents::UndoPurchase { [INFO] [stderr] 152 | | unique_id: unique_id, [INFO] [stderr] 153 | | }, [INFO] [stderr] 154 | | &mut self.datastore, [INFO] [stderr] 155 | | ); [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 150 | self.persistencer.test_store_apply( [INFO] [stderr] 151 | &rustix_event_shop::BLEvents::UndoPurchase { [INFO] [stderr] 152 | unique_id: unique_id, [INFO] [stderr] 153 | }, [INFO] [stderr] 154 | &mut self.datastore, [INFO] [stderr] 155 | ) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustix_backend.rs:158:9 [INFO] [stderr] | [INFO] [stderr] 158 | / return self.persistencer.test_store_apply( [INFO] [stderr] 159 | | &rustix_event_shop::BLEvents::MakeSpecialPurchase { [INFO] [stderr] 160 | | user_id: user_id, [INFO] [stderr] 161 | | special_name: special_name, [INFO] [stderr] ... | [INFO] [stderr] 164 | | &mut self.datastore, [INFO] [stderr] 165 | | ); [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 158 | self.persistencer.test_store_apply( [INFO] [stderr] 159 | &rustix_event_shop::BLEvents::MakeSpecialPurchase { [INFO] [stderr] 160 | user_id: user_id, [INFO] [stderr] 161 | special_name: special_name, [INFO] [stderr] 162 | timestamp: millis_timestamp, [INFO] [stderr] 163 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustix_backend.rs:169:9 [INFO] [stderr] | [INFO] [stderr] 169 | / return self.persistencer.test_store_apply( [INFO] [stderr] 170 | | &rustix_event_shop::BLEvents::MakeFreeForAllPurchase { [INFO] [stderr] 171 | | ffa_id: ffa_id, [INFO] [stderr] 172 | | item_id: item_id, [INFO] [stderr] ... | [INFO] [stderr] 175 | | &mut self.datastore, [INFO] [stderr] 176 | | ); [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 169 | self.persistencer.test_store_apply( [INFO] [stderr] 170 | &rustix_event_shop::BLEvents::MakeFreeForAllPurchase { [INFO] [stderr] 171 | ffa_id: ffa_id, [INFO] [stderr] 172 | item_id: item_id, [INFO] [stderr] 173 | timestamp: millis_timestamp, [INFO] [stderr] 174 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustix_backend.rs:180:9 [INFO] [stderr] | [INFO] [stderr] 180 | / return self.persistencer.test_store_apply( [INFO] [stderr] 181 | | &rustix_event_shop::BLEvents::CreateFreeForAll { [INFO] [stderr] 182 | | allowed_categories: allowed_categories, [INFO] [stderr] 183 | | allowed_drinks: allowed_drinks, [INFO] [stderr] ... | [INFO] [stderr] 189 | | &mut self.datastore, [INFO] [stderr] 190 | | ); [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 180 | self.persistencer.test_store_apply( [INFO] [stderr] 181 | &rustix_event_shop::BLEvents::CreateFreeForAll { [INFO] [stderr] 182 | allowed_categories: allowed_categories, [INFO] [stderr] 183 | allowed_drinks: allowed_drinks, [INFO] [stderr] 184 | allowed_number_total: allowed_number_total, [INFO] [stderr] 185 | text_message: text_message, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustix_backend.rs:195:9 [INFO] [stderr] | [INFO] [stderr] 195 | / return self.persistencer.test_store_apply( [INFO] [stderr] 196 | | &rustix_event_shop::BLEvents::CreateFreeBudget { [INFO] [stderr] 197 | | cents_worth_total: cents_worth_total, [INFO] [stderr] 198 | | text_message: text_message, [INFO] [stderr] ... | [INFO] [stderr] 203 | | &mut self.datastore, [INFO] [stderr] 204 | | ); [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 195 | self.persistencer.test_store_apply( [INFO] [stderr] 196 | &rustix_event_shop::BLEvents::CreateFreeBudget { [INFO] [stderr] 197 | cents_worth_total: cents_worth_total, [INFO] [stderr] 198 | text_message: text_message, [INFO] [stderr] 199 | created_timestamp: created_timestamp, [INFO] [stderr] 200 | donor: donor, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustix_backend.rs:209:9 [INFO] [stderr] | [INFO] [stderr] 209 | / return self.persistencer.test_store_apply( [INFO] [stderr] 210 | | &rustix_event_shop::BLEvents::CreateFreeCount { [INFO] [stderr] 211 | | allowed_categories: allowed_categories, [INFO] [stderr] 212 | | allowed_drinks: allowed_drinks, [INFO] [stderr] ... | [INFO] [stderr] 219 | | &mut self.datastore, [INFO] [stderr] 220 | | ); [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 209 | self.persistencer.test_store_apply( [INFO] [stderr] 210 | &rustix_event_shop::BLEvents::CreateFreeCount { [INFO] [stderr] 211 | allowed_categories: allowed_categories, [INFO] [stderr] 212 | allowed_drinks: allowed_drinks, [INFO] [stderr] 213 | allowed_number_total: allowed_number_total, [INFO] [stderr] 214 | text_message: text_message, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustix_backend.rs:223:9 [INFO] [stderr] | [INFO] [stderr] 223 | / return self.persistencer.test_store_apply( [INFO] [stderr] 224 | | &rustix_event_shop::BLEvents::MakeShoppingCartPurchase { [INFO] [stderr] 225 | | user_id: user_id, [INFO] [stderr] 226 | | specials: specials, [INFO] [stderr] ... | [INFO] [stderr] 230 | | &mut self.datastore, [INFO] [stderr] 231 | | ); [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 223 | self.persistencer.test_store_apply( [INFO] [stderr] 224 | &rustix_event_shop::BLEvents::MakeShoppingCartPurchase { [INFO] [stderr] 225 | user_id: user_id, [INFO] [stderr] 226 | specials: specials, [INFO] [stderr] 227 | item_ids: item_ids, [INFO] [stderr] 228 | timestamp: millis_timestamp, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustix_backend.rs:234:9 [INFO] [stderr] | [INFO] [stderr] 234 | / return self.persistencer.test_store_apply( [INFO] [stderr] 235 | | &rustix_event_shop::BLEvents::UpdateItem { [INFO] [stderr] 236 | | item_id: item_id, [INFO] [stderr] 237 | | itemname: itemname, [INFO] [stderr] ... | [INFO] [stderr] 241 | | &mut self.datastore, [INFO] [stderr] 242 | | ); [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 234 | self.persistencer.test_store_apply( [INFO] [stderr] 235 | &rustix_event_shop::BLEvents::UpdateItem { [INFO] [stderr] 236 | item_id: item_id, [INFO] [stderr] 237 | itemname: itemname, [INFO] [stderr] 238 | price_cents: price_cents, [INFO] [stderr] 239 | category: category, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustix_backend.rs:246:9 [INFO] [stderr] | [INFO] [stderr] 246 | / return self.persistencer.test_store_apply( [INFO] [stderr] 247 | | &rustix_event_shop::BLEvents::UpdateUser { [INFO] [stderr] 248 | | user_id: user_id, [INFO] [stderr] 249 | | username: username, [INFO] [stderr] ... | [INFO] [stderr] 255 | | &mut self.datastore, [INFO] [stderr] 256 | | ); [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 246 | self.persistencer.test_store_apply( [INFO] [stderr] 247 | &rustix_event_shop::BLEvents::UpdateUser { [INFO] [stderr] 248 | user_id: user_id, [INFO] [stderr] 249 | username: username, [INFO] [stderr] 250 | is_billed: is_billed, [INFO] [stderr] 251 | is_highlighted: is_highlighted, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustix_backend.rs:259:9 [INFO] [stderr] | [INFO] [stderr] 259 | return self.persistencer.test_store_apply(event, &mut self.datastore); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.persistencer.test_store_apply(event, &mut self.datastore)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustix_backend.rs:289:33 [INFO] [stderr] | [INFO] [stderr] 289 | return Some(self.datastore.version); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(self.datastore.version)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustix_backend.rs:293:33 [INFO] [stderr] | [INFO] [stderr] 293 | return None [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustix_backend.rs:299:25 [INFO] [stderr] | [INFO] [stderr] 299 | return None [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustix_backend.rs:306:17 [INFO] [stderr] | [INFO] [stderr] 306 | return None [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustix_backend.rs:341:9 [INFO] [stderr] | [INFO] [stderr] 341 | return Some(version); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(version)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustix_backend.rs:370:9 [INFO] [stderr] | [INFO] [stderr] 370 | / return RustixBackend { [INFO] [stderr] 371 | | datastore: datastore::Datastore::default(), [INFO] [stderr] 372 | | persistencer: persistencer::FilePersister::new(config).unwrap(), [INFO] [stderr] 373 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 370 | RustixBackend { [INFO] [stderr] 371 | datastore: datastore::Datastore::default(), [INFO] [stderr] 372 | persistencer: persistencer::FilePersister::new(config).unwrap(), [INFO] [stderr] 373 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rustix_backend.rs:503:43 [INFO] [stderr] | [INFO] [stderr] 503 | assert_eq!(backend.purchase(0, 0, 12345678i64), false); [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `12_345_678i64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rustix_backend.rs:510:43 [INFO] [stderr] | [INFO] [stderr] 510 | assert_eq!(backend.purchase(1, 0, 12345888i64), false); [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `12_345_888i64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rustix_backend.rs:516:32 [INFO] [stderr] | [INFO] [stderr] 516 | backend.purchase(1, 0, 12347878i64); [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `12_347_878i64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rustix_backend.rs:607:37 [INFO] [stderr] | [INFO] [stderr] 607 | let low_mid_time_point = 12345680i64; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `12_345_680i64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rustix_backend.rs:608:37 [INFO] [stderr] | [INFO] [stderr] 608 | let mid_time_point = 12345880i64; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `12_345_880i64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rustix_backend.rs:609:37 [INFO] [stderr] | [INFO] [stderr] 609 | let high_mid_time_poin = 12345890i64; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `12_345_890i64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rustix_backend.rs:610:37 [INFO] [stderr] | [INFO] [stderr] 610 | let highest_time_point = 12447878i64; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `12_447_878i64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Creating a reference that is immediately dereferenced. [INFO] [stderr] --> src/rustix_backend.rs:686:28 [INFO] [stderr] | [INFO] [stderr] 686 | let user_key = (0, (&backend).datastore.users.get(&0).unwrap().username.to_string()); [INFO] [stderr] | ^^^^^^^^^^ help: try this: `backend.datastore` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ref_in_deref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ref_in_deref [INFO] [stderr] [INFO] [stderr] warning: Creating a reference that is immediately dereferenced. [INFO] [stderr] --> src/rustix_backend.rs:687:30 [INFO] [stderr] | [INFO] [stderr] 687 | let user_1_key = (1, (&backend).datastore.users.get(&1).unwrap().username.to_string()); [INFO] [stderr] | ^^^^^^^^^^ help: try this: `backend.datastore` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ref_in_deref [INFO] [stderr] [INFO] [stderr] warning: Creating a reference that is immediately dereferenced. [INFO] [stderr] --> src/rustix_backend.rs:688:30 [INFO] [stderr] | [INFO] [stderr] 688 | let item_0_key = (0, (&backend).datastore.items.get(&0).unwrap().name.to_string()); [INFO] [stderr] | ^^^^^^^^^^ help: try this: `backend.datastore` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ref_in_deref [INFO] [stderr] [INFO] [stderr] warning: Creating a reference that is immediately dereferenced. [INFO] [stderr] --> src/rustix_backend.rs:689:30 [INFO] [stderr] | [INFO] [stderr] 689 | let item_1_key = (1, (&backend).datastore.items.get(&1).unwrap().name.to_string()); [INFO] [stderr] | ^^^^^^^^^^ help: try this: `backend.datastore` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ref_in_deref [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/persistencer.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | return RustixError::Init(e); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `RustixError::Init(e)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/persistencer.rs:59:9 [INFO] [stderr] | [INFO] [stderr] 59 | return RustixError::SerialJson(e); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `RustixError::SerialJson(e)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/persistencer.rs:65:9 [INFO] [stderr] | [INFO] [stderr] 65 | return RustixError::SerialUTF8(e); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `RustixError::SerialUTF8(e)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/persistencer.rs:71:9 [INFO] [stderr] | [INFO] [stderr] 71 | return RustixError::DB(e); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `RustixError::DB(e)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/persistencer.rs:120:9 [INFO] [stderr] | [INFO] [stderr] 120 | return Ok(fp); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(fp)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/persistencer.rs:134:5 [INFO] [stderr] | [INFO] [stderr] 134 | return [b1, b2, b3, b4]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `[b1, b2, b3, b4]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/persistencer.rs:150:9 [INFO] [stderr] | [INFO] [stderr] 150 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/persistencer.rs:164:21 [INFO] [stderr] | [INFO] [stderr] 164 | return false [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/persistencer.rs:169:21 [INFO] [stderr] | [INFO] [stderr] 169 | return event.apply(datastore, &self.config); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `event.apply(datastore, &self.config)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/persistencer.rs:173:13 [INFO] [stderr] | [INFO] [stderr] 173 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/persistencer.rs:216:9 [INFO] [stderr] | [INFO] [stderr] 216 | return Ok(datastore.version); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(datastore.version)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/persistencer.rs:224:5 [INFO] [stderr] | [INFO] [stderr] 224 | return wtr; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `wtr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/persistencer.rs:229:5 [INFO] [stderr] | [INFO] [stderr] 229 | return rdr.read_u64::().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `rdr.read_u64::().unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustix_event_shop.rs:136:5 [INFO] [stderr] | [INFO] [stderr] 136 | return r; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `r` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustix_event_shop.rs:141:9 [INFO] [stderr] | [INFO] [stderr] 141 | / return match self { [INFO] [stderr] 142 | | &BLEvents::CreateItem { [INFO] [stderr] 143 | | ref itemname, [INFO] [stderr] 144 | | price_cents, [INFO] [stderr] ... | [INFO] [stderr] 231 | | &BLEvents::SetPriceForSpecial { unique_id, price } => store.get_purchase(unique_id).is_some(), [INFO] [stderr] 232 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 141 | match self { [INFO] [stderr] 142 | &BLEvents::CreateItem { [INFO] [stderr] 143 | ref itemname, [INFO] [stderr] 144 | price_cents, [INFO] [stderr] 145 | ref category, [INFO] [stderr] 146 | } => true, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustix_event_shop.rs:236:9 [INFO] [stderr] | [INFO] [stderr] 236 | / return match self { [INFO] [stderr] 237 | | &BLEvents::CreateItem { [INFO] [stderr] 238 | | ref itemname, [INFO] [stderr] 239 | | ref price_cents, [INFO] [stderr] ... | [INFO] [stderr] 1196 | | }, [INFO] [stderr] 1197 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 236 | match self { [INFO] [stderr] 237 | &BLEvents::CreateItem { [INFO] [stderr] 238 | ref itemname, [INFO] [stderr] 239 | ref price_cents, [INFO] [stderr] 240 | ref category, [INFO] [stderr] 241 | } => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rustix_event_shop.rs:1245:28 [INFO] [stderr] | [INFO] [stderr] 1245 | timestamp: 123456789i64, [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `123_456_789i64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rustix_event_shop.rs:1275:28 [INFO] [stderr] | [INFO] [stderr] 1275 | timestamp: 123456789i64, [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `123_456_789i64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | / return StaticConfig { [INFO] [stderr] 15 | | users_per_page: 40, [INFO] [stderr] 16 | | users_in_top_users: 40, [INFO] [stderr] 17 | | top_drinks_per_user: 4, [INFO] [stderr] 18 | | use_persistence: true, [INFO] [stderr] 19 | | persistence_file_path: filepath.to_string(), [INFO] [stderr] 20 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 14 | StaticConfig { [INFO] [stderr] 15 | users_per_page: 40, [INFO] [stderr] 16 | users_in_top_users: 40, [INFO] [stderr] 17 | top_drinks_per_user: 4, [INFO] [stderr] 18 | use_persistence: true, [INFO] [stderr] 19 | persistence_file_path: filepath.to_string(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | / return StaticConfig { [INFO] [stderr] 27 | | users_per_page: 20, [INFO] [stderr] 28 | | users_in_top_users: 20, [INFO] [stderr] 29 | | top_drinks_per_user: 4, [INFO] [stderr] 30 | | use_persistence: false, [INFO] [stderr] 31 | | persistence_file_path: String::new(), [INFO] [stderr] 32 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 26 | StaticConfig { [INFO] [stderr] 27 | users_per_page: 20, [INFO] [stderr] 28 | users_in_top_users: 20, [INFO] [stderr] 29 | top_drinks_per_user: 4, [INFO] [stderr] 30 | use_persistence: false, [INFO] [stderr] 31 | persistence_file_path: String::new(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:50:5 [INFO] [stderr] | [INFO] [stderr] 50 | return build_transient_backend_with(20, 20); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `build_transient_backend_with(20, 20)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:62:5 [INFO] [stderr] | [INFO] [stderr] 62 | / return rustix_backend::RustixBackend { [INFO] [stderr] 63 | | datastore: datastore::Datastore::default(), [INFO] [stderr] 64 | | persistencer: persistencer::FilePersister::new(config).unwrap(), [INFO] [stderr] 65 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 62 | rustix_backend::RustixBackend { [INFO] [stderr] 63 | datastore: datastore::Datastore::default(), [INFO] [stderr] 64 | persistencer: persistencer::FilePersister::new(config).unwrap(), [INFO] [stderr] 65 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:71:5 [INFO] [stderr] | [INFO] [stderr] 71 | / return rustix_backend::RustixBackend { [INFO] [stderr] 72 | | datastore: datastore::Datastore::default(), [INFO] [stderr] 73 | | persistencer: persistencer::FilePersister::new(config).unwrap(), [INFO] [stderr] 74 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 71 | rustix_backend::RustixBackend { [INFO] [stderr] 72 | datastore: datastore::Datastore::default(), [INFO] [stderr] 73 | persistencer: persistencer::FilePersister::new(config).unwrap(), [INFO] [stderr] 74 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:69:9 [INFO] [stderr] | [INFO] [stderr] 69 | let mut config = StaticConfig::default_persistence(dir.to_str().unwrap()); [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/rustix_backend.rs:319:13 [INFO] [stderr] | [INFO] [stderr] 319 | let mut file_raw= File::open(filepath); [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/persistencer.rs:115:13 [INFO] [stderr] | [INFO] [stderr] 115 | let mut fp = FilePersister { [INFO] [stderr] | ----^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/left_threaded_avl_tree.rs:73:13 [INFO] [stderr] | [INFO] [stderr] 73 | self.scores[i] = self.scores[i] + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.scores[i] += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/datastore.rs:29:40 [INFO] [stderr] | [INFO] [stderr] 29 | fn get_mut_purchase(&mut self, id: &u64) -> Option<&mut Purchase>; [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/datastore.rs:142:33 [INFO] [stderr] | [INFO] [stderr] 142 | let v : Vec = self.purchases.iter() [INFO] [stderr] | _________________________________^ [INFO] [stderr] 143 | | .filter(|p: &&Purchase| { [INFO] [stderr] 144 | | p.get_user_id().eq(&user_id) && p.get_timestamp() >= &millis_start_inclusive && p.get_timestamp() < &millis_end_exclusive [INFO] [stderr] 145 | | }) [INFO] [stderr] 146 | | .map(|p: &Purchase| p.clone()) [INFO] [stderr] | |__________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 142 | let v : Vec = self.purchases.iter() [INFO] [stderr] 143 | .filter(|p: &&Purchase| { [INFO] [stderr] 144 | p.get_user_id().eq(&user_id) && p.get_timestamp() >= &millis_start_inclusive && p.get_timestamp() < &millis_end_exclusive [INFO] [stderr] 145 | }).cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/datastore.rs:144:45 [INFO] [stderr] | [INFO] [stderr] 144 | p.get_user_id().eq(&user_id) && p.get_timestamp() >= &millis_start_inclusive && p.get_timestamp() < &millis_end_exclusive [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^----------------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `millis_start_inclusive` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/datastore.rs:144:93 [INFO] [stderr] | [INFO] [stderr] 144 | p.get_user_id().eq(&user_id) && p.get_timestamp() >= &millis_start_inclusive && p.get_timestamp() < &millis_end_exclusive [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^--------------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `millis_end_exclusive` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/datastore.rs:174:29 [INFO] [stderr] | [INFO] [stderr] 174 | let v : Vec = self.bills.iter() [INFO] [stderr] | _____________________________^ [INFO] [stderr] 175 | | .filter(|b: &&Bill| { [INFO] [stderr] 176 | | matches_usergroup(&user_id, &b.users) && !(b.timestamp_to < millis_start_inclusive || b.timestamp_from > millis_end_exclusive) [INFO] [stderr] 177 | | }) [INFO] [stderr] 178 | | .map(|p: &Bill| p.clone()) [INFO] [stderr] | |______________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 174 | let v : Vec = self.bills.iter() [INFO] [stderr] 175 | .filter(|b: &&Bill| { [INFO] [stderr] 176 | matches_usergroup(&user_id, &b.users) && !(b.timestamp_to < millis_start_inclusive || b.timestamp_from > millis_end_exclusive) [INFO] [stderr] 177 | }).cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get_mut().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/datastore.rs:186:34 [INFO] [stderr] | [INFO] [stderr] 186 | return idx.map(move |id| self.purchases.get_mut(id).unwrap()).ok(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.purchases[id]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/datastore.rs:252:35 [INFO] [stderr] | [INFO] [stderr] 252 | let usr = self.users.get(&uid).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.users[&uid]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/datastore.rs:256:85 [INFO] [stderr] | [INFO] [stderr] 256 | } else if bill.users_that_will_not_be_billed.contains(&uid) { [INFO] [stderr] | _____________________________________________________________________________________^ [INFO] [stderr] 257 | | //else if user is in internal exclusion list of bill, add to internally excluded list [INFO] [stderr] 258 | | } else if usr.external_user_id.is_none() { [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/datastore.rs:254:43 [INFO] [stderr] | [INFO] [stderr] 254 | if !usr.is_billed { [INFO] [stderr] | ___________________________________________^ [INFO] [stderr] 255 | | //if user isn't billed per field, add to externally excluded list [INFO] [stderr] 256 | | } else if bill.users_that_will_not_be_billed.contains(&uid) { [INFO] [stderr] | |_________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/datastore.rs:308:13 [INFO] [stderr] | [INFO] [stderr] 308 | / match *freeby { [INFO] [stderr] 309 | | Freeby::Transfer { .. } => { [INFO] [stderr] 310 | | return Some(idx); [INFO] [stderr] 311 | | }, [INFO] [stderr] 312 | | _ => (), [INFO] [stderr] 313 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 308 | if let Freeby::Transfer { .. } = *freeby { [INFO] [stderr] 309 | return Some(idx); [INFO] [stderr] 310 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/datastore.rs:319:36 [INFO] [stderr] | [INFO] [stderr] 319 | let cat : Option = self.items.get(&item).unwrap().clone().category; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.items[&item]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/datastore.rs:321:13 [INFO] [stderr] | [INFO] [stderr] 321 | / match *freeby { [INFO] [stderr] 322 | | Freeby::Classic { ref allowed_categories, [INFO] [stderr] 323 | | ref allowed_drinks, .. } => { [INFO] [stderr] 324 | | let cat = cat.clone(); [INFO] [stderr] ... | [INFO] [stderr] 340 | | _ => (), [INFO] [stderr] 341 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 321 | if let Freeby::Classic { ref allowed_categories, [INFO] [stderr] 322 | ref allowed_drinks, .. } = *freeby { [INFO] [stderr] 323 | let cat = cat.clone(); [INFO] [stderr] 324 | if allowed_drinks.contains(&item) { [INFO] [stderr] 325 | return Some(idx); [INFO] [stderr] 326 | } else { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/datastore.rs:328:25 [INFO] [stderr] | [INFO] [stderr] 328 | / match cat { [INFO] [stderr] 329 | | Some(c) => { [INFO] [stderr] 330 | | if allowed_categories.contains(&c) { [INFO] [stderr] 331 | | return Some(idx); [INFO] [stderr] ... | [INFO] [stderr] 336 | | None => (), [INFO] [stderr] 337 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 328 | if let Some(c) = cat { [INFO] [stderr] 329 | if allowed_categories.contains(&c) { [INFO] [stderr] 330 | return Some(idx); [INFO] [stderr] 331 | } else { [INFO] [stderr] 332 | () [INFO] [stderr] 333 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/datastore.rs:367:34 [INFO] [stderr] | [INFO] [stderr] 367 | let found_open = self.open_freebies.get(&recipient_id).unwrap().binary_search_by(|f| f.get_id().cmp(&freeby_id)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.open_freebies[&recipient_id]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/datastore.rs:369:28 [INFO] [stderr] | [INFO] [stderr] 369 | return self.open_freebies.get(&recipient_id).unwrap().get(found_open.unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.open_freebies[&recipient_id]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/datastore.rs:381:35 [INFO] [stderr] | [INFO] [stderr] 381 | pub fn matches_usergroup(user_id: &Option, usergroup: &UserGroup) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `Option` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/datastore.rs:399:29 [INFO] [stderr] | [INFO] [stderr] 399 | fn matches_userset(user_id: &Option, usergroup: &HashSet) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `Option` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/datastore.rs:453:24 [INFO] [stderr] | [INFO] [stderr] 453 | Ok(idx) => self.purchases.get(idx).map(|p|p.clone()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.purchases.get(idx).cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:69:9 [INFO] [stderr] | [INFO] [stderr] 69 | let mut config = StaticConfig::default_persistence(dir.to_str().unwrap()); [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/datastore.rs:1150:9 [INFO] [stderr] | [INFO] [stderr] 1150 | / match self { [INFO] [stderr] 1151 | | &Purchase::SpecialPurchase{ [INFO] [stderr] 1152 | | ref unique_id, [INFO] [stderr] 1153 | | ref timestamp_epoch_millis, [INFO] [stderr] ... | [INFO] [stderr] 1176 | | }, [INFO] [stderr] 1177 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 1150 | match *self { [INFO] [stderr] 1151 | Purchase::SpecialPurchase{ [INFO] [stderr] 1152 | ref unique_id, [INFO] [stderr] 1153 | ref timestamp_epoch_millis, [INFO] [stderr] 1154 | ref special_name, [INFO] [stderr] 1155 | ref specialcost, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/datastore.rs:1181:9 [INFO] [stderr] | [INFO] [stderr] 1181 | / match self { [INFO] [stderr] 1182 | | &Purchase::SpecialPurchase { [INFO] [stderr] 1183 | | ref unique_id, [INFO] [stderr] 1184 | | ref timestamp_epoch_millis, [INFO] [stderr] ... | [INFO] [stderr] 1189 | | _ => panic!("get_special_set_price called on non-special purchase"), [INFO] [stderr] 1190 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 1181 | match *self { [INFO] [stderr] 1182 | Purchase::SpecialPurchase { [INFO] [stderr] 1183 | ref unique_id, [INFO] [stderr] 1184 | ref timestamp_epoch_millis, [INFO] [stderr] 1185 | ref special_name, [INFO] [stderr] 1186 | ref specialcost, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/datastore.rs:1194:9 [INFO] [stderr] | [INFO] [stderr] 1194 | / match self { [INFO] [stderr] 1195 | | &Purchase::SpecialPurchase{ [INFO] [stderr] 1196 | | ref unique_id, [INFO] [stderr] 1197 | | ref timestamp_epoch_millis, [INFO] [stderr] ... | [INFO] [stderr] 1220 | | } [INFO] [stderr] 1221 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 1194 | match *self { [INFO] [stderr] 1195 | Purchase::SpecialPurchase{ [INFO] [stderr] 1196 | ref unique_id, [INFO] [stderr] 1197 | ref timestamp_epoch_millis, [INFO] [stderr] 1198 | ref special_name, [INFO] [stderr] 1199 | ref specialcost, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/datastore.rs:1225:9 [INFO] [stderr] | [INFO] [stderr] 1225 | / match self { [INFO] [stderr] 1226 | | &Purchase::SpecialPurchase{ [INFO] [stderr] 1227 | | ref unique_id, [INFO] [stderr] 1228 | | ref timestamp_epoch_millis, [INFO] [stderr] ... | [INFO] [stderr] 1251 | | } [INFO] [stderr] 1252 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 1225 | match *self { [INFO] [stderr] 1226 | Purchase::SpecialPurchase{ [INFO] [stderr] 1227 | ref unique_id, [INFO] [stderr] 1228 | ref timestamp_epoch_millis, [INFO] [stderr] 1229 | ref special_name, [INFO] [stderr] 1230 | ref specialcost, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/datastore.rs:1255:9 [INFO] [stderr] | [INFO] [stderr] 1255 | / match self { [INFO] [stderr] 1256 | | &Purchase::SpecialPurchase{ [INFO] [stderr] 1257 | | ref unique_id, [INFO] [stderr] 1258 | | ref timestamp_epoch_millis, [INFO] [stderr] ... | [INFO] [stderr] 1281 | | } [INFO] [stderr] 1282 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 1255 | match *self { [INFO] [stderr] 1256 | Purchase::SpecialPurchase{ [INFO] [stderr] 1257 | ref unique_id, [INFO] [stderr] 1258 | ref timestamp_epoch_millis, [INFO] [stderr] 1259 | ref special_name, [INFO] [stderr] 1260 | ref specialcost, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/datastore.rs:1286:9 [INFO] [stderr] | [INFO] [stderr] 1286 | / match self { [INFO] [stderr] 1287 | | &Purchase::SpecialPurchase{ [INFO] [stderr] 1288 | | ref unique_id, [INFO] [stderr] 1289 | | ref timestamp_epoch_millis, [INFO] [stderr] ... | [INFO] [stderr] 1312 | | } [INFO] [stderr] 1313 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 1286 | match *self { [INFO] [stderr] 1287 | Purchase::SpecialPurchase{ [INFO] [stderr] 1288 | ref unique_id, [INFO] [stderr] 1289 | ref timestamp_epoch_millis, [INFO] [stderr] 1290 | ref special_name, [INFO] [stderr] 1291 | ref specialcost, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/datastore.rs:1317:9 [INFO] [stderr] | [INFO] [stderr] 1317 | / match self { [INFO] [stderr] 1318 | | &Purchase::SpecialPurchase{ [INFO] [stderr] 1319 | | ref unique_id, [INFO] [stderr] 1320 | | ref timestamp_epoch_millis, [INFO] [stderr] ... | [INFO] [stderr] 1343 | | } [INFO] [stderr] 1344 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 1317 | match *self { [INFO] [stderr] 1318 | Purchase::SpecialPurchase{ [INFO] [stderr] 1319 | ref unique_id, [INFO] [stderr] 1320 | ref timestamp_epoch_millis, [INFO] [stderr] 1321 | ref special_name, [INFO] [stderr] 1322 | ref specialcost, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/rustix_backend.rs:69:5 [INFO] [stderr] | [INFO] [stderr] 69 | / fn create_free_count(&mut self, allowed_categories : Vec, [INFO] [stderr] 70 | | allowed_drinks : Vec, [INFO] [stderr] 71 | | allowed_number_total : u16, [INFO] [stderr] 72 | | text_message : String, [INFO] [stderr] 73 | | created_timestamp : i64, [INFO] [stderr] 74 | | donor : u32, [INFO] [stderr] 75 | | recipient : u32) -> bool; [INFO] [stderr] | |__________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/persistencer.rs:139:9 [INFO] [stderr] | [INFO] [stderr] 139 | / match self.lmdb { [INFO] [stderr] 140 | | Some(ref lmdb) => { [INFO] [stderr] 141 | | let mut rw_transaction: RwTransaction = try!(lmdb.db_env.begin_rw_txn()); [INFO] [stderr] 142 | | let tx_flags: WriteFlags = WriteFlags::empty(); [INFO] [stderr] ... | [INFO] [stderr] 148 | | None => (), [INFO] [stderr] 149 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 139 | if let Some(ref lmdb) = self.lmdb { [INFO] [stderr] 140 | let mut rw_transaction: RwTransaction = try!(lmdb.db_env.begin_rw_txn()); [INFO] [stderr] 141 | let tx_flags: WriteFlags = WriteFlags::empty(); [INFO] [stderr] 142 | let key = id_to_key(id);// transform_u32_to_array_of_u8(id); [INFO] [stderr] 143 | let data = try!(serde_json::to_string(event)); [INFO] [stderr] 144 | let result = rw_transaction.put(lmdb.db, &key, &data, tx_flags); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/persistencer.rs:182:9 [INFO] [stderr] | [INFO] [stderr] 182 | / match self.lmdb { [INFO] [stderr] 183 | | Some(ref lmdb) => { [INFO] [stderr] 184 | | //build and use iterator if database is non-empty [INFO] [stderr] 185 | | let count = lmdb.db_env.stat().unwrap().entries() as u64; [INFO] [stderr] ... | [INFO] [stderr] 213 | | None => (), [INFO] [stderr] 214 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 182 | if let Some(ref lmdb) = self.lmdb { [INFO] [stderr] 183 | //build and use iterator if database is non-empty [INFO] [stderr] 184 | let count = lmdb.db_env.stat().unwrap().entries() as u64; [INFO] [stderr] 185 | if count > counter { [INFO] [stderr] 186 | let tx = try!(lmdb.db_env.begin_ro_txn()); [INFO] [stderr] 187 | { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/rustix_backend.rs:319:13 [INFO] [stderr] | [INFO] [stderr] 319 | let mut file_raw= File::open(filepath); [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 34 [INFO] [stderr] --> src/rustix_event_shop.rs:140:5 [INFO] [stderr] | [INFO] [stderr] 140 | / fn can_be_applied(&self, store: &Datastore) -> bool { [INFO] [stderr] 141 | | return match self { [INFO] [stderr] 142 | | &BLEvents::CreateItem { [INFO] [stderr] 143 | | ref itemname, [INFO] [stderr] ... | [INFO] [stderr] 232 | | }; [INFO] [stderr] 233 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/rustix_event_shop.rs:141:16 [INFO] [stderr] | [INFO] [stderr] 141 | return match self { [INFO] [stderr] | ________________^ [INFO] [stderr] 142 | | &BLEvents::CreateItem { [INFO] [stderr] 143 | | ref itemname, [INFO] [stderr] 144 | | price_cents, [INFO] [stderr] ... | [INFO] [stderr] 231 | | &BLEvents::SetPriceForSpecial { unique_id, price } => store.get_purchase(unique_id).is_some(), [INFO] [stderr] 232 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 141 | return match *self { [INFO] [stderr] 142 | BLEvents::CreateItem { [INFO] [stderr] 143 | ref itemname, [INFO] [stderr] 144 | price_cents, [INFO] [stderr] 145 | ref category, [INFO] [stderr] 146 | } => true, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/rustix_event_shop.rs:182:17 [INFO] [stderr] | [INFO] [stderr] 182 | result = result & x.can_be_applied(store); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `result &= x.can_be_applied(store)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_event_shop.rs:189:35 [INFO] [stderr] | [INFO] [stderr] 189 | let item: &Item = store.items.get(&item_id).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&store.items[&item_id]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 75 [INFO] [stderr] --> src/rustix_event_shop.rs:235:5 [INFO] [stderr] | [INFO] [stderr] 235 | / fn apply(&self, store: &mut Datastore, config: &StaticConfig) -> bool { [INFO] [stderr] 236 | | return match self { [INFO] [stderr] 237 | | &BLEvents::CreateItem { [INFO] [stderr] 238 | | ref itemname, [INFO] [stderr] ... | [INFO] [stderr] 1197 | | }; [INFO] [stderr] 1198 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/rustix_event_shop.rs:236:16 [INFO] [stderr] | [INFO] [stderr] 236 | return match self { [INFO] [stderr] | ________________^ [INFO] [stderr] 237 | | &BLEvents::CreateItem { [INFO] [stderr] 238 | | ref itemname, [INFO] [stderr] 239 | | ref price_cents, [INFO] [stderr] ... | [INFO] [stderr] 1196 | | }, [INFO] [stderr] 1197 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 236 | return match *self { [INFO] [stderr] 237 | BLEvents::CreateItem { [INFO] [stderr] 238 | ref itemname, [INFO] [stderr] 239 | ref price_cents, [INFO] [stderr] 240 | ref category, [INFO] [stderr] 241 | } => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's values [INFO] [stderr] --> src/rustix_event_shop.rs:258:35 [INFO] [stderr] | [INFO] [stderr] 258 | for (_, value) in &mut store.drink_scores_per_user { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::for_kv_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 258 | for value in store.drink_scores_per_user.values_mut() { [INFO] [stderr] | ^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's values [INFO] [stderr] --> src/rustix_event_shop.rs:267:35 [INFO] [stderr] | [INFO] [stderr] 267 | for (_, v) in &store.items { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 267 | for v in store.items.values() { [INFO] [stderr] | ^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's keys [INFO] [stderr] --> src/rustix_event_shop.rs:296:34 [INFO] [stderr] | [INFO] [stderr] 296 | for (_key, _) in &store.items { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 296 | for _key in store.items.keys() { [INFO] [stderr] | ^^^^ ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's values [INFO] [stderr] --> src/rustix_event_shop.rs:315:35 [INFO] [stderr] | [INFO] [stderr] 315 | for (_, v) in &store.users { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 315 | for v in store.users.values() { [INFO] [stderr] | ^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's values [INFO] [stderr] --> src/rustix_event_shop.rs:389:50 [INFO] [stderr] | [INFO] [stderr] 389 | for (_key, mut value) in &mut store.drink_scores_per_user { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 389 | for mut value in store.drink_scores_per_user.values_mut() { [INFO] [stderr] | ^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's values [INFO] [stderr] --> src/rustix_event_shop.rs:411:35 [INFO] [stderr] | [INFO] [stderr] 411 | for (_, v) in &store.items { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 411 | for v in store.items.values() { [INFO] [stderr] | ^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/rustix_event_shop.rs:425:17 [INFO] [stderr] | [INFO] [stderr] 425 | / match store.users.get(&user_id) { [INFO] [stderr] 426 | | Some(x) => { [INFO] [stderr] 427 | | if x.highlight_in_ui { [INFO] [stderr] 428 | | let _ = store.highlighted_users.remove(&user_id); [INFO] [stderr] ... | [INFO] [stderr] 431 | | None => (), [INFO] [stderr] 432 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 425 | if let Some(x) = store.users.get(&user_id) { [INFO] [stderr] 426 | if x.highlight_in_ui { [INFO] [stderr] 427 | let _ = store.highlighted_users.remove(&user_id); [INFO] [stderr] 428 | } [INFO] [stderr] 429 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's values [INFO] [stderr] --> src/rustix_event_shop.rs:451:35 [INFO] [stderr] | [INFO] [stderr] 451 | for (_, v) in &store.users { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 451 | for v in store.users.values() { [INFO] [stderr] | ^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_event_shop.rs:526:32 [INFO] [stderr] | [INFO] [stderr] 526 | let username = store.users.get(&user_id).unwrap().username.to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&store.users[&user_id]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_event_shop.rs:527:32 [INFO] [stderr] | [INFO] [stderr] 527 | let itemname = store.items.get(&item_id).unwrap().name.to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&store.items[&item_id]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_event_shop.rs:528:42 [INFO] [stderr] | [INFO] [stderr] 528 | let user_key = (user_id, store.users.get(&user_id).unwrap().username.to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&store.users[&user_id]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_event_shop.rs:529:42 [INFO] [stderr] | [INFO] [stderr] 529 | let item_key = (item_id, store.items.get(&item_id).unwrap().name.to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&store.items[&item_id]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/rustix_event_shop.rs:594:21 [INFO] [stderr] | [INFO] [stderr] 594 | result = result & x.apply(store, config); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `result &= x.apply(store, config)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_event_shop.rs:644:36 [INFO] [stderr] | [INFO] [stderr] 644 | let username = store.users.get(&user_id).unwrap().username.to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&store.users[&user_id]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_event_shop.rs:645:36 [INFO] [stderr] | [INFO] [stderr] 645 | let itemname = store.items.get(&item_id).unwrap().name.to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&store.items[&item_id]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_event_shop.rs:646:46 [INFO] [stderr] | [INFO] [stderr] 646 | let user_key = (user_id, store.users.get(&user_id).unwrap().username.to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&store.users[&user_id]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_event_shop.rs:647:46 [INFO] [stderr] | [INFO] [stderr] 647 | let item_key = (item_id, store.items.get(&item_id).unwrap().name.to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&store.items[&item_id]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_event_shop.rs:838:74 [INFO] [stderr] | [INFO] [stderr] 838 | let item_key1 : (u32, String) = (*element.get_item_id(), store.items.get(&element.get_item_id()).unwrap().name.to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&store.items[&element.get_item_id()]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_event_shop.rs:839:74 [INFO] [stderr] | [INFO] [stderr] 839 | let item_key2 : (u32, String) = (*element.get_item_id(), store.items.get(&element.get_item_id()).unwrap().name.to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&store.items[&element.get_item_id()]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_event_shop.rs:840:73 [INFO] [stderr] | [INFO] [stderr] 840 | let user_key : (u32, String) = (*element.get_user_id(), store.users.get(&element.get_user_id()).unwrap().username.to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&store.users[&element.get_user_id()]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_event_shop.rs:843:32 [INFO] [stderr] | [INFO] [stderr] 843 | let oldcost = *store [INFO] [stderr] | ________________________________^ [INFO] [stderr] 844 | | .balance_cost_per_user [INFO] [stderr] 845 | | .get(&user_key) [INFO] [stderr] 846 | | .unwrap() [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 843 | let oldcost = *&store [INFO] [stderr] 844 | .balance_cost_per_user[&user_key] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_event_shop.rs:849:33 [INFO] [stderr] | [INFO] [stderr] 849 | let oldcount = *store [INFO] [stderr] | _________________________________^ [INFO] [stderr] 850 | | .balance_count_per_user [INFO] [stderr] 851 | | .get(&user_key) [INFO] [stderr] 852 | | .unwrap() [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 849 | let oldcount = *&store [INFO] [stderr] 850 | .balance_count_per_user[&user_key] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get_mut().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_event_shop.rs:878:21 [INFO] [stderr] | [INFO] [stderr] 878 | store.bills.get_mut(bill_idx).unwrap().bill_state = BillState::Finalized; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `store.bills[bill_idx]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get_mut().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_event_shop.rs:902:59 [INFO] [stderr] | [INFO] [stderr] 902 | let mut bill: &mut Bill = store.bills.get_mut(bill_idx).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `store.bills[bill_idx]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/rustix_event_shop.rs:903:33 [INFO] [stderr] | [INFO] [stderr] 903 | / if !bill.finalized_data.all_users.contains_key(&consumer_id) { [INFO] [stderr] 904 | | bill.finalized_data.all_users.insert(consumer_id, user.clone()); [INFO] [stderr] 905 | | bill.finalized_data.user_consumption.insert(consumer_id, BillUserInstance { [INFO] [stderr] 906 | | user_id: consumer_id, [INFO] [stderr] 907 | | per_day: HashMap::new(), [INFO] [stderr] 908 | | }); [INFO] [stderr] 909 | | } [INFO] [stderr] | |_________________________________^ help: consider using: `bill.finalized_data.all_users.entry(consumer_id)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/rustix_event_shop.rs:903:33 [INFO] [stderr] | [INFO] [stderr] 903 | / if !bill.finalized_data.all_users.contains_key(&consumer_id) { [INFO] [stderr] 904 | | bill.finalized_data.all_users.insert(consumer_id, user.clone()); [INFO] [stderr] 905 | | bill.finalized_data.user_consumption.insert(consumer_id, BillUserInstance { [INFO] [stderr] 906 | | user_id: consumer_id, [INFO] [stderr] 907 | | per_day: HashMap::new(), [INFO] [stderr] 908 | | }); [INFO] [stderr] 909 | | } [INFO] [stderr] | |_________________________________^ help: consider using: `bill.finalized_data.all_users.entry(consumer_id)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/rustix_event_shop.rs:911:33 [INFO] [stderr] | [INFO] [stderr] 911 | / if !bill.finalized_data.user_consumption.get_mut(&consumer_id).unwrap().per_day.contains_key(&day_idx) { [INFO] [stderr] 912 | | bill.finalized_data.user_consumption.get_mut(&consumer_id).unwrap().per_day.insert(day_idx, BillUserDayInstance { [INFO] [stderr] 913 | | personally_consumed: HashMap::new(), [INFO] [stderr] 914 | | specials_consumed: Vec::new(), [INFO] [stderr] ... | [INFO] [stderr] 917 | | }); [INFO] [stderr] 918 | | } [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] help: consider using [INFO] [stderr] | [INFO] [stderr] 911 | bill.finalized_data.user_consumption.get_mut(&consumer_id).unwrap().per_day.entry(day_idx).or_insert(BillUserDayInstance { [INFO] [stderr] 912 | personally_consumed: HashMap::new(), [INFO] [stderr] 913 | specials_consumed: Vec::new(), [INFO] [stderr] 914 | ffa_giveouts: HashMap::new(), [INFO] [stderr] 915 | giveouts_to_user_id: HashMap::new(), [INFO] [stderr] 916 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_event_shop.rs:932:50 [INFO] [stderr] | [INFO] [stderr] 932 | let item: Item = store.items.get(&item_id).unwrap().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&store.items[&item_id]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get_mut().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_event_shop.rs:937:59 [INFO] [stderr] | [INFO] [stderr] 937 | let mut bill: &mut Bill = store.bills.get_mut(bill_idx).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `store.bills[bill_idx]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/rustix_event_shop.rs:938:33 [INFO] [stderr] | [INFO] [stderr] 938 | / if !bill.finalized_data.all_users.contains_key(&consumer_id) { [INFO] [stderr] 939 | | bill.finalized_data.all_users.insert(consumer_id, user.clone()); [INFO] [stderr] 940 | | bill.finalized_data.user_consumption.insert(consumer_id, BillUserInstance { [INFO] [stderr] 941 | | user_id: consumer_id, [INFO] [stderr] 942 | | per_day: HashMap::new(), [INFO] [stderr] 943 | | }); [INFO] [stderr] 944 | | } [INFO] [stderr] | |_________________________________^ help: consider using: `bill.finalized_data.all_users.entry(consumer_id)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/rustix_event_shop.rs:946:33 [INFO] [stderr] | [INFO] [stderr] 946 | / if !bill.finalized_data.all_items.contains_key(&item_id) { [INFO] [stderr] 947 | | bill.finalized_data.all_items.insert(item_id, item.clone()); [INFO] [stderr] 948 | | } [INFO] [stderr] | |_________________________________^ help: consider using: `bill.finalized_data.all_items.entry(item_id).or_insert(item.clone())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_event_shop.rs:954:62 [INFO] [stderr] | [INFO] [stderr] 954 | let old_count: u16 = store.open_freebies.get(&consumer_id).unwrap().get(cidx).unwrap().left(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&store.open_freebies[&consumer_id]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_event_shop.rs:955:61 [INFO] [stderr] | [INFO] [stderr] 955 | let donor_id: u32 = store.open_freebies.get(&consumer_id).unwrap().get(cidx).unwrap().get_donor(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&store.open_freebies[&consumer_id]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_event_shop.rs:956:59 [INFO] [stderr] | [INFO] [stderr] 956 | let donor: User = store.users.get(&donor_id).unwrap().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&store.users[&donor_id]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/rustix_event_shop.rs:960:45 [INFO] [stderr] | [INFO] [stderr] 960 | / if !bill.finalized_data.all_users.contains_key(&donor_id) { [INFO] [stderr] 961 | | bill.finalized_data.all_users.insert(donor_id, donor.clone()); [INFO] [stderr] 962 | | bill.finalized_data.user_consumption.insert(donor_id, BillUserInstance { [INFO] [stderr] 963 | | user_id: donor_id, [INFO] [stderr] 964 | | per_day: HashMap::new(), [INFO] [stderr] 965 | | }); [INFO] [stderr] 966 | | } [INFO] [stderr] | |_____________________________________________^ help: consider using: `bill.finalized_data.all_users.entry(donor_id)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/rustix_event_shop.rs:968:45 [INFO] [stderr] | [INFO] [stderr] 968 | / if !bill.finalized_data.user_consumption.get_mut(&donor_id).unwrap().per_day.contains_key(&day_idx) { [INFO] [stderr] 969 | | bill.finalized_data.user_consumption.get_mut(&donor_id).unwrap().per_day.insert(day_idx, BillUserDayInstance { [INFO] [stderr] 970 | | personally_consumed: HashMap::new(), [INFO] [stderr] 971 | | specials_consumed: Vec::new(), [INFO] [stderr] ... | [INFO] [stderr] 974 | | }); [INFO] [stderr] 975 | | } [INFO] [stderr] | |_____________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] help: consider using [INFO] [stderr] | [INFO] [stderr] 968 | bill.finalized_data.user_consumption.get_mut(&donor_id).unwrap().per_day.entry(day_idx).or_insert(BillUserDayInstance { [INFO] [stderr] 969 | personally_consumed: HashMap::new(), [INFO] [stderr] 970 | specials_consumed: Vec::new(), [INFO] [stderr] 971 | ffa_giveouts: HashMap::new(), [INFO] [stderr] 972 | giveouts_to_user_id: HashMap::new(), [INFO] [stderr] 973 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/rustix_event_shop.rs:1008:41 [INFO] [stderr] | [INFO] [stderr] 1008 | / match budget_freeby_idx { [INFO] [stderr] 1009 | | Some(bidx) => { [INFO] [stderr] 1010 | | let max_budget : u64 = store.open_freebies.get(&consumer_id).unwrap().get(bidx).unwrap().get_budget_cents_left(); [INFO] [stderr] 1011 | | let donor_id: u32 = store.open_freebies.get(&consumer_id).unwrap().get(bidx).unwrap().get_donor(); [INFO] [stderr] ... | [INFO] [stderr] 1101 | | None => (), [INFO] [stderr] 1102 | | } [INFO] [stderr] | |_________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 1008 | if let Some(bidx) = budget_freeby_idx { [INFO] [stderr] 1009 | let max_budget : u64 = store.open_freebies.get(&consumer_id).unwrap().get(bidx).unwrap().get_budget_cents_left(); [INFO] [stderr] 1010 | let donor_id: u32 = store.open_freebies.get(&consumer_id).unwrap().get(bidx).unwrap().get_donor(); [INFO] [stderr] 1011 | let donor: User = store.users.get(&donor_id).unwrap().clone(); [INFO] [stderr] 1012 | let item_cost : u64 = item.cost_cents as u64; [INFO] [stderr] 1013 | let taken_budget : u64 = cmp::min(max_budget, cmp::max(0u64, item_cost)); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_event_shop.rs:1010:72 [INFO] [stderr] | [INFO] [stderr] 1010 | let max_budget : u64 = store.open_freebies.get(&consumer_id).unwrap().get(bidx).unwrap().get_budget_cents_left(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&store.open_freebies[&consumer_id]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_event_shop.rs:1011:69 [INFO] [stderr] | [INFO] [stderr] 1011 | let donor_id: u32 = store.open_freebies.get(&consumer_id).unwrap().get(bidx).unwrap().get_donor(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&store.open_freebies[&consumer_id]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_event_shop.rs:1012:67 [INFO] [stderr] | [INFO] [stderr] 1012 | let donor: User = store.users.get(&donor_id).unwrap().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&store.users[&donor_id]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/rustix_event_shop.rs:1013:71 [INFO] [stderr] | [INFO] [stderr] 1013 | let item_cost : u64 = item.cost_cents as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(item.cost_cents)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/rustix_event_shop.rs:1026:53 [INFO] [stderr] | [INFO] [stderr] 1026 | / if !bill.finalized_data.user_consumption.contains_key(&consumer_id) { [INFO] [stderr] 1027 | | bill.finalized_data.user_consumption.insert(consumer_id, BillUserInstance { [INFO] [stderr] 1028 | | user_id: consumer_id, [INFO] [stderr] 1029 | | per_day: HashMap::new(), [INFO] [stderr] 1030 | | }); [INFO] [stderr] 1031 | | } [INFO] [stderr] | |_____________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] help: consider using [INFO] [stderr] | [INFO] [stderr] 1026 | bill.finalized_data.user_consumption.entry(consumer_id).or_insert(BillUserInstance { [INFO] [stderr] 1027 | user_id: consumer_id, [INFO] [stderr] 1028 | per_day: HashMap::new(), [INFO] [stderr] 1029 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/rustix_event_shop.rs:1032:53 [INFO] [stderr] | [INFO] [stderr] 1032 | / if !bill.finalized_data.user_consumption.get(&consumer_id).unwrap().per_day.contains_key(&day_idx) { [INFO] [stderr] 1033 | | bill.finalized_data.user_consumption.get_mut(&consumer_id).unwrap().per_day.insert(day_idx, BillUserDayInstance { [INFO] [stderr] 1034 | | personally_consumed: HashMap::new(), [INFO] [stderr] 1035 | | specials_consumed: Vec::new(), [INFO] [stderr] ... | [INFO] [stderr] 1038 | | }); [INFO] [stderr] 1039 | | } [INFO] [stderr] | |_________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] help: consider using [INFO] [stderr] | [INFO] [stderr] 1032 | bill.finalized_data.user_consumption.get(&consumer_id).unwrap().per_day.entry(day_idx).or_insert(BillUserDayInstance { [INFO] [stderr] 1033 | personally_consumed: HashMap::new(), [INFO] [stderr] 1034 | specials_consumed: Vec::new(), [INFO] [stderr] 1035 | ffa_giveouts: HashMap::new(), [INFO] [stderr] 1036 | giveouts_to_user_id: HashMap::new(), [INFO] [stderr] 1037 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_event_shop.rs:1032:57 [INFO] [stderr] | [INFO] [stderr] 1032 | if !bill.finalized_data.user_consumption.get(&consumer_id).unwrap().per_day.contains_key(&day_idx) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&bill.finalized_data.user_consumption[&consumer_id]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/rustix_event_shop.rs:1041:49 [INFO] [stderr] | [INFO] [stderr] 1041 | / if !bill.finalized_data.user_consumption.get(&consumer_id).unwrap().per_day.get(&day_idx).unwrap().giveouts_to_user_id.contains_key(&donor_id) { [INFO] [stderr] 1042 | | bill.finalized_data.user_consumption.get_mut(&consumer_id).unwrap().per_day.get_mut(&day_idx).unwrap().giveouts_to_user_id.insert(donor_id, PaidFor { [INFO] [stderr] 1043 | | recipient_id: donor_id, [INFO] [stderr] 1044 | | count_giveouts_used: HashMap::new(), [INFO] [stderr] ... | [INFO] [stderr] 1047 | | }); [INFO] [stderr] 1048 | | } [INFO] [stderr] | |_________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] help: consider using [INFO] [stderr] | [INFO] [stderr] 1041 | bill.finalized_data.user_consumption.get(&consumer_id).unwrap().per_day.get(&day_idx).unwrap().giveouts_to_user_id.entry(donor_id).or_insert(PaidFor { [INFO] [stderr] 1042 | recipient_id: donor_id, [INFO] [stderr] 1043 | count_giveouts_used: HashMap::new(), [INFO] [stderr] 1044 | budget_given: 0, [INFO] [stderr] 1045 | budget_gotten: 0, [INFO] [stderr] 1046 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_event_shop.rs:1041:53 [INFO] [stderr] | [INFO] [stderr] 1041 | if !bill.finalized_data.user_consumption.get(&consumer_id).unwrap().per_day.get(&day_idx).unwrap().giveouts_to_user_id.contains_key(&donor_id) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&bill.finalized_data.user_consumption.get(&consumer_id).unwrap().per_day[&day_idx]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_event_shop.rs:1041:53 [INFO] [stderr] | [INFO] [stderr] 1041 | if !bill.finalized_data.user_consumption.get(&consumer_id).unwrap().per_day.get(&day_idx).unwrap().giveouts_to_user_id.contains_key(&donor_id) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&bill.finalized_data.user_consumption[&consumer_id]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/rustix_event_shop.rs:1062:53 [INFO] [stderr] | [INFO] [stderr] 1062 | / if !bill.finalized_data.user_consumption.contains_key(&donor_id) { [INFO] [stderr] 1063 | | bill.finalized_data.user_consumption.insert(donor_id, BillUserInstance { [INFO] [stderr] 1064 | | user_id: donor_id, [INFO] [stderr] 1065 | | per_day: HashMap::new(), [INFO] [stderr] 1066 | | }); [INFO] [stderr] 1067 | | } [INFO] [stderr] | |_____________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] help: consider using [INFO] [stderr] | [INFO] [stderr] 1062 | bill.finalized_data.user_consumption.entry(donor_id).or_insert(BillUserInstance { [INFO] [stderr] 1063 | user_id: donor_id, [INFO] [stderr] 1064 | per_day: HashMap::new(), [INFO] [stderr] 1065 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/rustix_event_shop.rs:1068:53 [INFO] [stderr] | [INFO] [stderr] 1068 | / if !bill.finalized_data.user_consumption.get(&donor_id).unwrap().per_day.contains_key(&day_idx) { [INFO] [stderr] 1069 | | bill.finalized_data.user_consumption.get_mut(&donor_id).unwrap().per_day.insert(day_idx, BillUserDayInstance { [INFO] [stderr] 1070 | | personally_consumed: HashMap::new(), [INFO] [stderr] 1071 | | specials_consumed: Vec::new(), [INFO] [stderr] ... | [INFO] [stderr] 1074 | | }); [INFO] [stderr] 1075 | | } [INFO] [stderr] | |_____________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] help: consider using [INFO] [stderr] | [INFO] [stderr] 1068 | bill.finalized_data.user_consumption.get(&donor_id).unwrap().per_day.entry(day_idx).or_insert(BillUserDayInstance { [INFO] [stderr] 1069 | personally_consumed: HashMap::new(), [INFO] [stderr] 1070 | specials_consumed: Vec::new(), [INFO] [stderr] 1071 | ffa_giveouts: HashMap::new(), [INFO] [stderr] 1072 | giveouts_to_user_id: HashMap::new(), [INFO] [stderr] 1073 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_event_shop.rs:1068:57 [INFO] [stderr] | [INFO] [stderr] 1068 | if !bill.finalized_data.user_consumption.get(&donor_id).unwrap().per_day.contains_key(&day_idx) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&bill.finalized_data.user_consumption[&donor_id]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/rustix_event_shop.rs:1077:53 [INFO] [stderr] | [INFO] [stderr] 1077 | / if !bill.finalized_data.user_consumption.get(&donor_id).unwrap().per_day.get(&day_idx).unwrap().giveouts_to_user_id.contains_key(&consumer_id) { [INFO] [stderr] 1078 | | bill.finalized_data.user_consumption.get_mut(&donor_id).unwrap().per_day.get_mut(&day_idx).unwrap().giveouts_to_user_id.insert(consumer_id, PaidFor { [INFO] [stderr] 1079 | | recipient_id: consumer_id, [INFO] [stderr] 1080 | | count_giveouts_used: HashMap::new(), [INFO] [stderr] ... | [INFO] [stderr] 1083 | | }); [INFO] [stderr] 1084 | | } [INFO] [stderr] | |_____________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] help: consider using [INFO] [stderr] | [INFO] [stderr] 1077 | bill.finalized_data.user_consumption.get(&donor_id).unwrap().per_day.get(&day_idx).unwrap().giveouts_to_user_id.entry(consumer_id).or_insert(PaidFor { [INFO] [stderr] 1078 | recipient_id: consumer_id, [INFO] [stderr] 1079 | count_giveouts_used: HashMap::new(), [INFO] [stderr] 1080 | budget_given: 0, [INFO] [stderr] 1081 | budget_gotten: 0, [INFO] [stderr] 1082 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_event_shop.rs:1077:57 [INFO] [stderr] | [INFO] [stderr] 1077 | if !bill.finalized_data.user_consumption.get(&donor_id).unwrap().per_day.get(&day_idx).unwrap().giveouts_to_user_id.contains_key(&consumer_id) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&bill.finalized_data.user_consumption.get(&donor_id).unwrap().per_day[&day_idx]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_event_shop.rs:1077:57 [INFO] [stderr] | [INFO] [stderr] 1077 | if !bill.finalized_data.user_consumption.get(&donor_id).unwrap().per_day.get(&day_idx).unwrap().giveouts_to_user_id.contains_key(&consumer_id) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&bill.finalized_data.user_consumption[&donor_id]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_event_shop.rs:1114:50 [INFO] [stderr] | [INFO] [stderr] 1114 | let item: Item = store.items.get(&item_id).unwrap().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&store.items[&item_id]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get_mut().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_event_shop.rs:1117:59 [INFO] [stderr] | [INFO] [stderr] 1117 | let mut bill: &mut Bill = store.bills.get_mut(bill_idx).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `store.bills[bill_idx]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/rustix_event_shop.rs:1118:33 [INFO] [stderr] | [INFO] [stderr] 1118 | / if !bill.finalized_data.all_users.contains_key(&donor) { [INFO] [stderr] 1119 | | bill.finalized_data.all_users.insert(donor, user.clone()); [INFO] [stderr] 1120 | | bill.finalized_data.user_consumption.insert(donor, BillUserInstance { [INFO] [stderr] 1121 | | user_id: donor, [INFO] [stderr] 1122 | | per_day: HashMap::new(), [INFO] [stderr] 1123 | | }); [INFO] [stderr] 1124 | | } [INFO] [stderr] | |_________________________________^ help: consider using: `bill.finalized_data.all_users.entry(donor)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/rustix_event_shop.rs:1126:33 [INFO] [stderr] | [INFO] [stderr] 1126 | / if !bill.finalized_data.all_items.contains_key(&item_id) { [INFO] [stderr] 1127 | | bill.finalized_data.all_items.insert(item_id, item.clone()); [INFO] [stderr] 1128 | | } [INFO] [stderr] | |_________________________________^ help: consider using: `bill.finalized_data.all_items.entry(item_id).or_insert(item.clone())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/rustix_event_shop.rs:1131:33 [INFO] [stderr] | [INFO] [stderr] 1131 | / if !bill.finalized_data.user_consumption[&donor].per_day.contains_key(&day_idx) { [INFO] [stderr] 1132 | | bill.finalized_data.user_consumption.get_mut(&donor).unwrap().per_day.insert(day_idx, BillUserDayInstance { [INFO] [stderr] 1133 | | personally_consumed: HashMap::new(), [INFO] [stderr] 1134 | | specials_consumed: Vec::new(), [INFO] [stderr] ... | [INFO] [stderr] 1137 | | }); [INFO] [stderr] 1138 | | } [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] help: consider using [INFO] [stderr] | [INFO] [stderr] 1131 | bill.finalized_data.user_consumption[&donor].per_day.entry(day_idx).or_insert(BillUserDayInstance { [INFO] [stderr] 1132 | personally_consumed: HashMap::new(), [INFO] [stderr] 1133 | specials_consumed: Vec::new(), [INFO] [stderr] 1134 | ffa_giveouts: HashMap::new(), [INFO] [stderr] 1135 | giveouts_to_user_id: HashMap::new(), [INFO] [stderr] 1136 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/rustix_event_shop.rs:1172:17 [INFO] [stderr] | [INFO] [stderr] 1172 | / match x { [INFO] [stderr] 1173 | | &mut Purchase::SpecialPurchase{ [INFO] [stderr] 1174 | | ref unique_id, [INFO] [stderr] 1175 | | ref timestamp_epoch_millis, [INFO] [stderr] ... | [INFO] [stderr] 1183 | | _ => return false, [INFO] [stderr] 1184 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 1172 | match *x { [INFO] [stderr] 1173 | Purchase::SpecialPurchase{ [INFO] [stderr] 1174 | ref unique_id, [INFO] [stderr] 1175 | ref timestamp_epoch_millis, [INFO] [stderr] 1176 | ref special_name, [INFO] [stderr] 1177 | ref mut specialcost, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/persistencer.rs:115:13 [INFO] [stderr] | [INFO] [stderr] 115 | let mut fp = FilePersister { [INFO] [stderr] | ----^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] error: Could not compile `rustix-bl`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/left_threaded_avl_tree.rs:73:13 [INFO] [stderr] | [INFO] [stderr] 73 | self.scores[i] = self.scores[i] + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.scores[i] += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/datastore.rs:29:40 [INFO] [stderr] | [INFO] [stderr] 29 | fn get_mut_purchase(&mut self, id: &u64) -> Option<&mut Purchase>; [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/datastore.rs:142:33 [INFO] [stderr] | [INFO] [stderr] 142 | let v : Vec = self.purchases.iter() [INFO] [stderr] | _________________________________^ [INFO] [stderr] 143 | | .filter(|p: &&Purchase| { [INFO] [stderr] 144 | | p.get_user_id().eq(&user_id) && p.get_timestamp() >= &millis_start_inclusive && p.get_timestamp() < &millis_end_exclusive [INFO] [stderr] 145 | | }) [INFO] [stderr] 146 | | .map(|p: &Purchase| p.clone()) [INFO] [stderr] | |__________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 142 | let v : Vec = self.purchases.iter() [INFO] [stderr] 143 | .filter(|p: &&Purchase| { [INFO] [stderr] 144 | p.get_user_id().eq(&user_id) && p.get_timestamp() >= &millis_start_inclusive && p.get_timestamp() < &millis_end_exclusive [INFO] [stderr] 145 | }).cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/datastore.rs:144:45 [INFO] [stderr] | [INFO] [stderr] 144 | p.get_user_id().eq(&user_id) && p.get_timestamp() >= &millis_start_inclusive && p.get_timestamp() < &millis_end_exclusive [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^----------------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `millis_start_inclusive` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/datastore.rs:144:93 [INFO] [stderr] | [INFO] [stderr] 144 | p.get_user_id().eq(&user_id) && p.get_timestamp() >= &millis_start_inclusive && p.get_timestamp() < &millis_end_exclusive [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^--------------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `millis_end_exclusive` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/datastore.rs:174:29 [INFO] [stderr] | [INFO] [stderr] 174 | let v : Vec = self.bills.iter() [INFO] [stderr] | _____________________________^ [INFO] [stderr] 175 | | .filter(|b: &&Bill| { [INFO] [stderr] 176 | | matches_usergroup(&user_id, &b.users) && !(b.timestamp_to < millis_start_inclusive || b.timestamp_from > millis_end_exclusive) [INFO] [stderr] 177 | | }) [INFO] [stderr] 178 | | .map(|p: &Bill| p.clone()) [INFO] [stderr] | |______________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 174 | let v : Vec = self.bills.iter() [INFO] [stderr] 175 | .filter(|b: &&Bill| { [INFO] [stderr] 176 | matches_usergroup(&user_id, &b.users) && !(b.timestamp_to < millis_start_inclusive || b.timestamp_from > millis_end_exclusive) [INFO] [stderr] 177 | }).cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get_mut().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/datastore.rs:186:34 [INFO] [stderr] | [INFO] [stderr] 186 | return idx.map(move |id| self.purchases.get_mut(id).unwrap()).ok(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.purchases[id]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/datastore.rs:252:35 [INFO] [stderr] | [INFO] [stderr] 252 | let usr = self.users.get(&uid).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.users[&uid]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/datastore.rs:256:85 [INFO] [stderr] | [INFO] [stderr] 256 | } else if bill.users_that_will_not_be_billed.contains(&uid) { [INFO] [stderr] | _____________________________________________________________________________________^ [INFO] [stderr] 257 | | //else if user is in internal exclusion list of bill, add to internally excluded list [INFO] [stderr] 258 | | } else if usr.external_user_id.is_none() { [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/datastore.rs:254:43 [INFO] [stderr] | [INFO] [stderr] 254 | if !usr.is_billed { [INFO] [stderr] | ___________________________________________^ [INFO] [stderr] 255 | | //if user isn't billed per field, add to externally excluded list [INFO] [stderr] 256 | | } else if bill.users_that_will_not_be_billed.contains(&uid) { [INFO] [stderr] | |_________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/datastore.rs:308:13 [INFO] [stderr] | [INFO] [stderr] 308 | / match *freeby { [INFO] [stderr] 309 | | Freeby::Transfer { .. } => { [INFO] [stderr] 310 | | return Some(idx); [INFO] [stderr] 311 | | }, [INFO] [stderr] 312 | | _ => (), [INFO] [stderr] 313 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 308 | if let Freeby::Transfer { .. } = *freeby { [INFO] [stderr] 309 | return Some(idx); [INFO] [stderr] 310 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/datastore.rs:319:36 [INFO] [stderr] | [INFO] [stderr] 319 | let cat : Option = self.items.get(&item).unwrap().clone().category; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.items[&item]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/datastore.rs:321:13 [INFO] [stderr] | [INFO] [stderr] 321 | / match *freeby { [INFO] [stderr] 322 | | Freeby::Classic { ref allowed_categories, [INFO] [stderr] 323 | | ref allowed_drinks, .. } => { [INFO] [stderr] 324 | | let cat = cat.clone(); [INFO] [stderr] ... | [INFO] [stderr] 340 | | _ => (), [INFO] [stderr] 341 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 321 | if let Freeby::Classic { ref allowed_categories, [INFO] [stderr] 322 | ref allowed_drinks, .. } = *freeby { [INFO] [stderr] 323 | let cat = cat.clone(); [INFO] [stderr] 324 | if allowed_drinks.contains(&item) { [INFO] [stderr] 325 | return Some(idx); [INFO] [stderr] 326 | } else { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/datastore.rs:328:25 [INFO] [stderr] | [INFO] [stderr] 328 | / match cat { [INFO] [stderr] 329 | | Some(c) => { [INFO] [stderr] 330 | | if allowed_categories.contains(&c) { [INFO] [stderr] 331 | | return Some(idx); [INFO] [stderr] ... | [INFO] [stderr] 336 | | None => (), [INFO] [stderr] 337 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 328 | if let Some(c) = cat { [INFO] [stderr] 329 | if allowed_categories.contains(&c) { [INFO] [stderr] 330 | return Some(idx); [INFO] [stderr] 331 | } else { [INFO] [stderr] 332 | () [INFO] [stderr] 333 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/datastore.rs:367:34 [INFO] [stderr] | [INFO] [stderr] 367 | let found_open = self.open_freebies.get(&recipient_id).unwrap().binary_search_by(|f| f.get_id().cmp(&freeby_id)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.open_freebies[&recipient_id]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/datastore.rs:369:28 [INFO] [stderr] | [INFO] [stderr] 369 | return self.open_freebies.get(&recipient_id).unwrap().get(found_open.unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.open_freebies[&recipient_id]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/datastore.rs:381:35 [INFO] [stderr] | [INFO] [stderr] 381 | pub fn matches_usergroup(user_id: &Option, usergroup: &UserGroup) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `Option` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/datastore.rs:399:29 [INFO] [stderr] | [INFO] [stderr] 399 | fn matches_userset(user_id: &Option, usergroup: &HashSet) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `Option` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/datastore.rs:453:24 [INFO] [stderr] | [INFO] [stderr] 453 | Ok(idx) => self.purchases.get(idx).map(|p|p.clone()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.purchases.get(idx).cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/datastore.rs:1150:9 [INFO] [stderr] | [INFO] [stderr] 1150 | / match self { [INFO] [stderr] 1151 | | &Purchase::SpecialPurchase{ [INFO] [stderr] 1152 | | ref unique_id, [INFO] [stderr] 1153 | | ref timestamp_epoch_millis, [INFO] [stderr] ... | [INFO] [stderr] 1176 | | }, [INFO] [stderr] 1177 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 1150 | match *self { [INFO] [stderr] 1151 | Purchase::SpecialPurchase{ [INFO] [stderr] 1152 | ref unique_id, [INFO] [stderr] 1153 | ref timestamp_epoch_millis, [INFO] [stderr] 1154 | ref special_name, [INFO] [stderr] 1155 | ref specialcost, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/datastore.rs:1181:9 [INFO] [stderr] | [INFO] [stderr] 1181 | / match self { [INFO] [stderr] 1182 | | &Purchase::SpecialPurchase { [INFO] [stderr] 1183 | | ref unique_id, [INFO] [stderr] 1184 | | ref timestamp_epoch_millis, [INFO] [stderr] ... | [INFO] [stderr] 1189 | | _ => panic!("get_special_set_price called on non-special purchase"), [INFO] [stderr] 1190 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 1181 | match *self { [INFO] [stderr] 1182 | Purchase::SpecialPurchase { [INFO] [stderr] 1183 | ref unique_id, [INFO] [stderr] 1184 | ref timestamp_epoch_millis, [INFO] [stderr] 1185 | ref special_name, [INFO] [stderr] 1186 | ref specialcost, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/datastore.rs:1194:9 [INFO] [stderr] | [INFO] [stderr] 1194 | / match self { [INFO] [stderr] 1195 | | &Purchase::SpecialPurchase{ [INFO] [stderr] 1196 | | ref unique_id, [INFO] [stderr] 1197 | | ref timestamp_epoch_millis, [INFO] [stderr] ... | [INFO] [stderr] 1220 | | } [INFO] [stderr] 1221 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 1194 | match *self { [INFO] [stderr] 1195 | Purchase::SpecialPurchase{ [INFO] [stderr] 1196 | ref unique_id, [INFO] [stderr] 1197 | ref timestamp_epoch_millis, [INFO] [stderr] 1198 | ref special_name, [INFO] [stderr] 1199 | ref specialcost, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/datastore.rs:1225:9 [INFO] [stderr] | [INFO] [stderr] 1225 | / match self { [INFO] [stderr] 1226 | | &Purchase::SpecialPurchase{ [INFO] [stderr] 1227 | | ref unique_id, [INFO] [stderr] 1228 | | ref timestamp_epoch_millis, [INFO] [stderr] ... | [INFO] [stderr] 1251 | | } [INFO] [stderr] 1252 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 1225 | match *self { [INFO] [stderr] 1226 | Purchase::SpecialPurchase{ [INFO] [stderr] 1227 | ref unique_id, [INFO] [stderr] 1228 | ref timestamp_epoch_millis, [INFO] [stderr] 1229 | ref special_name, [INFO] [stderr] 1230 | ref specialcost, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/datastore.rs:1255:9 [INFO] [stderr] | [INFO] [stderr] 1255 | / match self { [INFO] [stderr] 1256 | | &Purchase::SpecialPurchase{ [INFO] [stderr] 1257 | | ref unique_id, [INFO] [stderr] 1258 | | ref timestamp_epoch_millis, [INFO] [stderr] ... | [INFO] [stderr] 1281 | | } [INFO] [stderr] 1282 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 1255 | match *self { [INFO] [stderr] 1256 | Purchase::SpecialPurchase{ [INFO] [stderr] 1257 | ref unique_id, [INFO] [stderr] 1258 | ref timestamp_epoch_millis, [INFO] [stderr] 1259 | ref special_name, [INFO] [stderr] 1260 | ref specialcost, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/datastore.rs:1286:9 [INFO] [stderr] | [INFO] [stderr] 1286 | / match self { [INFO] [stderr] 1287 | | &Purchase::SpecialPurchase{ [INFO] [stderr] 1288 | | ref unique_id, [INFO] [stderr] 1289 | | ref timestamp_epoch_millis, [INFO] [stderr] ... | [INFO] [stderr] 1312 | | } [INFO] [stderr] 1313 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 1286 | match *self { [INFO] [stderr] 1287 | Purchase::SpecialPurchase{ [INFO] [stderr] 1288 | ref unique_id, [INFO] [stderr] 1289 | ref timestamp_epoch_millis, [INFO] [stderr] 1290 | ref special_name, [INFO] [stderr] 1291 | ref specialcost, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/datastore.rs:1317:9 [INFO] [stderr] | [INFO] [stderr] 1317 | / match self { [INFO] [stderr] 1318 | | &Purchase::SpecialPurchase{ [INFO] [stderr] 1319 | | ref unique_id, [INFO] [stderr] 1320 | | ref timestamp_epoch_millis, [INFO] [stderr] ... | [INFO] [stderr] 1343 | | } [INFO] [stderr] 1344 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 1317 | match *self { [INFO] [stderr] 1318 | Purchase::SpecialPurchase{ [INFO] [stderr] 1319 | ref unique_id, [INFO] [stderr] 1320 | ref timestamp_epoch_millis, [INFO] [stderr] 1321 | ref special_name, [INFO] [stderr] 1322 | ref specialcost, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/rustix_backend.rs:69:5 [INFO] [stderr] | [INFO] [stderr] 69 | / fn create_free_count(&mut self, allowed_categories : Vec, [INFO] [stderr] 70 | | allowed_drinks : Vec, [INFO] [stderr] 71 | | allowed_number_total : u16, [INFO] [stderr] 72 | | text_message : String, [INFO] [stderr] 73 | | created_timestamp : i64, [INFO] [stderr] 74 | | donor : u32, [INFO] [stderr] 75 | | recipient : u32) -> bool; [INFO] [stderr] | |__________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_backend.rs:384:13 [INFO] [stderr] | [INFO] [stderr] 384 | backend.datastore.users.get(&0).unwrap().username, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&backend.datastore.users[&0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_backend.rs:397:13 [INFO] [stderr] | [INFO] [stderr] 397 | backend.datastore.items.get(&0).unwrap().name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&backend.datastore.items[&0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_backend.rs:401:13 [INFO] [stderr] | [INFO] [stderr] 401 | backend.datastore.items.get(&1).unwrap().name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&backend.datastore.items[&1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_backend.rs:405:13 [INFO] [stderr] | [INFO] [stderr] 405 | / backend [INFO] [stderr] 406 | | .datastore [INFO] [stderr] 407 | | .items [INFO] [stderr] 408 | | .get(&0) [INFO] [stderr] 409 | | .unwrap() [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 405 | &backend [INFO] [stderr] 406 | .datastore [INFO] [stderr] 407 | .items[&0] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_backend.rs:415:20 [INFO] [stderr] | [INFO] [stderr] 415 | assert_eq!(backend.datastore.items.get(&1).unwrap().cost_cents, 75); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&backend.datastore.items[&1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_backend.rs:427:13 [INFO] [stderr] | [INFO] [stderr] 427 | backend.datastore.items.get(&0).unwrap().name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&backend.datastore.items[&0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_backend.rs:431:13 [INFO] [stderr] | [INFO] [stderr] 431 | backend.datastore.items.get(&1).unwrap().name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&backend.datastore.items[&1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_backend.rs:435:13 [INFO] [stderr] | [INFO] [stderr] 435 | / backend [INFO] [stderr] 436 | | .datastore [INFO] [stderr] 437 | | .items [INFO] [stderr] 438 | | .get(&0) [INFO] [stderr] 439 | | .unwrap() [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 435 | &backend [INFO] [stderr] 436 | .datastore [INFO] [stderr] 437 | .items[&0] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_backend.rs:445:20 [INFO] [stderr] | [INFO] [stderr] 445 | assert_eq!(backend.datastore.items.get(&1).unwrap().cost_cents, 75); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&backend.datastore.items[&1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_backend.rs:451:13 [INFO] [stderr] | [INFO] [stderr] 451 | backend.datastore.items.get(&0).unwrap().name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&backend.datastore.items[&0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_backend.rs:455:13 [INFO] [stderr] | [INFO] [stderr] 455 | / backend [INFO] [stderr] 456 | | .datastore [INFO] [stderr] 457 | | .items [INFO] [stderr] 458 | | .get(&0) [INFO] [stderr] 459 | | .unwrap() [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 455 | &backend [INFO] [stderr] 456 | .datastore [INFO] [stderr] 457 | .items[&0] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_backend.rs:476:13 [INFO] [stderr] | [INFO] [stderr] 476 | backend.datastore.users.get(&0).unwrap().username, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&backend.datastore.users[&0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 43 [INFO] [stderr] --> src/rustix_backend.rs:486:5 [INFO] [stderr] | [INFO] [stderr] 486 | / fn simple_purchase() { [INFO] [stderr] 487 | | let mut backend = build_test_backend(); [INFO] [stderr] 488 | | backend.persistencer.config.users_in_top_users = 1usize; [INFO] [stderr] 489 | | [INFO] [stderr] ... | [INFO] [stderr] 630 | | [INFO] [stderr] 631 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_backend.rs:528:13 [INFO] [stderr] | [INFO] [stderr] 528 | / backend [INFO] [stderr] 529 | | .datastore [INFO] [stderr] 530 | | .top_drinks_per_user [INFO] [stderr] 531 | | .get(&0) [INFO] [stderr] 532 | | .unwrap() [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 528 | &backend [INFO] [stderr] 529 | .datastore [INFO] [stderr] 530 | .top_drinks_per_user[&0] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_backend.rs:538:13 [INFO] [stderr] | [INFO] [stderr] 538 | / backend [INFO] [stderr] 539 | | .datastore [INFO] [stderr] 540 | | .top_drinks_per_user [INFO] [stderr] 541 | | .get(&1) [INFO] [stderr] 542 | | .unwrap() [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 538 | &backend [INFO] [stderr] 539 | .datastore [INFO] [stderr] 540 | .top_drinks_per_user[&1] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 31 [INFO] [stderr] --> src/rustix_backend.rs:634:5 [INFO] [stderr] | [INFO] [stderr] 634 | / fn simple_create_bill() { [INFO] [stderr] 635 | | let mut backend = build_test_backend(); [INFO] [stderr] 636 | | //create two users, create three items, make 1 user purchase 2 items but not the third [INFO] [stderr] 637 | | backend.create_user("user a".to_string()); [INFO] [stderr] ... | [INFO] [stderr] 960 | | // ); [INFO] [stderr] 961 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_backend.rs:686:28 [INFO] [stderr] | [INFO] [stderr] 686 | let user_key = (0, (&backend).datastore.users.get(&0).unwrap().username.to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&(&backend).datastore.users[&0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_backend.rs:687:30 [INFO] [stderr] | [INFO] [stderr] 687 | let user_1_key = (1, (&backend).datastore.users.get(&1).unwrap().username.to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&(&backend).datastore.users[&1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_backend.rs:688:30 [INFO] [stderr] | [INFO] [stderr] 688 | let item_0_key = (0, (&backend).datastore.items.get(&0).unwrap().name.to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&(&backend).datastore.items[&0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_backend.rs:689:30 [INFO] [stderr] | [INFO] [stderr] 689 | let item_1_key = (1, (&backend).datastore.items.get(&1).unwrap().name.to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&(&backend).datastore.items[&1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_backend.rs:697:13 [INFO] [stderr] | [INFO] [stderr] 697 | / backend [INFO] [stderr] 698 | | .datastore [INFO] [stderr] 699 | | .balance_cost_per_user [INFO] [stderr] 700 | | .get(&user_key) [INFO] [stderr] 701 | | .unwrap() [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 697 | &backend [INFO] [stderr] 698 | .datastore [INFO] [stderr] 699 | .balance_cost_per_user[&user_key] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_backend.rs:708:13 [INFO] [stderr] | [INFO] [stderr] 708 | / backend [INFO] [stderr] 709 | | .datastore [INFO] [stderr] 710 | | .balance_cost_per_user [INFO] [stderr] 711 | | .get(&user_key) [INFO] [stderr] 712 | | .unwrap() [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 708 | &backend [INFO] [stderr] 709 | .datastore [INFO] [stderr] 710 | .balance_cost_per_user[&user_key] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_backend.rs:744:13 [INFO] [stderr] | [INFO] [stderr] 744 | backend.datastore.open_freebies.get(&2).unwrap().len(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&backend.datastore.open_freebies[&2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_backend.rs:775:13 [INFO] [stderr] | [INFO] [stderr] 775 | backend.datastore.bills[0].finalized_data.user_consumption.get(&0).unwrap().per_day.get(&0).unwrap().personally_consumed.len(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&backend.datastore.bills[0].finalized_data.user_consumption.get(&0).unwrap().per_day[&0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_backend.rs:775:13 [INFO] [stderr] | [INFO] [stderr] 775 | backend.datastore.bills[0].finalized_data.user_consumption.get(&0).unwrap().per_day.get(&0).unwrap().personally_consumed.len(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&backend.datastore.bills[0].finalized_data.user_consumption[&0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_backend.rs:779:13 [INFO] [stderr] | [INFO] [stderr] 779 | backend.datastore.bills[0].finalized_data.user_consumption.get(&0).unwrap().per_day.get(&0).unwrap().ffa_giveouts.len(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&backend.datastore.bills[0].finalized_data.user_consumption.get(&0).unwrap().per_day[&0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_backend.rs:779:13 [INFO] [stderr] | [INFO] [stderr] 779 | backend.datastore.bills[0].finalized_data.user_consumption.get(&0).unwrap().per_day.get(&0).unwrap().ffa_giveouts.len(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&backend.datastore.bills[0].finalized_data.user_consumption[&0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_backend.rs:783:13 [INFO] [stderr] | [INFO] [stderr] 783 | backend.datastore.bills[0].finalized_data.user_consumption.get(&0).unwrap().per_day.get(&0).unwrap().giveouts_to_user_id.len(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&backend.datastore.bills[0].finalized_data.user_consumption.get(&0).unwrap().per_day[&0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_backend.rs:783:13 [INFO] [stderr] | [INFO] [stderr] 783 | backend.datastore.bills[0].finalized_data.user_consumption.get(&0).unwrap().per_day.get(&0).unwrap().giveouts_to_user_id.len(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&backend.datastore.bills[0].finalized_data.user_consumption[&0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_backend.rs:787:13 [INFO] [stderr] | [INFO] [stderr] 787 | backend.datastore.bills[0].finalized_data.user_consumption.get(&0).unwrap().per_day.get(&0).unwrap().giveouts_to_user_id.get(&2).unwrap().budget_given, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&backend.datastore.bills[0].finalized_data.user_consumption.get(&0).unwrap().per_day.get(&0).unwrap().giveouts_to_user_id[&2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_backend.rs:787:13 [INFO] [stderr] | [INFO] [stderr] 787 | backend.datastore.bills[0].finalized_data.user_consumption.get(&0).unwrap().per_day.get(&0).unwrap().giveouts_to_user_id.get(&2).unwrap().budget_given, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&backend.datastore.bills[0].finalized_data.user_consumption.get(&0).unwrap().per_day[&0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_backend.rs:787:13 [INFO] [stderr] | [INFO] [stderr] 787 | backend.datastore.bills[0].finalized_data.user_consumption.get(&0).unwrap().per_day.get(&0).unwrap().giveouts_to_user_id.get(&2).unwrap().budget_given, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&backend.datastore.bills[0].finalized_data.user_consumption[&0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_backend.rs:791:13 [INFO] [stderr] | [INFO] [stderr] 791 | backend.datastore.bills[0].finalized_data.user_consumption.get(&2).unwrap().per_day.get(&0).unwrap().giveouts_to_user_id.get(&0).unwrap().budget_gotten, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&backend.datastore.bills[0].finalized_data.user_consumption.get(&2).unwrap().per_day.get(&0).unwrap().giveouts_to_user_id[&0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_backend.rs:791:13 [INFO] [stderr] | [INFO] [stderr] 791 | backend.datastore.bills[0].finalized_data.user_consumption.get(&2).unwrap().per_day.get(&0).unwrap().giveouts_to_user_id.get(&0).unwrap().budget_gotten, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&backend.datastore.bills[0].finalized_data.user_consumption.get(&2).unwrap().per_day[&0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_backend.rs:791:13 [INFO] [stderr] | [INFO] [stderr] 791 | backend.datastore.bills[0].finalized_data.user_consumption.get(&2).unwrap().per_day.get(&0).unwrap().giveouts_to_user_id.get(&0).unwrap().budget_gotten, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&backend.datastore.bills[0].finalized_data.user_consumption[&2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_backend.rs:795:13 [INFO] [stderr] | [INFO] [stderr] 795 | backend.datastore.bills[0].finalized_data.user_consumption.get(&2).unwrap().per_day.get(&0).unwrap().giveouts_to_user_id.get(&0).unwrap().budget_given, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&backend.datastore.bills[0].finalized_data.user_consumption.get(&2).unwrap().per_day.get(&0).unwrap().giveouts_to_user_id[&0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_backend.rs:795:13 [INFO] [stderr] | [INFO] [stderr] 795 | backend.datastore.bills[0].finalized_data.user_consumption.get(&2).unwrap().per_day.get(&0).unwrap().giveouts_to_user_id.get(&0).unwrap().budget_given, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&backend.datastore.bills[0].finalized_data.user_consumption.get(&2).unwrap().per_day[&0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_backend.rs:795:13 [INFO] [stderr] | [INFO] [stderr] 795 | backend.datastore.bills[0].finalized_data.user_consumption.get(&2).unwrap().per_day.get(&0).unwrap().giveouts_to_user_id.get(&0).unwrap().budget_given, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&backend.datastore.bills[0].finalized_data.user_consumption[&2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_backend.rs:799:13 [INFO] [stderr] | [INFO] [stderr] 799 | backend.datastore.bills[0].finalized_data.user_consumption.get(&0).unwrap().per_day.get(&0).unwrap().giveouts_to_user_id.get(&2).unwrap().budget_gotten, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&backend.datastore.bills[0].finalized_data.user_consumption.get(&0).unwrap().per_day.get(&0).unwrap().giveouts_to_user_id[&2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_backend.rs:799:13 [INFO] [stderr] | [INFO] [stderr] 799 | backend.datastore.bills[0].finalized_data.user_consumption.get(&0).unwrap().per_day.get(&0).unwrap().giveouts_to_user_id.get(&2).unwrap().budget_gotten, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&backend.datastore.bills[0].finalized_data.user_consumption.get(&0).unwrap().per_day[&0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_backend.rs:799:13 [INFO] [stderr] | [INFO] [stderr] 799 | backend.datastore.bills[0].finalized_data.user_consumption.get(&0).unwrap().per_day.get(&0).unwrap().giveouts_to_user_id.get(&2).unwrap().budget_gotten, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&backend.datastore.bills[0].finalized_data.user_consumption[&0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_backend.rs:803:13 [INFO] [stderr] | [INFO] [stderr] 803 | backend.datastore.bills[0].finalized_data.user_consumption.get(&0).unwrap().per_day.get(&0).unwrap().giveouts_to_user_id.get(&2).unwrap().count_giveouts_used.len(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&backend.datastore.bills[0].finalized_data.user_consumption.get(&0).unwrap().per_day.get(&0).unwrap().giveouts_to_user_id[&2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_backend.rs:803:13 [INFO] [stderr] | [INFO] [stderr] 803 | backend.datastore.bills[0].finalized_data.user_consumption.get(&0).unwrap().per_day.get(&0).unwrap().giveouts_to_user_id.get(&2).unwrap().count_giveouts_used.len(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&backend.datastore.bills[0].finalized_data.user_consumption.get(&0).unwrap().per_day[&0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_backend.rs:803:13 [INFO] [stderr] | [INFO] [stderr] 803 | backend.datastore.bills[0].finalized_data.user_consumption.get(&0).unwrap().per_day.get(&0).unwrap().giveouts_to_user_id.get(&2).unwrap().count_giveouts_used.len(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&backend.datastore.bills[0].finalized_data.user_consumption[&0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_backend.rs:807:13 [INFO] [stderr] | [INFO] [stderr] 807 | backend.datastore.bills[0].finalized_data.user_consumption.get(&0).unwrap().per_day.get(&0).unwrap().specials_consumed.len(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&backend.datastore.bills[0].finalized_data.user_consumption.get(&0).unwrap().per_day[&0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_backend.rs:807:13 [INFO] [stderr] | [INFO] [stderr] 807 | backend.datastore.bills[0].finalized_data.user_consumption.get(&0).unwrap().per_day.get(&0).unwrap().specials_consumed.len(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&backend.datastore.bills[0].finalized_data.user_consumption[&0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_backend.rs:813:13 [INFO] [stderr] | [INFO] [stderr] 813 | backend.datastore.open_freebies.get(&2).unwrap().len(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&backend.datastore.open_freebies[&2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/persistencer.rs:139:9 [INFO] [stderr] | [INFO] [stderr] 139 | / match self.lmdb { [INFO] [stderr] 140 | | Some(ref lmdb) => { [INFO] [stderr] 141 | | let mut rw_transaction: RwTransaction = try!(lmdb.db_env.begin_rw_txn()); [INFO] [stderr] 142 | | let tx_flags: WriteFlags = WriteFlags::empty(); [INFO] [stderr] ... | [INFO] [stderr] 148 | | None => (), [INFO] [stderr] 149 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 139 | if let Some(ref lmdb) = self.lmdb { [INFO] [stderr] 140 | let mut rw_transaction: RwTransaction = try!(lmdb.db_env.begin_rw_txn()); [INFO] [stderr] 141 | let tx_flags: WriteFlags = WriteFlags::empty(); [INFO] [stderr] 142 | let key = id_to_key(id);// transform_u32_to_array_of_u8(id); [INFO] [stderr] 143 | let data = try!(serde_json::to_string(event)); [INFO] [stderr] 144 | let result = rw_transaction.put(lmdb.db, &key, &data, tx_flags); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/persistencer.rs:182:9 [INFO] [stderr] | [INFO] [stderr] 182 | / match self.lmdb { [INFO] [stderr] 183 | | Some(ref lmdb) => { [INFO] [stderr] 184 | | //build and use iterator if database is non-empty [INFO] [stderr] 185 | | let count = lmdb.db_env.stat().unwrap().entries() as u64; [INFO] [stderr] ... | [INFO] [stderr] 213 | | None => (), [INFO] [stderr] 214 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 182 | if let Some(ref lmdb) = self.lmdb { [INFO] [stderr] 183 | //build and use iterator if database is non-empty [INFO] [stderr] 184 | let count = lmdb.db_env.stat().unwrap().entries() as u64; [INFO] [stderr] 185 | if count > counter { [INFO] [stderr] 186 | let tx = try!(lmdb.db_env.begin_ro_txn()); [INFO] [stderr] 187 | { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 34 [INFO] [stderr] --> src/rustix_event_shop.rs:140:5 [INFO] [stderr] | [INFO] [stderr] 140 | / fn can_be_applied(&self, store: &Datastore) -> bool { [INFO] [stderr] 141 | | return match self { [INFO] [stderr] 142 | | &BLEvents::CreateItem { [INFO] [stderr] 143 | | ref itemname, [INFO] [stderr] ... | [INFO] [stderr] 232 | | }; [INFO] [stderr] 233 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/rustix_event_shop.rs:141:16 [INFO] [stderr] | [INFO] [stderr] 141 | return match self { [INFO] [stderr] | ________________^ [INFO] [stderr] 142 | | &BLEvents::CreateItem { [INFO] [stderr] 143 | | ref itemname, [INFO] [stderr] 144 | | price_cents, [INFO] [stderr] ... | [INFO] [stderr] 231 | | &BLEvents::SetPriceForSpecial { unique_id, price } => store.get_purchase(unique_id).is_some(), [INFO] [stderr] 232 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 141 | return match *self { [INFO] [stderr] 142 | BLEvents::CreateItem { [INFO] [stderr] 143 | ref itemname, [INFO] [stderr] 144 | price_cents, [INFO] [stderr] 145 | ref category, [INFO] [stderr] 146 | } => true, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/rustix_event_shop.rs:182:17 [INFO] [stderr] | [INFO] [stderr] 182 | result = result & x.can_be_applied(store); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `result &= x.can_be_applied(store)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_event_shop.rs:189:35 [INFO] [stderr] | [INFO] [stderr] 189 | let item: &Item = store.items.get(&item_id).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&store.items[&item_id]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 75 [INFO] [stderr] --> src/rustix_event_shop.rs:235:5 [INFO] [stderr] | [INFO] [stderr] 235 | / fn apply(&self, store: &mut Datastore, config: &StaticConfig) -> bool { [INFO] [stderr] 236 | | return match self { [INFO] [stderr] 237 | | &BLEvents::CreateItem { [INFO] [stderr] 238 | | ref itemname, [INFO] [stderr] ... | [INFO] [stderr] 1197 | | }; [INFO] [stderr] 1198 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/rustix_event_shop.rs:236:16 [INFO] [stderr] | [INFO] [stderr] 236 | return match self { [INFO] [stderr] | ________________^ [INFO] [stderr] 237 | | &BLEvents::CreateItem { [INFO] [stderr] 238 | | ref itemname, [INFO] [stderr] 239 | | ref price_cents, [INFO] [stderr] ... | [INFO] [stderr] 1196 | | }, [INFO] [stderr] 1197 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 236 | return match *self { [INFO] [stderr] 237 | BLEvents::CreateItem { [INFO] [stderr] 238 | ref itemname, [INFO] [stderr] 239 | ref price_cents, [INFO] [stderr] 240 | ref category, [INFO] [stderr] 241 | } => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's values [INFO] [stderr] --> src/rustix_event_shop.rs:258:35 [INFO] [stderr] | [INFO] [stderr] 258 | for (_, value) in &mut store.drink_scores_per_user { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::for_kv_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 258 | for value in store.drink_scores_per_user.values_mut() { [INFO] [stderr] | ^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's values [INFO] [stderr] --> src/rustix_event_shop.rs:267:35 [INFO] [stderr] | [INFO] [stderr] 267 | for (_, v) in &store.items { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 267 | for v in store.items.values() { [INFO] [stderr] | ^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's keys [INFO] [stderr] --> src/rustix_event_shop.rs:296:34 [INFO] [stderr] | [INFO] [stderr] 296 | for (_key, _) in &store.items { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 296 | for _key in store.items.keys() { [INFO] [stderr] | ^^^^ ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's values [INFO] [stderr] --> src/rustix_event_shop.rs:315:35 [INFO] [stderr] | [INFO] [stderr] 315 | for (_, v) in &store.users { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 315 | for v in store.users.values() { [INFO] [stderr] | ^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's values [INFO] [stderr] --> src/rustix_event_shop.rs:389:50 [INFO] [stderr] | [INFO] [stderr] 389 | for (_key, mut value) in &mut store.drink_scores_per_user { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 389 | for mut value in store.drink_scores_per_user.values_mut() { [INFO] [stderr] | ^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's values [INFO] [stderr] --> src/rustix_event_shop.rs:411:35 [INFO] [stderr] | [INFO] [stderr] 411 | for (_, v) in &store.items { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 411 | for v in store.items.values() { [INFO] [stderr] | ^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/rustix_event_shop.rs:425:17 [INFO] [stderr] | [INFO] [stderr] 425 | / match store.users.get(&user_id) { [INFO] [stderr] 426 | | Some(x) => { [INFO] [stderr] 427 | | if x.highlight_in_ui { [INFO] [stderr] 428 | | let _ = store.highlighted_users.remove(&user_id); [INFO] [stderr] ... | [INFO] [stderr] 431 | | None => (), [INFO] [stderr] 432 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 425 | if let Some(x) = store.users.get(&user_id) { [INFO] [stderr] 426 | if x.highlight_in_ui { [INFO] [stderr] 427 | let _ = store.highlighted_users.remove(&user_id); [INFO] [stderr] 428 | } [INFO] [stderr] 429 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's values [INFO] [stderr] --> src/rustix_event_shop.rs:451:35 [INFO] [stderr] | [INFO] [stderr] 451 | for (_, v) in &store.users { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 451 | for v in store.users.values() { [INFO] [stderr] | ^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_event_shop.rs:526:32 [INFO] [stderr] | [INFO] [stderr] 526 | let username = store.users.get(&user_id).unwrap().username.to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&store.users[&user_id]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_event_shop.rs:527:32 [INFO] [stderr] | [INFO] [stderr] 527 | let itemname = store.items.get(&item_id).unwrap().name.to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&store.items[&item_id]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_event_shop.rs:528:42 [INFO] [stderr] | [INFO] [stderr] 528 | let user_key = (user_id, store.users.get(&user_id).unwrap().username.to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&store.users[&user_id]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_event_shop.rs:529:42 [INFO] [stderr] | [INFO] [stderr] 529 | let item_key = (item_id, store.items.get(&item_id).unwrap().name.to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&store.items[&item_id]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/rustix_event_shop.rs:594:21 [INFO] [stderr] | [INFO] [stderr] 594 | result = result & x.apply(store, config); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `result &= x.apply(store, config)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_event_shop.rs:644:36 [INFO] [stderr] | [INFO] [stderr] 644 | let username = store.users.get(&user_id).unwrap().username.to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&store.users[&user_id]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_event_shop.rs:645:36 [INFO] [stderr] | [INFO] [stderr] 645 | let itemname = store.items.get(&item_id).unwrap().name.to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&store.items[&item_id]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_event_shop.rs:646:46 [INFO] [stderr] | [INFO] [stderr] 646 | let user_key = (user_id, store.users.get(&user_id).unwrap().username.to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&store.users[&user_id]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_event_shop.rs:647:46 [INFO] [stderr] | [INFO] [stderr] 647 | let item_key = (item_id, store.items.get(&item_id).unwrap().name.to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&store.items[&item_id]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_event_shop.rs:838:74 [INFO] [stderr] | [INFO] [stderr] 838 | let item_key1 : (u32, String) = (*element.get_item_id(), store.items.get(&element.get_item_id()).unwrap().name.to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&store.items[&element.get_item_id()]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_event_shop.rs:839:74 [INFO] [stderr] | [INFO] [stderr] 839 | let item_key2 : (u32, String) = (*element.get_item_id(), store.items.get(&element.get_item_id()).unwrap().name.to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&store.items[&element.get_item_id()]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_event_shop.rs:840:73 [INFO] [stderr] | [INFO] [stderr] 840 | let user_key : (u32, String) = (*element.get_user_id(), store.users.get(&element.get_user_id()).unwrap().username.to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&store.users[&element.get_user_id()]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_event_shop.rs:843:32 [INFO] [stderr] | [INFO] [stderr] 843 | let oldcost = *store [INFO] [stderr] | ________________________________^ [INFO] [stderr] 844 | | .balance_cost_per_user [INFO] [stderr] 845 | | .get(&user_key) [INFO] [stderr] 846 | | .unwrap() [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 843 | let oldcost = *&store [INFO] [stderr] 844 | .balance_cost_per_user[&user_key] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_event_shop.rs:849:33 [INFO] [stderr] | [INFO] [stderr] 849 | let oldcount = *store [INFO] [stderr] | _________________________________^ [INFO] [stderr] 850 | | .balance_count_per_user [INFO] [stderr] 851 | | .get(&user_key) [INFO] [stderr] 852 | | .unwrap() [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 849 | let oldcount = *&store [INFO] [stderr] 850 | .balance_count_per_user[&user_key] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get_mut().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_event_shop.rs:878:21 [INFO] [stderr] | [INFO] [stderr] 878 | store.bills.get_mut(bill_idx).unwrap().bill_state = BillState::Finalized; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `store.bills[bill_idx]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get_mut().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_event_shop.rs:902:59 [INFO] [stderr] | [INFO] [stderr] 902 | let mut bill: &mut Bill = store.bills.get_mut(bill_idx).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `store.bills[bill_idx]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/rustix_event_shop.rs:903:33 [INFO] [stderr] | [INFO] [stderr] 903 | / if !bill.finalized_data.all_users.contains_key(&consumer_id) { [INFO] [stderr] 904 | | bill.finalized_data.all_users.insert(consumer_id, user.clone()); [INFO] [stderr] 905 | | bill.finalized_data.user_consumption.insert(consumer_id, BillUserInstance { [INFO] [stderr] 906 | | user_id: consumer_id, [INFO] [stderr] 907 | | per_day: HashMap::new(), [INFO] [stderr] 908 | | }); [INFO] [stderr] 909 | | } [INFO] [stderr] | |_________________________________^ help: consider using: `bill.finalized_data.all_users.entry(consumer_id)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/rustix_event_shop.rs:903:33 [INFO] [stderr] | [INFO] [stderr] 903 | / if !bill.finalized_data.all_users.contains_key(&consumer_id) { [INFO] [stderr] 904 | | bill.finalized_data.all_users.insert(consumer_id, user.clone()); [INFO] [stderr] 905 | | bill.finalized_data.user_consumption.insert(consumer_id, BillUserInstance { [INFO] [stderr] 906 | | user_id: consumer_id, [INFO] [stderr] 907 | | per_day: HashMap::new(), [INFO] [stderr] 908 | | }); [INFO] [stderr] 909 | | } [INFO] [stderr] | |_________________________________^ help: consider using: `bill.finalized_data.all_users.entry(consumer_id)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/rustix_event_shop.rs:911:33 [INFO] [stderr] | [INFO] [stderr] 911 | / if !bill.finalized_data.user_consumption.get_mut(&consumer_id).unwrap().per_day.contains_key(&day_idx) { [INFO] [stderr] 912 | | bill.finalized_data.user_consumption.get_mut(&consumer_id).unwrap().per_day.insert(day_idx, BillUserDayInstance { [INFO] [stderr] 913 | | personally_consumed: HashMap::new(), [INFO] [stderr] 914 | | specials_consumed: Vec::new(), [INFO] [stderr] ... | [INFO] [stderr] 917 | | }); [INFO] [stderr] 918 | | } [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] help: consider using [INFO] [stderr] | [INFO] [stderr] 911 | bill.finalized_data.user_consumption.get_mut(&consumer_id).unwrap().per_day.entry(day_idx).or_insert(BillUserDayInstance { [INFO] [stderr] 912 | personally_consumed: HashMap::new(), [INFO] [stderr] 913 | specials_consumed: Vec::new(), [INFO] [stderr] 914 | ffa_giveouts: HashMap::new(), [INFO] [stderr] 915 | giveouts_to_user_id: HashMap::new(), [INFO] [stderr] 916 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_event_shop.rs:932:50 [INFO] [stderr] | [INFO] [stderr] 932 | let item: Item = store.items.get(&item_id).unwrap().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&store.items[&item_id]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get_mut().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_event_shop.rs:937:59 [INFO] [stderr] | [INFO] [stderr] 937 | let mut bill: &mut Bill = store.bills.get_mut(bill_idx).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `store.bills[bill_idx]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/rustix_event_shop.rs:938:33 [INFO] [stderr] | [INFO] [stderr] 938 | / if !bill.finalized_data.all_users.contains_key(&consumer_id) { [INFO] [stderr] 939 | | bill.finalized_data.all_users.insert(consumer_id, user.clone()); [INFO] [stderr] 940 | | bill.finalized_data.user_consumption.insert(consumer_id, BillUserInstance { [INFO] [stderr] 941 | | user_id: consumer_id, [INFO] [stderr] 942 | | per_day: HashMap::new(), [INFO] [stderr] 943 | | }); [INFO] [stderr] 944 | | } [INFO] [stderr] | |_________________________________^ help: consider using: `bill.finalized_data.all_users.entry(consumer_id)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/rustix_event_shop.rs:946:33 [INFO] [stderr] | [INFO] [stderr] 946 | / if !bill.finalized_data.all_items.contains_key(&item_id) { [INFO] [stderr] 947 | | bill.finalized_data.all_items.insert(item_id, item.clone()); [INFO] [stderr] 948 | | } [INFO] [stderr] | |_________________________________^ help: consider using: `bill.finalized_data.all_items.entry(item_id).or_insert(item.clone())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_event_shop.rs:954:62 [INFO] [stderr] | [INFO] [stderr] 954 | let old_count: u16 = store.open_freebies.get(&consumer_id).unwrap().get(cidx).unwrap().left(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&store.open_freebies[&consumer_id]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_event_shop.rs:955:61 [INFO] [stderr] | [INFO] [stderr] 955 | let donor_id: u32 = store.open_freebies.get(&consumer_id).unwrap().get(cidx).unwrap().get_donor(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&store.open_freebies[&consumer_id]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_event_shop.rs:956:59 [INFO] [stderr] | [INFO] [stderr] 956 | let donor: User = store.users.get(&donor_id).unwrap().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&store.users[&donor_id]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/rustix_event_shop.rs:960:45 [INFO] [stderr] | [INFO] [stderr] 960 | / if !bill.finalized_data.all_users.contains_key(&donor_id) { [INFO] [stderr] 961 | | bill.finalized_data.all_users.insert(donor_id, donor.clone()); [INFO] [stderr] 962 | | bill.finalized_data.user_consumption.insert(donor_id, BillUserInstance { [INFO] [stderr] 963 | | user_id: donor_id, [INFO] [stderr] 964 | | per_day: HashMap::new(), [INFO] [stderr] 965 | | }); [INFO] [stderr] 966 | | } [INFO] [stderr] | |_____________________________________________^ help: consider using: `bill.finalized_data.all_users.entry(donor_id)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/rustix_event_shop.rs:968:45 [INFO] [stderr] | [INFO] [stderr] 968 | / if !bill.finalized_data.user_consumption.get_mut(&donor_id).unwrap().per_day.contains_key(&day_idx) { [INFO] [stderr] 969 | | bill.finalized_data.user_consumption.get_mut(&donor_id).unwrap().per_day.insert(day_idx, BillUserDayInstance { [INFO] [stderr] 970 | | personally_consumed: HashMap::new(), [INFO] [stderr] 971 | | specials_consumed: Vec::new(), [INFO] [stderr] ... | [INFO] [stderr] 974 | | }); [INFO] [stderr] 975 | | } [INFO] [stderr] | |_____________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] help: consider using [INFO] [stderr] | [INFO] [stderr] 968 | bill.finalized_data.user_consumption.get_mut(&donor_id).unwrap().per_day.entry(day_idx).or_insert(BillUserDayInstance { [INFO] [stderr] 969 | personally_consumed: HashMap::new(), [INFO] [stderr] 970 | specials_consumed: Vec::new(), [INFO] [stderr] 971 | ffa_giveouts: HashMap::new(), [INFO] [stderr] 972 | giveouts_to_user_id: HashMap::new(), [INFO] [stderr] 973 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/rustix_event_shop.rs:1008:41 [INFO] [stderr] | [INFO] [stderr] 1008 | / match budget_freeby_idx { [INFO] [stderr] 1009 | | Some(bidx) => { [INFO] [stderr] 1010 | | let max_budget : u64 = store.open_freebies.get(&consumer_id).unwrap().get(bidx).unwrap().get_budget_cents_left(); [INFO] [stderr] 1011 | | let donor_id: u32 = store.open_freebies.get(&consumer_id).unwrap().get(bidx).unwrap().get_donor(); [INFO] [stderr] ... | [INFO] [stderr] 1101 | | None => (), [INFO] [stderr] 1102 | | } [INFO] [stderr] | |_________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 1008 | if let Some(bidx) = budget_freeby_idx { [INFO] [stderr] 1009 | let max_budget : u64 = store.open_freebies.get(&consumer_id).unwrap().get(bidx).unwrap().get_budget_cents_left(); [INFO] [stderr] 1010 | let donor_id: u32 = store.open_freebies.get(&consumer_id).unwrap().get(bidx).unwrap().get_donor(); [INFO] [stderr] 1011 | let donor: User = store.users.get(&donor_id).unwrap().clone(); [INFO] [stderr] 1012 | let item_cost : u64 = item.cost_cents as u64; [INFO] [stderr] 1013 | let taken_budget : u64 = cmp::min(max_budget, cmp::max(0u64, item_cost)); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_event_shop.rs:1010:72 [INFO] [stderr] | [INFO] [stderr] 1010 | let max_budget : u64 = store.open_freebies.get(&consumer_id).unwrap().get(bidx).unwrap().get_budget_cents_left(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&store.open_freebies[&consumer_id]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_event_shop.rs:1011:69 [INFO] [stderr] | [INFO] [stderr] 1011 | let donor_id: u32 = store.open_freebies.get(&consumer_id).unwrap().get(bidx).unwrap().get_donor(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&store.open_freebies[&consumer_id]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_event_shop.rs:1012:67 [INFO] [stderr] | [INFO] [stderr] 1012 | let donor: User = store.users.get(&donor_id).unwrap().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&store.users[&donor_id]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/rustix_event_shop.rs:1013:71 [INFO] [stderr] | [INFO] [stderr] 1013 | let item_cost : u64 = item.cost_cents as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(item.cost_cents)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/rustix_event_shop.rs:1026:53 [INFO] [stderr] | [INFO] [stderr] 1026 | / if !bill.finalized_data.user_consumption.contains_key(&consumer_id) { [INFO] [stderr] 1027 | | bill.finalized_data.user_consumption.insert(consumer_id, BillUserInstance { [INFO] [stderr] 1028 | | user_id: consumer_id, [INFO] [stderr] 1029 | | per_day: HashMap::new(), [INFO] [stderr] 1030 | | }); [INFO] [stderr] 1031 | | } [INFO] [stderr] | |_____________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] help: consider using [INFO] [stderr] | [INFO] [stderr] 1026 | bill.finalized_data.user_consumption.entry(consumer_id).or_insert(BillUserInstance { [INFO] [stderr] 1027 | user_id: consumer_id, [INFO] [stderr] 1028 | per_day: HashMap::new(), [INFO] [stderr] 1029 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/rustix_event_shop.rs:1032:53 [INFO] [stderr] | [INFO] [stderr] 1032 | / if !bill.finalized_data.user_consumption.get(&consumer_id).unwrap().per_day.contains_key(&day_idx) { [INFO] [stderr] 1033 | | bill.finalized_data.user_consumption.get_mut(&consumer_id).unwrap().per_day.insert(day_idx, BillUserDayInstance { [INFO] [stderr] 1034 | | personally_consumed: HashMap::new(), [INFO] [stderr] 1035 | | specials_consumed: Vec::new(), [INFO] [stderr] ... | [INFO] [stderr] 1038 | | }); [INFO] [stderr] 1039 | | } [INFO] [stderr] | |_________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] help: consider using [INFO] [stderr] | [INFO] [stderr] 1032 | bill.finalized_data.user_consumption.get(&consumer_id).unwrap().per_day.entry(day_idx).or_insert(BillUserDayInstance { [INFO] [stderr] 1033 | personally_consumed: HashMap::new(), [INFO] [stderr] 1034 | specials_consumed: Vec::new(), [INFO] [stderr] 1035 | ffa_giveouts: HashMap::new(), [INFO] [stderr] 1036 | giveouts_to_user_id: HashMap::new(), [INFO] [stderr] 1037 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_event_shop.rs:1032:57 [INFO] [stderr] | [INFO] [stderr] 1032 | if !bill.finalized_data.user_consumption.get(&consumer_id).unwrap().per_day.contains_key(&day_idx) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&bill.finalized_data.user_consumption[&consumer_id]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/rustix_event_shop.rs:1041:49 [INFO] [stderr] | [INFO] [stderr] 1041 | / if !bill.finalized_data.user_consumption.get(&consumer_id).unwrap().per_day.get(&day_idx).unwrap().giveouts_to_user_id.contains_key(&donor_id) { [INFO] [stderr] 1042 | | bill.finalized_data.user_consumption.get_mut(&consumer_id).unwrap().per_day.get_mut(&day_idx).unwrap().giveouts_to_user_id.insert(donor_id, PaidFor { [INFO] [stderr] 1043 | | recipient_id: donor_id, [INFO] [stderr] 1044 | | count_giveouts_used: HashMap::new(), [INFO] [stderr] ... | [INFO] [stderr] 1047 | | }); [INFO] [stderr] 1048 | | } [INFO] [stderr] | |_________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] help: consider using [INFO] [stderr] | [INFO] [stderr] 1041 | bill.finalized_data.user_consumption.get(&consumer_id).unwrap().per_day.get(&day_idx).unwrap().giveouts_to_user_id.entry(donor_id).or_insert(PaidFor { [INFO] [stderr] 1042 | recipient_id: donor_id, [INFO] [stderr] 1043 | count_giveouts_used: HashMap::new(), [INFO] [stderr] 1044 | budget_given: 0, [INFO] [stderr] 1045 | budget_gotten: 0, [INFO] [stderr] 1046 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_event_shop.rs:1041:53 [INFO] [stderr] | [INFO] [stderr] 1041 | if !bill.finalized_data.user_consumption.get(&consumer_id).unwrap().per_day.get(&day_idx).unwrap().giveouts_to_user_id.contains_key(&donor_id) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&bill.finalized_data.user_consumption.get(&consumer_id).unwrap().per_day[&day_idx]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_event_shop.rs:1041:53 [INFO] [stderr] | [INFO] [stderr] 1041 | if !bill.finalized_data.user_consumption.get(&consumer_id).unwrap().per_day.get(&day_idx).unwrap().giveouts_to_user_id.contains_key(&donor_id) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&bill.finalized_data.user_consumption[&consumer_id]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/rustix_event_shop.rs:1062:53 [INFO] [stderr] | [INFO] [stderr] 1062 | / if !bill.finalized_data.user_consumption.contains_key(&donor_id) { [INFO] [stderr] 1063 | | bill.finalized_data.user_consumption.insert(donor_id, BillUserInstance { [INFO] [stderr] 1064 | | user_id: donor_id, [INFO] [stderr] 1065 | | per_day: HashMap::new(), [INFO] [stderr] 1066 | | }); [INFO] [stderr] 1067 | | } [INFO] [stderr] | |_____________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] help: consider using [INFO] [stderr] | [INFO] [stderr] 1062 | bill.finalized_data.user_consumption.entry(donor_id).or_insert(BillUserInstance { [INFO] [stderr] 1063 | user_id: donor_id, [INFO] [stderr] 1064 | per_day: HashMap::new(), [INFO] [stderr] 1065 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/rustix_event_shop.rs:1068:53 [INFO] [stderr] | [INFO] [stderr] 1068 | / if !bill.finalized_data.user_consumption.get(&donor_id).unwrap().per_day.contains_key(&day_idx) { [INFO] [stderr] 1069 | | bill.finalized_data.user_consumption.get_mut(&donor_id).unwrap().per_day.insert(day_idx, BillUserDayInstance { [INFO] [stderr] 1070 | | personally_consumed: HashMap::new(), [INFO] [stderr] 1071 | | specials_consumed: Vec::new(), [INFO] [stderr] ... | [INFO] [stderr] 1074 | | }); [INFO] [stderr] 1075 | | } [INFO] [stderr] | |_____________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] help: consider using [INFO] [stderr] | [INFO] [stderr] 1068 | bill.finalized_data.user_consumption.get(&donor_id).unwrap().per_day.entry(day_idx).or_insert(BillUserDayInstance { [INFO] [stderr] 1069 | personally_consumed: HashMap::new(), [INFO] [stderr] 1070 | specials_consumed: Vec::new(), [INFO] [stderr] 1071 | ffa_giveouts: HashMap::new(), [INFO] [stderr] 1072 | giveouts_to_user_id: HashMap::new(), [INFO] [stderr] 1073 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_event_shop.rs:1068:57 [INFO] [stderr] | [INFO] [stderr] 1068 | if !bill.finalized_data.user_consumption.get(&donor_id).unwrap().per_day.contains_key(&day_idx) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&bill.finalized_data.user_consumption[&donor_id]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/rustix_event_shop.rs:1077:53 [INFO] [stderr] | [INFO] [stderr] 1077 | / if !bill.finalized_data.user_consumption.get(&donor_id).unwrap().per_day.get(&day_idx).unwrap().giveouts_to_user_id.contains_key(&consumer_id) { [INFO] [stderr] 1078 | | bill.finalized_data.user_consumption.get_mut(&donor_id).unwrap().per_day.get_mut(&day_idx).unwrap().giveouts_to_user_id.insert(consumer_id, PaidFor { [INFO] [stderr] 1079 | | recipient_id: consumer_id, [INFO] [stderr] 1080 | | count_giveouts_used: HashMap::new(), [INFO] [stderr] ... | [INFO] [stderr] 1083 | | }); [INFO] [stderr] 1084 | | } [INFO] [stderr] | |_____________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] help: consider using [INFO] [stderr] | [INFO] [stderr] 1077 | bill.finalized_data.user_consumption.get(&donor_id).unwrap().per_day.get(&day_idx).unwrap().giveouts_to_user_id.entry(consumer_id).or_insert(PaidFor { [INFO] [stderr] 1078 | recipient_id: consumer_id, [INFO] [stderr] 1079 | count_giveouts_used: HashMap::new(), [INFO] [stderr] 1080 | budget_given: 0, [INFO] [stderr] 1081 | budget_gotten: 0, [INFO] [stderr] 1082 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_event_shop.rs:1077:57 [INFO] [stderr] | [INFO] [stderr] 1077 | if !bill.finalized_data.user_consumption.get(&donor_id).unwrap().per_day.get(&day_idx).unwrap().giveouts_to_user_id.contains_key(&consumer_id) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&bill.finalized_data.user_consumption.get(&donor_id).unwrap().per_day[&day_idx]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_event_shop.rs:1077:57 [INFO] [stderr] | [INFO] [stderr] 1077 | if !bill.finalized_data.user_consumption.get(&donor_id).unwrap().per_day.get(&day_idx).unwrap().giveouts_to_user_id.contains_key(&consumer_id) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&bill.finalized_data.user_consumption[&donor_id]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_event_shop.rs:1114:50 [INFO] [stderr] | [INFO] [stderr] 1114 | let item: Item = store.items.get(&item_id).unwrap().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&store.items[&item_id]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get_mut().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rustix_event_shop.rs:1117:59 [INFO] [stderr] | [INFO] [stderr] 1117 | let mut bill: &mut Bill = store.bills.get_mut(bill_idx).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `store.bills[bill_idx]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/rustix_event_shop.rs:1118:33 [INFO] [stderr] | [INFO] [stderr] 1118 | / if !bill.finalized_data.all_users.contains_key(&donor) { [INFO] [stderr] 1119 | | bill.finalized_data.all_users.insert(donor, user.clone()); [INFO] [stderr] 1120 | | bill.finalized_data.user_consumption.insert(donor, BillUserInstance { [INFO] [stderr] 1121 | | user_id: donor, [INFO] [stderr] 1122 | | per_day: HashMap::new(), [INFO] [stderr] 1123 | | }); [INFO] [stderr] 1124 | | } [INFO] [stderr] | |_________________________________^ help: consider using: `bill.finalized_data.all_users.entry(donor)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/rustix_event_shop.rs:1126:33 [INFO] [stderr] | [INFO] [stderr] 1126 | / if !bill.finalized_data.all_items.contains_key(&item_id) { [INFO] [stderr] 1127 | | bill.finalized_data.all_items.insert(item_id, item.clone()); [INFO] [stderr] 1128 | | } [INFO] [stderr] | |_________________________________^ help: consider using: `bill.finalized_data.all_items.entry(item_id).or_insert(item.clone())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/rustix_event_shop.rs:1131:33 [INFO] [stderr] | [INFO] [stderr] 1131 | / if !bill.finalized_data.user_consumption[&donor].per_day.contains_key(&day_idx) { [INFO] [stderr] 1132 | | bill.finalized_data.user_consumption.get_mut(&donor).unwrap().per_day.insert(day_idx, BillUserDayInstance { [INFO] [stderr] 1133 | | personally_consumed: HashMap::new(), [INFO] [stderr] 1134 | | specials_consumed: Vec::new(), [INFO] [stderr] ... | [INFO] [stderr] 1137 | | }); [INFO] [stderr] 1138 | | } [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] help: consider using [INFO] [stderr] | [INFO] [stderr] 1131 | bill.finalized_data.user_consumption[&donor].per_day.entry(day_idx).or_insert(BillUserDayInstance { [INFO] [stderr] 1132 | personally_consumed: HashMap::new(), [INFO] [stderr] 1133 | specials_consumed: Vec::new(), [INFO] [stderr] 1134 | ffa_giveouts: HashMap::new(), [INFO] [stderr] 1135 | giveouts_to_user_id: HashMap::new(), [INFO] [stderr] 1136 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/rustix_event_shop.rs:1172:17 [INFO] [stderr] | [INFO] [stderr] 1172 | / match x { [INFO] [stderr] 1173 | | &mut Purchase::SpecialPurchase{ [INFO] [stderr] 1174 | | ref unique_id, [INFO] [stderr] 1175 | | ref timestamp_epoch_millis, [INFO] [stderr] ... | [INFO] [stderr] 1183 | | _ => return false, [INFO] [stderr] 1184 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 1172 | match *x { [INFO] [stderr] 1173 | Purchase::SpecialPurchase{ [INFO] [stderr] 1174 | ref unique_id, [INFO] [stderr] 1175 | ref timestamp_epoch_millis, [INFO] [stderr] 1176 | ref special_name, [INFO] [stderr] 1177 | ref mut specialcost, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:99:21 [INFO] [stderr] | [INFO] [stderr] 99 | backend.datastore.users.get(&0u32).unwrap().username, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&backend.datastore.users[&0u32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:112:13 [INFO] [stderr] | [INFO] [stderr] 112 | b.datastore.users.get(&0u32).unwrap().username, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&b.datastore.users[&0u32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rustix-bl`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "77e096e0b3d33b1de006c0a992085b441d7f7be6b15383d8f548e6f2c08810a5"` [INFO] running `"docker" "rm" "-f" "77e096e0b3d33b1de006c0a992085b441d7f7be6b15383d8f548e6f2c08810a5"` [INFO] [stdout] 77e096e0b3d33b1de006c0a992085b441d7f7be6b15383d8f548e6f2c08810a5