[INFO] crate rustiful-derive 0.1.0 is already in cache [INFO] extracting crate rustiful-derive 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/rustiful-derive/0.1.0 [INFO] extracting crate rustiful-derive 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rustiful-derive/0.1.0 [INFO] validating manifest of rustiful-derive-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rustiful-derive-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rustiful-derive-0.1.0 [INFO] finished frobbing rustiful-derive-0.1.0 [INFO] frobbed toml for rustiful-derive-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/rustiful-derive/0.1.0/Cargo.toml [INFO] started frobbing rustiful-derive-0.1.0 [INFO] finished frobbing rustiful-derive-0.1.0 [INFO] frobbed toml for rustiful-derive-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rustiful-derive/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rustiful-derive-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rustiful-derive/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e731eb3ded184ada1fcf1cc8c7216944d14fb4db6dde6abbbb37e58d19caecb6 [INFO] running `"docker" "start" "-a" "e731eb3ded184ada1fcf1cc8c7216944d14fb4db6dde6abbbb37e58d19caecb6"` [INFO] [stderr] Compiling autoimpl-derive v0.1.0 [INFO] [stderr] Checking Inflector v0.10.1 [INFO] [stderr] Checking autoimpl v0.1.0 [INFO] [stderr] Checking rustiful v0.1.0 [INFO] [stderr] Checking rustiful-derive v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/util.rs:30:25 [INFO] [stderr] | [INFO] [stderr] 30 | ident: ident, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `ident` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/util.rs:30:25 [INFO] [stderr] | [INFO] [stderr] 30 | ident: ident, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `ident` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/util.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | return (json_api_id, attrs); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(json_api_id, attrs)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/util.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | return (json_api_id, attrs); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(json_api_id, attrs)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/params.rs:135:50 [INFO] [stderr] | [INFO] [stderr] 135 | let serde_struct_rename_attr: Vec<_> = attrs.into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/params.rs:135:50 [INFO] [stderr] | [INFO] [stderr] 135 | let serde_struct_rename_attr: Vec<_> = attrs.into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 12.93s [INFO] running `"docker" "inspect" "e731eb3ded184ada1fcf1cc8c7216944d14fb4db6dde6abbbb37e58d19caecb6"` [INFO] running `"docker" "rm" "-f" "e731eb3ded184ada1fcf1cc8c7216944d14fb4db6dde6abbbb37e58d19caecb6"` [INFO] [stdout] e731eb3ded184ada1fcf1cc8c7216944d14fb4db6dde6abbbb37e58d19caecb6