[INFO] crate rustiff 0.1.2 is already in cache [INFO] extracting crate rustiff 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/rustiff/0.1.2 [INFO] extracting crate rustiff 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rustiff/0.1.2 [INFO] validating manifest of rustiff-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rustiff-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rustiff-0.1.2 [INFO] finished frobbing rustiff-0.1.2 [INFO] frobbed toml for rustiff-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/rustiff/0.1.2/Cargo.toml [INFO] started frobbing rustiff-0.1.2 [INFO] finished frobbing rustiff-0.1.2 [INFO] frobbed toml for rustiff-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rustiff/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rustiff-0.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rustiff/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7a390a1b7f769699062c0d3dc4817953e1c829af8543ac20d84af3fcbb13fabe [INFO] running `"docker" "start" "-a" "7a390a1b7f769699062c0d3dc4817953e1c829af8543ac20d84af3fcbb13fabe"` [INFO] [stderr] Checking rustiff v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decode.rs:109:13 [INFO] [stderr] | [INFO] [stderr] 109 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decode.rs:111:13 [INFO] [stderr] | [INFO] [stderr] 111 | reader: reader, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decode.rs:112:13 [INFO] [stderr] | [INFO] [stderr] 112 | endian: endian, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `endian` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ifd.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | datatype: datatype, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `datatype` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ifd.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | count: count, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ifd.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | offset: offset, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image.rs:144:17 [INFO] [stderr] | [INFO] [stderr] 144 | bits_per_sample: bits_per_sample, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bits_per_sample` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image.rs:149:13 [INFO] [stderr] | [INFO] [stderr] 149 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image.rs:150:13 [INFO] [stderr] | [INFO] [stderr] 150 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image.rs:151:13 [INFO] [stderr] | [INFO] [stderr] 151 | compression: compression, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `compression` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image.rs:153:13 [INFO] [stderr] | [INFO] [stderr] 153 | bits_per_sample: bits_per_sample, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bits_per_sample` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image.rs:195:13 [INFO] [stderr] | [INFO] [stderr] 195 | header: header, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image.rs:196:13 [INFO] [stderr] | [INFO] [stderr] 196 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decode.rs:109:13 [INFO] [stderr] | [INFO] [stderr] 109 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decode.rs:111:13 [INFO] [stderr] | [INFO] [stderr] 111 | reader: reader, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decode.rs:112:13 [INFO] [stderr] | [INFO] [stderr] 112 | endian: endian, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `endian` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ifd.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | datatype: datatype, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `datatype` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ifd.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | count: count, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ifd.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | offset: offset, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image.rs:144:17 [INFO] [stderr] | [INFO] [stderr] 144 | bits_per_sample: bits_per_sample, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bits_per_sample` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image.rs:149:13 [INFO] [stderr] | [INFO] [stderr] 149 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image.rs:150:13 [INFO] [stderr] | [INFO] [stderr] 150 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image.rs:151:13 [INFO] [stderr] | [INFO] [stderr] 151 | compression: compression, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `compression` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image.rs:153:13 [INFO] [stderr] | [INFO] [stderr] 153 | bits_per_sample: bits_per_sample, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bits_per_sample` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image.rs:195:13 [INFO] [stderr] | [INFO] [stderr] 195 | header: header, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image.rs:196:13 [INFO] [stderr] | [INFO] [stderr] 196 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/error.rs:112:47 [INFO] [stderr] | [INFO] [stderr] 112 | data: err.values().iter().map(|x| *x as u32).collect::<_>() [INFO] [stderr] | ^^^^^^^^^ help: try: `u32::from(*x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/byte.rs:52:9 [INFO] [stderr] | [INFO] [stderr] 52 | let _ = self.read_exact(&mut val)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/byte.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | let _ = self.read_exact(&mut val)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/decode.rs:91:16 [INFO] [stderr] | [INFO] [stderr] 91 | if let Err(_) = reader.read_exact(&mut byte_order) { [INFO] [stderr] | _________- ^^^^^^ [INFO] [stderr] 92 | | return Err(DecodeError::from(DecodeErrorKind::NoByteOrder)); [INFO] [stderr] 93 | | } [INFO] [stderr] | |_________- help: try this: `if reader.read_exact(&mut byte_order).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/decode.rs:133:22 [INFO] [stderr] | [INFO] [stderr] 133 | ifd.get(tag).ok_or(DecodeError::from(DecodeErrorKind::CannotFindTheTag{ tag: AnyTag::from(tag) })) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| DecodeError::from(DecodeErrorKind::CannotFindTheTag{ tag: AnyTag::from(tag) }))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/decode.rs:142:26 [INFO] [stderr] | [INFO] [stderr] 142 | self.reader.goto(from as u64)?; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(from)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/error.rs:112:47 [INFO] [stderr] | [INFO] [stderr] 112 | data: err.values().iter().map(|x| *x as u32).collect::<_>() [INFO] [stderr] | ^^^^^^^^^ help: try: `u32::from(*x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/byte.rs:52:9 [INFO] [stderr] | [INFO] [stderr] 52 | let _ = self.read_exact(&mut val)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/byte.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | let _ = self.read_exact(&mut val)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/decode.rs:91:16 [INFO] [stderr] | [INFO] [stderr] 91 | if let Err(_) = reader.read_exact(&mut byte_order) { [INFO] [stderr] | _________- ^^^^^^ [INFO] [stderr] 92 | | return Err(DecodeError::from(DecodeErrorKind::NoByteOrder)); [INFO] [stderr] 93 | | } [INFO] [stderr] | |_________- help: try this: `if reader.read_exact(&mut byte_order).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/decode.rs:133:22 [INFO] [stderr] | [INFO] [stderr] 133 | ifd.get(tag).ok_or(DecodeError::from(DecodeErrorKind::CannotFindTheTag{ tag: AnyTag::from(tag) })) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| DecodeError::from(DecodeErrorKind::CannotFindTheTag{ tag: AnyTag::from(tag) }))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/decode.rs:142:26 [INFO] [stderr] | [INFO] [stderr] 142 | self.reader.goto(from as u64)?; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(from)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: Matching on `Some` with `ok()` is redundant [INFO] [stderr] --> src/decode.rs:210:9 [INFO] [stderr] | [INFO] [stderr] 210 | / if let Some((ifd, next)) = self.read_ifd(next).ok() { [INFO] [stderr] 211 | | self.next = next; [INFO] [stderr] 212 | | [INFO] [stderr] 213 | | Some(ifd) [INFO] [stderr] 214 | | } else { [INFO] [stderr] 215 | | None [INFO] [stderr] 216 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::if_let_some_result)] on by default [INFO] [stderr] = help: Consider matching on `Ok((ifd, next))` and removing the call to `ok` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_let_some_result [INFO] [stderr] [INFO] [stderr] warning: Matching on `Some` with `ok()` is redundant [INFO] [stderr] --> src/decode.rs:210:9 [INFO] [stderr] | [INFO] [stderr] 210 | / if let Some((ifd, next)) = self.read_ifd(next).ok() { [INFO] [stderr] 211 | | self.next = next; [INFO] [stderr] 212 | | [INFO] [stderr] 213 | | Some(ifd) [INFO] [stderr] 214 | | } else { [INFO] [stderr] 215 | | None [INFO] [stderr] 216 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::if_let_some_result)] on by default [INFO] [stderr] = help: Consider matching on `Ok((ifd, next))` and removing the call to `ok` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_let_some_result [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `ifd::IFD` [INFO] [stderr] --> src/ifd.rs:72:5 [INFO] [stderr] | [INFO] [stderr] 72 | / pub fn new() -> IFD { [INFO] [stderr] 73 | | IFD(HashMap::new()) [INFO] [stderr] 74 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 69 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `ifd::IFD` [INFO] [stderr] --> src/ifd.rs:72:5 [INFO] [stderr] | [INFO] [stderr] 72 | / pub fn new() -> IFD { [INFO] [stderr] 73 | | IFD(HashMap::new()) [INFO] [stderr] 74 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 69 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/image.rs:33:120 [INFO] [stderr] | [INFO] [stderr] 33 | n => Err(DecodeError::from(DecodeErrorKind::UnsupportedData{ tag: AnyTag::PhotometricInterpretation, data: n as u32 })), [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/image.rs:49:106 [INFO] [stderr] | [INFO] [stderr] 49 | n => Err(DecodeError::from(DecodeErrorKind::UnsupportedData{ tag: AnyTag::Compression, data: n as u32 })), [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/image.rs:33:120 [INFO] [stderr] | [INFO] [stderr] 33 | n => Err(DecodeError::from(DecodeErrorKind::UnsupportedData{ tag: AnyTag::PhotometricInterpretation, data: n as u32 })), [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/image.rs:49:106 [INFO] [stderr] | [INFO] [stderr] 49 | n => Err(DecodeError::from(DecodeErrorKind::UnsupportedData{ tag: AnyTag::Compression, data: n as u32 })), [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: item `image::BitsPerSample` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/image.rs:79:1 [INFO] [stderr] | [INFO] [stderr] 79 | / impl BitsPerSample { [INFO] [stderr] 80 | | pub fn new>(values: T) -> Result { [INFO] [stderr] 81 | | match values.as_ref() { [INFO] [stderr] 82 | | [8] => Ok(BitsPerSample::U8_1), [INFO] [stderr] ... | [INFO] [stderr] 115 | | } [INFO] [stderr] 116 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/image.rs:92:16 [INFO] [stderr] | [INFO] [stderr] 92 | pub fn len(&self) -> usize { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/image.rs:100:22 [INFO] [stderr] | [INFO] [stderr] 100 | pub fn max_value(&self) -> u16 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/image.rs:101:17 [INFO] [stderr] | [INFO] [stderr] 101 | let x = u8::max_value() as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(u8::max_value())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: item `image::BitsPerSample` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/image.rs:79:1 [INFO] [stderr] | [INFO] [stderr] 79 | / impl BitsPerSample { [INFO] [stderr] 80 | | pub fn new>(values: T) -> Result { [INFO] [stderr] 81 | | match values.as_ref() { [INFO] [stderr] 82 | | [8] => Ok(BitsPerSample::U8_1), [INFO] [stderr] ... | [INFO] [stderr] 115 | | } [INFO] [stderr] 116 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/image.rs:110:17 [INFO] [stderr] | [INFO] [stderr] 110 | pub fn bits(&self) -> usize { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/image.rs:92:16 [INFO] [stderr] | [INFO] [stderr] 92 | pub fn len(&self) -> usize { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/image.rs:100:22 [INFO] [stderr] | [INFO] [stderr] 100 | pub fn max_value(&self) -> u16 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/image.rs:101:17 [INFO] [stderr] | [INFO] [stderr] 101 | let x = u8::max_value() as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(u8::max_value())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/image.rs:110:17 [INFO] [stderr] | [INFO] [stderr] 110 | pub fn bits(&self) -> usize { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/tag.rs:94:57 [INFO] [stderr] | [INFO] [stderr] 94 | DataType::Short if count == 1 => Ok(offset.read_u16(endian)? as u32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(offset.read_u16(endian)?)` [INFO] [stderr] ... [INFO] [stderr] 205 | / tag_short_or_long_value! { [INFO] [stderr] 206 | | ImageWidth, 256, None; [INFO] [stderr] 207 | | ImageLength, 257, None; [INFO] [stderr] 208 | | RowsPerStrip, 278, Some(u32::max_value()); [INFO] [stderr] 209 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/tag.rs:94:57 [INFO] [stderr] | [INFO] [stderr] 94 | DataType::Short if count == 1 => Ok(offset.read_u16(endian)? as u32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(offset.read_u16(endian)?)` [INFO] [stderr] ... [INFO] [stderr] 205 | / tag_short_or_long_value! { [INFO] [stderr] 206 | | ImageWidth, 256, None; [INFO] [stderr] 207 | | ImageLength, 257, None; [INFO] [stderr] 208 | | RowsPerStrip, 278, Some(u32::max_value()); [INFO] [stderr] 209 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/tag.rs:129:62 [INFO] [stderr] | [INFO] [stderr] 129 | DataType::Short if count == 1 => Ok(vec![offset.read_u16(endian)? as u32]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(offset.read_u16(endian)?)` [INFO] [stderr] ... [INFO] [stderr] 211 | / tag_short_or_long_values! { [INFO] [stderr] 212 | | StripOffsets, 273, None; [INFO] [stderr] 213 | | StripByteCounts, 279, None; [INFO] [stderr] 214 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/tag.rs:131:25 [INFO] [stderr] | [INFO] [stderr] 131 | offset.read_u16(endian)? as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(offset.read_u16(endian)?)` [INFO] [stderr] ... [INFO] [stderr] 211 | / tag_short_or_long_values! { [INFO] [stderr] 212 | | StripOffsets, 273, None; [INFO] [stderr] 213 | | StripByteCounts, 279, None; [INFO] [stderr] 214 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/tag.rs:132:25 [INFO] [stderr] | [INFO] [stderr] 132 | offset.read_u16(endian)? as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(offset.read_u16(endian)?)` [INFO] [stderr] ... [INFO] [stderr] 211 | / tag_short_or_long_values! { [INFO] [stderr] 212 | | StripOffsets, 273, None; [INFO] [stderr] 213 | | StripByteCounts, 279, None; [INFO] [stderr] 214 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/tag.rs:135:38 [INFO] [stderr] | [INFO] [stderr] 135 | let offset = offset.read_u32(endian)? as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(offset.read_u32(endian)?)` [INFO] [stderr] ... [INFO] [stderr] 211 | / tag_short_or_long_values! { [INFO] [stderr] 212 | | StripOffsets, 273, None; [INFO] [stderr] 213 | | StripByteCounts, 279, None; [INFO] [stderr] 214 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/tag.rs:139:36 [INFO] [stderr] | [INFO] [stderr] 139 | v.push(reader.read_u16(endian)? as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(reader.read_u16(endian)?)` [INFO] [stderr] ... [INFO] [stderr] 211 | / tag_short_or_long_values! { [INFO] [stderr] 212 | | StripOffsets, 273, None; [INFO] [stderr] 213 | | StripByteCounts, 279, None; [INFO] [stderr] 214 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/tag.rs:146:38 [INFO] [stderr] | [INFO] [stderr] 146 | let offset = offset.read_u32(endian)? as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(offset.read_u32(endian)?)` [INFO] [stderr] ... [INFO] [stderr] 211 | / tag_short_or_long_values! { [INFO] [stderr] 212 | | StripOffsets, 273, None; [INFO] [stderr] 213 | | StripByteCounts, 279, None; [INFO] [stderr] 214 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/tag.rs:129:62 [INFO] [stderr] | [INFO] [stderr] 129 | DataType::Short if count == 1 => Ok(vec![offset.read_u16(endian)? as u32]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(offset.read_u16(endian)?)` [INFO] [stderr] ... [INFO] [stderr] 211 | / tag_short_or_long_values! { [INFO] [stderr] 212 | | StripOffsets, 273, None; [INFO] [stderr] 213 | | StripByteCounts, 279, None; [INFO] [stderr] 214 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/tag.rs:131:25 [INFO] [stderr] | [INFO] [stderr] 131 | offset.read_u16(endian)? as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(offset.read_u16(endian)?)` [INFO] [stderr] ... [INFO] [stderr] 211 | / tag_short_or_long_values! { [INFO] [stderr] 212 | | StripOffsets, 273, None; [INFO] [stderr] 213 | | StripByteCounts, 279, None; [INFO] [stderr] 214 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/tag.rs:132:25 [INFO] [stderr] | [INFO] [stderr] 132 | offset.read_u16(endian)? as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(offset.read_u16(endian)?)` [INFO] [stderr] ... [INFO] [stderr] 211 | / tag_short_or_long_values! { [INFO] [stderr] 212 | | StripOffsets, 273, None; [INFO] [stderr] 213 | | StripByteCounts, 279, None; [INFO] [stderr] 214 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/tag.rs:135:38 [INFO] [stderr] | [INFO] [stderr] 135 | let offset = offset.read_u32(endian)? as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(offset.read_u32(endian)?)` [INFO] [stderr] ... [INFO] [stderr] 211 | / tag_short_or_long_values! { [INFO] [stderr] 212 | | StripOffsets, 273, None; [INFO] [stderr] 213 | | StripByteCounts, 279, None; [INFO] [stderr] 214 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/tag.rs:139:36 [INFO] [stderr] | [INFO] [stderr] 139 | v.push(reader.read_u16(endian)? as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(reader.read_u16(endian)?)` [INFO] [stderr] ... [INFO] [stderr] 211 | / tag_short_or_long_values! { [INFO] [stderr] 212 | | StripOffsets, 273, None; [INFO] [stderr] 213 | | StripByteCounts, 279, None; [INFO] [stderr] 214 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/tag.rs:146:38 [INFO] [stderr] | [INFO] [stderr] 146 | let offset = offset.read_u32(endian)? as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(offset.read_u32(endian)?)` [INFO] [stderr] ... [INFO] [stderr] 211 | / tag_short_or_long_values! { [INFO] [stderr] 212 | | StripOffsets, 273, None; [INFO] [stderr] 213 | | StripByteCounts, 279, None; [INFO] [stderr] 214 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/tag.rs:177:38 [INFO] [stderr] | [INFO] [stderr] 177 | let offset = offset.read_u32(endian)? as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(offset.read_u32(endian)?)` [INFO] [stderr] ... [INFO] [stderr] 222 | / tag_short_values! { [INFO] [stderr] 223 | | BitsPerSample, 258, Some(vec![1]); [INFO] [stderr] 224 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/tag.rs:177:38 [INFO] [stderr] | [INFO] [stderr] 177 | let offset = offset.read_u32(endian)? as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(offset.read_u32(endian)?)` [INFO] [stderr] ... [INFO] [stderr] 222 | / tag_short_values! { [INFO] [stderr] 223 | | BitsPerSample, 258, Some(vec![1]); [INFO] [stderr] 224 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.63s [INFO] running `"docker" "inspect" "7a390a1b7f769699062c0d3dc4817953e1c829af8543ac20d84af3fcbb13fabe"` [INFO] running `"docker" "rm" "-f" "7a390a1b7f769699062c0d3dc4817953e1c829af8543ac20d84af3fcbb13fabe"` [INFO] [stdout] 7a390a1b7f769699062c0d3dc4817953e1c829af8543ac20d84af3fcbb13fabe