[INFO] crate rusticata-macros 1.1.0 is already in cache [INFO] extracting crate rusticata-macros 1.1.0 into work/ex/clippy-test-run/sources/stable/reg/rusticata-macros/1.1.0 [INFO] extracting crate rusticata-macros 1.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rusticata-macros/1.1.0 [INFO] validating manifest of rusticata-macros-1.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rusticata-macros-1.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rusticata-macros-1.1.0 [INFO] finished frobbing rusticata-macros-1.1.0 [INFO] frobbed toml for rusticata-macros-1.1.0 written to work/ex/clippy-test-run/sources/stable/reg/rusticata-macros/1.1.0/Cargo.toml [INFO] started frobbing rusticata-macros-1.1.0 [INFO] finished frobbing rusticata-macros-1.1.0 [INFO] frobbed toml for rusticata-macros-1.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rusticata-macros/1.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rusticata-macros-1.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rusticata-macros/1.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c3575b96f5f5b477a88d5b8326c4a38c59dbdd1aa31ceca3cfc5343ea87c70ff [INFO] running `"docker" "start" "-a" "c3575b96f5f5b477a88d5b8326c4a38c59dbdd1aa31ceca3cfc5343ea87c70ff"` [INFO] [stderr] Checking memchr v2.1.3 [INFO] [stderr] Checking nom v4.1.1 [INFO] [stderr] Checking rusticata-macros v1.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/macros.rs:117:8 [INFO] [stderr] | [INFO] [stderr] 117 | if s.len() == 0 { return Err("empty"); }; [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `s.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/macros.rs:121:18 [INFO] [stderr] | [INFO] [stderr] 121 | u = u1 | (c as u64); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(c)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/macros.rs:117:8 [INFO] [stderr] | [INFO] [stderr] 117 | if s.len() == 0 { return Err("empty"); }; [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `s.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/macros.rs:121:18 [INFO] [stderr] | [INFO] [stderr] 121 | u = u1 | (c as u64); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(c)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/macros.rs:180:5 [INFO] [stderr] | [INFO] [stderr] 180 | / match res { [INFO] [stderr] 181 | | Ok((rem, _)) => { [INFO] [stderr] 182 | | let res2 = be_u8(rem); [INFO] [stderr] 183 | | assert_eq!(res2, Ok((empty,5))); [INFO] [stderr] 184 | | }, [INFO] [stderr] 185 | | _ => (), [INFO] [stderr] 186 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 180 | if let Ok((rem, _)) = res { [INFO] [stderr] 181 | let res2 = be_u8(rem); [INFO] [stderr] 182 | assert_eq!(res2, Ok((empty,5))); [INFO] [stderr] 183 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> benches/bench.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #![feature(test)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error: Could not compile `rusticata-macros`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "c3575b96f5f5b477a88d5b8326c4a38c59dbdd1aa31ceca3cfc5343ea87c70ff"` [INFO] running `"docker" "rm" "-f" "c3575b96f5f5b477a88d5b8326c4a38c59dbdd1aa31ceca3cfc5343ea87c70ff"` [INFO] [stdout] c3575b96f5f5b477a88d5b8326c4a38c59dbdd1aa31ceca3cfc5343ea87c70ff