[INFO] crate rustfmt 0.10.0 is already in cache [INFO] extracting crate rustfmt 0.10.0 into work/ex/clippy-test-run/sources/stable/reg/rustfmt/0.10.0 [INFO] extracting crate rustfmt 0.10.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rustfmt/0.10.0 [INFO] validating manifest of rustfmt-0.10.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rustfmt-0.10.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rustfmt-0.10.0 [INFO] finished frobbing rustfmt-0.10.0 [INFO] frobbed toml for rustfmt-0.10.0 written to work/ex/clippy-test-run/sources/stable/reg/rustfmt/0.10.0/Cargo.toml [INFO] started frobbing rustfmt-0.10.0 [INFO] finished frobbing rustfmt-0.10.0 [INFO] frobbed toml for rustfmt-0.10.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rustfmt/0.10.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rustfmt-0.10.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rustfmt/0.10.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 108f816b21b8da6f9805364d9d074a4fb505e6d98a40dc668a4f2bba7d36a94b [INFO] running `"docker" "start" "-a" "108f816b21b8da6f9805364d9d074a4fb505e6d98a40dc668a4f2bba7d36a94b"` [INFO] [stderr] warning: Pattern matching for Cargo's include/exclude fields is changing and file `src/bin/cargo-fmt.rs` WILL NOT be included in a future Cargo version. [INFO] [stderr] See https://github.com/rust-lang/cargo/issues/4268 for more info [INFO] [stderr] warning: Pattern matching for Cargo's include/exclude fields is changing and file `src/bin/rustfmt.rs` WILL NOT be included in a future Cargo version. [INFO] [stderr] See https://github.com/rust-lang/cargo/issues/4268 for more info [INFO] [stderr] Compiling rustfmt v0.10.0 (/opt/crater/workdir) [INFO] [stderr] Checking strings v0.1.1 [INFO] [stderr] Checking toml v0.4.10 [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/filemap.rs:73:29 [INFO] [stderr] | [INFO] [stderr] 73 | '\n' => write!(writer, "\r\n")?, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/file_lines.rs:35:17 [INFO] [stderr] | [INFO] [stderr] 35 | Range { lo: lo, hi: hi } [INFO] [stderr] | ^^^^^^ help: replace it with: `lo` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/file_lines.rs:35:25 [INFO] [stderr] | [INFO] [stderr] 35 | Range { lo: lo, hi: hi } [INFO] [stderr] | ^^^^^^ help: replace it with: `hi` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/visitor.rs:564:13 [INFO] [stderr] | [INFO] [stderr] 564 | parse_session: parse_session, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `parse_session` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/visitor.rs:569:13 [INFO] [stderr] | [INFO] [stderr] 569 | config: config, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `config` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/items.rs:114:13 [INFO] [stderr] | [INFO] [stderr] 114 | abi: abi, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `abi` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/items.rs:120:13 [INFO] [stderr] | [INFO] [stderr] 120 | span: span, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `span` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/items.rs:472:13 [INFO] [stderr] | [INFO] [stderr] 472 | shape: shape, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `shape` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/items.rs:1131:9 [INFO] [stderr] | [INFO] [stderr] 1131 | tactic: tactic, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `tactic` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/items.rs:2264:9 [INFO] [stderr] | [INFO] [stderr] 2264 | tactic: tactic, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `tactic` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/items.rs:2438:9 [INFO] [stderr] | [INFO] [stderr] 2438 | shape: shape, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `shape` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/items.rs:2620:9 [INFO] [stderr] | [INFO] [stderr] 2620 | tactic: tactic, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `tactic` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lists.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | tactic: tactic, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `tactic` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lists.rs:100:9 [INFO] [stderr] | [INFO] [stderr] 100 | shape: shape, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `shape` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lists.rs:102:9 [INFO] [stderr] | [INFO] [stderr] 102 | config: config, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `config` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lists.rs:469:17 [INFO] [stderr] | [INFO] [stderr] 469 | pre_comment: pre_comment, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `pre_comment` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lists.rs:471:17 [INFO] [stderr] | [INFO] [stderr] 471 | post_comment: post_comment, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `post_comment` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lists.rs:472:17 [INFO] [stderr] | [INFO] [stderr] 472 | new_lines: new_lines, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `new_lines` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lists.rs:496:9 [INFO] [stderr] | [INFO] [stderr] 496 | codemap: codemap, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `codemap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lists.rs:498:9 [INFO] [stderr] | [INFO] [stderr] 498 | get_lo: get_lo, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `get_lo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lists.rs:499:9 [INFO] [stderr] | [INFO] [stderr] 499 | get_hi: get_hi, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `get_hi` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lists.rs:500:9 [INFO] [stderr] | [INFO] [stderr] 500 | get_item_string: get_item_string, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `get_item_string` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lists.rs:501:9 [INFO] [stderr] | [INFO] [stderr] 501 | prev_span_end: prev_span_end, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `prev_span_end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lists.rs:502:9 [INFO] [stderr] | [INFO] [stderr] 502 | next_span_start: next_span_start, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `next_span_start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lists.rs:503:9 [INFO] [stderr] | [INFO] [stderr] 503 | terminator: terminator, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `terminator` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lists.rs:623:9 [INFO] [stderr] | [INFO] [stderr] 623 | tactic: tactic, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `tactic` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lists.rs:630:9 [INFO] [stderr] | [INFO] [stderr] 630 | shape: shape, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `shape` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lists.rs:631:9 [INFO] [stderr] | [INFO] [stderr] 631 | ends_with_newline: ends_with_newline, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `ends_with_newline` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expr.rs:520:9 [INFO] [stderr] | [INFO] [stderr] 520 | tactic: tactic, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `tactic` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expr.rs:603:9 [INFO] [stderr] | [INFO] [stderr] 603 | tactic: tactic, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `tactic` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expr.rs:875:13 [INFO] [stderr] | [INFO] [stderr] 875 | block: block, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `block` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expr.rs:876:13 [INFO] [stderr] | [INFO] [stderr] 876 | else_block: else_block, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `else_block` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expr.rs:878:13 [INFO] [stderr] | [INFO] [stderr] 878 | pat: pat, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pat` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expr.rs:885:13 [INFO] [stderr] | [INFO] [stderr] 885 | allow_single_line: allow_single_line, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `allow_single_line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expr.rs:886:13 [INFO] [stderr] | [INFO] [stderr] 886 | nested_if: nested_if, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `nested_if` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expr.rs:887:13 [INFO] [stderr] | [INFO] [stderr] 887 | span: span, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `span` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expr.rs:898:13 [INFO] [stderr] | [INFO] [stderr] 898 | block: block, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `block` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expr.rs:900:13 [INFO] [stderr] | [INFO] [stderr] 900 | label: label, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `label` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expr.rs:907:13 [INFO] [stderr] | [INFO] [stderr] 907 | span: span, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `span` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expr.rs:920:13 [INFO] [stderr] | [INFO] [stderr] 920 | block: block, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `block` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expr.rs:922:13 [INFO] [stderr] | [INFO] [stderr] 922 | label: label, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `label` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expr.rs:923:13 [INFO] [stderr] | [INFO] [stderr] 923 | pat: pat, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pat` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expr.rs:932:13 [INFO] [stderr] | [INFO] [stderr] 932 | span: span, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `span` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expr.rs:945:13 [INFO] [stderr] | [INFO] [stderr] 945 | block: block, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `block` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expr.rs:947:13 [INFO] [stderr] | [INFO] [stderr] 947 | label: label, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `label` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expr.rs:954:13 [INFO] [stderr] | [INFO] [stderr] 954 | span: span, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `span` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expr.rs:1765:9 [INFO] [stderr] | [INFO] [stderr] 1765 | shape: shape, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `shape` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expr.rs:1957:9 [INFO] [stderr] | [INFO] [stderr] 1957 | tactic: tactic, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `tactic` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expr.rs:1966:9 [INFO] [stderr] | [INFO] [stderr] 1966 | shape: shape, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `shape` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/imports.rs:380:9 [INFO] [stderr] | [INFO] [stderr] 380 | tactic: tactic, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `tactic` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/issues.rs:92:13 [INFO] [stderr] | [INFO] [stderr] 92 | report_todo: report_todo, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `report_todo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/issues.rs:93:13 [INFO] [stderr] | [INFO] [stderr] 93 | report_fixme: report_fixme, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `report_fixme` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/issues.rs:170:13 [INFO] [stderr] | [INFO] [stderr] 170 | todo_idx: todo_idx, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `todo_idx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/issues.rs:171:13 [INFO] [stderr] | [INFO] [stderr] 171 | fixme_idx: fixme_idx, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `fixme_idx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/issues.rs:215:13 [INFO] [stderr] | [INFO] [stderr] 215 | part: part, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `part` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/issues.rs:216:13 [INFO] [stderr] | [INFO] [stderr] 216 | issue: issue, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `issue` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/comment.rs:228:9 [INFO] [stderr] | [INFO] [stderr] 228 | line_start: line_start, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `line_start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/comment.rs:232:9 [INFO] [stderr] | [INFO] [stderr] 232 | config: config, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `config` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/comment.rs:650:13 [INFO] [stderr] | [INFO] [stderr] 650 | slice: slice, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `slice` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/comment.rs:777:13 [INFO] [stderr] | [INFO] [stderr] 777 | is_block: is_block, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `is_block` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/comment.rs:891:5 [INFO] [stderr] | [INFO] [stderr] 891 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deprecated_cfg_attr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustfmt_diff.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | line_number: line_number, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `line_number` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/patterns.rs:290:13 [INFO] [stderr] | [INFO] [stderr] 290 | lo: lo, [INFO] [stderr] | ^^^^^^ help: replace it with: `lo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:129:13 [INFO] [stderr] | [INFO] [stderr] 129 | block_indent: block_indent, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `block_indent` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:130:13 [INFO] [stderr] | [INFO] [stderr] 130 | alignment: alignment, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `alignment` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:247:13 [INFO] [stderr] | [INFO] [stderr] 247 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:248:13 [INFO] [stderr] | [INFO] [stderr] 248 | indent: indent, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `indent` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:256:13 [INFO] [stderr] | [INFO] [stderr] 256 | indent: indent, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `indent` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:273:13 [INFO] [stderr] | [INFO] [stderr] 273 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:274:13 [INFO] [stderr] | [INFO] [stderr] 274 | indent: indent, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `indent` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:275:13 [INFO] [stderr] | [INFO] [stderr] 275 | offset: offset, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/lib.rs:423:17 [INFO] [stderr] | [INFO] [stderr] 423 | / write!( [INFO] [stderr] 424 | | fmt, [INFO] [stderr] 425 | | "{} {}:{}: {} {}\n", [INFO] [stderr] 426 | | error.msg_prefix(), [INFO] [stderr] ... | [INFO] [stderr] 430 | | error.msg_suffix() [INFO] [stderr] 431 | | )?; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/filemap.rs:73:29 [INFO] [stderr] | [INFO] [stderr] 73 | '\n' => write!(writer, "\r\n")?, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/file_lines.rs:35:17 [INFO] [stderr] | [INFO] [stderr] 35 | Range { lo: lo, hi: hi } [INFO] [stderr] | ^^^^^^ help: replace it with: `lo` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/file_lines.rs:35:25 [INFO] [stderr] | [INFO] [stderr] 35 | Range { lo: lo, hi: hi } [INFO] [stderr] | ^^^^^^ help: replace it with: `hi` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/visitor.rs:564:13 [INFO] [stderr] | [INFO] [stderr] 564 | parse_session: parse_session, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `parse_session` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/visitor.rs:569:13 [INFO] [stderr] | [INFO] [stderr] 569 | config: config, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `config` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/items.rs:114:13 [INFO] [stderr] | [INFO] [stderr] 114 | abi: abi, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `abi` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/items.rs:120:13 [INFO] [stderr] | [INFO] [stderr] 120 | span: span, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `span` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/items.rs:472:13 [INFO] [stderr] | [INFO] [stderr] 472 | shape: shape, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `shape` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/items.rs:1131:9 [INFO] [stderr] | [INFO] [stderr] 1131 | tactic: tactic, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `tactic` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/items.rs:2264:9 [INFO] [stderr] | [INFO] [stderr] 2264 | tactic: tactic, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `tactic` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/items.rs:2438:9 [INFO] [stderr] | [INFO] [stderr] 2438 | shape: shape, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `shape` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/items.rs:2620:9 [INFO] [stderr] | [INFO] [stderr] 2620 | tactic: tactic, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `tactic` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lists.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | tactic: tactic, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `tactic` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lists.rs:100:9 [INFO] [stderr] | [INFO] [stderr] 100 | shape: shape, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `shape` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lists.rs:102:9 [INFO] [stderr] | [INFO] [stderr] 102 | config: config, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `config` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lists.rs:469:17 [INFO] [stderr] | [INFO] [stderr] 469 | pre_comment: pre_comment, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `pre_comment` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lists.rs:471:17 [INFO] [stderr] | [INFO] [stderr] 471 | post_comment: post_comment, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `post_comment` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lists.rs:472:17 [INFO] [stderr] | [INFO] [stderr] 472 | new_lines: new_lines, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `new_lines` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lists.rs:496:9 [INFO] [stderr] | [INFO] [stderr] 496 | codemap: codemap, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `codemap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lists.rs:498:9 [INFO] [stderr] | [INFO] [stderr] 498 | get_lo: get_lo, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `get_lo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lists.rs:499:9 [INFO] [stderr] | [INFO] [stderr] 499 | get_hi: get_hi, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `get_hi` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lists.rs:500:9 [INFO] [stderr] | [INFO] [stderr] 500 | get_item_string: get_item_string, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `get_item_string` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lists.rs:501:9 [INFO] [stderr] | [INFO] [stderr] 501 | prev_span_end: prev_span_end, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `prev_span_end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lists.rs:502:9 [INFO] [stderr] | [INFO] [stderr] 502 | next_span_start: next_span_start, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `next_span_start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lists.rs:503:9 [INFO] [stderr] | [INFO] [stderr] 503 | terminator: terminator, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `terminator` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lists.rs:623:9 [INFO] [stderr] | [INFO] [stderr] 623 | tactic: tactic, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `tactic` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lists.rs:630:9 [INFO] [stderr] | [INFO] [stderr] 630 | shape: shape, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `shape` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lists.rs:631:9 [INFO] [stderr] | [INFO] [stderr] 631 | ends_with_newline: ends_with_newline, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `ends_with_newline` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expr.rs:520:9 [INFO] [stderr] | [INFO] [stderr] 520 | tactic: tactic, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `tactic` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expr.rs:603:9 [INFO] [stderr] | [INFO] [stderr] 603 | tactic: tactic, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `tactic` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expr.rs:875:13 [INFO] [stderr] | [INFO] [stderr] 875 | block: block, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `block` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expr.rs:876:13 [INFO] [stderr] | [INFO] [stderr] 876 | else_block: else_block, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `else_block` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expr.rs:878:13 [INFO] [stderr] | [INFO] [stderr] 878 | pat: pat, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pat` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expr.rs:885:13 [INFO] [stderr] | [INFO] [stderr] 885 | allow_single_line: allow_single_line, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `allow_single_line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expr.rs:886:13 [INFO] [stderr] | [INFO] [stderr] 886 | nested_if: nested_if, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `nested_if` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expr.rs:887:13 [INFO] [stderr] | [INFO] [stderr] 887 | span: span, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `span` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expr.rs:898:13 [INFO] [stderr] | [INFO] [stderr] 898 | block: block, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `block` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expr.rs:900:13 [INFO] [stderr] | [INFO] [stderr] 900 | label: label, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `label` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expr.rs:907:13 [INFO] [stderr] | [INFO] [stderr] 907 | span: span, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `span` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expr.rs:920:13 [INFO] [stderr] | [INFO] [stderr] 920 | block: block, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `block` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expr.rs:922:13 [INFO] [stderr] | [INFO] [stderr] 922 | label: label, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `label` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expr.rs:923:13 [INFO] [stderr] | [INFO] [stderr] 923 | pat: pat, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pat` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expr.rs:932:13 [INFO] [stderr] | [INFO] [stderr] 932 | span: span, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `span` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expr.rs:945:13 [INFO] [stderr] | [INFO] [stderr] 945 | block: block, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `block` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expr.rs:947:13 [INFO] [stderr] | [INFO] [stderr] 947 | label: label, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `label` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expr.rs:954:13 [INFO] [stderr] | [INFO] [stderr] 954 | span: span, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `span` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expr.rs:1765:9 [INFO] [stderr] | [INFO] [stderr] 1765 | shape: shape, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `shape` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expr.rs:1957:9 [INFO] [stderr] | [INFO] [stderr] 1957 | tactic: tactic, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `tactic` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expr.rs:1966:9 [INFO] [stderr] | [INFO] [stderr] 1966 | shape: shape, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `shape` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/imports.rs:380:9 [INFO] [stderr] | [INFO] [stderr] 380 | tactic: tactic, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `tactic` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/issues.rs:92:13 [INFO] [stderr] | [INFO] [stderr] 92 | report_todo: report_todo, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `report_todo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/issues.rs:93:13 [INFO] [stderr] | [INFO] [stderr] 93 | report_fixme: report_fixme, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `report_fixme` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/issues.rs:170:13 [INFO] [stderr] | [INFO] [stderr] 170 | todo_idx: todo_idx, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `todo_idx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/issues.rs:171:13 [INFO] [stderr] | [INFO] [stderr] 171 | fixme_idx: fixme_idx, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `fixme_idx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/issues.rs:215:13 [INFO] [stderr] | [INFO] [stderr] 215 | part: part, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `part` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/issues.rs:216:13 [INFO] [stderr] | [INFO] [stderr] 216 | issue: issue, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `issue` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/comment.rs:228:9 [INFO] [stderr] | [INFO] [stderr] 228 | line_start: line_start, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `line_start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/comment.rs:232:9 [INFO] [stderr] | [INFO] [stderr] 232 | config: config, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `config` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/comment.rs:650:13 [INFO] [stderr] | [INFO] [stderr] 650 | slice: slice, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `slice` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/comment.rs:777:13 [INFO] [stderr] | [INFO] [stderr] 777 | is_block: is_block, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `is_block` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/comment.rs:891:5 [INFO] [stderr] | [INFO] [stderr] 891 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deprecated_cfg_attr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustfmt_diff.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | line_number: line_number, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `line_number` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/patterns.rs:290:13 [INFO] [stderr] | [INFO] [stderr] 290 | lo: lo, [INFO] [stderr] | ^^^^^^ help: replace it with: `lo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:129:13 [INFO] [stderr] | [INFO] [stderr] 129 | block_indent: block_indent, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `block_indent` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:130:13 [INFO] [stderr] | [INFO] [stderr] 130 | alignment: alignment, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `alignment` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:247:13 [INFO] [stderr] | [INFO] [stderr] 247 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:248:13 [INFO] [stderr] | [INFO] [stderr] 248 | indent: indent, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `indent` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:256:13 [INFO] [stderr] | [INFO] [stderr] 256 | indent: indent, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `indent` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:273:13 [INFO] [stderr] | [INFO] [stderr] 273 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:274:13 [INFO] [stderr] | [INFO] [stderr] 274 | indent: indent, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `indent` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:275:13 [INFO] [stderr] | [INFO] [stderr] 275 | offset: offset, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/lib.rs:423:17 [INFO] [stderr] | [INFO] [stderr] 423 | / write!( [INFO] [stderr] 424 | | fmt, [INFO] [stderr] 425 | | "{} {}:{}: {} {}\n", [INFO] [stderr] 426 | | error.msg_prefix(), [INFO] [stderr] ... | [INFO] [stderr] 430 | | error.msg_suffix() [INFO] [stderr] 431 | | )?; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config.rs:459:32 [INFO] [stderr] | [INFO] [stderr] 459 | const CONFIG_FILE_NAMES: [&'static str; 2] = [".rustfmt.toml", "rustfmt.toml"]; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config.rs:459:32 [INFO] [stderr] | [INFO] [stderr] 459 | const CONFIG_FILE_NAMES: [&'static str; 2] = [".rustfmt.toml", "rustfmt.toml"]; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/items.rs:2115:5 [INFO] [stderr] | [INFO] [stderr] 2115 | return Some((result, force_new_line_for_brace)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some((result, force_new_line_for_brace))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/items.rs:1891:16 [INFO] [stderr] | [INFO] [stderr] 1891 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 1892 | | if context.config.fn_args_paren_newline() { [INFO] [stderr] 1893 | | result.push('\n'); [INFO] [stderr] 1894 | | result.push_str(&arg_indent.to_string(context.config)); [INFO] [stderr] ... | [INFO] [stderr] 1905 | | } [INFO] [stderr] 1906 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 1891 | } else if context.config.fn_args_paren_newline() { [INFO] [stderr] 1892 | result.push('\n'); [INFO] [stderr] 1893 | result.push_str(&arg_indent.to_string(context.config)); [INFO] [stderr] 1894 | if context.config.fn_args_layout() == IndentStyle::Visual { [INFO] [stderr] 1895 | arg_indent = arg_indent + 1; // extra space for `(` [INFO] [stderr] 1896 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/items.rs:2115:5 [INFO] [stderr] | [INFO] [stderr] 2115 | return Some((result, force_new_line_for_brace)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some((result, force_new_line_for_brace))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/items.rs:1891:16 [INFO] [stderr] | [INFO] [stderr] 1891 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 1892 | | if context.config.fn_args_paren_newline() { [INFO] [stderr] 1893 | | result.push('\n'); [INFO] [stderr] 1894 | | result.push_str(&arg_indent.to_string(context.config)); [INFO] [stderr] ... | [INFO] [stderr] 1905 | | } [INFO] [stderr] 1906 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 1891 | } else if context.config.fn_args_paren_newline() { [INFO] [stderr] 1892 | result.push('\n'); [INFO] [stderr] 1893 | result.push_str(&arg_indent.to_string(context.config)); [INFO] [stderr] 1894 | if context.config.fn_args_layout() == IndentStyle::Visual { [INFO] [stderr] 1895 | arg_indent = arg_indent + 1; // extra space for `(` [INFO] [stderr] 1896 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/expr.rs:58:12 [INFO] [stderr] | [INFO] [stderr] 58 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 59 | | if expr_str.contains('\n') || attr_str.contains('\n') || [INFO] [stderr] 60 | | attr_str.len() + expr_str.len() > shape.width [INFO] [stderr] 61 | | { [INFO] [stderr] ... | [INFO] [stderr] 65 | | } [INFO] [stderr] 66 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 58 | } else if expr_str.contains('\n') || attr_str.contains('\n') || [INFO] [stderr] 59 | attr_str.len() + expr_str.len() > shape.width [INFO] [stderr] 60 | { [INFO] [stderr] 61 | format!("\n{}", shape.indent.to_string(context.config)) [INFO] [stderr] 62 | } else { [INFO] [stderr] 63 | String::from(" ") [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/expr.rs:1791:16 [INFO] [stderr] | [INFO] [stderr] 1791 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 1792 | | if line.len() > shape.width + shape.indent.width() { [INFO] [stderr] 1793 | | return true; [INFO] [stderr] 1794 | | } [INFO] [stderr] 1795 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 1791 | } else if line.len() > shape.width + shape.indent.width() { [INFO] [stderr] 1792 | return true; [INFO] [stderr] 1793 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/expr.rs:58:12 [INFO] [stderr] | [INFO] [stderr] 58 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 59 | | if expr_str.contains('\n') || attr_str.contains('\n') || [INFO] [stderr] 60 | | attr_str.len() + expr_str.len() > shape.width [INFO] [stderr] 61 | | { [INFO] [stderr] ... | [INFO] [stderr] 65 | | } [INFO] [stderr] 66 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 58 | } else if expr_str.contains('\n') || attr_str.contains('\n') || [INFO] [stderr] 59 | attr_str.len() + expr_str.len() > shape.width [INFO] [stderr] 60 | { [INFO] [stderr] 61 | format!("\n{}", shape.indent.to_string(context.config)) [INFO] [stderr] 62 | } else { [INFO] [stderr] 63 | String::from(" ") [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/expr.rs:2150:12 [INFO] [stderr] | [INFO] [stderr] 2150 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 2151 | | if subexpr_str.len() + paren_overhead <= shape.width { [INFO] [stderr] 2152 | | Some(paren_wrapper(&subexpr_str)) [INFO] [stderr] 2153 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 2157 | | } [INFO] [stderr] 2158 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 2150 | } else if subexpr_str.len() + paren_overhead <= shape.width { [INFO] [stderr] 2151 | Some(paren_wrapper(&subexpr_str)) [INFO] [stderr] 2152 | } else { [INFO] [stderr] 2153 | let sub_shape = try_opt!(shape.offset_left(2)); [INFO] [stderr] 2154 | let subexpr_str = try_opt!(subexpr.rewrite(context, sub_shape)); [INFO] [stderr] 2155 | Some(paren_wrapper(&subexpr_str)) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/imports.rs:54:12 [INFO] [stderr] | [INFO] [stderr] 54 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 55 | | if b_name_str == "self" { [INFO] [stderr] 56 | | Ordering::Greater [INFO] [stderr] 57 | | } else { [INFO] [stderr] 58 | | a_name_str.cmp(&b_name_str) [INFO] [stderr] 59 | | } [INFO] [stderr] 60 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 54 | } else if b_name_str == "self" { [INFO] [stderr] 55 | Ordering::Greater [INFO] [stderr] 56 | } else { [INFO] [stderr] 57 | a_name_str.cmp(&b_name_str) [INFO] [stderr] 58 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/issues.rs:18:21 [INFO] [stderr] | [INFO] [stderr] 18 | const TO_DO_CHARS: &'static [char] = &['T', 'O', 'D', 'O']; [INFO] [stderr] | -^^^^^^^------- help: consider removing `'static`: `&[char]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/issues.rs:19:22 [INFO] [stderr] | [INFO] [stderr] 19 | const FIX_ME_CHARS: &'static [char] = &['F', 'I', 'X', 'M', 'E']; [INFO] [stderr] | -^^^^^^^------- help: consider removing `'static`: `&[char]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/comment.rs:26:12 [INFO] [stderr] | [INFO] [stderr] 26 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 27 | | if let Some(c) = comment.chars().nth(2) { [INFO] [stderr] 28 | | !c.is_alphanumeric() && !c.is_whitespace() [INFO] [stderr] 29 | | } else { [INFO] [stderr] 30 | | false [INFO] [stderr] 31 | | } [INFO] [stderr] 32 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 26 | } else if let Some(c) = comment.chars().nth(2) { [INFO] [stderr] 27 | !c.is_alphanumeric() && !c.is_whitespace() [INFO] [stderr] 28 | } else { [INFO] [stderr] 29 | false [INFO] [stderr] 30 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/comment.rs:797:20 [INFO] [stderr] | [INFO] [stderr] 797 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 798 | | if c == '\n' { [INFO] [stderr] 799 | | self.at_start_line = true; [INFO] [stderr] 800 | | } [INFO] [stderr] 801 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 797 | } else if c == '\n' { [INFO] [stderr] 798 | self.at_start_line = true; [INFO] [stderr] 799 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/expr.rs:1791:16 [INFO] [stderr] | [INFO] [stderr] 1791 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 1792 | | if line.len() > shape.width + shape.indent.width() { [INFO] [stderr] 1793 | | return true; [INFO] [stderr] 1794 | | } [INFO] [stderr] 1795 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 1791 | } else if line.len() > shape.width + shape.indent.width() { [INFO] [stderr] 1792 | return true; [INFO] [stderr] 1793 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Unnecessary `>= y + 1` or `x - 1 >=` [INFO] [stderr] --> src/chains.rs:554:12 [INFO] [stderr] | [INFO] [stderr] 554 | if last_line_width(parent_str) + first_line_width(first_child_str) + 1 <= [INFO] [stderr] | ____________^ [INFO] [stderr] 555 | | context.config.max_width() [INFO] [stderr] | |______________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::int_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#int_plus_one [INFO] [stderr] help: change `>= y + 1` to `> y` as shown [INFO] [stderr] | [INFO] [stderr] 554 | if last_line_width(parent_str) + first_line_width(first_child_str) < context.config.max_width() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/macros.rs:37:31 [INFO] [stderr] | [INFO] [stderr] 37 | const FORCED_BRACKET_MACROS: &'static [&'static str] = &["vec!"]; [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/macros.rs:37:41 [INFO] [stderr] | [INFO] [stderr] 37 | const FORCED_BRACKET_MACROS: &'static [&'static str] = &["vec!"]; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/expr.rs:2150:12 [INFO] [stderr] | [INFO] [stderr] 2150 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 2151 | | if subexpr_str.len() + paren_overhead <= shape.width { [INFO] [stderr] 2152 | | Some(paren_wrapper(&subexpr_str)) [INFO] [stderr] 2153 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 2157 | | } [INFO] [stderr] 2158 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 2150 | } else if subexpr_str.len() + paren_overhead <= shape.width { [INFO] [stderr] 2151 | Some(paren_wrapper(&subexpr_str)) [INFO] [stderr] 2152 | } else { [INFO] [stderr] 2153 | let sub_shape = try_opt!(shape.offset_left(2)); [INFO] [stderr] 2154 | let subexpr_str = try_opt!(subexpr.rewrite(context, sub_shape)); [INFO] [stderr] 2155 | Some(paren_wrapper(&subexpr_str)) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/imports.rs:54:12 [INFO] [stderr] | [INFO] [stderr] 54 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 55 | | if b_name_str == "self" { [INFO] [stderr] 56 | | Ordering::Greater [INFO] [stderr] 57 | | } else { [INFO] [stderr] 58 | | a_name_str.cmp(&b_name_str) [INFO] [stderr] 59 | | } [INFO] [stderr] 60 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 54 | } else if b_name_str == "self" { [INFO] [stderr] 55 | Ordering::Greater [INFO] [stderr] 56 | } else { [INFO] [stderr] 57 | a_name_str.cmp(&b_name_str) [INFO] [stderr] 58 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:83:25 [INFO] [stderr] | [INFO] [stderr] 83 | const SKIP_ANNOTATION: &'static str = "rustfmt_skip"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/issues.rs:18:21 [INFO] [stderr] | [INFO] [stderr] 18 | const TO_DO_CHARS: &'static [char] = &['T', 'O', 'D', 'O']; [INFO] [stderr] | -^^^^^^^------- help: consider removing `'static`: `&[char]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/issues.rs:19:22 [INFO] [stderr] | [INFO] [stderr] 19 | const FIX_ME_CHARS: &'static [char] = &['F', 'I', 'X', 'M', 'E']; [INFO] [stderr] | -^^^^^^^------- help: consider removing `'static`: `&[char]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/comment.rs:26:12 [INFO] [stderr] | [INFO] [stderr] 26 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 27 | | if let Some(c) = comment.chars().nth(2) { [INFO] [stderr] 28 | | !c.is_alphanumeric() && !c.is_whitespace() [INFO] [stderr] 29 | | } else { [INFO] [stderr] 30 | | false [INFO] [stderr] 31 | | } [INFO] [stderr] 32 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 26 | } else if let Some(c) = comment.chars().nth(2) { [INFO] [stderr] 27 | !c.is_alphanumeric() && !c.is_whitespace() [INFO] [stderr] 28 | } else { [INFO] [stderr] 29 | false [INFO] [stderr] 30 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/comment.rs:797:20 [INFO] [stderr] | [INFO] [stderr] 797 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 798 | | if c == '\n' { [INFO] [stderr] 799 | | self.at_start_line = true; [INFO] [stderr] 800 | | } [INFO] [stderr] 801 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 797 | } else if c == '\n' { [INFO] [stderr] 798 | self.at_start_line = true; [INFO] [stderr] 799 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Unnecessary `>= y + 1` or `x - 1 >=` [INFO] [stderr] --> src/chains.rs:554:12 [INFO] [stderr] | [INFO] [stderr] 554 | if last_line_width(parent_str) + first_line_width(first_child_str) + 1 <= [INFO] [stderr] | ____________^ [INFO] [stderr] 555 | | context.config.max_width() [INFO] [stderr] | |______________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::int_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#int_plus_one [INFO] [stderr] help: change `>= y + 1` to `> y` as shown [INFO] [stderr] | [INFO] [stderr] 554 | if last_line_width(parent_str) + first_line_width(first_child_str) < context.config.max_width() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/macros.rs:37:31 [INFO] [stderr] | [INFO] [stderr] 37 | const FORCED_BRACKET_MACROS: &'static [&'static str] = &["vec!"]; [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/macros.rs:37:41 [INFO] [stderr] | [INFO] [stderr] 37 | const FORCED_BRACKET_MACROS: &'static [&'static str] = &["vec!"]; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:83:25 [INFO] [stderr] | [INFO] [stderr] 83 | const SKIP_ANNOTATION: &'static str = "rustfmt_skip"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/utils.rs:221:21 [INFO] [stderr] | [INFO] [stderr] 221 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/config.rs:34:1 [INFO] [stderr] | [INFO] [stderr] 34 | / configuration_option_enum! { Style: [INFO] [stderr] 35 | | Rfc, // Follow the style RFCs style. [INFO] [stderr] 36 | | Legacy, // Follow the traditional Rustfmt style. [INFO] [stderr] 37 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/utils.rs:251:21 [INFO] [stderr] | [INFO] [stderr] 251 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/config.rs:34:1 [INFO] [stderr] | [INFO] [stderr] 34 | / configuration_option_enum! { Style: [INFO] [stderr] 35 | | Rfc, // Follow the style RFCs style. [INFO] [stderr] 36 | | Legacy, // Follow the traditional Rustfmt style. [INFO] [stderr] 37 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/utils.rs:221:21 [INFO] [stderr] | [INFO] [stderr] 221 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/config.rs:39:1 [INFO] [stderr] | [INFO] [stderr] 39 | / configuration_option_enum! { NewlineStyle: [INFO] [stderr] 40 | | Windows, // \r\n [INFO] [stderr] 41 | | Unix, // \n [INFO] [stderr] 42 | | Native, // \r\n in Windows, \n on other platforms [INFO] [stderr] 43 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/utils.rs:251:21 [INFO] [stderr] | [INFO] [stderr] 251 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/config.rs:39:1 [INFO] [stderr] | [INFO] [stderr] 39 | / configuration_option_enum! { NewlineStyle: [INFO] [stderr] 40 | | Windows, // \r\n [INFO] [stderr] 41 | | Unix, // \n [INFO] [stderr] 42 | | Native, // \r\n in Windows, \n on other platforms [INFO] [stderr] 43 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/utils.rs:221:21 [INFO] [stderr] | [INFO] [stderr] 221 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/config.rs:45:1 [INFO] [stderr] | [INFO] [stderr] 45 | / configuration_option_enum! { BraceStyle: [INFO] [stderr] 46 | | AlwaysNextLine, [INFO] [stderr] 47 | | PreferSameLine, [INFO] [stderr] 48 | | // Prefer same line except where there is a where clause, in which case force [INFO] [stderr] 49 | | // the brace to the next line. [INFO] [stderr] 50 | | SameLineWhere, [INFO] [stderr] 51 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/utils.rs:251:21 [INFO] [stderr] | [INFO] [stderr] 251 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/config.rs:45:1 [INFO] [stderr] | [INFO] [stderr] 45 | / configuration_option_enum! { BraceStyle: [INFO] [stderr] 46 | | AlwaysNextLine, [INFO] [stderr] 47 | | PreferSameLine, [INFO] [stderr] 48 | | // Prefer same line except where there is a where clause, in which case force [INFO] [stderr] 49 | | // the brace to the next line. [INFO] [stderr] 50 | | SameLineWhere, [INFO] [stderr] 51 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/utils.rs:221:21 [INFO] [stderr] | [INFO] [stderr] 221 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/config.rs:53:1 [INFO] [stderr] | [INFO] [stderr] 53 | / configuration_option_enum! { ControlBraceStyle: [INFO] [stderr] 54 | | // K&R style, Rust community default [INFO] [stderr] 55 | | AlwaysSameLine, [INFO] [stderr] 56 | | // Stroustrup style [INFO] [stderr] ... | [INFO] [stderr] 59 | | AlwaysNextLine, [INFO] [stderr] 60 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/utils.rs:251:21 [INFO] [stderr] | [INFO] [stderr] 251 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/config.rs:53:1 [INFO] [stderr] | [INFO] [stderr] 53 | / configuration_option_enum! { ControlBraceStyle: [INFO] [stderr] 54 | | // K&R style, Rust community default [INFO] [stderr] 55 | | AlwaysSameLine, [INFO] [stderr] 56 | | // Stroustrup style [INFO] [stderr] ... | [INFO] [stderr] 59 | | AlwaysNextLine, [INFO] [stderr] 60 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/utils.rs:221:21 [INFO] [stderr] | [INFO] [stderr] 221 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/config.rs:63:1 [INFO] [stderr] | [INFO] [stderr] 63 | / configuration_option_enum! { ReturnIndent: [INFO] [stderr] 64 | | // Aligned with the arguments [INFO] [stderr] 65 | | WithArgs, [INFO] [stderr] 66 | | // Aligned with the where clause [INFO] [stderr] 67 | | WithWhereClause, [INFO] [stderr] 68 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/utils.rs:251:21 [INFO] [stderr] | [INFO] [stderr] 251 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/config.rs:63:1 [INFO] [stderr] | [INFO] [stderr] 63 | / configuration_option_enum! { ReturnIndent: [INFO] [stderr] 64 | | // Aligned with the arguments [INFO] [stderr] 65 | | WithArgs, [INFO] [stderr] 66 | | // Aligned with the where clause [INFO] [stderr] 67 | | WithWhereClause, [INFO] [stderr] 68 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/utils.rs:221:21 [INFO] [stderr] | [INFO] [stderr] 221 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/config.rs:70:1 [INFO] [stderr] | [INFO] [stderr] 70 | / configuration_option_enum! { IndentStyle: [INFO] [stderr] 71 | | // First line on the same line as the opening brace, all lines aligned with [INFO] [stderr] 72 | | // the first line. [INFO] [stderr] 73 | | Visual, [INFO] [stderr] 74 | | // First line is on a new line and all lines align with block indent. [INFO] [stderr] 75 | | Block, [INFO] [stderr] 76 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/utils.rs:251:21 [INFO] [stderr] | [INFO] [stderr] 251 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/config.rs:70:1 [INFO] [stderr] | [INFO] [stderr] 70 | / configuration_option_enum! { IndentStyle: [INFO] [stderr] 71 | | // First line on the same line as the opening brace, all lines aligned with [INFO] [stderr] 72 | | // the first line. [INFO] [stderr] 73 | | Visual, [INFO] [stderr] 74 | | // First line is on a new line and all lines align with block indent. [INFO] [stderr] 75 | | Block, [INFO] [stderr] 76 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/utils.rs:221:21 [INFO] [stderr] | [INFO] [stderr] 221 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/config.rs:78:1 [INFO] [stderr] | [INFO] [stderr] 78 | / configuration_option_enum! { Density: [INFO] [stderr] 79 | | // Fit as much on one line as possible. [INFO] [stderr] 80 | | Compressed, [INFO] [stderr] 81 | | // Use more lines. [INFO] [stderr] ... | [INFO] [stderr] 86 | | Vertical, [INFO] [stderr] 87 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/utils.rs:251:21 [INFO] [stderr] | [INFO] [stderr] 251 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/config.rs:78:1 [INFO] [stderr] | [INFO] [stderr] 78 | / configuration_option_enum! { Density: [INFO] [stderr] 79 | | // Fit as much on one line as possible. [INFO] [stderr] 80 | | Compressed, [INFO] [stderr] 81 | | // Use more lines. [INFO] [stderr] ... | [INFO] [stderr] 86 | | Vertical, [INFO] [stderr] 87 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/utils.rs:221:21 [INFO] [stderr] | [INFO] [stderr] 221 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/config.rs:89:1 [INFO] [stderr] | [INFO] [stderr] 89 | / configuration_option_enum! { TypeDensity: [INFO] [stderr] 90 | | // No spaces around "=" and "+" [INFO] [stderr] 91 | | Compressed, [INFO] [stderr] 92 | | // Spaces around " = " and " + " [INFO] [stderr] 93 | | Wide, [INFO] [stderr] 94 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/utils.rs:251:21 [INFO] [stderr] | [INFO] [stderr] 251 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/config.rs:89:1 [INFO] [stderr] | [INFO] [stderr] 89 | / configuration_option_enum! { TypeDensity: [INFO] [stderr] 90 | | // No spaces around "=" and "+" [INFO] [stderr] 91 | | Compressed, [INFO] [stderr] 92 | | // Spaces around " = " and " + " [INFO] [stderr] 93 | | Wide, [INFO] [stderr] 94 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/utils.rs:221:21 [INFO] [stderr] | [INFO] [stderr] 221 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/config.rs:108:1 [INFO] [stderr] | [INFO] [stderr] 108 | / configuration_option_enum! { LicensePolicy: [INFO] [stderr] 109 | | // Do not place license text at top of files [INFO] [stderr] 110 | | NoLicense, [INFO] [stderr] 111 | | // Use the text in "license" field as the license [INFO] [stderr] ... | [INFO] [stderr] 114 | | FileLicense, [INFO] [stderr] 115 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/utils.rs:251:21 [INFO] [stderr] | [INFO] [stderr] 251 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/config.rs:108:1 [INFO] [stderr] | [INFO] [stderr] 108 | / configuration_option_enum! { LicensePolicy: [INFO] [stderr] 109 | | // Do not place license text at top of files [INFO] [stderr] 110 | | NoLicense, [INFO] [stderr] 111 | | // Use the text in "license" field as the license [INFO] [stderr] ... | [INFO] [stderr] 114 | | FileLicense, [INFO] [stderr] 115 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/utils.rs:221:21 [INFO] [stderr] | [INFO] [stderr] 221 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/config.rs:117:1 [INFO] [stderr] | [INFO] [stderr] 117 | / configuration_option_enum! { MultilineStyle: [INFO] [stderr] 118 | | // Use horizontal layout if it fits in one line, fall back to vertical [INFO] [stderr] 119 | | PreferSingle, [INFO] [stderr] 120 | | // Use vertical layout [INFO] [stderr] 121 | | ForceMulti, [INFO] [stderr] 122 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/utils.rs:251:21 [INFO] [stderr] | [INFO] [stderr] 251 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/config.rs:117:1 [INFO] [stderr] | [INFO] [stderr] 117 | / configuration_option_enum! { MultilineStyle: [INFO] [stderr] 118 | | // Use horizontal layout if it fits in one line, fall back to vertical [INFO] [stderr] 119 | | PreferSingle, [INFO] [stderr] 120 | | // Use vertical layout [INFO] [stderr] 121 | | ForceMulti, [INFO] [stderr] 122 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/utils.rs:221:21 [INFO] [stderr] | [INFO] [stderr] 221 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/config.rs:133:1 [INFO] [stderr] | [INFO] [stderr] 133 | / configuration_option_enum! { ReportTactic: [INFO] [stderr] 134 | | Always, [INFO] [stderr] 135 | | Unnumbered, [INFO] [stderr] 136 | | Never, [INFO] [stderr] 137 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/utils.rs:251:21 [INFO] [stderr] | [INFO] [stderr] 251 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/config.rs:133:1 [INFO] [stderr] | [INFO] [stderr] 133 | / configuration_option_enum! { ReportTactic: [INFO] [stderr] 134 | | Always, [INFO] [stderr] 135 | | Unnumbered, [INFO] [stderr] 136 | | Never, [INFO] [stderr] 137 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/utils.rs:221:21 [INFO] [stderr] | [INFO] [stderr] 221 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/config.rs:139:1 [INFO] [stderr] | [INFO] [stderr] 139 | / configuration_option_enum! { WriteMode: [INFO] [stderr] 140 | | // Backs the original file up and overwrites the original. [INFO] [stderr] 141 | | Replace, [INFO] [stderr] 142 | | // Overwrites original file without backup. [INFO] [stderr] ... | [INFO] [stderr] 153 | | Checkstyle, [INFO] [stderr] 154 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/utils.rs:251:21 [INFO] [stderr] | [INFO] [stderr] 251 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/config.rs:139:1 [INFO] [stderr] | [INFO] [stderr] 139 | / configuration_option_enum! { WriteMode: [INFO] [stderr] 140 | | // Backs the original file up and overwrites the original. [INFO] [stderr] 141 | | Replace, [INFO] [stderr] 142 | | // Overwrites original file without backup. [INFO] [stderr] ... | [INFO] [stderr] 153 | | Checkstyle, [INFO] [stderr] 154 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/utils.rs:221:21 [INFO] [stderr] | [INFO] [stderr] 221 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/lists.rs:39:1 [INFO] [stderr] | [INFO] [stderr] 39 | impl_enum_serialize_and_deserialize!(ListTactic, Vertical, Horizontal, HorizontalVertical, Mixed); [INFO] [stderr] | -------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/utils.rs:251:21 [INFO] [stderr] | [INFO] [stderr] 251 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/lists.rs:39:1 [INFO] [stderr] | [INFO] [stderr] 39 | impl_enum_serialize_and_deserialize!(ListTactic, Vertical, Horizontal, HorizontalVertical, Mixed); [INFO] [stderr] | -------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/utils.rs:221:21 [INFO] [stderr] | [INFO] [stderr] 221 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/lists.rs:48:1 [INFO] [stderr] | [INFO] [stderr] 48 | impl_enum_serialize_and_deserialize!(SeparatorTactic, Always, Never, Vertical); [INFO] [stderr] | ------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/utils.rs:251:21 [INFO] [stderr] | [INFO] [stderr] 251 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/lists.rs:48:1 [INFO] [stderr] | [INFO] [stderr] 48 | impl_enum_serialize_and_deserialize!(SeparatorTactic, Always, Never, Vertical); [INFO] [stderr] | ------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/utils.rs:221:21 [INFO] [stderr] | [INFO] [stderr] 221 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/config.rs:34:1 [INFO] [stderr] | [INFO] [stderr] 34 | / configuration_option_enum! { Style: [INFO] [stderr] 35 | | Rfc, // Follow the style RFCs style. [INFO] [stderr] 36 | | Legacy, // Follow the traditional Rustfmt style. [INFO] [stderr] 37 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/utils.rs:251:21 [INFO] [stderr] | [INFO] [stderr] 251 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/config.rs:34:1 [INFO] [stderr] | [INFO] [stderr] 34 | / configuration_option_enum! { Style: [INFO] [stderr] 35 | | Rfc, // Follow the style RFCs style. [INFO] [stderr] 36 | | Legacy, // Follow the traditional Rustfmt style. [INFO] [stderr] 37 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/utils.rs:221:21 [INFO] [stderr] | [INFO] [stderr] 221 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/config.rs:39:1 [INFO] [stderr] | [INFO] [stderr] 39 | / configuration_option_enum! { NewlineStyle: [INFO] [stderr] 40 | | Windows, // \r\n [INFO] [stderr] 41 | | Unix, // \n [INFO] [stderr] 42 | | Native, // \r\n in Windows, \n on other platforms [INFO] [stderr] 43 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/utils.rs:251:21 [INFO] [stderr] | [INFO] [stderr] 251 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/config.rs:39:1 [INFO] [stderr] | [INFO] [stderr] 39 | / configuration_option_enum! { NewlineStyle: [INFO] [stderr] 40 | | Windows, // \r\n [INFO] [stderr] 41 | | Unix, // \n [INFO] [stderr] 42 | | Native, // \r\n in Windows, \n on other platforms [INFO] [stderr] 43 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/utils.rs:221:21 [INFO] [stderr] | [INFO] [stderr] 221 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/config.rs:45:1 [INFO] [stderr] | [INFO] [stderr] 45 | / configuration_option_enum! { BraceStyle: [INFO] [stderr] 46 | | AlwaysNextLine, [INFO] [stderr] 47 | | PreferSameLine, [INFO] [stderr] 48 | | // Prefer same line except where there is a where clause, in which case force [INFO] [stderr] 49 | | // the brace to the next line. [INFO] [stderr] 50 | | SameLineWhere, [INFO] [stderr] 51 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/utils.rs:251:21 [INFO] [stderr] | [INFO] [stderr] 251 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/config.rs:45:1 [INFO] [stderr] | [INFO] [stderr] 45 | / configuration_option_enum! { BraceStyle: [INFO] [stderr] 46 | | AlwaysNextLine, [INFO] [stderr] 47 | | PreferSameLine, [INFO] [stderr] 48 | | // Prefer same line except where there is a where clause, in which case force [INFO] [stderr] 49 | | // the brace to the next line. [INFO] [stderr] 50 | | SameLineWhere, [INFO] [stderr] 51 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/utils.rs:221:21 [INFO] [stderr] | [INFO] [stderr] 221 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/config.rs:53:1 [INFO] [stderr] | [INFO] [stderr] 53 | / configuration_option_enum! { ControlBraceStyle: [INFO] [stderr] 54 | | // K&R style, Rust community default [INFO] [stderr] 55 | | AlwaysSameLine, [INFO] [stderr] 56 | | // Stroustrup style [INFO] [stderr] ... | [INFO] [stderr] 59 | | AlwaysNextLine, [INFO] [stderr] 60 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/utils.rs:251:21 [INFO] [stderr] | [INFO] [stderr] 251 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/config.rs:53:1 [INFO] [stderr] | [INFO] [stderr] 53 | / configuration_option_enum! { ControlBraceStyle: [INFO] [stderr] 54 | | // K&R style, Rust community default [INFO] [stderr] 55 | | AlwaysSameLine, [INFO] [stderr] 56 | | // Stroustrup style [INFO] [stderr] ... | [INFO] [stderr] 59 | | AlwaysNextLine, [INFO] [stderr] 60 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/utils.rs:221:21 [INFO] [stderr] | [INFO] [stderr] 221 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/config.rs:63:1 [INFO] [stderr] | [INFO] [stderr] 63 | / configuration_option_enum! { ReturnIndent: [INFO] [stderr] 64 | | // Aligned with the arguments [INFO] [stderr] 65 | | WithArgs, [INFO] [stderr] 66 | | // Aligned with the where clause [INFO] [stderr] 67 | | WithWhereClause, [INFO] [stderr] 68 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/utils.rs:251:21 [INFO] [stderr] | [INFO] [stderr] 251 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/config.rs:63:1 [INFO] [stderr] | [INFO] [stderr] 63 | / configuration_option_enum! { ReturnIndent: [INFO] [stderr] 64 | | // Aligned with the arguments [INFO] [stderr] 65 | | WithArgs, [INFO] [stderr] 66 | | // Aligned with the where clause [INFO] [stderr] 67 | | WithWhereClause, [INFO] [stderr] 68 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/utils.rs:221:21 [INFO] [stderr] | [INFO] [stderr] 221 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/config.rs:70:1 [INFO] [stderr] | [INFO] [stderr] 70 | / configuration_option_enum! { IndentStyle: [INFO] [stderr] 71 | | // First line on the same line as the opening brace, all lines aligned with [INFO] [stderr] 72 | | // the first line. [INFO] [stderr] 73 | | Visual, [INFO] [stderr] 74 | | // First line is on a new line and all lines align with block indent. [INFO] [stderr] 75 | | Block, [INFO] [stderr] 76 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/utils.rs:251:21 [INFO] [stderr] | [INFO] [stderr] 251 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/config.rs:70:1 [INFO] [stderr] | [INFO] [stderr] 70 | / configuration_option_enum! { IndentStyle: [INFO] [stderr] 71 | | // First line on the same line as the opening brace, all lines aligned with [INFO] [stderr] 72 | | // the first line. [INFO] [stderr] 73 | | Visual, [INFO] [stderr] 74 | | // First line is on a new line and all lines align with block indent. [INFO] [stderr] 75 | | Block, [INFO] [stderr] 76 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/utils.rs:221:21 [INFO] [stderr] | [INFO] [stderr] 221 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/config.rs:78:1 [INFO] [stderr] | [INFO] [stderr] 78 | / configuration_option_enum! { Density: [INFO] [stderr] 79 | | // Fit as much on one line as possible. [INFO] [stderr] 80 | | Compressed, [INFO] [stderr] 81 | | // Use more lines. [INFO] [stderr] ... | [INFO] [stderr] 86 | | Vertical, [INFO] [stderr] 87 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/utils.rs:251:21 [INFO] [stderr] | [INFO] [stderr] 251 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/config.rs:78:1 [INFO] [stderr] | [INFO] [stderr] 78 | / configuration_option_enum! { Density: [INFO] [stderr] 79 | | // Fit as much on one line as possible. [INFO] [stderr] 80 | | Compressed, [INFO] [stderr] 81 | | // Use more lines. [INFO] [stderr] ... | [INFO] [stderr] 86 | | Vertical, [INFO] [stderr] 87 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/utils.rs:221:21 [INFO] [stderr] | [INFO] [stderr] 221 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/config.rs:89:1 [INFO] [stderr] | [INFO] [stderr] 89 | / configuration_option_enum! { TypeDensity: [INFO] [stderr] 90 | | // No spaces around "=" and "+" [INFO] [stderr] 91 | | Compressed, [INFO] [stderr] 92 | | // Spaces around " = " and " + " [INFO] [stderr] 93 | | Wide, [INFO] [stderr] 94 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/utils.rs:251:21 [INFO] [stderr] | [INFO] [stderr] 251 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/config.rs:89:1 [INFO] [stderr] | [INFO] [stderr] 89 | / configuration_option_enum! { TypeDensity: [INFO] [stderr] 90 | | // No spaces around "=" and "+" [INFO] [stderr] 91 | | Compressed, [INFO] [stderr] 92 | | // Spaces around " = " and " + " [INFO] [stderr] 93 | | Wide, [INFO] [stderr] 94 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/utils.rs:221:21 [INFO] [stderr] | [INFO] [stderr] 221 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/config.rs:108:1 [INFO] [stderr] | [INFO] [stderr] 108 | / configuration_option_enum! { LicensePolicy: [INFO] [stderr] 109 | | // Do not place license text at top of files [INFO] [stderr] 110 | | NoLicense, [INFO] [stderr] 111 | | // Use the text in "license" field as the license [INFO] [stderr] ... | [INFO] [stderr] 114 | | FileLicense, [INFO] [stderr] 115 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/utils.rs:251:21 [INFO] [stderr] | [INFO] [stderr] 251 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/config.rs:108:1 [INFO] [stderr] | [INFO] [stderr] 108 | / configuration_option_enum! { LicensePolicy: [INFO] [stderr] 109 | | // Do not place license text at top of files [INFO] [stderr] 110 | | NoLicense, [INFO] [stderr] 111 | | // Use the text in "license" field as the license [INFO] [stderr] ... | [INFO] [stderr] 114 | | FileLicense, [INFO] [stderr] 115 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/utils.rs:221:21 [INFO] [stderr] | [INFO] [stderr] 221 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/config.rs:117:1 [INFO] [stderr] | [INFO] [stderr] 117 | / configuration_option_enum! { MultilineStyle: [INFO] [stderr] 118 | | // Use horizontal layout if it fits in one line, fall back to vertical [INFO] [stderr] 119 | | PreferSingle, [INFO] [stderr] 120 | | // Use vertical layout [INFO] [stderr] 121 | | ForceMulti, [INFO] [stderr] 122 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/utils.rs:251:21 [INFO] [stderr] | [INFO] [stderr] 251 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/config.rs:117:1 [INFO] [stderr] | [INFO] [stderr] 117 | / configuration_option_enum! { MultilineStyle: [INFO] [stderr] 118 | | // Use horizontal layout if it fits in one line, fall back to vertical [INFO] [stderr] 119 | | PreferSingle, [INFO] [stderr] 120 | | // Use vertical layout [INFO] [stderr] 121 | | ForceMulti, [INFO] [stderr] 122 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/utils.rs:221:21 [INFO] [stderr] | [INFO] [stderr] 221 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/config.rs:133:1 [INFO] [stderr] | [INFO] [stderr] 133 | / configuration_option_enum! { ReportTactic: [INFO] [stderr] 134 | | Always, [INFO] [stderr] 135 | | Unnumbered, [INFO] [stderr] 136 | | Never, [INFO] [stderr] 137 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/utils.rs:251:21 [INFO] [stderr] | [INFO] [stderr] 251 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/config.rs:133:1 [INFO] [stderr] | [INFO] [stderr] 133 | / configuration_option_enum! { ReportTactic: [INFO] [stderr] 134 | | Always, [INFO] [stderr] 135 | | Unnumbered, [INFO] [stderr] 136 | | Never, [INFO] [stderr] 137 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/utils.rs:221:21 [INFO] [stderr] | [INFO] [stderr] 221 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/config.rs:139:1 [INFO] [stderr] | [INFO] [stderr] 139 | / configuration_option_enum! { WriteMode: [INFO] [stderr] 140 | | // Backs the original file up and overwrites the original. [INFO] [stderr] 141 | | Replace, [INFO] [stderr] 142 | | // Overwrites original file without backup. [INFO] [stderr] ... | [INFO] [stderr] 153 | | Checkstyle, [INFO] [stderr] 154 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/utils.rs:251:21 [INFO] [stderr] | [INFO] [stderr] 251 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/config.rs:139:1 [INFO] [stderr] | [INFO] [stderr] 139 | / configuration_option_enum! { WriteMode: [INFO] [stderr] 140 | | // Backs the original file up and overwrites the original. [INFO] [stderr] 141 | | Replace, [INFO] [stderr] 142 | | // Overwrites original file without backup. [INFO] [stderr] ... | [INFO] [stderr] 153 | | Checkstyle, [INFO] [stderr] 154 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/utils.rs:221:21 [INFO] [stderr] | [INFO] [stderr] 221 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/lists.rs:39:1 [INFO] [stderr] | [INFO] [stderr] 39 | impl_enum_serialize_and_deserialize!(ListTactic, Vertical, Horizontal, HorizontalVertical, Mixed); [INFO] [stderr] | -------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/utils.rs:251:21 [INFO] [stderr] | [INFO] [stderr] 251 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/lists.rs:39:1 [INFO] [stderr] | [INFO] [stderr] 39 | impl_enum_serialize_and_deserialize!(ListTactic, Vertical, Horizontal, HorizontalVertical, Mixed); [INFO] [stderr] | -------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/utils.rs:221:21 [INFO] [stderr] | [INFO] [stderr] 221 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/lists.rs:48:1 [INFO] [stderr] | [INFO] [stderr] 48 | impl_enum_serialize_and_deserialize!(SeparatorTactic, Always, Never, Vertical); [INFO] [stderr] | ------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/utils.rs:251:21 [INFO] [stderr] | [INFO] [stderr] 251 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/lists.rs:48:1 [INFO] [stderr] | [INFO] [stderr] 48 | impl_enum_serialize_and_deserialize!(SeparatorTactic, Always, Never, Vertical); [INFO] [stderr] | ------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/utils.rs:221:21 [INFO] [stderr] | [INFO] [stderr] 221 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/config.rs:34:1 [INFO] [stderr] | [INFO] [stderr] 34 | / configuration_option_enum! { Style: [INFO] [stderr] 35 | | Rfc, // Follow the style RFCs style. [INFO] [stderr] 36 | | Legacy, // Follow the traditional Rustfmt style. [INFO] [stderr] 37 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/utils.rs:251:21 [INFO] [stderr] | [INFO] [stderr] 251 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/config.rs:34:1 [INFO] [stderr] | [INFO] [stderr] 34 | / configuration_option_enum! { Style: [INFO] [stderr] 35 | | Rfc, // Follow the style RFCs style. [INFO] [stderr] 36 | | Legacy, // Follow the traditional Rustfmt style. [INFO] [stderr] 37 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/utils.rs:221:21 [INFO] [stderr] | [INFO] [stderr] 221 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/config.rs:39:1 [INFO] [stderr] | [INFO] [stderr] 39 | / configuration_option_enum! { NewlineStyle: [INFO] [stderr] 40 | | Windows, // \r\n [INFO] [stderr] 41 | | Unix, // \n [INFO] [stderr] 42 | | Native, // \r\n in Windows, \n on other platforms [INFO] [stderr] 43 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/utils.rs:251:21 [INFO] [stderr] | [INFO] [stderr] 251 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/config.rs:39:1 [INFO] [stderr] | [INFO] [stderr] 39 | / configuration_option_enum! { NewlineStyle: [INFO] [stderr] 40 | | Windows, // \r\n [INFO] [stderr] 41 | | Unix, // \n [INFO] [stderr] 42 | | Native, // \r\n in Windows, \n on other platforms [INFO] [stderr] 43 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/utils.rs:221:21 [INFO] [stderr] | [INFO] [stderr] 221 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/config.rs:45:1 [INFO] [stderr] | [INFO] [stderr] 45 | / configuration_option_enum! { BraceStyle: [INFO] [stderr] 46 | | AlwaysNextLine, [INFO] [stderr] 47 | | PreferSameLine, [INFO] [stderr] 48 | | // Prefer same line except where there is a where clause, in which case force [INFO] [stderr] 49 | | // the brace to the next line. [INFO] [stderr] 50 | | SameLineWhere, [INFO] [stderr] 51 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/utils.rs:251:21 [INFO] [stderr] | [INFO] [stderr] 251 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/config.rs:45:1 [INFO] [stderr] | [INFO] [stderr] 45 | / configuration_option_enum! { BraceStyle: [INFO] [stderr] 46 | | AlwaysNextLine, [INFO] [stderr] 47 | | PreferSameLine, [INFO] [stderr] 48 | | // Prefer same line except where there is a where clause, in which case force [INFO] [stderr] 49 | | // the brace to the next line. [INFO] [stderr] 50 | | SameLineWhere, [INFO] [stderr] 51 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/utils.rs:221:21 [INFO] [stderr] | [INFO] [stderr] 221 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/config.rs:53:1 [INFO] [stderr] | [INFO] [stderr] 53 | / configuration_option_enum! { ControlBraceStyle: [INFO] [stderr] 54 | | // K&R style, Rust community default [INFO] [stderr] 55 | | AlwaysSameLine, [INFO] [stderr] 56 | | // Stroustrup style [INFO] [stderr] ... | [INFO] [stderr] 59 | | AlwaysNextLine, [INFO] [stderr] 60 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/utils.rs:251:21 [INFO] [stderr] | [INFO] [stderr] 251 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/config.rs:53:1 [INFO] [stderr] | [INFO] [stderr] 53 | / configuration_option_enum! { ControlBraceStyle: [INFO] [stderr] 54 | | // K&R style, Rust community default [INFO] [stderr] 55 | | AlwaysSameLine, [INFO] [stderr] 56 | | // Stroustrup style [INFO] [stderr] ... | [INFO] [stderr] 59 | | AlwaysNextLine, [INFO] [stderr] 60 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/utils.rs:221:21 [INFO] [stderr] | [INFO] [stderr] 221 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/config.rs:63:1 [INFO] [stderr] | [INFO] [stderr] 63 | / configuration_option_enum! { ReturnIndent: [INFO] [stderr] 64 | | // Aligned with the arguments [INFO] [stderr] 65 | | WithArgs, [INFO] [stderr] 66 | | // Aligned with the where clause [INFO] [stderr] 67 | | WithWhereClause, [INFO] [stderr] 68 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/utils.rs:251:21 [INFO] [stderr] | [INFO] [stderr] 251 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/config.rs:63:1 [INFO] [stderr] | [INFO] [stderr] 63 | / configuration_option_enum! { ReturnIndent: [INFO] [stderr] 64 | | // Aligned with the arguments [INFO] [stderr] 65 | | WithArgs, [INFO] [stderr] 66 | | // Aligned with the where clause [INFO] [stderr] 67 | | WithWhereClause, [INFO] [stderr] 68 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/utils.rs:221:21 [INFO] [stderr] | [INFO] [stderr] 221 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/config.rs:70:1 [INFO] [stderr] | [INFO] [stderr] 70 | / configuration_option_enum! { IndentStyle: [INFO] [stderr] 71 | | // First line on the same line as the opening brace, all lines aligned with [INFO] [stderr] 72 | | // the first line. [INFO] [stderr] 73 | | Visual, [INFO] [stderr] 74 | | // First line is on a new line and all lines align with block indent. [INFO] [stderr] 75 | | Block, [INFO] [stderr] 76 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/utils.rs:251:21 [INFO] [stderr] | [INFO] [stderr] 251 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/config.rs:70:1 [INFO] [stderr] | [INFO] [stderr] 70 | / configuration_option_enum! { IndentStyle: [INFO] [stderr] 71 | | // First line on the same line as the opening brace, all lines aligned with [INFO] [stderr] 72 | | // the first line. [INFO] [stderr] 73 | | Visual, [INFO] [stderr] 74 | | // First line is on a new line and all lines align with block indent. [INFO] [stderr] 75 | | Block, [INFO] [stderr] 76 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/utils.rs:221:21 [INFO] [stderr] | [INFO] [stderr] 221 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/config.rs:78:1 [INFO] [stderr] | [INFO] [stderr] 78 | / configuration_option_enum! { Density: [INFO] [stderr] 79 | | // Fit as much on one line as possible. [INFO] [stderr] 80 | | Compressed, [INFO] [stderr] 81 | | // Use more lines. [INFO] [stderr] ... | [INFO] [stderr] 86 | | Vertical, [INFO] [stderr] 87 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/utils.rs:251:21 [INFO] [stderr] | [INFO] [stderr] 251 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/config.rs:78:1 [INFO] [stderr] | [INFO] [stderr] 78 | / configuration_option_enum! { Density: [INFO] [stderr] 79 | | // Fit as much on one line as possible. [INFO] [stderr] 80 | | Compressed, [INFO] [stderr] 81 | | // Use more lines. [INFO] [stderr] ... | [INFO] [stderr] 86 | | Vertical, [INFO] [stderr] 87 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/utils.rs:221:21 [INFO] [stderr] | [INFO] [stderr] 221 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/config.rs:89:1 [INFO] [stderr] | [INFO] [stderr] 89 | / configuration_option_enum! { TypeDensity: [INFO] [stderr] 90 | | // No spaces around "=" and "+" [INFO] [stderr] 91 | | Compressed, [INFO] [stderr] 92 | | // Spaces around " = " and " + " [INFO] [stderr] 93 | | Wide, [INFO] [stderr] 94 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/utils.rs:251:21 [INFO] [stderr] | [INFO] [stderr] 251 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/config.rs:89:1 [INFO] [stderr] | [INFO] [stderr] 89 | / configuration_option_enum! { TypeDensity: [INFO] [stderr] 90 | | // No spaces around "=" and "+" [INFO] [stderr] 91 | | Compressed, [INFO] [stderr] 92 | | // Spaces around " = " and " + " [INFO] [stderr] 93 | | Wide, [INFO] [stderr] 94 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/utils.rs:221:21 [INFO] [stderr] | [INFO] [stderr] 221 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/config.rs:108:1 [INFO] [stderr] | [INFO] [stderr] 108 | / configuration_option_enum! { LicensePolicy: [INFO] [stderr] 109 | | // Do not place license text at top of files [INFO] [stderr] 110 | | NoLicense, [INFO] [stderr] 111 | | // Use the text in "license" field as the license [INFO] [stderr] ... | [INFO] [stderr] 114 | | FileLicense, [INFO] [stderr] 115 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/utils.rs:251:21 [INFO] [stderr] | [INFO] [stderr] 251 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/config.rs:108:1 [INFO] [stderr] | [INFO] [stderr] 108 | / configuration_option_enum! { LicensePolicy: [INFO] [stderr] 109 | | // Do not place license text at top of files [INFO] [stderr] 110 | | NoLicense, [INFO] [stderr] 111 | | // Use the text in "license" field as the license [INFO] [stderr] ... | [INFO] [stderr] 114 | | FileLicense, [INFO] [stderr] 115 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/utils.rs:221:21 [INFO] [stderr] | [INFO] [stderr] 221 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/config.rs:117:1 [INFO] [stderr] | [INFO] [stderr] 117 | / configuration_option_enum! { MultilineStyle: [INFO] [stderr] 118 | | // Use horizontal layout if it fits in one line, fall back to vertical [INFO] [stderr] 119 | | PreferSingle, [INFO] [stderr] 120 | | // Use vertical layout [INFO] [stderr] 121 | | ForceMulti, [INFO] [stderr] 122 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/utils.rs:251:21 [INFO] [stderr] | [INFO] [stderr] 251 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/config.rs:117:1 [INFO] [stderr] | [INFO] [stderr] 117 | / configuration_option_enum! { MultilineStyle: [INFO] [stderr] 118 | | // Use horizontal layout if it fits in one line, fall back to vertical [INFO] [stderr] 119 | | PreferSingle, [INFO] [stderr] 120 | | // Use vertical layout [INFO] [stderr] 121 | | ForceMulti, [INFO] [stderr] 122 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/utils.rs:221:21 [INFO] [stderr] | [INFO] [stderr] 221 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/config.rs:133:1 [INFO] [stderr] | [INFO] [stderr] 133 | / configuration_option_enum! { ReportTactic: [INFO] [stderr] 134 | | Always, [INFO] [stderr] 135 | | Unnumbered, [INFO] [stderr] 136 | | Never, [INFO] [stderr] 137 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/utils.rs:251:21 [INFO] [stderr] | [INFO] [stderr] 251 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/config.rs:133:1 [INFO] [stderr] | [INFO] [stderr] 133 | / configuration_option_enum! { ReportTactic: [INFO] [stderr] 134 | | Always, [INFO] [stderr] 135 | | Unnumbered, [INFO] [stderr] 136 | | Never, [INFO] [stderr] 137 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/utils.rs:221:21 [INFO] [stderr] | [INFO] [stderr] 221 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/config.rs:139:1 [INFO] [stderr] | [INFO] [stderr] 139 | / configuration_option_enum! { WriteMode: [INFO] [stderr] 140 | | // Backs the original file up and overwrites the original. [INFO] [stderr] 141 | | Replace, [INFO] [stderr] 142 | | // Overwrites original file without backup. [INFO] [stderr] ... | [INFO] [stderr] 153 | | Checkstyle, [INFO] [stderr] 154 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/utils.rs:251:21 [INFO] [stderr] | [INFO] [stderr] 251 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/config.rs:139:1 [INFO] [stderr] | [INFO] [stderr] 139 | / configuration_option_enum! { WriteMode: [INFO] [stderr] 140 | | // Backs the original file up and overwrites the original. [INFO] [stderr] 141 | | Replace, [INFO] [stderr] 142 | | // Overwrites original file without backup. [INFO] [stderr] ... | [INFO] [stderr] 153 | | Checkstyle, [INFO] [stderr] 154 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/utils.rs:221:21 [INFO] [stderr] | [INFO] [stderr] 221 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/lists.rs:39:1 [INFO] [stderr] | [INFO] [stderr] 39 | impl_enum_serialize_and_deserialize!(ListTactic, Vertical, Horizontal, HorizontalVertical, Mixed); [INFO] [stderr] | -------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/utils.rs:251:21 [INFO] [stderr] | [INFO] [stderr] 251 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/lists.rs:39:1 [INFO] [stderr] | [INFO] [stderr] 39 | impl_enum_serialize_and_deserialize!(ListTactic, Vertical, Horizontal, HorizontalVertical, Mixed); [INFO] [stderr] | -------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/utils.rs:221:21 [INFO] [stderr] | [INFO] [stderr] 221 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/lists.rs:48:1 [INFO] [stderr] | [INFO] [stderr] 48 | impl_enum_serialize_and_deserialize!(SeparatorTactic, Always, Never, Vertical); [INFO] [stderr] | ------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/utils.rs:251:21 [INFO] [stderr] | [INFO] [stderr] 251 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/lists.rs:48:1 [INFO] [stderr] | [INFO] [stderr] 48 | impl_enum_serialize_and_deserialize!(SeparatorTactic, Always, Never, Vertical); [INFO] [stderr] | ------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:441:5 [INFO] [stderr] | [INFO] [stderr] 441 | mut parse_session: &mut ParseSess, [INFO] [stderr] | ----^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:682:9 [INFO] [stderr] | [INFO] [stderr] 682 | let mut out = &mut stdout(); [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/utils.rs:221:21 [INFO] [stderr] | [INFO] [stderr] 221 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/config.rs:34:1 [INFO] [stderr] | [INFO] [stderr] 34 | / configuration_option_enum! { Style: [INFO] [stderr] 35 | | Rfc, // Follow the style RFCs style. [INFO] [stderr] 36 | | Legacy, // Follow the traditional Rustfmt style. [INFO] [stderr] 37 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/utils.rs:251:21 [INFO] [stderr] | [INFO] [stderr] 251 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/config.rs:34:1 [INFO] [stderr] | [INFO] [stderr] 34 | / configuration_option_enum! { Style: [INFO] [stderr] 35 | | Rfc, // Follow the style RFCs style. [INFO] [stderr] 36 | | Legacy, // Follow the traditional Rustfmt style. [INFO] [stderr] 37 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/utils.rs:221:21 [INFO] [stderr] | [INFO] [stderr] 221 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/config.rs:39:1 [INFO] [stderr] | [INFO] [stderr] 39 | / configuration_option_enum! { NewlineStyle: [INFO] [stderr] 40 | | Windows, // \r\n [INFO] [stderr] 41 | | Unix, // \n [INFO] [stderr] 42 | | Native, // \r\n in Windows, \n on other platforms [INFO] [stderr] 43 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/utils.rs:251:21 [INFO] [stderr] | [INFO] [stderr] 251 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/config.rs:39:1 [INFO] [stderr] | [INFO] [stderr] 39 | / configuration_option_enum! { NewlineStyle: [INFO] [stderr] 40 | | Windows, // \r\n [INFO] [stderr] 41 | | Unix, // \n [INFO] [stderr] 42 | | Native, // \r\n in Windows, \n on other platforms [INFO] [stderr] 43 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/utils.rs:221:21 [INFO] [stderr] | [INFO] [stderr] 221 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/config.rs:45:1 [INFO] [stderr] | [INFO] [stderr] 45 | / configuration_option_enum! { BraceStyle: [INFO] [stderr] 46 | | AlwaysNextLine, [INFO] [stderr] 47 | | PreferSameLine, [INFO] [stderr] 48 | | // Prefer same line except where there is a where clause, in which case force [INFO] [stderr] 49 | | // the brace to the next line. [INFO] [stderr] 50 | | SameLineWhere, [INFO] [stderr] 51 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/utils.rs:251:21 [INFO] [stderr] | [INFO] [stderr] 251 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/config.rs:45:1 [INFO] [stderr] | [INFO] [stderr] 45 | / configuration_option_enum! { BraceStyle: [INFO] [stderr] 46 | | AlwaysNextLine, [INFO] [stderr] 47 | | PreferSameLine, [INFO] [stderr] 48 | | // Prefer same line except where there is a where clause, in which case force [INFO] [stderr] 49 | | // the brace to the next line. [INFO] [stderr] 50 | | SameLineWhere, [INFO] [stderr] 51 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/utils.rs:221:21 [INFO] [stderr] | [INFO] [stderr] 221 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/config.rs:53:1 [INFO] [stderr] | [INFO] [stderr] 53 | / configuration_option_enum! { ControlBraceStyle: [INFO] [stderr] 54 | | // K&R style, Rust community default [INFO] [stderr] 55 | | AlwaysSameLine, [INFO] [stderr] 56 | | // Stroustrup style [INFO] [stderr] ... | [INFO] [stderr] 59 | | AlwaysNextLine, [INFO] [stderr] 60 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/utils.rs:251:21 [INFO] [stderr] | [INFO] [stderr] 251 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/config.rs:53:1 [INFO] [stderr] | [INFO] [stderr] 53 | / configuration_option_enum! { ControlBraceStyle: [INFO] [stderr] 54 | | // K&R style, Rust community default [INFO] [stderr] 55 | | AlwaysSameLine, [INFO] [stderr] 56 | | // Stroustrup style [INFO] [stderr] ... | [INFO] [stderr] 59 | | AlwaysNextLine, [INFO] [stderr] 60 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/utils.rs:221:21 [INFO] [stderr] | [INFO] [stderr] 221 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/config.rs:63:1 [INFO] [stderr] | [INFO] [stderr] 63 | / configuration_option_enum! { ReturnIndent: [INFO] [stderr] 64 | | // Aligned with the arguments [INFO] [stderr] 65 | | WithArgs, [INFO] [stderr] 66 | | // Aligned with the where clause [INFO] [stderr] 67 | | WithWhereClause, [INFO] [stderr] 68 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/utils.rs:251:21 [INFO] [stderr] | [INFO] [stderr] 251 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/config.rs:63:1 [INFO] [stderr] | [INFO] [stderr] 63 | / configuration_option_enum! { ReturnIndent: [INFO] [stderr] 64 | | // Aligned with the arguments [INFO] [stderr] 65 | | WithArgs, [INFO] [stderr] 66 | | // Aligned with the where clause [INFO] [stderr] 67 | | WithWhereClause, [INFO] [stderr] 68 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/utils.rs:221:21 [INFO] [stderr] | [INFO] [stderr] 221 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/config.rs:70:1 [INFO] [stderr] | [INFO] [stderr] 70 | / configuration_option_enum! { IndentStyle: [INFO] [stderr] 71 | | // First line on the same line as the opening brace, all lines aligned with [INFO] [stderr] 72 | | // the first line. [INFO] [stderr] 73 | | Visual, [INFO] [stderr] 74 | | // First line is on a new line and all lines align with block indent. [INFO] [stderr] 75 | | Block, [INFO] [stderr] 76 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/utils.rs:251:21 [INFO] [stderr] | [INFO] [stderr] 251 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/config.rs:70:1 [INFO] [stderr] | [INFO] [stderr] 70 | / configuration_option_enum! { IndentStyle: [INFO] [stderr] 71 | | // First line on the same line as the opening brace, all lines aligned with [INFO] [stderr] 72 | | // the first line. [INFO] [stderr] 73 | | Visual, [INFO] [stderr] 74 | | // First line is on a new line and all lines align with block indent. [INFO] [stderr] 75 | | Block, [INFO] [stderr] 76 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/utils.rs:221:21 [INFO] [stderr] | [INFO] [stderr] 221 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/config.rs:78:1 [INFO] [stderr] | [INFO] [stderr] 78 | / configuration_option_enum! { Density: [INFO] [stderr] 79 | | // Fit as much on one line as possible. [INFO] [stderr] 80 | | Compressed, [INFO] [stderr] 81 | | // Use more lines. [INFO] [stderr] ... | [INFO] [stderr] 86 | | Vertical, [INFO] [stderr] 87 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/utils.rs:251:21 [INFO] [stderr] | [INFO] [stderr] 251 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/config.rs:78:1 [INFO] [stderr] | [INFO] [stderr] 78 | / configuration_option_enum! { Density: [INFO] [stderr] 79 | | // Fit as much on one line as possible. [INFO] [stderr] 80 | | Compressed, [INFO] [stderr] 81 | | // Use more lines. [INFO] [stderr] ... | [INFO] [stderr] 86 | | Vertical, [INFO] [stderr] 87 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/utils.rs:221:21 [INFO] [stderr] | [INFO] [stderr] 221 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/config.rs:89:1 [INFO] [stderr] | [INFO] [stderr] 89 | / configuration_option_enum! { TypeDensity: [INFO] [stderr] 90 | | // No spaces around "=" and "+" [INFO] [stderr] 91 | | Compressed, [INFO] [stderr] 92 | | // Spaces around " = " and " + " [INFO] [stderr] 93 | | Wide, [INFO] [stderr] 94 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/utils.rs:251:21 [INFO] [stderr] | [INFO] [stderr] 251 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/config.rs:89:1 [INFO] [stderr] | [INFO] [stderr] 89 | / configuration_option_enum! { TypeDensity: [INFO] [stderr] 90 | | // No spaces around "=" and "+" [INFO] [stderr] 91 | | Compressed, [INFO] [stderr] 92 | | // Spaces around " = " and " + " [INFO] [stderr] 93 | | Wide, [INFO] [stderr] 94 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/utils.rs:221:21 [INFO] [stderr] | [INFO] [stderr] 221 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/config.rs:108:1 [INFO] [stderr] | [INFO] [stderr] 108 | / configuration_option_enum! { LicensePolicy: [INFO] [stderr] 109 | | // Do not place license text at top of files [INFO] [stderr] 110 | | NoLicense, [INFO] [stderr] 111 | | // Use the text in "license" field as the license [INFO] [stderr] ... | [INFO] [stderr] 114 | | FileLicense, [INFO] [stderr] 115 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/utils.rs:251:21 [INFO] [stderr] | [INFO] [stderr] 251 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/config.rs:108:1 [INFO] [stderr] | [INFO] [stderr] 108 | / configuration_option_enum! { LicensePolicy: [INFO] [stderr] 109 | | // Do not place license text at top of files [INFO] [stderr] 110 | | NoLicense, [INFO] [stderr] 111 | | // Use the text in "license" field as the license [INFO] [stderr] ... | [INFO] [stderr] 114 | | FileLicense, [INFO] [stderr] 115 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/utils.rs:221:21 [INFO] [stderr] | [INFO] [stderr] 221 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/config.rs:117:1 [INFO] [stderr] | [INFO] [stderr] 117 | / configuration_option_enum! { MultilineStyle: [INFO] [stderr] 118 | | // Use horizontal layout if it fits in one line, fall back to vertical [INFO] [stderr] 119 | | PreferSingle, [INFO] [stderr] 120 | | // Use vertical layout [INFO] [stderr] 121 | | ForceMulti, [INFO] [stderr] 122 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/utils.rs:251:21 [INFO] [stderr] | [INFO] [stderr] 251 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/config.rs:117:1 [INFO] [stderr] | [INFO] [stderr] 117 | / configuration_option_enum! { MultilineStyle: [INFO] [stderr] 118 | | // Use horizontal layout if it fits in one line, fall back to vertical [INFO] [stderr] 119 | | PreferSingle, [INFO] [stderr] 120 | | // Use vertical layout [INFO] [stderr] 121 | | ForceMulti, [INFO] [stderr] 122 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/utils.rs:221:21 [INFO] [stderr] | [INFO] [stderr] 221 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/config.rs:133:1 [INFO] [stderr] | [INFO] [stderr] 133 | / configuration_option_enum! { ReportTactic: [INFO] [stderr] 134 | | Always, [INFO] [stderr] 135 | | Unnumbered, [INFO] [stderr] 136 | | Never, [INFO] [stderr] 137 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/utils.rs:251:21 [INFO] [stderr] | [INFO] [stderr] 251 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/config.rs:133:1 [INFO] [stderr] | [INFO] [stderr] 133 | / configuration_option_enum! { ReportTactic: [INFO] [stderr] 134 | | Always, [INFO] [stderr] 135 | | Unnumbered, [INFO] [stderr] 136 | | Never, [INFO] [stderr] 137 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/utils.rs:221:21 [INFO] [stderr] | [INFO] [stderr] 221 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/config.rs:139:1 [INFO] [stderr] | [INFO] [stderr] 139 | / configuration_option_enum! { WriteMode: [INFO] [stderr] 140 | | // Backs the original file up and overwrites the original. [INFO] [stderr] 141 | | Replace, [INFO] [stderr] 142 | | // Overwrites original file without backup. [INFO] [stderr] ... | [INFO] [stderr] 153 | | Checkstyle, [INFO] [stderr] 154 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/utils.rs:251:21 [INFO] [stderr] | [INFO] [stderr] 251 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/config.rs:139:1 [INFO] [stderr] | [INFO] [stderr] 139 | / configuration_option_enum! { WriteMode: [INFO] [stderr] 140 | | // Backs the original file up and overwrites the original. [INFO] [stderr] 141 | | Replace, [INFO] [stderr] 142 | | // Overwrites original file without backup. [INFO] [stderr] ... | [INFO] [stderr] 153 | | Checkstyle, [INFO] [stderr] 154 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/utils.rs:221:21 [INFO] [stderr] | [INFO] [stderr] 221 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/lists.rs:39:1 [INFO] [stderr] | [INFO] [stderr] 39 | impl_enum_serialize_and_deserialize!(ListTactic, Vertical, Horizontal, HorizontalVertical, Mixed); [INFO] [stderr] | -------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/utils.rs:251:21 [INFO] [stderr] | [INFO] [stderr] 251 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/lists.rs:39:1 [INFO] [stderr] | [INFO] [stderr] 39 | impl_enum_serialize_and_deserialize!(ListTactic, Vertical, Horizontal, HorizontalVertical, Mixed); [INFO] [stderr] | -------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/utils.rs:221:21 [INFO] [stderr] | [INFO] [stderr] 221 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/lists.rs:48:1 [INFO] [stderr] | [INFO] [stderr] 48 | impl_enum_serialize_and_deserialize!(SeparatorTactic, Always, Never, Vertical); [INFO] [stderr] | ------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/utils.rs:251:21 [INFO] [stderr] | [INFO] [stderr] 251 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/lists.rs:48:1 [INFO] [stderr] | [INFO] [stderr] 48 | impl_enum_serialize_and_deserialize!(SeparatorTactic, Always, Never, Vertical); [INFO] [stderr] | ------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:441:5 [INFO] [stderr] | [INFO] [stderr] 441 | mut parse_session: &mut ParseSess, [INFO] [stderr] | ----^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:682:9 [INFO] [stderr] | [INFO] [stderr] 682 | let mut out = &mut stdout(); [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/macros.rs:71:9 [INFO] [stderr] | [INFO] [stderr] 71 | let mut context = &mut context.clone(); [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/config.rs:272:13 [INFO] [stderr] | [INFO] [stderr] 272 | / pub fn set<'a>(&'a mut self) -> ConfigSetter<'a> { [INFO] [stderr] 273 | | ConfigSetter(self) [INFO] [stderr] 274 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 481 | / create_config! { [INFO] [stderr] 482 | | verbose: bool, false, "Use verbose output"; [INFO] [stderr] 483 | | disable_all_formatting: bool, false, "Don't reformat anything"; [INFO] [stderr] 484 | | skip_children: bool, false, "Don't reformat out of line modules"; [INFO] [stderr] ... | [INFO] [stderr] 583 | | combine_control_expr: bool, true, "Combine control expressions with funciton calls." [INFO] [stderr] 584 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's keys [INFO] [stderr] --> src/config.rs:293:37 [INFO] [stderr] | [INFO] [stderr] 293 | for (key, _) in table { [INFO] [stderr] | ^^^^^ [INFO] [stderr] ... [INFO] [stderr] 481 | / create_config! { [INFO] [stderr] 482 | | verbose: bool, false, "Use verbose output"; [INFO] [stderr] 483 | | disable_all_formatting: bool, false, "Don't reformat anything"; [INFO] [stderr] 484 | | skip_children: bool, false, "Don't reformat out of line modules"; [INFO] [stderr] ... | [INFO] [stderr] 583 | | combine_control_expr: bool, true, "Combine control expressions with funciton calls." [INFO] [stderr] 584 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::for_kv_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 293 | for key in table.keys() { [INFO] [stderr] | ^^^ ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/filemap.rs:33:37 [INFO] [stderr] | [INFO] [stderr] 33 | pub fn write_all_files(file_map: &FileMap, out: &mut T, config: &Config) -> Result<(), io::Error> [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter_mut() and will not move the Vec [INFO] [stderr] --> src/file_lines.rs:96:35 [INFO] [stderr] | [INFO] [stderr] 96 | let mut iter = ranges.into_iter().peekable(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter_mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/file_lines.rs:98:32 [INFO] [stderr] | [INFO] [stderr] 98 | let mut next = next.clone(); [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*next` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/file_lines.rs:200:24 [INFO] [stderr] | [INFO] [stderr] 200 | m.entry(s).or_insert(vec![]).push(r); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| vec![])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/visitor.rs:141:9 [INFO] [stderr] | [INFO] [stderr] 141 | / let mut unindent_comment = self.is_if_else_block && !b.stmts.is_empty(); [INFO] [stderr] 142 | | if unindent_comment { [INFO] [stderr] 143 | | let end_pos = source!(self, b.span).hi - brace_compensation; [INFO] [stderr] 144 | | let snippet = self.get_context().snippet(mk_sp(self.last_pos, end_pos)); [INFO] [stderr] 145 | | unindent_comment = snippet.contains("//") || snippet.contains("/*"); [INFO] [stderr] 146 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let unindent_comment = if unindent_comment { ..; snippet.contains("//") || snippet.contains("/*") } else { self.is_if_else_block && !b.stmts.is_empty() };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/visitor.rs:770:21 [INFO] [stderr] | [INFO] [stderr] 770 | / format!( [INFO] [stderr] 771 | | "{}", [INFO] [stderr] 772 | | try_opt!(rewrite_comment(&value, false, doc_shape, context.config)) [INFO] [stderr] 773 | | ) [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] help: consider using .to_string() [INFO] [stderr] | [INFO] [stderr] 2 | $ crate :: fmt :: format ( match $expr { [INFO] [stderr] 3 | Some(val) => val, [INFO] [stderr] 4 | None => { return None; } [INFO] [stderr] 5 | }.to_string() ) ) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (12/7) [INFO] [stderr] --> src/items.rs:241:5 [INFO] [stderr] | [INFO] [stderr] 241 | / pub fn rewrite_fn( [INFO] [stderr] 242 | | &mut self, [INFO] [stderr] 243 | | indent: Indent, [INFO] [stderr] 244 | | ident: ast::Ident, [INFO] [stderr] ... | [INFO] [stderr] 299 | | self.single_line_fn(&result, block).or_else(|| Some(result)) [INFO] [stderr] 300 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/items.rs:503:35 [INFO] [stderr] | [INFO] [stderr] 503 | let missing_comment = rewrite_missing_comment_on_field( [INFO] [stderr] | ___________________________________^ [INFO] [stderr] 504 | | &context, [INFO] [stderr] 505 | | shape, [INFO] [stderr] 506 | | field.node.attrs[field.node.attrs.len() - 1].span.hi, [INFO] [stderr] 507 | | field.span.lo, [INFO] [stderr] 508 | | &mut result, [INFO] [stderr] 509 | | ).unwrap_or(String::new()); [INFO] [stderr] | |______________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 503 | let missing_comment = rewrite_missing_comment_on_field( [INFO] [stderr] 504 | &context, [INFO] [stderr] 505 | shape, [INFO] [stderr] 506 | field.node.attrs[field.node.attrs.len() - 1].span.hi, [INFO] [stderr] 507 | field.span.lo, [INFO] [stderr] 508 | &mut result, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you should use the `ends_with` method [INFO] [stderr] --> src/items.rs:653:12 [INFO] [stderr] | [INFO] [stderr] 653 | if result.chars().last().unwrap() == '{' { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: like this: `result.ends_with('{')` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::chars_last_cmp)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#chars_last_cmp [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/items.rs:860:1 [INFO] [stderr] | [INFO] [stderr] 860 | / pub fn format_struct( [INFO] [stderr] 861 | | context: &RewriteContext, [INFO] [stderr] 862 | | item_name: &str, [INFO] [stderr] 863 | | ident: ast::Ident, [INFO] [stderr] ... | [INFO] [stderr] 898 | | } [INFO] [stderr] 899 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/items.rs:1040:1 [INFO] [stderr] | [INFO] [stderr] 1040 | / fn format_struct_struct( [INFO] [stderr] 1041 | | context: &RewriteContext, [INFO] [stderr] 1042 | | item_name: &str, [INFO] [stderr] 1043 | | ident: ast::Ident, [INFO] [stderr] ... | [INFO] [stderr] 1151 | | } [INFO] [stderr] 1152 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/items.rs:1154:1 [INFO] [stderr] | [INFO] [stderr] 1154 | / fn format_tuple_struct( [INFO] [stderr] 1155 | | context: &RewriteContext, [INFO] [stderr] 1156 | | item_name: &str, [INFO] [stderr] 1157 | | ident: ast::Ident, [INFO] [stderr] ... | [INFO] [stderr] 1298 | | Some(result) [INFO] [stderr] 1299 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/items.rs:1265:57 [INFO] [stderr] | [INFO] [stderr] 1265 | if context.config.spaces_within_parens() && body.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!body.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/items.rs:1271:57 [INFO] [stderr] | [INFO] [stderr] 1271 | if context.config.spaces_within_parens() && body.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!body.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/items.rs:1427:13 [INFO] [stderr] | [INFO] [stderr] 1427 | / rewrite_missing_comment_on_field( [INFO] [stderr] 1428 | | context, [INFO] [stderr] 1429 | | shape, [INFO] [stderr] 1430 | | self.attrs[self.attrs.len() - 1].span.hi, [INFO] [stderr] 1431 | | self.span.lo, [INFO] [stderr] 1432 | | &mut attr_str, [INFO] [stderr] 1433 | | ).unwrap_or(String::new()) [INFO] [stderr] | |______________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 1427 | rewrite_missing_comment_on_field( [INFO] [stderr] 1428 | context, [INFO] [stderr] 1429 | shape, [INFO] [stderr] 1430 | self.attrs[self.attrs.len() - 1].span.hi, [INFO] [stderr] 1431 | self.span.lo, [INFO] [stderr] 1432 | &mut attr_str, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/items.rs:1508:1 [INFO] [stderr] | [INFO] [stderr] 1508 | / pub fn rewrite_static( [INFO] [stderr] 1509 | | prefix: &str, [INFO] [stderr] 1510 | | vis: &ast::Visibility, [INFO] [stderr] 1511 | | ident: ast::Ident, [INFO] [stderr] ... | [INFO] [stderr] 1564 | | } [INFO] [stderr] 1565 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/items.rs:1585:12 [INFO] [stderr] | [INFO] [stderr] 1585 | if bounds.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!bounds.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/items.rs:1754:50 [INFO] [stderr] | [INFO] [stderr] 1754 | ast::FunctionRetTy::Default(ref span) => span.clone(), [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*span` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 37 [INFO] [stderr] --> src/items.rs:1788:1 [INFO] [stderr] | [INFO] [stderr] 1788 | / fn rewrite_fn_base( [INFO] [stderr] 1789 | | context: &RewriteContext, [INFO] [stderr] 1790 | | indent: Indent, [INFO] [stderr] 1791 | | ident: ast::Ident, [INFO] [stderr] ... | [INFO] [stderr] 2115 | | return Some((result, force_new_line_for_brace)); [INFO] [stderr] 2116 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (14/7) [INFO] [stderr] --> src/items.rs:1788:1 [INFO] [stderr] | [INFO] [stderr] 1788 | / fn rewrite_fn_base( [INFO] [stderr] 1789 | | context: &RewriteContext, [INFO] [stderr] 1790 | | indent: Indent, [INFO] [stderr] 1791 | | ident: ast::Ident, [INFO] [stderr] ... | [INFO] [stderr] 2115 | | return Some((result, force_new_line_for_brace)); [INFO] [stderr] 2116 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/items.rs:1910:49 [INFO] [stderr] | [INFO] [stderr] 1910 | if context.config.spaces_within_parens() && fd.inputs.len() > 0 && result.ends_with('(') { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!fd.inputs.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/items.rs:1959:53 [INFO] [stderr] | [INFO] [stderr] 1959 | if context.config.spaces_within_parens() && fd.inputs.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!fd.inputs.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/items.rs:1964:61 [INFO] [stderr] | [INFO] [stderr] 1964 | if arg_str.lines().last().map_or(false, |last_line| { [INFO] [stderr] | _____________________________________________________________^ [INFO] [stderr] 1965 | | last_line.contains("//") [INFO] [stderr] 1966 | | }) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::block_in_if_condition_stmt)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> src/items.rs:2122:1 [INFO] [stderr] | [INFO] [stderr] 2122 | / fn rewrite_args( [INFO] [stderr] 2123 | | context: &RewriteContext, [INFO] [stderr] 2124 | | args: &[ast::Arg], [INFO] [stderr] 2125 | | explicit_self: Option<&ast::ExplicitSelf>, [INFO] [stderr] ... | [INFO] [stderr] 2276 | | write_list(&arg_items, &fmt) [INFO] [stderr] 2277 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/items.rs:2218:10 [INFO] [stderr] | [INFO] [stderr] 2218 | (arg_items.len() == 0 || arg_items.len() == 1 && arg_item_strs[0].len() <= one_line_budget); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `arg_items.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/items.rs:2477:24 [INFO] [stderr] | [INFO] [stderr] 2477 | type_param_bounds: &ast::TyParamBounds, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/items.rs:2554:1 [INFO] [stderr] | [INFO] [stderr] 2554 | / fn rewrite_where_clause( [INFO] [stderr] 2555 | | context: &RewriteContext, [INFO] [stderr] 2556 | | where_clause: &ast::WhereClause, [INFO] [stderr] 2557 | | brace_style: BraceStyle, [INFO] [stderr] ... | [INFO] [stderr] 2652 | | } [INFO] [stderr] 2653 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/items.rs:2659:1 [INFO] [stderr] | [INFO] [stderr] 2659 | / fn format_generics( [INFO] [stderr] 2660 | | context: &RewriteContext, [INFO] [stderr] 2661 | | generics: &ast::Generics, [INFO] [stderr] 2662 | | opener: &str, [INFO] [stderr] ... | [INFO] [stderr] 2712 | | Some(result) [INFO] [stderr] 2713 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/missed_spans.rs:93:36 [INFO] [stderr] | [INFO] [stderr] 93 | let snippet = self.snippet(span.clone()); [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `span` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/missed_spans.rs:185:40 [INFO] [stderr] | [INFO] [stderr] 185 | if let Some('/') = subslice.chars().skip(1).next() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_skip_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/missed_spans.rs:187:81 [INFO] [stderr] | [INFO] [stderr] 187 | if !subslice.split('\n').map(|s| s.trim_left()).any(|s| { [INFO] [stderr] | _________________________________________________________________________________^ [INFO] [stderr] 188 | | s.len() >= 2 && &s[0..2] == "/*" [INFO] [stderr] 189 | | }) [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/missed_spans.rs:221:55 [INFO] [stderr] | [INFO] [stderr] 221 | self.buffer.push_str(&snippet[line_start..i + 1]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use: `line_start..=i` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lists.rs:421:68 [INFO] [stderr] | [INFO] [stderr] 421 | post_snippet.find_uncommented(self.terminator).unwrap_or( [INFO] [stderr] | ____________________________________________________________________^ [INFO] [stderr] 422 | | post_snippet [INFO] [stderr] 423 | | .len(), [INFO] [stderr] 424 | | ) [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 421 | post_snippet.find_uncommented(self.terminator).unwrap_or_else(|| post_snippet [INFO] [stderr] 422 | .len()) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lists.rs:434:61 [INFO] [stderr] | [INFO] [stderr] 434 | let first_newline = test_snippet.find('\n').unwrap_or(test_snippet.len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| test_snippet.len())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lists.rs:437:77 [INFO] [stderr] | [INFO] [stderr] 437 | let first = test_snippet.find(|c: char| !c.is_whitespace()).unwrap_or( [INFO] [stderr] | _____________________________________________________________________________^ [INFO] [stderr] 438 | | test_snippet [INFO] [stderr] 439 | | .len(), [INFO] [stderr] 440 | | ); [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 437 | let first = test_snippet.find(|c: char| !c.is_whitespace()).unwrap_or_else(|| test_snippet [INFO] [stderr] 438 | .len()); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/lists.rs:479:1 [INFO] [stderr] | [INFO] [stderr] 479 | / pub fn itemize_list<'a, T, I, F1, F2, F3>( [INFO] [stderr] 480 | | codemap: &'a CodeMap, [INFO] [stderr] 481 | | inner: I, [INFO] [stderr] 482 | | terminator: &'a str, [INFO] [stderr] ... | [INFO] [stderr] 504 | | } [INFO] [stderr] 505 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/types.rs:402:73 [INFO] [stderr] | [INFO] [stderr] 402 | if context.config.spaces_within_angle_brackets() && lifetime_str.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!lifetime_str.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/types.rs:484:13 [INFO] [stderr] | [INFO] [stderr] 484 | / bounds [INFO] [stderr] 485 | | .into_iter() [INFO] [stderr] | |____________________________^ help: consider removing `.into_iter()`: `bounds` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/macros.rs:71:9 [INFO] [stderr] | [INFO] [stderr] 71 | let mut context = &mut context.clone(); [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/types.rs:600:17 [INFO] [stderr] | [INFO] [stderr] 600 | lifetime_str.len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!lifetime_str.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/types.rs:782:71 [INFO] [stderr] | [INFO] [stderr] 782 | pub fn join_bounds(context: &RewriteContext, shape: Shape, type_strs: &Vec) -> String { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/expr.rs:532:62 [INFO] [stderr] | [INFO] [stderr] 532 | if context.config.spaces_within_square_brackets() && list_str.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!list_str.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/expr.rs:1316:63 [INFO] [stderr] | [INFO] [stderr] 1316 | let first = missed_str.find(|c: char| !c.is_whitespace()).unwrap_or( [INFO] [stderr] | _______________________________________________________________^ [INFO] [stderr] 1317 | | missed_str [INFO] [stderr] 1318 | | .len(), [INFO] [stderr] 1319 | | ); [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 1316 | let first = missed_str.find(|c: char| !c.is_whitespace()).unwrap_or_else(|| missed_str [INFO] [stderr] 1317 | .len()); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/expr.rs:1989:9 [INFO] [stderr] | [INFO] [stderr] 1989 | / match args[args.len() - 1].node { [INFO] [stderr] 1990 | | ast::ExprKind::MethodCall(..) => context.force_one_line_chain = true, [INFO] [stderr] 1991 | | _ => (), [INFO] [stderr] 1992 | | } [INFO] [stderr] | |_________^ help: try this: `if let ast::ExprKind::MethodCall(..) = args[args.len() - 1].node { context.force_one_line_chain = true }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/expr.rs:2026:52 [INFO] [stderr] | [INFO] [stderr] 2026 | fn last_arg_shape(context: &RewriteContext, items: &Vec, shape: Shape) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[ListItem]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/expr.rs:2119:53 [INFO] [stderr] | [INFO] [stderr] 2119 | if context.config.spaces_within_parens() && args_str.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!args_str.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/expr.rs:2139:79 [INFO] [stderr] | [INFO] [stderr] 2139 | let paren_wrapper = |s: &str| if context.config.spaces_within_parens() && s.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!s.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/expr.rs:2226:8 [INFO] [stderr] | [INFO] [stderr] 2226 | if fields.len() == 0 && base.is_none() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `fields.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/expr.rs:2230:29 [INFO] [stderr] | [INFO] [stderr] 2230 | let field_iter = fields.into_iter().map(StructLitField::Regular).chain( [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/expr.rs:2400:49 [INFO] [stderr] | [INFO] [stderr] 2400 | if context.config.spaces_within_parens() && list_str.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!list_str.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/expr.rs:2460:9 [INFO] [stderr] | [INFO] [stderr] 2460 | op: &ast::UnOp, [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `ast::UnOp` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/expr.rs:2516:60 [INFO] [stderr] | [INFO] [stderr] 2516 | None if !context.snippet(ex.span).contains("\n") => { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: the `rhs @ _` pattern can be written as just `rhs` [INFO] [stderr] --> src/expr.rs:2519:17 [INFO] [stderr] | [INFO] [stderr] 2519 | rhs @ _ => rhs, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/imports.rs:77:14 [INFO] [stderr] | [INFO] [stderr] 77 | a_items: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 77 | a_items: &[ast::PathListItem], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: change `a_items.clone()` to [INFO] [stderr] | [INFO] [stderr] 80 | let mut a = a_items.to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/imports.rs:78:14 [INFO] [stderr] | [INFO] [stderr] 78 | b_items: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 78 | b_items: &[ast::PathListItem], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: change `b_items.clone()` to [INFO] [stderr] | [INFO] [stderr] 81 | let mut b = b_items.to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/imports.rs:136:19 [INFO] [stderr] | [INFO] [stderr] 136 | span: path.span.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `path.span` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/imports.rs:302:27 [INFO] [stderr] | [INFO] [stderr] 302 | fn rewrite_path_item(vpi: &&ast::PathListItem) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `&ast::PathListItem` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/issues.rs:24:19 [INFO] [stderr] | [INFO] [stderr] 24 | fn is_enabled(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/comment.rs:49:25 [INFO] [stderr] | [INFO] [stderr] 49 | &first_line[0..space_index + 1] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: use: `0..=space_index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/comment.rs:267:54 [INFO] [stderr] | [INFO] [stderr] 267 | let rewrite = rewrite_string(line, &fmt).unwrap_or(line.to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| line.to_owned())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/comment.rs:296:41 [INFO] [stderr] | [INFO] [stderr] 296 | if l.as_bytes()[fnw] == '*' as u8 && fnw > 0 { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'*' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/comment.rs:316:12 [INFO] [stderr] | [INFO] [stderr] 316 | } else if let &CommentStyle::Custom(opener) = style { [INFO] [stderr] | ____________^ [INFO] [stderr] 317 | | if line.starts_with(opener) { [INFO] [stderr] 318 | | &line[opener.len()..] [INFO] [stderr] 319 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 335 | | line [INFO] [stderr] 336 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 316 | } else if let CommentStyle::Custom(opener) = *style { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/comment.rs:461:19 [INFO] [stderr] | [INFO] [stderr] 461 | fn is_comment(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/comment.rs:470:24 [INFO] [stderr] | [INFO] [stderr] 470 | fn to_codecharkind(&self) -> CodeCharKind { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/modules.rs:79:9 [INFO] [stderr] | [INFO] [stderr] 79 | Err(_) => panic!("Couldn't find module {}", id), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 27 [INFO] [stderr] --> src/chains.rs:91:1 [INFO] [stderr] | [INFO] [stderr] 91 | / pub fn rewrite_chain(expr: &ast::Expr, context: &RewriteContext, shape: Shape) -> Option { [INFO] [stderr] 92 | | debug!("rewrite_chain {:?}", shape); [INFO] [stderr] 93 | | let total_span = expr.span; [INFO] [stderr] 94 | | let (parent, subexpr_list) = make_subexpr_list(expr, context); [INFO] [stderr] ... | [INFO] [stderr] 317 | | } [INFO] [stderr] 318 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/chains.rs:442:5 [INFO] [stderr] | [INFO] [stderr] 442 | / if let &ast::ExprKind::MethodCall(ref method_name, ref types, ref expressions) = expr_kind { [INFO] [stderr] 443 | | let shape = match shape.shrink_left(almost_total) { [INFO] [stderr] 444 | | Some(b) => b, [INFO] [stderr] 445 | | None => return false, [INFO] [stderr] ... | [INFO] [stderr] 463 | | unreachable!(); [INFO] [stderr] 464 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 442 | if let ast::ExprKind::MethodCall(ref method_name, ref types, ref expressions) = *expr_kind { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/chains.rs:580:76 [INFO] [stderr] | [INFO] [stderr] 580 | let type_str = if context.config.spaces_within_angle_brackets() && type_list.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!type_list.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/macros.rs:55:15 [INFO] [stderr] | [INFO] [stderr] 55 | fn opener(&self) -> &'static str { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/patterns.rs:152:8 [INFO] [stderr] | [INFO] [stderr] 152 | if fields.len() == 0 && !elipses { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `fields.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/patterns.rs:273:36 [INFO] [stderr] | [INFO] [stderr] 273 | let mut pat_vec: Vec<_> = pats.into_iter().map(|x| TuplePatField::Pat(x)).collect(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/config.rs:272:13 [INFO] [stderr] | [INFO] [stderr] 272 | / pub fn set<'a>(&'a mut self) -> ConfigSetter<'a> { [INFO] [stderr] 273 | | ConfigSetter(self) [INFO] [stderr] 274 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 481 | / create_config! { [INFO] [stderr] 482 | | verbose: bool, false, "Use verbose output"; [INFO] [stderr] 483 | | disable_all_formatting: bool, false, "Don't reformat anything"; [INFO] [stderr] 484 | | skip_children: bool, false, "Don't reformat out of line modules"; [INFO] [stderr] ... | [INFO] [stderr] 583 | | combine_control_expr: bool, true, "Combine control expressions with funciton calls." [INFO] [stderr] 584 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `summary::Summary` [INFO] [stderr] --> src/summary.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | / pub fn new() -> Summary { [INFO] [stderr] 19 | | Summary { [INFO] [stderr] 20 | | has_operational_errors: false, [INFO] [stderr] 21 | | has_parsing_errors: false, [INFO] [stderr] ... | [INFO] [stderr] 24 | | } [INFO] [stderr] 25 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 3 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's keys [INFO] [stderr] --> src/config.rs:293:37 [INFO] [stderr] | [INFO] [stderr] 293 | for (key, _) in table { [INFO] [stderr] | ^^^^^ [INFO] [stderr] ... [INFO] [stderr] 481 | / create_config! { [INFO] [stderr] 482 | | verbose: bool, false, "Use verbose output"; [INFO] [stderr] 483 | | disable_all_formatting: bool, false, "Don't reformat anything"; [INFO] [stderr] 484 | | skip_children: bool, false, "Don't reformat out of line modules"; [INFO] [stderr] ... | [INFO] [stderr] 583 | | combine_control_expr: bool, true, "Combine control expressions with funciton calls." [INFO] [stderr] 584 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::for_kv_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 293 | for key in table.keys() { [INFO] [stderr] | ^^^ ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/lib.rs:409:45 [INFO] [stderr] | [INFO] [stderr] 409 | .map(|(_, errors)| errors.len()) [INFO] [stderr] | _____________________________________________^ [INFO] [stderr] 410 | | .fold(0, |acc, x| acc + x) [INFO] [stderr] | |______________________________________^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/rustfmt.rs:379:13 [INFO] [stderr] | [INFO] [stderr] 379 | config_path: config_path, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `config_path` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/rustfmt.rs:395:9 [INFO] [stderr] | [INFO] [stderr] 395 | files: files, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `files` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/rustfmt.rs:396:9 [INFO] [stderr] | [INFO] [stderr] 396 | config_path: config_path, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `config_path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/rustfmt.rs:397:9 [INFO] [stderr] | [INFO] [stderr] 397 | minimal_config_path: minimal_config_path, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `minimal_config_path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/bin/cargo-fmt.rs:279:9 [INFO] [stderr] | [INFO] [stderr] 279 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/bin/cargo-fmt.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | #![deny(warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::redundant_field_names)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/bin/cargo-fmt.rs:280:9 [INFO] [stderr] | [INFO] [stderr] 280 | kind: kind, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: using `println!("")` [INFO] [stderr] --> src/bin/cargo-fmt.rs:302:9 [INFO] [stderr] | [INFO] [stderr] 302 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/bin/cargo-fmt.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | #![deny(warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::println_empty_string)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/filemap.rs:33:37 [INFO] [stderr] | [INFO] [stderr] 33 | pub fn write_all_files(file_map: &FileMap, out: &mut T, config: &Config) -> Result<(), io::Error> [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter_mut() and will not move the Vec [INFO] [stderr] --> src/file_lines.rs:96:35 [INFO] [stderr] | [INFO] [stderr] 96 | let mut iter = ranges.into_iter().peekable(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter_mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/file_lines.rs:98:32 [INFO] [stderr] | [INFO] [stderr] 98 | let mut next = next.clone(); [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*next` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/file_lines.rs:200:24 [INFO] [stderr] | [INFO] [stderr] 200 | m.entry(s).or_insert(vec![]).push(r); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| vec![])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/visitor.rs:141:9 [INFO] [stderr] | [INFO] [stderr] 141 | / let mut unindent_comment = self.is_if_else_block && !b.stmts.is_empty(); [INFO] [stderr] 142 | | if unindent_comment { [INFO] [stderr] 143 | | let end_pos = source!(self, b.span).hi - brace_compensation; [INFO] [stderr] 144 | | let snippet = self.get_context().snippet(mk_sp(self.last_pos, end_pos)); [INFO] [stderr] 145 | | unindent_comment = snippet.contains("//") || snippet.contains("/*"); [INFO] [stderr] 146 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let unindent_comment = if unindent_comment { ..; snippet.contains("//") || snippet.contains("/*") } else { self.is_if_else_block && !b.stmts.is_empty() };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/visitor.rs:770:21 [INFO] [stderr] | [INFO] [stderr] 770 | / format!( [INFO] [stderr] 771 | | "{}", [INFO] [stderr] 772 | | try_opt!(rewrite_comment(&value, false, doc_shape, context.config)) [INFO] [stderr] 773 | | ) [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] help: consider using .to_string() [INFO] [stderr] | [INFO] [stderr] 2 | $ crate :: fmt :: format ( match $expr { [INFO] [stderr] 3 | Some(val) => val, [INFO] [stderr] 4 | None => { return None; } [INFO] [stderr] 5 | }.to_string() ) ) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (12/7) [INFO] [stderr] --> src/items.rs:241:5 [INFO] [stderr] | [INFO] [stderr] 241 | / pub fn rewrite_fn( [INFO] [stderr] 242 | | &mut self, [INFO] [stderr] 243 | | indent: Indent, [INFO] [stderr] 244 | | ident: ast::Ident, [INFO] [stderr] ... | [INFO] [stderr] 299 | | self.single_line_fn(&result, block).or_else(|| Some(result)) [INFO] [stderr] 300 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/items.rs:503:35 [INFO] [stderr] | [INFO] [stderr] 503 | let missing_comment = rewrite_missing_comment_on_field( [INFO] [stderr] | ___________________________________^ [INFO] [stderr] 504 | | &context, [INFO] [stderr] 505 | | shape, [INFO] [stderr] 506 | | field.node.attrs[field.node.attrs.len() - 1].span.hi, [INFO] [stderr] 507 | | field.span.lo, [INFO] [stderr] 508 | | &mut result, [INFO] [stderr] 509 | | ).unwrap_or(String::new()); [INFO] [stderr] | |______________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 503 | let missing_comment = rewrite_missing_comment_on_field( [INFO] [stderr] 504 | &context, [INFO] [stderr] 505 | shape, [INFO] [stderr] 506 | field.node.attrs[field.node.attrs.len() - 1].span.hi, [INFO] [stderr] 507 | field.span.lo, [INFO] [stderr] 508 | &mut result, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you should use the `ends_with` method [INFO] [stderr] --> src/items.rs:653:12 [INFO] [stderr] | [INFO] [stderr] 653 | if result.chars().last().unwrap() == '{' { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: like this: `result.ends_with('{')` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::chars_last_cmp)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#chars_last_cmp [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/items.rs:860:1 [INFO] [stderr] | [INFO] [stderr] 860 | / pub fn format_struct( [INFO] [stderr] 861 | | context: &RewriteContext, [INFO] [stderr] 862 | | item_name: &str, [INFO] [stderr] 863 | | ident: ast::Ident, [INFO] [stderr] ... | [INFO] [stderr] 898 | | } [INFO] [stderr] 899 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/items.rs:1040:1 [INFO] [stderr] | [INFO] [stderr] 1040 | / fn format_struct_struct( [INFO] [stderr] 1041 | | context: &RewriteContext, [INFO] [stderr] 1042 | | item_name: &str, [INFO] [stderr] 1043 | | ident: ast::Ident, [INFO] [stderr] ... | [INFO] [stderr] 1151 | | } [INFO] [stderr] 1152 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/items.rs:1154:1 [INFO] [stderr] | [INFO] [stderr] 1154 | / fn format_tuple_struct( [INFO] [stderr] 1155 | | context: &RewriteContext, [INFO] [stderr] 1156 | | item_name: &str, [INFO] [stderr] 1157 | | ident: ast::Ident, [INFO] [stderr] ... | [INFO] [stderr] 1298 | | Some(result) [INFO] [stderr] 1299 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/items.rs:1265:57 [INFO] [stderr] | [INFO] [stderr] 1265 | if context.config.spaces_within_parens() && body.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!body.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/items.rs:1271:57 [INFO] [stderr] | [INFO] [stderr] 1271 | if context.config.spaces_within_parens() && body.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!body.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/items.rs:1427:13 [INFO] [stderr] | [INFO] [stderr] 1427 | / rewrite_missing_comment_on_field( [INFO] [stderr] 1428 | | context, [INFO] [stderr] 1429 | | shape, [INFO] [stderr] 1430 | | self.attrs[self.attrs.len() - 1].span.hi, [INFO] [stderr] 1431 | | self.span.lo, [INFO] [stderr] 1432 | | &mut attr_str, [INFO] [stderr] 1433 | | ).unwrap_or(String::new()) [INFO] [stderr] | |______________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 1427 | rewrite_missing_comment_on_field( [INFO] [stderr] 1428 | context, [INFO] [stderr] 1429 | shape, [INFO] [stderr] 1430 | self.attrs[self.attrs.len() - 1].span.hi, [INFO] [stderr] 1431 | self.span.lo, [INFO] [stderr] 1432 | &mut attr_str, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/items.rs:1508:1 [INFO] [stderr] | [INFO] [stderr] 1508 | / pub fn rewrite_static( [INFO] [stderr] 1509 | | prefix: &str, [INFO] [stderr] 1510 | | vis: &ast::Visibility, [INFO] [stderr] 1511 | | ident: ast::Ident, [INFO] [stderr] ... | [INFO] [stderr] 1564 | | } [INFO] [stderr] 1565 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/items.rs:1585:12 [INFO] [stderr] | [INFO] [stderr] 1585 | if bounds.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!bounds.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/items.rs:1754:50 [INFO] [stderr] | [INFO] [stderr] 1754 | ast::FunctionRetTy::Default(ref span) => span.clone(), [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*span` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 37 [INFO] [stderr] --> src/items.rs:1788:1 [INFO] [stderr] | [INFO] [stderr] 1788 | / fn rewrite_fn_base( [INFO] [stderr] 1789 | | context: &RewriteContext, [INFO] [stderr] 1790 | | indent: Indent, [INFO] [stderr] 1791 | | ident: ast::Ident, [INFO] [stderr] ... | [INFO] [stderr] 2115 | | return Some((result, force_new_line_for_brace)); [INFO] [stderr] 2116 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (14/7) [INFO] [stderr] --> src/items.rs:1788:1 [INFO] [stderr] | [INFO] [stderr] 1788 | / fn rewrite_fn_base( [INFO] [stderr] 1789 | | context: &RewriteContext, [INFO] [stderr] 1790 | | indent: Indent, [INFO] [stderr] 1791 | | ident: ast::Ident, [INFO] [stderr] ... | [INFO] [stderr] 2115 | | return Some((result, force_new_line_for_brace)); [INFO] [stderr] 2116 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/items.rs:1910:49 [INFO] [stderr] | [INFO] [stderr] 1910 | if context.config.spaces_within_parens() && fd.inputs.len() > 0 && result.ends_with('(') { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!fd.inputs.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/items.rs:1959:53 [INFO] [stderr] | [INFO] [stderr] 1959 | if context.config.spaces_within_parens() && fd.inputs.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!fd.inputs.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/items.rs:1964:61 [INFO] [stderr] | [INFO] [stderr] 1964 | if arg_str.lines().last().map_or(false, |last_line| { [INFO] [stderr] | _____________________________________________________________^ [INFO] [stderr] 1965 | | last_line.contains("//") [INFO] [stderr] 1966 | | }) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::block_in_if_condition_stmt)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> src/items.rs:2122:1 [INFO] [stderr] | [INFO] [stderr] 2122 | / fn rewrite_args( [INFO] [stderr] 2123 | | context: &RewriteContext, [INFO] [stderr] 2124 | | args: &[ast::Arg], [INFO] [stderr] 2125 | | explicit_self: Option<&ast::ExplicitSelf>, [INFO] [stderr] ... | [INFO] [stderr] 2276 | | write_list(&arg_items, &fmt) [INFO] [stderr] 2277 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/items.rs:2218:10 [INFO] [stderr] | [INFO] [stderr] 2218 | (arg_items.len() == 0 || arg_items.len() == 1 && arg_item_strs[0].len() <= one_line_budget); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `arg_items.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/items.rs:2477:24 [INFO] [stderr] | [INFO] [stderr] 2477 | type_param_bounds: &ast::TyParamBounds, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/items.rs:2554:1 [INFO] [stderr] | [INFO] [stderr] 2554 | / fn rewrite_where_clause( [INFO] [stderr] 2555 | | context: &RewriteContext, [INFO] [stderr] 2556 | | where_clause: &ast::WhereClause, [INFO] [stderr] 2557 | | brace_style: BraceStyle, [INFO] [stderr] ... | [INFO] [stderr] 2652 | | } [INFO] [stderr] 2653 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/items.rs:2659:1 [INFO] [stderr] | [INFO] [stderr] 2659 | / fn format_generics( [INFO] [stderr] 2660 | | context: &RewriteContext, [INFO] [stderr] 2661 | | generics: &ast::Generics, [INFO] [stderr] 2662 | | opener: &str, [INFO] [stderr] ... | [INFO] [stderr] 2712 | | Some(result) [INFO] [stderr] 2713 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/missed_spans.rs:93:36 [INFO] [stderr] | [INFO] [stderr] 93 | let snippet = self.snippet(span.clone()); [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `span` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/missed_spans.rs:185:40 [INFO] [stderr] | [INFO] [stderr] 185 | if let Some('/') = subslice.chars().skip(1).next() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_skip_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/missed_spans.rs:187:81 [INFO] [stderr] | [INFO] [stderr] 187 | if !subslice.split('\n').map(|s| s.trim_left()).any(|s| { [INFO] [stderr] | _________________________________________________________________________________^ [INFO] [stderr] 188 | | s.len() >= 2 && &s[0..2] == "/*" [INFO] [stderr] 189 | | }) [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/missed_spans.rs:221:55 [INFO] [stderr] | [INFO] [stderr] 221 | self.buffer.push_str(&snippet[line_start..i + 1]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use: `line_start..=i` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lists.rs:421:68 [INFO] [stderr] | [INFO] [stderr] 421 | post_snippet.find_uncommented(self.terminator).unwrap_or( [INFO] [stderr] | ____________________________________________________________________^ [INFO] [stderr] 422 | | post_snippet [INFO] [stderr] 423 | | .len(), [INFO] [stderr] 424 | | ) [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 421 | post_snippet.find_uncommented(self.terminator).unwrap_or_else(|| post_snippet [INFO] [stderr] 422 | .len()) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lists.rs:434:61 [INFO] [stderr] | [INFO] [stderr] 434 | let first_newline = test_snippet.find('\n').unwrap_or(test_snippet.len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| test_snippet.len())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lists.rs:437:77 [INFO] [stderr] | [INFO] [stderr] 437 | let first = test_snippet.find(|c: char| !c.is_whitespace()).unwrap_or( [INFO] [stderr] | _____________________________________________________________________________^ [INFO] [stderr] 438 | | test_snippet [INFO] [stderr] 439 | | .len(), [INFO] [stderr] 440 | | ); [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 437 | let first = test_snippet.find(|c: char| !c.is_whitespace()).unwrap_or_else(|| test_snippet [INFO] [stderr] 438 | .len()); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/lists.rs:479:1 [INFO] [stderr] | [INFO] [stderr] 479 | / pub fn itemize_list<'a, T, I, F1, F2, F3>( [INFO] [stderr] 480 | | codemap: &'a CodeMap, [INFO] [stderr] 481 | | inner: I, [INFO] [stderr] 482 | | terminator: &'a str, [INFO] [stderr] ... | [INFO] [stderr] 504 | | } [INFO] [stderr] 505 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/types.rs:402:73 [INFO] [stderr] | [INFO] [stderr] 402 | if context.config.spaces_within_angle_brackets() && lifetime_str.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!lifetime_str.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/types.rs:484:13 [INFO] [stderr] | [INFO] [stderr] 484 | / bounds [INFO] [stderr] 485 | | .into_iter() [INFO] [stderr] | |____________________________^ help: consider removing `.into_iter()`: `bounds` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/types.rs:600:17 [INFO] [stderr] | [INFO] [stderr] 600 | lifetime_str.len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!lifetime_str.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/types.rs:782:71 [INFO] [stderr] | [INFO] [stderr] 782 | pub fn join_bounds(context: &RewriteContext, shape: Shape, type_strs: &Vec) -> String { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/expr.rs:532:62 [INFO] [stderr] | [INFO] [stderr] 532 | if context.config.spaces_within_square_brackets() && list_str.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!list_str.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/expr.rs:1316:63 [INFO] [stderr] | [INFO] [stderr] 1316 | let first = missed_str.find(|c: char| !c.is_whitespace()).unwrap_or( [INFO] [stderr] | _______________________________________________________________^ [INFO] [stderr] 1317 | | missed_str [INFO] [stderr] 1318 | | .len(), [INFO] [stderr] 1319 | | ); [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 1316 | let first = missed_str.find(|c: char| !c.is_whitespace()).unwrap_or_else(|| missed_str [INFO] [stderr] 1317 | .len()); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/expr.rs:1989:9 [INFO] [stderr] | [INFO] [stderr] 1989 | / match args[args.len() - 1].node { [INFO] [stderr] 1990 | | ast::ExprKind::MethodCall(..) => context.force_one_line_chain = true, [INFO] [stderr] 1991 | | _ => (), [INFO] [stderr] 1992 | | } [INFO] [stderr] | |_________^ help: try this: `if let ast::ExprKind::MethodCall(..) = args[args.len() - 1].node { context.force_one_line_chain = true }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/expr.rs:2026:52 [INFO] [stderr] | [INFO] [stderr] 2026 | fn last_arg_shape(context: &RewriteContext, items: &Vec, shape: Shape) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[ListItem]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/expr.rs:2119:53 [INFO] [stderr] | [INFO] [stderr] 2119 | if context.config.spaces_within_parens() && args_str.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!args_str.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/expr.rs:2139:79 [INFO] [stderr] | [INFO] [stderr] 2139 | let paren_wrapper = |s: &str| if context.config.spaces_within_parens() && s.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!s.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/expr.rs:2226:8 [INFO] [stderr] | [INFO] [stderr] 2226 | if fields.len() == 0 && base.is_none() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `fields.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/expr.rs:2230:29 [INFO] [stderr] | [INFO] [stderr] 2230 | let field_iter = fields.into_iter().map(StructLitField::Regular).chain( [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/expr.rs:2400:49 [INFO] [stderr] | [INFO] [stderr] 2400 | if context.config.spaces_within_parens() && list_str.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!list_str.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/expr.rs:2460:9 [INFO] [stderr] | [INFO] [stderr] 2460 | op: &ast::UnOp, [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `ast::UnOp` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/expr.rs:2516:60 [INFO] [stderr] | [INFO] [stderr] 2516 | None if !context.snippet(ex.span).contains("\n") => { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: the `rhs @ _` pattern can be written as just `rhs` [INFO] [stderr] --> src/expr.rs:2519:17 [INFO] [stderr] | [INFO] [stderr] 2519 | rhs @ _ => rhs, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/imports.rs:77:14 [INFO] [stderr] | [INFO] [stderr] 77 | a_items: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 77 | a_items: &[ast::PathListItem], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: change `a_items.clone()` to [INFO] [stderr] | [INFO] [stderr] 80 | let mut a = a_items.to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/imports.rs:78:14 [INFO] [stderr] | [INFO] [stderr] 78 | b_items: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 78 | b_items: &[ast::PathListItem], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: change `b_items.clone()` to [INFO] [stderr] | [INFO] [stderr] 81 | let mut b = b_items.to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/imports.rs:136:19 [INFO] [stderr] | [INFO] [stderr] 136 | span: path.span.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `path.span` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/imports.rs:302:27 [INFO] [stderr] | [INFO] [stderr] 302 | fn rewrite_path_item(vpi: &&ast::PathListItem) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `&ast::PathListItem` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/issues.rs:24:19 [INFO] [stderr] | [INFO] [stderr] 24 | fn is_enabled(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/comment.rs:49:25 [INFO] [stderr] | [INFO] [stderr] 49 | &first_line[0..space_index + 1] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: use: `0..=space_index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/comment.rs:267:54 [INFO] [stderr] | [INFO] [stderr] 267 | let rewrite = rewrite_string(line, &fmt).unwrap_or(line.to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| line.to_owned())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/comment.rs:296:41 [INFO] [stderr] | [INFO] [stderr] 296 | if l.as_bytes()[fnw] == '*' as u8 && fnw > 0 { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'*' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/comment.rs:316:12 [INFO] [stderr] | [INFO] [stderr] 316 | } else if let &CommentStyle::Custom(opener) = style { [INFO] [stderr] | ____________^ [INFO] [stderr] 317 | | if line.starts_with(opener) { [INFO] [stderr] 318 | | &line[opener.len()..] [INFO] [stderr] 319 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 335 | | line [INFO] [stderr] 336 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 316 | } else if let CommentStyle::Custom(opener) = *style { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/comment.rs:461:19 [INFO] [stderr] | [INFO] [stderr] 461 | fn is_comment(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/comment.rs:470:24 [INFO] [stderr] | [INFO] [stderr] 470 | fn to_codecharkind(&self) -> CodeCharKind { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/modules.rs:79:9 [INFO] [stderr] | [INFO] [stderr] 79 | Err(_) => panic!("Couldn't find module {}", id), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 27 [INFO] [stderr] --> src/chains.rs:91:1 [INFO] [stderr] | [INFO] [stderr] 91 | / pub fn rewrite_chain(expr: &ast::Expr, context: &RewriteContext, shape: Shape) -> Option { [INFO] [stderr] 92 | | debug!("rewrite_chain {:?}", shape); [INFO] [stderr] 93 | | let total_span = expr.span; [INFO] [stderr] 94 | | let (parent, subexpr_list) = make_subexpr_list(expr, context); [INFO] [stderr] ... | [INFO] [stderr] 317 | | } [INFO] [stderr] 318 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/chains.rs:442:5 [INFO] [stderr] | [INFO] [stderr] 442 | / if let &ast::ExprKind::MethodCall(ref method_name, ref types, ref expressions) = expr_kind { [INFO] [stderr] 443 | | let shape = match shape.shrink_left(almost_total) { [INFO] [stderr] 444 | | Some(b) => b, [INFO] [stderr] 445 | | None => return false, [INFO] [stderr] ... | [INFO] [stderr] 463 | | unreachable!(); [INFO] [stderr] 464 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 442 | if let ast::ExprKind::MethodCall(ref method_name, ref types, ref expressions) = *expr_kind { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/chains.rs:580:76 [INFO] [stderr] | [INFO] [stderr] 580 | let type_str = if context.config.spaces_within_angle_brackets() && type_list.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!type_list.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/macros.rs:55:15 [INFO] [stderr] | [INFO] [stderr] 55 | fn opener(&self) -> &'static str { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/patterns.rs:152:8 [INFO] [stderr] | [INFO] [stderr] 152 | if fields.len() == 0 && !elipses { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `fields.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/patterns.rs:273:36 [INFO] [stderr] | [INFO] [stderr] 273 | let mut pat_vec: Vec<_> = pats.into_iter().map(|x| TuplePatField::Pat(x)).collect(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `summary::Summary` [INFO] [stderr] --> src/summary.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | / pub fn new() -> Summary { [INFO] [stderr] 19 | | Summary { [INFO] [stderr] 20 | | has_operational_errors: false, [INFO] [stderr] 21 | | has_parsing_errors: false, [INFO] [stderr] ... | [INFO] [stderr] 24 | | } [INFO] [stderr] 25 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 3 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/lib.rs:409:45 [INFO] [stderr] | [INFO] [stderr] 409 | .map(|(_, errors)| errors.len()) [INFO] [stderr] | _____________________________________________^ [INFO] [stderr] 410 | | .fold(0, |acc, x| acc + x) [INFO] [stderr] | |______________________________________^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rustfmt`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/bin/rustfmt.rs:110:57 [INFO] [stderr] | [INFO] [stderr] 110 | Config::from_resolved_toml_path(input_file).map_err(|e| FmtError::from(e)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `FmtError::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: the `path @ _` pattern can be written as just `path` [INFO] [stderr] --> src/bin/rustfmt.rs:366:9 [INFO] [stderr] | [INFO] [stderr] 366 | path @ _ => path, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "108f816b21b8da6f9805364d9d074a4fb505e6d98a40dc668a4f2bba7d36a94b"` [INFO] running `"docker" "rm" "-f" "108f816b21b8da6f9805364d9d074a4fb505e6d98a40dc668a4f2bba7d36a94b"` [INFO] [stdout] 108f816b21b8da6f9805364d9d074a4fb505e6d98a40dc668a4f2bba7d36a94b