[INFO] crate rustfm-scrobble 0.9.1 is already in cache [INFO] extracting crate rustfm-scrobble 0.9.1 into work/ex/clippy-test-run/sources/stable/reg/rustfm-scrobble/0.9.1 [INFO] extracting crate rustfm-scrobble 0.9.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rustfm-scrobble/0.9.1 [INFO] validating manifest of rustfm-scrobble-0.9.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rustfm-scrobble-0.9.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rustfm-scrobble-0.9.1 [INFO] finished frobbing rustfm-scrobble-0.9.1 [INFO] frobbed toml for rustfm-scrobble-0.9.1 written to work/ex/clippy-test-run/sources/stable/reg/rustfm-scrobble/0.9.1/Cargo.toml [INFO] started frobbing rustfm-scrobble-0.9.1 [INFO] finished frobbing rustfm-scrobble-0.9.1 [INFO] frobbed toml for rustfm-scrobble-0.9.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rustfm-scrobble/0.9.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rustfm-scrobble-0.9.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rustfm-scrobble/0.9.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 829bd2eec65a976f519c86403d7d7c8ba261e82864d184d5ee5ef91cb3bafb1f [INFO] running `"docker" "start" "-a" "829bd2eec65a976f519c86403d7d7c8ba261e82864d184d5ee5ef91cb3bafb1f"` [INFO] [stderr] Compiling wrapped-vec v0.2.1 [INFO] [stderr] Checking reqwest v0.7.3 [INFO] [stderr] Checking rustfm-scrobble v0.9.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scrobbler.rs:23:21 [INFO] [stderr] | [INFO] [stderr] 23 | Scrobbler { client: client } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `client` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scrobbler.rs:102:26 [INFO] [stderr] | [INFO] [stderr] 102 | ScrobblerError { err_msg: err_msg } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `err_msg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | http_client: http_client, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `http_client` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/auth.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | api_key: api_key, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `api_key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/auth.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | api_secret: api_secret, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `api_secret` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/auth.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | username: username, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `username` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/auth.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | password: password [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `password` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/models.rs:123:23 [INFO] [stderr] | [INFO] [stderr] 123 | Scrobble{ artist: artist, track: track, album: album, timestamp: None } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `artist` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/models.rs:123:39 [INFO] [stderr] | [INFO] [stderr] 123 | Scrobble{ artist: artist, track: track, album: album, timestamp: None } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `track` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/models.rs:123:53 [INFO] [stderr] | [INFO] [stderr] 123 | Scrobble{ artist: artist, track: track, album: album, timestamp: None } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `album` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scrobbler.rs:23:21 [INFO] [stderr] | [INFO] [stderr] 23 | Scrobbler { client: client } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `client` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scrobbler.rs:102:26 [INFO] [stderr] | [INFO] [stderr] 102 | ScrobblerError { err_msg: err_msg } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `err_msg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | http_client: http_client, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `http_client` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/auth.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | api_key: api_key, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `api_key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/auth.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | api_secret: api_secret, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `api_secret` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/auth.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | username: username, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `username` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/auth.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | password: password [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `password` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/models.rs:123:23 [INFO] [stderr] | [INFO] [stderr] 123 | Scrobble{ artist: artist, track: track, album: album, timestamp: None } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `artist` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/models.rs:123:39 [INFO] [stderr] | [INFO] [stderr] 123 | Scrobble{ artist: artist, track: track, album: album, timestamp: None } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `track` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/models.rs:123:53 [INFO] [stderr] | [INFO] [stderr] 123 | Scrobble{ artist: artist, track: track, album: album, timestamp: None } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `album` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/scrobbler.rs:60:47 [INFO] [stderr] | [INFO] [stderr] 60 | params.entry("timestamp".to_string()).or_insert(format!("{}", UNIX_EPOCH.elapsed().unwrap().as_secs())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| format!("{}", UNIX_EPOCH.elapsed().unwrap().as_secs()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/scrobbler.rs:72:60 [INFO] [stderr] | [INFO] [stderr] 72 | scrobble_params.entry("timestamp".to_string()).or_insert(format!("{}", UNIX_EPOCH.elapsed().unwrap().as_secs())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| format!("{}", UNIX_EPOCH.elapsed().unwrap().as_secs()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/scrobbler.rs:60:47 [INFO] [stderr] | [INFO] [stderr] 60 | params.entry("timestamp".to_string()).or_insert(format!("{}", UNIX_EPOCH.elapsed().unwrap().as_secs())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| format!("{}", UNIX_EPOCH.elapsed().unwrap().as_secs()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/scrobbler.rs:72:60 [INFO] [stderr] | [INFO] [stderr] 72 | scrobble_params.entry("timestamp".to_string()).or_insert(format!("{}", UNIX_EPOCH.elapsed().unwrap().as_secs())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| format!("{}", UNIX_EPOCH.elapsed().unwrap().as_secs()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'rustfm_scrobble::Scrobbler::authenticate': Use `authenticate_with_password` or `authenticate_with_session_key` [INFO] [stderr] --> examples/example.rs:23:21 [INFO] [stderr] | [INFO] [stderr] 23 | match scrobbler.authenticate(username, password) { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 23.37s [INFO] running `"docker" "inspect" "829bd2eec65a976f519c86403d7d7c8ba261e82864d184d5ee5ef91cb3bafb1f"` [INFO] running `"docker" "rm" "-f" "829bd2eec65a976f519c86403d7d7c8ba261e82864d184d5ee5ef91cb3bafb1f"` [INFO] [stdout] 829bd2eec65a976f519c86403d7d7c8ba261e82864d184d5ee5ef91cb3bafb1f