[INFO] crate rustface 0.1.1 is already in cache [INFO] extracting crate rustface 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/rustface/0.1.1 [INFO] extracting crate rustface 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rustface/0.1.1 [INFO] validating manifest of rustface-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rustface-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rustface-0.1.1 [INFO] finished frobbing rustface-0.1.1 [INFO] frobbed toml for rustface-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/rustface/0.1.1/Cargo.toml [INFO] started frobbing rustface-0.1.1 [INFO] finished frobbing rustface-0.1.1 [INFO] frobbed toml for rustface-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rustface/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rustface-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rustface/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ba91d3ec6f57c45d3332ce7a5d26b5a2bde39aff7349f14052abd4df557b3d26 [INFO] running `"docker" "start" "-a" "ba91d3ec6f57c45d3332ce7a5d26b5a2bde39aff7349f14052abd4df557b3d26"` [INFO] [stderr] Checking num-bigint v0.2.2 [INFO] [stderr] Checking png v0.11.0 [INFO] [stderr] Checking nalgebra v0.11.2 [INFO] [stderr] Checking rayon v0.7.1 [INFO] [stderr] Checking criterion v0.2.9 [INFO] [stderr] Checking quickcheck v0.2.27 [INFO] [stderr] Checking image v0.18.0 [INFO] [stderr] Checking num-rational v0.2.1 [INFO] [stderr] Checking num v0.2.0 [INFO] [stderr] Checking rustface v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/detector/mod.rs:364:37 [INFO] [stderr] | [INFO] [stderr] 364 | let h = bboxes[m].bbox().height() as f32; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/classifier/surf_mlp_classifier.rs:210:28 [INFO] [stderr] | [INFO] [stderr] 210 | dest = dest.offset(offset as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `dest.add(offset)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/detector/mod.rs:63:12 [INFO] [stderr] | [INFO] [stderr] 63 | if step_x <= 0 { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using step_x == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/detector/mod.rs:66:12 [INFO] [stderr] | [INFO] [stderr] 66 | if step_y <= 0 { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using step_y == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/feat/lab_boosted_featmap.rs:237:22 [INFO] [stderr] | [INFO] [stderr] 237 | for i in 1..(height + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: use: `1..=height` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/feat/lab_boosted_featmap.rs:262:22 [INFO] [stderr] | [INFO] [stderr] 262 | for r in 0..(height + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: use: `0..=height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/feat/lab_boosted_featmap.rs:263:26 [INFO] [stderr] | [INFO] [stderr] 263 | for c in 0..(width + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `0..=width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/feat/surf_mlp_featmap.rs:153:38 [INFO] [stderr] | [INFO] [stderr] 153 | math::vector_sub(src.offset((step << 1) as isize), src, dest, len); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `src.add((step << 1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/feat/surf_mlp_featmap.rs:243:28 [INFO] [stderr] | [INFO] [stderr] 243 | let row2 = row1.offset(len as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `row1.add(len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/feat/surf_mlp_featmap.rs:267:28 [INFO] [stderr] | [INFO] [stderr] 267 | let col2 = col1.offset(num_channel as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `col1.add(num_channel)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/math/mod.rs:22:42 [INFO] [stderr] | [INFO] [stderr] 22 | *dest.offset(i) = i32::from(*src.offset(i)); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::not_unsafe_ptr_arg_deref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/math/mod.rs:22:14 [INFO] [stderr] | [INFO] [stderr] 22 | *dest.offset(i) = i32::from(*src.offset(i)); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/math/mod.rs:30:26 [INFO] [stderr] | [INFO] [stderr] 30 | let value = *src.offset(i); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/math/mod.rs:31:14 [INFO] [stderr] | [INFO] [stderr] 31 | *dest.offset(i) = i32::pow(value, 2) as u32; [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/math/mod.rs:39:26 [INFO] [stderr] | [INFO] [stderr] 39 | let value = *src.offset(i); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/math/mod.rs:40:14 [INFO] [stderr] | [INFO] [stderr] 40 | *dest.offset(i) = if value >= 0 { value } else { -value }; [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/math/mod.rs:48:32 [INFO] [stderr] | [INFO] [stderr] 48 | *dest.offset(i) = *left.offset(i) + *right.offset(i); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/math/mod.rs:48:50 [INFO] [stderr] | [INFO] [stderr] 48 | *dest.offset(i) = *left.offset(i) + *right.offset(i); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/math/mod.rs:48:14 [INFO] [stderr] | [INFO] [stderr] 48 | *dest.offset(i) = *left.offset(i) + *right.offset(i); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/math/mod.rs:56:32 [INFO] [stderr] | [INFO] [stderr] 56 | *dest.offset(i) = *left.offset(i) - *right.offset(i); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/math/mod.rs:56:50 [INFO] [stderr] | [INFO] [stderr] 56 | *dest.offset(i) = *left.offset(i) - *right.offset(i); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/math/mod.rs:56:14 [INFO] [stderr] | [INFO] [stderr] 56 | *dest.offset(i) = *left.offset(i) - *right.offset(i); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/math/mod.rs:65:26 [INFO] [stderr] | [INFO] [stderr] 65 | product += (*left.offset(i)) * (*right.offset(i)); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/math/mod.rs:65:46 [INFO] [stderr] | [INFO] [stderr] 65 | product += (*left.offset(i)) * (*right.offset(i)); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: aborting due to 16 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rustface`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "ba91d3ec6f57c45d3332ce7a5d26b5a2bde39aff7349f14052abd4df557b3d26"` [INFO] running `"docker" "rm" "-f" "ba91d3ec6f57c45d3332ce7a5d26b5a2bde39aff7349f14052abd4df557b3d26"` [INFO] [stdout] ba91d3ec6f57c45d3332ce7a5d26b5a2bde39aff7349f14052abd4df557b3d26