[INFO] crate rusted_cypher 1.1.0 is already in cache [INFO] extracting crate rusted_cypher 1.1.0 into work/ex/clippy-test-run/sources/stable/reg/rusted_cypher/1.1.0 [INFO] extracting crate rusted_cypher 1.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rusted_cypher/1.1.0 [INFO] validating manifest of rusted_cypher-1.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rusted_cypher-1.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rusted_cypher-1.1.0 [INFO] finished frobbing rusted_cypher-1.1.0 [INFO] frobbed toml for rusted_cypher-1.1.0 written to work/ex/clippy-test-run/sources/stable/reg/rusted_cypher/1.1.0/Cargo.toml [INFO] started frobbing rusted_cypher-1.1.0 [INFO] finished frobbing rusted_cypher-1.1.0 [INFO] frobbed toml for rusted_cypher-1.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rusted_cypher/1.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rusted_cypher-1.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rusted_cypher/1.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 32c4bc1bbdb89cd5b1e7ce91e81bf4e4abecc71214249deb9b6d3c2b0304bf04 [INFO] running `"docker" "start" "-a" "32c4bc1bbdb89cd5b1e7ce91e81bf4e4abecc71214249deb9b6d3c2b0304bf04"` [INFO] [stderr] Checking semver-parser v0.6.2 [INFO] [stderr] Checking semver v0.5.1 [INFO] [stderr] Checking rusted_cypher v1.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cypher/transaction.rs:190:13 [INFO] [stderr] | [INFO] [stderr] 190 | headers: headers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `headers` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cypher/transaction.rs:228:13 [INFO] [stderr] | [INFO] [stderr] 228 | transaction: transaction, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `transaction` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cypher/transaction.rs:190:13 [INFO] [stderr] | [INFO] [stderr] 190 | headers: headers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `headers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cypher/transaction.rs:230:13 [INFO] [stderr] | [INFO] [stderr] 230 | expires: expires, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `expires` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cypher/result.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | columns: columns, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `columns` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cypher/result.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cypher/result.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | columns: columns, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `columns` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cypher/result.rs:73:13 [INFO] [stderr] | [INFO] [stderr] 73 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cypher/result.rs:146:13 [INFO] [stderr] | [INFO] [stderr] 146 | columns: columns, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `columns` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cypher/result.rs:147:13 [INFO] [stderr] | [INFO] [stderr] 147 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cypher/mod.rs:74:13 [INFO] [stderr] | [INFO] [stderr] 74 | endpoint: endpoint, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `endpoint` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cypher/mod.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | client: client, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `client` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cypher/mod.rs:76:13 [INFO] [stderr] | [INFO] [stderr] 76 | headers: headers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `headers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graph.rs:150:13 [INFO] [stderr] | [INFO] [stderr] 150 | headers: headers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `headers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graph.rs:151:13 [INFO] [stderr] | [INFO] [stderr] 151 | service_root: service_root, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `service_root` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graph.rs:152:13 [INFO] [stderr] | [INFO] [stderr] 152 | neo4j_version: neo4j_version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `neo4j_version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graph.rs:153:13 [INFO] [stderr] | [INFO] [stderr] 153 | cypher: cypher, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `cypher` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cypher/transaction.rs:228:13 [INFO] [stderr] | [INFO] [stderr] 228 | transaction: transaction, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `transaction` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cypher/transaction.rs:230:13 [INFO] [stderr] | [INFO] [stderr] 230 | expires: expires, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `expires` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cypher/result.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | columns: columns, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `columns` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cypher/result.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cypher/result.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | columns: columns, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `columns` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cypher/result.rs:73:13 [INFO] [stderr] | [INFO] [stderr] 73 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cypher/result.rs:146:13 [INFO] [stderr] | [INFO] [stderr] 146 | columns: columns, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `columns` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cypher/result.rs:147:13 [INFO] [stderr] | [INFO] [stderr] 147 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cypher/mod.rs:74:13 [INFO] [stderr] | [INFO] [stderr] 74 | endpoint: endpoint, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `endpoint` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cypher/mod.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | client: client, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `client` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cypher/mod.rs:76:13 [INFO] [stderr] | [INFO] [stderr] 76 | headers: headers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `headers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graph.rs:150:13 [INFO] [stderr] | [INFO] [stderr] 150 | headers: headers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `headers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graph.rs:151:13 [INFO] [stderr] | [INFO] [stderr] 151 | service_root: service_root, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `service_root` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graph.rs:152:13 [INFO] [stderr] | [INFO] [stderr] 152 | neo4j_version: neo4j_version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `neo4j_version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graph.rs:153:13 [INFO] [stderr] | [INFO] [stderr] 153 | cypher: cypher, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `cypher` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/cypher/transaction.rs:110:25 [INFO] [stderr] | [INFO] [stderr] 110 | const DATETIME_RFC822: &'static str = "%a, %d %b %Y %T %Z"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/cypher/transaction.rs:110:25 [INFO] [stderr] | [INFO] [stderr] 110 | const DATETIME_RFC822: &'static str = "%a, %d %b %Y %T %Z"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/cypher/transaction.rs:321:17 [INFO] [stderr] | [INFO] [stderr] 321 | const URL: &'static str = "http://neo4j:neo4j@localhost:7474/db/data/transaction"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/graph.rs:190:17 [INFO] [stderr] | [INFO] [stderr] 190 | const URL: &'static str = "http://neo4j:neo4j@localhost:7474/db/data"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: The function/method `time::strptime` doesn't need a mutable reference [INFO] [stderr] --> src/cypher/transaction.rs:223:38 [INFO] [stderr] | [INFO] [stderr] 223 | let expires = time::strptime(&mut result.transaction.expires, DATETIME_RFC822)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/cypher/transaction.rs:257:14 [INFO] [stderr] | [INFO] [stderr] 257 | .ok_or(GraphError::Statement("Server returned no results".to_owned()))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| GraphError::Statement("Server returned no results".to_owned()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: The function/method `time::strptime` doesn't need a mutable reference [INFO] [stderr] --> src/cypher/transaction.rs:272:39 [INFO] [stderr] | [INFO] [stderr] 272 | self.expires = time::strptime(&mut result.transaction.expires, DATETIME_RFC822)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/cypher/result.rs:55:25 [INFO] [stderr] | [INFO] [stderr] 55 | pub fn new(columns: &'a Vec, data: &'a Vec) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/cypher/result.rs:55:48 [INFO] [stderr] | [INFO] [stderr] 55 | pub fn new(columns: &'a Vec, data: &'a Vec) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[RowResult]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/cypher/result.rs:70:25 [INFO] [stderr] | [INFO] [stderr] 70 | pub fn new(columns: &'a Vec, data: &'a Vec) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/cypher/result.rs:70:48 [INFO] [stderr] | [INFO] [stderr] 70 | pub fn new(columns: &'a Vec, data: &'a Vec) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Value]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/cypher/result.rs:113:22 [INFO] [stderr] | [INFO] [stderr] 113 | Row::new(self.columns.as_ref(), data.row.as_ref()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.columns` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_asref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/cypher/mod.rs:37:34 [INFO] [stderr] | [INFO] [stderr] 37 | debug!("Sending query:\n{}", json_ser::to_string_pretty(&json).unwrap_or(String::new())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `json_ser::to_string_pretty(&json).unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/cypher/mod.rs:109:14 [INFO] [stderr] | [INFO] [stderr] 109 | .ok_or(GraphError::Other("No results returned from server".to_owned())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| GraphError::Other("No results returned from server".to_owned()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/cypher/mod.rs:160:12 [INFO] [stderr] | [INFO] [stderr] 160 | if result.errors().len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!result.errors().is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/graph.rs:122:9 [INFO] [stderr] | [INFO] [stderr] 122 | / url.password().map(|password| { [INFO] [stderr] 123 | | headers.set(Authorization( [INFO] [stderr] 124 | | Basic { [INFO] [stderr] 125 | | username: url.username().to_owned(), [INFO] [stderr] ... | [INFO] [stderr] 128 | | )); [INFO] [stderr] 129 | | }); [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 122 | if let Some(password) = url.password() { headers.set(Authorization( [INFO] [stderr] 123 | Basic { [INFO] [stderr] 124 | username: url.username().to_owned(), [INFO] [stderr] 125 | password: Some(password.to_owned()), [INFO] [stderr] 126 | } [INFO] [stderr] 127 | )); } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: The function/method `time::strptime` doesn't need a mutable reference [INFO] [stderr] --> src/cypher/transaction.rs:223:38 [INFO] [stderr] | [INFO] [stderr] 223 | let expires = time::strptime(&mut result.transaction.expires, DATETIME_RFC822)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/cypher/transaction.rs:257:14 [INFO] [stderr] | [INFO] [stderr] 257 | .ok_or(GraphError::Statement("Server returned no results".to_owned()))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| GraphError::Statement("Server returned no results".to_owned()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: The function/method `time::strptime` doesn't need a mutable reference [INFO] [stderr] --> src/cypher/transaction.rs:272:39 [INFO] [stderr] | [INFO] [stderr] 272 | self.expires = time::strptime(&mut result.transaction.expires, DATETIME_RFC822)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/cypher/statement.rs:41:17 [INFO] [stderr] | [INFO] [stderr] 41 | / match stmt.add_param($k, $v) { [INFO] [stderr] 42 | | Err(e) => error = Some(e), [INFO] [stderr] 43 | | _ => {} [INFO] [stderr] 44 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 212 | let statement1 = cypher_stmt!("MATCH n RETURN n", { [INFO] [stderr] | __________________________- [INFO] [stderr] 213 | | "name" => "test" [INFO] [stderr] 214 | | }).unwrap(); [INFO] [stderr] | |__________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 41 | if let Err(e) = stmt.add_param($k, $v) { cypher_stmt!("MATCH n RETURN n", { [INFO] [stderr] 42 | "name" => "test" [INFO] [stderr] 43 | }) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/cypher/statement.rs:41:17 [INFO] [stderr] | [INFO] [stderr] 41 | / match stmt.add_param($k, $v) { [INFO] [stderr] 42 | | Err(e) => error = Some(e), [INFO] [stderr] 43 | | _ => {} [INFO] [stderr] 44 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 217 | let statement2 = cypher_stmt!("MATCH n RETURN n", { [INFO] [stderr] | __________________________- [INFO] [stderr] 218 | | "value" => param [INFO] [stderr] 219 | | }).unwrap(); [INFO] [stderr] | |__________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 41 | if let Err(e) = stmt.add_param($k, $v) { cypher_stmt!("MATCH n RETURN n", { [INFO] [stderr] 42 | "value" => param [INFO] [stderr] 43 | }) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/cypher/statement.rs:41:17 [INFO] [stderr] | [INFO] [stderr] 41 | / match stmt.add_param($k, $v) { [INFO] [stderr] 42 | | Err(e) => error = Some(e), [INFO] [stderr] 43 | | _ => {} [INFO] [stderr] 44 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 228 | let statement = cypher_stmt!("MATCH n RETURN n", { [INFO] [stderr] | _________________________- [INFO] [stderr] 229 | | "param1" => "one", [INFO] [stderr] 230 | | "param2" => 2, [INFO] [stderr] 231 | | "param3" => param [INFO] [stderr] 232 | | }).unwrap(); [INFO] [stderr] | |__________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 41 | if let Err(e) = stmt.add_param($k, $v) { cypher_stmt!("MATCH n RETURN n", { [INFO] [stderr] 42 | "param1" => "one", [INFO] [stderr] 43 | "param2" => 2, [INFO] [stderr] 44 | "param3" => param [INFO] [stderr] 45 | }) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/cypher/statement.rs:236:9 [INFO] [stderr] | [INFO] [stderr] 236 | assert_eq!(param, statement.param::("param3").unwrap().unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/cypher/statement.rs:236:9 [INFO] [stderr] | [INFO] [stderr] 236 | assert_eq!(param, statement.param::("param3").unwrap().unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/cypher/result.rs:55:25 [INFO] [stderr] | [INFO] [stderr] 55 | pub fn new(columns: &'a Vec, data: &'a Vec) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/cypher/result.rs:55:48 [INFO] [stderr] | [INFO] [stderr] 55 | pub fn new(columns: &'a Vec, data: &'a Vec) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[RowResult]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/cypher/result.rs:70:25 [INFO] [stderr] | [INFO] [stderr] 70 | pub fn new(columns: &'a Vec, data: &'a Vec) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/cypher/result.rs:70:48 [INFO] [stderr] | [INFO] [stderr] 70 | pub fn new(columns: &'a Vec, data: &'a Vec) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Value]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/cypher/result.rs:113:22 [INFO] [stderr] | [INFO] [stderr] 113 | Row::new(self.columns.as_ref(), data.row.as_ref()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.columns` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_asref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/cypher/result.rs:159:24 [INFO] [stderr] | [INFO] [stderr] 159 | assert_eq!(row.get("name").unwrap(), "Test"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&row["name"]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/cypher/result.rs:160:24 [INFO] [stderr] | [INFO] [stderr] 160 | assert_eq!(row.get("lastname").unwrap(), "Result"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&row["lastname"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/cypher/result.rs:169:13 [INFO] [stderr] | [INFO] [stderr] 169 | let ref row = rows[0]; [INFO] [stderr] | ----^^^^^^^----------- help: try: `let row = &rows[0];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/cypher/result.rs:178:13 [INFO] [stderr] | [INFO] [stderr] 178 | let ref row = rows[0]; [INFO] [stderr] | ----^^^^^^^----------- help: try: `let row = &rows[0];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/cypher/mod.rs:37:34 [INFO] [stderr] | [INFO] [stderr] 37 | debug!("Sending query:\n{}", json_ser::to_string_pretty(&json).unwrap_or(String::new())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `json_ser::to_string_pretty(&json).unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/cypher/mod.rs:109:14 [INFO] [stderr] | [INFO] [stderr] 109 | .ok_or(GraphError::Other("No results returned from server".to_owned())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| GraphError::Other("No results returned from server".to_owned()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/cypher/mod.rs:160:12 [INFO] [stderr] | [INFO] [stderr] 160 | if result.errors().len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!result.errors().is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/graph.rs:122:9 [INFO] [stderr] | [INFO] [stderr] 122 | / url.password().map(|password| { [INFO] [stderr] 123 | | headers.set(Authorization( [INFO] [stderr] 124 | | Basic { [INFO] [stderr] 125 | | username: url.username().to_owned(), [INFO] [stderr] ... | [INFO] [stderr] 128 | | )); [INFO] [stderr] 129 | | }); [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 122 | if let Some(password) = url.password() { headers.set(Authorization( [INFO] [stderr] 123 | Basic { [INFO] [stderr] 124 | username: url.username().to_owned(), [INFO] [stderr] 125 | password: Some(password.to_owned()), [INFO] [stderr] 126 | } [INFO] [stderr] 127 | )); } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rusted_cypher`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "32c4bc1bbdb89cd5b1e7ce91e81bf4e4abecc71214249deb9b6d3c2b0304bf04"` [INFO] running `"docker" "rm" "-f" "32c4bc1bbdb89cd5b1e7ce91e81bf4e4abecc71214249deb9b6d3c2b0304bf04"` [INFO] [stdout] 32c4bc1bbdb89cd5b1e7ce91e81bf4e4abecc71214249deb9b6d3c2b0304bf04