[INFO] crate rustdt-json_rpc 0.3.0 is already in cache [INFO] extracting crate rustdt-json_rpc 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/rustdt-json_rpc/0.3.0 [INFO] extracting crate rustdt-json_rpc 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rustdt-json_rpc/0.3.0 [INFO] validating manifest of rustdt-json_rpc-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rustdt-json_rpc-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rustdt-json_rpc-0.3.0 [INFO] finished frobbing rustdt-json_rpc-0.3.0 [INFO] frobbed toml for rustdt-json_rpc-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/rustdt-json_rpc/0.3.0/Cargo.toml [INFO] started frobbing rustdt-json_rpc-0.3.0 [INFO] finished frobbing rustdt-json_rpc-0.3.0 [INFO] frobbed toml for rustdt-json_rpc-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rustdt-json_rpc/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rustdt-json_rpc-0.3.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rustdt-json_rpc/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6b99c41b4061918d0ac9ca79afc72ed0a1cb900594cf826d2dabf5414e194539 [INFO] running `"docker" "start" "-a" "6b99c41b4061918d0ac9ca79afc72ed0a1cb900594cf826d2dabf5414e194539"` [INFO] [stderr] Checking rustdt_util v0.2.3 [INFO] [stderr] Checking rustdt-json_rpc v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/jsonrpc_common.rs:108:24 [INFO] [stderr] | [INFO] [stderr] 108 | RequestError { code : code, message : message, data : None } [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `code` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/jsonrpc_common.rs:108:37 [INFO] [stderr] | [INFO] [stderr] 108 | RequestError { code : code, message : message, data : None } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `message` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/jsonrpc_common.rs:162:26 [INFO] [stderr] | [INFO] [stderr] 162 | Ok(RequestError{ code : code, message : message, data : data }) [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `code` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/jsonrpc_common.rs:162:39 [INFO] [stderr] | [INFO] [stderr] 162 | Ok(RequestError{ code : code, message : message, data : data }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `message` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/jsonrpc_common.rs:162:58 [INFO] [stderr] | [INFO] [stderr] 162 | Ok(RequestError{ code : code, message : message, data : data }) [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/jsonrpc_request.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | method : method, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `method` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/jsonrpc_request.rs:94:22 [INFO] [stderr] | [INFO] [stderr] 94 | Ok(Request { id : id, method : method, params : params }) [INFO] [stderr] | ^^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/jsonrpc_request.rs:94:31 [INFO] [stderr] | [INFO] [stderr] 94 | Ok(Request { id : id, method : method, params : params }) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `method` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/jsonrpc_request.rs:94:48 [INFO] [stderr] | [INFO] [stderr] 94 | Ok(Request { id : id, method : method, params : params }) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `params` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/jsonrpc_response.rs:32:20 [INFO] [stderr] | [INFO] [stderr] 32 | Response { id : id, result_or_error : ResponseResult::Result(result) } [INFO] [stderr] | ^^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/jsonrpc_response.rs:36:20 [INFO] [stderr] | [INFO] [stderr] 36 | Response { id : id, result_or_error : ResponseResult::Error(error) } [INFO] [stderr] | ^^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/jsonrpc_response.rs:57:20 [INFO] [stderr] | [INFO] [stderr] 57 | Response { id : id, result_or_error : ResponseResult::Error(error) } [INFO] [stderr] | ^^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/jsonrpc_response.rs:110:22 [INFO] [stderr] | [INFO] [stderr] 110 | Ok(Response{ id : id, result_or_error : result_or_error }) [INFO] [stderr] | ^^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/jsonrpc_response.rs:110:31 [INFO] [stderr] | [INFO] [stderr] 110 | Ok(Response{ id : id, result_or_error : result_or_error }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `result_or_error` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/method_types.rs:28:31 [INFO] [stderr] | [INFO] [stderr] 28 | MethodError:: { code : code, message : msg, data : data } [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `code` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/method_types.rs:28:59 [INFO] [stderr] | [INFO] [stderr] 28 | MethodError:: { code : code, message : msg, data : data } [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/output_agent.rs:91:54 [INFO] [stderr] | [INFO] [stderr] 91 | agent_runner.run_agent(AgentInnerRunner{ rx : rx }); [INFO] [stderr] | ^^^^^^^ help: replace it with: `rx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/jsonrpc.rs:146:27 [INFO] [stderr] | [INFO] [stderr] 146 | EndpointHandler { endpoint : endpoint, request_handler: request_handler } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `endpoint` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/jsonrpc.rs:146:48 [INFO] [stderr] | [INFO] [stderr] 146 | EndpointHandler { endpoint : endpoint, request_handler: request_handler } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `request_handler` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/jsonrpc.rs:246:52 [INFO] [stderr] | [INFO] [stderr] 246 | completion_flag : FinishedFlag(false), id : id, on_response: on_response [INFO] [stderr] | ^^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/jsonrpc.rs:246:61 [INFO] [stderr] | [INFO] [stderr] 246 | completion_flag : FinishedFlag(false), id : id, on_response: on_response [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `on_response` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/jsonrpc.rs:258:27 [INFO] [stderr] | [INFO] [stderr] 258 | Response{ id : id, result_or_error : response_result } [INFO] [stderr] | ^^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/jsonrpc.rs:353:29 [INFO] [stderr] | [INFO] [stderr] 353 | MethodCompletable { completable : completable, p1 : PhantomData, p2 : PhantomData} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `completable` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/jsonrpc.rs:465:82 [INFO] [stderr] | [INFO] [stderr] 465 | let rpc_request = Request { id: id.clone(), method : method_name.into(), params : params }; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `params` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tests_sample_types.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | Point { x : x, y : y } [INFO] [stderr] | ^^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tests_sample_types.rs:15:20 [INFO] [stderr] | [INFO] [stderr] 15 | Point { x : x, y : y } [INFO] [stderr] | ^^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tests_sample_types.rs:95:19 [INFO] [stderr] | [INFO] [stderr] 95 | Ok(Point{ x: x, y: y }) [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tests_sample_types.rs:95:25 [INFO] [stderr] | [INFO] [stderr] 95 | Ok(Point{ x: x, y: y }) [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/jsonrpc_common.rs:108:24 [INFO] [stderr] | [INFO] [stderr] 108 | RequestError { code : code, message : message, data : None } [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `code` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/jsonrpc_common.rs:108:37 [INFO] [stderr] | [INFO] [stderr] 108 | RequestError { code : code, message : message, data : None } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `message` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/jsonrpc_common.rs:162:26 [INFO] [stderr] | [INFO] [stderr] 162 | Ok(RequestError{ code : code, message : message, data : data }) [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `code` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/jsonrpc_common.rs:162:39 [INFO] [stderr] | [INFO] [stderr] 162 | Ok(RequestError{ code : code, message : message, data : data }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `message` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/jsonrpc_common.rs:162:58 [INFO] [stderr] | [INFO] [stderr] 162 | Ok(RequestError{ code : code, message : message, data : data }) [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/jsonrpc_request.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | method : method, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `method` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/jsonrpc_request.rs:94:22 [INFO] [stderr] | [INFO] [stderr] 94 | Ok(Request { id : id, method : method, params : params }) [INFO] [stderr] | ^^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/jsonrpc_request.rs:94:31 [INFO] [stderr] | [INFO] [stderr] 94 | Ok(Request { id : id, method : method, params : params }) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `method` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/jsonrpc_request.rs:94:48 [INFO] [stderr] | [INFO] [stderr] 94 | Ok(Request { id : id, method : method, params : params }) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `params` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/jsonrpc_response.rs:32:20 [INFO] [stderr] | [INFO] [stderr] 32 | Response { id : id, result_or_error : ResponseResult::Result(result) } [INFO] [stderr] | ^^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/jsonrpc_response.rs:36:20 [INFO] [stderr] | [INFO] [stderr] 36 | Response { id : id, result_or_error : ResponseResult::Error(error) } [INFO] [stderr] | ^^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/jsonrpc_response.rs:57:20 [INFO] [stderr] | [INFO] [stderr] 57 | Response { id : id, result_or_error : ResponseResult::Error(error) } [INFO] [stderr] | ^^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/jsonrpc_response.rs:110:22 [INFO] [stderr] | [INFO] [stderr] 110 | Ok(Response{ id : id, result_or_error : result_or_error }) [INFO] [stderr] | ^^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/jsonrpc_response.rs:110:31 [INFO] [stderr] | [INFO] [stderr] 110 | Ok(Response{ id : id, result_or_error : result_or_error }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `result_or_error` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/method_types.rs:28:31 [INFO] [stderr] | [INFO] [stderr] 28 | MethodError:: { code : code, message : msg, data : data } [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `code` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/method_types.rs:28:59 [INFO] [stderr] | [INFO] [stderr] 28 | MethodError:: { code : code, message : msg, data : data } [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/output_agent.rs:91:54 [INFO] [stderr] | [INFO] [stderr] 91 | agent_runner.run_agent(AgentInnerRunner{ rx : rx }); [INFO] [stderr] | ^^^^^^^ help: replace it with: `rx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/jsonrpc.rs:146:27 [INFO] [stderr] | [INFO] [stderr] 146 | EndpointHandler { endpoint : endpoint, request_handler: request_handler } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `endpoint` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/jsonrpc.rs:146:48 [INFO] [stderr] | [INFO] [stderr] 146 | EndpointHandler { endpoint : endpoint, request_handler: request_handler } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `request_handler` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/jsonrpc.rs:246:52 [INFO] [stderr] | [INFO] [stderr] 246 | completion_flag : FinishedFlag(false), id : id, on_response: on_response [INFO] [stderr] | ^^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/jsonrpc.rs:246:61 [INFO] [stderr] | [INFO] [stderr] 246 | completion_flag : FinishedFlag(false), id : id, on_response: on_response [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `on_response` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/jsonrpc.rs:258:27 [INFO] [stderr] | [INFO] [stderr] 258 | Response{ id : id, result_or_error : response_result } [INFO] [stderr] | ^^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/jsonrpc.rs:353:29 [INFO] [stderr] | [INFO] [stderr] 353 | MethodCompletable { completable : completable, p1 : PhantomData, p2 : PhantomData} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `completable` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/jsonrpc.rs:465:82 [INFO] [stderr] | [INFO] [stderr] 465 | let rpc_request = Request { id: id.clone(), method : method_name.into(), params : params }; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `params` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tests_sample_types.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | Point { x : x, y : y } [INFO] [stderr] | ^^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tests_sample_types.rs:15:20 [INFO] [stderr] | [INFO] [stderr] 15 | Point { x : x, y : y } [INFO] [stderr] | ^^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tests_sample_types.rs:95:19 [INFO] [stderr] | [INFO] [stderr] 95 | Ok(Point{ x: x, y: y }) [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tests_sample_types.rs:95:25 [INFO] [stderr] | [INFO] [stderr] 95 | Ok(Point{ x: x, y: y }) [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/json_util.rs:48:23 [INFO] [stderr] | [INFO] [stderr] 48 | None => { return Err(self.new_error(&format!("Property `{}` is missing.", key))) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(self.new_error(&format!("Property `{}` is missing.", key)))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this is an `else if` but the formatting might hide it [INFO] [stderr] --> src/jsonrpc_response.rs:101:14 [INFO] [stderr] | [INFO] [stderr] 101 | } else [INFO] [stderr] | ______________^ [INFO] [stderr] 102 | | if let Some(error_obj) = json_obj.remove("error") { [INFO] [stderr] | |____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::suspicious_else_formatting)] on by default [INFO] [stderr] = note: to remove this lint, remove the `else` or remove the new line between `else` and `if` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/output_agent.rs:46:31 [INFO] [stderr] | [INFO] [stderr] 46 | const ERR_SEND_TASK_FAILED : &'static str = [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'futures::BoxFuture': removed without replacement, recommended to use a local extension trait or function if needed, more details in https://github.com/rust-lang-nursery/futures-rs/issues/228 [INFO] [stderr] --> src/jsonrpc.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | use futures::BoxFuture; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'futures::BoxFuture': removed without replacement, recommended to use a local extension trait or function if needed, more details in https://github.com/rust-lang-nursery/futures-rs/issues/228 [INFO] [stderr] --> src/jsonrpc.rs:417:42 [INFO] [stderr] | [INFO] [stderr] 417 | pub type RequestFuture = BoxFuture, futures::Canceled>; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/json_util.rs:48:23 [INFO] [stderr] | [INFO] [stderr] 48 | None => { return Err(self.new_error(&format!("Property `{}` is missing.", key))) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(self.new_error(&format!("Property `{}` is missing.", key)))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `json_util::*` [INFO] [stderr] --> src/jsonrpc_message.rs:74:9 [INFO] [stderr] | [INFO] [stderr] 74 | use json_util::*; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `jsonrpc_response::*` [INFO] [stderr] --> src/jsonrpc_message.rs:77:9 [INFO] [stderr] | [INFO] [stderr] 77 | use jsonrpc_response::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `jsonrpc_request::*` [INFO] [stderr] --> src/jsonrpc_message.rs:79:9 [INFO] [stderr] | [INFO] [stderr] 79 | use jsonrpc_request::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `json_util::*` [INFO] [stderr] --> src/jsonrpc_request.rs:185:9 [INFO] [stderr] | [INFO] [stderr] 185 | use json_util::*; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `jsonrpc_common::*` [INFO] [stderr] --> src/jsonrpc_request.rs:187:9 [INFO] [stderr] | [INFO] [stderr] 187 | use jsonrpc_common::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this is an `else if` but the formatting might hide it [INFO] [stderr] --> src/jsonrpc_response.rs:101:14 [INFO] [stderr] | [INFO] [stderr] 101 | } else [INFO] [stderr] | ______________^ [INFO] [stderr] 102 | | if let Some(error_obj) = json_obj.remove("error") { [INFO] [stderr] | |____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::suspicious_else_formatting)] on by default [INFO] [stderr] = note: to remove this lint, remove the `else` or remove the new line between `else` and `if` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting [INFO] [stderr] [INFO] [stderr] warning: unused import: `jsonrpc_common::*` [INFO] [stderr] --> src/jsonrpc_response.rs:118:9 [INFO] [stderr] | [INFO] [stderr] 118 | use jsonrpc_common::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `json_util::*` [INFO] [stderr] --> src/jsonrpc_response.rs:120:9 [INFO] [stderr] | [INFO] [stderr] 120 | use json_util::*; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/output_agent.rs:46:31 [INFO] [stderr] | [INFO] [stderr] 46 | const ERR_SEND_TASK_FAILED : &'static str = [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unused import: `util::core::*` [INFO] [stderr] --> src/jsonrpc.rs:504:9 [INFO] [stderr] | [INFO] [stderr] 504 | use util::core::*; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `jsonrpc_common::*` [INFO] [stderr] --> src/jsonrpc.rs:514:9 [INFO] [stderr] | [INFO] [stderr] 514 | use jsonrpc_common::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `jsonrpc_response::*` [INFO] [stderr] --> src/jsonrpc.rs:515:9 [INFO] [stderr] | [INFO] [stderr] 515 | use jsonrpc_response::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `jsonrpc_request::*` [INFO] [stderr] --> src/jsonrpc.rs:516:9 [INFO] [stderr] | [INFO] [stderr] 516 | use jsonrpc_request::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `method_types::*` [INFO] [stderr] --> src/jsonrpc.rs:518:9 [INFO] [stderr] | [INFO] [stderr] 518 | use method_types::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item '>::complete': renamed to `send` [INFO] [stderr] --> src/jsonrpc.rs:481:20 [INFO] [stderr] | [INFO] [stderr] 481 | entry.complete(result_or_error) [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'futures::BoxFuture': removed without replacement, recommended to use a local extension trait or function if needed, more details in https://github.com/rust-lang-nursery/futures-rs/issues/228 [INFO] [stderr] --> src/jsonrpc.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | use futures::BoxFuture; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'futures::BoxFuture': removed without replacement, recommended to use a local extension trait or function if needed, more details in https://github.com/rust-lang-nursery/futures-rs/issues/228 [INFO] [stderr] --> src/jsonrpc.rs:417:42 [INFO] [stderr] | [INFO] [stderr] 417 | pub type RequestFuture = BoxFuture, futures::Canceled>; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'futures::task::Unpark': recommended to use `Notify` instead [INFO] [stderr] --> src/jsonrpc.rs:524:9 [INFO] [stderr] | [INFO] [stderr] 524 | use futures::task::Unpark; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'futures::task::Unpark': recommended to use `Notify` instead [INFO] [stderr] --> src/jsonrpc.rs:678:33 [INFO] [stderr] | [INFO] [stderr] 678 | pub fn noop_unpark() -> Arc { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'futures::task::Unpark': recommended to use `Notify` instead [INFO] [stderr] --> src/jsonrpc.rs:681:14 [INFO] [stderr] | [INFO] [stderr] 681 | impl Unpark for Foo { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/jsonrpc.rs:388:55 [INFO] [stderr] | [INFO] [stderr] 388 | let write_task : OutputAgentTask = Box::new(move |mut response_handler| { [INFO] [stderr] | ----^^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/json_util.rs:42:32 [INFO] [stderr] | [INFO] [stderr] 42 | fn obtain_Value(&mut self, mut json_map : &mut JsonObject, key: & str) [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/json_util.rs:52:35 [INFO] [stderr] | [INFO] [stderr] 52 | fn obtain_Value_or(&mut self, mut json_map : &mut JsonObject, key: & str, default: & Fn() -> Value) [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item '>::complete': renamed to `send` [INFO] [stderr] --> src/jsonrpc.rs:481:20 [INFO] [stderr] | [INFO] [stderr] 481 | entry.complete(result_or_error) [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'futures::task_impl::std::>::poll_future': recommended to use `poll_future_notify` instead [INFO] [stderr] --> src/jsonrpc.rs:662:26 [INFO] [stderr] | [INFO] [stderr] 662 | let poll = spawn.poll_future(noop_unpark()); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/method_types.rs:49:28 [INFO] [stderr] | [INFO] [stderr] 49 | code : code as i64, // Safe convertion. TODO: use TryFrom when it's stable [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i64::from(code)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/service_util.rs:42:33 [INFO] [stderr] | [INFO] [stderr] 42 | try!(self.0.write_all(&['\n' as u8])); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'\n' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `map_request_handler::MapRequestHandler` [INFO] [stderr] --> src/map_request_handler.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | / pub fn new() -> MapRequestHandler { [INFO] [stderr] 32 | | MapRequestHandler { method_handlers : HashMap::new() } [INFO] [stderr] 33 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 25 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/map_request_handler.rs:79:29 [INFO] [stderr] | [INFO] [stderr] 79 | let method_fn : &Box = method_fn; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `&RpcMethodHandler` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/jsonrpc.rs:388:55 [INFO] [stderr] | [INFO] [stderr] 388 | let write_task : OutputAgentTask = Box::new(move |mut response_handler| { [INFO] [stderr] | ----^^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/json_util.rs:42:32 [INFO] [stderr] | [INFO] [stderr] 42 | fn obtain_Value(&mut self, mut json_map : &mut JsonObject, key: & str) [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/json_util.rs:52:35 [INFO] [stderr] | [INFO] [stderr] 52 | fn obtain_Value_or(&mut self, mut json_map : &mut JsonObject, key: & str, default: & Fn() -> Value) [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> tests/tests_sample_types.rs:88:19 [INFO] [stderr] | [INFO] [stderr] 88 | Ok(Point{ x: x, y: y }) [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> tests/tests_sample_types.rs:88:25 [INFO] [stderr] | [INFO] [stderr] 88 | Ok(Point{ x: x, y: y }) [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> tests/tests_sample_types.rs:88:19 [INFO] [stderr] | [INFO] [stderr] 88 | Ok(Point{ x: x, y: y }) [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> tests/tests_sample_types.rs:88:25 [INFO] [stderr] | [INFO] [stderr] 88 | Ok(Point{ x: x, y: y }) [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> src/jsonrpc_response.rs:126:28 [INFO] [stderr] | [INFO] [stderr] 126 | pub fn sample_json_obj(foo: u32) -> Value { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/method_types.rs:49:28 [INFO] [stderr] | [INFO] [stderr] 49 | code : code as i64, // Safe convertion. TODO: use TryFrom when it's stable [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i64::from(code)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/service_util.rs:42:33 [INFO] [stderr] | [INFO] [stderr] 42 | try!(self.0.write_all(&['\n' as u8])); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'\n' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `map_request_handler::MapRequestHandler` [INFO] [stderr] --> src/map_request_handler.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | / pub fn new() -> MapRequestHandler { [INFO] [stderr] 32 | | MapRequestHandler { method_handlers : HashMap::new() } [INFO] [stderr] 33 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 25 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/map_request_handler.rs:79:29 [INFO] [stderr] | [INFO] [stderr] 79 | let method_fn : &Box = method_fn; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `&RpcMethodHandler` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> tests/example.rs:98:5 [INFO] [stderr] | [INFO] [stderr] 98 | / for stream in listener.incoming() { [INFO] [stderr] 99 | | let stream = stream.expect("TCP listen error."); [INFO] [stderr] 100 | | thread::spawn(move|| handle_server_connection(stream)); [INFO] [stderr] 101 | | [INFO] [stderr] 102 | | break; // For example purposes, we only listen to first connection [INFO] [stderr] 103 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rustdt-json_rpc`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "6b99c41b4061918d0ac9ca79afc72ed0a1cb900594cf826d2dabf5414e194539"` [INFO] running `"docker" "rm" "-f" "6b99c41b4061918d0ac9ca79afc72ed0a1cb900594cf826d2dabf5414e194539"` [INFO] [stdout] 6b99c41b4061918d0ac9ca79afc72ed0a1cb900594cf826d2dabf5414e194539