[INFO] crate rustdct 0.3.0 is already in cache [INFO] extracting crate rustdct 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/rustdct/0.3.0 [INFO] extracting crate rustdct 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rustdct/0.3.0 [INFO] validating manifest of rustdct-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rustdct-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rustdct-0.3.0 [INFO] finished frobbing rustdct-0.3.0 [INFO] frobbed toml for rustdct-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/rustdct/0.3.0/Cargo.toml [INFO] started frobbing rustdct-0.3.0 [INFO] finished frobbing rustdct-0.3.0 [INFO] frobbed toml for rustdct-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rustdct/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rustdct-0.3.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rustdct/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c6d45094982fca8c84067852ca26ac857d4e6912371cd70160aef16d2684389d [INFO] running `"docker" "start" "-a" "c6d45094982fca8c84067852ca26ac857d4e6912371cd70160aef16d2684389d"` [INFO] [stderr] Checking rustdct v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/algorithm/type2and3_splitradix.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | half_dct: half_dct, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `half_dct` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/algorithm/type2and3_splitradix.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | quarter_dct: quarter_dct, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `quarter_dct` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/algorithm/type4_convert_to_type3.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | inner_dct: inner_dct, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `inner_dct` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/algorithm/type4_convert_to_type3.rs:154:13 [INFO] [stderr] | [INFO] [stderr] 154 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/algorithm/type4_convert_to_type3.rs:185:13 [INFO] [stderr] | [INFO] [stderr] 185 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/algorithm/type2and3_splitradix.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | half_dct: half_dct, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `half_dct` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/algorithm/type2and3_splitradix.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | quarter_dct: quarter_dct, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `quarter_dct` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/algorithm/type4_convert_to_type3.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | inner_dct: inner_dct, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `inner_dct` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/algorithm/type4_convert_to_type3.rs:154:13 [INFO] [stderr] | [INFO] [stderr] 154 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/algorithm/type4_convert_to_type3.rs:185:13 [INFO] [stderr] | [INFO] [stderr] 185 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mdct/mdct_naive.rs:188:19 [INFO] [stderr] | [INFO] [stderr] 188 | vec![-4.7455063, -2.073643, -2.2964284, 8.479767], [INFO] [stderr] | ^^^^^^^^^ help: consider: `4.745_506_3` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mdct/mdct_naive.rs:188:31 [INFO] [stderr] | [INFO] [stderr] 188 | vec![-4.7455063, -2.073643, -2.2964284, 8.479767], [INFO] [stderr] | ^^^^^^^^ help: consider: `2.073_643` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mdct/mdct_naive.rs:188:42 [INFO] [stderr] | [INFO] [stderr] 188 | vec![-4.7455063, -2.073643, -2.2964284, 8.479767], [INFO] [stderr] | ^^^^^^^^^ help: consider: `2.296_428_4` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mdct/mdct_naive.rs:188:53 [INFO] [stderr] | [INFO] [stderr] 188 | vec![-4.7455063, -2.073643, -2.2964284, 8.479767], [INFO] [stderr] | ^^^^^^^^ help: consider: `8.479_767` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mdct/mdct_naive.rs:190:18 [INFO] [stderr] | [INFO] [stderr] 190 | -2.90775651, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2.907_756_51` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mdct/mdct_naive.rs:191:18 [INFO] [stderr] | [INFO] [stderr] 191 | -12.30026278, [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `12.300_262_78` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mdct/mdct_naive.rs:192:17 [INFO] [stderr] | [INFO] [stderr] 192 | 6.92661442, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `6.926_614_42` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mdct/mdct_naive.rs:193:17 [INFO] [stderr] | [INFO] [stderr] 193 | 2.79403335, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2.794_033_35` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mdct/mdct_naive.rs:194:17 [INFO] [stderr] | [INFO] [stderr] 194 | 3.56420194, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `3.564_201_94` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mdct/mdct_naive.rs:195:18 [INFO] [stderr] | [INFO] [stderr] 195 | -2.40007133, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2.400_071_33` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mdct/mdct_naive.rs:230:18 [INFO] [stderr] | [INFO] [stderr] 230 | vec![2.29289322, 1.53553391], [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2.292_893_22` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mdct/mdct_naive.rs:230:30 [INFO] [stderr] | [INFO] [stderr] 230 | vec![2.29289322, 1.53553391], [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1.535_533_91` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mdct/mdct_naive.rs:231:19 [INFO] [stderr] | [INFO] [stderr] 231 | vec![-4.67324308, 3.1647844, -6.22625186, 2.1647844], [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4.673_243_08` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mdct/mdct_naive.rs:231:31 [INFO] [stderr] | [INFO] [stderr] 231 | vec![-4.67324308, 3.1647844, -6.22625186, 2.1647844], [INFO] [stderr] | ^^^^^^^^^ help: consider: `3.164_784_4` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mdct/mdct_naive.rs:231:43 [INFO] [stderr] | [INFO] [stderr] 231 | vec![-4.67324308, 3.1647844, -6.22625186, 2.1647844], [INFO] [stderr] | ^^^^^^^^^^ help: consider: `6.226_251_86` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mdct/mdct_naive.rs:231:55 [INFO] [stderr] | [INFO] [stderr] 231 | vec![-4.67324308, 3.1647844, -6.22625186, 2.1647844], [INFO] [stderr] | ^^^^^^^^^ help: consider: `2.164_784_4` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mdct/mdct_naive.rs:233:18 [INFO] [stderr] | [INFO] [stderr] 233 | -5.50153067, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `5.501_530_67` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mdct/mdct_naive.rs:234:18 [INFO] [stderr] | [INFO] [stderr] 234 | -3.46580575, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `3.465_805_75` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mdct/mdct_naive.rs:235:17 [INFO] [stderr] | [INFO] [stderr] 235 | 3.79375195, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `3.793_751_95` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mdct/mdct_naive.rs:236:18 [INFO] [stderr] | [INFO] [stderr] 236 | -1.25072987, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1.250_729_87` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mdct/mdct_naive.rs:237:17 [INFO] [stderr] | [INFO] [stderr] 237 | 4.6738204, [INFO] [stderr] | ^^^^^^^^^ help: consider: `4.673_820_4` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mdct/mdct_naive.rs:238:17 [INFO] [stderr] | [INFO] [stderr] 238 | 3.16506351, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `3.165_063_51` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mdct/mdct_naive.rs:323:19 [INFO] [stderr] | [INFO] [stderr] 323 | vec![-4.2367144, 4.2367153, -2.837299, -2.8372989], [INFO] [stderr] | ^^^^^^^^^ help: consider: `4.236_714_4` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mdct/mdct_naive.rs:323:30 [INFO] [stderr] | [INFO] [stderr] 323 | vec![-4.2367144, 4.2367153, -2.837299, -2.8372989], [INFO] [stderr] | ^^^^^^^^^ help: consider: `4.236_715_3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mdct/mdct_naive.rs:323:42 [INFO] [stderr] | [INFO] [stderr] 323 | vec![-4.2367144, 4.2367153, -2.837299, -2.8372989], [INFO] [stderr] | ^^^^^^^^ help: consider: `2.837_299` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mdct/mdct_naive.rs:323:53 [INFO] [stderr] | [INFO] [stderr] 323 | vec![-4.2367144, 4.2367153, -2.837299, -2.8372989], [INFO] [stderr] | ^^^^^^^^^ help: consider: `2.837_298_9` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mdct/mdct_naive.rs:325:17 [INFO] [stderr] | [INFO] [stderr] 325 | 5.833236, [INFO] [stderr] | ^^^^^^^^ help: consider: `5.833_236` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mdct/mdct_naive.rs:326:17 [INFO] [stderr] | [INFO] [stderr] 326 | 2.4275358, [INFO] [stderr] | ^^^^^^^^^ help: consider: `2.427_535_8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mdct/mdct_naive.rs:327:18 [INFO] [stderr] | [INFO] [stderr] 327 | -2.4275393, [INFO] [stderr] | ^^^^^^^^^ help: consider: `2.427_539_3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mdct/mdct_naive.rs:328:18 [INFO] [stderr] | [INFO] [stderr] 328 | -5.833232, [INFO] [stderr] | ^^^^^^^^ help: consider: `5.833_232` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mdct/mdct_naive.rs:329:17 [INFO] [stderr] | [INFO] [stderr] 329 | 4.8335495, [INFO] [stderr] | ^^^^^^^^^ help: consider: `4.833_549_5` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mdct/mdct_naive.rs:330:18 [INFO] [stderr] | [INFO] [stderr] 330 | -14.584825, [INFO] [stderr] | ^^^^^^^^^ help: consider: `14.584_825` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mdct/mdct_naive.rs:331:18 [INFO] [stderr] | [INFO] [stderr] 331 | -14.584811, [INFO] [stderr] | ^^^^^^^^^ help: consider: `14.584_811` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mdct/mdct_naive.rs:332:17 [INFO] [stderr] | [INFO] [stderr] 332 | 4.8335423, [INFO] [stderr] | ^^^^^^^^^ help: consider: `4.833_542_3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mdct/mdct_naive.rs:335:17 [INFO] [stderr] | [INFO] [stderr] 335 | 2.4138875, [INFO] [stderr] | ^^^^^^^^^ help: consider: `2.413_887_5` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mdct/mdct_naive.rs:336:17 [INFO] [stderr] | [INFO] [stderr] 336 | 8.921771, [INFO] [stderr] | ^^^^^^^^ help: consider: `8.921_771` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mdct/mdct_naive.rs:337:18 [INFO] [stderr] | [INFO] [stderr] 337 | -2.4359043, [INFO] [stderr] | ^^^^^^^^^ help: consider: `2.435_904_3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mdct/mdct_naive.rs:338:17 [INFO] [stderr] | [INFO] [stderr] 338 | 2.4359055, [INFO] [stderr] | ^^^^^^^^^ help: consider: `2.435_905_5` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mdct/mdct_naive.rs:339:18 [INFO] [stderr] | [INFO] [stderr] 339 | -8.921769, [INFO] [stderr] | ^^^^^^^^ help: consider: `8.921_769` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mdct/mdct_naive.rs:340:18 [INFO] [stderr] | [INFO] [stderr] 340 | -2.4138737, [INFO] [stderr] | ^^^^^^^^^ help: consider: `2.413_873_7` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mdct/mdct_naive.rs:341:17 [INFO] [stderr] | [INFO] [stderr] 341 | 3.1458342, [INFO] [stderr] | ^^^^^^^^^ help: consider: `3.145_834_2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mdct/mdct_naive.rs:342:18 [INFO] [stderr] | [INFO] [stderr] 342 | -0.63405657, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0.634_056_57` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mdct/mdct_naive.rs:343:18 [INFO] [stderr] | [INFO] [stderr] 343 | -18.502512, [INFO] [stderr] | ^^^^^^^^^ help: consider: `18.502_512` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mdct/mdct_naive.rs:344:18 [INFO] [stderr] | [INFO] [stderr] 344 | -18.502502, [INFO] [stderr] | ^^^^^^^^^ help: consider: `18.502_502` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mdct/mdct_naive.rs:345:18 [INFO] [stderr] | [INFO] [stderr] 345 | -0.6340414, [INFO] [stderr] | ^^^^^^^^^ help: consider: `0.634_041_4` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mdct/mdct_naive.rs:346:17 [INFO] [stderr] | [INFO] [stderr] 346 | 3.1458292, [INFO] [stderr] | ^^^^^^^^^ help: consider: `3.145_829_2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mdct/mdct_naive.rs:375:18 [INFO] [stderr] | [INFO] [stderr] 375 | -1.6213203435596431, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `1.621_320_343_559_643_1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mdct/mdct_naive.rs:376:17 [INFO] [stderr] | [INFO] [stderr] 376 | 3.9142135623730936, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `3.914_213_562_373_093_6` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mdct/mdct_naive.rs:377:18 [INFO] [stderr] | [INFO] [stderr] 377 | -2.6213203435596433, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `2.621_320_343_559_643_3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mdct/mdct_naive.rs:378:18 [INFO] [stderr] | [INFO] [stderr] 378 | -1.0857864376269069, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `1.085_786_437_626_906_9` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mdct/mdct_naive.rs:381:17 [INFO] [stderr] | [INFO] [stderr] 381 | 1.1380080486867217, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `1.138_008_048_686_721_7` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mdct/mdct_naive.rs:382:17 [INFO] [stderr] | [INFO] [stderr] 382 | 1.3486674811260955, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `1.348_667_481_126_095_5` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mdct/mdct_naive.rs:383:18 [INFO] [stderr] | [INFO] [stderr] 383 | -2.0184235241728627, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `2.018_423_524_172_862_7` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mdct/mdct_naive.rs:384:18 [INFO] [stderr] | [INFO] [stderr] 384 | -5.7211528055198331, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `5.721_152_805_519_833_1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mdct/mdct_naive.rs:385:17 [INFO] [stderr] | [INFO] [stderr] 385 | 4.7406716077536428, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `4.740_671_607_753_642_8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mdct/mdct_naive.rs:386:18 [INFO] [stderr] | [INFO] [stderr] 386 | -12.126842074178105, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `12.126_842_074_178_105` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mdct/mdct_naive.rs:387:18 [INFO] [stderr] | [INFO] [stderr] 387 | -8.1028968193867765, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `8.102_896_819_386_776_5` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mdct/mdct_naive.rs:388:17 [INFO] [stderr] | [INFO] [stderr] 388 | 0.94297821246780911, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `0.942_978_212_467_809_11` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mdct/mdct_naive.rs:391:17 [INFO] [stderr] | [INFO] [stderr] 391 | 0.3150751815802082, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0.315_075_181_580_208_2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mdct/mdct_naive.rs:392:17 [INFO] [stderr] | [INFO] [stderr] 392 | 3.4142135623730949, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `3.414_213_562_373_094_9` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mdct/mdct_naive.rs:393:18 [INFO] [stderr] | [INFO] [stderr] 393 | -1.4828837895525038, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `1.482_883_789_552_503_8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mdct/mdct_naive.rs:394:17 [INFO] [stderr] | [INFO] [stderr] 394 | 1.9325317795197492, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `1.932_531_779_519_749_2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mdct/mdct_naive.rs:395:18 [INFO] [stderr] | [INFO] [stderr] 395 | -8.2426406871192732, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `8.242_640_687_119_273_2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mdct/mdct_naive.rs:396:18 [INFO] [stderr] | [INFO] [stderr] 396 | -2.3932336063055089, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `2.393_233_606_305_508_9` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mdct/mdct_naive.rs:397:17 [INFO] [stderr] | [INFO] [stderr] 397 | 3.1189227588735786, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `3.118_922_758_873_578_6` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mdct/mdct_naive.rs:398:18 [INFO] [stderr] | [INFO] [stderr] 398 | -0.58578643762689731, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `0.585_786_437_626_897_31` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mdct/mdct_naive.rs:399:18 [INFO] [stderr] | [INFO] [stderr] 399 | -14.679036212259122, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `14.679_036_212_259_122` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mdct/mdct_naive.rs:400:18 [INFO] [stderr] | [INFO] [stderr] 400 | -11.263620643186901, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `11.263_620_643_186_901` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mdct/mdct_naive.rs:401:18 [INFO] [stderr] | [INFO] [stderr] 401 | -0.24264068711929426, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `0.242_640_687_119_294_26` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mdct/mdct_naive.rs:402:17 [INFO] [stderr] | [INFO] [stderr] 402 | 0.41061397098787894, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `0.410_613_970_987_878_94` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/test_utils.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | return sig; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `sig` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: called `.get_mut().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/mdct/mdct_naive.rs:67:31 [INFO] [stderr] | [INFO] [stderr] 67 | let output_cell = output.get_mut(k).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `output[k]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `input_a` [INFO] [stderr] --> src/mdct/mdct_naive.rs:73:22 [INFO] [stderr] | [INFO] [stderr] 73 | for i in 0..input_a.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 73 | for (i, ) in input_a.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `input_b` [INFO] [stderr] --> src/mdct/mdct_naive.rs:84:22 [INFO] [stderr] | [INFO] [stderr] 84 | for i in 0..input_b.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 84 | for (i, ) in input_b.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `k` is used to index `output_a` [INFO] [stderr] --> src/mdct/mdct_naive.rs:103:18 [INFO] [stderr] | [INFO] [stderr] 103 | for k in 0..input_len { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 103 | for (k, ) in output_a.iter_mut().enumerate().take(input_len) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `input`. [INFO] [stderr] --> src/mdct/mdct_naive.rs:109:22 [INFO] [stderr] | [INFO] [stderr] 109 | for i in 0..input.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 109 | for in &input { [INFO] [stderr] | ^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `k` is used to index `output_b` [INFO] [stderr] --> src/mdct/mdct_naive.rs:122:18 [INFO] [stderr] | [INFO] [stderr] 122 | for k in 0..input_len { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 122 | for (k, ) in output_b.iter_mut().enumerate().take(input_len) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `input`. [INFO] [stderr] --> src/mdct/mdct_naive.rs:135:22 [INFO] [stderr] | [INFO] [stderr] 135 | for i in 0..input.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 135 | for in &input { [INFO] [stderr] | ^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `.get_mut().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/algorithm/type1_naive.rs:54:31 [INFO] [stderr] | [INFO] [stderr] 54 | let output_cell = output.get_mut(k).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `output[k]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `input`. [INFO] [stderr] --> src/algorithm/type1_naive.rs:60:22 [INFO] [stderr] | [INFO] [stderr] 60 | for i in 1..input.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 60 | for in input.iter().skip(1) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `.get_mut().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/algorithm/type1_naive.rs:121:31 [INFO] [stderr] | [INFO] [stderr] 121 | let output_cell = output.get_mut(k).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `output[k]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `input`. [INFO] [stderr] --> src/algorithm/type1_naive.rs:127:22 [INFO] [stderr] | [INFO] [stderr] 127 | for i in 0..input.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 127 | for in &input { [INFO] [stderr] | ^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `algorithm::type2and3_butterflies::Type2And3Butterfly2` [INFO] [stderr] --> src/algorithm/type2and3_butterflies.rs:57:2 [INFO] [stderr] | [INFO] [stderr] 57 | pub fn new() -> Self { [INFO] [stderr] | _____^ [INFO] [stderr] 58 | | Type2And3Butterfly2 { [INFO] [stderr] 59 | | _phantom: PhantomData, [INFO] [stderr] 60 | | } [INFO] [stderr] 61 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 53 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `algorithm::type2and3_butterflies::Type2And3Butterfly4` [INFO] [stderr] --> src/algorithm/type2and3_butterflies.rs:152:2 [INFO] [stderr] | [INFO] [stderr] 152 | pub fn new() -> Self { [INFO] [stderr] | _____^ [INFO] [stderr] 153 | | Type2And3Butterfly4 { [INFO] [stderr] 154 | | twiddle: twiddles::single_twiddle(1,16).conj() [INFO] [stderr] 155 | | } [INFO] [stderr] 156 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 151 | impl Default for algorithm::type2and3_butterflies::Type2And3Butterfly4 { [INFO] [stderr] 152 | fn default() -> Self { [INFO] [stderr] 153 | Self::new() [INFO] [stderr] 154 | } [INFO] [stderr] 155 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `algorithm::type2and3_butterflies::Type2And3Butterfly8` [INFO] [stderr] --> src/algorithm/type2and3_butterflies.rs:226:2 [INFO] [stderr] | [INFO] [stderr] 226 | pub fn new() -> Self { [INFO] [stderr] | _____^ [INFO] [stderr] 227 | | Type2And3Butterfly8 { [INFO] [stderr] 228 | | butterfly4: Type2And3Butterfly4::new(), [INFO] [stderr] 229 | | butterfly2: Type2And3Butterfly2::new(), [INFO] [stderr] ... | [INFO] [stderr] 234 | | } [INFO] [stderr] 235 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 225 | impl Default for algorithm::type2and3_butterflies::Type2And3Butterfly8 { [INFO] [stderr] 226 | fn default() -> Self { [INFO] [stderr] 227 | Self::new() [INFO] [stderr] 228 | } [INFO] [stderr] 229 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `algorithm::type2and3_butterflies::Type2And3Butterfly16` [INFO] [stderr] --> src/algorithm/type2and3_butterflies.rs:417:2 [INFO] [stderr] | [INFO] [stderr] 417 | pub fn new() -> Self { [INFO] [stderr] | _____^ [INFO] [stderr] 418 | | Type2And3Butterfly16 { [INFO] [stderr] 419 | | butterfly8: Type2And3Butterfly8::new(), [INFO] [stderr] 420 | | butterfly4: Type2And3Butterfly4::new(), [INFO] [stderr] ... | [INFO] [stderr] 427 | | } [INFO] [stderr] 428 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 416 | impl Default for algorithm::type2and3_butterflies::Type2And3Butterfly16 { [INFO] [stderr] 417 | fn default() -> Self { [INFO] [stderr] 418 | Self::new() [INFO] [stderr] 419 | } [INFO] [stderr] 420 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get_mut().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/algorithm/type2and3_naive.rs:54:31 [INFO] [stderr] | [INFO] [stderr] 54 | let output_cell = output.get_mut(k).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `output[k]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `input`. [INFO] [stderr] --> src/algorithm/type2and3_naive.rs:60:22 [INFO] [stderr] | [INFO] [stderr] 60 | for i in 0..input.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 60 | for in &input { [INFO] [stderr] | ^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `.get_mut().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/algorithm/type2and3_naive.rs:78:31 [INFO] [stderr] | [INFO] [stderr] 78 | let output_cell = output.get_mut(k).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `output[k]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `input`. [INFO] [stderr] --> src/algorithm/type2and3_naive.rs:84:22 [INFO] [stderr] | [INFO] [stderr] 84 | for i in 0..input.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 84 | for in &input { [INFO] [stderr] | ^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `.get_mut().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/algorithm/type2and3_naive.rs:104:31 [INFO] [stderr] | [INFO] [stderr] 104 | let output_cell = output.get_mut(k).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `output[k]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `input`. [INFO] [stderr] --> src/algorithm/type2and3_naive.rs:110:22 [INFO] [stderr] | [INFO] [stderr] 110 | for i in 1..input.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 110 | for in input.iter().skip(1) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `.get_mut().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/algorithm/type2and3_naive.rs:131:31 [INFO] [stderr] | [INFO] [stderr] 131 | let output_cell = output.get_mut(k).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `output[k]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `input`. [INFO] [stderr] --> src/algorithm/type2and3_naive.rs:137:22 [INFO] [stderr] | [INFO] [stderr] 137 | for i in 0..input.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 137 | for in &input { [INFO] [stderr] | ^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/algorithm/type4_convert_to_fft.rs:76:9 [INFO] [stderr] | [INFO] [stderr] 76 | input_index = input_index - len; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `input_index -= len` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/algorithm/type4_convert_to_fft.rs:84:9 [INFO] [stderr] | [INFO] [stderr] 84 | input_index = input_index - len; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `input_index -= len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/algorithm/type4_convert_to_fft.rs:92:9 [INFO] [stderr] | [INFO] [stderr] 92 | input_index = input_index - len; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `input_index -= len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/algorithm/type4_convert_to_fft.rs:100:9 [INFO] [stderr] | [INFO] [stderr] 100 | input_index = input_index - len; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `input_index -= len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/algorithm/type4_convert_to_fft.rs:167:9 [INFO] [stderr] | [INFO] [stderr] 167 | input_index = input_index - len; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `input_index -= len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/algorithm/type4_convert_to_fft.rs:175:9 [INFO] [stderr] | [INFO] [stderr] 175 | input_index = input_index - len; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `input_index -= len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/algorithm/type4_convert_to_fft.rs:183:9 [INFO] [stderr] | [INFO] [stderr] 183 | input_index = input_index - len; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `input_index -= len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/algorithm/type4_convert_to_fft.rs:191:9 [INFO] [stderr] | [INFO] [stderr] 191 | input_index = input_index - len; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `input_index -= len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: called `.get_mut().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/algorithm/type4_naive.rs:46:31 [INFO] [stderr] | [INFO] [stderr] 46 | let output_cell = output.get_mut(k).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `output[k]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `input`. [INFO] [stderr] --> src/algorithm/type4_naive.rs:52:22 [INFO] [stderr] | [INFO] [stderr] 52 | for i in 0..input.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 52 | for in &input { [INFO] [stderr] | ^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `.get_mut().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/algorithm/type4_naive.rs:70:31 [INFO] [stderr] | [INFO] [stderr] 70 | let output_cell = output.get_mut(k).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `output[k]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `input`. [INFO] [stderr] --> src/algorithm/type4_naive.rs:76:22 [INFO] [stderr] | [INFO] [stderr] 76 | for i in 0..input.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 76 | for in &input { [INFO] [stderr] | ^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `plan::DCTplanner` [INFO] [stderr] --> src/plan.rs:50:5 [INFO] [stderr] | [INFO] [stderr] 50 | / pub fn new() -> Self { [INFO] [stderr] 51 | | Self { [INFO] [stderr] 52 | | fft_planner: FFTplanner::new(false), [INFO] [stderr] 53 | | dct1_cache: HashMap::new(), [INFO] [stderr] ... | [INFO] [stderr] 58 | | } [INFO] [stderr] 59 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 49 | impl Default for plan::DCTplanner { [INFO] [stderr] 50 | fn default() -> Self { [INFO] [stderr] 51 | Self::new() [INFO] [stderr] 52 | } [INFO] [stderr] 53 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/plan.rs:64:9 [INFO] [stderr] | [INFO] [stderr] 64 | / if self.dct1_cache.contains_key(&len) { [INFO] [stderr] 65 | | Arc::clone(self.dct1_cache.get(&len).unwrap()) [INFO] [stderr] 66 | | } else { [INFO] [stderr] 67 | | let result = self.plan_new_dct1(len); [INFO] [stderr] 68 | | self.dct1_cache.insert(len, Arc::clone(&result)); [INFO] [stderr] 69 | | result [INFO] [stderr] 70 | | } [INFO] [stderr] | |_________^ help: consider using: `self.dct1_cache.entry(len)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/plan.rs:65:24 [INFO] [stderr] | [INFO] [stderr] 65 | Arc::clone(self.dct1_cache.get(&len).unwrap()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.dct1_cache[&len]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/plan.rs:89:9 [INFO] [stderr] | [INFO] [stderr] 89 | / if self.dct23_cache.contains_key(&len) { [INFO] [stderr] 90 | | Arc::clone(self.dct23_cache.get(&len).unwrap()) [INFO] [stderr] 91 | | } else { [INFO] [stderr] 92 | | let result = self.plan_new_dct2(len); [INFO] [stderr] 93 | | self.dct23_cache.insert(len, Arc::clone(&result)); [INFO] [stderr] 94 | | result [INFO] [stderr] 95 | | } [INFO] [stderr] | |_________^ help: consider using: `self.dct23_cache.entry(len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/plan.rs:90:24 [INFO] [stderr] | [INFO] [stderr] 90 | Arc::clone(self.dct23_cache.get(&len).unwrap()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.dct23_cache[&len]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/plan.rs:136:9 [INFO] [stderr] | [INFO] [stderr] 136 | / if self.dct4_cache.contains_key(&len) { [INFO] [stderr] 137 | | Arc::clone(self.dct4_cache.get(&len).unwrap()) [INFO] [stderr] 138 | | } else { [INFO] [stderr] 139 | | let result = self.plan_new_dct4(len); [INFO] [stderr] 140 | | self.dct4_cache.insert(len, Arc::clone(&result)); [INFO] [stderr] 141 | | result [INFO] [stderr] 142 | | } [INFO] [stderr] | |_________^ help: consider using: `self.dct4_cache.entry(len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/plan.rs:137:24 [INFO] [stderr] | [INFO] [stderr] 137 | Arc::clone(self.dct4_cache.get(&len).unwrap()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.dct4_cache[&len]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/plan.rs:170:9 [INFO] [stderr] | [INFO] [stderr] 170 | / if self.dst1_cache.contains_key(&len) { [INFO] [stderr] 171 | | Arc::clone(self.dst1_cache.get(&len).unwrap()) [INFO] [stderr] 172 | | } else { [INFO] [stderr] 173 | | let result = self.plan_new_dst1(len); [INFO] [stderr] 174 | | self.dst1_cache.insert(len, Arc::clone(&result)); [INFO] [stderr] 175 | | result [INFO] [stderr] 176 | | } [INFO] [stderr] | |_________^ help: consider using: `self.dst1_cache.entry(len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/plan.rs:171:24 [INFO] [stderr] | [INFO] [stderr] 171 | Arc::clone(self.dst1_cache.get(&len).unwrap()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.dst1_cache[&len]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/plan.rs:216:9 [INFO] [stderr] | [INFO] [stderr] 216 | / if self.mdct_cache.contains_key(&len) { [INFO] [stderr] 217 | | Arc::clone(self.mdct_cache.get(&len).unwrap()) [INFO] [stderr] 218 | | } else { [INFO] [stderr] 219 | | let result = self.plan_new_mdct(len, window_fn); [INFO] [stderr] 220 | | self.mdct_cache.insert(len, Arc::clone(&result)); [INFO] [stderr] 221 | | result [INFO] [stderr] 222 | | } [INFO] [stderr] | |_________^ help: consider using: `self.mdct_cache.entry(len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/plan.rs:217:24 [INFO] [stderr] | [INFO] [stderr] 217 | Arc::clone(self.mdct_cache.get(&len).unwrap()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.mdct_cache[&len]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get_mut().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/mdct/mdct_naive.rs:67:31 [INFO] [stderr] | [INFO] [stderr] 67 | let output_cell = output.get_mut(k).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `output[k]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `input_a` [INFO] [stderr] --> src/mdct/mdct_naive.rs:73:22 [INFO] [stderr] | [INFO] [stderr] 73 | for i in 0..input_a.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 73 | for (i, ) in input_a.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `input_b` [INFO] [stderr] --> src/mdct/mdct_naive.rs:84:22 [INFO] [stderr] | [INFO] [stderr] 84 | for i in 0..input_b.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 84 | for (i, ) in input_b.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `k` is used to index `output_a` [INFO] [stderr] --> src/mdct/mdct_naive.rs:103:18 [INFO] [stderr] | [INFO] [stderr] 103 | for k in 0..input_len { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 103 | for (k, ) in output_a.iter_mut().enumerate().take(input_len) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `input`. [INFO] [stderr] --> src/mdct/mdct_naive.rs:109:22 [INFO] [stderr] | [INFO] [stderr] 109 | for i in 0..input.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 109 | for in &input { [INFO] [stderr] | ^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `k` is used to index `output_b` [INFO] [stderr] --> src/mdct/mdct_naive.rs:122:18 [INFO] [stderr] | [INFO] [stderr] 122 | for k in 0..input_len { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 122 | for (k, ) in output_b.iter_mut().enumerate().take(input_len) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `input`. [INFO] [stderr] --> src/mdct/mdct_naive.rs:135:22 [INFO] [stderr] | [INFO] [stderr] 135 | for i in 0..input.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 135 | for in &input { [INFO] [stderr] | ^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/mdct/mdct_naive.rs:190:18 [INFO] [stderr] | [INFO] [stderr] 190 | -2.90775651, [INFO] [stderr] | ^^^^^^^^^^ help: consider changing the type or truncating it to: `2.907_756_6` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::excessive_precision)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/mdct/mdct_naive.rs:191:18 [INFO] [stderr] | [INFO] [stderr] 191 | -12.30026278, [INFO] [stderr] | ^^^^^^^^^^^ help: consider changing the type or truncating it to: `12.300_262` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/mdct/mdct_naive.rs:192:17 [INFO] [stderr] | [INFO] [stderr] 192 | 6.92661442, [INFO] [stderr] | ^^^^^^^^^^ help: consider changing the type or truncating it to: `6.926_614_3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/mdct/mdct_naive.rs:193:17 [INFO] [stderr] | [INFO] [stderr] 193 | 2.79403335, [INFO] [stderr] | ^^^^^^^^^^ help: consider changing the type or truncating it to: `2.794_033_3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/mdct/mdct_naive.rs:194:17 [INFO] [stderr] | [INFO] [stderr] 194 | 3.56420194, [INFO] [stderr] | ^^^^^^^^^^ help: consider changing the type or truncating it to: `3.564_201_8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/mdct/mdct_naive.rs:195:18 [INFO] [stderr] | [INFO] [stderr] 195 | -2.40007133, [INFO] [stderr] | ^^^^^^^^^^ help: consider changing the type or truncating it to: `2.400_071_4` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/mdct/mdct_naive.rs:230:18 [INFO] [stderr] | [INFO] [stderr] 230 | vec![2.29289322, 1.53553391], [INFO] [stderr] | ^^^^^^^^^^ help: consider changing the type or truncating it to: `2.292_893_2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/mdct/mdct_naive.rs:230:30 [INFO] [stderr] | [INFO] [stderr] 230 | vec![2.29289322, 1.53553391], [INFO] [stderr] | ^^^^^^^^^^ help: consider changing the type or truncating it to: `1.535_533_9` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/mdct/mdct_naive.rs:231:19 [INFO] [stderr] | [INFO] [stderr] 231 | vec![-4.67324308, 3.1647844, -6.22625186, 2.1647844], [INFO] [stderr] | ^^^^^^^^^^ help: consider changing the type or truncating it to: `4.673_243` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/mdct/mdct_naive.rs:231:43 [INFO] [stderr] | [INFO] [stderr] 231 | vec![-4.67324308, 3.1647844, -6.22625186, 2.1647844], [INFO] [stderr] | ^^^^^^^^^^ help: consider changing the type or truncating it to: `6.226_252` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/mdct/mdct_naive.rs:233:18 [INFO] [stderr] | [INFO] [stderr] 233 | -5.50153067, [INFO] [stderr] | ^^^^^^^^^^ help: consider changing the type or truncating it to: `5.501_530_6` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/mdct/mdct_naive.rs:234:18 [INFO] [stderr] | [INFO] [stderr] 234 | -3.46580575, [INFO] [stderr] | ^^^^^^^^^^ help: consider changing the type or truncating it to: `3.465_805_8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/mdct/mdct_naive.rs:235:17 [INFO] [stderr] | [INFO] [stderr] 235 | 3.79375195, [INFO] [stderr] | ^^^^^^^^^^ help: consider changing the type or truncating it to: `3.793_752` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/mdct/mdct_naive.rs:236:18 [INFO] [stderr] | [INFO] [stderr] 236 | -1.25072987, [INFO] [stderr] | ^^^^^^^^^^ help: consider changing the type or truncating it to: `1.250_729_9` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/mdct/mdct_naive.rs:237:17 [INFO] [stderr] | [INFO] [stderr] 237 | 4.6738204, [INFO] [stderr] | ^^^^^^^^^ help: consider changing the type or truncating it to: `4.673_820_5` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/mdct/mdct_naive.rs:238:17 [INFO] [stderr] | [INFO] [stderr] 238 | 3.16506351, [INFO] [stderr] | ^^^^^^^^^^ help: consider changing the type or truncating it to: `3.165_063_6` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: The function/method `process_mdct` doesn't need a mutable reference [INFO] [stderr] --> src/mdct/mdct_naive.rs:266:34 [INFO] [stderr] | [INFO] [stderr] 266 | dct.process_mdct(&mut input, &mut fast_output); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: the loop variable `k` is used to index `output` [INFO] [stderr] --> src/mdct/mdct_naive.rs:293:18 [INFO] [stderr] | [INFO] [stderr] 293 | for k in 0..output.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 293 | for (k, ) in output.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `n` is used to index `windowed_input` [INFO] [stderr] --> src/mdct/mdct_naive.rs:298:22 [INFO] [stderr] | [INFO] [stderr] 298 | for n in 0..input.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 298 | for (n, ) in windowed_input.iter().enumerate().take(input.len()) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/mdct/mdct_naive.rs:375:18 [INFO] [stderr] | [INFO] [stderr] 375 | -1.6213203435596431, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `1.621_320_4` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/mdct/mdct_naive.rs:376:17 [INFO] [stderr] | [INFO] [stderr] 376 | 3.9142135623730936, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `3.914_213_7` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/mdct/mdct_naive.rs:377:18 [INFO] [stderr] | [INFO] [stderr] 377 | -2.6213203435596433, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `2.621_320_2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/mdct/mdct_naive.rs:378:18 [INFO] [stderr] | [INFO] [stderr] 378 | -1.0857864376269069, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `1.085_786_5` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/mdct/mdct_naive.rs:381:17 [INFO] [stderr] | [INFO] [stderr] 381 | 1.1380080486867217, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `1.138_008` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/mdct/mdct_naive.rs:382:17 [INFO] [stderr] | [INFO] [stderr] 382 | 1.3486674811260955, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `1.348_667_5` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/mdct/mdct_naive.rs:383:18 [INFO] [stderr] | [INFO] [stderr] 383 | -2.0184235241728627, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `2.018_423_6` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/mdct/mdct_naive.rs:384:18 [INFO] [stderr] | [INFO] [stderr] 384 | -5.7211528055198331, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `5.721_153` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/mdct/mdct_naive.rs:385:17 [INFO] [stderr] | [INFO] [stderr] 385 | 4.7406716077536428, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `4.740_671_6` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/mdct/mdct_naive.rs:386:18 [INFO] [stderr] | [INFO] [stderr] 386 | -12.126842074178105, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `12.126_842_5` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/mdct/mdct_naive.rs:387:18 [INFO] [stderr] | [INFO] [stderr] 387 | -8.1028968193867765, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `8.102_897` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/mdct/mdct_naive.rs:388:17 [INFO] [stderr] | [INFO] [stderr] 388 | 0.94297821246780911, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.942_978_2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/mdct/mdct_naive.rs:391:17 [INFO] [stderr] | [INFO] [stderr] 391 | 0.3150751815802082, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.315_075_2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/mdct/mdct_naive.rs:392:17 [INFO] [stderr] | [INFO] [stderr] 392 | 3.4142135623730949, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `3.414_213_7` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/mdct/mdct_naive.rs:393:18 [INFO] [stderr] | [INFO] [stderr] 393 | -1.4828837895525038, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `1.482_883_8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/mdct/mdct_naive.rs:394:17 [INFO] [stderr] | [INFO] [stderr] 394 | 1.9325317795197492, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `1.932_531_8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/mdct/mdct_naive.rs:395:18 [INFO] [stderr] | [INFO] [stderr] 395 | -8.2426406871192732, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `8.242_640_5` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/mdct/mdct_naive.rs:396:18 [INFO] [stderr] | [INFO] [stderr] 396 | -2.3932336063055089, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `2.393_233_5` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/mdct/mdct_naive.rs:397:17 [INFO] [stderr] | [INFO] [stderr] 397 | 3.1189227588735786, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `3.118_922_7` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/mdct/mdct_naive.rs:398:18 [INFO] [stderr] | [INFO] [stderr] 398 | -0.58578643762689731, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.585_786_46` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/mdct/mdct_naive.rs:399:18 [INFO] [stderr] | [INFO] [stderr] 399 | -14.679036212259122, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `14.679_036` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/mdct/mdct_naive.rs:400:18 [INFO] [stderr] | [INFO] [stderr] 400 | -11.263620643186901, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `11.263_62` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/mdct/mdct_naive.rs:401:18 [INFO] [stderr] | [INFO] [stderr] 401 | -0.24264068711929426, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.242_640_69` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/mdct/mdct_naive.rs:402:17 [INFO] [stderr] | [INFO] [stderr] 402 | 0.41061397098787894, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.410_613_98` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: The function/method `process_imdct` doesn't need a mutable reference [INFO] [stderr] --> src/mdct/mdct_naive.rs:434:35 [INFO] [stderr] | [INFO] [stderr] 434 | dct.process_imdct(&mut input, &mut fast_output); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: the loop variable `n` is used to index `output` [INFO] [stderr] --> src/mdct/mdct_naive.rs:454:18 [INFO] [stderr] | [INFO] [stderr] 454 | for n in 0..output.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 454 | for (n, ) in output.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `k` is used to index `input` [INFO] [stderr] --> src/mdct/mdct_naive.rs:459:22 [INFO] [stderr] | [INFO] [stderr] 459 | for k in 0..input.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 459 | for (k, ) in input.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `.get_mut().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/algorithm/type1_naive.rs:54:31 [INFO] [stderr] | [INFO] [stderr] 54 | let output_cell = output.get_mut(k).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `output[k]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `input`. [INFO] [stderr] --> src/algorithm/type1_naive.rs:60:22 [INFO] [stderr] | [INFO] [stderr] 60 | for i in 1..input.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 60 | for in input.iter().skip(1) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `.get_mut().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/algorithm/type1_naive.rs:121:31 [INFO] [stderr] | [INFO] [stderr] 121 | let output_cell = output.get_mut(k).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `output[k]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `input`. [INFO] [stderr] --> src/algorithm/type1_naive.rs:127:22 [INFO] [stderr] | [INFO] [stderr] 127 | for i in 0..input.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 127 | for in &input { [INFO] [stderr] | ^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `algorithm::type2and3_butterflies::Type2And3Butterfly2` [INFO] [stderr] --> src/algorithm/type2and3_butterflies.rs:57:2 [INFO] [stderr] | [INFO] [stderr] 57 | pub fn new() -> Self { [INFO] [stderr] | _____^ [INFO] [stderr] 58 | | Type2And3Butterfly2 { [INFO] [stderr] 59 | | _phantom: PhantomData, [INFO] [stderr] 60 | | } [INFO] [stderr] 61 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 53 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `algorithm::type2and3_butterflies::Type2And3Butterfly4` [INFO] [stderr] --> src/algorithm/type2and3_butterflies.rs:152:2 [INFO] [stderr] | [INFO] [stderr] 152 | pub fn new() -> Self { [INFO] [stderr] | _____^ [INFO] [stderr] 153 | | Type2And3Butterfly4 { [INFO] [stderr] 154 | | twiddle: twiddles::single_twiddle(1,16).conj() [INFO] [stderr] 155 | | } [INFO] [stderr] 156 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 151 | impl Default for algorithm::type2and3_butterflies::Type2And3Butterfly4 { [INFO] [stderr] 152 | fn default() -> Self { [INFO] [stderr] 153 | Self::new() [INFO] [stderr] 154 | } [INFO] [stderr] 155 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `algorithm::type2and3_butterflies::Type2And3Butterfly8` [INFO] [stderr] --> src/algorithm/type2and3_butterflies.rs:226:2 [INFO] [stderr] | [INFO] [stderr] 226 | pub fn new() -> Self { [INFO] [stderr] | _____^ [INFO] [stderr] 227 | | Type2And3Butterfly8 { [INFO] [stderr] 228 | | butterfly4: Type2And3Butterfly4::new(), [INFO] [stderr] 229 | | butterfly2: Type2And3Butterfly2::new(), [INFO] [stderr] ... | [INFO] [stderr] 234 | | } [INFO] [stderr] 235 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 225 | impl Default for algorithm::type2and3_butterflies::Type2And3Butterfly8 { [INFO] [stderr] 226 | fn default() -> Self { [INFO] [stderr] 227 | Self::new() [INFO] [stderr] 228 | } [INFO] [stderr] 229 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `algorithm::type2and3_butterflies::Type2And3Butterfly16` [INFO] [stderr] --> src/algorithm/type2and3_butterflies.rs:417:2 [INFO] [stderr] | [INFO] [stderr] 417 | pub fn new() -> Self { [INFO] [stderr] | _____^ [INFO] [stderr] 418 | | Type2And3Butterfly16 { [INFO] [stderr] 419 | | butterfly8: Type2And3Butterfly8::new(), [INFO] [stderr] 420 | | butterfly4: Type2And3Butterfly4::new(), [INFO] [stderr] ... | [INFO] [stderr] 427 | | } [INFO] [stderr] 428 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 416 | impl Default for algorithm::type2and3_butterflies::Type2And3Butterfly16 { [INFO] [stderr] 417 | fn default() -> Self { [INFO] [stderr] 418 | Self::new() [INFO] [stderr] 419 | } [INFO] [stderr] 420 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/common/known_data.rs:57:109 [INFO] [stderr] | [INFO] [stderr] 57 | KnownTestValues { input: vec![1.0, 1.0, 1.0, 1.0], expected_output: vec![2.5137, -0.7483, 0.33409, -0.099456] }, [INFO] [stderr] | ^^^^^^^^ help: consider: `0.099_456` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/common/known_data.rs:58:120 [INFO] [stderr] | [INFO] [stderr] 58 | KnownTestValues { input: vec![1.0, 1.0, 1.0, 1.0, 1.0], expected_output: vec![3.1569, -0.98131, 0.5, -0.25476, 0.079192] }, [INFO] [stderr] | ^^^^^^^^ help: consider: `0.079_192` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/common/known_data.rs:83:92 [INFO] [stderr] | [INFO] [stderr] 83 | KnownTestValues { input: vec![3.3, 5.9, -1.9, 6.25], expected_output: vec![8.306, -0.016005, 0.87276, -10.344] }, [INFO] [stderr] | ^^^^^^^^ help: consider: `0.016_005` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/common/known_data.rs:141:107 [INFO] [stderr] | [INFO] [stderr] 141 | KnownTestValues { input: vec![1.0, 1.0, 1.0, 1.0], expected_output: vec![2.5137, 0.7483, 0.33409, 0.099456] }, [INFO] [stderr] | ^^^^^^^^ help: consider: `0.099_456` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/common/known_data.rs:142:118 [INFO] [stderr] | [INFO] [stderr] 142 | KnownTestValues { input: vec![1.0, 1.0, 1.0, 1.0, 1.0], expected_output: vec![3.1569, 0.98131, 0.5, 0.25476, 0.079192] }, [INFO] [stderr] | ^^^^^^^^ help: consider: `0.079_192` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> tests/common/slow_fns.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> tests/common/slow_fns.rs:50:5 [INFO] [stderr] | [INFO] [stderr] 50 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> tests/common/slow_fns.rs:75:5 [INFO] [stderr] | [INFO] [stderr] 75 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> tests/common/slow_fns.rs:101:5 [INFO] [stderr] | [INFO] [stderr] 101 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> tests/common/slow_fns.rs:125:5 [INFO] [stderr] | [INFO] [stderr] 125 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> tests/common/slow_fns.rs:147:5 [INFO] [stderr] | [INFO] [stderr] 147 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> tests/common/slow_fns.rs:176:5 [INFO] [stderr] | [INFO] [stderr] 176 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> tests/common/slow_fns.rs:199:5 [INFO] [stderr] | [INFO] [stderr] 199 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> tests/common/mod.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | return sig; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `sig` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> benches/bench_dct_naive.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #![feature(test)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error: Could not compile `rustdct`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> benches/bench_dct_planned.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #![feature(test)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error: Could not compile `rustdct`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: called `.get_mut().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/algorithm/type2and3_naive.rs:54:31 [INFO] [stderr] | [INFO] [stderr] 54 | let output_cell = output.get_mut(k).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `output[k]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `input`. [INFO] [stderr] --> src/algorithm/type2and3_naive.rs:60:22 [INFO] [stderr] | [INFO] [stderr] 60 | for i in 0..input.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 60 | for in &input { [INFO] [stderr] | ^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `.get_mut().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/algorithm/type2and3_naive.rs:78:31 [INFO] [stderr] | [INFO] [stderr] 78 | let output_cell = output.get_mut(k).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `output[k]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `input`. [INFO] [stderr] --> src/algorithm/type2and3_naive.rs:84:22 [INFO] [stderr] | [INFO] [stderr] 84 | for i in 0..input.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 84 | for in &input { [INFO] [stderr] | ^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `.get_mut().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/algorithm/type2and3_naive.rs:104:31 [INFO] [stderr] | [INFO] [stderr] 104 | let output_cell = output.get_mut(k).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `output[k]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `input`. [INFO] [stderr] --> src/algorithm/type2and3_naive.rs:110:22 [INFO] [stderr] | [INFO] [stderr] 110 | for i in 1..input.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 110 | for in input.iter().skip(1) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `.get_mut().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/algorithm/type2and3_naive.rs:131:31 [INFO] [stderr] | [INFO] [stderr] 131 | let output_cell = output.get_mut(k).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `output[k]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `input`. [INFO] [stderr] --> src/algorithm/type2and3_naive.rs:137:22 [INFO] [stderr] | [INFO] [stderr] 137 | for i in 0..input.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 137 | for in &input { [INFO] [stderr] | ^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/algorithm/type4_convert_to_fft.rs:76:9 [INFO] [stderr] | [INFO] [stderr] 76 | input_index = input_index - len; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `input_index -= len` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/algorithm/type4_convert_to_fft.rs:84:9 [INFO] [stderr] | [INFO] [stderr] 84 | input_index = input_index - len; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `input_index -= len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/algorithm/type4_convert_to_fft.rs:92:9 [INFO] [stderr] | [INFO] [stderr] 92 | input_index = input_index - len; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `input_index -= len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/algorithm/type4_convert_to_fft.rs:100:9 [INFO] [stderr] | [INFO] [stderr] 100 | input_index = input_index - len; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `input_index -= len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/algorithm/type4_convert_to_fft.rs:167:9 [INFO] [stderr] | [INFO] [stderr] 167 | input_index = input_index - len; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `input_index -= len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/algorithm/type4_convert_to_fft.rs:175:9 [INFO] [stderr] | [INFO] [stderr] 175 | input_index = input_index - len; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `input_index -= len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/algorithm/type4_convert_to_fft.rs:183:9 [INFO] [stderr] | [INFO] [stderr] 183 | input_index = input_index - len; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `input_index -= len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/algorithm/type4_convert_to_fft.rs:191:9 [INFO] [stderr] | [INFO] [stderr] 191 | input_index = input_index - len; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `input_index -= len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: called `.get_mut().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/algorithm/type4_naive.rs:46:31 [INFO] [stderr] | [INFO] [stderr] 46 | let output_cell = output.get_mut(k).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `output[k]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `input`. [INFO] [stderr] --> src/algorithm/type4_naive.rs:52:22 [INFO] [stderr] | [INFO] [stderr] 52 | for i in 0..input.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 52 | for in &input { [INFO] [stderr] | ^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `.get_mut().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/algorithm/type4_naive.rs:70:31 [INFO] [stderr] | [INFO] [stderr] 70 | let output_cell = output.get_mut(k).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `output[k]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `input`. [INFO] [stderr] --> src/algorithm/type4_naive.rs:76:22 [INFO] [stderr] | [INFO] [stderr] 76 | for i in 0..input.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 76 | for in &input { [INFO] [stderr] | ^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `plan::DCTplanner` [INFO] [stderr] --> src/plan.rs:50:5 [INFO] [stderr] | [INFO] [stderr] 50 | / pub fn new() -> Self { [INFO] [stderr] 51 | | Self { [INFO] [stderr] 52 | | fft_planner: FFTplanner::new(false), [INFO] [stderr] 53 | | dct1_cache: HashMap::new(), [INFO] [stderr] ... | [INFO] [stderr] 58 | | } [INFO] [stderr] 59 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 49 | impl Default for plan::DCTplanner { [INFO] [stderr] 50 | fn default() -> Self { [INFO] [stderr] 51 | Self::new() [INFO] [stderr] 52 | } [INFO] [stderr] 53 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/plan.rs:64:9 [INFO] [stderr] | [INFO] [stderr] 64 | / if self.dct1_cache.contains_key(&len) { [INFO] [stderr] 65 | | Arc::clone(self.dct1_cache.get(&len).unwrap()) [INFO] [stderr] 66 | | } else { [INFO] [stderr] 67 | | let result = self.plan_new_dct1(len); [INFO] [stderr] 68 | | self.dct1_cache.insert(len, Arc::clone(&result)); [INFO] [stderr] 69 | | result [INFO] [stderr] 70 | | } [INFO] [stderr] | |_________^ help: consider using: `self.dct1_cache.entry(len)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/plan.rs:65:24 [INFO] [stderr] | [INFO] [stderr] 65 | Arc::clone(self.dct1_cache.get(&len).unwrap()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.dct1_cache[&len]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/plan.rs:89:9 [INFO] [stderr] | [INFO] [stderr] 89 | / if self.dct23_cache.contains_key(&len) { [INFO] [stderr] 90 | | Arc::clone(self.dct23_cache.get(&len).unwrap()) [INFO] [stderr] 91 | | } else { [INFO] [stderr] 92 | | let result = self.plan_new_dct2(len); [INFO] [stderr] 93 | | self.dct23_cache.insert(len, Arc::clone(&result)); [INFO] [stderr] 94 | | result [INFO] [stderr] 95 | | } [INFO] [stderr] | |_________^ help: consider using: `self.dct23_cache.entry(len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/plan.rs:90:24 [INFO] [stderr] | [INFO] [stderr] 90 | Arc::clone(self.dct23_cache.get(&len).unwrap()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.dct23_cache[&len]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/plan.rs:136:9 [INFO] [stderr] | [INFO] [stderr] 136 | / if self.dct4_cache.contains_key(&len) { [INFO] [stderr] 137 | | Arc::clone(self.dct4_cache.get(&len).unwrap()) [INFO] [stderr] 138 | | } else { [INFO] [stderr] 139 | | let result = self.plan_new_dct4(len); [INFO] [stderr] 140 | | self.dct4_cache.insert(len, Arc::clone(&result)); [INFO] [stderr] 141 | | result [INFO] [stderr] 142 | | } [INFO] [stderr] | |_________^ help: consider using: `self.dct4_cache.entry(len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/plan.rs:137:24 [INFO] [stderr] | [INFO] [stderr] 137 | Arc::clone(self.dct4_cache.get(&len).unwrap()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.dct4_cache[&len]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/plan.rs:170:9 [INFO] [stderr] | [INFO] [stderr] 170 | / if self.dst1_cache.contains_key(&len) { [INFO] [stderr] 171 | | Arc::clone(self.dst1_cache.get(&len).unwrap()) [INFO] [stderr] 172 | | } else { [INFO] [stderr] 173 | | let result = self.plan_new_dst1(len); [INFO] [stderr] 174 | | self.dst1_cache.insert(len, Arc::clone(&result)); [INFO] [stderr] 175 | | result [INFO] [stderr] 176 | | } [INFO] [stderr] | |_________^ help: consider using: `self.dst1_cache.entry(len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/plan.rs:171:24 [INFO] [stderr] | [INFO] [stderr] 171 | Arc::clone(self.dst1_cache.get(&len).unwrap()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.dst1_cache[&len]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/plan.rs:216:9 [INFO] [stderr] | [INFO] [stderr] 216 | / if self.mdct_cache.contains_key(&len) { [INFO] [stderr] 217 | | Arc::clone(self.mdct_cache.get(&len).unwrap()) [INFO] [stderr] 218 | | } else { [INFO] [stderr] 219 | | let result = self.plan_new_mdct(len, window_fn); [INFO] [stderr] 220 | | self.mdct_cache.insert(len, Arc::clone(&result)); [INFO] [stderr] 221 | | result [INFO] [stderr] 222 | | } [INFO] [stderr] | |_________^ help: consider using: `self.mdct_cache.entry(len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/plan.rs:217:24 [INFO] [stderr] | [INFO] [stderr] 217 | Arc::clone(self.mdct_cache.get(&len).unwrap()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.mdct_cache[&len]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> benches/bench_dct_via_fft.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #![feature(test)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error: Could not compile `rustdct`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: approximate value of `f{32, 64}::consts::FRAC_1_SQRT_2` found. Consider using it directly [INFO] [stderr] --> tests/common/known_data.rs:75:67 [INFO] [stderr] | [INFO] [stderr] 75 | KnownTestValues { input: vec![1.0], expected_output: vec![0.70711] }, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::approx_constant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::FRAC_1_SQRT_2` found. Consider using it directly [INFO] [stderr] --> tests/common/known_data.rs:77:86 [INFO] [stderr] | [INFO] [stderr] 77 | KnownTestValues { input: vec![1.0, 1.0, 1.0], expected_output: vec![1.9319, -0.70711, 0.51764] }, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::FRAC_1_SQRT_2` found. Consider using it directly [INFO] [stderr] --> tests/common/known_data.rs:79:104 [INFO] [stderr] | [INFO] [stderr] 79 | KnownTestValues { input: vec![1.0, 1.0, 1.0, 1.0, 1.0], expected_output: vec![3.1962, -1.1013, 0.70711, -0.56116, 0.50623] }, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::SQRT_2` found. Consider using it directly [INFO] [stderr] --> tests/common/known_data.rs:118:72 [INFO] [stderr] | [INFO] [stderr] 118 | KnownTestValues { input: vec![1.0, 1.0], expected_output: vec![1.4142, 0.0] }, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::FRAC_1_SQRT_2` found. Consider using it directly [INFO] [stderr] --> tests/common/known_data.rs:159:67 [INFO] [stderr] | [INFO] [stderr] 159 | KnownTestValues { input: vec![1.0], expected_output: vec![0.70711] }, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::FRAC_1_SQRT_2` found. Consider using it directly [INFO] [stderr] --> tests/common/known_data.rs:161:85 [INFO] [stderr] | [INFO] [stderr] 161 | KnownTestValues { input: vec![1.0, 1.0, 1.0], expected_output: vec![1.9319, 0.70711, 0.51764] }, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::FRAC_1_SQRT_2` found. Consider using it directly [INFO] [stderr] --> tests/common/known_data.rs:163:103 [INFO] [stderr] | [INFO] [stderr] 163 | KnownTestValues { input: vec![1.0, 1.0, 1.0, 1.0, 1.0], expected_output: vec![3.1962, 1.1013, 0.70711, 0.56116, 0.50623] }, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `input` [INFO] [stderr] --> tests/common/slow_fns.rs:17:18 [INFO] [stderr] | [INFO] [stderr] 17 | for i in 1..(input.len() - 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 17 | for (i, ) in input.iter().enumerate().take((input.len() - 1)).skip(1) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `input` [INFO] [stderr] --> tests/common/slow_fns.rs:40:18 [INFO] [stderr] | [INFO] [stderr] 40 | for i in 0..(input.len()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 40 | for (i, ) in input.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `input` [INFO] [stderr] --> tests/common/slow_fns.rs:64:18 [INFO] [stderr] | [INFO] [stderr] 64 | for i in 1..(input.len()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 64 | for (i, ) in input.iter().enumerate().skip(1) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `input` [INFO] [stderr] --> tests/common/slow_fns.rs:90:18 [INFO] [stderr] | [INFO] [stderr] 90 | for i in 0..input.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 90 | for (i, ) in input.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `input` [INFO] [stderr] --> tests/common/slow_fns.rs:114:18 [INFO] [stderr] | [INFO] [stderr] 114 | for i in 0..input.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 114 | for (i, ) in input.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `input` [INFO] [stderr] --> tests/common/slow_fns.rs:138:18 [INFO] [stderr] | [INFO] [stderr] 138 | for i in 0..input.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 138 | for (i, ) in input.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `input` [INFO] [stderr] --> tests/common/slow_fns.rs:189:18 [INFO] [stderr] | [INFO] [stderr] 189 | for i in 0..input.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 189 | for (i, ) in input.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: The function/method `process_mdct` doesn't need a mutable reference [INFO] [stderr] --> tests/common/macros.rs:91:32 [INFO] [stderr] | [INFO] [stderr] 91 | naive_dct.process_mdct(&mut naive_input, &mut naive_output); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `process_mdct` doesn't need a mutable reference [INFO] [stderr] --> tests/common/macros.rs:92:33 [INFO] [stderr] | [INFO] [stderr] 92 | actual_dct.process_mdct(&mut actual_input, &mut actual_output); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> tests/common/macros.rs:132:13 [INFO] [stderr] | [INFO] [stderr] 132 | *element = *element * scale_factor; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*element *= scale_factor` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] error: aborting due to 7 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rustdct`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "c6d45094982fca8c84067852ca26ac857d4e6912371cd70160aef16d2684389d"` [INFO] running `"docker" "rm" "-f" "c6d45094982fca8c84067852ca26ac857d4e6912371cd70160aef16d2684389d"` [INFO] [stdout] c6d45094982fca8c84067852ca26ac857d4e6912371cd70160aef16d2684389d