[INFO] crate rustbuddy 0.1.0 is already in cache [INFO] extracting crate rustbuddy 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/rustbuddy/0.1.0 [INFO] extracting crate rustbuddy 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rustbuddy/0.1.0 [INFO] validating manifest of rustbuddy-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rustbuddy-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rustbuddy-0.1.0 [INFO] finished frobbing rustbuddy-0.1.0 [INFO] frobbed toml for rustbuddy-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/rustbuddy/0.1.0/Cargo.toml [INFO] started frobbing rustbuddy-0.1.0 [INFO] finished frobbing rustbuddy-0.1.0 [INFO] frobbed toml for rustbuddy-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rustbuddy/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rustbuddy-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rustbuddy/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fd2179532fabbfcb45176c116a4dccbe0e93b7ea1aa959059729f7575b2b3d27 [INFO] running `"docker" "start" "-a" "fd2179532fabbfcb45176c116a4dccbe0e93b7ea1aa959059729f7575b2b3d27"` [INFO] [stderr] Checking rustbuddy v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | levels: levels, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `levels` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | levels: levels, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `levels` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | / return BuddyAllocator{ [INFO] [stderr] 18 | | levels: levels, [INFO] [stderr] 19 | | tree: vec![NODE_UNUSED; size], [INFO] [stderr] 20 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 17 | BuddyAllocator{ [INFO] [stderr] 18 | levels: levels, [INFO] [stderr] 19 | tree: vec![NODE_UNUSED; size], [INFO] [stderr] 20 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/lib.rs:16:28 [INFO] [stderr] | [INFO] [stderr] 16 | let size: usize = (1 << levels + 1) - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `1 << (levels + 1)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:92:9 [INFO] [stderr] | [INFO] [stderr] 92 | return index as isize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `index as isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:173:9 [INFO] [stderr] | [INFO] [stderr] 173 | return out; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `out` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | / return BuddyAllocator{ [INFO] [stderr] 18 | | levels: levels, [INFO] [stderr] 19 | | tree: vec![NODE_UNUSED; size], [INFO] [stderr] 20 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 17 | BuddyAllocator{ [INFO] [stderr] 18 | levels: levels, [INFO] [stderr] 19 | tree: vec![NODE_UNUSED; size], [INFO] [stderr] 20 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/lib.rs:16:28 [INFO] [stderr] | [INFO] [stderr] 16 | let size: usize = (1 << levels + 1) - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `1 << (levels + 1)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:92:9 [INFO] [stderr] | [INFO] [stderr] 92 | return index as isize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `index as isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:173:9 [INFO] [stderr] | [INFO] [stderr] 173 | return out; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `out` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/lib.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | / let requested_blocks: f64; [INFO] [stderr] 27 | | if s == 0 { [INFO] [stderr] 28 | | requested_blocks = 1.0; [INFO] [stderr] 29 | | } else { [INFO] [stderr] 30 | | requested_blocks = s.next_power_of_two() as f64; [INFO] [stderr] 31 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let requested_blocks = if s == 0 { 1.0 } else { s.next_power_of_two() as f64 };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/lib.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | / let requested_blocks: f64; [INFO] [stderr] 27 | | if s == 0 { [INFO] [stderr] 28 | | requested_blocks = 1.0; [INFO] [stderr] 29 | | } else { [INFO] [stderr] 30 | | requested_blocks = s.next_power_of_two() as f64; [INFO] [stderr] 31 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let requested_blocks = if s == 0 { 1.0 } else { s.next_power_of_two() as f64 };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.15s [INFO] running `"docker" "inspect" "fd2179532fabbfcb45176c116a4dccbe0e93b7ea1aa959059729f7575b2b3d27"` [INFO] running `"docker" "rm" "-f" "fd2179532fabbfcb45176c116a4dccbe0e93b7ea1aa959059729f7575b2b3d27"` [INFO] [stdout] fd2179532fabbfcb45176c116a4dccbe0e93b7ea1aa959059729f7575b2b3d27