[INFO] crate rustamodb 0.0.6 is already in cache [INFO] extracting crate rustamodb 0.0.6 into work/ex/clippy-test-run/sources/stable/reg/rustamodb/0.0.6 [INFO] extracting crate rustamodb 0.0.6 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rustamodb/0.0.6 [INFO] validating manifest of rustamodb-0.0.6 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rustamodb-0.0.6 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rustamodb-0.0.6 [INFO] finished frobbing rustamodb-0.0.6 [INFO] frobbed toml for rustamodb-0.0.6 written to work/ex/clippy-test-run/sources/stable/reg/rustamodb/0.0.6/Cargo.toml [INFO] started frobbing rustamodb-0.0.6 [INFO] finished frobbing rustamodb-0.0.6 [INFO] frobbed toml for rustamodb-0.0.6 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rustamodb/0.0.6/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rustamodb-0.0.6 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rustamodb/0.0.6:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 23c5f074e69213db5d2d345c233fd3c8f33d3f7c22f20bda6c76d7c5ca7d5716 [INFO] running `"docker" "start" "-a" "23c5f074e69213db5d2d345c233fd3c8f33d3f7c22f20bda6c76d7c5ca7d5716"` [INFO] [stderr] Compiling rusoto_core v0.32.0 [INFO] [stderr] Checking rusoto_credential v0.11.0 [INFO] [stderr] Checking rusoto_dynamodb v0.32.0 [INFO] [stderr] Checking rustamodb v0.0.6 (/opt/crater/workdir) [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/ops.rs:19:58 [INFO] [stderr] | [INFO] [stderr] 19 | name: env::var("AWS_DEFAULT_REGION").unwrap_or(format!("us-east-1")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| format!("us-east-1"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/ops.rs:19:68 [INFO] [stderr] | [INFO] [stderr] 19 | name: env::var("AWS_DEFAULT_REGION").unwrap_or(format!("us-east-1")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"us-east-1".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/ops.rs:65:29 [INFO] [stderr] | [INFO] [stderr] 65 | None => Err(format!("no items in db")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"no items in db".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/ops.rs:68:23 [INFO] [stderr] | [INFO] [stderr] 68 | Err(_) => Err(format!("no db found")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"no db found".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/ops.rs:82:29 [INFO] [stderr] | [INFO] [stderr] 82 | None => Err(format!("item not found in dynamo_db")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"item not found in dynamo_db".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/ops.rs:85:23 [INFO] [stderr] | [INFO] [stderr] 85 | Err(_) => Err(format!("unknown error")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"unknown error".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/ops.rs:19:58 [INFO] [stderr] | [INFO] [stderr] 19 | name: env::var("AWS_DEFAULT_REGION").unwrap_or(format!("us-east-1")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| format!("us-east-1"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/ops.rs:19:68 [INFO] [stderr] | [INFO] [stderr] 19 | name: env::var("AWS_DEFAULT_REGION").unwrap_or(format!("us-east-1")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"us-east-1".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/ops.rs:65:29 [INFO] [stderr] | [INFO] [stderr] 65 | None => Err(format!("no items in db")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"no items in db".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/ops.rs:68:23 [INFO] [stderr] | [INFO] [stderr] 68 | Err(_) => Err(format!("no db found")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"no db found".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/ops.rs:82:29 [INFO] [stderr] | [INFO] [stderr] 82 | None => Err(format!("item not found in dynamo_db")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"item not found in dynamo_db".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/ops.rs:85:23 [INFO] [stderr] | [INFO] [stderr] 85 | Err(_) => Err(format!("unknown error")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"unknown error".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 36.03s [INFO] running `"docker" "inspect" "23c5f074e69213db5d2d345c233fd3c8f33d3f7c22f20bda6c76d7c5ca7d5716"` [INFO] running `"docker" "rm" "-f" "23c5f074e69213db5d2d345c233fd3c8f33d3f7c22f20bda6c76d7c5ca7d5716"` [INFO] [stdout] 23c5f074e69213db5d2d345c233fd3c8f33d3f7c22f20bda6c76d7c5ca7d5716