[INFO] crate rustache 0.1.0 is already in cache [INFO] extracting crate rustache 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/rustache/0.1.0 [INFO] extracting crate rustache 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rustache/0.1.0 [INFO] validating manifest of rustache-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rustache-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rustache-0.1.0 [INFO] finished frobbing rustache-0.1.0 [INFO] frobbed toml for rustache-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/rustache/0.1.0/Cargo.toml [INFO] started frobbing rustache-0.1.0 [INFO] finished frobbing rustache-0.1.0 [INFO] frobbed toml for rustache-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rustache/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rustache-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rustache/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4f1c9bebdedb84c8a806a70c44729c8f640bdbe8bce251ef2d966da0486cf8a0 [INFO] running `"docker" "start" "-a" "4f1c9bebdedb84c8a806a70c44729c8f640bdbe8bce251ef2d966da0486cf8a0"` [INFO] [stderr] Checking rustache v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:153:13 [INFO] [stderr] | [INFO] [stderr] 153 | return Static(text); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Static(text)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:162:18 [INFO] [stderr] | [INFO] [stderr] 162 | false => return Value(name, raw.to_string()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Value(name, raw.to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:166:13 [INFO] [stderr] | [INFO] [stderr] 166 | return node; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:177:13 [INFO] [stderr] | [INFO] [stderr] 177 | return Unescaped(name, raw.to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Unescaped(name, raw.to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:184:21 [INFO] [stderr] | [INFO] [stderr] 184 | return node; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:188:21 [INFO] [stderr] | [INFO] [stderr] 188 | return node; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:218:25 [INFO] [stderr] | [INFO] [stderr] 218 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:221:25 [INFO] [stderr] | [INFO] [stderr] 221 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:224:26 [INFO] [stderr] | [INFO] [stderr] 224 | Parse => return false, [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:228:14 [INFO] [stderr] | [INFO] [stderr] 228 | _ => return false, [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:247:29 [INFO] [stderr] | [INFO] [stderr] 247 | return Unescaped(variable, var); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Unescaped(variable, var)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:253:29 [INFO] [stderr] | [INFO] [stderr] 253 | return Unescaped(variable, var); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Unescaped(variable, var)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:261:21 [INFO] [stderr] | [INFO] [stderr] 261 | return Value(variable, var); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Value(variable, var)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:275:13 [INFO] [stderr] | [INFO] [stderr] 275 | / return Section(variable, [INFO] [stderr] 276 | | vec![handle_dot_notation(&parts[1..], unescaped, amp)], [INFO] [stderr] 277 | | false, [INFO] [stderr] 278 | | otag, [INFO] [stderr] 279 | | ctag); [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 275 | Section(variable, [INFO] [stderr] 276 | vec![handle_dot_notation(&parts[1..], unescaped, amp)], [INFO] [stderr] 277 | false, [INFO] [stderr] 278 | otag, [INFO] [stderr] 279 | ctag) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:153:13 [INFO] [stderr] | [INFO] [stderr] 153 | return Static(text); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Static(text)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:162:18 [INFO] [stderr] | [INFO] [stderr] 162 | false => return Value(name, raw.to_string()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Value(name, raw.to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:166:13 [INFO] [stderr] | [INFO] [stderr] 166 | return node; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:177:13 [INFO] [stderr] | [INFO] [stderr] 177 | return Unescaped(name, raw.to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Unescaped(name, raw.to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:184:21 [INFO] [stderr] | [INFO] [stderr] 184 | return node; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:188:21 [INFO] [stderr] | [INFO] [stderr] 188 | return node; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:218:25 [INFO] [stderr] | [INFO] [stderr] 218 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:221:25 [INFO] [stderr] | [INFO] [stderr] 221 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:224:26 [INFO] [stderr] | [INFO] [stderr] 224 | Parse => return false, [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:228:14 [INFO] [stderr] | [INFO] [stderr] 228 | _ => return false, [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:247:29 [INFO] [stderr] | [INFO] [stderr] 247 | return Unescaped(variable, var); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Unescaped(variable, var)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:253:29 [INFO] [stderr] | [INFO] [stderr] 253 | return Unescaped(variable, var); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Unescaped(variable, var)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:261:21 [INFO] [stderr] | [INFO] [stderr] 261 | return Value(variable, var); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Value(variable, var)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:275:13 [INFO] [stderr] | [INFO] [stderr] 275 | / return Section(variable, [INFO] [stderr] 276 | | vec![handle_dot_notation(&parts[1..], unescaped, amp)], [INFO] [stderr] 277 | | false, [INFO] [stderr] 278 | | otag, [INFO] [stderr] 279 | | ctag); [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 275 | Section(variable, [INFO] [stderr] 276 | vec![handle_dot_notation(&parts[1..], unescaped, amp)], [INFO] [stderr] 277 | false, [INFO] [stderr] 278 | otag, [INFO] [stderr] 279 | ctag) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/parser.rs:50:30 [INFO] [stderr] | [INFO] [stderr] 50 | pub fn parse_nodes<'a>(list: &Vec>) -> Vec> { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Token<'a>]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/parser.rs:55:5 [INFO] [stderr] | [INFO] [stderr] 55 | / loop { [INFO] [stderr] 56 | | // Iterate while still nodes in the list [INFO] [stderr] 57 | | match it.next() { [INFO] [stderr] 58 | | Some((i, token)) => { [INFO] [stderr] ... | [INFO] [stderr] 137 | | } [INFO] [stderr] 138 | | } [INFO] [stderr] | |_____^ help: try: `while let Some((i, token)) = it.next() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/parser.rs:59:17 [INFO] [stderr] | [INFO] [stderr] 59 | / match token { [INFO] [stderr] 60 | | &Text(text) => nodes.push(parse_text_node(text, &mut status)), [INFO] [stderr] 61 | | &Variable(name, raw) => nodes.push(parse_variable_node(name, raw)), [INFO] [stderr] 62 | | &Raw(name, raw) => nodes.push(parse_raw_node(name, raw)), [INFO] [stderr] ... | [INFO] [stderr] 133 | | } [INFO] [stderr] 134 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 59 | match *token { [INFO] [stderr] 60 | Text(text) => nodes.push(parse_text_node(text, &mut status)), [INFO] [stderr] 61 | Variable(name, raw) => nodes.push(parse_variable_node(name, raw)), [INFO] [stderr] 62 | Raw(name, raw) => nodes.push(parse_raw_node(name, raw)), [INFO] [stderr] 63 | Partial(name, raw) => nodes.push(Part(name, raw)), [INFO] [stderr] 64 | // Unopened closing tags are ignored [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/parser.rs:115:33 [INFO] [stderr] | [INFO] [stderr] 115 | / match parse_comment_node(token, &mut status, &mut nodes) { [INFO] [stderr] 116 | | true => { [INFO] [stderr] 117 | | // it.next(); [INFO] [stderr] 118 | | } [INFO] [stderr] 119 | | false => {} [INFO] [stderr] 120 | | } [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/parser.rs:123:33 [INFO] [stderr] | [INFO] [stderr] 123 | / match nodes.last().unwrap() { [INFO] [stderr] 124 | | &Static(text) => { [INFO] [stderr] 125 | | if text.is_whitespace() { [INFO] [stderr] 126 | | nodes.pop(); [INFO] [stderr] ... | [INFO] [stderr] 129 | | _ => continue, [INFO] [stderr] 130 | | } [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 123 | match *nodes.last().unwrap() { [INFO] [stderr] 124 | Static(text) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/parser.rs:150:44 [INFO] [stderr] | [INFO] [stderr] 150 | } else if text.is_whitespace() { [INFO] [stderr] | ____________________________________________^ [INFO] [stderr] 151 | | *status = Skip; [INFO] [stderr] 152 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/parser.rs:148:36 [INFO] [stderr] | [INFO] [stderr] 148 | if text.contains("\n") { [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 149 | | *status = Skip; [INFO] [stderr] 150 | | } else if text.is_whitespace() { [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parser.rs:148:30 [INFO] [stderr] | [INFO] [stderr] 148 | if text.contains("\n") { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parser.rs:160:38 [INFO] [stderr] | [INFO] [stderr] 160 | let dot_notation = name.contains("."); [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/parser.rs:161:5 [INFO] [stderr] | [INFO] [stderr] 161 | / match dot_notation { [INFO] [stderr] 162 | | false => return Value(name, raw.to_string()), [INFO] [stderr] 163 | | true => { [INFO] [stderr] 164 | | let parts: Vec<&str> = name.split(".").collect(); [INFO] [stderr] ... | [INFO] [stderr] 167 | | } [INFO] [stderr] 168 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 161 | if dot_notation { [INFO] [stderr] 162 | let parts: Vec<&str> = name.split(".").collect(); [INFO] [stderr] 163 | let node = handle_dot_notation(&parts[..], false, false); [INFO] [stderr] 164 | return node; [INFO] [stderr] 165 | } else { return Value(name, raw.to_string()) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parser.rs:164:47 [INFO] [stderr] | [INFO] [stderr] 164 | let parts: Vec<&str> = name.split(".").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parser.rs:173:38 [INFO] [stderr] | [INFO] [stderr] 173 | let dot_notation = name.contains("."); [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parser.rs:174:34 [INFO] [stderr] | [INFO] [stderr] 174 | let ampersand = raw.contains("&"); [INFO] [stderr] | ^^^ help: try using a char instead: `'&'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/parser.rs:175:5 [INFO] [stderr] | [INFO] [stderr] 175 | / match dot_notation { [INFO] [stderr] 176 | | false => { [INFO] [stderr] 177 | | return Unescaped(name, raw.to_string()); [INFO] [stderr] 178 | | } [INFO] [stderr] ... | [INFO] [stderr] 191 | | } [INFO] [stderr] 192 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 175 | if dot_notation { [INFO] [stderr] 176 | let parts: Vec<&str> = name.split(".").collect(); [INFO] [stderr] 177 | match ampersand { [INFO] [stderr] 178 | true => { [INFO] [stderr] 179 | let node = handle_dot_notation(&parts[..], true, true); [INFO] [stderr] 180 | return node; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parser.rs:180:47 [INFO] [stderr] | [INFO] [stderr] 180 | let parts: Vec<&str> = name.split(".").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/parser.rs:181:13 [INFO] [stderr] | [INFO] [stderr] 181 | / match ampersand { [INFO] [stderr] 182 | | true => { [INFO] [stderr] 183 | | let node = handle_dot_notation(&parts[..], true, true); [INFO] [stderr] 184 | | return node; [INFO] [stderr] ... | [INFO] [stderr] 189 | | } [INFO] [stderr] 190 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 181 | if ampersand { [INFO] [stderr] 182 | let node = handle_dot_notation(&parts[..], true, true); [INFO] [stderr] 183 | return node; [INFO] [stderr] 184 | } else { [INFO] [stderr] 185 | let node = handle_dot_notation(&parts[..], true, false); [INFO] [stderr] 186 | return node; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser.rs:207:25 [INFO] [stderr] | [INFO] [stderr] 207 | / match nodes.last().unwrap() { [INFO] [stderr] 208 | | &Static(text) => { [INFO] [stderr] 209 | | // If the previous node is whitespace and has a newline [INFO] [stderr] 210 | | // then remove it [INFO] [stderr] ... | [INFO] [stderr] 215 | | _ => {} [INFO] [stderr] 216 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 207 | if let &Static(text) = nodes.last().unwrap() { [INFO] [stderr] 208 | // If the previous node is whitespace and has a newline [INFO] [stderr] 209 | // then remove it [INFO] [stderr] 210 | if text.is_whitespace() && text.contains("\n") { [INFO] [stderr] 211 | nodes.pop(); [INFO] [stderr] 212 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/parser.rs:207:25 [INFO] [stderr] | [INFO] [stderr] 207 | / match nodes.last().unwrap() { [INFO] [stderr] 208 | | &Static(text) => { [INFO] [stderr] 209 | | // If the previous node is whitespace and has a newline [INFO] [stderr] 210 | | // then remove it [INFO] [stderr] ... | [INFO] [stderr] 215 | | _ => {} [INFO] [stderr] 216 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 207 | match *nodes.last().unwrap() { [INFO] [stderr] 208 | Static(text) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parser.rs:211:74 [INFO] [stderr] | [INFO] [stderr] 211 | if text.is_whitespace() && text.contains("\n") { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/parser.rs:239:13 [INFO] [stderr] | [INFO] [stderr] 239 | / match unescaped { [INFO] [stderr] 240 | | // Determine if the matching tag is unesecaped or normal. [INFO] [stderr] 241 | | true => { [INFO] [stderr] 242 | | match amp { [INFO] [stderr] ... | [INFO] [stderr] 262 | | } [INFO] [stderr] 263 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 239 | if unescaped { [INFO] [stderr] 240 | match amp { [INFO] [stderr] 241 | true => { [INFO] [stderr] 242 | let mut var = "{{&".to_string(); [INFO] [stderr] 243 | var.push_str(variable); [INFO] [stderr] 244 | var.push_str("}}"); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/parser.rs:242:21 [INFO] [stderr] | [INFO] [stderr] 242 | / match amp { [INFO] [stderr] 243 | | true => { [INFO] [stderr] 244 | | let mut var = "{{&".to_string(); [INFO] [stderr] 245 | | var.push_str(variable); [INFO] [stderr] ... | [INFO] [stderr] 254 | | } [INFO] [stderr] 255 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 242 | if amp { [INFO] [stderr] 243 | let mut var = "{{&".to_string(); [INFO] [stderr] 244 | var.push_str(variable); [INFO] [stderr] 245 | var.push_str("}}"); [INFO] [stderr] 246 | return Unescaped(variable, var); [INFO] [stderr] 247 | } else { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `build::HashBuilder<'a>` [INFO] [stderr] --> src/build.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | / pub fn new() -> HashBuilder<'a> { [INFO] [stderr] 19 | | HashBuilder { [INFO] [stderr] 20 | | data: HashMap::new(), [INFO] [stderr] 21 | | partials_path: "", [INFO] [stderr] 22 | | } [INFO] [stderr] 23 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 9 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `build::VecBuilder<'a>` [INFO] [stderr] --> src/build.rs:106:5 [INFO] [stderr] | [INFO] [stderr] 106 | / pub fn new() -> VecBuilder<'a> { [INFO] [stderr] 107 | | VecBuilder { data: Vec::new() } [INFO] [stderr] 108 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 100 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/template.rs:366:81 [INFO] [stderr] | [INFO] [stderr] 366 | return Err(TemplateErrorType(UnexpectedDataType(format!("{}", [INFO] [stderr] | _________________________________________________________________________________^ [INFO] [stderr] 367 | | val)))) [INFO] [stderr] | |____________________________________________________________________________________________^ help: consider using .to_string(): `val.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rustache`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/parser.rs:50:30 [INFO] [stderr] | [INFO] [stderr] 50 | pub fn parse_nodes<'a>(list: &Vec>) -> Vec> { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Token<'a>]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/parser.rs:55:5 [INFO] [stderr] | [INFO] [stderr] 55 | / loop { [INFO] [stderr] 56 | | // Iterate while still nodes in the list [INFO] [stderr] 57 | | match it.next() { [INFO] [stderr] 58 | | Some((i, token)) => { [INFO] [stderr] ... | [INFO] [stderr] 137 | | } [INFO] [stderr] 138 | | } [INFO] [stderr] | |_____^ help: try: `while let Some((i, token)) = it.next() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/parser.rs:59:17 [INFO] [stderr] | [INFO] [stderr] 59 | / match token { [INFO] [stderr] 60 | | &Text(text) => nodes.push(parse_text_node(text, &mut status)), [INFO] [stderr] 61 | | &Variable(name, raw) => nodes.push(parse_variable_node(name, raw)), [INFO] [stderr] 62 | | &Raw(name, raw) => nodes.push(parse_raw_node(name, raw)), [INFO] [stderr] ... | [INFO] [stderr] 133 | | } [INFO] [stderr] 134 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 59 | match *token { [INFO] [stderr] 60 | Text(text) => nodes.push(parse_text_node(text, &mut status)), [INFO] [stderr] 61 | Variable(name, raw) => nodes.push(parse_variable_node(name, raw)), [INFO] [stderr] 62 | Raw(name, raw) => nodes.push(parse_raw_node(name, raw)), [INFO] [stderr] 63 | Partial(name, raw) => nodes.push(Part(name, raw)), [INFO] [stderr] 64 | // Unopened closing tags are ignored [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/parser.rs:115:33 [INFO] [stderr] | [INFO] [stderr] 115 | / match parse_comment_node(token, &mut status, &mut nodes) { [INFO] [stderr] 116 | | true => { [INFO] [stderr] 117 | | // it.next(); [INFO] [stderr] 118 | | } [INFO] [stderr] 119 | | false => {} [INFO] [stderr] 120 | | } [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/parser.rs:123:33 [INFO] [stderr] | [INFO] [stderr] 123 | / match nodes.last().unwrap() { [INFO] [stderr] 124 | | &Static(text) => { [INFO] [stderr] 125 | | if text.is_whitespace() { [INFO] [stderr] 126 | | nodes.pop(); [INFO] [stderr] ... | [INFO] [stderr] 129 | | _ => continue, [INFO] [stderr] 130 | | } [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 123 | match *nodes.last().unwrap() { [INFO] [stderr] 124 | Static(text) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/parser.rs:150:44 [INFO] [stderr] | [INFO] [stderr] 150 | } else if text.is_whitespace() { [INFO] [stderr] | ____________________________________________^ [INFO] [stderr] 151 | | *status = Skip; [INFO] [stderr] 152 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/parser.rs:148:36 [INFO] [stderr] | [INFO] [stderr] 148 | if text.contains("\n") { [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 149 | | *status = Skip; [INFO] [stderr] 150 | | } else if text.is_whitespace() { [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parser.rs:148:30 [INFO] [stderr] | [INFO] [stderr] 148 | if text.contains("\n") { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parser.rs:160:38 [INFO] [stderr] | [INFO] [stderr] 160 | let dot_notation = name.contains("."); [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/parser.rs:161:5 [INFO] [stderr] | [INFO] [stderr] 161 | / match dot_notation { [INFO] [stderr] 162 | | false => return Value(name, raw.to_string()), [INFO] [stderr] 163 | | true => { [INFO] [stderr] 164 | | let parts: Vec<&str> = name.split(".").collect(); [INFO] [stderr] ... | [INFO] [stderr] 167 | | } [INFO] [stderr] 168 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 161 | if dot_notation { [INFO] [stderr] 162 | let parts: Vec<&str> = name.split(".").collect(); [INFO] [stderr] 163 | let node = handle_dot_notation(&parts[..], false, false); [INFO] [stderr] 164 | return node; [INFO] [stderr] 165 | } else { return Value(name, raw.to_string()) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parser.rs:164:47 [INFO] [stderr] | [INFO] [stderr] 164 | let parts: Vec<&str> = name.split(".").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parser.rs:173:38 [INFO] [stderr] | [INFO] [stderr] 173 | let dot_notation = name.contains("."); [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parser.rs:174:34 [INFO] [stderr] | [INFO] [stderr] 174 | let ampersand = raw.contains("&"); [INFO] [stderr] | ^^^ help: try using a char instead: `'&'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/parser.rs:175:5 [INFO] [stderr] | [INFO] [stderr] 175 | / match dot_notation { [INFO] [stderr] 176 | | false => { [INFO] [stderr] 177 | | return Unescaped(name, raw.to_string()); [INFO] [stderr] 178 | | } [INFO] [stderr] ... | [INFO] [stderr] 191 | | } [INFO] [stderr] 192 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 175 | if dot_notation { [INFO] [stderr] 176 | let parts: Vec<&str> = name.split(".").collect(); [INFO] [stderr] 177 | match ampersand { [INFO] [stderr] 178 | true => { [INFO] [stderr] 179 | let node = handle_dot_notation(&parts[..], true, true); [INFO] [stderr] 180 | return node; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parser.rs:180:47 [INFO] [stderr] | [INFO] [stderr] 180 | let parts: Vec<&str> = name.split(".").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/parser.rs:181:13 [INFO] [stderr] | [INFO] [stderr] 181 | / match ampersand { [INFO] [stderr] 182 | | true => { [INFO] [stderr] 183 | | let node = handle_dot_notation(&parts[..], true, true); [INFO] [stderr] 184 | | return node; [INFO] [stderr] ... | [INFO] [stderr] 189 | | } [INFO] [stderr] 190 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 181 | if ampersand { [INFO] [stderr] 182 | let node = handle_dot_notation(&parts[..], true, true); [INFO] [stderr] 183 | return node; [INFO] [stderr] 184 | } else { [INFO] [stderr] 185 | let node = handle_dot_notation(&parts[..], true, false); [INFO] [stderr] 186 | return node; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser.rs:207:25 [INFO] [stderr] | [INFO] [stderr] 207 | / match nodes.last().unwrap() { [INFO] [stderr] 208 | | &Static(text) => { [INFO] [stderr] 209 | | // If the previous node is whitespace and has a newline [INFO] [stderr] 210 | | // then remove it [INFO] [stderr] ... | [INFO] [stderr] 215 | | _ => {} [INFO] [stderr] 216 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 207 | if let &Static(text) = nodes.last().unwrap() { [INFO] [stderr] 208 | // If the previous node is whitespace and has a newline [INFO] [stderr] 209 | // then remove it [INFO] [stderr] 210 | if text.is_whitespace() && text.contains("\n") { [INFO] [stderr] 211 | nodes.pop(); [INFO] [stderr] 212 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/parser.rs:207:25 [INFO] [stderr] | [INFO] [stderr] 207 | / match nodes.last().unwrap() { [INFO] [stderr] 208 | | &Static(text) => { [INFO] [stderr] 209 | | // If the previous node is whitespace and has a newline [INFO] [stderr] 210 | | // then remove it [INFO] [stderr] ... | [INFO] [stderr] 215 | | _ => {} [INFO] [stderr] 216 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 207 | match *nodes.last().unwrap() { [INFO] [stderr] 208 | Static(text) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parser.rs:211:74 [INFO] [stderr] | [INFO] [stderr] 211 | if text.is_whitespace() && text.contains("\n") { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/parser.rs:239:13 [INFO] [stderr] | [INFO] [stderr] 239 | / match unescaped { [INFO] [stderr] 240 | | // Determine if the matching tag is unesecaped or normal. [INFO] [stderr] 241 | | true => { [INFO] [stderr] 242 | | match amp { [INFO] [stderr] ... | [INFO] [stderr] 262 | | } [INFO] [stderr] 263 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 239 | if unescaped { [INFO] [stderr] 240 | match amp { [INFO] [stderr] 241 | true => { [INFO] [stderr] 242 | let mut var = "{{&".to_string(); [INFO] [stderr] 243 | var.push_str(variable); [INFO] [stderr] 244 | var.push_str("}}"); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/parser.rs:242:21 [INFO] [stderr] | [INFO] [stderr] 242 | / match amp { [INFO] [stderr] 243 | | true => { [INFO] [stderr] 244 | | let mut var = "{{&".to_string(); [INFO] [stderr] 245 | | var.push_str(variable); [INFO] [stderr] ... | [INFO] [stderr] 254 | | } [INFO] [stderr] 255 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 242 | if amp { [INFO] [stderr] 243 | let mut var = "{{&".to_string(); [INFO] [stderr] 244 | var.push_str(variable); [INFO] [stderr] 245 | var.push_str("}}"); [INFO] [stderr] 246 | return Unescaped(variable, var); [INFO] [stderr] 247 | } else { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `build::HashBuilder<'a>` [INFO] [stderr] --> src/build.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | / pub fn new() -> HashBuilder<'a> { [INFO] [stderr] 19 | | HashBuilder { [INFO] [stderr] 20 | | data: HashMap::new(), [INFO] [stderr] 21 | | partials_path: "", [INFO] [stderr] 22 | | } [INFO] [stderr] 23 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 9 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `build::VecBuilder<'a>` [INFO] [stderr] --> src/build.rs:106:5 [INFO] [stderr] | [INFO] [stderr] 106 | / pub fn new() -> VecBuilder<'a> { [INFO] [stderr] 107 | | VecBuilder { data: Vec::new() } [INFO] [stderr] 108 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 100 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/template.rs:366:81 [INFO] [stderr] | [INFO] [stderr] 366 | return Err(TemplateErrorType(UnexpectedDataType(format!("{}", [INFO] [stderr] | _________________________________________________________________________________^ [INFO] [stderr] 367 | | val)))) [INFO] [stderr] | |____________________________________________________________________________________________^ help: consider using .to_string(): `val.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: The function/method `parser::parse_nodes` doesn't need a mutable reference [INFO] [stderr] --> src/template.rs:1051:41 [INFO] [stderr] | [INFO] [stderr] 1051 | let nodes = parser::parse_nodes(&mut tokens); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `parser::parse_nodes` doesn't need a mutable reference [INFO] [stderr] --> src/template.rs:1081:41 [INFO] [stderr] | [INFO] [stderr] 1081 | let nodes = parser::parse_nodes(&mut tokens); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rustache`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "4f1c9bebdedb84c8a806a70c44729c8f640bdbe8bce251ef2d966da0486cf8a0"` [INFO] running `"docker" "rm" "-f" "4f1c9bebdedb84c8a806a70c44729c8f640bdbe8bce251ef2d966da0486cf8a0"` [INFO] [stdout] 4f1c9bebdedb84c8a806a70c44729c8f640bdbe8bce251ef2d966da0486cf8a0